Re: [PATCH] drm/ttm: fix unused function warning

2020-12-08 Thread Martin Peres
unt(struct ttm_pool_type *pt) Move the definition into the #ifdef block. Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") Signed-off-by: Arnd Bergmann Thanks Arnd! The patch looks good to me: Reviewed-by: Martin Peres --- drivers/gpu/drm/ttm/ttm_pool.c | 29 +

Re: [Mesa-dev] [PATCH 4.16 039/110] drm/i915/gen9: Add WaClearHIZ_WM_CHICKEN3 for bxt and glk

2018-05-22 Thread Martin Peres
Sorry for top-posting, but why is this email on mesa-dev, and not on intel-gfx? I mean, the latter is for the kernel driver while the former is the userspace 3d driver, so intel-...@lists.freedesktop.org is definitely the prefered mailing list for these discussions. Martin On 21/05/18 14:11, Greg

Re: [RFC v3 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

2018-01-27 Thread Martin Peres
; @@ -10,6 +10,7 @@ nvkm-y += nvkm/subdev/therm/nv50.o > nvkm-y += nvkm/subdev/therm/g84.o > nvkm-y += nvkm/subdev/therm/gt215.o > nvkm-y += nvkm/subdev/therm/gf119.o > +nvkm-y += nvkm/subdev/therm/gk104.o > nvkm-y += nvkm/subdev/therm/gm107.o > nvkm-y += nvkm/subdev/therm/gm20

Re: [RFC v3 2/4] drm/nouveau: Add support for BLCG on Kepler1

2018-01-27 Thread Martin Peres
bring up the GPU. However, the values used by > the vbios are more power hungry then they need to be, so the nvidia driver then -> than. With the comment about not exposing clock gating until patch 2, 3, and 4 have landed addressed, the series is: Reviewed-by: Martin Peres Thanks a lot!

Re: [RFC 1/4] drm/nouveau: Add support for basic clockgating on Kepler1

2018-01-21 Thread Martin Peres
s/gpu/drm/nouveau/nvkm/subdev/therm/Kbuild > @@ -10,6 +10,7 @@ nvkm-y += nvkm/subdev/therm/nv50.o > nvkm-y += nvkm/subdev/therm/g84.o > nvkm-y += nvkm/subdev/therm/gt215.o > nvkm-y += nvkm/subdev/therm/gf119.o > +nvkm-y += nvkm/subdev/therm/gk104.o > nvkm-y += nvkm/subdev/therm

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-28 Thread Martin Peres
On 27/07/17 10:36, Tomi Sarvela wrote: On 26/07/17 17:26, Thomas Gleixner wrote: On Wed, 26 Jul 2017, Martin Peres wrote: On 25/07/17 10:01, Tomi Sarvela wrote: On 24/07/17 19:37, Martin Peres wrote: On 24/07/17 19:35, Thomas Gleixner wrote: On Mon, 24 Jul 2017, Martin Peres wrote: On 24

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-26 Thread Martin Peres
On 25/07/17 10:01, Tomi Sarvela wrote: On 24/07/17 19:37, Martin Peres wrote: On 24/07/17 19:35, Thomas Gleixner wrote: On Mon, 24 Jul 2017, Martin Peres wrote: On 24/07/17 18:28, Thomas Gleixner wrote: Output of 'cat /proc/interrupts' and a description what kind of 'old&#

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-24 Thread Martin Peres
On 24/07/17 19:35, Thomas Gleixner wrote: On Mon, 24 Jul 2017, Martin Peres wrote: On 24/07/17 18:28, Thomas Gleixner wrote: Output of 'cat /proc/interrupts' and a description what kind of 'old' Intel platform that is. Sorry, I should have repeated the name outside of jus

Re: Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-24 Thread Martin Peres
On 24/07/17 18:28, Thomas Gleixner wrote: On Mon, 24 Jul 2017, Martin Peres wrote: I am contacting you because your patch "bf22ff45b genirq: Avoid unnecessary low level irq function calls" broke suspend/resume on an old Intel platform. This was not caught in linux-next and only got

Suspend-resume failure on Intel Eagle Lake Core2Duo

2017-07-24 Thread Martin Peres
Hello, I am contacting you because your patch "bf22ff45b genirq: Avoid unnecessary low level irq function calls" broke suspend/resume on an old Intel platform. This was not caught in linux-next and only got introduced in linux 4.13-rc1. Here is the current place where the bug has been report

Re: [Nouveau] [PATCH] drm/nouveau/therm: fix spelling mistake on array thresolds

2017-06-27 Thread Martin Peres
On 27/06/17 11:08, Colin King wrote: From: Colin Ian King Array thresolds should be named thresholds, rename it. Also make it static static const char * const Signed-off-by: Colin Ian King Thanks for doing this, Reviewed-by: Martin Peres --- drivers/gpu/drm/nouveau/nvkm/subdev/therm

Re: [PATCH] drm/nouveau: fix LEDS_CLASS=m configuration

2016-11-08 Thread Martin Peres
On 08/11/16 15:56, Arnd Bergmann wrote: The newly introduced LED handling for nouveau fails to link when the driver is built-in but the LED subsystem is a loadable module: drivers/gpu/drm/nouveau/nouveau.o: In function `nouveau_do_suspend': tvnv17.c:(.text.nouveau_do_suspend+0x10): undefined ref

Re: [PATCH] drm/nouveau/nvbios/iccsense: fix semicolon.cocci warnings

2016-04-13 Thread Martin Peres
On 13/04/16 08:13, kbuild test robot wrote: drivers/gpu/drm/nouveau/nvkm/subdev/bios/iccsense.c:96:3-4: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Martin Peres Signed-off-by: Fengguang Wu Signed-off-by: Martin Peres

Re: [PATCH] drm/nouveau/iccsense: fix ifnullfree.cocci warnings

2016-04-13 Thread Martin Peres
ned-off-by: Fengguang Wu Signed-off-by: Martin Peres

Re: [RESEND PATCH nouveau 3/3] volt: add support for GK20A

2014-12-01 Thread Martin Peres
ne to add that to the DT. If it was not the case, it is still easier to move to the DT instead of doing the opposite. Acked-by: Martin Peres -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordom

Re: [RESEND PATCH nouveau 2/3] volt: allow non-bios voltage scaling

2014-12-01 Thread Martin Peres
call it conditionally if the platform has a vbios. Non-vbios platforms can use the ctor() to init the data structures.". At the very least this patch makes the code easier to read, so: Acked-by: Alexandre Courbot Acked-by: Martin Peres -- To unsubscribe from this list: send the line &q

Re: [PATCH 0/3] drm/gk20a: support for reclocking

2014-07-11 Thread Martin Peres
On 11/07/2014 03:42, Alexandre Courbot wrote: On 07/10/2014 06:50 PM, Mikko Perttunen wrote: Does GK20A itself have any kind of thermal protection capabilities? Upstream SOCTHERM support is not yet available (though I have a driver in my tree), so we are thinking of disabling CPU DVFS on boards

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Martin Peres
Le 23/06/2014 19:56, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 1:46 PM, Martin Peres wrote: Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list of valid "values" that

Re: unparseable, undocumented /sys/class/drm/.../pstate

2014-06-23 Thread Martin Peres
Le 23/06/2014 18:40, Ilia Mirkin a écrit : On Mon, Jun 23, 2014 at 12:36 PM, Greg KH wrote: On Mon, Jun 23, 2014 at 12:18:51PM -0400, Ilia Mirkin wrote: A list of valid "values" that a file can be in is fine if you just then write one value back to that file. That's the one exception, but a mi

Re: [PATCH] dma-buf: Expose buffer size to userspace (v2)

2013-09-04 Thread Martin Peres
Le 04/09/2013 14:05, Daniel Vetter a écrit : On Wed, Sep 04, 2013 at 12:24:27PM +0200, Martin Peres wrote: Hi Christopher, Le 04/09/2013 05:15, Christopher James Halse Rogers a écrit : Each dma-buf has an associated size and it's reasonable for userspace to want to know what it is.

Re: [PATCH] dma-buf: Expose buffer size to userspace (v2)

2013-09-04 Thread Martin Peres
Hi Christopher, Le 04/09/2013 05:15, Christopher James Halse Rogers a écrit : Each dma-buf has an associated size and it's reasonable for userspace to want to know what it is. Since userspace already has an fd, expose the size using the size = lseek(fd, SEEK_END, 0); lseek(fd, SEEK_CUR, 0); idio

Re: nouveau: temperature on nv40 is unavailable since ad40d73ef533ab0ad16b4a1ab2f7870c1f8ab954

2013-08-21 Thread Martin Peres
On 16/08/2013 09:14, Pali Rohár wrote: On Thursday 15 August 2013 18:21:51 Martin Peres wrote: On 15/08/2013 03:24, Pali Rohár wrote: On Thursday 15 August 2013 04:07:24 Martin Peres wrote: On 14/08/2013 05:02, Pali Rohár wrote: On Tuesday 13 August 2013 15:55:28 Martin Peres wrote: On 13

Re: [PATCH] nouveau reclocking on nv40 not working since 77145f1cbdf8d28b46ff8070ca749bad821e0774

2013-08-16 Thread Martin Peres
On 16/08/2013 03:16, Pali Rohár wrote: On Thursday 15 August 2013 18:23:06 Martin Peres wrote: On 15/08/2013 13:46, Pali Rohár wrote: On Tuesday 13 August 2013 11:28:01 Pali Rohár wrote: Hello, in commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was introduced error which cause that on my

Re: [PATCH] nouveau reclocking on nv40 not working since 77145f1cbdf8d28b46ff8070ca749bad821e0774

2013-08-15 Thread Martin Peres
On 15/08/2013 13:46, Pali Rohár wrote: On Tuesday 13 August 2013 11:28:01 Pali Rohár wrote: Hello, in commit 77145f1cbdf8d28b46ff8070ca749bad821e0774 was introduced error which cause that on my Nvidia 6600GT card reclocking not working anymore. There is missing assigment of return value from pl

Re: nouveau: temperature on nv40 is unavailable since ad40d73ef533ab0ad16b4a1ab2f7870c1f8ab954

2013-08-15 Thread Martin Peres
On 15/08/2013 03:24, Pali Rohár wrote: On Thursday 15 August 2013 04:07:24 Martin Peres wrote: On 14/08/2013 05:02, Pali Rohár wrote: On Tuesday 13 August 2013 15:55:28 Martin Peres wrote: On 13/08/2013 09:53, Pali Rohár wrote: On utorok, 13. augusta 2013 15:32:45 CEST, Martin Peres wrote

Re: nouveau: temperature on nv40 is unavailable since ad40d73ef533ab0ad16b4a1ab2f7870c1f8ab954

2013-08-14 Thread Martin Peres
On 14/08/2013 05:02, Pali Rohár wrote: On Tuesday 13 August 2013 15:55:28 Martin Peres wrote: On 13/08/2013 09:53, Pali Rohár wrote: On utorok, 13. augusta 2013 15:32:45 CEST, Martin Peres wrote: On 13/08/2013 09:23, Pali Rohár wrote: On Tuesday 13 August 2013 09:01:19 Martin Peres wrote

Re: nouveau: temperature on nv40 is unavailable since ad40d73ef533ab0ad16b4a1ab2f7870c1f8ab954

2013-08-13 Thread Martin Peres
On 13/08/2013 09:53, Pali Rohár wrote: On utorok, 13. augusta 2013 15:32:45 CEST, Martin Peres wrote: On 13/08/2013 09:23, Pali Rohár wrote: On Tuesday 13 August 2013 09:01:19 Martin Peres wrote: ... You can check the temperature by running nvidia-settings. If you can't see the temper

Re: nouveau: temperature on nv40 is unavailable since ad40d73ef533ab0ad16b4a1ab2f7870c1f8ab954

2013-08-13 Thread Martin Peres
On 13/08/2013 09:23, Pali Rohár wrote: On Tuesday 13 August 2013 09:01:19 Martin Peres wrote: On 13/08/2013 05:56, Pali Rohár wrote: Hello, after commit ad40d73ef533ab0ad16b4a1ab2f7870c1f8ab954 temperature information from lm sensors is not available on my Nvidia 6600GT graphics card. There

Re: nouveau shuts the machine down with v3.9-rc1 (temperature (72 C) hit the 'shutdown' threshold).

2013-03-11 Thread Martin Peres
On 11/03/2013 13:38, Konrad Rzeszutek Wilk wrote: With that I am still getting the issues (even with an insance delay of 100 seconds). Here is the serial log with various runs. Any thoughts? Sorry for taking so long to answer but I got a one-week flu and still had to do my research duties :s

Re: nouveau shuts the machine down with v3.9-rc1 (temperature (72 C) hit the 'shutdown' threshold).

2013-03-04 Thread Martin Peres
Hi Konrad, On 04/03/2013 19:40, Konrad Rzeszutek Wilk wrote:> After git merge ab7826595e9ec51a51f622c5fc91e2f59440481a > (Merge tag 'mfd-3.9-1' of git://git.kernel.org/pub/scm/linux/kernel/git/sameo/mfd-2.6) > the nouveau driver ends up shutting of the machine when booting. > > > I hadn't done

Re: Linux 3.7-rc1 (nouveau_bios_score oops).

2012-10-20 Thread Martin Peres
rom f09d58dc23a6e48ed56a1d9bf803f800f0c59e83 Mon Sep 17 00:00:00 2001 From: Martin Peres Date: Sat, 20 Oct 2012 11:03:36 +0200 Subject: [PATCH] drm/nouveau/bios: improve error handling when reading the vbios from ACPI Reported-by: Pawel Sikora Signed-off-by: Martin Peres --- drivers/gpu/drm/nouveau/core/subdev/bios/bas