Re: [PATCH] RDMA/addr: potential uninitialized variable in ib_nl_process_good_ip_rsep()

2021-04-04 Thread Mark Bloch
On 4/4/21 1:33 PM, Leon Romanovsky wrote: > On Fri, Apr 02, 2021 at 02:47:23PM +0300, Dan Carpenter wrote: >> The nla_len() is less than or equal to 16. If it's less than 16 then >> end of the "gid" buffer is uninitialized. >> >> Fixes: ae43f8286730 ("IB/core: Add IP to GID netlink offload") >> Si

Re: [PATCH 1/2] IB/sa: Resolving use-after-free in ib_nl_send_msg.

2020-05-07 Thread Mark Bloch
On 5/7/2020 13:16, Wan, Kaike wrote: > > >> -Original Message----- >> From: Mark Bloch >> Sent: Thursday, May 07, 2020 3:36 PM >> To: Divya Indi ; linux-kernel@vger.kernel.org; linux- >> r...@vger.kernel.org; Jason Gunthorpe ; Wan, Kaike >> >

Re: [PATCH 1/2] IB/sa: Resolving use-after-free in ib_nl_send_msg.

2020-05-07 Thread Mark Bloch
On 5/7/2020 11:34, Divya Indi wrote: > This patch fixes commit - > commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before > sending")' > > Above commit adds the query to the request list before ib_nl_snd_msg. > > However, if there is a delay in sending out the request (

Re: [PATCH 2/4] mdev: Make mdev alias unique among all mdevs

2019-08-26 Thread Mark Bloch
On 8/26/19 1:41 PM, Parav Pandit wrote: > Mdev alias should be unique among all the mdevs, so that when such alias > is used by the mdev users to derive other objects, there is no > collision in a given system. > > Signed-off-by: Parav Pandit > --- > drivers/vfio/mdev/mdev_core.c | 5 + >

Re: [PATCH net-next, 5/6] net/mlx5: Add HV VHCA control agent

2019-08-14 Thread Mark Bloch
On 8/14/19 12:09 PM, Haiyang Zhang wrote: > From: Eran Ben Elisha > > Control agent is responsible over of the control block (ID 0). It should > update the PF via this block about every capability change. In addition, > upon block 0 invalidate, it should activate all other supported agents > wi

Re: [PATCH net-next, 4/6] net/mlx5: Add HV VHCA infrastructure

2019-08-14 Thread Mark Bloch
On 8/14/19 12:08 PM, Haiyang Zhang wrote: > From: Eran Ben Elisha > > HV VHCA is a layer which provides PF to VF communication channel based on > HyperV PCI config channel. It implements Mellanox's Inter VHCA control > communication protocol. The protocol contains control block in order to > pa

Re: [PATCH net-next, 3/6] net/mlx5: Add wrappers for HyperV PCIe operations

2019-08-14 Thread Mark Bloch
On 8/14/19 12:08 PM, Haiyang Zhang wrote: > From: Eran Ben Elisha > > Add wrapper functions for HyperV PCIe read / write / > block_invalidate_register operations. This will be used as an > infrastructure in the downstream patch for software communication. > > This will be enabled by default i

Re: [PATCH v3] RDMA/core: Fix race when resolving IP address

2019-07-08 Thread Mark Bloch
On 7/8/19 11:47 AM, Dag Moxnes wrote: > Thanks Jason, > > Regards, > Dag > > Den 08.07.2019 19:50, skrev Jason Gunthorpe: >> On Mon, Jul 08, 2019 at 01:16:24PM +0200, Dag Moxnes wrote: >>> Use neighbour lock when copying MAC address from neighbour data struct >>> in dst_fetch_ha. >>> >>> When n

Re: [PATCH] net/mlx5e: reduce stack usage in mlx5_eswitch_termtbl_create

2019-06-17 Thread Mark Bloch
On 6/17/19 11:02 AM, Saeed Mahameed wrote: > On Mon, 2019-06-17 at 13:08 +0200, Arnd Bergmann wrote: >> Putting an empty 'mlx5_flow_spec' structure on the stack is a bit >> wasteful and causes a warning on 32-bit architectures when building >> with clang -fsanitize-coverage: >> >> drivers/net/eth

Re: general protection fault in rdma_listen (2)

2019-04-09 Thread Mark Bloch
On 4/9/19 6:57 AM, Dmitry Vyukov wrote: > On Fri, Nov 16, 2018 at 6:44 PM syzbot > wrote: >> >> syzbot has found a reproducer for the following crash on: >> >> HEAD commit:da5322e65940 Merge tag 'selinux-pr-20181115' of git://git... >> git tree: upstream >> console output: https://syzk

Re: [PATCH] ib umem: bug: put pid back before return from error path

2016-12-22 Thread Mark Bloch
Hi, You have two bugs here: 1) When using ODP, ib_umem_release() checks for umem->odp_data != NULL calls ib_umem_odp_release() and returns immediately without calling put_pid(). This one isn't in the error path so the title doesn't fit. 2) In case the allocation failed, we return in -ENOM