On Wednesday, July 06, 2016 10:49:29 kbuild test robot wrote:
> net/batman-adv/bridge_loop_avoidance.c:1105:9-10: WARNING: return of 0/1 in
> function 'batadv_bla_process_claim' with return type bool
>
> Return statements in functions returning bool should use
> true/false instead of 1/0.
> Gene
On Friday, December 18, 2015 23:33:31 Geliang Tang wrote:
> Use list_for_each_entry_safe() instead of list_for_each_safe() to
> simplify the code.
>
> Signed-off-by: Geliang Tang
> ---
> net/batman-adv/icmp_socket.c | 22 +-
> 1 file changed, 9 insertions(+), 13 deletions(-)
On Monday, December 28, 2015 23:43:37 Geliang Tang wrote:
> Use to_delayed_work() instead of open-coding it.
>
> Signed-off-by: Geliang Tang
> ---
> net/batman-adv/bridge_loop_avoidance.c | 2 +-
> net/batman-adv/distributed-arp-table.c | 2 +-
> net/batman-adv/network-coding.c| 2 +-
>
On Sunday, November 15, 2015 09:43:26 SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 15 Nov 2015 08:04:43 +0100
>
> The kfree_skb() function tests whether its argument is NULL and then
> returns immediately. Thus the test around the calls is not needed.
>
> This issue was detected
On Tuesday, November 03, 2015 21:52:58 SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 3 Nov 2015 19:20:34 +0100
>
> The batadv_softif_vlan_free_ref() function tests whether its argument is
> NULL and then returns immediately. Thus the test around the call is not
> needed.
>
> This
On Sunday, November 15, 2015 09:45:51 SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Sun, 15 Nov 2015 09:00:42 +0100
>
> * Let us return directly if a call of the batadv_orig_hash_find() function
> returned a null pointer.
>
> * Omit the initialisation for the variable "skb" at the be
On Tuesday, November 03, 2015 21:54:35 SF Markus Elfring wrote:
> From: Markus Elfring
> Date: Tue, 3 Nov 2015 20:41:02 +0100
>
> Let us split a check for a condition at the beginning of the
> batadv_is_ap_isolated() function so that a direct return can be performed
> in this function if the vari
On Thursday, February 19, 2015 11:55:41 Joe Perches wrote:
> > Can you make a suggestion / patch for checkpatch to better handle this
> > case ?
> The "sizeof" test in the current script doesn't work.
>
> I believe the patch below works with no false positives
> but it's perl regexes against odd
Hi Joe,
we have come across a checkpatch false-positive:
static void batadv_recv_handler_init(void)
{
int i;
for (i = 0; i < ARRAY_SIZE(batadv_rx_handler); i++)
batadv_rx_handler[i] = batadv_recv_unhandled_packet;
for (i = BATADV_UNICAST_MIN; i <= B
On Saturday, February 23, 2013 02:37:06 Sasha Levin wrote:
> I'm confused about how batadv_orig_hash_del_if removes an interface from
> the hashtable. I see the hashtable is using rcu to protect it, but when we
> delete an entry we free it straight away by calling
> batadv_orig_node_del_if() and no
On Tuesday, December 25, 2012 19:30:36 Antonio Quartulli wrote:
> On Mon, Dec 24, 2012 at 11:14:07AM +0900, Akinobu Mita wrote:
> > Use more preferable function name which implies using a pseudo-random
> > number generator.
> >
> > Signed-off-by: Akinobu Mita
> >
On Tuesday, December 25, 2012 03:36:36 Marek Lindner wrote:
> > >> > empty, this assumption is wrong:
> > >> Why isn't this patch part of Linux 3.7? It seems to be a bugfix and it
> > >> was sent early enough?
> > >
> > > Th
On Monday, December 24, 2012 23:42:15 Pau Koning wrote:
> On Mon, Dec 24, 2012 at 3:38 PM, Marek Lindner
wrote:
> > On Monday, December 24, 2012 22:18:52 Pau Koning wrote:
> >> On Mon, Nov 19, 2012 at 9:08 PM, Sasha Levin
wrote:
> >> > The code that works with
On Monday, December 24, 2012 22:18:52 Pau Koning wrote:
> On Mon, Nov 19, 2012 at 9:08 PM, Sasha Levin wrote:
> > The code that works with routing_algo assumes that the string passed is
> > non
>
> > empty, this assumption is wrong:
> Why isn't this patch part of Linux 3.7? It seems to be a bugfi
On Tuesday, November 13, 2012 09:53:26 Shan Wei wrote:
> From: Shan Wei
>
> this_cpu_add is an atomic operation.
> and be more faster than per_cpu_ptr operation.
>
> Signed-off-by: Shan Wei
> Reviewed-by: Christoph Lameter
> ---
> v4: no changes vs v3.
> ---
> net/batman-adv/main.h |4 +--
15 matches
Mail list logo
