Re: [PATCH V4] clk: at91: PLL recalc_rate() now using cached MUL and DIV values

2018-05-08 Thread Marcin Ziemianowicz
On Mon, Apr 30, 2018 at 07:58:47AM +0200, Boris Brezillon wrote: > On Sun, 29 Apr 2018 15:01:11 -0400 > Marcin Ziemianowicz wrote: > > > When a USB device is connected to the USB host port on the SAM9N12 then > > you get "-62" error which seems to indicate USB

[PATCH V4] clk: at91: PLL recalc_rate() now using cached MUL and DIV values

2018-04-29 Thread Marcin Ziemianowicz
he past by 87e2ed338f1b ("clk: at91: fix recalc_rate implementation of PLL driver") but the bug was later re-introduced by 1bdf02326b71 ("clk: at91: make use of syscon/regmap internally"). Fixes: 1bdf02326b71 ("clk: at91: make use of syscon/regmap internally) Cc: Signed-off-by: Mar

Re: [PATCH v3] clk: at91: PLL recalc_rate() now using cached MUL+DIV values

2018-04-29 Thread Marcin Ziemianowicz
On Sun, Apr 29, 2018 at 03:19:35PM +0200, Boris Brezillon wrote: > On Sun, 29 Apr 2018 15:17:10 +0200 > Boris Brezillon wrote: > > > Hi Marcin, > > > > On Fri, 27 Apr 2018 13:56:09 -0400 > > Marcin Ziemianowicz wrote: > > > > > Stephen Boyd ,

Re: [PATCH v3] clk: at91: PLL recalc_rate() now using cached MUL+DIV values

2018-04-29 Thread Marcin Ziemianowicz
On Sun, Apr 29, 2018 at 03:17:10PM +0200, Boris Brezillon wrote: > Hi Marcin, > > On Fri, 27 Apr 2018 13:56:09 -0400 > Marcin Ziemianowicz wrote: > > > Stephen Boyd , > > linux-...@vger.kernel.org, > > linux-arm-ker...@lists.infradead.org, > > linux-kerne

[PATCH v3] clk: at91: PLL recalc_rate() now using cached MUL+DIV values

2018-04-27 Thread Marcin Ziemianowicz
g lines addressed Signed-off-by: Marcin Ziemianowicz --- drivers/clk/at91/clk-pll.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/clk/at91/clk-pll.c b/drivers/clk/at91/clk-pll.c index 7d3223fc..cc6e0364 100644 --- a/drivers/clk/at91/clk-pll.c +++ b/drive

[PATCH v2 2/2] clk: at91: Fix for PLL set_rate changes not being actually written to PLL peripheral bits

2018-04-09 Thread Marcin Ziemianowicz
actually being adjusted. Writing the multiplier and divider values to the peripheral fixes the bus running at half speed. Signed-off-by: Marcin Ziemianowicz --- drivers/clk/at91/clk-pll.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/clk/at91/clk-pll.c b/drivers/clk/at91/

[PATCH v2 1/2] clk: at91: Added more information logging.

2018-04-09 Thread Marcin Ziemianowicz
I noticed that when debugging some USB clocking issue that there weren't many ways to tell what the state of the USB clocking system was. This adds a few logging statements to see what the relevant code is trying to do. Signed-off-by: Marcin Ziemianowicz --- drivers/clk/at91/clk-pll.c

[PATCH v2 0/2] clk: at91: Added more information logging

2018-04-09 Thread Marcin Ziemianowicz
This is a series of patches which resolves set_rate() for the PLL not having any effect and therefore the USB Host port not working. Also, a few messages were added which may be helpful in the future when others are working with USB clocking. Changes since V1: Added patch set cover letter Shor

Re: [PATCH 1/2] clk: at91: Added more information logging.

2018-04-08 Thread Marcin Ziemianowicz
This > > adds a few logging statements to see what the relevant code is trying to > > do. > > > > Signed-off-by: Marcin Ziemianowicz > > Your "From:" line doesn't match this name :( Ah drat, I knew I did something wrong. You suggested in IRC that I wait a