Re: [PATCH] atmel_spi: support zero length transfer

2008-02-25 Thread Marc Pignat
On Saturday 23 February 2008, David Brownell wrote: ... > No, it's fully defined. "Crash my engine" is not OK. The delay > is controlled by transfer.delay_usecs ... possibly zero, which is > best viewed as a degenerate case. Ooops, I missed that (the delay *is* defined in transfer.delay_usecs). S

Re: [PATCH] atmel_spi: support zero length transfer

2008-02-22 Thread Marc Pignat
Hi Dave! On Thursday 21 February 2008, David Brownell wrote: > > David, do you think writing 0 bytes is a valid use of this API? > > Just a zero byte transfer ... no, though it depends what you mean > by "valid". (I'm not sure I'd expect all controller drivers to > reject such requests.) That h

Re: [PATCH] atmel_spi: support zero length transfer

2008-02-21 Thread Marc Pignat
Hi! On Thursday 21 February 2008, Atsushi Nemoto wrote: ... > Yes. I tested it on AT91SAM9260 and it seems ENDRX rises soon. > Though it can be possible to avoid starting DMA for zero length > transfer, I think it is not worth to optimize for such a rare case. Ok, verified to work on at91rm9200,

Re: [PATCH] atmel_spi: support zero length transfer

2008-02-20 Thread Marc Pignat
Hi! On Wednesday 20 February 2008, you wrote: > A spi transfer with zero length is not invalid. Such transfer can be > used to achieve delay before first CLK edge after chipselect assertion. How long will be that delay? If they are really users of that kind of thing, this should be fixed by addi

Re: [PATCH] at91_mci: use generic GPIO calls

2008-02-05 Thread Marc Pignat
Hi all! On Monday 04 February 2008, Nicolas Ferre wrote: > From: David Brownell <[EMAIL PROTECTED]> ... > /* > @@ -946,9 +986,10 @@ static int __exit at91_mci_remove(struct > host = mmc_priv(mmc); > > if (host->board->det_pin) { > + if (device_can_wakeup(&pdev->dev)) > +

Re: [PATCH -mm v4 0/9] atmel_serial cleanups and improvements

2008-01-24 Thread Marc Pignat
Tested and working on at91rm9200 using 2.6.24-rc8, in one word... ack. Regards Marc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [PATCH 6/6] atmel_serial: Add DMA support

2008-01-23 Thread Marc Pignat
On Wednesday 23 January 2008, Haavard Skinnemoen wrote: > On Wed, 23 Jan 2008 14:18:38 +0100 ... > GFP_DMA doesn't have anything to do with alignment, AFAIK. I don't even know if it does something for at91 or avr32, but there is a flag for dma memory, so we should use it. ... > No, please don't. I

Re: [PATCH 6/6] atmel_serial: Add DMA support

2008-01-23 Thread Marc Pignat
Hi! On Wednesday 23 January 2008, Haavard Skinnemoen wrote: > On Wed, 23 Jan 2008 13:30:32 +0100 > Marc Pignat <[EMAIL PROTECTED]> wrote: > > On Wednesday 23 January 2008, Haavard Skinnemoen wrote: ... > > Ok, but then any power of two larger than the cache line size sh

Re: [PATCH 6/6] atmel_serial: Add DMA support

2008-01-23 Thread Marc Pignat
Hi! On Wednesday 23 January 2008, Haavard Skinnemoen wrote: > On Tue, 22 Jan 2008 17:52:43 +0100 > Marc Pignat <[EMAIL PROTECTED]> wrote: > > > Hi! > > > > I removed [EMAIL PROTECTED] from cc, it is a > > subscriber-only list. > > Right. Does th

Re: [PATCH 6/6] atmel_serial: Add DMA support

2008-01-22 Thread Marc Pignat
Hi! I removed [EMAIL PROTECTED] from cc, it is a subscriber-only list. On Tuesday 22 January 2008, Haavard Skinnemoen wrote: > From: Chip Coldwell <[EMAIL PROTECTED]> ... > @@ -47,6 +50,11 @@ > > #include "atmel_serial.h" > > +#define SUPPORT_PDC > +#define PDC_BUFFER_SIZE (L1_C

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Marc Pignat
On Monday 14 January 2008, Florian Fainelli wrote: > Le lundi 14 janvier 2008, Marc Pignat a écrit : > > Hi Florian! > > I understand your wish, but... > > You told me that your plaform doesn't implement the generic gpio interface > > (yet?), so this driver can

Re: [RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Marc Pignat
Hi Florian! On Monday 14 January 2008, Florian Fainelli wrote: ... > I would like this function to be supplied by the platform_data structure > because as I mentioned before, not all GPIO connected watchdog will simply > need a single bit to be toggled, but also sometimes a full GPIO line. I und

[RFC, PATCH, take 2] watchdog on generic gpio

2008-01-14 Thread Marc Pignat
watchdog driver for embedded systems with a supervisor watchdog (MAX823 or so) connected to a gpio. This is the platform_driver and needs platform_data for defining the gpio pin and the watchdog timeout. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- Hi! Changes form take1: * cor

Re: [RFC, PATCH] watchdog on gpio

2008-01-13 Thread Marc Pignat
On Friday 11 January 2008, Florian Fainelli wrote: > Hello Marc, > > Your patch looks good to me, and I have been waiting for something like > this :). Other comments below. > > Le jeudi 10 janvier 2008, Marc Pignat a écrit : > > +#include > > +#include >

[RFC, PATCH] watchdog on gpio

2008-01-10 Thread Marc Pignat
watchdog driver for embedded systems with a supervisor watchdog (MAX823 or so) connected to a gpio. This is the platform_driver and needs platform_data for defining the gpio pin and the watchdog timeout. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- Hi! If you've got a max823,

Re: [RFC, PATCH] sdio: move temporary buffer

2007-12-19 Thread Marc Pignat
On Wednesday 19 December 2007, Pierre Ossman wrote: > On Wed, 19 Dec 2007 11:55:25 +0100 ... > This is still voodoo to me, so I'll have to take your word for it. :) And almost voodoo to me... this is why I hope an ack from a DMA mentor! Marc -- To unsubscribe from this list: send the line "unsubsc

[RFC, PATCH] sdio: move temporary buffer

2007-12-19 Thread Marc Pignat
Move the temporary buffer used by some sdio functions from sdio_func struct to the mmc_host struct and make it dma-safe. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- There is no need to have this temporary buffer in every sdio_func, since all access to it are serialized by sdio_

Re: [PATCH] zd1211rw, fix oops when ejecting install media

2007-10-15 Thread Marc Pignat
Hi all! On Monday 15 October 2007, Daniel Drake wrote: ... > Acked-by: Daniel Drake <[EMAIL PROTECTED]> Is there any hope to apply this to 2.6.23.2, as this is a regression fix? Regards Marc - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [E

[PATCH] zd1211rw, fix oops when ejecting install media

2007-10-15 Thread Marc Pignat
The disconnect function can dereference the net_device structure before it is allocated. This is the case when ejecting the device installer. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- Hello! Patch against 2.6.23. This patch fixes the bug I've submitted to linux-wireless fr

Re: [PATCH] at91 pm: Compilation fix for at91sam926x

2007-08-10 Thread Marc Pignat
On Friday 10 August 2007 09:12, Hans-Jürgen Koch wrote: > Am Freitag 10 August 2007 00:15 schrieb Ulf Samuelsson: > > > > > > +#if defined(CONFIG_ARCH_AT91RM9200) > > > > at91_sys_write(AT91_SDRAMC_SRR, 1); /* > > > > self-refresh mode */ > > > > > Why don't use: > > >

Re: [PATCH] at91 pm: Compilation fix for at91sam926x

2007-08-09 Thread Marc Pignat
Hello! On Thursday 09 August 2007 16:53, Hans-Jürgen Koch wrote: > (added linux-arm-kernel to CC) > > Am Donnerstag 09 August 2007 14:10 schrieb Andy Herzig: > > Hello all, > > > > This patch is intended to fix compilation errors when I tried to add in > > power management to my Atmel AT91SAM926

Re: [PATCH] mmc: at91_mci: fix hanging and rework to match flowcharts

2007-07-02 Thread Marc Pignat
On Monday 02 July 2007 14:16, Nicolas Ferre wrote: > Fixes hanging using multi block operations (seen during CMD25). > Signed-off-by: Nicolas Ferre <[EMAIL PROTECTED]> Verified working on at91rm9200 using 1 wire mode. A small remark, only for future improvements: > @@ -817,7 +834,11 @@ static int

[BUG] clockevents : clockevent_delta2ns usage

2007-07-02 Thread Marc Pignat
Hello all! We're currently working with David Brownell and Remy Bohmer on implementation of clocksource/events on the at91rm9200 processor (arm arch). While debugging our implementation, we came about a rounding problem, in the setting of min_delta_ns field, and I think it can be in almost all c

Re: [PATCH] mmc-atmel : fix kunmap wrong usage

2007-06-22 Thread Marc Pignat
On Friday 22 June 2007 15:34, Nicolas Ferre wrote: > Hugh Dickins : > Here: > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=b9bae3402572dc50a1e084c5b1ae5117918ef0f0 > > > But it would be good to hear from Nicolas whether that indeed fixes > > his oops: I couldn't

Re: [PATCH] mmc-atmel : fix kunmap wrong usage

2007-06-22 Thread Marc Pignat
On Friday 22 June 2007 15:34, Nicolas Ferre wrote: > Hugh Dickins : > > Aren't you just guessing there? Those kunmap_atomics in at91_mci.c > > may look wrong to you, but they're not incorrect (so long as sg->offset > > falls within the page, as it must do here to make sense of the page). > > Espec

[PATCH] mmc-atmel : fix kunmap wrong usage

2007-06-21 Thread Marc Pignat
from: Marc Pignat <[EMAIL PROTECTED]> kunmap must be called on the pointer returned by kmap. Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- N.B: This is the same patch as yesterday, with proper Signed-off-by and more comments. The buffer variable is used this way:

Re: Oops in a driver while using SLUB as a SLAB allocator

2007-06-21 Thread Marc Pignat
please use this patch, sorry for the later Regards Marc --- drivers/mmc/host/at91_mci.c-2.6.22-rc5.orig 2007-06-21 16:27:31.0 +0200 +++ drivers/mmc/host/at91_mci.c-2.6.22-rc5 2007-06-21 16:42:48.0 +0200 @@ -164,7 +164,7 @@ static inline void at91mci_sg_to_dma(str

Re: Oops in a driver while using SLUB as a SLAB allocator

2007-06-21 Thread Marc Pignat
Hello Nicolas! Good news! I think I've found the problem, this seems to work (tested with SLUB and SLAB). If you're in the cleanup stage, I think the whole kmap and kunmap can be in the 'if (cpu_is_at91rm9200())', we have no reason to kmap data we don't touch :-D Regards Marc --- drivers/mmc

[PATCH] at91: fix enable/disable_irq_wake symmetry in pcmcia driver

2007-05-10 Thread Marc Pignat
from Marc Pignat <[EMAIL PROTECTED]> fix enable_irq_wake and disable_irq_wake symmetry in at91 pcmcia driver Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- This patch applies to the 2.6.21.1 kernel. disable_irq_wake call must be symmetric with enable_irq_wake. This patch fix

[PATCHv2] at91: fix enable/disable_irq_wake symmetry in pcmcia driver

2007-05-10 Thread Marc Pignat
from Marc Pignat <[EMAIL PROTECTED]> fix enable_irq_wake and disable_irq_wake symmetry in at91 pcmcia driver Signed-off-by: Marc Pignat <[EMAIL PROTECTED]> --- Please forget the [PATCH] at91: fix enable/disable_irq_wake symmetry in pcmcia driver, it doesn't compile... Here