Re: [PATCH] xilinx: Fix compiler warning

On So, 2014-06-22 at 15:15 +0400, Sergei Shtylyov wrote: > Hello. > > On 06/22/2014 02:21 PM, Manuel Schölling wrote: > > > The time comparsion functions require arguments of type unsigned long > > instead of (signed) long. > > > Signed-off-by: Manuel Schölling > > [...] > > > diff --git a/in

Re: [PATCH RESEND v2] console: Add persistent scrollback buffers for all VGA consoles

This version reuses an "old" scrollback buffer of the previous console if memory allocation fails. However, the issue of clearing the console using the 'clear_console' commnad [1,2] is still unsolved. I'd prefer implementing it using a ioctl() call but it's open for discussion ;) [1] https://sour

Re: [PATCH v2] dns_resolver: assure that dns_query() result is null-terminated

On Sa, 2014-06-07 at 14:42 -0700, David Rientjes wrote: > On Sat, 7 Jun 2014, Manuel Schölling wrote: > > > dns_query() credulously assumes that keys are null-terminated and > > returns a copy of a memory block that is off by one. > > No sign-off? Please read Documentation/SubmittingPatches. It'

Re: [PATCH] dns_resolver: assure that dns_query() result is null-terminated

LOL, that was stupid! Sorry, I'll send a corrected version in a second... On Sa, 2014-06-07 at 14:54 -0400, Trond Myklebust wrote: > On Sat, Jun 7, 2014 at 1:56 PM, Manuel Schölling > wrote: > > dns_query() credulously assumes that keys are null-terminated and > > returns a copy of a memory block

Re: [PATCH] console: Add persistent scrollback buffers for all VGA consoles

On Sa, 2014-05-31 at 00:26 +0200, Jakub Wilk wrote: > * Manuel Schölling , 2014-05-30, 15:27: > >Add a scrollback buffers for each VGA console. The benefit is that the > >scrollback history is not flushed when switching between consoles but > >is persistent. > > Some people rely on this scrollba

Re: [PATCH] console: Add persistent scrollback buffers for all VGA consoles

Hi Geert, On Fr, 2014-05-30 at 16:28 +0200, Geert Uytterhoeven wrote: Hi Manuel, > > On Fri, May 30, 2014 at 3:27 PM, Manuel Schölling > wrote: > > Add a scrollback buffers for each VGA console. The benefit is that > > the scrollback history is not flushed when switching between consoles > > but

Re: [PATCH] staging: gdm72xx: use time_before()

On So, 2014-05-25 at 11:33 -0700, Greg KH wrote: > On Sun, May 25, 2014 at 08:24:33PM +0200, Manuel Schoelling wrote: > > On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > > > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > > > To be future-pr

Re: [PATCH] staging: gdm72xx: use time_before()

On So, 2014-05-25 at 11:14 -0700, Greg KH wrote: > On Sun, May 25, 2014 at 03:08:59PM +0200, Manuel Schölling wrote: > > To be future-proof and for better readability the time comparisons are > > modified to use time_before() instead of plain, error-prone math. > > > > Signed-off-by: Manuel Schöll

Re: [PATCH] ipath: use time_before()/_after()

On So, 2014-05-25 at 22:17 +0800, Dongsheng Yang wrote: > On Sun, May 25, 2014 at 9:26 PM, Manuel Schölling > wrote: > > To be future-proof and for better readability the time comparisons are > > modified to use time_before/_after() instead of plain, error-prone math. > > > > Signed-off-by: Manuel

Re: [PATCH 1/3] net: vxge: Use time_is_before_jiffies() for time comparison

Sorry, contrary to the subject of this mail, this is a single file patch. Patches 2-3 do not exist. On Mo, 2014-05-19 at 18:47 +0200, Manuel Schölling wrote: > To be future-proof and for better readability the time comparisons are > modified > to use time_is_before_jiffies() instead of plain, err

Re: [PATCH] fs: Cleanup string initializations (char[] instead of char *)

Thanks for the detailed review of my patches, guys! I had a look at the assembler code now, too and you are right about this. I was misguided by the KernelJanitor's TODO list [1]. If there is consensus the corresponding paragraph from that list should be removed. [1] http://kernelnewbies.org/Kern