Re: [PATCH] drm: include: fix W=1 warnings in struct drm_dsc_config

2019-09-10 Thread Manasi Navare
On Tue, Sep 10, 2019 at 12:58:24PM +, Harry Wentland wrote: > +Manasi, Gaurav > > On 2019-09-09 9:52 a.m., Benjamin Gaignard wrote: > > Change scale_increment_interval and nfl_bpg_offset fields to > > u32 to avoid W=1 warnings because we are testing them against > > 65535. > > > > Signed-off-

Re: [Intel-gfx] [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Manasi Navare
On Wed, Apr 04, 2018 at 06:34:29PM +0300, Ville Syrjälä wrote: > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > While enabling/disabling DPMS before link training with MST hubs is > > perfectly valid; unfortunately disabling DPMS results in some devices > > disabling their AUX CH b

Re: [PATCH v3 5/5] drm/i915: Implement proper fallback training for MST

2018-03-12 Thread Manasi Navare
t suceeds here but then loses synchronization in between, that time it will send IRQ_HPD and indicate this through ESI and the way its handled is through intel_dp_mst_check_link_status() and then through the separate mst_retrain_link work. And this time we first try to retrain at the current v

Re: [PATCH v3 3/5] drm/dp_mst: Add drm_dp_mst_topology_mgr_lower_link_rate()

2018-03-12 Thread Manasi Navare
ng MST is going to need to do in order to retrain MST links > properly, we add the drm_dp_mst_topology_mgr_lower_link_rate() helper > which simply recalculates the pbn_div for a given mst topology, then > marks the link status of all connectors living in that topology as bad. > We'

Re: [PATCH v3 2/5] drm/i915: Only use one link bw config for MST topologies

2018-03-12 Thread Manasi Navare
ning it reads the new max link rate and lane count during the mst compute config. Isnt that the case or am I missing something here? Manasi > Signed-off-by: Lyude Paul > Cc: Manasi Navare > Cc: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_dp.c | 11 +-- > dri

Re: [PATCH v2 2/6] drm/i915: Move DP modeset retry work into intel_dp

2018-03-08 Thread Manasi Navare
of the > intel_connector struct and into intel_dp. > > V2: > - Remove accidental duplicate modeset_retry_work in intel_connector > > Signed-off-by: Lyude Paul > Cc: Manasi Navare > Cc: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_display.c | 23 ++

Re: [PATCH 1/6] drm/i915: Remove unused DP_LINK_CHECK_TIMEOUT

2018-03-08 Thread Manasi Navare
On Thu, Mar 08, 2018 at 06:24:15PM -0500, Lyude Paul wrote: > Signed-off-by: Lyude Paul > Cc: Manasi Navare > Cc: Ville Syrjälä Reviewed-by: Manasi Navare > --- > drivers/gpu/drm/i915/intel_dp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/g

Re: [PATCH] drm/i915: Synchronize connectors states when switching from poll to irq

2017-07-19 Thread Manasi Navare
On Tue, Jul 18, 2017 at 03:11:42PM +0300, Paul Kocialkowski wrote: > On Mon, 2017-06-26 at 15:32 +0300, Paul Kocialkowski wrote: > > After detecting an IRQ storm, hotplug detection will switch from > > irq-based detection to poll-based detection. After a short delay or > > when resetting storm dete

Re: [PATCH v2] drm/i915: Explicit the connector name for DP link training result

2017-07-18 Thread Manasi Navare
is does make sense during the link training failure debugging to know the connector name. While at it feel free to change "Failed", "Link Rate, Lane Count", to upper case in the failure_handling case to be consistent with the pass case. Reviewed-by: Manasi Navare Manasi &g

Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V

2017-07-17 Thread Manasi Navare
On Mon, Jul 17, 2017 at 08:59:18PM +, Pandiyan, Dhinakaran wrote: > > > > On Mon, 2017-07-17 at 18:55 +, Pandiyan, Dhinakaran wrote: > > Looks like a typo in > > > > cf54ca8 ("drm/i915/cnl: Implement voltage swing sequence.") > > > > but Cc'ing Rodrigo, Clint to make sure this wasn't

Re: [Intel-gfx] [PATCH] drm/i915: Return correct EDP voltage swing table for 0.85V

2017-07-17 Thread Manasi Navare
This makes sense, it should have returned the edp ddi buf translation table as per the Bspec. Please add this to the commit message: Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.") After that, Reviewed-by: Manasi Navare Manasi On Mon, Jul 17, 2017 at 11:21:

Re: [PATCH v2 1/2] drm: Introduce crtc->mode_valid() callback

2017-05-03 Thread Manasi Navare
On Fri, Apr 28, 2017 at 02:47:11PM +0100, Jose Abreu wrote: > Some crtc's may have restrictions in the mode they can display. In > this patch a new callback (crtc->mode_valid()) is introduced that > is called at the same stage of connector->mode_valid() callback. > > This shall be implemented if t