lme2510_int_read is not atomically called so use GFP_KERNEL for
usb_alloc_urb and usb_submit_urb which is the first in the chain
of interrupt submissions.
Signed-off-by: Malcolm Priestley
---
This patch is applied on top of
[likely] media: lmedm04: Fix misuse of comma
I have tested both
> If that's a request for me, I won't as I can't test.
>
> As the maintainer, you should do that.
No it is for media maintainer.
Good catch the interrupt URB is not running because usb_submit_urb is tangled
with it.
It only really affects signal strength.
add
Fixes: 15e1ce33182d ("[media] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe
1 != type 3 in interrupt urb")
Cc:
Regards
Malcolm
On 21/12/2018 18:51, Linus Torvalds wrote:
> On Fri, Dec 21, 2018 at 9:57 AM Steven Rostedt wrote:
>>
>> I figured the best thing to do is to create a helper macro and place it
>> into include/linux/string.h. And go around and fix all the open coded
>> versions of it later.
>>
>> I plan on only ap
Hi
On 19/11/2018 17:53, Mauro Carvalho Chehab wrote:
> Hi Takashi,
>
> Em Mon, 19 Nov 2018 16:13:29 +0100
> Takashi Iwai escreveu:
>
>> Hi,
>>
>> we've got a regression report on openSUSE Bugzilla regarding DVB-S PCI
>> card:
>> https://bugzilla.opensuse.org/show_bug.cgi?id=1116374
>>
>> Acc
On 25/09/17 13:39, Andrey Konovalov wrote:
Hi!
I've got the following report while fuzzing the kernel with syzkaller.
On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2).
usb 1-1: new full-speed USB device number 2 using dummy_hcd
gadgetfs: connected
gadgetfs: disconnected
gadgetfs
Hi
On 18/05/17 20:09, Gustavo A. R. Silva wrote:
Hello everybody,
While looking into Coverity ID 1226934 I ran into the following piece of
code at drivers/media/usb/dvb-usb-v2/lmedm04.c:205
205static int lme2510_stream_restart(struct dvb_usb_device *d)
206{
207struct lme2510_state *
On 08/11/16 21:38, Mauro Carvalho Chehab wrote:
Em Tue, 8 Nov 2016 22:15:24 +0100
Benjamin Larsson escreveu:
On 11/08/2016 09:22 PM, Mauro Carvalho Chehab wrote:
Em Tue, 8 Nov 2016 10:42:03 -0800
Linus Torvalds escreveu:
On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote:
Since v4.9-rc4 I g
On 28/09/16 08:40, Dan Carpenter wrote:
On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote:
Change the type and uses of rx_rate.
Signed-off-by: Martin Alonso
---
drivers/staging/vt6656/dpc.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
On 16/07/15 09:54, Dan Carpenter wrote:
On Thu, Jul 16, 2015 at 08:45:06AM +, Maninder Singh wrote:
where we are checking for (pTDInfo->skb), we are using it in above line.
and it does not look good, thats why we should remove thse checks and i have
suggested
changes.
code snippet:-
---
On 03/06/15 12:35, David Howells wrote:
Statistics polling can not be done by lmedm04 driver's implementation of
M88RS2000/TS2020 because I2C messages stop the device's demuxer, so allow
polling for statistics to be suppressed in the ts2020 driver by setting
dont_poll in the ts2020_config struc
On 03/06/15 17:43, Antti Palosaari wrote:
On 06/03/2015 07:37 PM, David Howells wrote:
Malcolm Priestley wrote:
Yes, also, the workqueue appears not to be initialized when using
the dvb
attached method.
I'm not sure what you're referring to. It's initialised in
ts2020_pro
On 03/06/15 17:37, David Howells wrote:
Malcolm Priestley wrote:
Yes, also, the workqueue appears not to be initialized when using the dvb
attached method.
I'm not sure what you're referring to. It's initialised in ts2020_probe()
just after the ts2020_priv struct is alloc
On 03/06/15 12:13, Antti Palosaari wrote:
On 05/28/2015 11:07 PM, Malcolm Priestley wrote:
On 28/05/15 11:08, David Howells wrote:
Malcolm Priestley wrote:
Statistics polling can not be done by lmedm04 driver's
implementation of
M88RS2000/TS2020 because I2C messages stop the de
On 03/06/15 11:17, David Howells wrote:
Malcolm Priestley wrote:
Yes, also, the workqueue appears not to be initialized when using the dvb
attached method.
I'm not sure what you're referring to. It's initialised in ts2020_probe()
just after the ts2020_priv struct is alloc
On 28/05/15 11:08, David Howells wrote:
Malcolm Priestley wrote:
Statistics polling can not be done by lmedm04 driver's implementation of
M88RS2000/TS2020 because I2C messages stop the devices demuxer.
So any polling must be a config option for this driver.
Ummm... I presume a ru
On 26/05/15 16:04, David Howells wrote:
Provide a DVBv5 API signal strength. This is in units of 0.001 dBm rather
than a percentage.
From Antti Palosaari's testing with a signal generator, it appears that the
gain calculated according to Montage's specification if negated is a
reasonable repr
On 31/01/15 19:05, Derrick Greenspan wrote:
This patch fixes the checkpatch.pl warning:
WARNING: else is not generally useful after a break or return
559: FILE: drivers/staging/vt6656/rxtx.c:559:
Checkpatch does not check that the if and else has different function scope.
It isn't erroneous
On 31/01/15 15:16, Rickard Strandqvist wrote:
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/vt665
On 11/01/15 16:42, Joe Perches wrote:
On Mon, 2015-01-12 at 03:19 +1100, Emrys Bayliss wrote:
This patch fixes the following checkpatch.pl error:
rxtx.c:588: WARNING: else is not generally useful after a break or return
Signed-off-by: Emrys Bayliss
---
drivers/staging/vt6656/rxtx.c | 6 +--
On 21/12/14 13:56, Mike Krinkin wrote:
this patch fixes following sparse warnings:
drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in
argument 1 (different address spaces)
drivers/staging/vt6655/device_main.c:1503:25:expected void [noderef]
*
drivers/staging/vt6655/
On 21/12/14 08:17, Jeremiah Mahler wrote:
Eddie, all,
On Sat, Dec 20, 2014 at 10:27:55PM -0700, Eddie Kovsky wrote:
Fixes following warning generated by sparse:
drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument
1 (different address spaces)
drivers/staging/vt6655/b
Remove macro and directive leaving the code.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/rxtx.c | 4 +---
drivers/staging/vt6655/wmgr.c | 12
2 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655
ether_crc is already in kernel remove local code and
include linux/crc32.h
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device.h | 1 +
drivers/staging/vt6655/device_main.c | 17 -
2 files changed, 1 insertion(+), 17 deletions(-)
diff --git a/drivers
PLICE_DEBUG is not defined in any header for this file.
Remove code, references and directives.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device_main.c | 40
1 file changed, 40 deletions(-)
diff --git a/drivers/staging/vt6655
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device.h | 4
drivers/staging/vt6655/dpc.c| 7 +++
2 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
index fadebe9..1abad5d 100644
--- a/drivers
PLICE_DEBUG is not defined remove dead code.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/vntwifi.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vt6655/vntwifi.c b/drivers/staging/vt6655/vntwifi.c
index 4d425e0..59f66fe 100644
--- a/drivers/staging
Aligning the code.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device_main.c | 37 ++--
1 file changed, 19 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index 0ecc99b
The value is either DEVICE_INIT_COLD or DEVICE_INIT_DXPL making no
difference to code.
Remove typedef and remove if statement in device_init_registers
pulling the code in.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device.h | 6 -
drivers/staging/vt6655/device_main.c
Removing all variables associated with the code.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/bssdb.c | 53
drivers/staging/vt6655/device_main.c | 15 --
2 files changed, 68 deletions(-)
diff --git a/drivers/staging/vt6655
This device is always memory mapped
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device_main.c | 10 +-
drivers/staging/vt6655/upc.h | 34 --
2 files changed, 1 insertion(+), 43 deletions(-)
diff --git a/drivers/staging/vt6655
Removing all code within and function MngWorkItem.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device.h | 1 -
drivers/staging/vt6655/device_main.c | 6 --
drivers/staging/vt6655/dpc.c | 24
drivers/staging/vt6655/dpc.h | 2
Removing _RxManagementQueue, InitRxManagementQueue, MlmeThread, mlme_kill,
EnQueue and DeQueue.
Signed-off-by: Malcolm Priestley
---
drivers/staging/vt6655/device.h | 49 +---
drivers/staging/vt6655/device_main.c | 55
On 27/07/14 19:21, Greg Kroah-Hartman wrote:
On Sat, Jul 26, 2014 at 11:44:57AM +0100, Malcolm Priestley wrote:
On 26/07/14 10:18, Guillaume CLÉMENT wrote:
On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote:
Hi Malcolm,
On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm
On 26/07/14 10:18, Guillaume CLÉMENT wrote:
On Sat, Jul 26, 2014 at 10:24:30AM +0200, Guillaume CLÉMENT wrote:
Hi Malcolm,
On Sat, Jul 26, 2014 at 12:09:49AM +0100, Malcolm Priestley wrote:
Hi Guillaume
On 25/07/14 13:47, Guillaume Clement wrote:
Sparse reported that the data from
Hi Guillaume
On 25/07/14 13:47, Guillaume Clement wrote:
Sparse reported that the data from tagSCmdRequest is given by
userspace, so it should be tagged as such.
extra is not in user space
All Wireless Extensions ioctl extra calls originate from
ioctl_standard_iw_point in wext-core.
Either
Hi Guillaume
On 25/07/14 13:47, Guillaume Clement wrote:
Sparse reported that the data from tagSCmdRequest is given by
userspace, so it should be tagged as such.
extra is not in user space
All Wireless Extensions ioctl extra calls originate from
ioctl_standard_iw_point in wext-core.
Either
On Sun, 2014-02-02 at 18:07 +, Stefan Lippers-Hollmann wrote:
> Hi
>
> [ CC'ing the relevant parties ]
>
> On Sunday 02 February 2014, Dave Jones wrote:
> > On Sun, Feb 02, 2014 at 03:41:27AM -0800, scan-ad...@coverity.com wrote:
> > >
> > > Please find the latest report on new defect(s) i
gt; > http://git.kernel.org/linus/;a=commit;h=302433daf47aeb7d21d66e55fb84d6a8fffd4aed
> > > > Commit: 302433daf47aeb7d21d66e55fb84d6a8fffd4aed
> > > > Parent: a72f8beeedc97b776799a1a80c04eb5312980c9b
> > > > Author: Malcolm Priestley
> &g
39 matches
Mail list logo
