ed-off-by: Daniel Gomez
Linus -- just a heads up, Daniel is next up from the Rust world
to take on modules. After 6 months from now it will be Sami. Petr
has done great but the goal was to get more blood from the Rust
world. This has been working well so far so I think after Sami
I'll just go
a greater effort to move ctl tables into their
> respective subsystems which will reduce the merge conflicts in
> kernel/sysctl.c.
>
> Signed-off-by: Joel Granados
Reviewed-by: Luis Chamberlain
Luis
gt; one file.
>
> This is part of a greater effort to move ctl tables into their
> respective subsystems which will reduce the merge conflicts in
> kernel/sysctl.c.
>
> Signed-off-by: Joel Granados
Reviewed-by: Luis Chamberlain
Luis
educe the merge conflicts in
> kernel/sysctl.c.
>
> Signed-off-by: Joel Granados
Reviewed-by: Luis Chamberlain
Luis
cts in
> kernel/sysctl.c.
>
> Signed-off-by: Joel Granados
Reviewed-by: Luis Chamberlain
Luis
ems which will reduce the merge conflicts in
> kernel/sysctl.c.
>
> Signed-off-by: Joel Granados
Reviewed-by: Luis Chamberlain
Luis
e temp value.
>
> This is part of a greater effort to move ctl tables into their
> respective subsystems which will reduce the merge conflicts in
> kernel/sysctl.c.
>
> Signed-off-by: Joel Granados
Reviewed-by: Luis Chamberlain
Luis
linux/key.h key_sysctls
> linux/nvs_fs.hacpi_video_flags
> linux/acpi.h acpi_video_flags
> linux/fs.hproc_nr_files
>
> * These are no longer needed as intermediate includes
> ==
> Include
> ==
> linux/f
On Fri, May 09, 2025 at 02:54:15PM +0200, Joel Granados wrote:
> These comments are older than 2003 and therefore do not bare any
> relevance on the current state of the sysctl.c file. Remove them as they
> confuse more than clarify.
>
> Signed-off-by: Joel Granados
Re
G_MODULES) += module/
And so you can drop this ifdef.
Other than that:
Reviewed-by: Luis Chamberlain
Luis
On Fri, Apr 18, 2025 at 01:50:47PM -0300, Herton R. Krzesinski wrote:
> Right now test_kmod has hardcoded dependencies on btrfs/xfs. That
> is not optimal since you end up needing to select/build them, but it
> is not really required since other fs could be selected for the testing.
> Also, we can'
epends on PAGE_SIZE_LESS_THAN_256KB # for BTRFS
Please read the commit log that added PAGE_SIZE_LESS_THAN_256KB, what
do we want to do about those complaining about that? Maybe Cc the
author of that patch.
Other than that, it looks good to me. Did you run the selftest?
Reviewed-by: Luis Chamberlain
Luis
On Wed, Mar 12, 2025 at 09:30:28AM -0700, Kees Cook wrote:
> On Wed, Mar 12, 2025 at 04:45:24PM +0100, Vlastimil Babka wrote:
> > On 3/6/25 17:57, Luis Chamberlain wrote:
> > > + linux-mm since we're adding TAINT_BAD_PAGE
> > >
> > > On Thu, Mar 06, 2
NT_FLAG(MACHINE_CHECK, 'M', ' ', false),
> - TAINT_FLAG(BAD_PAGE, 'B', ' ', false),
> + TAINT_FLAG(BAD_PAGE,'B', ' ', true),
> TAINT_FLAG(USER,'U
;
> Add lib/tests/module/ and tools/testing/selftests/module/ to maintained
> files. They were introduced previously by commit 84b4a51fce4c ("selftests:
> add new kallsyms selftests").
>
> Signed-off-by: Petr Pavlu
Reviewed-by: Luis Chamberlain
> ---
> MAINTAINE
ro_after_init sections.
>
> [1]
> https://lore.kernel.org/linux-modules/20241223093840.29417-1-petr.pa...@suse.com/
Reviewed-by: Luis Chamberlain
Luis
On Thu, Jan 09, 2025 at 11:52:27AM +0100, Arnout Engelen wrote:
> On Fri, 3 Jan 2025 17:37:52 -0800, Luis Chamberlain wrote:
> > What distro which is using module signatures would switch
> > to this as an alternative instead?
>
> In NixOS, we disable MODULE_SIG by defa
On Mon, Jan 06, 2025 at 04:13:29PM -0800, Kees Cook wrote:
> On Fri, Jan 03, 2025 at 05:13:32PM +0100, Petr Pavlu wrote:
> > On 12/5/24 20:46, Christophe Leroy wrote:
> > > This series reworks module loading to avoid leaving the module in a
> > > stale state when protecting ro_after_init section fa
On Sat, Jan 04, 2025 at 07:30:39AM +0100, Thomas Weißschuh wrote:
> Hi Luis,
>
> On 2025-01-03 17:37:52-0800, Luis Chamberlain wrote:
> > On Wed, Dec 25, 2024 at 11:52:00PM +0100, Thomas Weißschuh wrote:
> > > diff --git a/kernel/module/Kconfig b/kernel/mo
On Wed, Dec 25, 2024 at 11:52:00PM +0100, Thomas Weißschuh wrote:
> diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig
> index
> 7b329057997ad2ec310133ca84617d9bfcdb7e9f..57d317a6fa444195d0806e6bd7a2af6e338a7f01
> 100644
> --- a/kernel/module/Kconfig
> +++ b/kernel/module/Kconfig
> @@ -34
On Wed, Jan 01, 2025 at 01:43:22PM +0100, Petr Pavlu wrote:
> On 12/23/24 21:14, Linus Torvalds wrote:
> > On Mon, 23 Dec 2024 at 02:55, Petr Pavlu wrote:
> >>
> >> Luis asked me to look after the modules maintenance for a while, with the
> >> plan to rotate it with other recently added modules ma
t; Reported-by: Linus Torvalds
> Suggested-by: Linus Torvalds
> Signed-off-by: Masahiro Yamada
Reviewed-by: Luis Chamberlain
Luis
On Fri, Dec 13, 2024 at 01:28:27PM +0100, Andreas Hindborg wrote:
>
> Hi Luis, Petr, Sami, Dani,
>
> I just noticed that I failed in email and forgot to add you to the
> recipient list of this series. Do you want a resend, or is this
> sufficient?
If the patches didn't go to linux-modules, then
after_init data section to read-only fails, all we can
> do is to inform the user through a warning. This is what patch 2 does.
>
> Then patch 3 tries to go a bit further by testing the ability to write
> protect ro-after-init section prior to initialising the module.
Reviewed-by: Luis Chamberlain
Luis
On Tue, Dec 10, 2024 at 11:27:06PM +0900, Masahiro Yamada wrote:
> On Tue, Dec 10, 2024 at 9:42 PM Neal Gompa wrote:
> >
> > On Mon, Nov 25, 2024 at 10:34 AM Sami Tolvanen
> > wrote:
> > >
> > > On Mon, Nov 25, 2024 at 4:41 PM Miguel Ojeda
> > > wrote:
> > > >
> > > > On Mon, Nov 25, 2024 at 2:
On Thu, Nov 28, 2024 at 03:10:34PM +0100, Geert Uytterhoeven wrote:
> Despite the warning, I gave this a try on m68k (cross-compiled on i7 ;-).
> However, I didn't notice any extra-ordinary build times.
I had some large values before this got merged and due to this
slowing down builds 2x I reduced
On Thu, Nov 28, 2024 at 03:04:52PM +0100, Geert Uytterhoeven wrote:
> The parameter passed to load_mod() is stored in $MOD, but never used.
> Obviously it was intended to be used instead of the hardcoded
> "test_kallsyms_b" module name.
>
> Fixes: 84b4a51fce4ccc66 ("selftests: add new kallsyms sel
v6.13-rc1
This consists of 3 fixes, the main one build that we build the kallsyms
test modules all over again if we just run make twice.
Geert Uytterhoeven (1):
selftests: find_symbol: Actually use load_mod() parameter
Luis Cham
On Wed, Nov 27, 2024 at 07:02:55PM -0800, Luis Chamberlain wrote:
> I did. Multiple times.
I've split this up now in 2 parts, one with your fixes and then the
other boundary fixes which are not related.
>From 8e4c903fa3079e1c05c9585f78c57e8067024d99 Mon Sep 17 00:00:00 2001
On Thu, Nov 28, 2024 at 11:56:44AM +0900, Masahiro Yamada wrote:
> On Thu, Nov 28, 2024 at 11:42 AM Luis Chamberlain wrote:
> >
> > Now with Masahiro's cleanups, in my testing we don't need the FORCE anymore.
> >
> >
> > From 83497e0e83d81950df54d8
Now with Masahiro's cleanups, in my testing we don't need the FORCE anymore.
>From 83497e0e83d81950df54d82461b1dae629842147 Mon Sep 17 00:00:00 2001
From: Luis Chamberlain
Date: Wed, 27 Nov 2024 14:10:57 -0800
Subject: [PATCH v3] selftests: kallsyms: fix double build stupidity
F
On Thu, Nov 28, 2024 at 11:09:43AM +0900, Masahiro Yamada wrote:
> diff --git a/lib/tests/module/Makefile b/lib/tests/module/Makefile
> index af5c27b996cb..8cfc4ae600a9 100644
> --- a/lib/tests/module/Makefile
> +++ b/lib/tests/module/Makefile
> @@ -3,13 +3,12 @@ obj-$(CONFIG_TEST_KALLSYMS_B) += te
On Wed, Nov 27, 2024 at 03:56:48PM -0800, Linus Torvalds wrote:
> On Wed, 27 Nov 2024 at 15:26, Luis Chamberlain wrote:
> >
> > On Wed, Nov 27, 2024 at 02:35:36PM -0800, Luis Chamberlain wrote:
> > > Sorry about that, I'm on it.
> >
> > OK here is a fix, g
On Wed, Nov 27, 2024 at 02:35:36PM -0800, Luis Chamberlain wrote:
> Sorry about that, I'm on it.
OK here is a fix, goes double build tested and then run time tested.
>From 6c9ef19d7676c3f650f1de3e2619c958f21c0b75 Mon Sep 17 00:00:00 2001
From: Luis Chamberlain
Date: Wed, 27 Nov 20
On Wed, Nov 27, 2024 at 01:22:37PM -0800, Linus Torvalds wrote:
> On Tue, 26 Nov 2024 at 17:10, Luis Chamberlain wrote:
> >
> > Highlights for this merge window:
>
> Lowlights:
>
> > * Adds a new modules selftests: kallsyms which helps us tests
> > fin
On Wed, Nov 27, 2024 at 02:37:40PM +0100, Christophe Leroy wrote:
>
>
> Le 26/11/2024 à 20:58, Luis Chamberlain a écrit :
> > On Sat, Nov 09, 2024 at 11:35:35AM +0100, Christophe Leroy wrote:
> > > module_enable_rodata_ro() is called twice, once before module init
>
for __ex_table
Luis Chamberlain (2):
selftests: add new kallsyms selftests
tests/module/gen_test_kallsyms.sh: use 0 value for variables
Matthew Maurer (13):
module: Take const arg in validate_section_offset
module: Factor out elf_validity_ehdr
mod
On Sat, Nov 09, 2024 at 11:35:35AM +0100, Christophe Leroy wrote:
> module_enable_rodata_ro() is called twice, once before module init
> to set rodata sections readonly and once after module init to set
> rodata_after_init section readonly.
>
> The second time, only the rodata_after_init section n
On Mon, Nov 18, 2024 at 01:54:14PM +0100, Petr Pavlu wrote:
> I'm however not sure about rejecting empty strings as is also done by
> the patch. Consider a call to request_module("mod%s", suffix) where the
> suffix could be empty to select the default variant, or non-empty to
> select e.g. some opt
On Thu, Nov 21, 2024 at 08:42:21PM +, Sami Tolvanen wrote:
> If you also want to test the series with actual Rust modules, this
> branch adds Matt's latest modversion_info series:
The merge window for v6.13 is now open so this is too late for that, so
this is all work to be queued up after, so
On Tue, Nov 26, 2024 at 12:50:48PM +0900, Masahiro Yamada wrote:
> On Tue, Nov 26, 2024 at 8:30 AM Luis Chamberlain wrote:
> >
> > On Thu, Nov 21, 2024 at 08:42:22PM +, Sami Tolvanen wrote:
> > > Add a basic DWARF parser, which uses libdw to traverse the debugging
On Thu, Nov 21, 2024 at 08:42:22PM +, Sami Tolvanen wrote:
> Add a basic DWARF parser, which uses libdw to traverse the debugging
> information in an object file and looks for functions and variables.
> In follow-up patches, this will be expanded to produce symbol versions
> for CONFIG_MODVERSI
On Mon, Nov 18, 2024 at 04:09:34PM -0800, Matthew Maurer wrote:
> > Thinking about this some more, if we're going down enabling a new
> > option, it seems to beg the question if the old *two* ksymtab sections
> > could just be folded into the a new one where the "gpl only" thing
> > becomes just on
On Thu, Nov 07, 2024 at 02:38:13PM -0800, Luis Chamberlain wrote:
> The only thing left I think to test is the impact at runtime, and the
> only thing I can think of is first we use find_symbol() on resolve_symbol()
> which it took me a while to review and realize that this ju
On Mon, Nov 18, 2024 at 11:10:28AM +0100, Werner Sembach wrote:
> Hi,
>
> Am 15.11.24 um 19:50 schrieb Werner Sembach:
> > From: Uwe Kleine-König
> >
> > TUXEDO has not yet relicensed a module for GPLv2+ as a reply from former
> > contributers the committed code under GPLv3+ is awaited.
> >
> >
On Wed, Nov 13, 2024 at 09:04:51AM -0500, Neal Gompa wrote:
> On Mon, Nov 11, 2024 at 11:06 PM Masahiro Yamada wrote:
> >
> > On Thu, Oct 31, 2024 at 2:01 AM Sami Tolvanen
> > wrote:
> > >
> > > Suggested-by: Petr Pavlu
> > > Signed-off-by: Sami Tolvanen
> > > Acked-by: Neal Gompa
> >
> > Doe
On Wed, Nov 13, 2024 at 07:49:24AM +0100, Christophe Leroy wrote:
>
>
> Le 12/11/2024 à 21:28, Luis Chamberlain a écrit :
> > On Sat, Nov 09, 2024 at 11:35:37AM +0100, Christophe Leroy wrote:
> > > diff --git a/kernel/module/main.c b/kernel/module/main.c
> > >
On Sat, Nov 09, 2024 at 11:35:37AM +0100, Christophe Leroy wrote:
> diff --git a/kernel/module/main.c b/kernel/module/main.c
> index 1bf4b0db291b..b603c9647e73 100644
> --- a/kernel/module/main.c
> +++ b/kernel/module/main.c
> @@ -2582,7 +2582,7 @@ static noinline int do_init_module(struct module *
On Fri, Nov 08, 2024 at 05:12:16PM +0100, Daniel Gomez via B4 Relay wrote:
> From: Daniel Gomez
>
> When ro_after_init fails, we need to unload the module.
>
> Rename the goto tag to fail_ro_after_init to make it more clear and try
> to check for dependencies, stop the module and call the exit f
+ Other new module maintainers
On Fri, Nov 08, 2024 at 09:12:03AM +0100, Christophe Leroy wrote:
> Hi Luis,
>
> Le 24/09/2024 à 09:22, Mike Rapoport a écrit :
> > On Thu, Sep 19, 2024 at 02:53:34AM -0700, Luis Chamberlain wrote:
> > > On Fri, Sep 06, 2024 at 04:24:56PM
On Wed, Nov 06, 2024 at 06:46:48PM +, Sami Tolvanen wrote:
> Hi Luis,
>
> On Wed, Nov 6, 2024 at 12:24 AM Luis Chamberlain wrote:
> >
> > Use 0 for the values as we use them for the return value on init
> > to keep the test modules simple. This fixes a splat repo
On Wed, Nov 06, 2024 at 02:19:38PM -0800, Matthew Maurer wrote:
> >
> > > If booted against an old kernel, it will
> > > behave as though there is no modversions information.
> >
> > Huh? This I don't get. If you have the new libkmod and boot
> > an old kernel, that should just not break becauase w
On Wed, Nov 06, 2024 at 08:02:40PM +0100, Peter Zijlstra wrote:
> Hi,
>
> I've been wanting $topic for a while, and having just stumbled into the
> whole namespace thing by accident, I figured I'd give it a go, most if
> the hard parts seem to have already been done.
Neat, hch suggested something
On Tue, Nov 05, 2024 at 04:26:51PM -0800, Matthew Maurer wrote:
> On Fri, Nov 1, 2024 at 2:10 PM Luis Chamberlain wrote:
> >
> > On Thu, Oct 31, 2024 at 01:00:28PM -0700, Matthew Maurer wrote:
> > > > The question is, if only extended moversions are used, what new tooli
+0x76/0x7e
RIP: 0033:0x7ffaa5d18839
Reported-by: Sami Tolvanen
Signed-off-by: Luis Chamberlain
---
lib/tests/module/gen_test_kallsyms.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/tests/module/gen_test_kallsyms.sh
b/lib/tests/module/gen_test_kallsyms.sh
index ae5966f1f904..
On Tue, Oct 29, 2024 at 09:24:30AM -0700, Sami Tolvanen wrote:
> Hi Luis,
>
> On Mon, Oct 21, 2024 at 12:33 PM Luis Chamberlain wrote:
> >
> > diff --git a/lib/tests/module/gen_test_kallsyms.sh
> > b/lib/tests/module/gen_test_kallsyms.sh
> > new file m
On Thu, Oct 31, 2024 at 01:00:28PM -0700, Matthew Maurer wrote:
> > The question is, if only extended moversions are used, what new tooling
> > requirements are there? Can you test using only extended modversions?
> >
> > Luis
>
> I'm not sure precisely what you're asking for. Do you want:
> 1.
On Wed, Oct 30, 2024 at 11:05:03PM +, Matthew Maurer wrote:
> diff --git a/kernel/module/Kconfig b/kernel/module/Kconfig
> index
> e6b2427e5c190aacf7b9c5c1bb57fca39d311564..a31c617cd67d3d66b24d2fba34cbd5cc9c53ab78
> 100644
> --- a/kernel/module/Kconfig
> +++ b/kernel/module/Kconfig
> @@ -208,
On Wed, Oct 30, 2024 at 10:06:12PM -0700, Matthew Maurer wrote:
> On Wed, Oct 30, 2024 at 9:37 PM Luis Chamberlain wrote:
> >
> > On Thu, Oct 31, 2024 at 12:22:36PM +1100, Michael Ellerman wrote:
> > > Matthew Maurer writes:
> > > > Adds a new format for MODV
On Thu, Oct 31, 2024 at 12:22:36PM +1100, Michael Ellerman wrote:
> Matthew Maurer writes:
> > Adds a new format for MODVERSIONS which stores each field in a separate
> > ELF section. This initially adds support for variable length names, but
> > could later be used to add additional fields to MOD
On Wed, Oct 30, 2024 at 05:16:34PM +, Matthew Maurer wrote:
> This script has been broken for 5 years with no user complaints.
>
> It first had its .mod.c parser broken in commit a3d0cb04f7df ("modpost:
> use __section in the output to *.mod.c"). Later, it had its object file
> enumeration bro
On Thu, Oct 24, 2024 at 11:07:57PM +, Sami Tolvanen wrote:
> > Changes in v7:
> > - Fix modpost to detect EXTENDED_MODVERSIONS based on a flag
> > - Drop patches to fix export_report.pl
>
> Unless Luis prefers to deal with this separately, perhaps you can
> just include a patch to delete expor
On Wed, Oct 23, 2024 at 10:28:49AM -0700, Jeff Johnson wrote:
> On 10/21/24 12:33, Luis Chamberlain wrote:
> ...
> > +gen_template_module_exit()
> > +{
> > + cat <<END_MODULE
> > +static int __init auto_test_module_init(void)
> > +{
> > + ret
On Mon, Oct 21, 2024 at 10:20:38PM +0200, Tobias Stoeckmann wrote:
> Hi Luis,
>
> On Mon, Oct 21, 2024 at 12:55:34PM -0700, Luis Chamberlain wrote:
> > And then you can make a series with 3 patches for this and your prior one,
> > and you can just refer to the PoC in the fix
On Sat, Oct 19, 2024 at 04:15:32PM +0200, Tobias Stoeckmann wrote:
> It must be verified that the symbol name offsets point into the
> string table, not outside of it.
>
> Signed-off-by: Tobias Stoeckmann
> ---
> Proof of Concept:
>
> 1. Create "poc.sh"
>
> ```
> cat > poc.sh << EOF
> #!/bin/sh
On Sat, Oct 19, 2024 at 04:14:40PM +0200, Tobias Stoeckmann wrote:
> The string table must be NUL-terminated, just like the section name table.
>
> Signed-off-by: Tobias Stoeckmann
> ---
> In order to create a proof of concept, which I can't get into a simple
> script right now, it's easiest to m
On Fri, Feb 02, 2024 at 10:23:21AM -0800, Luis Chamberlain wrote:
> On Sat, Feb 03, 2024 at 12:20:38AM +0900, Masahiro Yamada wrote:
> > On Fri, Feb 2, 2024 at 3:05 AM Luis Chamberlain wrote:
> > >
> > > On Wed, Jan 31, 2024 at 02:11:44PM -0800, Luis Chamberlain wr
On Sat, Oct 19, 2024 at 01:45:35PM -0700, Luis Chamberlain wrote:
> On Thu, Oct 17, 2024 at 02:08:19PM +0200, Helge Deller wrote:
> > Hi Luis,
> >
> > On 10/17/24 01:21, Luis Chamberlain wrote:
> > > That sounds great. Yeah, the above would be great to test. A
module writing code, which may be more useful for more complex
cases later in the future.
Signed-off-by: Luis Chamberlain
---
I posted the v2 [0] a long time ago to account for some Helge's patches
and provide a vehicle for testing but Masahiro noted this should be
addressed on the asm cod
On Tue, Oct 15, 2024 at 11:18:57PM +, Matthew Maurer wrote:
> Adds a new format for MODVERSIONS which stores each field in a separate
> ELF section. This initially adds support for variable length names, but
> could later be used to add additional fields to MODVERSIONS in a
> backwards compatib
On Tue, Oct 15, 2024 at 11:18:59PM +, Matthew Maurer wrote:
> Generate both the existing modversions format and the new extended one
> when running modpost. Presence of this metadata in the final .ko is
> guarded by CONFIG_EXTENDED_MODVERSIONS.
>
> We no longer generate an error on long symbol
On Tue, Oct 15, 2024 at 11:18:59PM +, Matthew Maurer wrote:
> Generate both the existing modversions format and the new extended one
> when running modpost. Presence of this metadata in the final .ko is
> guarded by CONFIG_EXTENDED_MODVERSIONS.
>
> We no longer generate an error on long symbol
On Wed, Oct 16, 2024 at 05:29:21PM -0700, Sami Tolvanen wrote:
> Hi,
>
> On Tue, Oct 15, 2024 at 4:19 PM Matthew Maurer wrote:
> >
> > The `export_report.pl` script was broken [1] a while back due to a code
> > cleanup causing the regex to no longer match. Additionally, it assumes a
> > `modules.
On Sun, Oct 20, 2024 at 09:59:49PM +1100, Stephen Rothwell wrote:
> Hi,
>
> On Sat, 19 Oct 2024 14:21:00 -0700 Luis Chamberlain wrote:
> >
> > Use the new shared modules tree as we have more than one
> > modules maintainer now.
> >
> > git://git.kern
On Wed, Oct 16, 2024 at 04:18:41PM +0200, Thorsten Leemhuis wrote:
> Switch away from using sha1 for module signing by default and use the
> more modern sha512 instead, which is what among others Arch, Fedora,
> RHEL, and Ubuntu are currently using for their kernels.
>
> Sha1 has not been consider
On Tue, Oct 15, 2024 at 11:16:34PM +, Matthew Maurer wrote:
> Split out from Extended MODVERSIONS Support [1]
>
> This series refactors module validation during loading to ensure that
> everything is checked on its way in. This is intended to make the code
> robust enough that we can more conf
Use the new shared modules tree as we have more than one
modules maintainer now.
git://git.kernel.org/pub/scm/linux/kernel/git/modules/linux.git
Signed-off-by: Luis Chamberlain
---
Next/Trees | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Next/Trees b/Next/Trees
index
On Thu, Oct 17, 2024 at 02:08:19PM +0200, Helge Deller wrote:
> Hi Luis,
>
> On 10/17/24 01:21, Luis Chamberlain wrote:
> > That sounds great. Yeah, the above would be great to test. A while ago
> > I wrote a new modules selftests in order to test possible improvements
>
On Tue, Oct 15, 2024 at 04:22:22PM -0700, Matthew Maurer wrote:
> So, the basic things I can think of to test here are:
>
> 1. The kernel can still load the previous MODVERSIONS format
> 2. The kernel can load the new MODVERSIONS format
> 3. If we artificially tweak a CRC in the previous format, i
On Fri, Oct 11, 2024 at 04:45:25PM -0700, Luis Chamberlain wrote:
>
> Also, just as I asked Sami, coould you split this up into patch sets?
> One with all the cleanups and elf validation code shifts. And then the
> other code. That will let me pick up quickly the first patch set.
O
Also, just as I asked Sami, coould you split this up into patch sets?
One with all the cleanups and elf validation code shifts. And then the
other code. That will let me pick up quickly the first patch set.
Luis
On Tue, Oct 08, 2024 at 06:38:24PM +, Sami Tolvanen wrote:
> Hi,
>
> Here's v4 of the DWARF modversions series. The main motivation is
> modversions support for Rust, which is important for distributions
> like Android that are about to ship Rust kernel modules. Per Luis'
> request [1], v2 dro
On Fri, Oct 11, 2024 at 02:00:47PM +0200, Thorsten Leemhuis wrote:
> On 11.10.24 12:27, Thorsten Leemhuis wrote:
> > On 10.10.24 17:52, Sami Tolvanen wrote:
> > Thx for your feedback!
> >> On Thu, Oct 10, 2024 at 1:57 AM Thorsten Leemhuis
> >> wrote:
> >>> On 10.10.24 10:42, Sedat Dilek wrote:
>
On Fri, Oct 11, 2024 at 03:27:30PM -0700, Matthew Maurer wrote:
> On Fri, Oct 11, 2024 at 3:22 PM Luis Chamberlain wrote:
> >
> > On Wed, Sep 25, 2024 at 11:38:29PM +, Matthew Maurer wrote:
> > > Adds a new format for MODVERSIONS which stores each field in a separate
On Fri, Oct 11, 2024 at 03:22:54PM -0700, Matthew Maurer wrote:
> On Fri, Oct 11, 2024 at 3:13 PM Luis Chamberlain wrote:
> >
> > On Wed, Sep 25, 2024 at 11:38:28PM +, Matthew Maurer wrote:
> > > * modules.order has .o files when in a build dir, support this
>
On Wed, Sep 25, 2024 at 11:38:29PM +, Matthew Maurer wrote:
> Adds a new format for MODVERSIONS which stores each field in a separate
> ELF section. This initially adds support for variable length names, but
> could later be used to add additional fields to MODVERSIONS in a
> backwards compatib
On Wed, Sep 25, 2024 at 11:38:28PM +, Matthew Maurer wrote:
> * modules.order has .o files when in a build dir, support this
The commit log is not clear, is it that it's always had *.o files, and
you're adding them now, why? Why is the .ko search now removed?
> * .mod.c source layout has chan
question ;-)
>
> >
> > I don't want to block this change, but I just wonder why many modules
> > are removing MODULE_VERSION and we are adding it instead.
>
> Yep, that's a good point. I didn't know that other modules started to
> remove MODULE_VERSI
oming in future kernel releases.
This has been on linux-next for ~ 3 weeks now with no issues.
Chunhui Li (1):
module: abort module loading when sysfs setup suffer errors
Luis Chamberlain (1):
MAINTAINERS: scale modules
On Tue, Sep 10, 2024 at 08:31:23AM +0100, Vincent Donnefort wrote:
> commit ac3b43283923 ("module: replace module_layout with module_memory")
> introduced a set of memory regions for the module layout sharing the
> same attributes. However, it didn't update the kmemleak scanned areas
> which intend
t;
> Patch for make mod_sysfs_setup can check the error of
> add_notes_attrs and add_sysfs_attrs
>
> Fixes: db939b519bea ("Module section offsets in /sys/module")
> Fixes: 6d76013381ed ("Add /sys/module/name/notes")
> Acked-by: Luis Chamberlain
> Review
On Mon, Sep 09, 2024 at 11:23:56AM +0100, Vincent Donnefort wrote:
> On Mon, Sep 09, 2024 at 09:52:57AM +0100, Catalin Marinas wrote:
> > On Mon, Sep 09, 2024 at 08:40:34AM +0100, Vincent Donnefort wrote:
> > > On Sat, Sep 07, 2024 at 03:12:13PM +0100, Catalin Marinas wrote:
> > > > On Fri, Sep 06,
On Fri, Sep 06, 2024 at 04:38:56PM +0100, Vincent Donnefort wrote:
> commit ac3b43283923 ("module: replace module_layout with module_memory")
> introduced a set of memory regions for the module layout sharing the
> same attributes but didn't update the kmemleak scanned areas which
> intended to lim
t;
> Patch for make mod_sysfs_setup can check the error of
> add_notes_attrs and add_sysfs_attrs
>
> Acked-by: Luis Chamberlain
> Reviewed-by: Petr Pavlu
> Reported-by: kernel test robot
> Closes:
> https://lore.kernel.org/oe-kbuild-all/202409010016.3xifsmra-...@intel.com/
On Wed, Sep 04, 2024 at 08:41:07PM +0800, Chunhui Li wrote:
> When insmod a kernel module, if fails in add_notes_attrs or
> add_sysfs_attrs such as memory allocation fail, mod_sysfs_setup
> will still return success, but we can't access user interface
> on android device.
>
> Patch for make mod_sy
the code and so that we can scale.
Add those who have stepped up to help.
Signed-off-by: Luis Chamberlain
---
First order of business, please help review Kris Van Hees's patches with
Rust in mind!
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINER
On Mon, Jul 22, 2024 at 11:06:20AM +0200, Petr Pavlu wrote:
> Allow enabling the in-kernel module decompression support separately,
> without requiring to enable also the automatic compression during
> 'make modules_install'.
Applied and pushed, thanks!
Luis
On Wed, Jul 24, 2024 at 05:04:25PM +, Sami Tolvanen wrote:
> Hi Luis,
>
> On Thu, Jul 18, 2024 at 5:15 PM Luis Chamberlain wrote:
> >
> > On Tue, Jul 09, 2024 at 12:08:16PM +0200, Miguel Ojeda wrote:
> > > On Mon, Jul 8, 2024 at 11:42 PM Luis Chamberlain
&g
r respective Fixes tag?
Provided the commit logs are extended with Fixes and order is maintained
to be able to bisect correctly:
Reviewed-by: Luis Chamberlain
Luis
The following changes since commit 6ba59ff4227927d3a8530fc2973b80e94b54d58f:
Linux 6.10-rc4 (2024-06-16 13:40:16 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git/
tags/modules-6.11-rc1
for you to fetch changes up to 61842868de13a
1 - 100 of 659 matches
Mail list logo
