Re: [RFC PATCH 2/2] PM: hibernate: introduce opportunistic memory reclaim

2020-06-08 Thread Luigi Semenzato
Hi Andrea, 1. This mechanism is quite general. It is possible that, although hibernation may be an important use, there will be other uses for it. I suggest leaving the hibernation example and performance analysis, but not mentioning PM or hibernation in the patch subject. 2. It may be useful to

Re: is hibernation usable?

2019-10-22 Thread Luigi Semenzato
On Tue, Oct 22, 2019 at 4:16 PM Rafael J. Wysocki wrote: > > On Wed, Oct 23, 2019 at 12:53 AM Luigi Semenzato wrote: > > > > On Tue, Oct 22, 2019 at 3:14 PM Rafael J. Wysocki wrote: > > > > > > On Tue, Oct 22, 2019 at 11:26 PM Luigi Semenzato > >

Re: is hibernation usable?

2019-10-22 Thread Luigi Semenzato
On Tue, Oct 22, 2019 at 3:14 PM Rafael J. Wysocki wrote: > > On Tue, Oct 22, 2019 at 11:26 PM Luigi Semenzato wrote: > > > > Thank you for the quick reply! > > > > On Tue, Oct 22, 2019 at 1:57 PM Rafael J. Wysocki wrote: > > > > > > On Tue, Oct 22

Re: is hibernation usable?

2019-10-22 Thread Luigi Semenzato
Thank you for the quick reply! On Tue, Oct 22, 2019 at 1:57 PM Rafael J. Wysocki wrote: > > On Tue, Oct 22, 2019 at 10:09 PM Luigi Semenzato wrote: > > > > Following a thread in linux-pm > > (https://marc.info/?l=linux-mm&m=157012300901871) I have some issues > &g

is hibernation usable?

2019-10-22 Thread Luigi Semenzato
Following a thread in linux-pm (https://marc.info/?l=linux-mm&m=157012300901871) I have some issues that may be of general interest. 1. To the best of my knowledge, Linux hibernation is guaranteed to fail if more than 1/2 of total RAM is in use (for instance, by anonymous pages). My knowledge is

Re: mmotm 2019-05-29-20-52 uploaded

2019-05-29 Thread Luigi Semenzato
My apologies but the patch mm-smaps-split-pss-into-components.patch has a bug (does not update private_clean and private_dirty). Please do not include it. I will resubmit a corrected version. Thanks. On Wed, May 29, 2019 at 8:53 PM wrote: > > The mm-of-the-moment snapshot 2019-05-29-20-52

Re: [PATCH] Input: cros_ec_keyb - avoid variable-length arrays on stack

2014-01-02 Thread Luigi Semenzato
On Thu, Jan 2, 2014 at 11:48 AM, Dmitry Torokhov wrote: > Hi Doug, > > On Thu, Jan 02, 2014 at 09:40:44AM -0800, Doug Anderson wrote: >> Dmitry, >> >> Thanks for cleaning up cros_eckeyb. :) I'm a little curious about >> the motivation here. I can't imagine a keyboard with all that many >> colum

Re: [PATCH] Input: cros_ec_keyb - switch from using uint8_t to u8

2014-01-02 Thread Luigi Semenzato
Thank you, this is useful information, and it would be even more useful if it made it in Documentation/CodingStyle :-) On Thu, Jan 2, 2014 at 11:27 AM, Dmitry Torokhov wrote: > On Thu, Jan 02, 2014 at 08:12:09AM -0800, Doug Anderson wrote: >> Dmitry, >> >> On Tue, Dec 31, 2013 at 11:34 AM, Dmit

Re: user defined OOM policies

2013-11-20 Thread Luigi Semenzato
On Wed, Nov 20, 2013 at 7:22 AM, Michal Hocko wrote: > On Wed 20-11-13 00:02:20, David Rientjes wrote: >> On Tue, 19 Nov 2013, Michal Hocko wrote: >> >> > > We have basically ended up with 3 options AFAIR: >> > > 1) allow memcg approach (memcg.oom_control) on the root level >> > >for

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-07 Thread Luigi Semenzato
On Thu, Nov 7, 2013 at 9:06 AM, Luigi Semenzato wrote: -> Android 4.4 KitKat is also using zram, to better support devices with -> less than 1 MB RAM. (That's the news.) Sorry, I meant 1 GB RAM. http://dilbert.com/strips/comic/1991-09-27/ -- To unsubscribe from this list: se

Re: [PATCH] staging: zsmalloc: Ensure handle is never 0 on success

2013-11-07 Thread Luigi Semenzato
If I may add my usual 2c (and some news): zram is used by default on all Chrome OS devices. I can't say how many devices, but it's not a small number, google it, and it's an important market, low-end laptops for education and the less affluent. It has been available experimentally for well over

Re: [PATCH] mm, oom: Fix race when selecting process to kill

2013-11-05 Thread Luigi Semenzato
would be removed at the end of each scan. I think this would work, i.e. it would have all the right properties, but I don't have a sense of whether the performance impact is acceptable. Probably not, or it would have been proposed earlier. On Tue, Nov 5, 2013 at 8:45 PM, Luigi Semenzato

Re: [PATCH] mm, oom: Fix race when selecting process to kill

2013-11-05 Thread Luigi Semenzato
h. On Tue, Nov 5, 2013 at 7:04 PM, Sameer Nanda wrote: > > > > On Tue, Nov 5, 2013 at 5:27 PM, David Rientjes wrote: >> >> On Tue, 5 Nov 2013, Luigi Semenzato wrote: >> >> > It's not enough to hold a reference to the task struct, because it can >>

Re: [PATCH] mm, oom: Fix race when selecting process to kill

2013-11-05 Thread Luigi Semenzato
It's not enough to hold a reference to the task struct, because it can still be taken out of the circular list of threads. The RCU assumptions don't hold in that case. On Tue, Nov 5, 2013 at 5:18 PM, David Rientjes wrote: > On Tue, 5 Nov 2013, Sameer Nanda wrote: > >> The selection of the proces

Re: zram/zsmalloc issues in very low memory conditions

2013-10-31 Thread Luigi Semenzato
34 PM, Olav Haugan wrote: > Hi Luigi, > > On 10/24/2013 6:12 PM, Luigi Semenzato wrote: >> On Thu, Oct 24, 2013 at 5:35 PM, Olav Haugan wrote: >>> Hi Bob, Luigi, >>> >>> On 10/23/2013 5:55 PM, Bob Liu wrote: >>>> >>>> On 10/24/2013

Re: zram/zsmalloc issues in very low memory conditions

2013-10-24 Thread Luigi Semenzato
On Thu, Oct 24, 2013 at 5:35 PM, Olav Haugan wrote: > Hi Bob, Luigi, > > On 10/23/2013 5:55 PM, Bob Liu wrote: >> >> On 10/24/2013 05:51 AM, Olav Haugan wrote: >>> I am trying to use zram in very low memory conditions and I am having >>> some issues. zram is in the reclaim path. So if the system i

Re: zram/zsmalloc issues in very low memory conditions

2013-10-23 Thread Luigi Semenzato
(sorry about the HTML in the previous message) On Wed, Oct 23, 2013 at 2:51 PM, Olav Haugan wrote: > I am trying to use zram in very low memory conditions and I am having > some issues. zram is in the reclaim path. So if the system is very low > on memory the system is trying to reclaim pages by

Re: [tpmdd-devel] [PATCH] tpm: MAINTAINERS: Add myself as tpm maintainer

2013-10-22 Thread Luigi Semenzato
I know how to reach Rajiv. Let me ping him. (I am not copying him here for privacy.) On Tue, Oct 22, 2013 at 12:42 PM, Ashley D Lai wrote: > On Tue, 2013-10-22 at 21:33 +0200, Peter Huewe wrote: >> Hi Joel, >> >> > Gesendet: Dienstag, 22. Oktober 2013 um 19:55 Uhr >> > Von: "Joel Schopp" >> >>

Re: [tpmdd-devel] [PATCH 01/15] tpm: MAINTAINERS: Add myself as tpm maintainer

2013-10-22 Thread Luigi Semenzato
I completely support Peter's request, and many thanks to Peter for volunteering. On Tue, Oct 22, 2013 at 10:53 AM, Peter Huewe wrote: > Since I'm actively maintaining the tpm subsystem for a few months now, > it's time to step up and be an official maintainer for the tpm subsystem, > atleast unti

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-18 Thread Luigi Semenzato
On Sun, Aug 18, 2013 at 9:37 PM, Minchan Kim wrote: > Hello Bob, > > Sorry for the late response. I was on holiday. > > On Mon, Aug 19, 2013 at 11:57:41AM +0800, Bob Liu wrote: >> Hi Minchan, >> >> On 08/19/2013 11:18 AM, Minchan Kim wrote: >> > Hello Mel, >> > >> > On Fri, Aug 16, 2013 at 09:33:4

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-14 Thread Luigi Semenzato
On Wed, Aug 14, 2013 at 10:40 AM, Mel Gorman wrote: > On Wed, Aug 14, 2013 at 02:55:31PM +0900, Minchan Kim wrote: >> It's 6th trial of zram/zsmalloc promotion. >> [patch 5, zram: promote zram from staging] explains why we need zram. >> >> Main reason to block promotion is there was no review of z

Re: [PATCH v6 0/5] zram/zsmalloc promotion

2013-08-14 Thread Luigi Semenzato
During earlier discussions of zswap there was a plan to make it work with zsmalloc as an option instead of zbud. Does zbud work for compression factors better than 2:1? I have the impression (maybe wrong) that it does not. In our use of zram (Chrome OS) typical overall compression ratios are betw

Re: [tpmdd-devel] tpm_tis driver failed to suspend, error -62

2013-03-19 Thread Luigi Semenzato
Error 62 is ETIME. The driver is timing out during a tpm_send, possibly trying to send the Tpm_SaveState command. It may be that you cannot talk to the TPM at all. Have you tried sending messages to the TPM before suspending? Are there any other tpm entries in the syslog? Like at boot? What m

Re: [PATCH 1/2] mm: prevent to add a page to swap if may_writepage is unset

2013-01-10 Thread Luigi Semenzato
[I may have screwed up my previous message, sorry if this is a duplicate. (Content-Policy reject msg: The message contains HTML subpart, therefore we consider it SPAM or Outlook Virus.)] -- For what it's worth, I tested this patch on my 3.4 kernel, and it

Re: [PATCH 0/8] zswap: compressed swap caching

2012-12-12 Thread Luigi Semenzato
Just a couple of questions and comments as a user. I apologize if this is the wrong time to make them, feel free to ignore them. 1. It's becoming difficult to understand how zcache, zcache2, zram, and now zswap, interact and/or overlap with each other. For instance, I am examining the possibilit

Re: [PATCH v4 0/3] zram/zsmalloc promotion

2012-11-07 Thread Luigi Semenzato
Since Chrome OS was mentioned: the main reason why we don't use swap to a disk (rotating or SSD) is because it doesn't degrade gracefully and leads to a bad interactive experience. Generally we prefer to manage RAM at a higher level, by transparently killing and restarting processes. But we notic

[tip:perf/urgent] perf tools: do not flush maps on COMM for perf report

2012-10-23 Thread tip-bot for Luigi Semenzato
Commit-ID: 9fdbf671ba7e8adb2cbb93d716232ebcab55f6bd Gitweb: http://git.kernel.org/tip/9fdbf671ba7e8adb2cbb93d716232ebcab55f6bd Author: Luigi Semenzato AuthorDate: Tue, 21 Aug 2012 14:52:20 -0700 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 22 Oct 2012 13:55:53 -0200 perf tools

Re: [PATCH] perf: do not flush maps on COMM for perf report

2012-08-22 Thread Luigi Semenzato
There is also this (incomplete, untested) patch, which shows what it takes to add the new record type. https://lkml.org/lkml/2012/3/2/345 On Wed, Aug 22, 2012 at 11:16 AM, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 22, 2012 at 10:56:13AM -0600, David Ahern escreveu: >> On 8/22/12 10:29 AM, Ar

Re: [PATCH] perf: do not flush maps on COMM for perf report

2012-08-22 Thread Luigi Semenzato
On Wed, Aug 22, 2012 at 12:28 AM, Ingo Molnar wrote: > > * Luigi Semenzato wrote: > >> This fixes a long-standing bug caused by the lack of separate >> COMM and EXEC record types, which makes "perf report" lose >> track of symbols when a process renames itse

[PATCH] perf: do not flush maps on COMM for perf report

2012-08-21 Thread Luigi Semenzato
nes) and is not necessary. Signed-off-by: Luigi Semenzato --- tools/perf/util/thread.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/tools/perf/util/thread.c b/tools/perf/util/thread.c index fb4b7ea..8b3e593 100644 --- a/tools/perf/util/thread.c +++ b/tools/perf/util/threa