looks good, I assume that for now, you're relying on additional
patches for the control path, like mhi_uci or mhi_wwan_ctrl.
Reviewed-by: Loic Poulain
> ---
> drivers/bus/mhi/pci_generic.c | 47 +++
> 1 file changed, 47 insertions(+)
>
> diff --git
Hi Dan,
On Wed, 7 Apr 2021 at 16:32, Dan Williams wrote:
>
> On Mon, 2021-04-05 at 11:52 +0200, Loic Poulain wrote:
> > This change introduces initial support for a WWAN framework. Given
> > the
> > complexity and heterogeneity of existing WWAN hardwares and
> &g
Hi Jarvis,
On Wed, 7 Apr 2021 at 04:51, Jarvis Jiang wrote:
>
> Add support for T99W175 modems, this modem series is based on SDX55
> qcom chip. The modem is mainly based on MBIM protocol for both the
> data and control path.
>
> This patch was tested with Ubuntu 20.04 X86_64 PC as host
>
> Signe
On Fri, 2 Apr 2021 at 23:33, Bhaumik Bhatt wrote:
>
> Add generic info for SDX65 based modems.
>
> Signed-off-by: Bhaumik Bhatt
> ---
> This patch was tested on SDX65 hardware with Ubuntu X86_64 PC as host.
Good to see that!
Reviewed-by: Loic Poulain
On Mon, 5 Apr 2021 at 11:44, Loic Poulain wrote:
>
> The MHI WWWAN control driver allows MHI QCOM-based modems to expose
> different modem control protocols/ports via the WWAN framework, so that
> userspace modem tools or daemon (e.g. ModemManager) can control WWAN
> config and st
for controlling a modem, and
for which related opensource userpace support exist.
Signed-off-by: Loic Poulain
---
v2: update copyright (2021)
v3: Move driver to dedicated drivers/net/wwan directory
v4: Rework to use wwan framework instead of self cdev management
v5: Fix errors/typos in
annes's earlier WWAN
subsystem proposal.
This initial version is purposely minimalist, it's essentially moving
the generic part of the previously proposed mhi_wwan_ctrl driver inside
a common WWAN framework, but the implementation is open and flexible
enough to allow extension for furth
On Fri, 2 Apr 2021 at 17:43, Greg KH wrote:
>
> On Fri, Apr 02, 2021 at 05:41:01PM +0200, Loic Poulain wrote:
> > On Fri, 2 Apr 2021 at 16:05, Greg KH wrote:
> > >
> > > On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote:
> > > > The MHI
On Fri, 2 Apr 2021 at 16:05, Greg KH wrote:
>
> On Fri, Apr 02, 2021 at 04:06:37PM +0200, Loic Poulain wrote:
> > The MHI WWWAN control driver allows MHI QCOM-based modems to expose
> > different modem control protocols/ports via the WWAN framework, so that
> > userspa
for controlling a modem, and
for which related opensource userpace support exist.
Signed-off-by: Loic Poulain
---
v2: update copyright (2021)
v3: Move driver to dedicated drivers/net/wwan directory
v4: Rework to use wwan framework instead of self cdev management
v5: Fix errors/typos in
work, but the implementation is open and flexible
enough to allow extension for further drivers.
Signed-off-by: Loic Poulain
---
v2: not part of the series
v3: not part of the series
v4: Introduce WWAN framework/subsystem
v5: Specify WWAN_CORE module name in Kconfig
v6: - Move to unified
hasivam
Reviewed-by: Loic Poulain
ove
> conditionals in handling firmware load for PBL modes and keeps
> the execution environment out of the picture as it can change at
> any time.
>
> Signed-off-by: Bhaumik Bhatt
Reviewed-by: Loic Poulain
r up instead by identifying Flash
> Programmer as a valid mission mode execution environment with a
> purpose to flash the device image contents.
>
> Signed-off-by: Bhaumik Bhatt
> Reviewed-by: Manivannan Sadhasivam
Reviewed-by: Loic Poulain
nels using Firehose protocol. Link to USB flashing
> tool: https://git.linaro.org/landing-teams/working/qualcomm/qdl.git/
>
> Make the necessary changes to allow for this sequence to occur and
> allow using the Flash Programmer execution environment.
>
> Signed-off-by: Carl Yin
&g
gt; within the MHI core driver and helps pave the way for Flash
> Programmer execution environment functionality.
>
> Signed-off-by: Bhaumik Bhatt
Reviewed-by: Loic Poulain
lash Programmer execution environment.
>
> Signed-off-by: Bhaumik Bhatt
> Reviewed-by: Manivannan Sadhasivam
Reviewed-by: Loic Poulain
ly on the local 'fw_name' variable
> as a safer alternative.
>
> Signed-off-by: Bhaumik Bhatt
> Reviewed-by: Manivannan Sadhasivam
Reviewed-by: Loic Poulain
On Thu, 18 Mar 2021 at 17:13, Jeffrey Hugo wrote:
>
> On 3/17/2021 3:26 PM, Bhaumik Bhatt wrote:
> > On 2021-03-11 11:59 AM, Jeffrey Hugo wrote:
> >> On 3/11/2021 1:00 AM, Loic Poulain wrote:
> >>> Hi Bhaumik,
> >>>
> >>>
esses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King
Reviewed-by: Loic Poulain
> ---
> drivers/bus/mhi/core/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
>
Hi Greg,
On Fri, 12 Mar 2021 at 07:56, Greg KH wrote:
>
> On Thu, Mar 11, 2021 at 09:41:03PM +0100, Loic Poulain wrote:
> > This change introduces initial support for a WWAN subsystem. Given the
> > complexity and heterogeneity of existing WWAN hardwares and interfaces,
>
Hi Greg,
On Fri, 12 Mar 2021 at 09:16, Greg KH wrote:
>
> On Thu, Mar 11, 2021 at 09:41:04PM +0100, Loic Poulain wrote:
> > The MHI WWWAN control driver allows MHI QCOM-based modems to expose
> > different modem control protocols/ports to userspace, so that userspace
> &g
subsystem (when available) or to be discussed as a
new MHI driver (e.g AI accelerator, WiFi debug channels, etc...).
Signed-off-by: Loic Poulain
---
v2: update copyright (2021)
v3: Move driver to dedicated drivers/net/wwan directory
v4: Rework to use wwan framework instead of self cdev
the implementation is open and flexible
enough to allow extension for further drivers.
Signed-off-by: Loic Poulain
---
v2: not part of the series
v3: not part of the series
v4: Introduce WWAN framework/subsystem
v5: Specify WWAN_CORE module name in Kconfig
drivers/net/Kconfig
On Thu, 11 Mar 2021 at 17:48, Greg KH wrote:
>
> On Thu, Mar 11, 2021 at 05:39:05PM +0100, Loic Poulain wrote:
> > This change introduces initial support for a WWAN subsystem. Given the
> > complexity and heterogeneity of existing WWAN hardwares and interfaces,
> > there
subsystem (when available) or to be discussed as a
new MHI driver (e.g AI accelerator, WiFi debug channels, etc...).
Signed-off-by: Loic Poulain
---
drivers/net/wwan/Kconfig | 14 ++
drivers/net/wwan/Makefile| 1 +
drivers/net/wwan/mhi_wwan_ctrl.c | 497
the implementation is open and flexible
enough to allow extension for further drivers.
Signed-off-by: Loic Poulain
---
drivers/net/Kconfig | 2 +
drivers/net/Makefile | 1 +
drivers/net/wwan/Kconfig | 19 ++
drivers/net/wwan/Makefile| 8 +++
driv
Hi Bhaumik,
On Thu, 11 Mar 2021 at 00:31, Bhaumik Bhatt wrote:
>
> Introduce helper function to allow MHI core driver to poll for
> a value in a register field. This helps reach a common path to
> read and poll register values along with a retry time interval.
>
> Signed-off-by: Bhaumik Bhatt
>
Hi Greg,
On Tue, 9 Mar 2021 at 10:35, Greg KH wrote:
>
> On Tue, Mar 09, 2021 at 09:42:16AM +0100, Loic Poulain wrote:
> > The MHI WWWAN control driver allows MHI Qcom based modems to expose
> > different modem control protocols/ports to userspace, so that userspace
> &g
ned-off-by: Loic Poulain
---
v2: update copyright (2021)
v3: Move driver to dedicated drivers/net/wwan directory
drivers/net/Kconfig | 2 +
drivers/net/Makefile | 1 +
drivers/net/wwan/Kconfig | 26 ++
drivers/net/wwan/Makefile| 6 +
driver
On Tue, 9 Mar 2021 at 09:19, Greg KH wrote:
>
> On Mon, Mar 08, 2021 at 09:59:27PM +0100, Loic Poulain wrote:
> > The MHI WWWAN control driver allows MHI Qcom based modems to expose
> > different modem control protocols to userspace, so that userspace
> > modem tools or d
Hi Jakub,
On Mon, 8 Mar 2021 at 19:51, Jakub Kicinski wrote:
>
> On Mon, 8 Mar 2021 19:40:51 +0100 Loic Poulain wrote:
> > The MHI WWWAN control driver allows MHI Qcom based modems to expose
> > different modem control protocols to userspace, so that userspace
> > mo
to be discussed as a
new MHI driver (e.g AI accelerator, WiFi debug channels, etc...).
Co-developed-by: Hemant Kumar
Signed-off-by: Hemant Kumar
Signed-off-by: Loic Poulain
---
v2: update copyright (2021)
drivers/bus/mhi/Kconfig | 12 +
drivers/bus/mhi/Makefile| 3 +
drivers/bus
to be discussed as a
new MHI driver (e.g AI accelerator, WiFi debug channels, etc...).
Co-developed-by: Hemant Kumar
Signed-off-by: Hemant Kumar
Signed-off-by: Loic Poulain
---
drivers/bus/mhi/Kconfig | 12 +
drivers/bus/mhi/Makefile| 3 +
drivers/bus/mhi/wwan_ctrl.c | 559
On Thu, 4 Mar 2021 at 23:14, Bhaumik Bhatt wrote:
>
> As per documentation, fields marked as (required) in an MHI
> controller structure need to be populated by the controller driver
> before calling mhi_register_controller(). Ensure all required
> pointers and non-zero fields are present in the c
On Wed, 24 Feb 2021 at 04:44, Bhaumik Bhatt wrote:
>
> Introduce helper function to allow MHI core driver to poll for
> a value in a register field. This helps reach a common path to
> read and poll register values along with a retry time interval.
>
> Signed-off-by: Bhaumik Bhatt
> ---
> driver
On Thu, 25 Feb 2021 at 00:23, Bhaumik Bhatt wrote:
>
> Update debug prints to include local device in the BHI interrupt
> handler. This helps show transitions better between MHI states.
>
> Signed-off-by: Bhaumik Bhatt
> Reviewed-by: Manivannan Sadhasivam
Reviewed-by: Loic Poulain
we use the correct execution environment
> to notify the controller driver when the device resets to one of
> the PBL execution environments.
>
> Signed-off-by: Bhaumik Bhatt
Looking good now
Reviewed-by: Loic Poulain
e host download the AMSS
> image from the SBL transition of PM state worker thread when a
> DEV_ST_TRANSITION_SBL is queued instead of the blocking wait.
>
> Signed-off-by: Bhaumik Bhatt
> Reviewed-by: Manivannan Sadhasivam
Reviewed-by: Loic Poulain
d destroy
> devices in such scenarios that allow SBL client drivers to clean
> up once device enters mission mode.
>
> Signed-off-by: Bhaumik Bhatt
Reviewed-by: Loic Poulain
On Wed, 17 Feb 2021 at 16:06, Jeffrey Hugo wrote:
>
> On 2/17/2021 8:02 AM, Loic Poulain wrote:
> > On Tue, 16 Feb 2021 at 19:50, Jeffrey Hugo wrote:
> >>
> >> From: Fan Wu
> >>
> >> Currently ENOMEM is returned when MHI ring is full. This err
On Tue, 16 Feb 2021 at 19:50, Jeffrey Hugo wrote:
>
> From: Fan Wu
>
> Currently ENOMEM is returned when MHI ring is full. This error code is
> very misleading. Change to EBUSY instead.
Well, there is no space left in the ring, so it's no so misleading.
Regards,
Loic
ilure, which is likely to incorrectly cause a device init failure
> if syserr was detected at power_up. Fix this.
>
> Fixes: e18d4e9fa79b ("bus: mhi: core: Handle syserr during power_up")
> Signed-off-by: Jeffrey Hugo
Reviewed-by: Loic Poulain
> ---
> drivers/bus/mhi/core
Add support for basic PM operations")
> Signed-off-by: Jeffrey Hugo
So in that function, 'ee' should be 'previous_ee', right?
Reviewed-by: Loic Poulain
Hi Jakub,
On Wed, 3 Feb 2021 at 19:05, Jakub Kicinski wrote:
>
> On Wed, 03 Feb 2021 09:45:06 +0530 Manivannan Sadhasivam wrote:
> > >> Jakub, Dave, Adding you both to get your reviews on this series. I've
> > >> provided an explanation above and in the previous iteration [1].
> > >
> > >Let's be
Hi Daniele,
On Tue, 19 Jan 2021 at 23:06, Bjorn Helgaas wrote:
>
> On Tue, Jan 19, 2021 at 11:27:57AM +0100, Daniele Palmas wrote:
> > Add Telit Vendor ID to pci_ids.h
>
> From the top of the file:
>
> * Do not add new entries to this file unless the definitions
> * are shared between
On Mon, 11 Jan 2021 at 18:28, Jakub Kicinski wrote:
>
> On Mon, 11 Jan 2021 18:16:17 +0100 Loic Poulain wrote:
> > From: Hemant Kumar
> >
> > Introduce mhi_get_free_desc_count() API to return number
> > of TREs available to queue buffer. MHI clients can use this
The RX queue size can be determined at runtime by retrieving the
number of available transfer descriptors.
Signed-off-by: Loic Poulain
---
drivers/net/mhi_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
index b7f7f2e
Use the new mhi_get_free_desc_count helper to track queue usage
instead of relying on the locally maintained rx_queued count.
Signed-off-by: Loic Poulain
---
drivers/net/mhi_net.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/net/mhi_net.c b/drivers
From: Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number
of TREs available to queue buffer. MHI clients can use this
API to know before hand if ring is full without calling queue
API.
Signed-off-by: Hemant Kumar
Reviewed-by: Jeffrey Hugo
Reviewed-by: Manivannan Sadhasivam
-
The RX queue size can be determined at runtime by retrieving the
number of available transfer descriptors.
Signed-off-by: Loic Poulain
---
drivers/net/mhi_net.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/mhi_net.c b/drivers/net/mhi_net.c
index b7f7f2e
From: Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number
of TREs available to queue buffer. MHI clients can use this
API to know before hand if ring is full without calling queue
API.
Signed-off-by: Hemant Kumar
Reviewed-by: Jeffrey Hugo
Reviewed-by: Manivannan Sadhasivam
-
Hi Jakub,
On Thu, 17 Dec 2020 at 17:58, Jakub Kicinski wrote:
>
> On Thu, 17 Dec 2020 16:34:09 +0100 Loic Poulain wrote:
> > MHI net is protocol agnostic, the payload protocol depends on the modem
> > configuration, which can be either RMNET (IP muxing and aggregation) or
>
MHI net is protocol agnostic, the payload protocol depends on the modem
configuration, which can be either RMNET (IP muxing and aggregation) or
raw IP. This patch adds support for incomming IPv4/IPv6 packets, that
was previously unconditionnaly reported as RMNET packets.
Signed-off-by: Loic
Hi Folks,
On Fri, 11 Dec 2020 at 20:45, Hemant Kumar wrote:
>
> This patch series adds support for UCI driver. UCI driver enables userspace
> clients to communicate to external MHI devices like modem. UCI driver probe
> creates standard character device file nodes for userspace clients to
> perfo
On Fri, 11 Dec 2020 at 08:44, Greg KH wrote:
>
> On Thu, Dec 10, 2020 at 11:04:11PM -0800, Hemant Kumar wrote:
> > This MHI client driver allows userspace clients to transfer
> > raw data between MHI device and host using standard file operations.
> > Driver instantiates UCI device object which is
On Tue, 1 Dec 2020 at 18:51, Jeffrey Hugo wrote:
>
> On 12/1/2020 10:52 AM, Loic Poulain wrote:
> > On Tue, 1 Dec 2020 at 18:37, Jeffrey Hugo wrote:
> >>
> >> On 12/1/2020 10:36 AM, Loic Poulain wrote:
> >>> On Tue, 1 Dec 2020 at 02:16,
On Tue, 1 Dec 2020 at 18:37, Jeffrey Hugo wrote:
>
> On 12/1/2020 10:36 AM, Loic Poulain wrote:
> > On Tue, 1 Dec 2020 at 02:16, Hemant Kumar wrote:
> >>
> >> Hi Loic,
> >>
> >> On 11/30/20 10:22 AM, Loic Poulain wrote:
> >>> On Sat, 2
On Tue, 1 Dec 2020 at 02:16, Hemant Kumar wrote:
>
> Hi Loic,
>
> On 11/30/20 10:22 AM, Loic Poulain wrote:
> > On Sat, 28 Nov 2020 at 04:26, Hemant Kumar wrote:
> >>
> >> This MHI client driver allows userspace clients to transfer
> >> raw data be
er of how things were allocated. I changed
> the label names to say what the goto does instead of describing where
> the goto comes from.
>
> Fixes: 8f7039787687 ("bus: mhi: core: Move to using high priority workqueue")
> Signed-off-by: Dan Carpenter
Reviewed-by: Loic Poulain
On Sat, 28 Nov 2020 at 04:26, Hemant Kumar wrote:
>
> This MHI client driver allows userspace clients to transfer
> raw data between MHI device and host using standard file operations.
> Driver instantiates UCI device object which is associated to device
> file node. UCI device object instantiates
Just one comment:
On Mon, 16 Nov 2020 at 23:46, Hemant Kumar wrote:
>
> This MHI client driver allows userspace clients to transfer
> raw data between MHI device and host using standard file operations.
> Driver instantiates UCI device object which is associated to device
> file node. UCI device
On Mon, 16 Nov 2020 at 23:46, Hemant Kumar wrote:
>
> Introduce mhi_get_free_desc_count() API to return number
> of TREs available to queue buffer. MHI clients can use this
> API to know before hand if ring is full without calling queue
> API.
>
> Signed-off-by: Hemant Kumar
> Reviewed-by: Jeffre
On Mon, 16 Nov 2020 at 23:46, Hemant Kumar wrote:
>
> Loopback test opens the MHI device file node and writes
> a data buffer to it. MHI UCI kernel space driver copies
> the data and sends it to MHI uplink (Tx) LOOPBACK channel.
> MHI device loops back the same data to MHI downlink (Rx)
> LOOPBACK
Hi Bhaumik,
On Wed, 11 Nov 2020 at 01:40, Bhaumik Bhatt wrote:
>
> Hi Loic,
>
> On 2020-11-10 03:14, Loic Poulain wrote:
> > Hi Bhaumik,
> >
> > On Mon, 9 Nov 2020 at 23:44, Bhaumik Bhatt
> > wrote:
> >>
> >> Some MHI clients may wa
Hi Bhaumik,
On Mon, 9 Nov 2020 at 23:44, Bhaumik Bhatt wrote:
>
> Some MHI clients may want to request for pausing or resuming of the
> data transfers for their channels. Enable them to do so using the new
> APIs provided for the same.
>
> Signed-off-by: Bhaumik Bhatt
> ---
> drivers/bus/mhi/co
Hi Hemant,
A few comments inline.
On Thu, 22 Oct 2020 at 10:22, Hemant Kumar wrote:
>
> This MHI client driver allows userspace clients to transfer
> raw data between MHI device and host using standard file operations.
> Driver instantiates UCI device object which is associated to device
> file
On Wed, 21 Oct 2020 at 18:25, Manivannan Sadhasivam
wrote:
>
> On Wed, Oct 21, 2020 at 05:43:14PM +0200, Loic Poulain wrote:
> > On Wed, 21 Oct 2020 at 17:27, Manivannan Sadhasivam <
> > manivannan.sadhasi...@linaro.org> wrote:
> >
> > > On Fri, Oct 16,
Hi Hemant,
See comments inline, but globally, the locking and ref counting is
more complicated than it should be.
On Wed, 16 Sep 2020 at 21:57, Hemant Kumar wrote:
>
> This MHI client driver allows userspace clients to transfer
> raw data between MHI device and host using standard file operation
On Thu, 3 Sep 2020 at 09:19, Jie Deng wrote:
>
>
> On 2020/9/3 14:12, Jason Wang wrote:
> >
> > On 2020/9/3 下午1:34, Jie Deng wrote:
> >> Add an I2C bus driver for virtio para-virtualization.
> >>
> >> The controller can be emulated by the backend driver in
> >> any device model software by followi
ernel/git/torvalds/linux.git/commit/?id=03864e57770a9541e7ff3990bacf2d9a2fffcd5d
>
> No dice, same exact problem.
>
> But the patch is present downstream[1]:
>
> commit c26727f853308dc4a6645dad09e9565429f8604f
> Author: Loic Poulain
> Date: Wed Dec 12 17:51:48 2018 +01
On Wed, 11 Sep 2019 at 19:54, Guenter Roeck wrote:
>
> On Wed, Sep 11, 2019 at 10:04:12AM +0200, Loic Poulain wrote:
> > Hi Guenter, Jorge,
> >
> > On Mon, 9 Sep 2019 at 00:50, Guenter Roeck wrote:
> >
> > > On 9/6/19 1:30 PM, Jorge Ramirez-Ortiz wrote:
&g
Hi Sakari,
>> Any comments on this change?
>
> https://patchwork.linuxtv.org/project/linux-media/list/?submitter=Maxime+Ripard&state=*&q=ov5640>
>
> There's also another set that adds PIXEL_CLOCK (as well as LINK_FREQ)
> support to the driver, that seems more complete than this patch but
> require
ccording to the datasheet, 96MHz can be used as a pixel clock rate for
> most of the modes.
>
> Signed-off-by: Manivannan Sadhasivam
Tested-by: Loic Poulain
It works for me on Dragonboard 410c + D3 camera mezzanine (ov5640) .
Any comments on this change?
Regards,
Loic
Hi Srini,
On 16 March 2018 at 22:54, wrote:
> From: Srinivas Kandagatla
>
> This patch add support to DB600c board, which is another
> 96boards based on Qualcomm APQ8064 SoC.
>
> Support for USB, HDMI, PCIe, I2C, SPI, eMMC, microSD card, LEDs
> device tree nodes is added in this patch.
>
> Sign
Hi Ramon,
On 29 March 2018 at 09:32, Ramon Fried wrote:
>> Should we document qcom,wcn3610 just like wcn3620 is:
>>
>> Documentation/devicetree/bindings/remoteproc/qcom,wcnss-pil.txt:
>>"qcom,wcn3620",
> IMHO the mentioned bindings is related to the PIL (peripheral image loa
On 13 March 2018 at 17:03, Thierry Escande wrote:
> From: Thierry Escande
>
> Add support for Qualcomm serial slave devices. Probe the serial device,
> retrieve its maximum speed and register a new hci uart device.
>
> Signed-off-by: Thierry Escande
> ---
> drivers/bluetooth/Kconfig | 2 +-
Hi Colin, Bjorn,
On 26 December 2017 at 21:13, Bjorn Andersson
wrote:
> On Tue 19 Dec 09:04 PST 2017, Colin King wrote:
>
>> From: Colin Ian King
>>
>> msg_body.min_ch_time is being assigned twice; remove the redundant
>> first assignment.
>>
>> Detected by CoverityScan, CID#1463042 ("Unused Val
Hi Peter,
> So it seems it's actually working fine albeit the strange mac addr, no
> idea what I was trying before, although there's an error about loading
> firmware:
>
> [ 31.035291] Bluetooth: hci0: BCM: chip id 94
> [ 31.035801] Bluetooth: hci0: BCM: features 0x2e
> [ 31.037483] Bluetoot
parameter and global variables
e) Add logic to pick right firmware image
v4: Addresses review comments from Alan
a) Use existing kernel helper APIs instead of writing own.
b) Replace mdelay() with msleep()
v5: Addresses review comments from Loic Poulain
a) Use bt_dev_err/warn/dbg helpers
Hi Amitkumar,
Hi Marcel,
I suggest you to add Marcel as recipient of your patches.
From: Jeffy Chen [mailto:jeffy.c...@rock-chips.com]
Sent: Friday, June 24, 2016 11:32 AM
To: Amitkumar Karwar; linux-blueto...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org; Ganapathi Bhat
Subject: Re: [
image
v4: Addresses review comments from Alan
a) Use existing kernel helper APIs instead of writing own.
b) Replace mdelay() with msleep()
v5: Addresses review comments from Loic Poulain
a) Use bt_dev_err/warn/dbg helpers insted of BT_ERR/WARN/DBG
b) Used static functions where
Hi Amitkumar,
Quick review inline.
On 03/03/2016 12:56, Amitkumar Karwar wrote:
From: Ganapathi Bhat
This patch implement firmware download feature for
Marvell Bluetooth devices. If firmware is already
downloaded, it will skip downloading.
Signed-off-by: Ganapathi Bhat
Signed-off-by: Amitku
0x0e) plen 4
Unknown (0x3f|0x005d) ncmd 1
00
Then, if we read the same register with opcode_read 0xfc5e:
< HCI Command (0x3f|0x005e) plen 6 [hci0]
04 8c 00 00 02 04
> HCI Event (0x0e) plen 12 [hci0]
Unknown (0x3f|0x005e) ncmd 1
00 04 8c 00 00 2a 00 00 00
Signed-of
Send a HCI command and wait for command complete event.
This function serializes the requests by grabbing the req_lock.
Signed-off-by: Loic Poulain
---
v1: v2: no patch 1/2
v3: Add hci_cmd_sync function, used by regmap-ibt
include/net/bluetooth/hci_core.h | 3 +++
net/bluetooth/hci_core.c
0x0e) plen 4
Unknown (0x3f|0x005d) ncmd 1
00
Then, if we read the same register with opcode_read 0xfc5e:
< HCI Command (0x3f|0x005e) plen 6 [hci0]
04 8c 00 00 02 04
> HCI Event (0x0e) plen 12 [hci0]
Unknown (0x3f|0x005e) ncmd 1
00 04 8c 00 00 2a 00 00 00
Signed-of
REG ADDR MD SZ
__ __ ___ ___
< 0E 0c 01 59 fc 00 04 8c 00 00 22 11 00 32
CC EVT HDR ST REG ADDR DATA
Signed-off-by: Loic Poulain
---
drivers/base/regmap/Kconfig | 6 +-
drivers/base/regmap/Makefile | 1 +
drivers/base/regmap/
In certain suspend modes on certain boards the 8250 UART may lose
state when the device goes to suspend. If we're using
no_console_suspend this can cause lots of problems during resume.
Let's cache the basic UART config registers at suspend time and if we
notice that the UART loses state (by loo
Direct irq en bit should be cleared for pads using io mode.
If not, the io based irq will never be detected.
However, this bit can sometimes be misconfigured (BIOS issue).
Force clearing of this bit in io mode and trigger a WARN.
Signed-off-by: Loic Poulain
---
v2: Apply over
Yes I'm going to do a v3.
Regards,
Loic
On 23/09/2014 20:36, Westerberg, Mika wrote:
On Tue, Sep 23, 2014 at 05:44:43PM +0200, Linus Walleij wrote:
On Wed, Sep 17, 2014 at 3:47 PM, Loic Poulain wrote:
Direct Irq En bit can be initialized to a bad value.
This bit has to be cleared f
just keep this patch locally as a workaround and revert
it later once our BIOS fixed.
Regards,
Loic
On 18/09/2014 09:49, Mika Westerberg wrote:
On Wed, Sep 17, 2014 at 03:47:01PM +0200, Loic Poulain wrote:
Direct Irq En bit can be initialized to a bad value.
This bit has to be cleared for io a
Direct Irq En bit can be initialized to a bad value.
This bit has to be cleared for io access mode.
Signed-off-by: Loic Poulain
---
v2: Apply over ff998356b644ebe723127bd9eec6040b59a4a4f6 + add Warning
drivers/pinctrl/pinctrl-baytrail.c | 5 -
1 file changed, 4 insertions(+), 1 deletion
Do you think a WARN necessary before clearing the bit?
Regards,
Loic
On 17/09/2014 15:18, Mathias Nyman wrote:
On 09/17/2014 03:30 PM, Loic Poulain wrote:
Direct Irq En bit can be initialized to a bad value.
This bit has to be cleared for io access mode.
Signed-off-by: Loic Poulain
Direct Irq En bit can be initialized to a bad value.
This bit has to be cleared for io access mode.
Signed-off-by: Loic Poulain
---
drivers/pinctrl/pinctrl-baytrail.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-baytrail.c
b/drivers/pinctrl
94 matches
Mail list logo
