Typo: compation --> compaction
Signed-off-by: Liu Xiang
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index 7da25b87f..c25665802 100644
--- a/drivers/vir
Since pages have been deflated to a local list,
there is no race between fill and leak.
Signed-off-by: Liu Xiang
---
drivers/virtio/virtio_balloon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/virtio/virtio_balloon.c b/drivers/virtio/virtio_balloon.c
index
Russell King - ARM Linux admin 于2021年3月25日周四 下午6:06写道:
>
> On Thu, Mar 25, 2021 at 05:50:49PM +0800, Liu Xiang wrote:
> > When CONFIG_HARDEN_BRANCH_PREDICTOR is selected and user aborts occur,
> > there is a warning:
> >
> > BUG: using smp_processor_id() in preempti
01012a8>] (do_DataAbort) from [<8010b03c>] (__dabt_usr+0x3c/0x40)
Exception stack(0xb21d1fb0 to 0xb21d1ff8)
1fa0: fff4 0054 fff4
1fc0: 7ed81cc8 7ed81ca0 0007a440 00000000
1fe0: 7ed81ca0 0001
Now there is no check with the return value of virtio_gpu_alloc_cmd_resp().
If it fails, the following operation will cause a fault.
Signed-off-by: Liu Xiang
---
drivers/gpu/drm/virtio/virtgpu_vq.c | 89 +
1 file changed, 89 insertions(+)
diff --git a/drivers/gpu
> On Thu, Jan 21, 2021 at 5:40 PM Maxime Ripard wrote:
> On Tue, Jan 19, 2021 at 02:29:08PM +0800, Liu Xiang wrote:
> > When CONFIG_REGULATOR is not set, sunxi_pmx_request() always return
> > success. Even a group of pins call sunxi_pmx_request(), the refcount
> > is only
--
> On Thu, Jan 21, 2021 at 5:40 PM Maxime Ripard wrote:
> On Tue, Jan 19, 2021 at 02:29:08PM +0800, Liu Xiang wrote:
> > When CONFIG_REGULATOR is not set, sunxi_pmx_request() always return
> > success. Even a
> Hi,
> On Tue, Jan 19, 2021 at 02:29:08PM +0800, Liu Xiang wrote:
> When CONFIG_REGULATOR is not set, sunxi_pmx_request() always return
> success. Even a group of pins call sunxi_pmx_request(), the refcount
> is only 1. This can cause a use-after-free warning in sunxi_pmx_free().
in its own
complete workqueue and the preemptoff problem could be avoided.
Signed-off-by: Liu Xiang
---
drivers/mmc/core/block.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c
index 42e27a298..c27239a89 100644
--- a/driver
On Wed, Jan 20, 2021 at 10:15:22AM +0800, Liu Xiang wrote:
> The commit "40d09b53bfc557af7481b9d80f060a7ac9c7d314" has solved the
> irqsoff problem by completing the request in softirq. But it may cause
> the system to suffer bad preemptoff time.
> Introduce the RE
ted in the blk_complete workqueue.
It can be used for requests that want to cut down both irqsoff and
preemptoff time.
Signed-off-by: Liu Xiang
---
block/blk-mq.c| 46 +++
include/linux/blk_types.h | 4
include/linux/blkdev.h| 5 +
3 fil
-off-by: Liu Xiang
---
drivers/pinctrl/sunxi/pinctrl-sunxi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
index dc8d39ae0..d1a8974eb 100644
--- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
+++ b
: Liu Xiang
Signed-off-by: Pan Jiagen
---
Changes in v2:
as suggested by Mike, apply the same fix to the related local
variables in gather_surplus_pages().
---
---
mm/hugetlb.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index 37f15c3
Thanks for your advice. I will send a v2 patch.
--
发件人:Mike Kravetz
发送时间:2020年11月19日(星期四) 02:44
收件人:liu xiang ; linux-mm
抄 送:akpm ; linux-kernel
; liuxiang_1999 ; pan
jiagen
主 题:Re: [PATCH] mm: hugetlb: fix type of delta
On 64-bit machine, delta variable in hugetlb_acct_memory() may be larger
than 0x, but gather_surplus_pages() can only use the low 32-bit
value now.
Reported-by: Ma Chenggong
Signed-off-by: Liu Xiang
Signed-off-by: Pan Jiagen
---
mm/hugetlb.c | 2 +-
1 file changed, 1 insertion(+), 1
The '|' operation of status in linflex_rxint is unnecessary,
so it can be removed.
Signed-off-by: Liu Xiang
---
drivers/tty/serial/fsl_linflexuart.c | 19 +--
1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/drivers/tty/serial/fsl_linflexuart.c
b/d
When enable clk_ref failed, clk_ptp should be disabled rather than
clk_ref itself.
Signed-off-by: Liu Xiang
---
drivers/net/ethernet/freescale/fec_main.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c
b/drivers/net/ethernet
Because nr_pages is unsigned long, it can not be negative.
Signed-off-by: Liu Xiang
---
mm/gup.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/mm/gup.c b/mm/gup.c
index 8f236a3..0236954 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -735,10 +735,10 @@ static int
gfpflags_allow_blocking() does not care about __GFP_HIGHMEM,
so highmem_mask can be removed.
Signed-off-by: Liu Xiang
---
mm/vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/vmalloc.c b/mm/vmalloc.c
index 7ba11e1..143c636 100644
--- a/mm/vmalloc.c
+++ b/mm
IS25LP256 gets BFPT_DWORD1_ADDRESS_BYTES_3_ONLY from BFPT table for
address width. But in actual fact the flash can support 4-byte address.
Use a post bfpt fixup hook to overwrite the address width advertised by
the BFPT.
Suggested-by: Tudor Ambarus
Signed-off-by: Liu Xiang
---
Changes in v4
Hi, ta
Thanks for your advice! I will send the update patch in soon.
At 2019-06-22 19:49:25, tudor.amba...@microchip.com wrote:
>Hi, Liu,
>
>On 03/31/2019 10:42 AM, Liu Xiang wrote:
>
>> Some is25lp256 get BFPT_DWORD1_ADDRESS_BYTES_3_ONLY from BFPT table for
>> addr
Because get_block() might set the buffer mapped, fully_mapped reset
should be done according to the result of buffer_mapped(bh)
which check the buffer mapped attribute again after get_block().
Signed-off-by: Liu Xiang
---
Changes in v2:
change comment
fs/buffer.c | 2 +-
1 file changed, 1
rrent page. So prefetchw() should be called while the page pointer
has just been updated.
Signed-off-by: Liu Xiang
---
Changes in v2:
remove prefetchw() when pages is NULL and change comment
fs/ext4/readpage.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/ext4/readpa
Now frozen slab can only be on the per cpu partial list.
Signed-off-by: Liu Xiang
---
mm/slub.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index dc6..9e2f220 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -58,10 +58,11 @@
* D. page
Hi, Vignesh
At 2019-03-19 13:22:15, "Vignesh Raghavendra" wrote:
>Hi,
>
>On 13/03/19 7:15 PM, Liu Xiang wrote:
>> In some is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
>> is 0xfff920e5. So the DWORD1[18:17] Address Bytes bits are 0b00,
>&
Hi, Vignesh
Thanks for your suggestion. I will send a new patch.
At 2019-03-19 13:22:15, "Vignesh Raghavendra" wrote:
>Hi,
>
>On 13/03/19 7:15 PM, Liu Xiang wrote:
>> In some is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
>> is 0xfff920e5. So
hen nor->addr_width does not match
the device size in spi_nor_parse_bfpt(). Then it can go back to
use spi_nor_ids[] for setting the right addr_width.
Suggested-by: Boris Brezillon
Signed-off-by: Liu Xiang
---
drivers/mtd/spi-nor/spi-nor.c | 8
1 file changed, 8 insertions(+)
diff -
the spi_nor_ids[] is right, it can work well.
I will send a v2 patch.
At 2018-11-16 21:24:10, "Liu Xiang" wrote:
>
>Hi Tudor, Boris, Cyrille,
>There is no JEDEC BFPT tables in the datasheet.
>In my test platform, I sent RDSFDP command to the flash and got the
>parameters
Hi, Marc
Thanks for your reply!
At 2019-03-11 23:55:11, "Marc Zyngier" wrote:
>On 11/03/2019 14:52, Liu Xiang wrote:
>> For secondary GICs, the start irq number should skip over SGIs
>> and PPIs. Its value should be 32. So we should pass hwirq_base to
>>
For secondary GICs, the start irq number should skip over SGIs
and PPIs. Its value should be 32. So we should pass hwirq_base to
irq_alloc_descs() rather than a constant number 16.
Signed-off-by: Liu Xiang
---
drivers/irqchip/irq-gic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
When pages is not NULL, prefetchw(&page->flags) always works on
the last consumed page. This might do little improvment for handling
current page. It is better to do prefetchw while the page pointer
has just been updated.
Signed-off-by: Liu Xiang
---
fs/ext4/readpage.c | 7 +--
Fix a typo in ext2_get_blocks comment.
Signed-off-by: Liu Xiang
---
fs/ext2/inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext2/inode.c b/fs/ext2/inode.c
index e4bb938..11da3fb 100644
--- a/fs/ext2/inode.c
+++ b/fs/ext2/inode.c
@@ -717,7 +717,7 @@ static int
Because get_block() might set the buffer mapped, reset fully_mapped
after it is more accurately.
Signed-off-by: Liu Xiang
---
fs/buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/buffer.c b/fs/buffer.c
index 52d024b..b2e9167 100644
--- a/fs/buffer.c
+++ b/fs
When best_desc keeps NULL, best_group keeps -1, too. So we can
return best_group directly.
Signed-off-by: Liu Xiang
---
fs/ext2/ialloc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index 5c3d7b7..a0c5ea9 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2
If ((char *)de == dir_end) is true, the name_len will not be used
in the subsequent routine. So the reset code can be removed.
Signed-off-by: Liu Xiang
---
fs/ext2/dir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/ext2/dir.c b/fs/ext2/dir.c
index 3b8114d..5ec497f 100644
--- a/fs/ext2
The calculation of ra->prev_pos can be simplified.
Signed-off-by: Liu Xiang
---
mm/filemap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/filemap.c b/mm/filemap.c
index 9f5e323..7f30844 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -2279,9 +2279,7 @@ sta
The case of (EXT2_INODE_SIZE(sb) == 0) is included in
(sbi->s_inode_size < EXT2_GOOD_OLD_INODE_SIZE).
So there is no need to check again.
Signed-off-by: Liu Xiang
---
fs/ext2/super.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index 73b2d52..c
Add spaces around '&' to follow kernel coding style.
Signed-off-by: Liu Xiang
---
arch/openrisc/include/asm/fixmap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/openrisc/include/asm/fixmap.h
b/arch/openrisc/include/asm/fixmap.h
index 5a01595..75c7a7
Add spaces around '&' to follow kernel coding style.
Signed-off-by: Liu Xiang
---
include/asm-generic/fixmap.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/fixmap.h b/include/asm-generic/fixmap.h
index 827e4d3..d6e8da3 100644
--- a/inclu
Add spaces around '+' to follow kernel coding style.
Signed-off-by: Liu Xiang
---
arch/arm64/mm/mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c
index d1d6601..1dbd7be 100644
--- a/arch/arm64/mm/mmu.c
+++ b/arch/arm6
te:
>
>> Hi, Liu, Boris, Cyrille,
>>
>> On 11/14/2018 03:51 PM, Boris Brezillon wrote:
>> > On Wed, 14 Nov 2018 20:56:05 +0800
>> > Liu Xiang wrote:
>> >
>> >> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
>> >>
r to add this check until I get the right answer from
ISSI?
At 2018-11-14 21:51:29, "Boris Brezillon" wrote:
>On Wed, 14 Nov 2018 20:56:05 +0800
>Liu Xiang wrote:
>
>> In is25lp256, the DWORD1 of JEDEC Basic Flash Parameter Header
>> is 0xfff920e5. So the DW
The is25lp256 supports 4-byte opcodes and quad output.
Suggested-by: Boris Brezillon
Signed-off-by: Liu Xiang
---
drivers/mtd/spi-nor/spi-nor.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 3e54e31
nor->addr_width not match
the device size in spi_nor_parse_sfdp().
Suggested-by: Boris Brezillon
Signed-off-by: Liu Xiang
---
drivers/mtd/spi-nor/spi-nor.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
index 3eba13a..7
c:
Signed-off-by: Liu Xiang
---
Changes in v3:
move changelog position.
drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c
b/drivers/mtd/spi-nor/fsl-quadspi.c
index 7d9620c..64304a3 100644
--- a/drivers/mtd/spi-nor/fsl-quads
Thanks for your suggestion. Should I send another patch?
At 2018-08-28 21:23:05, "Boris Brezillon" wrote:
>On Tue, 28 Aug 2018 21:21:16 +0800
>Liu Xiang wrote:
>
>> If the size of spi-nor flash is larger than 16MB, the read_opcode
>> is set
: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc:
Signed-off-by: Liu Xiang
---
drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c
b/drivers/mtd/spi-nor/fsl-quadspi.c
index 7d9620c..64304a3 100644
--- a/drivers/m
the address above 16MB.
I think the size of flash is the most important judgement for
nor->addr_width. Once the size is larger than 16MB, nor->addr_width
must be 4. This can avoid the bad situation that manufacturer sets
incorrect value of register.
Signed-off-by: Liu Xiang
---
drivers/mtd/sp
the address above 16MB.
I think the size of flash is the most important judgement for
nor->addr_width. Once the size is larger than 16MB, nor->addr_width
must be 4. This can avoid the bad situation that manufacturer sets
incorrect value of register.
Signed-off-by: Liu Xiang
---
drivers/mtd/sp
If the size of spi-nor flash is larger than 16MB, the read_opcode
is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
cause read operation fail.
Signed-off-by: Liu Xiang
---
drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file
According to the datasheet, bq27411 is similar to bq27421.
Signed-off-by: Liu Xiang
---
Documentation/devicetree/bindings/power/supply/bq27xxx.txt | 1 +
drivers/power/supply/bq27xxx_battery.c | 9 +
drivers/power/supply/bq27xxx_battery_i2c.c | 2
The URL of bq27441-g1 and bq27426 are missing and bq27520-g4 is duplicated.
Signed-off-by: Liu Xiang
---
drivers/power/supply/bq27xxx_battery.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c
b/drivers/power/supply/bq27xxx_battery.c
Implement a resource managed irq_of_parse_and_map function.
Signed-off-by: Liu Xiang
---
drivers/of/irq.c | 38 ++
include/linux/of_irq.h | 7 +++
2 files changed, 45 insertions(+)
diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 02ad93a
completed.
---
Signed-off-by: Liu Xiang
---
drivers/net/ethernet/davicom/dm9000.c | 39 +--
1 file changed, 28 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/davicom/dm9000.c
b/drivers/net/ethernet/davicom/dm9000.c
index 50222b7..56df77d 100644
--- a
The URL of bq27441-g1 is missing and bq27520-g4 is duplicated.
Signed-off-by: Liu Xiang
---
drivers/power/supply/bq27xxx_battery.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c
b/drivers/power/supply/bq27xxx_battery.c
index
According to the datasheet, bq27411 is similar to bq27421.
Signed-off-by: Liu Xiang
---
drivers/power/supply/bq27xxx_battery.c | 14 ++
include/linux/power/bq27xxx_battery.h | 3 ++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/power/supply
.
---
v2:
dm9000_phy_write_reg is extracted from dm9000_phy_write, with no lock,
do the real phy operation.
---
Signed-off-by: Liu Xiang
---
drivers/net/ethernet/davicom/dm9000.c | 37 +--
1 file changed, 22 insertions(+), 15 deletions(-)
diff --git a/drivers/net
.
Signed-off-by: Liu Xiang
---
drivers/net/ethernet/davicom/dm9000.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/drivers/net/ethernet/davicom/dm9000.c
b/drivers/net/ethernet/davicom/dm9000.c
index 008dc81..afe33de 100644
--- a/drivers/net/ethernet
According to the datasheet, MAX17040 has six 16-bit registers.
Register reads and writes are only valid if all 16 bits are transferred.
Any write command that is terminated early is ignored.
So it's better to change register transacton length from 8 bits to 16 bits.
Signed-off-by: Liu
When dev.of_node is not NULL, we also need to set IRQF_TRIGGER_FALLING
flag, otherwise it may cause uncertain interrupts.
Signed-off-by: Liu Xiang
---
drivers/tty/serial/max310x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/max310x.c b/drivers/tty
h in musb_h_disable should be checked.If the qh is emtpy,
then recycle it and go to exit directly.
---
v2:
- Modify the urb empty condition
---
Signed-off-by: Liu Xiang
---
drivers/usb/musb/musb_host.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/mu
o the qh in musb_h_disable should be checked.If the qh is emtpy,
then recycle it and go to exit directly.
Signed-off-by: Liu Xiang
---
drivers/usb/musb/musb_host.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb
62 matches
Mail list logo