Re: [PATCH] virt: acrn: Fix document of acrn_msi_inject()

2021-03-10 Thread Liu, Shuo A
On 3/10/2021 23:50, Greg Kroah-Hartman wrote: > On Wed, Mar 10, 2021 at 11:37:51PM +0800, shuo.a@intel.com wrote: >> From: Shuo Liu >> >> This fixes below sparse warning. >> >> ../drivers/virt/acrn/vm.c:105: warning: expecting prototype for >> acrn_inject_msi(). Prototype was for acrn_msi_i

Re: [PATCH] virt: acrn: Use vfs_poll() instead of f_op->poll()

2021-02-20 Thread Liu, Shuo A
On 2/20/2021 22:53, Yejune Deng wrote: > Use vfs_poll() is a more advanced function in acrn_irqfd_assign(). > as the same time, modify the definition of events. > > Signed-off-by: Yejune Deng Thanks for the update. Reviewed-by: Shuo Liu Hi Greg, Need i do more work on this patch? Or you wil

Re: linux-next: Tree for Feb 10 (acrn)

2021-02-10 Thread Liu, Shuo A
On 2/11/2021 01:52, Randy Dunlap wrote: > On 2/10/21 3:42 AM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20210209: >> > > ../drivers/virt/acrn/hsm.c: In function ‘remove_cpu_store’: > ../drivers/virt/acrn/hsm.c:389:3: error: implicit declaration of function > ‘remove_cpu’; did you

Re: [PATCH v4 00/17] HSM driver for ACRN hypervisor

2020-09-26 Thread Liu, Shuo A
Ping... On 9/22/2020 19:42, shuo.a@intel.com wrote: > From: Shuo Liu > > ACRN is a Type 1 reference hypervisor stack, running directly on the > bare-metal > hardware, and is suitable for a variety of IoT and embedded device solutions. > > ACRN implements a hybrid VMM architecture, using a

Re: [PATCH v3 06/17] virt: acrn: Introduce VM management interfaces

2020-09-10 Thread Liu, Shuo A
Hi Greg, On 9/11/2020 00:28, Greg Kroah-Hartman wrote: > On Thu, Sep 10, 2020 at 02:19:00PM +0800, Shuo A Liu wrote: >> On Wed 9.Sep'20 at 11:45:16 +0200, Greg Kroah-Hartman wrote: >>> On Wed, Sep 09, 2020 at 05:08:25PM +0800, shuo.a@intel.com wrote: From: Shuo Liu The VM mana

Re: [PATCH v2 07/17] virt: acrn: Introduce an ioctl to set vCPU registers state

2020-09-03 Thread Liu, Shuo A
Hi Greg, On 9/3/2020 21:03, Greg Kroah-Hartman wrote: > On Thu, Sep 03, 2020 at 08:41:51PM +0800, shuo.a@intel.com wrote: >> From: Shuo Liu >> >> A virtual CPU of User VM has different context due to the different >> registers state. ACRN userspace needs to set the virtual CPU >> registers st

Re: [PATCH v2 06/17] virt: acrn: Introduce VM management interfaces

2020-09-03 Thread Liu, Shuo A
Hi Greg, On 9/3/2020 21:02, Greg Kroah-Hartman wrote: > On Thu, Sep 03, 2020 at 08:41:50PM +0800, shuo.a@intel.com wrote: >> From: Shuo Liu >> >> The VM management interfaces expose several VM operations to ACRN >> userspace via ioctls. For example, creating VM, starting VM, destroying >> VM

Re: [PATCH v2 05/17] virt: acrn: Introduce ACRN HSM basic driver

2020-09-03 Thread Liu, Shuo A
On 9/3/2020 20:53, Greg Kroah-Hartman wrote: > On Thu, Sep 03, 2020 at 08:41:49PM +0800, shuo.a@intel.com wrote: >> From: Shuo Liu >> >> ACRN Hypervisor Service Module (HSM) is a kernel module in Service VM >> which communicates with ACRN userspace through ioctls and talks to ACRN >> Hyperv

[PATCH] xen/events: Fix interrupt lost during irq_disable and irq_enable

2017-07-29 Thread Liu Shuo
move eoi_pirq when irq_enable. Signed-off-by: Liu Shuo --- drivers/xen/events/events_base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/xen/events/events_base.c b/drivers/xen/events/events_base.c index bae1f5d3..2d43118 100644 --- a/drivers/xen/events/events_base.c +++ b/

Re: [PATCH] can: Fix kernel panic at security_sock_rcv_skb

2017-01-13 Thread Liu Shuo
On Thu 12.Jan'17 at 17:33:38 +0100, Oliver Hartkopp wrote: On 01/12/2017 02:01 PM, Eric Dumazet wrote: On Thu, 2017-01-12 at 09:22 +0100, Oliver Hartkopp wrote: But my main concern is: The reason why can_rx_delete_receiver() was introduced was the need to remove a huge number of receivers wi

Re: [PATCH] KVM: release anon file in failure path of vm creation

2016-07-15 Thread Liu Shuo
On Fri 15.Jul'16 at 6:09:59 +0100, Al Viro wrote: On Fri, Jul 15, 2016 at 11:18:41AM +0800, Liu Shuo wrote: If there is no such thread (who operates the descriptor based on guessing), i can think the changing is safe at the point. As the fd has not been delivered to userspace. Am i

Re: [PATCH] KVM: release anon file in failure path of vm creation

2016-07-14 Thread Liu Shuo
On Fri 15.Jul'16 at 3:26:03 +0100, Al Viro wrote: On Fri, Jul 15, 2016 at 10:22:04AM +0800, Liu Shuo wrote: > You have no warranty whatsoever that descriptor table has not been changed > by that point. You should *NEVER* use sys_close() on failure exit paths Could you please el

Re: [PATCH] KVM: release anon file in failure path of vm creation

2016-07-14 Thread Liu Shuo
On Thu 14.Jul'16 at 17:46:47 +0100, Al Viro wrote: On Tue, Jul 12, 2016 at 12:24:39PM +0200, Paolo Bonzini wrote: On 12/07/2016 11:38, Liu Shuo wrote: > The failure of create debugfs of VM will return directly without release > the anon file. It will leak memory and file descri

[PATCH] KVM: release anon file in failure path of vm creation

2016-07-12 Thread Liu Shuo
The failure of create debugfs of VM will return directly without release the anon file. It will leak memory and file descriptors, even through be not serious. Signed-off-by: Liu Shuo --- virt/kvm/kvm_main.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/virt/kvm/kvm_main.c b/virt/kvm

[PATCH 2/2] pstore: fix memory leak when decompress using big_oops_buf

2014-03-12 Thread Liu Shuo
From: Liu ShuoX After sucessful decompressing, the buffer which pointed by 'buf' will be lost as 'buf' is overwrite by 'big_oops_buf' and will never be freed. Signed-off-by: Liu ShuoX --- fs/pstore/platform.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/pstore/platform.c b/fs/pstore

[PATCH 1/2] pstore: fix buffer overflow while write offset equal to buffer size

2014-03-12 Thread Liu Shuo
From: Liu ShuoX In case new offset is equal to prz->buffer_size, it won't wrap at this time and will return old(overflow) value next time. Signed-off-by: Liu ShuoX --- fs/pstore/ram_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/pstore/ram_core.c b/fs/pstore/r

[PATCH] pstore: clarify clearing of _read_cnt in ramoops_context

2014-03-07 Thread Liu Shuo
On Fri 7.Mar'14 at 16:23:29 -0800, Kees Cook wrote: On Fri, Mar 7, 2014 at 1:25 PM, Andrew Morton wrote: On Fri, 7 Mar 2014 10:58:43 +0800 Liu ShuoX wrote: ftrace_read_cnt need to be reset in open to support mutli times getting the records. Signed-off-by: Liu ShuoX --- fs/pstore/ram.c