Re: [PATCH v1 1/2] pinctrl: mediatek: support access registers without race-condition

2020-08-21 Thread Light Hsieh
On Fri, 2020-08-21 at 02:59 -0700, Sean Wang wrote: > Hi Light, > > On Thu, Aug 20, 2020 at 9:47 PM Light Hsieh wrote: > > > > On Wed, 2020-08-19 at 16:11 -0700, Sean Wang wrote: > > > Hi Light, > > > > > > On Tue, Aug 18, 2020 at 1

Re: [PATCH v1 1/2] pinctrl: mediatek: support access registers without race-condition

2020-08-20 Thread Light Hsieh
On Wed, 2020-08-19 at 16:11 -0700, Sean Wang wrote: > Hi Light, > > On Tue, Aug 18, 2020 at 1:36 AM wrote: > > > > From: Light Hsieh > > > > Some MediaTek SOC provide more control registers other than value register. > > s/MT6765/Some MediaTek SoC/ >

Re: [PATCH] pinctrl: mediatek: fix mtk_eint link error

2020-04-29 Thread Light Hsieh
On Wed, 2020-04-29 at 15:24 +0200, Arnd Bergmann wrote: > In a configuration with CONFIG_PINCTRL_MTK_MOORE=y and > CONFIG_PINCTRL_MTK_PARIS=m, > we end up with the mtk_eint driver as a loadable module that cannot be > linked from built-in code: How did you set all MTK-related PINCTRL configs? and

Re: [PATCH v6 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-26 Thread Light Hsieh
nteger instead of unsigned integer. Otherwise, kernel fault will occur when s_pin field of first entry of a mtk_pin_field_calc[] array is not 0. On Fri, 2019-09-27 at 13:02 +0800, Light Hsieh wrote: > 1. Check if gpio pin number is in valid range to prevent from get invalid >pointer &

[PATCH v6 3/5] pinctrl: mediatek: Refine mtk_pinconf_get() and mtk_pinconf_set()

2019-09-26 Thread Light Hsieh
1.Refine mtk_pinconf_get(): 1.1 Use only one occurrence of return at end of this function. 1.2 Correct cases for PIN_CONFIG_SLEW_RATE, PIN_CONFIG_INPUT_SCHMITT_ENABLE, and PIN_CONFIG_OUTPUT_ENABLE - Use variable ret to receive value in mtk_hw_get_value() (instead of variable val) since

[PATCH v6 5/5] pinctrl: mediatek: Add support for pin configuration dump via debugfs.

2019-09-26 Thread Light Hsieh
Add support for pin configuration dump via catting /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins. pinctrl framework had already support such dump. This patch implement the operation function pointer to fullfill this dump. --- drivers/pinctrl/mediatek/pinctrl-paris.c | 88 +++

[PATCH v6 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage

2019-09-26 Thread Light Hsieh
Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to previous Mediatek's bias-pull usage. In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins with 2 pull resistors can be specified as value for bias-pull-up and bias-pull-down. For example: bias-pull-up =

[PATCH v6 2/5] pinctrl: mediatek: Supporting driving setting without mapping current to register value

2019-09-26 Thread Light Hsieh
Mediatek's smarphone project actual usage does need to know current value (in mA) in procedure of finding the best driving setting. The steps in the procedure is like as follow: 1. set driving setting field in setting register as 0, measure waveform, perform test, and etc. 2. set driving settin

[PATCH v6 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-26 Thread Light Hsieh
1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_field_lookup() to use binary search for accele

Re: [PATCH v5 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-17 Thread Light Hsieh
Dear reviewer, Due to my operation error, one file (pinctrl-paris.h) is missed in patch seriers 5/5 of v4. v5 is sent to correct this error. On Wed, 2019-09-18 at 10:39 +0800, Light Hsieh wrote: > 1. Check if gpio pin number is in valid range to prevent from get invalid >pointer &#x

[PATCH v5 5/5] pinctrl: mediatek: Add support for pin configuration dump via debugfs.

2019-09-17 Thread Light Hsieh
Add support for pin configuration dump via catting /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins. pinctrl framework had already support such dump. This patch implement the operation function pointer to fullfill this dump. --- drivers/pinctrl/mediatek/pinctrl-paris.c | 88 +++

[PATCH v5 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-17 Thread Light Hsieh
1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_field_lookup() to use binary search for accele

[PATCH v5 3/5] pinctrl: mediatek: Refine mtk_pinconf_get() and mtk_pinconf_set()

2019-09-17 Thread Light Hsieh
1.Refine mtk_pinconf_get(): 1.1 Use only one occurrence of return at end of this function. 1.2 Correct cases for PIN_CONFIG_SLEW_RATE, PIN_CONFIG_INPUT_SCHMITT_ENABLE, and PIN_CONFIG_OUTPUT_ENABLE - Use variable ret to receive value in mtk_hw_get_value() (instead of variable val) since

[PATCH v5 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage

2019-09-17 Thread Light Hsieh
Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to previous Mediatek's bias-pull usage. In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins with 2 pull resistors can be specified as value for bias-pull-up and bias-pull-down. For example: bias-pull-up =

[PATCH v5 2/5] pinctrl: mediatek: Supporting driving setting without mapping current to register value

2019-09-17 Thread Light Hsieh
Mediatek's smarphone project actual usage does need to know current value (in mA) in procedure of finding the best driving setting. The steps in the procedure is like as follow: 1. set driving setting field in setting register as 0, measure waveform, perform test, and etc. 2. set driving settin

[PATCH v4 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage

2019-09-17 Thread Light Hsieh
Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to previous Mediatek's bias-pull usage. In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins with 2 pull resistors can be specified as value for bias-pull-up and bias-pull-down. For example: bias-pull-up =

[PATCH v4 2/5] pinctrl: mediatek: Supporting driving setting without mapping current to register value

2019-09-17 Thread Light Hsieh
Mediatek's smarphone project actual usage does need to know current value (in mA) in procedure of finding the best driving setting. The steps in the procedure is like as follow: 1. set driving setting field in setting register as 0, measure waveform, perform test, and etc. 2. set driving settin

[PATCH v4 3/5] pinctrl: mediatek: Refine mtk_pinconf_get() and mtk_pinconf_set()

2019-09-17 Thread Light Hsieh
1.Refine mtk_pinconf_get(): 1.1 Use only one occurrence of return at end of this function. 1.2 Correct cases for PIN_CONFIG_SLEW_RATE, PIN_CONFIG_INPUT_SCHMITT_ENABLE, and PIN_CONFIG_OUTPUT_ENABLE - Use variable ret to receive value in mtk_hw_get_value() (instead of variable val) since

[PATCH v4 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-17 Thread Light Hsieh
1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_field_lookup() to use binary search for accele

[PATCH v4 5/5] pinctrl: mediatek: Add support for pin configuration dump via debugfs.

2019-09-17 Thread Light Hsieh
Add support for pin configuration dump via catting /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins. pinctrl framework had already support such dump. This patch implement the operation function pointer to fullfill this dump. --- drivers/pinctrl/mediatek/pinctrl-paris.c | 88 +++

Re: [PATCH v3 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-17 Thread Light Hsieh
bias_set, - .bias_get = mtk_pinconf_bias_get, + .bias_set_combo = mtk_pinconf_bias_set_combo, + .bias_get_combo = mtk_pinconf_bias_get_combo, On Tue, 2019-09-17 at 16:26 +0800, Light Hsieh wrote: > 1. Check if gpio pin number is in valid range to prevent from get invalid >poi

[PATCH v3 2/5] pinctrl: mediatek: Supporting driving setting without mapping current to register value

2019-09-17 Thread Light Hsieh
Mediatek's smarphone project actual usage does need to know current value (in mA) in procedure of finding the best driving setting. The steps in the procedure is like as follow: 1. set driving setting field in setting register as 0, measure waveform, perform test, and etc. 2. set driving settin

[PATCH v3 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage

2019-09-17 Thread Light Hsieh
Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to previous Mediatek's bias-pull usage. In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins with 2 pull resistors can be specified as value for bias-pull-up and bias-pull-down. For example: bias-pull-up =

[PATCH v3 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-17 Thread Light Hsieh
1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_field_lookup() to use binary search for accele

[PATCH v3 3/5] pinctrl: mediatek: Refine mtk_pinconf_get() and mtk_pinconf_set()

2019-09-17 Thread Light Hsieh
1.Refine mtk_pinconf_get(): 1.1 Use only one occurrence of return at end of this function. 1.2 Correct cases for PIN_CONFIG_SLEW_RATE, PIN_CONFIG_INPUT_SCHMITT_ENABLE, and PIN_CONFIG_OUTPUT_ENABLE - Use variable ret to receive value in mtk_hw_get_value() (instead of variable val) since

[PATCH v3 5/5] pinctrl: mediatek: Add support for pin configuration dump via debugfs.

2019-09-17 Thread Light Hsieh
Add support for pin configuration dump via catting /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins. pinctrl framework had already support such dump. This patch implement the operation function pointer to fullfill this dump. --- drivers/pinctrl/mediatek/pinctrl-paris.c | 88 +++

Re: [PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-04 Thread Light Hsieh
Dear reviewers, v2 is the same as v1 except that commit message is corrected according to Linus' comment for v1: 1. remove Change-Id lines 2. correct sysfs as debugfs On Thu, 2019-09-05 at 13:53 +0800, Light Hsieh wrote: > From: Light Hsieh > > 1. Check if gpio pin number is

[PATCH v2 3/5] pinctrl: mediatek: Refine mtk_pinconf_get() and mtk_pinconf_set()

2019-09-04 Thread Light Hsieh
From: Light Hsieh 1.Refine mtk_pinconf_get(): 1.1 Use only one occurrence of return at end of this function. 1.2 Correct cases for PIN_CONFIG_SLEW_RATE, PIN_CONFIG_INPUT_SCHMITT_ENABLE, and PIN_CONFIG_OUTPUT_ENABLE - Use variable ret to receive value in mtk_hw_get_value() (instead of

[PATCH v2 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-09-04 Thread Light Hsieh
From: Light Hsieh 1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_f

[PATCH v2 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage

2019-09-04 Thread Light Hsieh
From: Light Hsieh Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to previous Mediatek's bias-pull usage. In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins with 2 pull resistors can be specified as value for bias-pull-up and bias-pull-down

[PATCH v2 2/5] pinctrl: mediatek: Supporting driving setting without mapping current to register value

2019-09-04 Thread Light Hsieh
From: Light Hsieh Mediatek's smarphone project actual usage does need to know current value (in mA) in procedure of finding the best driving setting. The steps in the procedure is like as follow: 1. set driving setting field in setting register as 0, measure waveform, perform test, an

[PATCH v2 5/5] pinctrl: mediatek: Add support for pin configuration dump via debugfs.

2019-09-04 Thread Light Hsieh
From: Light Hsieh Add support for pin configuration dump via catting /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins. pinctrl framework had already support such dump. This patch implement the operation function pointer to fullfill this dump. --- drivers/pinctrl/mediatek/pinctrl

[PATCH v1 5/5] pinctrl: mediatek: Add support for pin configuration dump via sysfs.

2019-08-13 Thread Light Hsieh
From: Light Hsieh Add support for pin configuration dump via catting /sys/kernel/debug/pinctrl/$platform_dependent_path/pinconf-pins. pinctrl framework had already support such dump. This patch implement the operation function pointer to fullfill this dump. Change-Id

[PATCH v1 2/5] pinctrl: mediatek: Supporting driving setting without mapping current to register value

2019-08-13 Thread Light Hsieh
From: Light Hsieh Mediatek's smarphone project actual usage does need to know current value (in mA) in procedure of finding the best driving setting. The steps in the procedure is like as follow: 1. set driving setting field in setting register as 0, measure waveform, perform test, an

[PATCH v1 0/5] Improve MediaTek pinctrl v2 and make backward compatible to smartphone mass production usage

2019-08-13 Thread Light Hsieh
This patch improves MediaTek pinctrl v2 and makes backward compatible to current smartphone mass production usage by: 1.Check gpio pin number and use binary search in control address lookup 2.Supporting driving setting without mapping current to register value 3.Correct usage of PIN_CONFIG get/set

[PATCH v1 4/5] pinctrl: mediatek: Backward compatible to previous Mediatek's bias-pull usage

2019-08-13 Thread Light Hsieh
From: Light Hsieh Refine mtk_pinconf_set()/mtk_pinconf_get() for backward compatibility to previous Mediatek's bias-pull usage. In PINCTRL_MTK that use pinctrl-mtk-common.c, bias-pull setting for pins with 2 pull resistors can be specified as value for bias-pull-up and bias-pull-down

[PATCH v1 1/5] pinctrl: mediatek: Check gpio pin number and use binary search in mtk_hw_pin_field_lookup()

2019-08-13 Thread Light Hsieh
From: Light Hsieh 1. Check if gpio pin number is in valid range to prevent from get invalid pointer 'desc' in the following code: desc = (const struct mtk_pin_desc *)&hw->soc->pins[gpio]; 2. Use binary search in mtk_hw_pin_field_lookup() Modify mtk_hw_pin_f

[PATCH v1 3/5] pinctrl: mediatek: Refine mtk_pinconf_get() and mtk_pinconf_set()

2019-08-13 Thread Light Hsieh
From: Light Hsieh 1.Refine mtk_pinconf_get(): 1.1 Use only one occurrence of return at end of this function. 1.2 Correct cases for PIN_CONFIG_SLEW_RATE, PIN_CONFIG_INPUT_SCHMITT_ENABLE, and PIN_CONFIG_OUTPUT_ENABLE - Use variable ret to receive value in mtk_hw_get_value() (instead of

Re: [PATCH 1/1] pinctrl: Add alternative way for specifying register bases

2019-04-15 Thread Light Hsieh
Hi, Sean: On Sun, 2019-04-14 at 16:01 -0700, Sean Wang wrote: > Hi, Light > > On Thu, Apr 11, 2019 at 8:15 PM Light Hsieh wrote: > > > > The orginal PINCTRL_MTK_PARIS/PINCTRL_MTK_MOORE need more effort for > > specifying register bases when porting pl

[PATCH 1/1] pinctrl: Add alternative way for specifying register bases

2019-04-11 Thread Light Hsieh
The orginal PINCTRL_MTK_PARIS/PINCTRL_MTK_MOORE need more effort for specifying register bases when porting platform driver: 1. Write mt_pinctrl_register_base_name[] array in pinctrl-mt.c to specify names of register bases, for exmaple: static const char * const mt6765_pinctrl_r

Re: [PATCH] pinctrl: Add kernel config PINCTRL_MTK_V2

2019-04-11 Thread Light Hsieh
Dear reviewer, The points of Sean are right. Please forget this patch proposal. On Thu, 2019-04-11 at 15:04 -0700, Sean Wang wrote: > Hi, Light > > On Thu, Apr 11, 2019 at 2:32 AM Light Hsieh wrote: > > > > Since no single Mediatek chip use code for PIN

[PATCH] pinctrl: Add kernel config PINCTRL_MTK_V2

2019-04-11 Thread Light Hsieh
Since no single Mediatek chip use code for PINCTRL_MTK and code for PINCTRL_MTK_MOORE/PINCTRL_MTK_PARIS simultaneously, it is better to use different config to determine if related code will be built or not on building non-generic kernel. Add kernel config PINCTRL_MTK_V2 selected by either PINCTRL

What Has Kept You Waiting?

2017-12-03 Thread Mr Light Adam
treasury. Best regards, Mr Light Adam

high-power LED SPOT LIGHTS Milky white ceiling lamps

2014-10-30 Thread LED Light
Dear Mr/MS, Very glad to know you are looking for LED panel light and spot light in the market. We are one of the biggest suppliers of LED in China and southeast Asia. For more information, please visit our website: http://www.jrs-led.net Enclosed is price list and Free sample can be sent to you

Milky LED BULBS Ceramic ceiling lamps LED FLOOD LIGHTS

2014-10-29 Thread LED Light
have a nice day,friend. Glad to know you are interested in LED bean gall ligh and ceiling light. We do all sorts of LED light Wholesale in china. If you need,we will offer you every model with competitive price and high quality. For more information,Please kindly visit our websit: jrs-LED.net

high-power LED SPOT LIGHTS Milky white ceiling lamps

2014-10-29 Thread LED Light
Dear Mr/Ms We hear that you are in the market for LED lamps We are a professional manufacturer of LED lamps the favorable price and high quality are satisfy difference market need here we enclose our latest catalogue to introduce our products. in detail you may also visit our online company as

LED MINING LIGHTS GARDEN LIGHT CANDLE LIGHT

2014-10-29 Thread LED Light
Dear Sir, How are you? We are the professional China Supplier of LED products, LED LED spot lights, LED down lights, Par38, T-8... We are glad to know that you are in the market for LED products lights. There are some of this kind as attached for your reference. Are you interested in it? Or

LED MINING LIGHTS GARDEN LIGHT CANDLE LIGHT

2014-10-28 Thread LED Light
Dear Sir, How are you? We are the professional China Supplier of LED products, LED LED spot lights, LED down lights, Par38, T-8... We are glad to know that you are in the market for LED products lights. There are some of this kind as attached for your reference. Are you interested in it? Or

RGB LED TUBES LED GROW LIGHTS LED Street lights Underground Light

2014-10-28 Thread LED Light
Dear Mr/MS, Very glad to know you are looking for LED panel light and spot light in the market. We are one of the biggest suppliers of LED in China and southeast Asia. For more information, please visit our website: http://www.jrs-led.net Enclosed is price list and Free sample can be sent to you

LED LAMPS PARcans Street lights Underground Light

2014-10-28 Thread LED Light
Dear Mr/Ms We hear that you are in the market for LED lamps We are a professional manufacturer of LED lamps the favorable price and high quality are satisfy difference market need here we enclose our latest catalogue to introduce our products. in detail you may also visit our online company as

LED TUBES LED GROW LIGHTS LED Street lights Underground Light

2013-11-10 Thread LED FLASH LIGHT CAMCORDERS DIMMABLE LED BULBS
Thank you for your time. We sale LED lamps with Good quality and competitive price all over the world. To give you a general idea,Please visit our websit: jrs-LED.net Waitting for your reply. Best regards JRS Technology Co.,Ltd shadow Email: sha...@jrs-tech.net Skype: techjrsa MSN:techj...

LED MINING LIGHTS GARDEN LIGHT CANDLE LIGHT

2013-11-07 Thread LED FLASH LIGHT CAMCORDERS DIMMABLE LED BULBS
Dear Mr/Ms, From the internet we have konw that you are interested in our products We are a leading exporter of LED lamps for so many years .for details about our products welcome to browse our website www.JRS-LED.net we believe that flavorable price and high quality will help you to extend m

Re: Intel_pstate: One Core always 100% C0 state and never scale down

2013-07-04 Thread Light
On 07/04/2013 11:43 AM, Light wrote: I am using a laptop with Intel Ivy bridge core i7 3610QM. I updated my kernel to 3.10 and started to use intel_pstate as scaling driver: #cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver intel_pstate However I find that one of my four cores is always

Intel_pstate: One Core always 100% C0 state and never scale down

2013-07-03 Thread Light
I am using a laptop with Intel Ivy bridge core i7 3610QM. I updated my kernel to 3.10 and started to use intel_pstate as scaling driver: #cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_driver intel_pstate However I find that one of my four cores is always in C0 state even when there is no act