Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component

2019-01-14 Thread Liam Girdwood
On Sat, 2019-01-12 at 11:37 +0530, Rohit kumar wrote: > On 1/12/2019 3:19 AM, Pierre-Louis Bossart wrote: > > > Thanks for the overnight fix. This update fixes the issue on my > > > Skylake XPS13 test device (blind testing since I don't understand > > > what the code does). > > > > > > Tested-by

Re: [alsa-devel] [PATCH] ASoC: Intel: fix Kconfig dependencies

2017-11-02 Thread Liam Girdwood
On Thu, 2017-11-02 at 22:02 +0530, Vinod Koul wrote: > > > The BYT legacy drivers used DMAengine (dw) to load the firmware > and hence the > > > dependency. The Skylake and other drivers do not need that, so we > should > > > move this from toplevel to the BYT driver only. > > > > Ok, so Haswell a

Re: [RFC PATCH] ASoC: dpcm: Apply symmetry for DPCM

2015-12-11 Thread Liam Girdwood
). > > Signed-off-by: PC Liao > Signed-off-by: Koro Chen Acked-by: Liam Girdwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ASoC: dpcm: Make BE prepare possible in suspend state

2015-10-28 Thread Liam Girdwood
t;runtime is not cleared while this runtime is actually freed > by snd_pcm_detach_substream(). If another suspend comes, a NULL pointer > dereference will happen in snd_pcm_suspend() when accessing > BE substream's runtime. > > Signed-off-by: Koro Chen Acked-by: Liam Girdwood

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-08-27 Thread Liam Girdwood
On Thu, 2015-08-27 at 01:50 +, Lin, Mengdong wrote: > > -Original Message- > > From: Liam Girdwood [mailto:liam.r.girdw...@linux.intel.com] > > Sent: Wednesday, August 26, 2015 5:01 PM > > To: Jie, Yang > > Cc: Takashi Iwai; Dmitry Torokhov; Luis

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-08-26 Thread Liam Girdwood
On Wed, 2015-08-26 at 08:29 +, Jie, Yang wrote: > > -Original Message- > > From: Liam Girdwood [mailto:liam.r.girdw...@linux.intel.com] > > I think the options are to either :- > > > > 1) Don not support audio DSP drivers using topology data as built-in

Re: Problems loading firmware using built-in drivers with kernels that use initramfs.

2015-08-26 Thread Liam Girdwood
On Wed, 2015-08-26 at 07:17 +0100, Jie, Yang wrote: > > -Original Message- > > From: Takashi Iwai [mailto:ti...@suse.de] > > Sent: Wednesday, August 26, 2015 1:33 PM > > To: Jie, Yang > > Cc: Dmitry Torokhov; Luis R. Rodriguez; Girdwood, Liam R; > > joonas.lahti...@linux.intel.com; Tom Gund

Re: [alsa-devel] [PATCH v3] ASoC: Add support for NAU8825 codec to ASoC

2015-07-13 Thread Liam Girdwood
On Mon, 2015-07-13 at 15:33 +0800, Chih-Chiang Chang wrote: > +static void set_sys_clk(struct snd_soc_codec *codec, int sys_clk) > +{ > +struct nau8825_priv *nau8825 = snd_soc_codec_get_drvdata(codec); > + > +pr_debug("%s :: sys_clk=%x\n", __func__, sys_clk); > +switch (sys_clk) { > +

Re: Re: [PATCH] ACPI: Adjust the return value of _REV on x86

2015-03-24 Thread Liam Girdwood
On Tue, 2015-03-24 at 00:50 -0500, Mario Limonciello wrote: > I believe a majority of the kernel work is complete, but from some off > kernel mailing list discussions I understand that pulseaudio doesn't > understand the control interface that gets used for I2S for jack > detection. There is som

Re: [alsa-devel] [PATCH 1/2] ASoC: rt5677: Add ACPI device probing

2014-11-25 Thread Liam Girdwood
On Tue, 2014-11-25 at 08:01 -0800, Darren Hart wrote: > > On 11/25/14 06:28, Liam Girdwood wrote: > > On Tue, 2014-11-25 at 12:11 +, Grant Likely wrote: > >> On Sat, Nov 15, 2014 at 6:56 AM, Ben Zhang wrote: > >>> The rt5677 codec driver looks for ACPI dev

Re: [alsa-devel] [PATCH 1/2] ASoC: rt5677: Add ACPI device probing

2014-11-25 Thread Liam Girdwood
On Tue, 2014-11-25 at 12:11 +, Grant Likely wrote: > On Sat, Nov 15, 2014 at 6:56 AM, Ben Zhang wrote: > > The rt5677 codec driver looks for ACPI device ID "RT5677CE", > > which is specified in coreboot. This patch allows platform > > data to be obtained via ACPI > > > > Signed-off-by: Ben Zha

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-13 Thread Liam Girdwood
On Sat, 2014-01-11 at 10:35 +0100, Takashi Iwai wrote: > At Fri, 10 Jan 2014 18:43:09 +, > Liam Girdwood wrote: > > > > On Fri, 2014-01-10 at 14:46 +0100, Takashi Iwai wrote: > > > At Fri, 10 Jan 2014 12:29:08 +, > > > Liam Girdwood wrote: > > &

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Liam Girdwood
On Fri, 2014-01-10 at 14:46 +0100, Takashi Iwai wrote: > At Fri, 10 Jan 2014 12:29:08 +, > Liam Girdwood wrote: > > > > On Fri, 2014-01-10 at 13:01 +0100, Takashi Iwai wrote: > > > At Fri, 10 Jan 2014 19:59:42 +0800, > > > Nenghua Cao wrote: > >

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Liam Girdwood
On Fri, 2014-01-10 at 13:01 +0100, Takashi Iwai wrote: > At Fri, 10 Jan 2014 19:59:42 +0800, > Nenghua Cao wrote: > > > > On 01/10/2014 07:47 PM, Liam Girdwood wrote: > > > On Fri, 2014-01-10 at 19:21 +0800, Nenghua Cao wrote: > > >> On 01/10/2014 06:55 PM,

Re: [alsa-devel] [PATCH] ASoC: dpcm: don't do hw_param when BE has done hw_param

2014-01-10 Thread Liam Girdwood
On Fri, 2014-01-10 at 19:21 +0800, Nenghua Cao wrote: > On 01/10/2014 06:55 PM, Takashi Iwai wrote: > > [Corrected mail addresses of both Mark and Liam] > > > Hi, Takashi: > Thanks for correcting my mistake. > > At Fri, 10 Jan 2014 13:36:35 +0800, > > Nenghua Cao wrote: > >> > >> From: Nenghua Cao

[PATCH] regulator: maintainers: update email address

2013-01-15 Thread Liam Girdwood
From: Liam Girdwood I no longer work at TI. Signed-off-by: Liam Girdwood --- MAINTAINERS |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 915564e..3c2e275 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7082,7 +7082,7 @@ F:include

Re: [PATCH] sound/sgtl5000: fix initial setting for DAC data source

2012-11-28 Thread Liam Girdwood
On 28/11/12 09:20, Oskar Schirmer wrote: According to documentation bit 3:2 in register SSS_CTRL are reserved and zero, so the setting of 0x0008 does not make much sense. Instead, bit 4 should be set as is with power up, to reflect routing of I2S_IN to DAC correctly. Looks much like an off by on

Re: [PATCH] regulator: core: Add regulator_is_supported_voltage_tol()

2012-11-14 Thread Liam Girdwood
On 14/11/12 07:47, Mark Brown wrote: If consumers wish to set voltages based on a tolerance it stands to reason that they will also want to query for support in the same manner. Signed-off-by: Mark Brown Acked-by: Liam Girdwood -- To unsubscribe from this list: send the line "unsubs

Re: [alsa-devel] Query about alsa ucm (use case manager) config files

2012-10-31 Thread Liam Girdwood
On 31/10/12 12:59, Ashish Chavan wrote: > Hi, >I am just curious to know if there is any centralized repository for > alsa use case manager configuration files. I tried searching and could > only find alsa-ucm-conf.git repo at alsa project git server, which is > actually an empty repo! > This

Re: [PATCH] regulator: core: Fast path non-deferred disables

2012-09-07 Thread Liam Girdwood
-by: Mark Brown Acked-by: Liam Girdwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] regulator: core: Mark all DT based boards as having full constraints

2012-07-06 Thread Liam Girdwood
by: Mark Brown Acked-by: Liam Girdwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [UPDATED v2][PATCH 0/6] regulator: voltage and current regulator framework

2008-02-22 Thread Liam Girdwood
On Fri, 2008-02-22 at 11:22 +0800, eric miao wrote: > > I have a rough peek into the git tree on opensource.wolfsonmicro.com, > find another PMIC framework, and here instead is a regulator framework, > looks like a simplified or dedicated one. What is their relationship? > This is probably the o

Re: [UPDATED v2][PATCH 0/6] regulator: voltage and current regulator framework

2008-02-21 Thread Liam Girdwood
On Thu, 2008-02-21 at 08:41 +, Russell King - ARM Linux wrote: > On Wed, Feb 20, 2008 at 05:08:46PM +0000, Liam Girdwood wrote: > > This patch series provides a generic framework to allow device drivers > > to control voltage and current regulators on SoC based devices (e.g.

[PATCH 5/6] regulator: regulator framework build.

2008-02-20 Thread Liam Girdwood
This patch adds support to build the regulator core. Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> --- drivers/Kconfig|2 ++ drivers/Makefile |1 + drivers/regulator/Kconfig | 32 drivers/regulator/Makefile |9 ++

[PATCH 6/6] regulator: add maintainers.

2008-02-20 Thread Liam Girdwood
Added Liam Girdwood and Mark Brown as maintainers. Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> --- MAINTAINERS |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 082d1ee..1f7d3ce 100644 --- a/MAINTAINERS +++ b/MAINT

[PATCH 4/6] regulator: regulator core.

2008-02-20 Thread Liam Girdwood
This patch provides the regulator framework core. The core also provides a sysfs interface for userspace information. Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> --- drivers/regulator/reg-core.c | 1049 ++ 1 files changed, 1049 insertions

[PATCH 2/6] regulator: regulator driver interface.

2008-02-20 Thread Liam Girdwood
This interface allows regulator drivers to register their voltage and current regulators with the core. It also has a notifier call chain for propagating regulator events to clients. Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> --- include/linux/regulator/regulator-drv.h

[PATCH 3/6] regulator: platform level interface.

2008-02-20 Thread Liam Girdwood
Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> --- include/linux/regulator/regulator-platform.h | 104 ++ 1 files changed, 104 insertions(+), 0 deletions(-) create mode 100644 include/linux/regulator/regulator-platform.h diff --git a/include/linux/regulator/regulat

[PATCH 1/6] regulator: consumer driver regulator control framework.

2008-02-20 Thread Liam Girdwood
). Consumers can also get() or set() :- voltage, current, operating mode. Consumers can also enable and disable regulators. The framework also compiles out if not in use so drivers can be reused in systems with no software PMIC power control. Signed-off-by: Liam Girdwood <[EMAIL PROTEC

[UPDATED v2][PATCH 0/6] regulator: voltage and current regulator framework

2008-02-20 Thread Liam Girdwood
Version 2 with thanks to Sam Ravnborg, Mariusz Kozlowski, David Brownell and Laura Lawrence for their comments. This patch series provides a generic framework to allow device drivers to control voltage and current regulators on SoC based devices (e.g. phones, gps, media players). The intention is

[PATCH 4/4] Voltage and current regulator framework

2008-02-15 Thread Liam Girdwood
Wolfson Microelectronics PLC. + * + * Author: Liam Girdwood <[EMAIL PROTECTED]> + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2

[PATCH 5/4] Voltage and current regulator framework

2008-02-15 Thread Liam Girdwood
Oops, there is a 5/4 as I forgot this :- Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/4] Voltage and current regulator framework

2008-02-15 Thread Liam Girdwood
. + * + * Copyright (C) 2007, 2008 Wolfson Microelectronics PLC. + * + * Author: Liam Girdwood <[EMAIL PROTECTED]> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foun

[PATCH 0/4] Voltage and current regulator framework

2008-02-15 Thread Liam Girdwood
This patch series provides a generic framework to allow device drivers to control voltage and current regulators on SoC based devices (e.g. phones, gps, media players). The intention is to allow systems to dynamically control regulator output in order to save power and prolong battery life. This a

[PATCH 2/4] Voltage and current regulator framework

2008-02-15 Thread Liam Girdwood
. + * + * Copyright (C) 2007, 2008 Wolfson Microelectronics PLC. + * + * Author: Liam Girdwood <[EMAIL PROTECTED]> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License version 2 as + * published by the Free Software Foun

[PATCH 3/4] Voltage and current regulator framework

2008-02-15 Thread Liam Girdwood
Regulator support, platform driver API. + * + * Copyright (C) 2007, 2008 Wolfson Microelectronics PLC. + * + * Author: Liam Girdwood <[EMAIL PROTECTED]> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License versio

Re: TR: codec audio Cirrus CS42L51 - Audio capture problems

2007-10-10 Thread Liam Girdwood
On Wed, 2007-10-10 at 10:20 +0200, Pierre Savary wrote: > > I am currently writing a driver for the CS42L51 audio codec to work with > at91sam9260, using I2C and I2S. I used the couple of files { > /sound/soc/at91/eti_b1_wm8731.c , /sound/soc/codecs/wm8731.c } as a model. > I succeeded in playing

Re: [alsa-devel] [RFC][PATCH] Get rid of dead code in sound/pci/ac97/ac97_patch.c

2007-08-01 Thread Liam Girdwood
I'd prefer we keep this code in atm. The WM97xx touch driver needs it to eliminate any audio noise from the touchscreen ADC. I'll post the remaining touch driver patches in time for the next merge window. Liam On Tue, 2007-07-31 at 22:36 +0200, Michal Piotrowski wrote: > Hi, > > File /home/de

Re: [alsa-devel] Mic and Line In Capture AC97 slots issue

2007-05-10 Thread Liam Girdwood
On Thu, 2007-05-10 at 02:45 +0530, Nobin Mathew wrote: > http://mailman.alsa-project.org/pipermail/alsa-devel/2007-May/000835.html > http://mailman.alsa-project.org/pipermail/alsa-devel/2007-May/000837.html > > the overrun issue was because my application was not fast enough. > > I resolved that

Re: Fwd: [ASoC] Mic record is not working with wm9713 ASoC driver

2007-05-09 Thread Liam Girdwood
It's probably best to keep this thread on alsa-dev otherwise things start to get confusing when cross posting occurs. Liam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/maj

Re: [ASoC] Mic record is not working with wm9713 ASoC driver

2007-05-09 Thread Liam Girdwood
On Wed, 2007-05-09 at 14:48 +0530, Nobin Mathew wrote: > I am trying to record mic with AsoC wm9713 driver. My Mic is connected "Mic > 1". I've replied to this duplicate post on alsa-dev. Liam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] OSS Support for AC97 low power codecs

2005-01-26 Thread Liam Girdwood
Andrew, Looks like I missed a critical diff line in the patch :- --- a/include/linux/ac97_codec.h 2005-01-22 01:46:59.0 + and added some PM stuff that is from a future patch. Correct patch is attached. Liam On Wed, 2005-01-26 at 13:42, Liam Girdwood wrote: > Hi Andrew, >

[PATCH] OSS Support for AC97 low power codecs

2005-01-26 Thread Liam Girdwood
the mixer setup as some init settings were being clobbered. o Added extra check so that default_digital_ops doesn't overwrite a valid codec_ops. (SPDIF) Signed-off-by: Liam Girdwood <[EMAIL PROTECTED]> Liam diff -ur a/sound/oss/ac97_codec.c b/sound/oss/ac97_codec.c --- a/sound/oss/ac97_