Re: [PATCH 2/4] efi/libstub: detect panel-id

2019-07-03 Thread Leif Lindholm
On Tue, Jul 02, 2019 at 03:48:48PM -0700, Rob Clark wrote: > > > There is one kernel, and there > > > are N distro's, so debugging a users "I don't get a screen at boot" > > > problem because their distro missed some shim patch really just > > > doesn't seem like a headache I want to have. > > > >

Re: [PATCH] firmware: bluefield: add boot control driver

2017-10-10 Thread Leif Lindholm
On Tue, Oct 10, 2017 at 11:23:32AM +0100, Mark Rutland wrote: > On Tue, Oct 10, 2017 at 11:15:39AM +0100, Sudeep Holla wrote: > > (+Mark, Grant) > > > > On 09/10/17 18:16, Chris Metcalf wrote: > > > The Mellanox BlueField SoC firmware supports a safe upgrade mode as > > > part of the flow where u

Re: [PATCH v11 2/4] ACPI: parse SPCR and enable matching console

2017-09-11 Thread Leif Lindholm
On Mon, Sep 11, 2017 at 02:28:20PM +0200, Andreas Schwab wrote: > On Sep 11 2017, Graeme Gregory wrote: > > > Considering the SPCR table in question seems mildly insane, you could > > always unload the SPCR in grub. > > How do you "unload the SPCR"? But in any case, console= should always > tak

Re: [PATCH v11 2/4] ACPI: parse SPCR and enable matching console

2017-09-11 Thread Leif Lindholm
I'm afraid Aleksey is no longer assigned to Linaro (you will probably have seen a bounce). On Mon, Sep 11, 2017 at 11:11:49AM +0200, Andreas Schwab wrote: > On Sep 27 2016, Aleksey Makarov wrote: > > > 'ARM Server Base Boot Requiremets' [1] mentions SPCR (Serial Port > > Console Redirection Tabl

Re: [PATCH] arm64: Add translation functions for /dev/mem read/write

2017-05-03 Thread Leif Lindholm
On Wed, May 03, 2017 at 11:07:45AM -0600, Goel, Sameer wrote: > On 5/3/2017 5:26 AM, Will Deacon wrote: > > [adding some /dev/mem fans to cc] > > > > On Tue, May 02, 2017 at 02:28:05PM -0600, Sameer Goel wrote: > >> Port architecture specific xlate and unxlate functions for /dev/mem > >> read/writ

Re: [PATCH] efi: fdt: avoid FDT manipulation after ExitBootServices()

2017-02-01 Thread Leif Lindholm
ched to uncached memory accesses halfway through compiler generated code > (i.e., involving a stack) can never be done in a way that is architecturally > safe. > > Cc: > Fixes: abfb7b686a3e ("efi/libstub/arm*: Pass latest memory map to the kernel") > Tested-by: Riku Voipi

Re: [PATCHv2 1/5] efi/runtime-wrappers: add {__,}efi_call_virt templates

2016-04-21 Thread Leif Lindholm
On Thu, Apr 21, 2016 at 12:35:25PM +0100, Mark Rutland wrote: > Currently each architecture must implement two macros, efi_call_virt and > __efi_call_virt, which only differ by the presence or absence of a > return type. Otherwise, the logic surrounding the call is identical. > > As each architect

Re: arm64/efi handling of persistent memory

2015-12-18 Thread Leif Lindholm
On Fri, Dec 18, 2015 at 11:52:24AM +, Mark Rutland wrote: > On Fri, Dec 18, 2015 at 11:06:51AM +0000, Leif Lindholm wrote: > > On Fri, Dec 18, 2015 at 01:33:25AM +, Elliott, Robert (Persistent > > Memory) wrote: > > > Similar to the questions about the arm64 efi

Re: arm64/efi handling of persistent memory

2015-12-18 Thread Leif Lindholm
On Fri, Dec 18, 2015 at 01:33:25AM +, Elliott, Robert (Persistent Memory) wrote: > Similar to the questions about the arm64 efi boot stub > handing persistent memory, some of the arm64 kernel code > looks fishy. > > In arch/arm64/kernel/efi.c: > > static int __init is_normal_ram(efi_memory_

Re: [PATCH] efi/libstub/fdt: Standardize the names of EFI stub parameters

2015-09-10 Thread Leif Lindholm
On Thu, Sep 10, 2015 at 02:52:25PM +0100, Stefano Stabellini wrote: > > > In any case this should be separate from the shim ABI discussion. > > > > I disagree; I think this is very much relevant to the ABI discussion. > > That's not to say that I insist on a particular approach, but I think > > th

Re: [Linaro-acpi] [RFC 3/5] acpi/serial: add DBG2 earlycon support

2015-09-08 Thread Leif Lindholm
On Tue, Sep 08, 2015 at 12:38:59PM -0400, Mark Salter wrote: > On Tue, 2015-09-08 at 13:43 +0100, Leif Lindholm wrote: > > The ACPI DBG2 table defines a debug console. Add support for parsing it > > and using it to select earlycon destination when no arguments provided. > &g

Re: [RFC 3/5] acpi/serial: add DBG2 earlycon support

2015-09-08 Thread Leif Lindholm
On Tue, Sep 08, 2015 at 02:09:51PM +0100, Mark Rutland wrote: > On Tue, Sep 08, 2015 at 01:43:35PM +0100, Leif Lindholm wrote: > > The ACPI DBG2 table defines a debug console. Add support for parsing it > > and using it to select earlycon destination when no arguments provided. >

Re: [RFC 5/5] HACK: serial: move pl011 initcall to device_initcall

2015-09-08 Thread Leif Lindholm
On Tue, Sep 08, 2015 at 01:56:08PM +0100, Mark Rutland wrote: > On Tue, Sep 08, 2015 at 01:43:37PM +0100, Leif Lindholm wrote: > > --- > > drivers/tty/serial/amba-pl011.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tty/s

Re: [RFC 2/5] of/serial: move earlycon early_param handling to serial

2015-09-08 Thread Leif Lindholm
On Tue, Sep 08, 2015 at 01:52:45PM +0100, Mark Rutland wrote: > On Tue, Sep 08, 2015 at 01:43:34PM +0100, Leif Lindholm wrote: > > We have multiple "earlycon" early_param handlers - merge the DT one into > > the main earlycon one. This means the earlycon early_param

[RFC 1/5] arm64: move acpi/dt decision earlier in boot process

2015-09-08 Thread Leif Lindholm
In order to support selecting earlycon via either ACPI or DT, move the decision on whether to attempt ACPI configuration into the early_param handling. Then make acpi_boot_table_init() bail out if acpi_disabled. Signed-off-by: Leif Lindholm --- arch/arm64/kernel/acpi.c | 53

[RFC 4/5] tty/console: use SPCR table to define console

2015-09-08 Thread Leif Lindholm
in the boot process. Signed-off-by: Jon Masters [rebased and cleaned up] Signed-off-by: Torez Smith [reworked to use _CRS, moved to drivers/acpi] Signed-off-by: Leif Lindholm --- drivers/acpi/console.c | 157 +++ drivers/tty/serial/serial_core.c

[RFC 3/5] acpi/serial: add DBG2 earlycon support

2015-09-08 Thread Leif Lindholm
The ACPI DBG2 table defines a debug console. Add support for parsing it and using it to select earlycon destination when no arguments provided. Signed-off-by: Leif Lindholm --- arch/arm64/kernel/acpi.c | 2 + drivers/acpi/Makefile | 1 + drivers/acpi/console.c| 103

[RFC 2/5] of/serial: move earlycon early_param handling to serial

2015-09-08 Thread Leif Lindholm
We have multiple "earlycon" early_param handlers - merge the DT one into the main earlycon one. This means the earlycon early_param handler does not just return success if no options are specified. Signed-off-by: Leif Lindholm --- drivers/of/fdt.c | 11 +-- d

[RFC 5/5] HACK: serial: move pl011 initcall to device_initcall

2015-09-08 Thread Leif Lindholm
--- drivers/tty/serial/amba-pl011.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/amba-pl011.c b/drivers/tty/serial/amba-pl011.c index 452dbba..31cf985 100644 --- a/drivers/tty/serial/amba-pl011.c +++ b/drivers/tty/serial/amba-pl011.c @@ -2806,7 +2806,7 @@

[RFC 0/5] console/acpi: add DBG2 and SPCR console configuration

2015-09-08 Thread Leif Lindholm
x27;s 2012 DBGP/DBG2 set (although not much of the original remains - this is quite a cut-down version). Leif Lindholm (4): arm64: move acpi/dt decision earlier in boot process of/serial: move earlycon early_param handling to serial acpi/serial: add DBG2 earlycon support HACK: serial:

Re: [PATCH 1/4] x86, efi, kasan: #undef memset/memcpy/memmove per arch.

2015-08-28 Thread Leif Lindholm
On Fri, Aug 28, 2015 at 08:27:45AM +0200, Ingo Molnar wrote: > > * Andrey Ryabinin wrote: > > > In not-instrumented code KASAN replaces instrumented > > memset/memcpy/memmove with not-instrumented analogues > > __memset/__memcpy/__memove. > > However, on x86 EFI stub is not linked with kernel. >

Re: [PATCH 2/3] arm64: use core efi=debug instead of uefi_debug command line parameter

2015-08-26 Thread Leif Lindholm
On Wed, Aug 26, 2015 at 06:24:55PM +0100, Matt Fleming wrote: > On Wed, 26 Aug, at 02:24:57PM, Leif Lindholm wrote: > > Now that we have an efi=debug command line option in the core code, use > > this instead of the arm64-specific uefi_debug option. > > > > S

[PATCH 0/3] unify efi debug output across architectures

2015-08-26 Thread Leif Lindholm
7; instead of 'uefi_debug' - Rework arm64 interface to core code to drop special verbosity flag Leif Lindholm (3): efi/x86: move efi=debug option parsing to core arm64: use core efi=debug instead of uefi_debug command line parameter efi/arm64: clean up efi_get_fdt_params() interface

[PATCH 2/3] arm64: use core efi=debug instead of uefi_debug command line parameter

2015-08-26 Thread Leif Lindholm
Now that we have an efi=debug command line option in the core code, use this instead of the arm64-specific uefi_debug option. Signed-off-by: Leif Lindholm --- Documentation/arm/uefi.txt | 2 -- arch/arm64/kernel/efi.c| 19 +-- 2 files changed, 5 insertions(+), 16 deletions

[PATCH 3/3] efi/arm64: clean up efi_get_fdt_params() interface

2015-08-26 Thread Leif Lindholm
As we now have a common debug infrastructure between core and arm64 efi, drop the bit of the interface passing verbose output flags around. Signed-off-by: Leif Lindholm --- arch/arm64/kernel/efi.c| 2 +- drivers/firmware/efi/efi.c | 6 ++ include/linux/efi.h| 2 +- 3 files

[PATCH 1/3] efi/x86: move efi=debug option parsing to core

2015-08-26 Thread Leif Lindholm
fed6cefe3b6e ("x86/efi: Add a "debug" option to the efi= cmdline") adds the DBG flag, but does so for x86 only. Move this early param parsing to core code. Signed-off-by: Leif Lindholm --- arch/x86/platform/efi/efi.c | 2 -- drivers/firmware/efi/efi.c | 3 +++ 2 files c

Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node

2015-08-25 Thread Leif Lindholm
On Tue, Aug 25, 2015 at 04:51:22PM +0200, Ard Biesheuvel wrote: > >>Arm kernel should either fetch memory information from > >>efi or DT. > > > > Absolutely. > > > >>Currently arm kernel fetch both efi memory information and > >>reserved buffer from DTB at the same time. > > > > No,

Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node

2015-08-25 Thread Leif Lindholm
On Tue, Aug 25, 2015 at 09:43:14PM +0800, Haojian Zhuang wrote: > Since we discussed a lot on this, let's make a conclusion on it. > > 1. UEFI could append the reserved buffer in it's memory mapping. Yes. It needs to. (I will let Mark comment on points 2-4.) > 5. A patch is necessary in kernel.

Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node

2015-08-25 Thread Leif Lindholm
On Tue, Aug 25, 2015 at 06:15:10PM +0800, Haojian Zhuang wrote: > > > 1. We need support both UEFI and uboot. So the reserved buffer have to > > > be declared in DTB since they are used by kernel driver, not UEFI. > > > > The buffer may need to be declared in DTB also, but it most certanily > > ne

Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node

2015-08-25 Thread Leif Lindholm
On Tue, Aug 25, 2015 at 04:13:47PM +0800, Haojian Zhuang wrote: > On Mon, 2015-08-24 at 12:49 +0100, Leif Lindholm wrote: > > On Mon, Aug 24, 2015 at 06:19:56PM +0800, Haojian Zhuang wrote: > > > > If your EFI memory map describes the memory as mappable, it is wrong. > &

Re: [PATCH v1 3/3] arm64: dts: add Hi6220 mailbox node

2015-08-24 Thread Leif Lindholm
On Mon, Aug 24, 2015 at 06:19:56PM +0800, Haojian Zhuang wrote: > > If your EFI memory map describes the memory as mappable, it is wrong. > > When kernel is working, kernel will create its own page table based on > UEFI memory map. Since it's reserved in DTS file as Leo's patch, it'll > be moved t

Re: [PATCH v2 0/3] SysFS driver for QEMU fw_cfg device

2015-08-19 Thread Leif Lindholm
On Wed, Aug 19, 2015 at 04:49:15PM -0400, Gabriel L. Somlo wrote: > Hi Ard, > > On Wed, Aug 19, 2015 at 11:42:02AM +0200, Ard Biesheuvel wrote: > > (missed some cc's) > > > > On 19 August 2015 at 11:38, Ard Biesheuvel > > wrote: > > > From: "Gabriel L. Somlo" > > >> Several different architect

Re: [PATCH 2/2] of: unittest: Add option string test case with longer path

2015-03-17 Thread Leif Lindholm
#2 failed\n"); > + of_node_put(np); > + > np = of_find_node_opts_by_path("/testcase-data:testoption", NULL); > selftest(np, "NULL option path test failed\n"); > of_node_put(np); > -- > 1.9.1 Acked-by: Leif Lindholm -- To unsubscribe fr

Re: [PATCH 1/2] of: handle both '/' and ':' in path strings

2015-03-17 Thread Leif Lindholm
truct > device_node *parent, > { > struct device_node *child; > int len; > - const char *end; > > - end = strchr(path, ':'); > - if (!end) > - end = strchrnul(path, '/'); > - > - len = end - path; > +

Re: [PATCH 0/2] of: fix handling of '/' in path options

2015-03-11 Thread Leif Lindholm
On Wed, Mar 11, 2015 at 07:49:33AM -0500, Rob Herring wrote: > On Mon, Mar 9, 2015 at 1:03 PM, Leif Lindholm > wrote: > > Commit 7914a7c5651a ("of: support passing console options with > > stdout-path") neglected to deal with '/'s appearing past the '

Re: [PATCH v9 05/21] ARM64 / ACPI: Get RSDP and ACPI boot-time tables

2015-03-10 Thread Leif Lindholm
On Tue, Mar 10, 2015 at 04:01:16PM +0800, Hanjun Guo wrote: > >>index 000..f052e7a > >>--- /dev/null > >>+++ b/arch/arm64/kernel/acpi.c > >>@@ -0,0 +1,101 @@ > >>+/* > >>+ * ARM64 Specific Low-Level ACPI Boot Support > >>+ * > >>+ * Copyright (C) 2013-2014, Linaro Ltd. > >>+ * Author: Al Ston

[PATCH 1/2] of: fix handling of '/' in options for of_find_node_by_path()

2015-03-09 Thread Leif Lindholm
Ensure proper handling of paths with appended options (after ':'), where those options may contain a '/'. Fixes: 7914a7c5651a ("of: support passing console options with stdout-path") Reported-by: Peter Hurley Signed-off-by: Leif Lindholm --- drivers/of/base.c |

[PATCH 2/2] of: unittest: Add options string testcase variants

2015-03-09 Thread Leif Lindholm
From: Peter Hurley Add testcase variants with '/' in the options string to test for scan beyond end path name terminated by ':'. Signed-off-by: Peter Hurley --- drivers/of/unittest.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c

[PATCH 0/2] of: fix handling of '/' in path options

2015-03-09 Thread Leif Lindholm
Commit 7914a7c5651a ("of: support passing console options with stdout-path") neglected to deal with '/'s appearing past the ':' terminator. This mini-series fixes this oversight and adds the tests to prove it. Leif Lindholm (1): of: fix handling of '/&#

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2015-03-06 Thread Leif Lindholm
t failed\n"); > + of_node_put(np); > + > np = of_find_node_opts_by_path("testcase-alias:testaliasoption", NULL); > selftest(np, "NULL option alias path test failed\n"); > of_node_put(np); Could you give the below a spin, and if it work

Re: [PATCH v8 08/21] dt / chosen: Add linux,uefi-stub-generated-dtb property

2015-02-02 Thread Leif Lindholm
ot; is passed in early parameters. > > CC: Mark Rutland > CC: Jonathan Corbet > CC: Catalin Marinas > CC: Will Deacon > CC: Leif Lindholm > CC: Grant Likely > CC: Matt Fleming > Signed-off-by: Hanjun Guo > --- > Documentation/arm/uefi.txt | 3 +++ >

Re: [PATCH v7 04/17] ARM64 / ACPI: Introduce early_param for "acpi" and pass acpi=force to enable ACPI

2015-01-20 Thread Leif Lindholm
On Tue, Jan 20, 2015 at 11:10:32AM +, Mark Rutland wrote: > > diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c > > index 54e39e3..8268c7b 100644 > > --- a/arch/arm64/kernel/setup.c > > +++ b/arch/arm64/kernel/setup.c > > @@ -371,6 +371,31 @@ static void __init request_standard

Re: SMBIOS/DMI data under CONFIG_STRICT_DEVMEM

2015-01-17 Thread Leif Lindholm
On Sat, Jan 17, 2015 at 03:12:13PM -0500, Jon Masters wrote: > Hi Catalin, all, > > I would like to ensure that the SMBIOS data provided by firmware is > always readable from userspace on AArch64, through /dev/mem. No, we need to ensure /dev/mem can be completely disabled on any system that ever

Re: [PATCH v5 6/8] arm64/efi: move SetVirtualAddressMap() to UEFI stub

2015-01-09 Thread Leif Lindholm
* Estimate size of new FDT, and allocate memory for it. We > @@ -248,12 +267,48 @@ efi_status_t > allocate_new_fdt_and_exit_boot(efi_system_table_t *sys_table, > } > } > > + /* > + * Update the memory map with virtual addresses. The function will also >

Re: [PATCH v5 0/8] arm64: stable UEFI virtual mappings for kexec

2015-01-09 Thread Leif Lindholm
For the series: Tested-by: Leif Lindholm -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[RFC] fs: make efivarfs a pseudo filesystem, built by default with EFI

2014-12-18 Thread Leif Lindholm
variables, over the legacy efivars interface, also build it by default as a module if CONFIG_EFI. Signed-off-by: Leif Lindholm --- fs/Kconfig | 2 +- fs/efivarfs/Kconfig | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/Kconfig b/fs/Kconfig index 664991a..a6bb

Re: [PATCH v3 2/3] of: add optional options parameter to? of_find_node_by_path()

2014-11-28 Thread Leif Lindholm
On Fri, Nov 28, 2014 at 03:25:12PM +, Grant Likely wrote: > On Fri, 28 Nov 2014 11:34:28 + > , Leif Lindholm > wrote: > > On Fri, Nov 28, 2014 at 12:44:03AM +, Grant Likely wrote: > > > > + separator = strchr(path, ':');

Re: [PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2014-11-28 Thread Leif Lindholm
On Fri, Nov 28, 2014 at 12:44:03AM +, Grant Likely wrote: > On Thu, 27 Nov 2014 17:56:06 + > , Leif Lindholm > wrote: > > Update of_find_node_by_path(): > > 1) Rename function to of_find_node_opts_by_path(), adding an optional > >pointer argument. Prov

[PATCH v3 1/3] devicetree: of: Add bindings for chosen node, stdout-path

2014-11-27 Thread Leif Lindholm
Add a global binding for the chosen node. Include a description of the stdout-path, and an explicit statement on its extra options in the context of a UART console. Opening description stolen from www.devicetree.org, and part of the remaining text provided by Mark Rutland. Signed-off-by: Leif

[PATCH v3 0/3] of: support passing console options with stdout-path

2014-11-27 Thread Leif Lindholm
since v1: - Change interface of of_get_node_by_path() to take an additional argument, and update all of its callers to keep working. - Rework original patch to use this interface. Leif Lindholm (3): devicetree: of: Add bindings for chosen node, stdout-path of: add optional options parameter

[PATCH v3 3/3] of: support passing console options with stdout-path

2014-11-27 Thread Leif Lindholm
Support specifying console options (like with console=ttyXN,) by appending them to the stdout-path property after a separating ':'. Example: stdout-path = "uart0:115200"; Signed-off-by: Leif Lindholm --- drivers/of/base.c |9 +++-- 1 file changed, 7 insert

[PATCH v3 2/3] of: add optional options parameter to of_find_node_by_path()

2014-11-27 Thread Leif Lindholm
and including the ':' separator. 3) Set the new provided pointer argument to the beginning of the string following the ':' separator. 4: Add tests. Signed-off-by: Leif Lindholm --- drivers/of/base.c | 21 + drivers/of/selftest.c | 12

Re: [PATCH v2 2/2] of: support passing console options with stdout-path

2014-11-27 Thread Leif Lindholm
v 26, 2014 at 05:40:40PM +, Leif Lindholm wrote: > > > >> Support specifying console options (like with console=ttyXN,) > > > >> by appending them to the stdout-path property after a separating ':'. > > > >> > > > >> Example

Re: [PATCH v2 1/2] of: add optional options parameter to of_find_node_by_path()

2014-11-26 Thread Leif Lindholm
On Wed, Nov 26, 2014 at 09:06:33PM +, Grant Likely wrote: > On Wed, Nov 26, 2014 at 5:40 PM, Leif Lindholm > wrote: > > Update of_find_node_by_path(): > > 1) Ignore any part of the path beyond and including the ':' separator. > > 2) Set the new provided po

[PATCH v2 2/2] of: support passing console options with stdout-path

2014-11-26 Thread Leif Lindholm
Support specifying console options (like with console=ttyXN,) by appending them to the stdout-path property after a separating ':'. Example: stdout-path = "uart0:115200"; Signed-off-by: Leif Lindholm --- drivers/of/base.c |5 +++-- 1 file changed, 3 insert

[PATCH v2 1/2] of: add optional options parameter to of_find_node_by_path()

2014-11-26 Thread Leif Lindholm
find_node_by_path(E1) + of_find_node_by_path(E1, NULL) drivers/of/resolver.c manually updated, since spatch fails to parse it correctly. Signed-off-by: Leif Lindholm --- arch/arm/kernel/devtree.c |2 +- arch/arm/mach-bcm/kona_smp.c|2 +- arc

[PATCH v2 0/2] of: support passing console options with stdout-path

2014-11-26 Thread Leif Lindholm
maintains existing whitespace errors. Changes since v1: - Change interface of of_get_node_by_path() to take an additional argument, and update all of its callers to keep working. - Rework original patch to use this interface. Leif Lindholm (2): of: add optional options parameter to

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Leif Lindholm
On Tue, Nov 25, 2014 at 02:58:54PM +, Grant Likely wrote: > > + len = strchrnul(path, ':') - path; > > + > > for_each_property_of_node(of_aliases, pp) { > > if (strlen(pp->name) == len && !strncmp(pp->name, path, > > len)) { > >

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Leif Lindholm
I booted anything at all, given how badly I broke path scanning... Please ignore previous version - a fixed one follows: / Leif >From aef87fd958902afe881720286d525e10997462b8 Mon Sep 17 00:00:00 2001 From: Leif Lindholm Date: Mon, 24 Nov 2014 22:23:58 + Subject: [PATCH] of: support

Re: [PATCH] of: support passing console options with stdout-path

2014-11-25 Thread Leif Lindholm
On Tue, Nov 25, 2014 at 10:35:04AM +, Mark Rutland wrote: > On Mon, Nov 24, 2014 at 10:23:58PM +0000, Leif Lindholm wrote: > > Support specifying console options (like with console=ttyXN,) > > by appending them to the stdout-path property after a separating '

Re: [PATCH] of: support passing console options with stdout-path

2014-11-24 Thread Leif Lindholm
On Tue, Nov 25, 2014 at 12:00:16AM +0100, Andrew Lunn wrote: > On Mon, Nov 24, 2014 at 10:23:58PM +0000, Leif Lindholm wrote: > > Support specifying console options (like with console=ttyXN,) > > by appending them to the stdout-path property after a separating ':'. > &g

[PATCH] of: support passing console options with stdout-path

2014-11-24 Thread Leif Lindholm
':'. Signed-off-by: Leif Lindholm --- drivers/of/base.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 3823edf..89c6b33 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -37,6 +37,7 @@ EXPOR

Re: [RFC PATCH] make CONFIG_STRICT_DEVMEM a core non-debug feature

2014-11-04 Thread Leif Lindholm
On Tue, Nov 04, 2014 at 12:02:32PM -0800, Kees Cook wrote: > > I considered doing that, but didn't want to risk listing too many > > details of one architecture, and too few of others. > > Well, the others only say "memory mapped peripherals", so that's what > I was suggesting adding the x86 langu

Re: [RFC PATCH] make CONFIG_STRICT_DEVMEM a core non-debug feature

2014-11-04 Thread Leif Lindholm
On Tue, Nov 04, 2014 at 10:43:00AM -0800, Kees Cook wrote: > > diff --git a/drivers/char/Kconfig b/drivers/char/Kconfig > > index efefd12..39f7817 100644 > > --- a/drivers/char/Kconfig > > +++ b/drivers/char/Kconfig > > @@ -6,6 +6,22 @@ menu "Character devices" > > > > source "drivers/tty/Kconfig"

[RFC PATCH] make CONFIG_STRICT_DEVMEM a core non-debug feature

2014-11-04 Thread Leif Lindholm
Most, but not all, architectures supporting CONFIG_STRICT_DEVMEM treat it as a debug feature - although its function is pretty much the opposite of debug. This patch deletes all architecture-specific config options and moves the option to core code, as a non-debug option. Signed-off-by: Leif

Re: [GIT PULL] x86 fixes

2014-09-23 Thread Leif Lindholm
yes, then this patch might break your build and we > probably want to do something like unconditionally select > CONFIG_EFI_ARM_STUB when CONFIG_EFI_STUB=y. For arm64: Tested-by: Leif Lindholm > --- > > From 8054c405f0acc8ecb74b7e29675a1e6894afedb0 Mon Sep 17 00:00:00 2001 > From

Re: [PATCH 3/8] arm: mm: reduce fixmap kmap from 32 to 16 CPUS

2014-08-08 Thread Leif Lindholm
On Thu, Aug 07, 2014 at 05:18:44PM -0500, Rob Herring wrote: > On Thu, Aug 7, 2014 at 10:01 AM, Kees Cook wrote: > > More room is needed in the fixmap range for non-kmap fixmap entries. This > > reduces the kmap range from 32 to 16 CPUs. > > Do you want this merged or just doing this to get the r

Re: [PATCH 1/8] arm: use generic fixmap.h

2014-08-07 Thread Leif Lindholm
LK(ITCM_OFFSET, (unsigned long) itcm_end), > #endif > - MLK(FIXADDR_START, FIXADDR_TOP), > + MLK(FIXADDR_START, FIXADDR_END), > MLM(VMALLOC_START, VMALLOC_END), > MLM(PAGE_OFFSET, (unsigned long)high_me

Re: [PATCH 1/2] UEFI arm64: add noefi boot param

2014-08-06 Thread Leif Lindholm
On Wed, Aug 06, 2014 at 03:18:14PM +0100, Matt Fleming wrote: > On Wed, 06 Aug, at 04:10:45PM, Ard Biesheuvel wrote: > > > > Shouldn't we clear the bit here if we failed to enable runtime > > services for some reason? Other code may test the bit assuming that it > > signifies that runtime services

Re: [PATCH 1/2] UEFI arm64: add noefi boot param

2014-08-06 Thread Leif Lindholm
On Wed, Aug 06, 2014 at 02:20:21PM +0100, Matt Fleming wrote: > > Since this is really turning an x86-specific feature into a generic > > one, could it be moved to core code? > > Maybe an efi.mask, reusing the efi_enabled defines, with an > > efi_disabled macro? > > Why the new efi_disabled() and

Re: [PATCH 1/2] UEFI arm64: add noefi boot param

2014-08-06 Thread Leif Lindholm
On Wed, Aug 06, 2014 at 04:38:25PM +0800, Dave Young wrote: > > Adding a noefi boot param like in X86 to disable efi runtime services support. > > This will be useful for debugging uefi problems. Also it will be useful > for later kexec/kdump work. Kexec on uefi support in X86 depends on a fixed

Re: [GIT PULL] EFI urgent fix

2014-06-20 Thread Leif Lindholm
On Fri, Jun 20, 2014 at 02:49:38PM +0100, Matt Fleming wrote: > On Fri, 20 Jun, at 02:39:19PM, Leif Lindholm wrote: > > > > I did post an alternative patch for one half of this a week before > > anyone else, but that one seems to have been ignored, even by gmane: > > h

Re: [GIT PULL] EFI urgent fix

2014-06-20 Thread Leif Lindholm
On Fri, Jun 20, 2014 at 10:28:48AM +0100, Catalin Marinas wrote: > On Fri, Jun 20, 2014 at 10:00:08AM +0100, Matt Fleming wrote: > > Please pull the following compiler warning fix. Sorry, I've been pretty > > slow in getting this pull request sent. Multiple people have reported > > hitting it and I

Re: [PATCH] arm64: Add flush_cache_vmap call in __early_set_fixmap

2014-06-09 Thread Leif Lindholm
On Mon, Jun 09, 2014 at 12:03:56PM +0100, Catalin Marinas wrote: > > > > > __early_set_fixmap does not do any synchronization when called to set > > > > > a > > > > > fixmap entry. Add call to flush_vmap_cache(). > > Did you hit a problem or it was just for safety? This fixes an abort when acces

Re: [PATCH] arm64: Add flush_cache_vmap call in __early_set_fixmap

2014-06-06 Thread Leif Lindholm
On Fri, Jun 06, 2014 at 10:37:29AM -0400, Mark Salter wrote: > On Fri, 2014-06-06 at 11:29 +0100, Leif Lindholm wrote: > > __early_set_fixmap does not do any synchronization when called to set a > > fixmap entry. Add call to flush_vmap_cache(). > > > > Tested on hardw

[PATCH] arm64: Add flush_cache_vmap call in __early_set_fixmap

2014-06-06 Thread Leif Lindholm
__early_set_fixmap does not do any synchronization when called to set a fixmap entry. Add call to flush_vmap_cache(). Tested on hardware. Signed-off-by: Leif Lindholm Tested-by: Graeme Gregory Cc: Steve Capper --- arch/arm64/mm/ioremap.c |5 +++-- 1 file changed, 3 insertions(+), 2

Re: [PATCH v2 00/10] arm64: UEFI support

2014-04-29 Thread Leif Lindholm
On Tue, Apr 29, 2014 at 04:27:07PM +0100, Matt Fleming wrote: > > I'm wondering if it would be better to organize it into a separate topic > > branch. We can still take it through tip, if you want, but it would be > > better than putting it all into one tree. > > Sure, that makes sense. I'll do t

[PATCH v2 01/10] lib: add fdt_empty_tree.c

2014-04-25 Thread Leif Lindholm
From: Mark Salter CONFIG_LIBFDT support does not include fdt_empty_tree.c which is needed by arm64 EFI stub. Add it to libfdt_files. Signed-off-by: Mark Salter Signed-off-by: Leif Lindholm --- lib/Makefile |3 ++- lib/fdt_empty_tree.c |2 ++ 2 files changed, 4 insertions

[PATCH v2 03/10] efi: add helper function to get UEFI params from FDT

2014-04-25 Thread Leif Lindholm
-by: Mark Salter Signed-off-by: Leif Lindholm --- drivers/firmware/efi/Kconfig |7 drivers/firmware/efi/efi.c | 79 ++ include/linux/efi.h |9 + 3 files changed, 95 insertions(+) diff --git a/drivers/firmware/efi/Kconfig b

[PATCH v2 05/10] efi: Add shared FDT related functions for ARM/ARM64

2014-04-25 Thread Leif Lindholm
-helper.c. Signed-off-by: Roy Franz [ Fixed memory node deletion code. ] Signed-off-by: Mark Rutland Signed-off-by: Leif Lindholm Acked-by: Grant Likely --- drivers/firmware/efi/fdt.c | 285 include/linux/efi.h|3 + 2 files changed, 288

[PATCH v2 02/10] doc: efi-stub.txt updates for ARM

2014-04-25 Thread Leif Lindholm
From: Roy Franz Update efi-stub.txt documentation to be more general and not x86 specific. Add ARM only "dtb=" command line option description. Signed-off-by: Roy Franz Signed-off-by: Leif Lindholm Acked-by: Grant Likely --- Documentation/efi-stub.txt | 27

[PATCH v2 04/10] arm64: Add function to create identity mappings

2014-04-25 Thread Leif Lindholm
UEFI. This patch adds a create_id_mapping() function which reuses the core code of the existing create_mapping(). Signed-off-by: Mark Salter [ Fixed error message formatting (%pa). ] Signed-off-by: Mark Rutland Signed-off-by: Leif Lindholm --- arch/arm64/include/asm/mmu.h |2 ++ arch/arm64

[PATCH v2 09/10] doc: arm64: add description of EFI stub support

2014-04-25 Thread Leif Lindholm
From: Mark Salter Add explanation of arm64 EFI stub and kernel image header changes needed to masquerade as a PE/COFF application. Signed-off-by: Mark Salter Signed-off-by: Leif Lindholm Acked-by: Grant Likely CC: linux-...@vger.kernel.org CC: Rob Landley --- Documentation/arm64

[PATCH v2 07/10] doc: arm: add UEFI support documentation

2014-04-25 Thread Leif Lindholm
This patch provides documentation of the [U]EFI runtime service and configuration features for the arm architecture. Signed-off-by: Leif Lindholm Acked-by: Grant Likely --- Documentation/arm/00-INDEX |2 ++ Documentation/arm/uefi.txt | 64 2

[PATCH v2 06/10] arm64: add EFI runtime services

2014-04-25 Thread Leif Lindholm
: Leif Lindholm --- arch/arm64/Kconfig | 15 ++ arch/arm64/include/asm/efi.h | 14 ++ arch/arm64/kernel/Makefile |1 + arch/arm64/kernel/efi.c | 466 ++ arch/arm64/kernel/setup.c|5 + 5 files changed, 501 insertions

[PATCH v2 08/10] arm64: efi: add EFI stub

2014-04-25 Thread Leif Lindholm
] Signed-off-by: Ard Biesheuvel Signed-off-by: Leif Lindholm --- arch/arm64/Kconfig |5 +- arch/arm64/kernel/Makefile |4 +- arch/arm64/kernel/efi-entry.S | 109 + arch/arm64/kernel/efi-stub.c| 81 + arch/arm64/kernel/head.S

[PATCH v2 10/10] efi/arm64: ignore dtb= when UEFI SecureBoot is enabled

2014-04-25 Thread Leif Lindholm
From: Ard Biesheuvel Loading unauthenticated FDT blobs directly from storage is a security hazard, so this should only be allowed when running with UEFI Secure Boot disabled. Signed-off-by: Ard Biesheuvel Signed-off-by: Leif Lindholm --- drivers/firmware/efi/arm-stub.c | 39

[PATCH v2 00/10] arm64: UEFI support

2014-04-25 Thread Leif Lindholm
struction cache by address for kernel image area. - CONFIG_EFI_STUB merged into CONFIG_EFI since they are interdependent. - EFI_DEVICE_TREE_GUID renamed DEVICE_TREE_GUID. - Minor cleanups. Ard Biesheuvel (1): efi/arm64: ignore dtb= when UEFI SecureBoot is enabled Leif Lindholm (1): doc: arm:

Re: [PATCH 3/3] of: Handle memory@0 node on PPC32 only

2014-04-24 Thread Leif Lindholm
On Wed, Apr 23, 2014 at 02:10:58PM +0100, Grant Likely wrote: > > Does anyone have a LongTrail DT to hand, and if so does the root have a > > compatible string? From grepping through the kernel I could only find a > > model string ("IBM,LongTrail"). > > Actually, on LongTrail this can be removed f

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-23 Thread Leif Lindholm
On Wed, Apr 23, 2014 at 02:15:08PM +0100, Grant Likely wrote: > > The reason for me doing that is because we (including you) agreed at > > the discussion held during LCU13 that this was the safest way of > > preventing "mischief" like userland trying to read information from > > /proc/device-tree..

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-22 Thread Leif Lindholm
On Tue, Apr 22, 2014 at 02:08:29PM +0100, Grant Likely wrote: > > I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here. > > I completely agree. OK. So do we keep this around on unaffected architectures in perpetuity? Or can there be some cut-off date when the majority of DT-e

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-18 Thread Leif Lindholm
On Fri, Apr 18, 2014 at 04:28:17PM -0500, Rob Herring wrote: > >> > Apart from the current code permitting recreating a 15+ year old > >> > firmware bug into completely new platform ports? > >> > >> I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here. > > > > In addition to, or

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-18 Thread Leif Lindholm
On Fri, Apr 18, 2014 at 10:37:58AM -0500, Rob Herring wrote: > >> But why do you need this? > > > > Apart from the current code permitting recreating a 15+ year old > > firmware bug into completely new platform ports? > > I would prefer to see a "WARN_ON(!IS_ENABLED(CONFIG_PPC32));" added here. I

Re: [PATCH 3/3] of: Handle memory@0 node on PPC32 only

2014-04-18 Thread Leif Lindholm
Hi Geert, On Fri, Apr 18, 2014 at 10:04:15AM +0200, Geert Uytterhoeven wrote: > On Thu, Apr 17, 2014 at 7:42 PM, Leif Lindholm > wrote: > > In order to deal with an firmware bug on a specific ppc32 platform > > (longtrail), early_init_dt_scan_memory() looks for a node called &

Re: [PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-18 Thread Leif Lindholm
On Thu, Apr 17, 2014 at 07:43:13PM -0500, Rob Herring wrote: > On Thu, Apr 17, 2014 at 12:41 PM, Leif Lindholm > wrote: > > drivers/of/fdt.c contains a workaround for a missing memory type > > entry on longtrail firmware. Make that quirk PPC32 only, and while > > at it -

[PATCH 2/3] mips: dts: add device_type="memory" where missing

2014-04-17 Thread Leif Lindholm
A few platforms lack a 'device_type = "memory"' for their memory nodes, relying on an old ppc quirk in order to discover its memory. Add this, to permit that quirk to be made ppc only. Signed-off-by: Leif Lindholm Cc: linux-m...@linux-mips.org Cc: devicet...@vger.kernel.org

[PATCH 3/3] of: Handle memory@0 node on PPC32 only

2014-04-17 Thread Leif Lindholm
In order to deal with an firmware bug on a specific ppc32 platform (longtrail), early_init_dt_scan_memory() looks for a node called memory@0 on all platforms. Restrict this quirk to ppc32 kernels only. Signed-off-by: Leif Lindholm Cc: linuxppc-...@lists.ozlabs.org Cc: Grant Likely Cc: Mark

[PATCH 1/3] arm: dts: add device_type="memory" for ste-ccu8540

2014-04-17 Thread Leif Lindholm
The current .dts for ste-ccu8540 lacks a 'device_type = "memory"' for its memory node, relying on an old ppc quirk in order to discover its memory. Add this, to permit that quirk to be made ppc only. Signed-off-by: Leif Lindholm Cc: linux-arm-ker...@lists.infra

[PATCH 0/3] of: dts: enable memory@0 quirk for PPC32 only

2014-04-17 Thread Leif Lindholm
-kernel@vger.kernel.org Cc: Mark Rutland Leif Lindholm (3): arm: dts: add device_type="memory" for ste-ccu8540 mips: dts: add device_type="memory" where missing of: Handle memory@0 node on PPC32 only arch/arm/boot/dts/ste-ccu8540.dts |1 + arch/mips/lantiq/dts/eas

[PATCH v3 02/10] doc: efi-stub.txt updates for ARM

2014-04-04 Thread Leif Lindholm
From: Roy Franz Update efi-stub.txt documentation to be more general and not x86 specific. Add ARM only "dtb=" command line option description. Signed-off-by: Roy Franz Signed-off-by: Leif Lindholm Acked-by: Grant Likely --- Documentation/efi-stub.txt | 27

  1   2   3   >