Re: (subset) [PATCH v4 3/3] mfd: 88pm886: Add GPADC cell

2025-09-16 Thread Lee Jones
On Thu, 11 Sep 2025 14:43:46 +0200, Duje Mihanović wrote: > Add a cell for the PMIC's onboard General Purpose ADC. > > Applied, thanks! [3/3] mfd: 88pm886: Add GPADC cell commit: 5a30f3de5b458f335b49523e72010078b2c22923 -- Lee Jones [李琼斯]

Re: [PATCH] selftests: breakpoints: use suspend_stats to reliably check suspend success

2025-08-01 Thread Moon Hee Lee
Hi Olivier, On Fri, Aug 1, 2025 at 5:39 AM Olivier Blin wrote: > Shouldn't you also remove the timerfd variable? > It seems to be of no functional use after this change. The timerfd is still required because it provides the wake-up event for this test. Just before suspend the code programs a CLO

[PATCH] selftests: breakpoints: use suspend_stats to reliably check suspend success

2025-06-26 Thread Moon Hee Lee
@oracle.com/ Fixes: c66be905cda2 ("selftests: breakpoints: use remaining time to check if suspend succeed") Signed-off-by: Moon Hee Lee --- .../breakpoints/step_after_suspend_test.c | 41 ++- 1 file changed, 31 insertions(+), 10 deletions(-) diff --git a/too

[PATCH] selftests/mm: remove duplicate .gitignore entries

2025-06-25 Thread Moon Hee Lee
/20240924185911.117937-1-lorenzo.stoa...@oracle.com/ [2] https://lore.kernel.org/all/20241125064036.413536-1-lizhij...@fujitsu.com/ Signed-off-by: Moon Hee Lee --- tools/testing/selftests/mm/.gitignore | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/testing/selftests/mm/.gitignore b/tools/testing

[PATCH] selftests/kexec: fix test_kexec_jump build and ignore generated binary

2025-06-24 Thread Moon Hee Lee
built regardless of invocation context and properly removed by make clean. Also add the binary to .gitignore to avoid tracking it in version control. Signed-off-by: Moon Hee Lee --- tools/testing/selftests/kexec/.gitignore | 2 ++ tools/testing/selftests/kexec/Makefile | 2 +- 2 files changed

[PATCH] selftests: ptrace: add set_syscall_info to .gitignore

2025-06-23 Thread Moon Hee Lee
Add the set_syscall_info test binary to .gitignore to avoid tracking build artifacts in the ptrace selftests directory. Signed-off-by: Moon Hee Lee --- tools/testing/selftests/ptrace/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/ptrace/.gitignore b

[PATCH v2] selftests: pid_namespace: Fix missing mount headers in pid_max.c

2025-05-06 Thread Moon Hee Lee
linux_mainline/tools/testing/selftests/pid_namespace/pid_max] Error 1 Signed-off-by: Moon Hee Lee --- tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftests/pid_namespace/pid_max.c b/tools/testing/selftests/pid_names

[PATCH] selftests: pid_namespace: Fix missing mount headers in pid_max.c

2025-05-06 Thread Moon Hee Lee
Fix compilation error in pid_max.c by including to define mount(), umount2(), MS_PRIVATE, MS_REC, and MNT_DETACH. The test now builds successfully. Signed-off-by: Moon Hee Lee --- tools/testing/selftests/pid_namespace/pid_max.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing

Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-05-01 Thread Lee Jones
; 132 | MODULE_DEVICE_TABLE(spi, stmpe_id); > > | ^ > > 1 error generated. > > > Reviewed-by: Krzysztof Kozlowski > > P.S. You can trim the error messages to relevant parts, e.g. "1 error > generated" is really redundant and not needed to store in git history. Trimmed on apply, thanks. -- Lee Jones [李琼斯]

Re: (subset) [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-05-01 Thread Lee Jones
^ > 1 error generated. > > [...] Applied, thanks! [1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE commit: 7e5d7dcd96e29bb30fe7b105c53ae63a8edcd3e1 -- Lee Jones [李琼斯]

Re: (subset) [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-11-12 Thread Lee Jones
On Sat, 12 Oct 2024 21:31:38 +0200, Karel Balej wrote: > Add a MFD cell for the chip's real-time clock. > > Applied, thanks! [1/2] mfd: 88pm886: add the RTC cell commit: 156d87b679a565a166da4a7ce892cb87f6317faf -- Lee Jones [李琼斯]

Re: [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-10-15 Thread Lee Jones
es), > MFD_CELL_NAME("88pm886-regulator"), > + MFD_CELL_NAME("88pm886-rtc"), > }; > > static int pm886_power_off_handler(struct sys_off_data *sys_off_data) > -- > 2.47.0 > -- Lee Jones [李琼斯]

Re: [RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-10-15 Thread Lee Jones
gt; MAINTAINERS | 1 + > drivers/rtc/Kconfig | 10 > drivers/rtc/Makefile| 1 + > drivers/rtc/rtc-88pm886.c | 97 +++++++++ > include/linux/mfd/88pm886.h | 9 Acked-by: Lee Jones > 5 files changed, 118 inser

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-11 Thread Lee Jones
On Thu, 10 Oct 2024, Karel Balej wrote: > Lee Jones, 2024-10-10T09:35:19+01:00: > > On Thu, 10 Oct 2024, Lee Jones wrote: > > > > > On Wed, 09 Oct 2024, Karel Balej wrote: > > > > > > > Lee Jones, 2024-10-09T11:06:43+01:00: > > > >

[PATCH,bpf-next v3 4/4] samples/bpf: remove obsolete tracing related tests

2024-10-10 Thread Daniel T. Lee
g redundant tests. [1]: https://patchwork.kernel.org/cover/13759916 Signed-off-by: Daniel T. Lee --- Changes in V3: - Makefile fix samples/bpf/Makefile | 11 -- samples/bpf/test_overhead_kprobe.bpf.c | 41 - samples/bpf/test_overhead_raw_tp.bpf.c | 17 -- samples/bpf/test

[PATCH,bpf-next v3 3/4] samples/bpf: remove obsolete cgroup related tests

2024-10-10 Thread Daniel T. Lee
this test redundant. By removing these outdated tests, this patch helps streamline and modernize the test suite, avoiding duplication of test coverage. Signed-off-by: Daniel T. Lee --- Changes in v3: - Makefile fix samples/bpf/Makefile | 9 - samples/bpf

[PATCH,bpf-next v3 2/4] selftests/bpf: migrate cgroup sock create test for prohibiting sockets

2024-10-10 Thread Daniel T. Lee
under selftests. This migration ensures that the socket creation blocking behavior with cgroup bpf program is properly tested within the selftest framework. Signed-off-by: Daniel T. Lee --- Chagnes in V2: - commit message change Changes in v3: - Makefile fix samples/bpf/Makefile

[PATCH,bpf-next v3 1/4] selftests/bpf: migrate cgroup sock create test for setting iface/mark/prio

2024-10-10 Thread Daniel T. Lee
socket creation is properly tested. Signed-off-by: Daniel T. Lee --- samples/bpf/Makefile | 2 - samples/bpf/test_cgrp2_sock.c | 296 -- samples/bpf/test_cgrp2_sock.sh| 137 .../selftests/bpf/prog_tests/sock_creat

[PATCH,bpf-next v3 0/4] selftests/bpf: migrate and remove cgroup/tracing related tests

2024-10-10 Thread Daniel T. Lee
s based on cgroup. This behavior is now validated by cgroup_skb_sk_lookup, which uses bpf_skb_cgroup_id, making this test redundant. [1]: https://patchwork.kernel.org/cover/13759916 --- Changes in v2: - commit message fix Changes in v3: - Makefile fix Daniel T. Lee (4): selftests/bpf: migrate cg

[PATCH,bpf-next v2 4/4] samples/bpf: remove obsolete tracing related tests

2024-10-10 Thread Daniel T. Lee
g redundant tests. [1]: https://patchwork.kernel.org/cover/13759916 Signed-off-by: Daniel T. Lee --- samples/bpf/Makefile | 11 -- samples/bpf/test_overhead_kprobe.bpf.c | 41 - samples/bpf/test_overhead_raw_tp.bpf.c | 17 -- samples/bpf/test_overhead_tp.bpf.c | 23 --- sa

[PATCH,bpf-next v2 3/4] samples/bpf: remove obsolete cgroup related tests

2024-10-10 Thread Daniel T. Lee
this test redundant. By removing these outdated tests, this patch helps streamline and modernize the test suite, avoiding duplication of test coverage. Signed-off-by: Daniel T. Lee --- samples/bpf/Makefile | 9 - samples/bpf/test_cgrp2_array_pin.c| 106

[PATCH,bpf-next v2 2/4] selftests/bpf: migrate cgroup sock create tests for prohibitig sockets

2024-10-10 Thread Daniel T. Lee
under selftests. This migration ensures that the socket creation blocking behavior with cgroup bpf program is properly tested within the selftest framework. Signed-off-by: Daniel T. Lee --- Chagnes in V2: - commit message fix --- samples/bpf/Makefile | 2 - samples/bpf

[PATCH,bpf-next v2 1/4] selftests/bpf: migrate cgroup sock create test for setting iface/mark/prio

2024-10-10 Thread Daniel T. Lee
socket creation is properly tested. Signed-off-by: Daniel T. Lee --- samples/bpf/Makefile | 2 - samples/bpf/test_cgrp2_sock.c | 296 -- samples/bpf/test_cgrp2_sock.sh| 137 .../selftests/bpf/prog_tests/sock_creat

[PATCH,bpf-next v2 0/4] selftests/bpf: migrate and remove cgroup/tracing related tests

2024-10-10 Thread Daniel T. Lee
s based on cgroup. This behavior is now validated by cgroup_skb_sk_lookup, which uses bpf_skb_cgroup_id, making this test redundant. [1]: https://patchwork.kernel.org/cover/13759916 Daniel T. Lee (4): selftests/bpf: migrate cgroup sock create test for setting iface/mark/prio selftests

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Lee Jones
On Wed, 09 Oct 2024, Lee Jones wrote: > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > RTC lives on the base register page of the chip. Add definitions of the > > registers needed for a basic set/read time functionality. > > > > > > Applied, thanks!

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Lee Jones
On Thu, 10 Oct 2024, Lee Jones wrote: > On Wed, 09 Oct 2024, Karel Balej wrote: > > > Lee Jones, 2024-10-09T11:06:43+01:00: > > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > > RTC lives on the base register page of the chip. Add definitions of t

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Lee Jones
On Wed, 09 Oct 2024, Karel Balej wrote: > Lee Jones, 2024-10-09T11:06:43+01:00: > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > RTC lives on the base register page of the chip. Add definitions of the > > > registers needed for a basic

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-09 Thread Lee Jones
commit: 0a936c2c45884b9a3800379f3cab4d0a685d63f5 -- Lee Jones [李琼斯]

Re: [PATCH v7 0/5] initial support for Marvell 88PM886 PMIC

2024-06-28 Thread Lee Jones
On Fri, 28 Jun 2024, Lee Jones wrote: > On Fri, 31 May 2024 19:34:55 +0200, Karel Balej wrote: > > the following implements basic support for Marvell's 88PM886 PMIC which > > is found for instance as a component of the samsung,coreprimevelte > > smartphone which inspired

Re: [PATCH v7 0/5] initial support for Marvell 88PM886 PMIC

2024-06-28 Thread Lee Jones
144396e9570efea02d467df0a68fd28db6f [4/5] input: add onkey driver for Marvell 88PM886 PMIC commit: 914089db309ccc590314b6c21df5a1f812e9ab0b [5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC commit: f53d3efa366b1754f0389944401bb53397d22468 -- Lee Jones [李琼斯]

Re: [PATCH v7 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-06-13 Thread Lee Jones
> drivers/regulator/Makefile| 1 + > 3 files changed, 399 insertions(+) > create mode 100644 drivers/regulator/88pm886-regulator.c I'm fine with this set - just waiting for Mark to review. -- Lee Jones [李琼斯]

Re: [PATCH v6 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-05-31 Thread Lee Jones
gt; drivers/mfd/Makefile| 1 + > include/linux/mfd/88pm886.h | 69 + > 4 files changed, 230 insertions(+) > create mode 100644 drivers/mfd/88pm886.c > create mode 100644 include/linux/mfd/88pm886.h I don't see any more issues. Are you planning on seeing to Mark's review comments? -- Lee Jones [李琼斯]

Re: (subset) [PATCH v2] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types

2024-05-02 Thread Lee Jones
On Fri, 12 Apr 2024 16:22:53 +0200, Luca Weiss wrote: > Add the PBS (Programmable Boot Sequencer) to the list of devices. > > Applied, thanks! [1/1] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types commit: a1f3b5edaf18b1c71a537032c4a6537bde2ad5e9 -- Lee Jones [李琼斯]

Re: [PATCH 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-04-11 Thread Lee Jones
On Thu, 11 Apr 2024, Karel Balej wrote: > Lee Jones, 2024-04-11T12:37:26+01:00: > [...] > > > diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c > > > new file mode 100644 > > > index ..e06d418a5da9 > > > --- /dev/null > > &g

Re: [PATCH 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-04-11 Thread Lee Jones
0.o 88pm80x.o > obj-$(CONFIG_MFD_88PM805)+= 88pm805.o 88pm80x.o > +obj-$(CONFIG_MFD_88PM886_PMIC) += 88pm886.o > obj-$(CONFIG_MFD_ACT8945A) += act8945a.o > obj-$(CONFIG_MFD_SM501) += sm501.o > obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o > diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h > new file mode 100644 > index ..5ce30a3b85aa > --- /dev/null > +++ b/include/linux/mfd/88pm886.h > @@ -0,0 +1,30 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __MFD_88PM886_H > +#define __MFD_88PM886_H > + > +#include > +#include > + > +#define PM886_A1_CHIP_ID 0xa1 > + > +#define PM886_REG_ID 0x00 > + > +#define PM886_REG_STATUS10x01 > +#define PM886_ONKEY_STS1 BIT(0) > + > +#define PM886_REG_MISC_CONFIG1 0x14 > +#define PM886_SW_PDOWN BIT(5) > + > +#define PM886_REG_MISC_CONFIG2 0x15 > +#define PM886_INT_INVBIT(0) > +#define PM886_INT_CLEAR BIT(1) > +#define PM886_INT_RC 0x00 > +#define PM886_INT_WC BIT(1) > +#define PM886_INT_MASK_MODE BIT(2) > + > +struct pm886_chip { > + struct i2c_client *client; > + unsigned int chip_id; > + struct regmap *regmap; > +}; > +#endif /* __MFD_88PM886_H */ > -- > 2.44.0 > -- Lee Jones [李琼斯]

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Lee Jones
On Thu, 21 Mar 2024, Karel Balej wrote: > Lee Jones, 2024-03-21T15:42:11+00:00: > > On Mon, 11 Mar 2024, Karel Balej wrote: > > > > > From: Karel Balej > > > > > > Marvell 88PM886 is a PMIC which provides various functions such as > > > onke

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Lee Jones
truct i2c_client *client; > + unsigned int chip_id; > + struct regmap *regmap; > +}; > + > +static const struct regmap_config pm886_i2c_regmap = { > + .reg_bits = 8, > + .val_bits = 8, > + .max_register = PM886_REGMAP_CONF_MAX_REG, > +}; Why is this in here? > +#endif /* __MFD_88PM886_H */ What would you like me to do with this RFC patch? -- Lee Jones [李琼斯]

Re: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-07 Thread Lee Jones
(IS_ERR(regmap)) { > > > + err = PTR_ERR(regmap); > > > + dev_err(dev, "Failed to initialize regulators regmap: %d\n", > > > err); > > > + return err; > > > + } > > > + chip->regmaps[PM886_REGMAP_REGULATORS] = regmap; > > > > Except for the regulator driver, where else is the regulators regmap used? > > Nowhere, at least as of now. So you are saying that I should initialize > the regmap in the regulator driver? I am. -- Lee Jones [李琼斯]

Re: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-05 Thread Lee Jones
_BCM2835) += bcm2835-pm.o > diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h > new file mode 100644 > index ..c7527bab0fba > --- /dev/null > +++ b/include/linux/mfd/88pm886.h > @@ -0,0 +1,46 @@ > +/* SPDX-License-Identifier: GPL-2.0-only */ > +#ifndef __MFD_88PM886_H > +#define __MFD_88PM886_H > + > +#include What's this for? > +#define PM886_A1_CHIP_ID 0xa1 > + > +#define PM886_REG_ID 0x00 > + > +#define PM886_REG_STATUS10x01 > +#define PM886_ONKEY_STS1 BIT(0) > + > +#define PM886_REG_MISC_CONFIG1 0x14 > +#define PM886_SW_PDOWN BIT(5) > + > +#define PM886_REG_MISC_CONFIG2 0x15 > +#define PM886_INT_INVBIT(0) > +#define PM886_INT_CLEAR BIT(1) > +#define PM886_INT_RC 0x00 > +#define PM886_INT_WC BIT(1) > +#define PM886_INT_MASK_MODE BIT(2) > + > +#define PM886_PAGE_OFFSET_REGULATORS 1 > + > +enum pm886_regulator_id { > + PM886_REGULATOR_ID_LDO2, > + PM886_REGULATOR_ID_LDO15, > + PM886_REGULATOR_ID_BUCK2, > + > + PM886_REGULATOR_ID_SENTINEL > +}; > + > +enum pm886_regmap_index { > + PM886_REGMAP_BASE, > + PM886_REGMAP_REGULATORS, > + > + PM886_REGMAP_NR > +}; > + > +struct pm886_chip { > + struct i2c_client *client; > + unsigned int whoami; chip_id > + struct regmap *regmaps[PM886_REGMAP_NR]; > +}; > +#endif /* __MFD_88PM886_H */ > -- > 2.44.0 > -- Lee Jones [李琼斯]

Re: (subset) [PATCH v5] leds: qcom-lpg: Add PM660L configuration and compatible

2024-02-08 Thread Lee Jones
nging to the synchronized triled block and one loose PWM channel. > > Applied, thanks! [1/1] leds: qcom-lpg: Add PM660L configuration and compatible commit: 0e848bb4630e12099636fde050cadad33221045f -- Lee Jones [李琼斯]

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-02-02 Thread Lee Jones
Linus, On Fri, 02 Feb 2024, Karel Balej wrote: > Lee Jones, 2024-02-02T12:45:50+00:00: > > On Thu, 01 Feb 2024, Karel Balej wrote: > > > > > Lee Jones, 2024-01-31T11:03:11+00:00: > > > > On Sun, 28 Jan 2024, Karel Balej wrote: > &g

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-02-02 Thread Lee Jones
On Thu, 01 Feb 2024, Karel Balej wrote: > Lee Jones, 2024-01-31T11:03:11+00:00: > > On Sun, 28 Jan 2024, Karel Balej wrote: > > > > > + /* GPIO1: DVC, GPIO0: input */ > > > > > + REG_SEQ0(PM88X_REG_GPIO_CTRL1, 0x40), > > > &

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-01-31 Thread Lee Jones
the parts which there is > already use for. I intend to add the other parts along with the > respective subdevice drivers, please see my regulator series [1] for an > example. > > I thought this approach would make for shorter and simpler patches and > also would allow me to make more informed decisions as I familiarize > myself with the downstream subdevice drivers more closely one by one. One device doesn't warrant an MFD. Please add more devices. -- Lee Jones [李琼斯]

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-01-25 Thread Lee Jones
PM88X_INT_INVBIT(0) > +#define PM88X_INT_CLEAR BIT(1) > +#define PM88X_INT_RC 0x00 > +#define PM88X_INT_WC BIT(1) > +#define PM88X_INT_MASK_MODE BIT(2) > + > +#define PM88X_REG_WDOG 0x1d > + > +#define PM88X_REG_LOWPOWER2 0x21 > +#define PM88X_REG_LOWPOWER4 0x23 > + > +#define PM88X_REG_GPIO_CTRL1 0x30 These don't really need to be spaced out, do they? > +#define PM88X_REG_GPIO_CTRL2 0x31 > + > +#define PM88X_REG_GPIO_CTRL3 0x32 > + > +#define PM88X_REG_GPIO_CTRL4 0x33 > + > +#define PM88X_REG_BK_OSC_CTRL1 0x50 > +#define PM88X_REG_BK_OSC_CTRL3 0x52 > + > +#define PM88X_REG_AON_CTRL2 0xe2 > + > +enum pm88x_regmap_index { > + PM88X_REGMAP_BASE, > + > + PM88X_REGMAP_NR > +}; > + > +struct pm88x_data { > + unsigned int whoami; > + struct reg_sequence *presets; > + unsigned int num_presets; > +}; > + > +struct pm88x_chip { > + struct i2c_client *client; > + struct regmap_irq_chip_data *irq_data; Group this with the other regmap related member(s). What are you using this for? > + const struct pm88x_data *data; Remove this. > + struct regmap *regmaps[PM88X_REGMAP_NR]; > +}; > +#endif /* __LINUX_MFD_88PM88X_H */ > -- > 2.43.0 > -- 9) 4) Lee Jones [李琼斯]

Re: [RFC PATCH 1/5] mfd: 88pm88x: differences with respect to the PMIC RFC series

2024-01-11 Thread Lee Jones
On Thu, 11 Jan 2024, Karel Balej wrote: > On Thu Jan 11, 2024 at 4:25 PM CET, Lee Jones wrote: > > [...] > > > > > > diff --git a/include/linux/mfd/88pm88x.h b/include/linux/mfd/88pm88x.h > > > > > index a34c57447827..9a335f6b9c07 100644 &

Re: [RFC PATCH 1/5] mfd: 88pm88x: differences with respect to the PMIC RFC series

2024-01-11 Thread Lee Jones
On Thu, 11 Jan 2024, Karel Balej wrote: > Lee, > > On Thu Jan 11, 2024 at 11:54 AM CET, Lee Jones wrote: > > The subject needs work. Please tell us what the patches is doing. > > > > On Thu, 28 Dec 2023, Karel Balej wrote: > > > > > From: Karel Balej

Re: [RFC PATCH 1/5] mfd: 88pm88x: differences with respect to the PMIC RFC series

2024-01-11 Thread Lee Jones
inux/mfd/88pm88x.h > index a34c57447827..9a335f6b9c07 100644 > --- a/include/linux/mfd/88pm88x.h > +++ b/include/linux/mfd/88pm88x.h > @@ -49,6 +49,8 @@ struct pm88x_data { > unsigned int whoami; > struct reg_sequence *presets; > unsigned int num_presets; > + struct mfd_cell *devs; > + unsigned int num_devs; Why are you adding extra abstraction? > }; > > struct pm88x_chip { > -- > 2.43.0 > -- Lee Jones [李琼斯]

BUG: unable to handle kernel paging request in bpf_probe_read_compat_str

2023-12-13 Thread xingwei lee
Hello I found a bug in net/bpf in the lastest upstream linux and comfired in the lastest net tree and lastest net bpf titled BUG: unable to handle kernel paging request in bpf_probe_read_compat_str If you fix this issue, please add the following tag to the commit: Reported-by: xingwei Lee

WARNING: kmalloc bug in bpf_uprobe_multi_link_attach

2023-12-11 Thread xingwei lee
Sorry for containing HTML part, repeat the mail Hello I found a bug in net/bpf in the lastest upstream linux and lastest net tree. WARNING: kmalloc bug in bpf_uprobe_multi_link_attach kernel: net 28a7cb045ab700de5554193a1642917602787784 Kernel config: https://github.com/google/syzkaller/commits/f

Re: [syzbot] [bpf?] [trace?] possible deadlock in dev_watchdog

2023-12-04 Thread xingwei lee
hello I reproduced this bug with repro.c and repro.txt =* repro.txt =* r0 = syz_clone(0x0, 0x0, 0x0, 0x0, 0x0, 0x0) ptrace(0x10, r0) r1 = bpf$BPF_PROG_RAW_TRACEPOINT_LOAD(0x5, &(0x7f000200)={0x18, 0x4, &(0x7f0002c0)=ANY=[@ANYBLOB="18011c0012f185006d0095"], &(0x

Re: [PATCH v6 0/2] leds: Add a driver for KTD202x

2023-10-12 Thread Lee Jones
26d9b40 [2/2] leds: add ktd202x driver commit: 4239b17b5de0dcd5900727be5597ba061acd00b8 -- Lee Jones [李琼斯]

Re: (subset) [PATCH v2 1/2] dt-bindings: mfd: qcom,spmi-pmic: Drop unused labels from examples

2023-10-05 Thread Lee Jones
mic: Drop unused labels from examples commit: cac94656ff2b16827d7cd455f0d3746280cf3138 -- Lee Jones [李琼斯]

Re: [PATCH v4 2/2] leds: add ktd202x driver

2023-09-28 Thread Lee Jones
mutex_init() as late as possible and omitting as many of these gotos as you can. > + } > + > + chip->regulators[0].supply = "vin"; > + chip->regulators[1].supply = "vio"; > + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(chip->regulators), > + chip->regulators); > + if (ret < 0) { > + dev_err_probe(dev, ret, "Failed to request regulators.\n"); > + goto error; > + } > + > + ret = regulator_bulk_enable(ARRAY_SIZE(chip->regulators), > + chip->regulators); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to enable regulators.\n"); > + goto error; > + } > + > + ret = ktd202x_probe_dt(chip); > + if (ret < 0) > + goto error_reg; > + > + ret = regulator_bulk_disable(ARRAY_SIZE(chip->regulators), > + chip->regulators); > + if (ret) { > + dev_err_probe(dev, ret, "Failed to disable regulators.\n"); > + goto error; > + } > + > + return 0; > + > +error_reg: > + regulator_bulk_disable(ARRAY_SIZE(chip->regulators), > +chip->regulators); > + > +error: > + mutex_destroy(&chip->mutex); > + return ret; > +} > + > +static void ktd202x_remove(struct i2c_client *client) > +{ > + struct ktd202x *chip = i2c_get_clientdata(client); > + > + ktd202x_chip_disable(chip); > + > + mutex_destroy(&chip->mutex); > +} > + > +static void ktd202x_shutdown(struct i2c_client *client) > +{ > + struct ktd202x *chip = i2c_get_clientdata(client); > + > + /* Reset registers to make sure all off before shutdown */ Grammar. > + regmap_write(chip->regmap, KTD202X_REG_RESET_CONTROL, > + KTD202X_RSTR_RESET); > +} > + > +static const struct of_device_id ktd202x_match_table[] = { > + { .compatible = "kinetic,ktd2026", .data = (void *)KTD2026_NUM_LEDS }, > + { .compatible = "kinetic,ktd2027", .data = (void *)KTD2027_NUM_LEDS }, > + {}, > +}; > + Remove these line. > +MODULE_DEVICE_TABLE(of, ktd202x_match_table); > + > +static struct i2c_driver ktd202x_driver = { > + .driver = { > + .name = "leds-ktd202x", > + .of_match_table = ktd202x_match_table, > + }, > + .probe = ktd202x_probe, > + .remove = ktd202x_remove, > + .shutdown = ktd202x_shutdown, > +}; > +module_i2c_driver(ktd202x_driver); > + > +MODULE_AUTHOR("André Apitzsch "); > +MODULE_DESCRIPTION("Kinetic KTD2026/7 LED driver"); > +MODULE_LICENSE("GPL"); > > -- > 2.42.0 > -- 8) 3) Lee Jones [李琼斯]

Re: [PATCH v7 1/3] bio: limit bio max size

2021-04-19 Thread Changheun Lee
> On 4/18/21 10:49 PM, Changheun Lee wrote: > >>> @@ -167,6 +168,7 @@ void blk_queue_max_hw_sectors(struct request_queue > >>> *q, unsigned int max_hw_secto > >>> max_sectors = round_down(max_sectors, > >>>limits-&

[PATCH v2] qtnfmac: Fix possible buffer overflow in qtnf_event_handle_external_auth

2021-04-19 Thread Lee Gibson
Function qtnf_event_handle_external_auth calls memcpy without checking the length. A user could control that length and trigger a buffer overflow. Fix by checking the length is within the maximum allowed size. Signed-off-by: Lee Gibson --- v2: use clamp_val() instead of min_t() drivers/net

Re: [PATCH 22/40] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header

2021-04-19 Thread Lee Jones
On Fri, 16 Apr 2021, Christian König wrote: > > > Am 16.04.21 um 16:37 schrieb Lee Jones: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member > > 'num_pages' not descr

Re: [PATCH 00/31] Rid W=1 warnings from GFS2 and EncryptFS

2021-04-19 Thread Lee Jones
On Mon, 19 Apr 2021, Tyler Hicks wrote: > On 2021-03-30 17:44:27, Lee Jones wrote: > > This set is part of a larger effort attempting to clean-up W=1 > > kernel builds, which are currently overwhelmingly riddled with > > niggly little warnings. > > > > T

Re: [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831

2021-04-19 Thread Lee Jones
On Mon, 19 Apr 2021, Lee Jones wrote: > On Mon, 19 Apr 2021, Lee Jones wrote: > > > On Mon, 19 Apr 2021, ChiYuan Huang wrote: > > > > > Hi, Linux mfd reviewers: > > >It's been three weeks not to get any response from you. > > > Is there

Re: [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831

2021-04-19 Thread Lee Jones
On Mon, 19 Apr 2021, Lee Jones wrote: > On Mon, 19 Apr 2021, ChiYuan Huang wrote: > > > Hi, Linux mfd reviewers: > >It's been three weeks not to get any response from you. > > Is there something wrong about this mfd patch? > > If yes, please feel free to

Re: [PATCH v6 1/4] mfd: rt4831: Adds support for Richtek RT4831

2021-04-19 Thread Lee Jones
Refine Kconfig descriptions. > > - Add copyright. > > - Refine error logs in probe. > > - Refine comment lines in remove and shutdown. > > --- > > drivers/mfd/Kconfig | 10 + > > drivers/mfd/Makefile | 1 + > > drivers/mfd/rt4831.c | 115 > > +++ > > 3 files changed, 126 insertions(+) > > create mode 100644 drivers/mfd/rt4831.c -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog

Re: [PATCH v7 1/3] bio: limit bio max size

2021-04-18 Thread Changheun Lee
c92a6e8..e5add63da3af 100644 > > --- a/include/linux/bio.h > > +++ b/include/linux/bio.h > > @@ -106,6 +106,8 @@ static inline void *bio_data(struct bio *bio) > > return NULL; > > } > > > > +extern unsigned int bio_max_size(struct bio *bio); > > You may want to define bio_max_size() as an inline function in bio.h > such that no additional function calls are introduced in the hot path. I tried, but it is not easy. because request_queue structure of blkdev.h should be referred in bio.h. I think it's not good to apply as a inline function. Thanks, Changheun Lee.

Re: [PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header

2021-04-16 Thread Lee Jones
On Fri, 16 Apr 2021, Krzysztof Kozlowski wrote: > On 16/04/2021 16:37, Lee Jones wrote: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype > > for shadow_prote

[PATCH 40/40] drm/mediatek/mtk_disp_ccorr: Demote less than half-populated struct header

2021-04-16 Thread Lee Jones
ot described in 'mtk_disp_ccorr' Cc: Chun-Kuang Hu Cc: Philipp Zabel Cc: David Airlie Cc: Daniel Vetter Cc: Matthias Brugger Cc: dri-de...@lists.freedesktop.org Cc: linux-media...@lists.infradead.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/

[PATCH 38/40] drm/exynos/exynos_drm_ipp: Fix some function name disparity issues

2021-04-16 Thread Lee Jones
: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c b/drivers/gpu/drm/exynos/exynos_drm_ipp.c

[PATCH 39/40] drm/sti/sti_hdmi: Provide kernel-doc headers with function names

2021-04-16 Thread Lee Jones
: Benjamin Gaignard Cc: David Airlie Cc: Daniel Vetter Cc: Philipp Zabel Cc: Vincent Abriou Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/sti/sti_hdmi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/sti

[PATCH 36/40] drm/exynos/exynos7_drm_decon: Realign function name with its header

2021-04-16 Thread Lee Jones
Cc: Daniel Vetter Cc: Krzysztof Kozlowski Cc: Akshu Agarwal Cc: Ajay Kumar Cc: dri-de...@lists.freedesktop.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +- 1 file changed, 1

[PATCH 37/40] drm/panel/panel-sitronix-st7701: Demote kernel-doc format abuse

2021-04-16 Thread Lee Jones
avid Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/panel/panel-sitronix-st7701.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7701.c b/drivers/gpu/drm/panel/panel-sitronix

[PATCH 35/40] drm/amd/amdgpu/amdgpu_cs: Repair some function naming disparity

2021-04-16 Thread Lee Jones
Vetter Cc: Sumit Semwal Cc: Jerome Glisse Cc: amd-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++--- 1 file changed, 3 insertions(+), 3

[PATCH 34/40] drm/exynos/exynos_drm_fimd: Realign function name with its header

2021-04-16 Thread Lee Jones
: Daniel Vetter Cc: Krzysztof Kozlowski Cc: dri-de...@lists.freedesktop.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-samsung-...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH 31/40] drm/amd/amdgpu/amdgpu_gart: Correct a couple of function names in the docs

2021-04-16 Thread Lee Jones
amdgpu_dummy_page_fini(). Prototype was for amdgpu_gart_dummy_page_fini() instead Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Nirmoy Das Cc: amd-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/

[PATCH 33/40] drm/amd/amdgpu/amdgpu_ring: Provide description for 'sched_score'

2021-04-16 Thread Lee Jones
ter Cc: Sumit Semwal Cc: amd-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/amd/a

[PATCH 32/40] drm/amd/amdgpu/amdgpu_ttm: Fix incorrectly documented function 'amdgpu_ttm_copy_mem_to_mem()'

2021-04-16 Thread Lee Jones
Vetter Cc: Sumit Semwal Cc: Jerome Glisse Cc: amd-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH 29/40] drm/amd/amdgpu/amdgpu_fence: Provide description for 'sched_score'

2021-04-16 Thread Lee Jones
aniel Vetter Cc: Sumit Semwal Cc: Jerome Glisse Cc: amd-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH 30/40] drm/vgem/vgem_drv: Demote kernel-doc abuse

2021-04-16 Thread Lee Jones
ian König" Cc: Adam Jackson Cc: Ben Widawsky Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/vgem/vgem_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[PATCH 27/40] drm/ttm/ttm_device: Demote kernel-doc abuses

2021-04-16 Thread Lee Jones
m_global_swapout' drivers/gpu/drm/ttm/ttm_device.c:112: warning: expecting prototype for A buffer object shrink method that tries to swap out the first(). Prototype was for ttm_global_swapout() instead Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@

[PATCH 25/40] drm/radeon/radeon_device: Provide function name in kernel-doc header

2021-04-16 Thread Lee Jones
ie Cc: Daniel Vetter Cc: amd-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/radeon/radeon_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/rad

[PATCH 26/40] drm/amd/amdgpu/amdgpu_device: Remove unused variable 'r'

2021-04-16 Thread Lee Jones
" Cc: David Airlie Cc: Daniel Vetter Cc: Sumit Semwal Cc: amd-...@lists.freedesktop.org Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++--- 1 file

[PATCH 28/40] drm/panel/panel-raspberrypi-touchscreen: Demote kernel-doc abuse

2021-04-16 Thread Lee Jones
lie Cc: Daniel Vetter Cc: Eric Anholt Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c b/drivers/gpu/

[PATCH 24/40] drm/scheduler/sched_entity: Fix some function name disparity

2021-04-16 Thread Lee Jones
: "Christian König" Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/scheduler/sched_entity.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm

[PATCH 22/40] drm/ttm/ttm_tt: Demote non-conformant kernel-doc header

2021-04-16 Thread Lee Jones
described in 'ttm_tt_mgr_init' Cc: Christian Koenig Cc: Huang Rui Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/ttm/ttm_tt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm

[PATCH 23/40] drm/ttm/ttm_bo: Fix incorrectly documented function 'ttm_bo_cleanup_refs'

2021-04-16 Thread Lee Jones
: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/ttm/ttm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c index

[PATCH 21/40] drm/xlnx/zynqmp_dp: Fix a little potential doc-rot

2021-04-16 Thread Lee Jones
Zabel Cc: dri-de...@lists.freedesktop.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c index

[PATCH 20/40] drm/xlnx/zynqmp_disp: Fix incorrectly documented enum 'zynqmp_disp_id'

2021-04-16 Thread Lee Jones
-de...@lists.freedesktop.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Lee Jones --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c index 109d627968ac0

[PATCH 19/40] drm/omapdrm/omap_gem: Properly document omap_gem_dumb_map_offset()

2021-04-16 Thread Lee Jones
König" Cc: Rob Clark Cc: dri-de...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/omapdrm/omap_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c

[PATCH 18/40] drm/omapdrm/omap_irq: Fix a couple of incorrectly documented functions

2021-04-16 Thread Lee Jones
was for omap_irq_disable_vblank() instead Cc: Tomi Valkeinen Cc: David Airlie Cc: Daniel Vetter Cc: Rob Clark Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

[PATCH 16/40] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block

2021-04-16 Thread Lee Jones
x27;cmd' not described in 'nouveau_compat_ioctl' drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or member 'arg' not described in 'nouveau_compat_ioctl' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.or

[PATCH 17/40] gpu: host1x: bus: Remove superfluous param description 'key'

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/host1x/bus.c:774: warning: Excess function parameter 'key' description in '__host1x_client_register' Cc: Thierry Reding Cc: dri-de...@lists.freedesktop.org Cc: linux-te...@vger.kernel.org Signed-off-by: Lee Jon

[PATCH 15/40] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function

2021-04-16 Thread Lee Jones
: dri-de...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nouveau_svm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c index

[PATCH 13/40] drm/nouveau/dispnv50/disp: Include header containing our prototypes

2021-04-16 Thread Lee Jones
...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c index 351f954989530..4905ed584ff48 100644 --- a/drivers/gpu/drm/nouveau/dispnv50

[PATCH 12/40] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions

2021-04-16 Thread Lee Jones
...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nv50_display.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nv50_display.h b/drivers/gpu/drm/nouveau/nv50_display.h index fbd3b15583bc8..2421401d12636 100644 --- a/drivers/gpu/drm/nouveau

[PATCH 14/40] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc

2021-04-16 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * file mga_ioc32.c Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones

[PATCH 11/40] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static

2021-04-16 Thread Lee Jones
...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/dispnv50/headc57d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c index fd51527b56b83..bdcfd240d61c8 100644 --- a

[PATCH 07/40] drm/nouveau/nouveau_bo: Remove unused variables 'dev'

2021-04-16 Thread Lee Jones
g Cc: nouv...@lists.freedesktop.org Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nouveau_bo.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c b/drivers/gpu/drm/nouveau/nouveau_

[PATCH 10/40] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void

2021-04-16 Thread Lee Jones
Cc: dri-de...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c b/drivers/gpu/drm/nouveau/dispnv50/disp.c

[PATCH 09/40] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers

2021-04-16 Thread Lee Jones
27;old_fb' not described in 'nv_crtc_mode_set' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 08/40] drm/nouveau/nouveau_display: Remove set but unused variable 'width'

2021-04-16 Thread Lee Jones
: Daniel Vetter Cc: dri-de...@lists.freedesktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nouveau_display.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c b/drivers/gpu/drm/nouveau

[PATCH 04/40] include: drm: drm_atomic: Make use of 'new_plane_state'

2021-04-16 Thread Lee Jones
Daniel Vetter Cc: Rob Clark Cc: dri-de...@lists.freedesktop.org Signed-off-by: Lee Jones --- include/drm/drm_atomic.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index ac5a28eff2c86..259e6970dc836 100644 ---

[PATCH 06/40] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header

2021-04-16 Thread Lee Jones
desktop.org Cc: nouv...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c index 397ff4fe9df89..

[PATCH 03/40] drm/msm/dp/dp_display: Remove unused variable 'hpd'

2021-04-16 Thread Lee Jones
Cc: Daniel Vetter Cc: Kuogee Hsieh Cc: linux-arm-...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: freedr...@lists.freedesktop.org Signed-off-by: Lee Jones --- drivers/gpu/drm/msm/dp/dp_display.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/msm/dp/dp_display.c

[PATCH 05/40] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers

2021-04-16 Thread Lee Jones
7;gk20a_volt_get_cvb_t_voltage' drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c:69: warning: Function parameter or member 'coef' not described in 'gk20a_volt_get_cvb_t_voltage' Cc: Ben Skeggs Cc: David Airlie Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.or

  1   2   3   4   5   6   7   8   9   10   >