Re: [PATCH 2/2] usb: serial: option: add Cellient MPL200 card

2020-10-05 Thread Lars Melin
On 10/5/2020 18:06, Johan Hovold wrote: On Mon, Oct 05, 2020 at 01:01:34PM +0200, Wilken Gottwalt wrote: On Mon, 5 Oct 2020 10:20:45 +0200 Johan Hovold wrote: On Sat, Oct 03, 2020 at 11:40:29AM +0200, Wilken Gottwalt wrote: Add usb ids of the Cellient MPL200 card. Signed-off-by: Wilken Gott

Re: [PATCH] USB: serial: option: Add Telit FT980-KS composition

2020-10-04 Thread Lars Melin
On 10/4/2020 23:03, Leonid Bloch wrote: Lars, Thank you for your review! The changes which you have suggested also made ModemManager to recognize the device (which it didn't do before). Please check out the v2. Cheers, Leonid. The v2 looks good to me br Lars

Re: [PATCH] USB: serial: option: Add Telit FT980-KS composition

2020-10-04 Thread Lars Melin
On 10/4/2020 21:16, Lars Melin wrote: On 10/4/2020 20:29, Leonid Bloch wrote: On 10/4/20 1:58 PM, Lars Melin wrote: On 10/4/2020 16:57, Leonid Bloch wrote: This commit adds the following Telit FT980-KS composition: 0x1054: rndis, diag, adb, nmea, modem, modem, aux AT commands can be sent to

Re: [PATCH] USB: serial: option: Add Telit FT980-KS composition

2020-10-04 Thread Lars Melin
On 10/4/2020 20:29, Leonid Bloch wrote: On 10/4/20 1:58 PM, Lars Melin wrote: On 10/4/2020 16:57, Leonid Bloch wrote: This commit adds the following Telit FT980-KS composition: 0x1054: rndis, diag, adb, nmea, modem, modem, aux AT commands can be sent to /dev/ttyUSB5. Please submit a

Re: [PATCH] USB: serial: option: Add Telit FT980-KS composition

2020-10-04 Thread Lars Melin
On 10/4/2020 16:57, Leonid Bloch wrote: This commit adds the following Telit FT980-KS composition: 0x1054: rndis, diag, adb, nmea, modem, modem, aux AT commands can be sent to /dev/ttyUSB5. Please submit a verbose lsusb listing for the device, I can't imagine that the adb interface should b

Re: [PATCH v2] usb: serial: Repair FTDI FT232R bricked eeprom

2020-09-09 Thread Lars Melin
On 9/10/2020 10:02, Oliver Neukum wrote: Am Mittwoch, den 09.09.2020, 13:34 -0600 schrieb James Hilliard: This patch detects and reverses the effects of the malicious FTDI Windows driver version 2.12.00(FTDIgate). Hi, this raises questions. Should we do this unconditionally without asking? Do

Re: [PATCH AUTOSEL 4.14 17/33] net: usb: qmi_wwan: add Telit 0x1050 composition

2020-09-07 Thread Lars Melin
On 9/8/2020 01:15, Sasha Levin wrote: On Mon, Sep 07, 2020 at 11:36:37AM +0200, Kristian Evensen wrote: // snip When testing the FN980 with kernel 4.14, I noticed that the qmi device was not there. Checking the git log, I see that this patch was never applied. The patch applies fine, so I gues

Re: [PATCH] HID: quirks: Add USB_QUIRK_IGNORE_REMOTE_WAKEUP quirk for BYD zhaoxin notebook

2020-09-03 Thread Lars Melin
On 9/4/2020 08:48, Penghao wrote: --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -387,6 +387,10 @@ static const struct usb_device_id usb_quirk_list[] = { { USB_DEVICE(0x0b05, 0x17e0), .driver_info = USB_QUIRK_IGNORE_REMOTE_WAKEUP }, + /* SON

Re: [PATCH] ALSA: usb-audio: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for Lenovo A630Z TIO built-in usb audio card

2020-09-03 Thread Lars Melin
On 9/4/2020 08:45, Penghao wrote: --- a/drivers/usb/core/quirks.c +++ b/drivers/usb/core/quirks.c @@ -403,6 +403,10 @@ static const struct usb_device_id usb_quirk_list[] = { { USB_DEVICE(0x12d1, 0x15c3), .driver_info = USB_QUIRK_DISCONNECT_SUSPEND }, + /* Lenov

Re: [PATCH v2] usb: typec: mux: intel: Fix DP_HPD_LVL bit field

2020-05-11 Thread Lars Melin
On 5/11/2020 04:39, Prashant Malani wrote: According to the PMC Type C Subsystem (TCSS) Mux programming guide rev 0.6, the PMC HPD request LVL bit field is bit 4. Fix the definition here to match the programming guide. Since this bit field is changing, explicitly define a field for the HPD_HIGH

Re: [PATCH] USB: serial: option: Add Motorola modem UARTs

2019-07-23 Thread Lars Melin
On 7/23/2019 21:49, Tony Lindgren wrote: +#define MOTOROLA_VENDOR_ID 0x22b8 +#define MOTOROLA_PRODUCT_MDM6600 0x2a70 +#define MOTOROLA_PRODUCT_MDM9600 0x2e0a +#define MOTOROLA_PRODUCT_MDM_RAM_DL0x4281 +#define MOTOROLA_PRODUCT_MDM_QC_DL

Re: [PATCH v7 0/6] Introduced new Cadence USBSS DRD Driver.

2019-06-05 Thread Lars Melin
On 6/5/2019 17:03, Pawel Laszczak wrote: This patch introduces new Cadence USBSS DRD driver to Linux kernel. The Cadence USBSS DRD Driver is a highly configurable IP Core which can be instantiated as Dual-Role Device (DRD), Peripheral Only and Host Only (XHCI)configurations. The driver is not

Re: [PATCH] option: Improve Quectel EP06 detection

2018-09-11 Thread Lars Melin
On 9/10/2018 18:39, Kristian Evensen wrote: Hi, On Mon, Sep 10, 2018 at 12:30 PM Johan Hovold wrote: Please provide the output of usb-devices (or lsusb -v) for both "configurations". How do you update the configuration by the way? The configuration is updated using a proprietary AT-command (

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 23:12, Johan Hovold wrote: On Thu, Apr 26, 2018 at 06:40:46PM +0700, Lars Melin wrote: On 4/26/2018 18:39, Lars Melin wrote: On 4/26/2018 18:19, Bjørn Mork wrote: Anyway, Qualcomm based designs are definitely handled by both drivers. Using qcserial only makes sense if the

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 18:39, Lars Melin wrote: On 4/26/2018 18:19, Bjørn Mork wrote: Anyway, Qualcomm based designs are definitely handled by both drivers. Using qcserial only makes sense if the interface layout matches one of the defined shared schemes, which currently are: QCSERIAL_G2K = 0

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 18:19, Bjørn Mork wrote: Anyway, Qualcomm based designs are definitely handled by both drivers. Using qcserial only makes sense if the interface layout matches one of the defined shared schemes, which currently are: QCSERIAL_G2K = 0, /* Gobi 2000 */ QCSERIAL_G1

Re: [PATCH] USB: serial: option: adding support for ublox R410M

2018-04-26 Thread Lars Melin
On 4/26/2018 14:09, Johan Hovold wrote: On Thu, Apr 26, 2018 at 02:28:31PM +0800, SZ Lin (林上智) wrote: This patch adds support for ublox R410M PID 0x90b2 USB modem to option driver, this module supports LTE Cat M1 / NB1. Interface layout: 0: QCDM/DIAG 1: ADB 2: AT 3: RMNET Signed-off-by: SZ Lin

Re: [PATCH] net: qmi_wwan: add Dell DW5818, DW5819

2017-11-20 Thread Lars Melin
On 11/20/2017 16:27, Shrirang Bagul wrote: Dell Wireless 5819/5818 devices are re-branded Sierra Wireless MC74 series modems which will by default boot with vid 0x413c and pid's 0x81cf, 0x81d0, 0x81d1,0x81d2. Along with qcserial, these modems support qmi_wwan on the usb interface #12. Signed-off

Re: [PATCH] usb-musb: keep VBUS on when device is disconnected

2017-03-25 Thread Lars Melin
On 2017-03-25 01:58, Bin Liu wrote: On Wed, Mar 15, 2017 at 09:08:01AM -0500, Moreno Bartalucci wrote: With usb-musb port in host mode, when the device is disconnected, either logically (because of a mode switch) or physically (by pulling the cable), the USB port should keep suppling VBUS, with

Re: [PATCH net-next] cdc_ether: Improve ZTE MF823/831/910 handling

2016-07-19 Thread Lars Melin
On 2016-07-19 13:40, Kristian Evensen wrote: I guess I can match on the VID/PID in usbnet, but won't it be cleaner to add a new bind() function (in cdc_ether) which matches the two PIDs and leave usbnet as is? Or am I misunderstanding how to add this functionality to usbnet? Matching on the u

Re: [PATCH] HID: usbhid: Add a quirk for Xin-Mo Dual Arcade

2015-10-25 Thread Lars Melin
On 2015-10-24 22:44, Michele Baldessari wrote: The Xin-Mo Dual Arcade controller (16c0:05e1) needs this quirk in order to have the two distinct joysticks working. Before the change: $ jstest /dev/input/js0 Joystick (Xin-Mo Xin-Mo Dual Arcade) has 2 axes (X, Y) ... $ jstest /dev/input/js1 jstest:

Re: [PATCH] usb: core: hub: Removed some warnings generated by checkpatch.pl

2015-08-14 Thread Lars Melin
On 2015-08-15 11:41, Chase Metzger wrote: Removed some checkpatch.pl warnings saying there was an unwanted space between function names and their arguments. Signed-off-by: Chase Metzger --- drivers/usb/core/hub.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --

Re: [PATCH] usb: option: Add ID for Peiker LTE NAD

2014-11-01 Thread Lars Melin
On 2014-11-01 23:01, Matthias Klein wrote: Add ID of the Peiker LTE NAD for legacy serial interface Signed-off-by: Matthias Klein --- drivers/usb/serial/option.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/usb/serial/option.c b/drivers/usb/serial/option.c index d1a3f60..d7f10

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Lars Melin
On 2014-10-12 00:28, Jonas Brunsgaard wrote: Could you be more specific, what is it you dislike? After this patch the checkpatch script only come up with a couple of warnings, all due to the line length limit, and these warnings are all acceppable as they improve the ability to grep for user read

Re: [PATCH] usb: atm: fix codestyle issues in

2014-10-11 Thread Lars Melin
On 2014-10-11 23:02, Jonas Brunsgaard wrote: Signed-off-by: Jonas Brunsgaard --- drivers/usb/atm/ueagle-atm.c | 95 1 file changed, 42 insertions(+), 53 deletions(-) diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index 5a

Re: [PATCH] usb: serial: Fix indentation style issue

2014-10-11 Thread Lars Melin
On 2014-10-11 21:20, Greg KH wrote: On Sat, Oct 11, 2014 at 03:49:43PM +0200, Philip Munksgaard wrote: Fix a style issue Signed-off-by: Philip Munksgaard --- drivers/usb/serial/option.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/serial/option.c b/drivers

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-29 Thread Lars Melin
On 2014-09-29 19:11, Heiko Schocher wrote: Hello Lars, sorry for my late answer ... Am 24.09.2014 16:22, schrieb Lars Melin: On 2014-09-24 20:12, Heiko Schocher wrote: Hello Lars, Am 24.09.2014 14:25, schrieb Lars Melin: On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Lars Melin
On 2014-09-24 20:12, Heiko Schocher wrote: Hello Lars, Am 24.09.2014 14:25, schrieb Lars Melin: On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous

Re: [PATCH] usb: gadget: f_rndis: fix usb_interface_descriptor for rndis

2014-09-24 Thread Lars Melin
On 2014-09-24 13:48, Heiko Schocher wrote: use the values for RNDIS over Ethernet as defined in http://www.usb.org/developers/defined_class (search for RDNIS): - baseclass: 0xef (miscellaneous) - subclass: 0x04 - protocol: 0x01 That is usb class, it is not the same thing as communication devic

Re: [PATCH] net: qmi_wwan: Add ID for Telewell TW-LTE 4G v2

2014-07-01 Thread Lars Melin
On 2014-07-02 02:01, Bernd Wachter wrote: There's a new version of the Telewell 4G modem working with, but not recognized by this driver. Signed-off-by: Bernd Wachter --- --- linux-3.15.3/drivers/net/usb/qmi_wwan.c.orig2014-07-01 21:31:07.0 +0300 +++ linux-3.15.3/drivers/net/us