Re: linux-next: build warnings after merge of the sparc tree

2021-02-25 Thread LABBE Corentin
Le Mon, Feb 22, 2021 at 07:09:28PM +1100, Stephen Rothwell a écrit : > Hi all, > > After merging the sparc tree, today's linux-next build (sparc64 defconfig) > produced these warnings: > > arch/sparc/configs/sparc64_defconfig:237:warning: override: reassigning to > symbol ATA > arch/sparc/config

Re: [kbuild] drivers/crypto/allwinner/sun8i-ss/sun8i-ss-hash.c:443 sun8i_ss_hash_run() warn: possible memory leak of 'result'

2021-01-10 Thread LABBE Corentin
Le Thu, Jan 07, 2021 at 04:12:36PM +0300, Dan Carpenter a écrit : > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 > commit: d9b45418a91773b7672e4c60037a28074b495c6d crypto: sun8i-ss - support > hash algorith

Re: [PATCH v2 -next] media: zoran: convert comma to semicolon

2021-01-10 Thread LABBE Corentin
Le Fri, Jan 08, 2021 at 05:21:19PM +0800, Zheng Yongjun a écrit : > Replace a comma between expression statements by a semicolon. > > Signed-off-by: Zheng Yongjun > --- > drivers/staging/media/zoran/zoran_driver.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/

Re: [PATCH -next] media: zoran: use resource_size

2021-01-06 Thread LABBE Corentin
Le Wed, Jan 06, 2021 at 05:51:00PM +0300, Dan Carpenter a écrit : > On Wed, Jan 06, 2021 at 09:17:02PM +0800, Zheng Yongjun wrote: > > Use resource_size rather than a verbose computation on > > the end and start fields. > > > > Signed-off-by: Zheng Yongjun > > --- > > drivers/staging/media/zoran

Re: [PATCH] staging:media:zoran: Fixed grammar issue

2020-11-30 Thread LABBE Corentin
On Mon, Nov 30, 2020 at 05:06:59PM -0600, Travis Carter wrote: > Removed repeated word 'in' > > Signed-off-by: Travis Carter > --- > drivers/staging/media/zoran/zoran_card.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/media/zoran/zoran_card.c > b/dr

Re: drivers/crypto/allwinner/sun8i-ce/sun8i-ce-hash.c:412 sun8i_ce_hash_run() warn: possible memory leak of 'result'

2020-11-11 Thread LABBE Corentin
On Tue, Nov 10, 2020 at 01:47:37PM +0300, Dan Carpenter wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 407ab579637ced6dc32cfb2295afb7259cca4b22 > commit: 56f6d5aee88d129b2424902cd630f10794550763 crypto: sun8i-ce - support > hash algorithms >

Re: [PATCH][next] media: zoran: fix spelling mistake and make error message more meaningful

2020-10-05 Thread LABBE Corentin
On Fri, Oct 02, 2020 at 11:16:20AM +0100, Colin King wrote: > From: Colin Ian King > > There is a spelling mistake in a pci_err error message. Fix this and > make the error message a little more meaningful. > > Signed-off-by: Colin Ian King > --- > drivers/staging/media/zoran/zoran_driver.c |

Re: [PATCH] media: zoran.rst: place it at the right place this time

2020-10-04 Thread LABBE Corentin
On Sun, Oct 04, 2020 at 06:00:30PM +0200, Mauro Carvalho Chehab wrote: > I was too quick moving zoran.rst... it ends that the original > patch didn't do the right thing and forgot to update the files > that references it. > > Fix it. > > Fixes: 6b90346919d4 ("media: zoran: move documentation file

Re: [PATCH 1/4] media: zoran: move documentation file to the right place

2020-10-04 Thread LABBE Corentin
On Sat, Oct 03, 2020 at 10:41:54AM +0200, Mauro Carvalho Chehab wrote: > The zoran revert patch misplaced the Zoran doc file. Move it to > the right place. > > Signed-off-by: Mauro Carvalho Chehab > --- > Documentation/driver-api/media/drivers/index.rst | 1 + > .../{media => dri

Re: [PATCH 3/3] media: zoran: fix mixed case on vars

2020-10-02 Thread LABBE Corentin
On Thu, Oct 01, 2020 at 11:28:15AM +0200, Mauro Carvalho Chehab wrote: > Use this small script to replace CamelCase and wrong case > on vars: > > > FILES=$(find "$1" -type f|grep -e '.c$' -e '.h$') > CAMEL_VARS=$(cat tags|perl -ne 'print "$1\n" if > (m/^(\w*[A-Z]\w*[a-z]\w*)\s/)') > for i in $CA

Re: [PATCH 2/3] media: zoran: get rid of an unused var

2020-10-02 Thread LABBE Corentin
On Thu, Oct 01, 2020 at 11:28:14AM +0200, Mauro Carvalho Chehab wrote: > The jpeg_error in lowercase is not used anywhere. Drop it. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/staging/media/zoran/zoran.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/media/

Re: [PATCH RFT/RFC 37/49] staging: media: zoran: add fallthrough keyword

2020-09-24 Thread LABBE Corentin
On Mon, Sep 21, 2020 at 01:59:45PM +0300, Dan Carpenter wrote: > On Mon, Sep 21, 2020 at 10:20:12AM +, Corentin Labbe wrote: > > This patch adds fallthrough keyword where appropriate. > > > > Signed-off-by: Corentin Labbe > > --- > > drivers/staging/media/zoran/zoran_device.c | 6 ++ > >

Re: [PATCH v2 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-23 Thread LABBE Corentin
On Wed, Sep 23, 2020 at 04:00:32PM +0200, Arnd Bergmann wrote: > On Sun, Sep 20, 2020 at 8:37 PM Corentin Labbe wrote: > > > > Ciphers produce invalid results on BE. > > Key and IV need to be written in LE. > > > > Fixes: 6298e948215f2 ("crypto: sunxi-ss - Add Allwinner Security System > > crypto

Re: [PATCH RFT/RFC 01/49] staging: media: Revert "media: zoran: remove deprecated driver"

2020-09-22 Thread LABBE Corentin
On Tue, Sep 22, 2020 at 06:16:01AM +0100, Christoph Hellwig wrote: > > + fh->buffers.buffer[i].v4l.fbuffer = mem; > > + fh->buffers.buffer[i].v4l.fbuffer_phys = virt_to_phys(mem); > > + fh->buffers.buffer[i].v4l.fbuffer_bus = virt_to_bus(mem); > > + for (off

Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-19 Thread LABBE Corentin
On Fri, Sep 18, 2020 at 06:09:15PM +1000, Herbert Xu wrote: > On Fri, Sep 18, 2020 at 10:06:58AM +0200, LABBE Corentin wrote: > > > > But I think only me will see it and since I already have this on my TODO > > list, I dont see any interest to leave it failing. > > Fur

Re: [PATCH 4/7] crypto: sun4i-ss: handle BigEndian for cipher

2020-09-18 Thread LABBE Corentin
On Fri, Sep 18, 2020 at 05:31:28PM +1000, Herbert Xu wrote: > On Thu, Sep 17, 2020 at 06:35:55PM +, Corentin Labbe wrote: > > Ciphers produce invalid results on BE. > > Key and IV need to be written in LE. > > Furthermore, the non-optimized function is too complicated to convert, > > let's simp

Re: [PATCH v4 08/17] crypto: sun8i-ce: move iv data to request context

2020-08-21 Thread LABBE Corentin
On Fri, Jul 31, 2020 at 06:24:27PM +1000, Herbert Xu wrote: > On Tue, Jul 21, 2020 at 07:06:22PM +, Corentin Labbe wrote: > > Instead of storing IV data in the channel context, store them in the > > request context. > > Storing them in the channel structure was conceptualy wrong since they > >

Re: [PATCH v4 16/17] crypto: sun8i-ce: fix comparison of integer expressions of different signedness

2020-07-21 Thread LABBE Corentin
On Tue, Jul 21, 2020 at 02:32:15PM -0700, Joe Perches wrote: > On Tue, 2020-07-21 at 19:06 +, Corentin Labbe wrote: > > This patch fixes the warning: > > warning: comparison of integer expressions of different signedness: 'int' > > and 'long unsigned int' [-Wsign-compare] > > I think these do

Re: [PATCH -next] crypto: amlogic: Convert to DEFINE_SHOW_ATTRIBUTE

2020-07-20 Thread LABBE Corentin
On Thu, Jul 16, 2020 at 05:04:11PM +0800, Qinglang Miao wrote: > From: Liu Shixin > > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Liu Shixin > --- > drivers/crypto/amlogic/amlogic-gxl-core.c | 15 ++- > 1 file changed, 2 insertions(+), 13 deletions(-) >

Re: [PATCH] sparc: sparc64_defconfig: add necessary configs for qemu

2020-07-02 Thread LABBE Corentin
On Thu, Jul 02, 2020 at 08:58:40PM +0100, Mark Cave-Ayland wrote: > On 02/07/2020 14:02, Corentin Labbe wrote: > > > The sparc64 qemu machines uses pcnet32 network hardware by default, so for > > simple boot testing using qemu, having PCNET32 is useful. > > Same for its storage which is a PATA_CMD

Re: [PATCH v2 13/14] crypto: sun8i-ce: Add support for the PRNG

2020-06-15 Thread LABBE Corentin
On Mon, Apr 27, 2020 at 11:23:15AM +0200, Stephan Mueller wrote: > Am Montag, 27. April 2020, 10:41:37 CEST schrieb LABBE Corentin: > > Hi Corentin, > > > > Shouldn't they all be kzfree? > > > > Yes > > Probably it miss also a memzero_explici

Re: [PATCH] ARM: defconfig: enable storage for qemu

2020-06-10 Thread LABBE Corentin
On Thu, Mar 05, 2020 at 03:48:23PM +, Corentin Labbe wrote: > The qemu versatilepb machine has some SCSI storage which cannot be used > with this defconfig. > The SCSI rely on PCI which is not enabled. > So let's enable both PCI and SCSI. > > This will permit to use LAVA tests for versatilepb

Re: tegra124-jetson-tk1: sata doesnt work since 5.2

2020-06-02 Thread LABBE Corentin
On Mon, Jun 01, 2020 at 05:30:37PM +0300, Dmitry Osipenko wrote: > 31.05.2020 22:31, LABBE Corentin пишет: > > On Thu, Mar 19, 2020 at 08:44:01AM +0100, LABBE Corentin wrote: > >> Hello > >> > >> sata doesnt work on tegra124-jetson-tk1 on next and master and at

Re: tegra124-jetson-tk1: sata doesnt work since 5.2

2020-05-31 Thread LABBE Corentin
On Thu, Mar 19, 2020 at 08:44:01AM +0100, LABBE Corentin wrote: > Hello > > sata doesnt work on tegra124-jetson-tk1 on next and master and at least since > 5.2 (but 5.1 works). > [0.492810] +5V_SATA: supplied by +5V_SYS > [0.493230] +12V_SATA: supplied by +VDD_MUX >

Re: [PATCH 2/4] crypto: amlogic: Add crypto accelerator for amlogic GXL

2019-08-01 Thread LABBE Corentin
On Sat, Jul 27, 2019 at 02:17:38PM +0200, Martin Blumenstingl wrote: > Hi Corentin, > > it's great to see you working on this :) > > On Thu, Jul 25, 2019 at 9:45 PM Corentin Labbe wrote: > > > > This patch adds support for the amlogic GXL cryptographic offloader present > > on GXL SoCs. > > > >

Re: [PATCH] agp: Add bridge parameter documentation

2019-04-20 Thread LABBE Corentin
On Wed, Dec 20, 2017 at 07:26:50PM +, Corentin Labbe wrote: > This patch add documentation about the bridge parameter in several > function. > > This will fix the following build warning: > drivers/char/agp/generic.c:220: warning: No description found for parameter > 'bridge' > drivers/char/a

Re: [PATCH RESEND] spi: clps711x: remove unused header

2019-04-20 Thread LABBE Corentin
On Wed, Sep 19, 2018 at 07:17:54PM +, Corentin Labbe wrote: > include/linux/platform_data/spi-clps711x.h is unused since commit > 6acaadc852f1 ("spi: clps711x: Driver refactor") > Let's remove it. > Hello Gentle ping Regards > Signed-off-by: Corentin Labbe > --- > include/linux/platform

Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB

2019-03-12 Thread LABBE Corentin
On Tue, Mar 12, 2019 at 12:06:23PM +, Alan Cox wrote: > On Tue, 12 Mar 2019 11:41:02 +0100 > LABBE Corentin wrote: > > > On Mon, Dec 10, 2018 at 05:52:35PM +0300, Sergei Shtylyov wrote: > > > Hello! > > > > > > On 12/10/2018 04:46 PM, Corentin Labbe

Re: [PATCH] ata: pata_oldpiix: Add missing device ID for INTEL_82371AB

2019-03-12 Thread LABBE Corentin
On Mon, Dec 10, 2018 at 05:52:35PM +0300, Sergei Shtylyov wrote: > Hello! > > On 12/10/2018 04:46 PM, Corentin Labbe wrote: > > > When playing with a virtual SPARC machine with qemu, I found that the > > IDE emulated device was not probing with the ata/pata_oldpiix driver. > >Correctly, it s

Re: [PATCH v2 0/2] ARC: rework U-boot arguments handling

2019-02-15 Thread LABBE Corentin
On Thu, Feb 14, 2019 at 06:07:43PM +0300, Eugeniy Paltsev wrote: > Reworking U-boot args handling and enable uboot support > unconditionally. > > Changes v1->v2: > * Drop magic number check [in this patch series] > * Keep comment about cndline appending > > Changes RFC->v1: > * Don't add new A

Re: [PATCH 1/2] ARC: U-boot: check arguments paranoidly

2019-02-12 Thread LABBE Corentin
On Tue, Feb 12, 2019 at 06:39:31PM +0300, Eugeniy Paltsev wrote: > Handle U-boot arguments paranoidly: > * don't allow to pass unknown tag. > * try to use external device tree blob only if corresponding tag >(TAG_DTB) is set. > * check that magic number is correct. > * don't check uboot_tag

Re: [PATCH] dma-debug: add dumping facility via debugfs

2019-01-18 Thread LABBE Corentin
On Wed, Jan 16, 2019 at 06:10:13PM +, Robin Murphy wrote: > On 16/01/2019 13:44, Corentin Labbe wrote: > > While debugging a DMA mapping leak, I needed to access > > debug_dma_dump_mappings() but easily from user space. > > > > This patch adds a /sys/kernel/debug/dma-api/dump file which contai

Re: [PATCH] PCI: amlogic: fix build failure due to missing linux/gpio/consumer.h header

2019-01-04 Thread LABBE Corentin
On Fri, Jan 04, 2019 at 10:30:25AM +, Lorenzo Pieralisi wrote: > On Fri, Jan 04, 2019 at 09:08:37AM +, Corentin Labbe wrote: > > When building on x86, I got the following build failure: > > Hi, > > what tree are you testing on and which config ? I use the next-20190102 tree The config ca

Re: [PATCH 2/5] crypto: crypto_user_stat: convert all stats from u32 to u64

2018-11-07 Thread LABBE Corentin
On Mon, Nov 05, 2018 at 05:42:42PM -0800, Eric Biggers wrote: > Hi Corentin, > > On Mon, Nov 05, 2018 at 12:51:11PM +, Corentin Labbe wrote: > > All the 32-bit fields need to be 64-bit. In some cases, UINT32_MAX crypto > > operations can be done in seconds. > > > > Reported-by: Eric Biggers

Re: [PATCH v3 4/9] dt-bindings: ata: ahci-platform: document AHCI reset

2018-07-17 Thread LABBE Corentin
On Mon, Jul 16, 2018 at 09:54:16AM -0600, Rob Herring wrote: > On Fri, Jul 13, 2018 at 11:03:01AM +, Corentin Labbe wrote: > > This patch document the new optional resets for ahci node. > > > > Signed-off-by: Corentin Labbe > > --- > > Documentation/devicetree/bindings/ata/ahci-platform.txt

Re: [PATCH] IB/cxgb3: remove cxio_dbg.c

2018-01-30 Thread LABBE Corentin
On Sun, Jan 28, 2018 at 02:09:03PM -0700, Jason Gunthorpe wrote: > On Sun, Jan 28, 2018 at 08:24:22AM -0800, Joe Perches wrote: > > On Sun, 2018-01-28 at 15:11 +, Corentin Labbe wrote: > > > cxio_dbg.c is uncompiled since commit 2b540355cd2f ("RDMA/cxgb3: > > > cleanups") > > > 10 years after,

Re: [PATCH] staging: media: atomisp2: remove unused headers

2018-01-29 Thread LABBE Corentin
On Mon, Jan 29, 2018 at 03:22:33PM +0200, Andy Shevchenko wrote: > On Mon, Jan 29, 2018 at 3:11 PM, Corentin Labbe wrote: > > All thoses headers are not used by any source files. > > Lets just remove them. > > How did you test this? > > P.S. I like the patch, but since driver in a state of coma

Re: [PATCH] staging: media: remove unused VIDEO_ATOMISP_OV8858 kconfig

2018-01-26 Thread LABBE Corentin
On Tue, Jan 23, 2018 at 07:20:12PM +0100, Greg Kroah-Hartman wrote: > On Tue, Jan 23, 2018 at 07:31:27PM +0200, Andy Shevchenko wrote: > > On Tue, Jan 23, 2018 at 4:37 PM, Corentin Labbe wrote: > > > Nothing in kernel use VIDEO_ATOMISP_OV8858 since commit 3a81c7660f80 > > > ("media: staging: atom

Re: [PATCH 1/2] crypto: Implement a generic crypto statistics

2018-01-18 Thread LABBE Corentin
On Fri, Jan 12, 2018 at 10:11:18AM +0100, Stephan Mueller wrote: > Am Freitag, 12. Januar 2018, 10:07:30 CET schrieb LABBE Corentin: > > > > > + __u64 stat_hash_tlen; > > > > > > > > }; > > > > > > What I am slightly unsu

Re: [PATCH 1/2] crypto: Implement a generic crypto statistics

2018-01-12 Thread LABBE Corentin
On Fri, Jan 12, 2018 at 07:49:43AM +0100, Stephan Mueller wrote: > Am Donnerstag, 11. Januar 2018, 20:56:56 CET schrieb Corentin Labbe: > > Hi Corentin, > > > This patch implement a generic way to get statistics about all crypto > > usages. > > > > Signed-off-by: Corentin Labbe > > --- > > cry

Re: [PATCH RFC 1/3] crypto: Prevent to register duplicate cra_driver_name

2017-12-21 Thread LABBE Corentin
On Thu, Dec 21, 2017 at 01:35:27PM +0100, LABBE Corentin wrote: > On Thu, Dec 21, 2017 at 05:35:22PM +1100, Herbert Xu wrote: > > On Wed, Dec 20, 2017 at 08:09:25PM +, Corentin Labbe wrote: > > > Each crypto algorithm "cra_name" can have multiple implementation c

Re: [PATCH RFC 2/3] crypto: Implement a generic crypto statistics

2017-12-21 Thread LABBE Corentin
On Thu, Dec 21, 2017 at 07:38:35AM +0100, Stephan Mueller wrote: > Am Mittwoch, 20. Dezember 2017, 21:09:26 CET schrieb Corentin Labbe: > > Hi Corentin, > > > This patch implement a generic way to get statistics about all crypto > > usages. > > > > Signed-off-by: Corentin Labbe > > --- > > cry

Re: [PATCH RFC 1/3] crypto: Prevent to register duplicate cra_driver_name

2017-12-21 Thread LABBE Corentin
On Thu, Dec 21, 2017 at 05:35:22PM +1100, Herbert Xu wrote: > On Wed, Dec 20, 2017 at 08:09:25PM +, Corentin Labbe wrote: > > Each crypto algorithm "cra_name" can have multiple implementation called > > "cra_driver_name". > > If two different implementation have the same cra_driver_name, nothin

Re: [PATCH] crypto: arm64/aes - do not call crypto_unregister_skcipher twice on error

2017-11-23 Thread LABBE Corentin
On Wed, Nov 22, 2017 at 08:55:14AM +, Ard Biesheuvel wrote: > Hello Corentin, > > On 22 November 2017 at 08:08, Corentin Labbe wrote: > > When a cipher fail > > fails > > > to register in aes_init(), the error path go thought > > goes through > > > aes_exit() then crypto_unregister_skciph

Re: [PATCH 1/4] usb: xhci: remove unused variable last_freed_endpoint

2017-10-26 Thread LABBE Corentin
On Thu, Oct 26, 2017 at 12:01:54PM +, Corentin Labbe wrote: > This patch fix the following build warnings: > drivers/usb/host/xhci.c:3378:6: warning: variable 'last_freed_endpoint' set > but not used [-Wunused-but-set-variable] > > Signed-off-by: Corentin Labbe > --- > drivers/usb/host/xhci

[BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE

2016-11-07 Thread LABBE Corentin
Hello With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try. [3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver [3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip [3.923016] gpiochip_add_data: GPIOs 0..223 (1c20

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-28 Thread LABBE Corentin
On Tue, Oct 25, 2016 at 09:06:34AM +0200, Jean-Francois Moine wrote: > On Tue, 25 Oct 2016 07:38:55 +0200 > LABBE Corentin wrote: > > > > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > > > Since SID's content is constant over reboot, >

Re: [PATCH] nvmem: sunxi-sid: SID content is not a valid source of randomness

2016-10-24 Thread LABBE Corentin
On Mon, Oct 24, 2016 at 10:10:20PM +0200, Maxime Ripard wrote: > On Sat, Oct 22, 2016 at 03:53:28PM +0200, Corentin Labbe wrote: > > Since SID's content is constant over reboot, > > That's not true, at least not across all the Allwinner SoCs, and > especially not on the A10 and A20 that this drive

Re: [PATCH v4 01/10] ethernet: add sun8i-emac driver

2016-10-23 Thread LABBE Corentin
On Fri, Oct 07, 2016 at 08:02:39AM -0700, Joe Perches wrote: > On Fri, 2016-10-07 at 10:25 +0200, Corentin Labbe wrote: > > This patch add support for sun8i-emac ethernet MAC hardware. > > It could be found in Allwinner H3/A83T/A64 SoCs. > > trivial notes: > > > diff --git a/drivers/net/ethernet/

Re: [PATCH] ARM: dt: sun8i-h3: Add sunxi-sid to dts for sun8i-h3

2016-10-23 Thread LABBE Corentin
On Thu, Oct 20, 2016 at 10:36:54PM +0200, Maxime Ripard wrote: > On Wed, Oct 19, 2016 at 09:40:16AM +0200, LABBE Corentin wrote: > > On Wed, Oct 05, 2016 at 12:21:30PM +0200, Jean-Francois Moine wrote: > > > On Wed, 5 Oct 2016 11:48:24 +0200 > > > Corentin Labbe wrote

Re: [PATCH] ARM: dt: sun8i-h3: Add sunxi-sid to dts for sun8i-h3

2016-10-19 Thread LABBE Corentin
On Wed, Oct 05, 2016 at 12:21:30PM +0200, Jean-Francois Moine wrote: > On Wed, 5 Oct 2016 11:48:24 +0200 > Corentin Labbe wrote: > > > This patch add support for the sunxi-sid driver to the device tree for > > sun8i-h3. > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/boot/dts/sun8

Re: [PATCH v2] rtc: cmos: remove all __exit_p annotations

2016-10-18 Thread LABBE Corentin
On Tue, Oct 18, 2016 at 04:16:39PM +0200, Alexandre Belloni wrote: > Hi, > > On 18/10/2016 at 13:55:53 +0200, Corentin Labbe wrote : > > Change since v1: > > - restored __exit for module_exit function > > > > ---8<--- > > I don't think this is the proper scissor symbol for git. At least, it is >

Re: [PATCH v4 03/10] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-10-13 Thread LABBE Corentin
On Mon, Oct 10, 2016 at 10:13:35AM -0500, Rob Herring wrote: > On Fri, Oct 07, 2016 at 10:25:50AM +0200, Corentin Labbe wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: Corentin Labbe > > --- > > .../bindings/net/al

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

2016-10-12 Thread LABBE Corentin
On Tue, Oct 11, 2016 at 11:40:42AM +0200, Maxime Ripard wrote: > On Mon, Oct 10, 2016 at 03:09:43PM +0200, Jean-Francois Moine wrote: > > On Mon, 10 Oct 2016 14:35:11 +0200 > > LABBE Corentin wrote: > > > > > On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard

Re: [linux-sunxi] [PATCH 2/5] pwm: Add Allwinner A31 SoC support

2016-10-11 Thread LABBE Corentin
Hello I have a minor comment below On Tue, Oct 11, 2016 at 02:34:46PM +0800, Icenowy Zheng wrote: > This adds a generic PWM framework driver for the PWM controller found > on Allwinner A31 and A31s SoCs. > > The PWM controller is different with other Allwinner SoCs, with a > control register per

Re: [PATCH v4 10/10] ARM: sunxi: Enable sun8i-emac driver on multi_v7_defconfig

2016-10-10 Thread LABBE Corentin
On Mon, Oct 10, 2016 at 02:30:46PM +0200, Maxime Ripard wrote: > On Fri, Oct 07, 2016 at 10:25:57AM +0200, Corentin Labbe wrote: > > Enable the sun8i-emac driver in the multi_v7 default configuration > > > > Signed-off-by: Corentin Labbe > > --- > > arch/arm/configs/multi_v7_defconfig | 1 + > >

Re: [RFC PATCH 9/9] ethernet: sun8i-emac: add pm_runtime support

2016-09-14 Thread LABBE Corentin
On Mon, Sep 12, 2016 at 10:44:51PM +0200, Maxime Ripard wrote: > Hi, > > On Fri, Sep 09, 2016 at 02:45:17PM +0200, Corentin Labbe wrote: > > This patch add pm_runtime support to sun8i-emac. > > For the moment, only basic support is added, (the device is marked as > > used when net/open) > > > > S

Re: [PATCH v3 5/9] ARM: dts: sun8i-h3: add sun8i-emac ethernet driver

2016-09-14 Thread LABBE Corentin
On Mon, Sep 12, 2016 at 09:29:33AM +0200, Maxime Ripard wrote: > On Fri, Sep 09, 2016 at 02:45:13PM +0200, Corentin Labbe wrote: > > The sun8i-emac is an ethernet MAC hardware that support 10/100/1000 > > speed. > > > > This patch enable the sun8i-emac on the Allwinner H3 SoC Device-tree. > > The

Re: [PATCH v3 8/9] ARM: sunxi: Enable sun8i-emac driver on sunxi_defconfig

2016-09-13 Thread LABBE Corentin
On Mon, Sep 12, 2016 at 09:30:08AM +0200, Maxime Ripard wrote: > Hi, > > On Fri, Sep 09, 2016 at 02:45:16PM +0200, Corentin Labbe wrote: > > Enable the sun8i-emac driver in the sunxi default configuration > > > > Signed-off-by: Corentin Labbe > > Could you make the same patch for multi_v7 ? >

Re: [PATCH v3 4/9] ARM: dts: sun8i-h3: Add dt node for the syscon control module

2016-09-13 Thread LABBE Corentin
On Mon, Sep 12, 2016 at 09:28:12AM +0200, Maxime Ripard wrote: > On Fri, Sep 09, 2016 at 02:45:12PM +0200, Corentin Labbe wrote: > > This patch add the dt node for the syscon register present on the > > Allwinner H3. > > > > Only two register are present in this syscon and the only one useful is >

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-13 Thread LABBE Corentin
On Fri, Sep 09, 2016 at 04:17:10PM +0200, Andrew Lunn wrote: > > +Optional properties: > > +- allwinner,tx-delay: TX clock delay chain value. Range value is 0-0x07. > > Default is 0) > > +- allwinner,rx-delay: RX clock delay chain value. Range value is 0-0x1F. > > Default is 0) > > What are the

Re: [PATCH v3 1/9] ethernet: add sun8i-emac driver

2016-09-13 Thread LABBE Corentin
On Fri, Sep 09, 2016 at 04:15:27PM +0200, Andrew Lunn wrote: > Hi Corentin > > > +static int sun8i_emac_mdio_register(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + struct mii_bus *bus; > > + int ret; > > + > > + bus = mdiobus_alloc(); > > Yo

Re: [PATCH v3 3/9] ARM: sun8i: dt: Add DT bindings documentation for Allwinner sun8i-emac

2016-09-12 Thread LABBE Corentin
On Fri, Sep 09, 2016 at 04:04:13PM +0200, Andrew Lunn wrote: > > +The device node referenced by "phy" or "phy-handle" should be a child node > > +of this node. See phy.txt for the generic PHY bindings. > > I've not looked at the code yet, but is this really true? Generally > there is not this limi

[PATCH v3 1/8] hwrng: amd: Fix style problem with blank line

2016-08-26 Thread LABBE Corentin
Some blank line are unncessary, and one is missing after declaration. This patch fix thoses style problems. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char

[PATCH v3 3/8] hwrng: amd: Be consitent with the driver name

2016-08-26 Thread LABBE Corentin
The driver name is displayed each time differently. This patch make use of the same name everywhere. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char

[PATCH v3 8/8] hwrng: amd: Convert to new hwrng read() API

2016-08-26 Thread LABBE Corentin
This patch convert the hwrng interface used by amd768-rng to its new API by replacing data_read()/data_present() by read(). Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 47 1 file changed, 28 insertions(+), 19 deletions(-) diff

[PATCH v3 2/8] hwrng: amd: use the BIT macro

2016-08-26 Thread LABBE Corentin
This patch add usage of the BIT() macro Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c index 45b7965..d0042f5 100644 --- a/drivers

[PATCH v3 7/8] hwrng: amd: Access hardware via ioread32/iowrite32

2016-08-26 Thread LABBE Corentin
Instead of accessing hw directly via pmbase, it's better to access after ioport_map() via ioread32/iowrite32. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 31 +-- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH v3 5/8] hwrng: amd: release_region must be called after hwrng_unregister

2016-08-26 Thread LABBE Corentin
The driver release the memory region before being sure that nobody use it. This patch made hwrng_unregister ran before any release was done. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char

[PATCH v3 4/8] hwrng: amd: Remove asm/io.h

2016-08-26 Thread LABBE Corentin
checkpatch complains about used instead of linux/io.h. In fact it is not needed. This patch remove it, and in the process, alphabetize the other headers. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH v3 6/8] hwrng: amd: Replace global variable with private struct

2016-08-26 Thread LABBE Corentin
Instead of having two global variable, it's better to use a private struct. This will permit to remove amd_pdev variable Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 57 ++-- 1 file changed, 38 insertions(+), 19 deletions(-)

[PATCH v3 0/8] hwrng: amd: rework of the amd hwrng driver

2016-08-26 Thread LABBE Corentin
Changes since v2: - split the latest patch in 4 Changes since v1: - Keep the hwrng name as "amd" LABBE Corentin (8): hwrng: amd: Fix style problem with blank line hwrng: amd: use the BIT macro hwrng: amd: Be consitent with the driver name hwrng: amd: Remove asm/io.h

Re: [PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-26 Thread LABBE Corentin
On Thu, Aug 25, 2016 at 02:56:38PM +, Jason Cooper wrote: > Hi Corentin, > > On Thu, Aug 25, 2016 at 02:16:35PM +0200, LABBE Corentin wrote: > > This patch convert the hwrng interface used by amd768-rng to its new API > > by replacing data_read()/data_present() by read().

[PATCH v2 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-25 Thread LABBE Corentin
ng hw directly via pmbase, it's better to access after ioport_map() via ioread32/iowrite32. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 151 +-- 1 file changed, 99 insertions(+), 52 deletions(-) diff --git a/drivers/char/hw_random/a

[PATCH v2 4/5] hwrng: amd: Remove asm/io.h

2016-08-25 Thread LABBE Corentin
checkpatch complains about used instead of linux/io.h. In fact it is not needed. This patch remove it, and in the process, alphabetize the other headers. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] hwrng: pasemi_rng.c: Migrate to managed API

2016-08-25 Thread LABBE Corentin
On Thu, Aug 25, 2016 at 05:04:16PM +0530, PrasannaKumar Muralidharan wrote: > Use devm_ioremap and devm_hwrng_register instead of ioremap and > hwrng_register. This removes unregistering and error handling code. > > This patch is not tested with hardware as I don't have access to it. > > Signed-o

[PATCH v2 1/5] hwrng: amd: Fix style problem with blank line

2016-08-25 Thread LABBE Corentin
Some blank line are unncessary, and one is missing after declaration. This patch fix thoses style problems. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char

[PATCH v2 0/5] hwrng: amd: rework of the amd hwrng driver

2016-08-25 Thread LABBE Corentin
Changes since v1: - Keep the hwrng name as "amd" LABBE Corentin (5): hwrng: amd: Fix style problem with blank line hwrng: amd: use the BIT macro hwrng: amd: Be consitent with the driver name hwrng: amd: Remove asm/io.h hwrng: amd: Rework of the amd768-hwrng driver dr

[PATCH v2 3/5] hwrng: amd: Be consitent with the driver name

2016-08-25 Thread LABBE Corentin
The driver name is displayed each time differently. This patch make use of the same name everywhere. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char

[PATCH v2 2/5] hwrng: amd: use the BIT macro

2016-08-25 Thread LABBE Corentin
This patch add usage of the BIT() macro Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c index 45b7965..d0042f5 100644 --- a/drivers

Re: [PATCH v2 1/5] ethernet: add sun8i-emac driver

2016-08-24 Thread LABBE Corentin
> > +/* Set Management Data Clock, must be call after device reset */ > > +static void sun8i_emac_set_mdc(struct net_device *ndev) > > +{ > > + struct sun8i_emac_priv *priv = netdev_priv(ndev); > > + unsigned long rate; > > + u32 reg; > > + > > + rate = clk_get_rate(priv->ahb_clk); > > +

Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name

2016-08-24 Thread LABBE Corentin
On Wed, Aug 24, 2016 at 06:58:11PM +0800, Herbert Xu wrote: > On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote: > > The driver name is displayed each time differently. > > This patch make use of the same name everywhere. > > > > Signed-off-by: LABBE Cor

[PATCH v3] pwm: sun4i: fix a possible NULL dereference

2016-08-24 Thread LABBE Corentin
necessary for avoiding a second NULL deref on pwm->data. Reported-by: coverity (CID 1324139) Signed-off-by: LABBE Corentin --- Changes since v2: - Add a test on pwm->data for avoiding a second NULL deref. Changes since v1: - Use of_device_get_match_data() drivers/pwm/pwm-sun4i

Re: [PATCH v2 1/1] pwm: sun4i: fix a possible NULL dereference

2016-08-24 Thread LABBE Corentin
On Mon, Aug 22, 2016 at 08:57:37AM +0200, Maxime Ripard wrote: > Hi, > > On Tue, Aug 16, 2016 at 03:18:06PM +0200, LABBE Corentin wrote: > > of_match_device could return NULL, and so cause a NULL pointer > > dereference later. > > > > For fixing this problem

[PATCH v2] gpu: ipu-v3: fix a possible NULL dereference

2016-08-24 Thread LABBE Corentin
necessary for avoiding a second NULL deref later on devtype. Signed-off-by: LABBE Corentin --- Changes in v2: - Add a test on devtype for avoiding a second NULL deref. drivers/gpu/ipu-v3/ipu-common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/ipu-v3

[PATCH 3/5] hwrng: amd: Be consitent with the driver name

2016-08-19 Thread LABBE Corentin
The driver name is displayed each time differently. This patch make use of the same name everywhere. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers

[PATCH 1/5] hwrng: amd: Fix style problem with blank line

2016-08-19 Thread LABBE Corentin
Some blank line are unncessary, and one is missing after declaration. This patch fix thoses style problems. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char

[PATCH 4/5] hwrng: amd: Remove asm/io.h

2016-08-19 Thread LABBE Corentin
checkpatch complains about used instead of linux/io.h. In fact it is not needed. This patch remove it, and in the process, alphabetize the other headers. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 2/5] hwrng: amd: use the BIT macro

2016-08-19 Thread LABBE Corentin
This patch add usage of the BIT() macro Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c index 45b7965..d0042f5 100644 --- a/drivers

[PATCH 5/5] hwrng: amd: Rework of the amd768-hwrng driver

2016-08-19 Thread LABBE Corentin
ng hw directly via pmbase, it's better to access after ioport_map() via ioread32/iowrite32. Signed-off-by: LABBE Corentin --- drivers/char/hw_random/amd-rng.c | 151 +-- 1 file changed, 99 insertions(+), 52 deletions(-) diff --git a/drivers/char/hw_random/a

[PATCH] MAINTAINERS: add linux-su...@googlegroups.com as list for sunxi arch

2016-08-18 Thread LABBE Corentin
All discutions about sunxi architecture is done on linux-su...@googlegroups.com. This patch add it as list on drivers for this arch. Signed-off-by: LABBE Corentin --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a306795..6254eb1 100644 --- a

Re: [PATCH] Add Ingenic JZ4780 hardware RNG driver

2016-08-18 Thread LABBE Corentin
On Thu, Aug 18, 2016 at 10:44:18AM +0530, PrasannaKumar Muralidharan wrote: > >> +static int jz4780_rng_read(struct hwrng *rng, void *buf, size_t max, bool > >> wait) > >> +{ > >> + struct jz4780_rng *jz4780_rng = container_of(rng, struct jz4780_rng, > >> +

[PATCH] atm: fore200e: Do not drop const qualifier

2016-08-17 Thread LABBE Corentin
The data member of structure firmware is const and this constness is dropped by some cast. This patch add some const for keeping the const information. Signed-off-by: LABBE Corentin --- drivers/atm/fore200e.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/atm

[PATCH 2/3] input: pixcir_i2c: Remove text about writing to Free Software Foundation

2016-08-17 Thread LABBE Corentin
Checkpatch complains about the text suggesting writing to Free Software Foundation for GPLv2 license copy. This patch remove that text. Signed-off-by: LABBE Corentin --- drivers/input/touchscreen/pixcir_i2c_ts.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/input/touchscreen

[PATCH 3/3] input: pixcir_i2c: Remove a useless blank line

2016-08-17 Thread LABBE Corentin
This patch fix the following checkpatch report: Blank lines aren't necessary after an open brace Signed-off-by: LABBE Corentin --- drivers/input/touchscreen/pixcir_i2c_ts.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/input/touchscreen/pixcir_i2c_ts.c b/drivers/input/touchs

[PATCH 1/3] input: pixcir_i2c_ts: simplify code with of_device_get_match_data

2016-08-17 Thread LABBE Corentin
The usage of of_device_get_match_data reduce the code size a bit. Furthermore, it is better to use a standard function for getting the match data. Signed-off-by: LABBE Corentin --- drivers/input/touchscreen/pixcir_i2c_ts.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git

[PATCH] memory: atmel-sdramc: fix a possible NULL dereference

2016-08-16 Thread LABBE Corentin
of_match_device could return NULL, and so cause a NULL pointer dereference later. For fixing this problem, we use of_device_get_match_data(), this will simplify the code a little by using a standard function for getting the match data. Signed-off-by: LABBE Corentin --- drivers/memory/atmel

[PATCH] gpu: ipu-v3: fix a possible NULL dereference

2016-08-16 Thread LABBE Corentin
of_match_device could return NULL, and so cause a NULL pointer dereference later. For fixing this problem, we use of_device_get_match_data(), this will simplify the code a little by using a standard function for getting the match data. Signed-off-by: LABBE Corentin --- drivers/gpu/ipu-v3/ipu

[PATCH v2 0/1] pwm: sun4i: fix a possible NULL dereference

2016-08-16 Thread LABBE Corentin
Hello Change since v1: - Use of_device_get_match_data() LABBE Corentin (1): pwm: sun4i: fix a possible NULL dereference drivers/pwm/pwm-sun4i.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) -- 2.7.3

[PATCH v2 1/1] pwm: sun4i: fix a possible NULL dereference

2016-08-16 Thread LABBE Corentin
of_match_device could return NULL, and so cause a NULL pointer dereference later. For fixing this problem, we use of_device_get_match_data(), this will simplify the code a little by using a standard function for getting the match data. Reported-by: coverity (CID 1324139) Signed-off-by: LABBE

  1   2   3   4   5   >