Re: Re: [PATCH v2] arm64: kasan: add interceptors for strcmp/strncmp functions

2018-09-05 Thread Kyeongdon Kim
On 2018-09-05 오전 1:24, Andrey Ryabinin wrote: On 09/04/2018 01:10 PM, Andrey Ryabinin wrote: > > > On 09/04/2018 09:59 AM, Kyeongdon Kim wrote: > >>>> +#undef strncmp >>>> +int strncmp(const char *cs, const char *ct, size_t len) >>>> +{ &

Re: Re: [PATCH v2] arm64: kasan: add interceptors for strcmp/strncmp functions

2018-09-04 Thread Kyeongdon Kim
Hello Andrey, Thanks for your review. On 2018-09-03 오후 6:40, Andrey Ryabinin wrote: On 08/23/2018 11:56 AM, Kyeongdon Kim wrote: > diff --git a/mm/kasan/kasan.c b/mm/kasan/kasan.c > index c3bd520..61ad7f1 100644 > --- a/mm/kasan/kasan.c > +++ b/mm/kasan/kasan.c > @@ -304,6

Re: Re: [PATCH v2] arm64: kasan: add interceptors for strcmp/strncmp functions

2018-09-03 Thread Kyeongdon Kim
Hello Dmitry, On 2018-09-03 오후 6:13, Dmitry Vyukov wrote: On Mon, Sep 3, 2018 at 11:02 AM, Kyeongdon Kim wrote: > Dear all, > > Could anyone review this and provide me appropriate approach ? > I think str[n]cmp are frequently used functions so I believe very useful w/ > a

Re: [PATCH v2] arm64: kasan: add interceptors for strcmp/strncmp functions

2018-09-03 Thread Kyeongdon Kim
Dear all, Could anyone review this and provide me appropriate approach ? I think str[n]cmp are frequently used functions so I believe very useful w/ arm64 KASAN. Best Regards, Kyeongdon Kim On 2018-08-23 오후 5:56, Kyeongdon Kim wrote: This patch declares strcmp/strncmp as weak symbols. (2

[PATCH v2] arm64: kasan: add interceptors for strcmp/strncmp functions

2018-08-23 Thread Kyeongdon Kim
patch now. Signed-off-by: Kyeongdon Kim --- arch/arm64/include/asm/string.h | 5 + arch/arm64/kernel/arm64ksyms.c | 2 ++ arch/arm64/kernel/image.h | 2 ++ arch/arm64/lib/strcmp.S | 3 +++ arch/arm64/lib/strncmp.S| 3 +++ mm/kasan/kasan.c| 23

[PATCH] arm64: kasan: add interceptors for strcmp/strncmp functions

2018-08-17 Thread Kyeongdon Kim
bus_add_driver+0x2dc/0x328 driver_register+0x118/0x160 __platform_driver_register+0x7c/0x88 alarmtimer_init+0x154/0x1e4 do_one_initcall+0x184/0x1a4 kernel_init_freeable+0x2ec/0x2f0 kernel_init+0x18/0x10c ret_from_fork+0x10/0x50 Signed-off-by: Kyeongdon Kim --- arch/arm64/include/asm/string.h | 4

[PATCH] arm64: lib: use c string functions for KASAN support

2018-08-14 Thread Kyeongdon Kim
c fc fc == Signed-off-by: Kyeongdon Kim --- arch/arm64/include/asm/string.h | 2 ++ arch/arm64/kernel/arm64ksyms.c | 2 ++ arch/arm64/lib/Makefile | 8 +--- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/arc

[PATCH v2] ksm : use checksum and memcmp for rb_tree

2017-11-14 Thread Kyeongdon Kim
sumption than KSM default enable. v1 -> v2 - add comment for oldchecksum value - move the oldchecksum value out of union - remove check code regarding checksum 0 in stable_tree_search() link to v1 : https://lkml.org/lkml/2017/10/30/251 Signed-off-by: Kyeon

Re: Re: [PATCH] ksm : use checksum and memcmp for rb_tree

2017-11-06 Thread Kyeongdon Kim
Sorry, re-send this email because of the Delivery failed message (to linux-kernel) On 2017-10-30 오후 10:22, Timofey Titovets wrote: 2017-10-30 15:03 GMT+03:00 Kyeongdon Kim : > The current ksm is using memcmp to insert and search 'rb_tree'. > It does cause very expensive comput

[PATCH] ksm : use checksum and memcmp for rb_tree

2017-10-30 Thread Kyeongdon Kim
d advantage for the power consumption than KSM default enable. Signed-off-by: Kyeongdon Kim --- mm/ksm.c | 49 + 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/mm/ksm.c b/mm/ksm.c index be8f457..66ab4f4 100644 --- a/mm/ksm.c +++ b/

Re: Re: [PATCH] mm/vmstats: add counters for the page frag cache

2017-09-08 Thread Kyeongdon Kim
On 2017-09-04 오후 5:30, Konstantin Khlebnikov wrote: On 04.09.2017 04:35, Kyeongdon Kim wrote: > Thanks for your reply, > But I couldn't find "NR_FRAGMENT_PAGES" in linux-next.git .. is that vmstat counter? or others? > I mean rather than adding bunch vmstat counters

[PATCH] selinux: Use kmem_cache for hashtab_node

2017-09-06 Thread Kyeongdon Kim
can reduce memory size 52byte(slack size/alloc count) per each struct. Signed-off-by: Kyeongdon Kim --- security/selinux/ss/hashtab.c | 17 +++-- security/selinux/ss/hashtab.h | 4 security/selinux/ss/services.c | 4 3 files changed, 23 insertions(+), 2 deletions

Re: Re: [PATCH] mm/vmstats: add counters for the page frag cache

2017-09-03 Thread Kyeongdon Kim
nnot use those memory debug tools. That's why those counters need.. and for much cheaper I can remove pgfrag_alloc_calls and pgfrag_free_calls. Thanks, Kyeongdon Kim On 2017-09-01 오후 6:21, Michal Hocko wrote: On Fri 01-09-17 12:12:36, Konstantin Khlebnikov wrote: > IMHO that's

Re: Re: [PATCH] mm/vmstats: add counters for the page frag cache

2017-09-03 Thread Kyeongdon Kim
ree) are enough to guess what will happen and would remove pgfrag_alloc_calls and pgfrag_free_calls. Thanks, Kyeongdon Kim On 2017-09-01 오후 6:12, Konstantin Khlebnikov wrote: IMHO that's too much counters. Per-node NR_FRAGMENT_PAGES should be enough for guessing what's going on. Perf pro

[PATCH] mm/vmstats: add counters for the page frag cache

2017-08-31 Thread Kyeongdon Kim
calculate for the amount of page. The gap between pgfrag_alloc_calls and pgfrag_free_calls is for sub-indicator. They can see trends of memory usage during the test. Without it, it's difficult to check page frag usage so I believe we should add it. Signed-off-by: Kyeongdon Kim --- include/

Re: Re: [PATCH] zram: revive swap_slot_free_notify

2016-03-31 Thread Kyeongdon Kim
LR is at swap_slot_free_notify+0x18/0x6c > [27833.995946] pc : [] lr : [] psr: 400f0113 > [27833.995946] sp : dd193d78 ip : c2deb1e4 fp : da015180 > [27833.995959] r10: r9 : 000200da r8 : c120fe08 > [27833.995968] r7 : r6 : r5 : c249a6c0 r4 : = > c249a6c

Re: Re: [PATCH v4 2/2] zram: try vmalloc() after kmalloc()

2015-12-21 Thread Kyeongdon Kim
s startup latency about 60-120ms in each case. >> > > Hello Kyeongdon, > > just to make sure, the patch works fine for you and we can move > forward and Cc -stable. correct? > > -ss > Hello Sergey, I was on vacation so I checked your email a moment ago, sorry about

Re: Re: [PATCH v3 2/2] zram: try vmalloc() after kmalloc()

2015-11-30 Thread Kyeongdon Kim
om zsmalloc() log message (test #3) : <4>[ 186.763605][1] KDKIM: zcomp_lz4_create: 24: ret = ffc00203 <4>[ 186.776652][1] KDKIM: zcomp_lz4_create: 24: ret = ffc0020f <4>[ 186.811423][1] KDKIM: zcomp_lz4_create: 24: ret = ffffffc002108000 <4>[ 186.816744][1]

Re: Re: [PATCH v3] zram: try vmalloc() after kmalloc()

2015-11-24 Thread Kyeongdon Kim
On 2015-11-24 오전 8:28, Minchan Kim wrote: > Hello Andrew, > > On Mon, Nov 23, 2015 at 02:52:26PM -0800, Andrew Morton wrote: >> On Mon, 23 Nov 2015 15:21:15 +0900 Kyeongdon Kim > wrote: >> >> > When we're using LZ4 multi compression streams for zram s

Re: Re: [PATCH v3] zram: try vmalloc() after kmalloc()

2015-11-23 Thread Kyeongdon Kim
Hello Andrew, On 2015-11-24 오전 7:52, Andrew Morton wrote: > On Mon, 23 Nov 2015 15:21:15 +0900 Kyeongdon Kim > wrote: > >> When we're using LZ4 multi compression streams for zram swap, >> we found out page allocation failure message in system running test. >> Tha

[PATCH v3] zram: try vmalloc() after kmalloc()

2015-11-22 Thread Kyeongdon Kim
4kB 0*2048kB 0*4096kB = 13796kB Signed-off-by: Kyeongdon Kim --- drivers/block/zram/zcomp_lz4.c | 12 ++-- drivers/block/zram/zcomp_lzo.c | 12 ++-- 2 files changed, 20 insertions(+), 4 deletions(-) diff --git a/drivers/block/zram/zcomp_lz4.c b/drivers/block/zram/zcomp_lz4.c index f2

[PATCH v2] zram: Prevent page allocation failure during zcomp_strm_alloc

2015-11-20 Thread Kyeongdon Kim
096kB = 13796kB Signed-off-by: Kyeongdon Kim --- drivers/block/zram/zcomp_lz4.c | 15 +-- drivers/block/zram/zcomp_lzo.c | 15 +-- 2 files changed, 26 insertions(+), 4 deletions(-) diff --git a/drivers/block/zram/zcomp_lz4.c b/drivers/block/zram/zcomp_lz4.c index f2afb7e..04