Re: [RFC PATCH 2/6] of: reserved-memory: Add of_reserved_mem_lookup_by_name

2025-07-30 Thread Krzysztof Kozlowski
On 30/07/2025 12:57, Viresh Kumar wrote: > On 30-07-25, 11:46, Krzysztof Kozlowski wrote: >> On 30/07/2025 11:29, Viresh Kumar wrote: >>> + struct device_node *child __free(device_node) = NULL; >> >> This should not be NULL or this should not be cleanup. Foll

Re: [RFC PATCH 6/6] virtio-msg: Add support for loopback bus

2025-07-30 Thread Krzysztof Kozlowski
On 30/07/2025 11:29, Viresh Kumar wrote: > Add a loopback bus implementation for the virtio-msg transport. > > This bus simulates a backend that echoes messages to itself, allowing > testing and development of virtio-msg without requiring an actual remote > backend or transport hardware. > > The

Re: [RFC PATCH 2/6] of: reserved-memory: Add of_reserved_mem_lookup_by_name

2025-07-30 Thread Krzysztof Kozlowski
On 30/07/2025 11:29, Viresh Kumar wrote: > This adds of_reserved_mem_lookup_by_name() helper to get a Add... > > +/** > + * of_reserved_mem_lookup_by_name() - acquire reserved_mem from node name > + * @name:node name > + * > + * This function allows drivers to acquire a reference to the re

Re: [PATCH v2 2/2] drivers: remoteproc: Add C906L controller for Sophgo CV1800B SoC

2025-07-30 Thread Krzysztof Kozlowski
On 30/07/2025 11:27, Junhui Liu wrote: > On 30/07/2025 08:46, Krzysztof Kozlowski wrote: >> On 28/07/2025 13:03, Junhui Liu wrote: >>> + >>> +static int cv1800b_c906l_mem_alloc(struct rproc *rproc, >>> + struct rproc_mem_entry *

Re: [PATCH v2 1/2] dt-bindings: remoteproc: Add C906L rproc for Sophgo CV1800B SoC

2025-07-29 Thread Krzysztof Kozlowski
On 30/07/2025 05:31, Junhui Liu wrote: > On 29/07/2025 08:27, Krzysztof Kozlowski wrote: >> On 28/07/2025 19:13, Junhui Liu wrote: >>>> >>>>> +description: >>>>> + This property is required only if the rpmsg/virtio functionality >

Re: [PATCH v2 2/2] drivers: remoteproc: Add C906L controller for Sophgo CV1800B SoC

2025-07-29 Thread Krzysztof Kozlowski
On 28/07/2025 13:03, Junhui Liu wrote: > + > +static int cv1800b_c906l_mem_alloc(struct rproc *rproc, > +struct rproc_mem_entry *mem) > +{ > + void __iomem *va; > + > + va = ioremap_wc(mem->dma, mem->len); > + if (!va) > + return -ENOMEM; > +

Re: [PATCH v2 1/2] dt-bindings: remoteproc: Add C906L rproc for Sophgo CV1800B SoC

2025-07-28 Thread Krzysztof Kozlowski
On 28/07/2025 19:13, Junhui Liu wrote: >> >>> +description: >>> + This property is required only if the rpmsg/virtio functionality is >>> used. >>> + (see mailbox/sophgo,cv1800b-mailbox.yaml) >>> +items: >>> + - description: mailbox channel to send data to C906L >>> + -

Re: [PATCH v2 1/2] dt-bindings: remoteproc: Add C906L rproc for Sophgo CV1800B SoC

2025-07-28 Thread Krzysztof Kozlowski
On 28/07/2025 13:03, Junhui Liu wrote: > + > + firmware-name: > +maxItems: 1 > + > + mbox-names: > +items: > + - const: tx > + - const: rx > + > + mboxes: First go mboxes, then mboxes-names. ALWAYS. > +description: > + This property is required only if the rpmsg/virt

Re: [PATCH v3 1/2] dt-bindings: remoteproc: qcom,milos-pas: Document remoteprocs

2025-07-21 Thread Krzysztof Kozlowski
On 21/07/2025 08:42, Peng Fan wrote: >> + >> + interrupt-names: >> +minItems: 6 >> +maxItems: 6 > > Ditto. > > Do you need to define the list? Did you read the entire binding? It reminds me Frank's comment as well - instead of actually checking you just ask question which you would fin

Re: [PATCH v4 0/5] remoteproc: imx_rproc: Support i.MX95

2025-07-18 Thread Krzysztof Kozlowski
On 18/07/2025 10:20, Peng Fan wrote: > On Thu, Jul 17, 2025 at 08:48:43AM -0600, Mathieu Poirier wrote: >> On Mon, Jul 14, 2025 at 11:52:05AM +, Peng Fan wrote: Subject: Re: [PATCH v4 0/5] remoteproc: imx_rproc: Support i.MX95 >>> [...] New warnings running 'make CHECK_DTBS=y fo

Re: [PATCH 3/3] dt-bindings: soc: qcom,rpmh-rsc: Remove double colon from description

2025-07-17 Thread Krzysztof Kozlowski
On 17/07/2025 08:54, Luca Weiss wrote: > No double colon is necessary in the description. Fix it. > > Reported-by: Rob Herring > Closes: https://lore.kernel.org/lkml/20250625150458.ga1182597-r...@kernel.org/ > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlow

Re: [PATCH 2/3] dt-bindings: interconnect: qcom: Remove double colon from description

2025-07-17 Thread Krzysztof Kozlowski
kernel.org/ > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/3] dt-bindings: clock: qcom: Remove double colon from description

2025-07-17 Thread Krzysztof Kozlowski
kernel.org/ > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 4/4] mmc: sdhci-brcmstb: rpmb sharing by claiming host for TZOS

2025-07-13 Thread Krzysztof Kozlowski
On 11/07/2025 17:42, Kamal Dasu wrote: > + > +static int sdhci_brcmstb_sdio_share_init(struct platform_device *pdev) > +{ > + struct sdhci_host *host = dev_get_drvdata(&pdev->dev); > + struct device_node *np = pdev->dev.of_node; > + struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host)

Re: [PATCH 3/4] dt-bindings: mmc: add brcmstb share register and hwlocks reference

2025-07-13 Thread Krzysztof Kozlowski
On 11/07/2025 17:42, Kamal Dasu wrote: > From: Kamal Dasu > > Adding optional controller share registers and hwspinlock reference fields > to be used by sdhci-brcmstb driver. > > Signed-off-by: Kamal Dasu > --- > .../bindings/mmc/brcm,sdhci-brcmstb.yaml | 29 +-- > 1 file

Re: [PATCH 1/4] dt-bindings: brcmstb-hwspinlock: support for hwspinlock

2025-07-13 Thread Krzysztof Kozlowski
On 11/07/2025 17:42, Kamal Dasu wrote: > From: Kamal Dasu > > Adding brcmstb_hwspinlock bindings. > > Signed-off-by: Kamal Dasu Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching

Re: [PATCH v2 2/4] dt-bindings: phy: qcom,snps-eusb2: document the Milos Synopsys eUSB2 PHY

2025-07-10 Thread Krzysztof Kozlowski
1 insertion(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/4] dt-bindings: usb: qcom,snps-dwc3: Add Milos compatible

2025-07-10 Thread Krzysztof Kozlowski
On Wed, Jul 09, 2025 at 11:18:15AM +0200, Luca Weiss wrote: > Document the Milos dwc3 compatible. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 3 +++ > 1 file changed, 3 insertions(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Document qcom,tune-res-fsdif

2025-07-09 Thread Krzysztof Kozlowski
On 09/07/2025 14:22, Luca Weiss wrote: > On Wed Jul 9, 2025 at 12:16 PM CEST, Krzysztof Kozlowski wrote: >> On 09/07/2025 11:40, Luca Weiss wrote: >>> Hi Krzysztof, >>> >>> On Tue Jul 8, 2025 at 10:31 AM CEST, Luca Weiss wrote: >>>> On Tue Jul 8,

Re: [PATCH v2 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip Interconnect in Qualcomm Milos SoC

2025-07-09 Thread Krzysztof Kozlowski
connect/qcom,milos-rpmh.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm RPMh Network-On-Chip Interconnect on Milos on Milos SoC Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Document qcom,tune-res-fsdif

2025-07-09 Thread Krzysztof Kozlowski
On 09/07/2025 11:40, Luca Weiss wrote: > Hi Krzysztof, > > On Tue Jul 8, 2025 at 10:31 AM CEST, Luca Weiss wrote: >> On Tue Jul 8, 2025 at 10:21 AM CEST, Krzysztof Kozlowski wrote: >>> On Tue, Jul 08, 2025 at 10:13:24AM +0200, Krzysztof Kozlowski wrote: >>>>

Re: [PATCH 2/4] regulator: dt-bindings: qcom,rpmh: Add PMR735B compatible

2025-07-08 Thread Krzysztof Kozlowski
> 1 file changed, 14 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] regulator: dt-bindings: qcom,rpmh: Add PM7550 compatible

2025-07-08 Thread Krzysztof Kozlowski
> 1 file changed, 21 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/4] dt-bindings: pinctrl: qcom,pmic-gpio: Add PMIV0104 support

2025-07-08 Thread Krzysztof Kozlowski
pmic-gpio.yaml | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: mfd: qcom,spmi-pmic: Document PMIV0104

2025-07-08 Thread Krzysztof Kozlowski
On Wed, Jun 25, 2025 at 11:18:02AM +0200, Luca Weiss wrote: > Add the PMIV0104 PMIC which is found on e.g. boards with SM7635 SoCs. s/SM7635/Milos/ SoCs. Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Document qcom,tune-res-fsdif

2025-07-08 Thread Krzysztof Kozlowski
On Tue, Jul 08, 2025 at 10:13:24AM +0200, Krzysztof Kozlowski wrote: > On Wed, Jun 25, 2025 at 11:14:56AM +0200, Luca Weiss wrote: > > Document the FS Differential TX Output Resistance Tuning value found on > > the eUSB2 repeater on Qualcomm PMICs. > > > >

Re: [PATCH 3/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Add compatible for PMIV0104

2025-07-08 Thread Krzysztof Kozlowski
On Wed, Jun 25, 2025 at 11:14:58AM +0200, Luca Weiss wrote: > Add a dt-bindings compatible string for the Qualcomm's PMIV0104 PMIC. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 1 + Acked-by: Krzysztof Kozl

Re: [PATCH 1/4] dt-bindings: phy: qcom,snps-eusb2-repeater: Document qcom,tune-res-fsdif

2025-07-08 Thread Krzysztof Kozlowski
On Wed, Jun 25, 2025 at 11:14:56AM +0200, Luca Weiss wrote: > Document the FS Differential TX Output Resistance Tuning value found on > the eUSB2 repeater on Qualcomm PMICs. > > Signed-off-by: Luca Weiss > --- > Documentation/devicetree/bindings/phy/qcom,snps-eusb2-repeater.yaml | 6 > ++ >

Re: [PATCH v2 1/2] dt-bindings: power: qcom,rpmpd: document the Milos RPMh Power Domains

2025-07-08 Thread Krzysztof Kozlowski
ocs, see maintainers soc profile). Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/2] pmdomain: qcom: rpmhpd: Add Milos power domains

2025-07-08 Thread Krzysztof Kozlowski
On Mon, Jul 07, 2025 at 04:42:13PM +0200, Casey Connolly wrote: > > > > diff --git a/drivers/pmdomain/qcom/rpmhpd.c > > > > b/drivers/pmdomain/qcom/rpmhpd.c > > > > index > > > > 078323b85b5648e33dd89e08cf31bdc5ab76d553..e09552a469264f28952fc46c3ab8c125e87310da > > > > 100644 > > > > --- a/drive

Re: [PATCH v2 3/4] dt-bindings: clock: qcom: document the Milos TCSR Clock Controller

2025-07-08 Thread Krzysztof Kozlowski
nsertion(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/4] dt-bindings: clock: qcom: Document the Milos RPMH Clock Controller

2025-07-08 Thread Krzysztof Kozlowski
nsertion(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 10/11] dt-bindings: clock: qcom: document the Milos Video Clock Controller

2025-07-04 Thread Krzysztof Kozlowski
On 04/07/2025 09:17, Luca Weiss wrote: > Add bindings documentation for the Milos (e.g. SM7635) Video Clock > Controller. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 08/11] dt-bindings: clock: qcom: document the Milos GPU Clock Controller

2025-07-04 Thread Krzysztof Kozlowski
On 04/07/2025 09:17, Luca Weiss wrote: > Add bindings documentation for the Milos (e.g. SM7635) Graphics Clock > Controller. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 06/11] dt-bindings: clock: qcom: document the Milos Display Clock Controller

2025-07-04 Thread Krzysztof Kozlowski
On 04/07/2025 09:16, Luca Weiss wrote: > Add bindings documentation for the Milos (e.g. SM7635) Display Clock > Controller. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 04/11] dt-bindings: clock: qcom: document the Milos Camera Clock Controller

2025-07-04 Thread Krzysztof Kozlowski
s-camcc.h | 131 > + > 2 files changed, 182 insertions(+) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 02/11] dt-bindings: clock: qcom: document the Milos Global Clock Controller

2025-07-04 Thread Krzysztof Kozlowski
s-gcc.h | 210 > + > 2 files changed, 272 insertions(+) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: pinctrl: document the Milos Top Level Mode Multiplexer

2025-07-03 Thread Krzysztof Kozlowski
On 03/07/2025 12:04, Konrad Dybcio wrote: > > > On 03-Jul-25 09:44, Luca Weiss wrote: >> On Thu Jul 3, 2025 at 9:41 AM CEST, Krzysztof Kozlowski wrote: >>> On Wed, Jul 02, 2025 at 05:56:16PM +0200, Luca Weiss wrote: >>>> Document the Top Level Mode Multiplexer

Re: [PATCH v2 1/2] dt-bindings: pinctrl: document the Milos Top Level Mode Multiplexer

2025-07-03 Thread Krzysztof Kozlowski
On 03/07/2025 09:44, Luca Weiss wrote: > On Thu Jul 3, 2025 at 9:41 AM CEST, Krzysztof Kozlowski wrote: >> On Wed, Jul 02, 2025 at 05:56:16PM +0200, Luca Weiss wrote: >>> Document the Top Level Mode Multiplexer on the Milos Platform. >> >> What is Milos platform? D

Re: [PATCH v2 1/2] dt-bindings: pinctrl: document the Milos Top Level Mode Multiplexer

2025-07-03 Thread Krzysztof Kozlowski
On Wed, Jul 02, 2025 at 05:56:16PM +0200, Luca Weiss wrote: > Document the Top Level Mode Multiplexer on the Milos Platform. What is Milos platform? Does it have some sort of model number how we usually expect? Wasn't this SM7325 or similar? The problem with such new naming that it awfully sounds

Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP

2025-07-02 Thread Krzysztof Kozlowski
On 01/07/2025 12:16, Luca Weiss wrote: >>>- if: >>>properties: >>> compatible: >>> @@ -185,6 +205,7 @@ allOf: >>> compatible: >>>contains: >>> enum: >>> + - qcom,sm7635-adsp-pas >>>- qcom,sm8550-adsp-pas >>>

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS

2025-07-02 Thread Krzysztof Kozlowski
On 01/07/2025 12:12, Luca Weiss wrote: > Hi Krzysztof, > > On Tue Jul 1, 2025 at 10:12 AM CEST, Krzysztof Kozlowski wrote: >> On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote: >>> @@ -91,6 +93,7 @@ allOf: >>>properties: >>>

Re: [PATCH v2 2/3] dt-bindings: remoteproc: qcom,sm8550-pas: document SM7635 ADSP & CDSP

2025-07-01 Thread Krzysztof Kozlowski
On Fri, Jun 27, 2025 at 08:55:43AM +0200, Luca Weiss wrote: > Document the ADSP & CDSP remoteprocs on the SM7635 Platform. > > Signed-off-by: Luca Weiss > --- > .../bindings/remoteproc/qcom,sm8550-pas.yaml | 37 > ++ > 1 file changed, 37 insertions(+) > > diff --git

Re: [PATCH v2 1/3] dt-bindings: remoteproc: qcom,sm8350-pas: document SM7635 MPSS & WPSS

2025-07-01 Thread Krzysztof Kozlowski
On Fri, Jun 27, 2025 at 08:55:42AM +0200, Luca Weiss wrote: > @@ -91,6 +93,7 @@ allOf: >properties: > compatible: >enum: > +- qcom,sm7635-mpss-pas > - qcom,sm8350-mpss-pas > - qcom,sm8450-mpss-pas > then: > @@ -142,6 +145,22 @@

Re: [PATCH v3 1/5] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-27 Thread Krzysztof Kozlowski
1 insertion(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 26/06/2025 12:19, Bryan O'Donoghue wrote: > On 26/06/2025 11:00, Krzysztof Kozlowski wrote: >>> + reg-names: >>> +items: >>> + - const: csi_clk_mux >> No, I already provided arguments in two lengthy discussions - this is >> not sorted by

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 13/06/2025 11:33, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Vincent Knecht > --- Also, still in

Re: [PATCH v4 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 06/06/2025 12:46, Vladimir Zapolskiy wrote: > Hello Vincent. > > On 6/2/25 20:27, Vincent Knecht via B4 Relay wrote: >> From: Vincent Knecht >> >> Add bindings for qcom,msm8939-camss in order to support the camera >> subsystem for MSM8939. >> >> Re

Re: [PATCH v5 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-26 Thread Krzysztof Kozlowski
On 13/06/2025 11:33, Vincent Knecht via B4 Relay wrote: > From: Vincent Knecht > > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Reviewed-by: Krzysztof Kozlowski Drop, you did here some unusual changes. > Signed-o

Re: [PATCH v2 1/3] dt-bindings: remoteproc: fsl,imx-rproc: Add support for i.MX95

2025-06-23 Thread Krzysztof Kozlowski
On 06/06/2025 03:55, Peng Fan (OSS) wrote: >fsl,entry-address: > $ref: /schemas/types.yaml#/definitions/uint32 > description: > @@ -78,6 +85,12 @@ properties: > description: >Phandle to IOMUXC GPR block which provide access to CM7 CPUWAIT bit. > > + fsl,lmm-id: > +

Re: [PATCH v2 2/4] dt-bindings: arm: qcom: Add MSM8976 BQ Aquaris X5 Plus

2025-06-16 Thread Krzysztof Kozlowski
On 15/06/2025 22:35, André Apitzsch via B4 Relay wrote: > From: André Apitzsch > > BQ Aquaris X5 Plus (Longcheer L9360) is a smartphone based on MSM8976 > SoC. > > Signed-off-by: André Apitzsch > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-06-02 Thread Krzysztof Kozlowski
const: vfe0 > + > + iommus: > +maxItems: 1 > + > + power-domains: > +items: > + - description: VFE GDSC - Video Front End, Global Distributed Switch > Controller. Wrap according to Linux coding style, so at 80. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 3/4] media: dt-bindings: Add qcom,msm8939-camss

2025-05-21 Thread Krzysztof Kozlowski
On Tue, May 20, 2025 at 08:39:08PM GMT, Vincent Knecht wrote: > Add bindings for qcom,msm8939-camss in order to support the camera > subsystem for MSM8939. > > Signed-off-by: Vincent Knecht > --- > .../bindings/media/qcom,msm8939-camss.yaml | 269 > + > 1 file change

Re: [PATCH] dt-bindings: pmem: Convert binding to YAML

2025-05-18 Thread Krzysztof Kozlowski
On 18/05/2025 05:55, Drew Fustini wrote: > Convert the PMEM device tree binding from text to YAML. This will allow > device trees with pmem-region nodes to pass dtbs_check. > > Signed-off-by: Drew Fustini > --- > .../devicetree/bindings/pmem/pmem-region.yaml | 49 +++ I don't see

Re: [PATCH 3/6] ASoC: dt-bindings: qcom,sm8250: Add Fairphone 4 sound card

2025-04-28 Thread Krzysztof Kozlowski
t; 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH] dt-bindings: remoteproc: qcom,sm8150-pas: Add missing SC8180X compatible

2025-04-28 Thread Krzysztof Kozlowski
AS. Fixes: 4b4ab93ddc5f ("dt-bindings: remoteproc: Consolidate SC8180X and SM8150 PAS files") Cc: Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml| 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/re

Re: [PATCH 2/6] dt-bindings: soc: qcom: add qcom,qcs615-imem compatible

2025-04-28 Thread Krzysztof Kozlowski
On Wed, Apr 23, 2025 at 05:17:38PM GMT, Lijuan Gao wrote: > Document qcom,qcs615-imem compatible. It has a child node for debugging > purposes. > > Signed-off-by: Lijuan Gao > --- > Documentation/devicetree/bindings/sram/qcom,imem.yaml | 1 + Acked-by: Krzysztof Kozlow

Re: [PATCH 1/6] dt-bindings: remoteproc: qcom,sm8150-pas: Document QCS615 remoteproc

2025-04-28 Thread Krzysztof Kozlowski
cdsp-pas > -- qcom,sc8180x-slpi-pas This needs fixes, but it is not related to this patch. I'll send a fix but might conflict in first diff chunk. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v1 1/7] mfd: stmpe-spi: Correct the name used in MODULE_DEVICE_TABLE

2025-04-27 Thread Krzysztof Kozlowski
ror generated. Reviewed-by: Krzysztof Kozlowski P.S. You can trim the error messages to relevant parts, e.g. "1 error generated" is really redundant and not needed to store in git history. > Best regards, Krzysztof

Re: [PATCH 3/3] arm64: dts: qcom: sdm632-fairphone-fp3: Add AW8898 amplifier

2025-04-06 Thread Krzysztof Kozlowski
On 06/04/2025 15:03, Luca Weiss wrote: > Add a node for the amplifier found on Fairphone 3, receiving sound via > I2S from the SoC and being connected to the speaker. > > Signed-off-by: Luca Weiss > --- Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 2/3] ASoC: codecs: Add aw8898 amplifier driver

2025-04-06 Thread Krzysztof Kozlowski
On 06/04/2025 15:03, Luca Weiss wrote: > +static const struct i2c_device_id aw8898_id[] = { > + { "aw8898" }, > + { /* sentinel */ } > +}; > +MODULE_DEVICE_TABLE(i2c, aw8898_id); > + > +static const struct of_device_id aw8898_of_match[] = { > + { .compatible = "awinic,aw8898" }, > +

Re: [PATCH 1/3] ASoC: dt-bindings: Document Awinic AW8898 amplifier

2025-04-06 Thread Krzysztof Kozlowski
; + - reg > + - reset-gpios Some or all of the supplies should be required. > + - "#sound-dai-cells" > + > +additionalProperties: false and this 'unevaluatedProperties: false' instead. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 0/2] Add vcp driver

2025-04-06 Thread Krzysztof Kozlowski
On 06/04/2025 10:05, Xiangzhi Tang (唐相志) wrote: > On Wed, 2025-04-02 at 12:31 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 02/04/2025 11:19, Xia

Re: [PATCH 2/2] remoterpoc: mediatek: vcp: Add vcp remoteproc driver

2025-04-06 Thread Krzysztof Kozlowski
On 06/04/2025 09:29, Xiangzhi Tang (唐相志) wrote: > On Wed, 2025-04-02 at 13:16 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> Please kindly trim the replies from un

Re: [PATCH 1/2] dt-bindings: remoteproc: Add VCP support for mt8196

2025-04-06 Thread Krzysztof Kozlowski
On 06/04/2025 08:46, Xiangzhi Tang (唐相志) wrote: > On Wed, 2025-04-02 at 13:11 +0200, Krzysztof Kozlowski wrote: >> External email : Please do not click links or open attachments until >> you have verified the sender or the content. >> >> >> On 02/0

Re: [PATCH 1/2] dt-bindings: remoteproc: Add VCP support for mt8196

2025-04-05 Thread Krzysztof Kozlowski
On 02/04/2025 11:19, Xiangzhi Tang wrote: > + > +description: > + The MediaTek VCP enables the SoC control the MediaTek Video Companion > Risc-V coprocessor. Wrap at coding style. > + > +properties: > + compatible: > +enum: > + - mediatek,mt8196-vcp > + > + reg: > +items: > +

Re: [PATCH 2/2] remoterpoc: mediatek: vcp: Add vcp remoteproc driver

2025-04-05 Thread Krzysztof Kozlowski
On 02/04/2025 11:19, Xiangzhi Tang wrote: > Add host driver to control the mediatek Risc-V coprocessor > > 1.Support rproc mechanism to load vcm firmware from filesystem > 2.Support SMC services to request ATF to setting vcp boot sequence > 3.Host communicated with VCP depends on VCP IPC interface

Re: [PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-04-05 Thread Krzysztof Kozlowski
On 24/03/2025 19:00, David Heidelberg wrote: > On 10/03/2025 10:45, Krzysztof Kozlowski wrote: >> On Sat, Mar 08, 2025 at 03:08:37PM +0100, David Heidelberg wrote: >>> From: Caleb Connolly >>> >>> This new property allows devices to specify some register values

Re: [PATCH v4 1/7] dt-bindings: input: syna,rmi4: Document syna,rmi4-s3706b-i2c

2025-04-04 Thread Krzysztof Kozlowski
- syna,rmi4-i2c > + - syna,rmi4-spi > + - items: > + - enum: > + - syna,rmi4-s3706b-i2c # OnePlus 6/6T Drop i2c suffix. With that: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH 0/2] Add vcp driver

2025-04-02 Thread Krzysztof Kozlowski
On 02/04/2025 11:19, Xiangzhi Tang wrote: > Add support MediaTek's Video Companion Processor(VCP) host driver to > control the MediaTek VCP Risc-V coprocessor. > The VCP host driver using rproc mechanism to load vcm firmware > from filesystem, and using SMC services to request ATF to setting > vcp

Re: [PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-03-26 Thread Krzysztof Kozlowski
On 25/03/2025 14:23, Caleb Connolly wrote: > > > On 3/25/25 08:36, Krzysztof Kozlowski wrote: >> On 24/03/2025 19:00, David Heidelberg wrote: >>> On 10/03/2025 10:45, Krzysztof Kozlowski wrote: >>>> On Sat, Mar 08, 2025 at 03:08:37PM +0100, David Heidelbe

Re: [PATCH 1/4] dt-bindings: remoteproc: mediatek: Add missing minItems for 8192/8195

2025-03-19 Thread Krzysztof Kozlowski
On 18/03/2025 23:22, Nícolas F. R. A. Prado wrote: > Both MT8192 and MT8195 have an L1TCM memory, so it should be described > in reg, and therefore reg's minItems should be 3, as is already implicit > by reg-names. Override minItems to 3 for MT8192 and MT8195. I think that was the original intenti

Re: [PATCH 2/4] dt-bindings: remoteproc: mediatek: Remove l1tcm for dual-core MT8188 SCP

2025-03-19 Thread Krzysztof Kozlowski
g-names to 1, since as this is a multi-core SCP with no > L1TCM memory, only the CFG memory region is present in the parent node. > > Fixes: 91e0d560b9fd ("dt-bindings: remoteproc: mediatek: Support MT8188 > dual-core SCP") > Signed-off-by: Nícolas F. R. A. Prado Reviewed-b

Re: [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Document FT8716 support

2025-03-14 Thread Krzysztof Kozlowski
On Thu, Mar 13, 2025 at 09:20:16PM +0100, Jens Reidel wrote: > Document FocalTech FT8716 support by adding the compatible. > > Signed-off-by: Jens Reidel > --- > .../devicetree/bindings/input/touchscreen/edt-ft5x06.yaml| 1 + > 1 file changed, 1 insertion(+) A

Re: [PATCH v3 1/7] dt-bindings: input: syna,rmi4: document syna,pdt-fallback-desc

2025-03-11 Thread Krzysztof Kozlowski
On Sat, Mar 08, 2025 at 03:08:37PM +0100, David Heidelberg wrote: > From: Caleb Connolly > > This new property allows devices to specify some register values which > are missing on units with third party replacement displays. These > displays use unofficial touch ICs which only implement a subset

Re: [PATCH v2 2/3] media: dt-bindings: Add LC898217XC documentation

2025-03-04 Thread Krzysztof Kozlowski
On Tue, Mar 04, 2025 at 10:32:19PM +0300, Vasiliy Doylov wrote: > +required: > + - compatible > + - reg > + - vcc-supply > + > +additionalProperties: false > + > +examples: > + - | > + If there is going to be resend/new version: drop above blank line. Re

Re: [PATCH v2 1/3] MAINTAINERS: Add entry for Onsemi LC898217XC lens voice coil driver

2025-03-04 Thread Krzysztof Kozlowski
On Tue, Mar 04, 2025 at 10:32:18PM +0300, Vasiliy Doylov wrote: > Add entry for Onsemi LC898217XC lens voice coil driver > > Signed-off-by: Vasiliy Doylov > --- > MAINTAINERS | 8 > 1 file changed, 8 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index > 29e1a423eee5bcf9df

Re: [PATCH net-next v3 3/3] ieee802154: ca8210: Switch to using gpiod API

2025-03-04 Thread Krzysztof Kozlowski
On Tue, Mar 04, 2025 at 01:22:34PM +0200, Andy Shevchenko wrote: > This updates the driver to gpiod API, and removes yet another use of > of_get_named_gpio(). > > With this, invert the logic of the reset pin which is active low > and add a quirk for the legacy and incorrect device tree description

[PATCH v2] dt-bindings: remoteproc: qcom,sm6115-pas: Use recommended MBN firmware format in DTS example

2025-02-26 Thread Krzysztof Kozlowski
All Qualcomm firmwares uploaded to linux-firmware are in MBN format, instead of split MDT. No functional changes, just correct the DTS example so people will not rely on unaccepted files. Signed-off-by: Krzysztof Kozlowski --- .../devicetree/bindings/remoteproc/qcom,sm6115-pas.yaml | 2

Re: [PATCH 2/2] input/touchscreen: imagis: document ist3038h

2025-02-24 Thread Krzysztof Kozlowski
On 24/02/2025 10:03, Andras Sebok wrote: > Signed-off-by: Andras Sebok > --- > .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory yo

[PATCH RFC v2 2/2] remoteproc: qcom: pas: Add SM8750 MPSS

2025-02-21 Thread Krzysztof Kozlowski
Add remote processor PAS loaders for SM8750 MPSS (modem), which differs from SM8650 by lack of fifth memory region for Qlink Logging. Signed-off-by: Krzysztof Kozlowski --- Changes in v2: None --- drivers/remoteproc/qcom_q6v5_pas.c | 25 + 1 file changed, 25 insertions

[PATCH v3] dt-bindings: remoteproc: Add SM8750 CDSP

2025-02-21 Thread Krzysztof Kozlowski
Add remote processor PAS loader for SM8750 CDSP processor, compatible with earlier SM8650 with minor difference: one more sixth shutdown interrupt. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Changesin v3: 1. Split MPSS into separate patch, keep the ack. v2: https

[PATCH RFC v2 1/2] dt-bindings: remoteproc: Add SM8750 MPSS

2025-02-21 Thread Krzysztof Kozlowski
memory region as well. There might be other differences against SM8650, because the modem currently crashes after starting. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Changes in v2: Split from previous MPSS+CDSP: https://lore.kernel.org/all/20250220154132.199358-1

Re: [RESEND PATCH 1/2] dt-bindings: remoteproc: Add SM8750 MPSS and CDSP

2025-02-21 Thread Krzysztof Kozlowski
On 20/02/2025 16:41, Krzysztof Kozlowski wrote: > Add remote processor PAS loaders for SM8750 MPSS (modem) and CDSP > processors. Both are compatible with earlier SM8650 with minor > differences: > 1. SM8750 CDSP has one more sixth shutdown interrupt. > 2. SM8750 MPSS lacks fift

[RESEND PATCH 2/2] remoteproc: qcom: pas: Add SM8750 MPSS

2025-02-20 Thread Krzysztof Kozlowski
Add remote processor PAS loaders for SM8750 MPSS (modem), which differs from SM8650 by lack of fifth memory region for Qlink Logging. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/qcom_q6v5_pas.c | 25 + 1 file changed, 25 insertions(+) diff --git a/drivers

[RESEND PATCH 1/2] dt-bindings: remoteproc: Add SM8750 MPSS and CDSP

2025-02-20 Thread Krzysztof Kozlowski
. There might be other differences, because the modem currently crashes after starting. Acked-by: Conor Dooley Signed-off-by: Krzysztof Kozlowski --- Resend after some time. --- .../bindings/remoteproc/qcom,sm8550-pas.yaml | 46 +-- 1 file changed, 42 insertions(+), 4 deletions

Re: [PATCH] dt-bindings: hwlock: Convert to dtschema

2025-02-18 Thread Krzysztof Kozlowski
s specific to that > + platform. > + > +maintainers: > + - Bjorn Andersson > + - Rob Herring > + - Krzysztof Kozlowski > + - Conor Dooley Subsystem maintainer only. > + > +properties: > + $nodename: > +pattern: "^hwlock(@.*)?" Why .* in the pattern if

Re: [PATCH 1/2] dt-bindings: arm: qcom: Add Lenovo Xiaoxin Pad Pro 2021

2025-02-17 Thread Krzysztof Kozlowski
t; 1 file changed, 1 insertion(+) Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/2] dt-bindings: remoteproc: qcom,wcnss-pil: Add support for single power-domain platforms

2025-02-11 Thread Krzysztof Kozlowski
reword commit message, expand based on feedback from > Stephan Gerhold] > Signed-off-by: Luca Weiss > --- > .../bindings/remoteproc/qcom,wcnss-pil.yaml| 45 > +- > 1 file changed, 36 insertions(+), 9 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v3 1/2] dt-bindings: media: i2c: Add DW9719 and DW9761 VCM

2025-02-11 Thread Krzysztof Kozlowski
On Sun, Feb 09, 2025 at 10:51:57PM +0100, André Apitzsch wrote: > Document Dongwoon DW9719 and DW9761 VCM devicetree bindings. > > Signed-off-by: André Apitzsch > --- > .../bindings/media/i2c/dongwoon,dw9719.yaml| 45 > ++ > 1 file changed, 45 insertions(+) > > diff

Re: [PATCH v3 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets

2025-02-02 Thread Krzysztof Kozlowski
On Mon, Feb 03, 2025 at 09:34:24AM +0300, Alexey Minnekhanov wrote: > Add resets for eMMC/SD card blocks that were missed during initial > driver submission. > > Signed-off-by: Alexey Minnekhanov > --- Acked-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets

2025-01-30 Thread Krzysztof Kozlowski
On 30/01/2025 12:29, Alexey Minnekhanov wrote: > On 1/30/25 11:35 AM, Krzysztof Kozlowski wrote: >> On Thu, Jan 30, 2025 at 12:23:25AM +0300, Alexey Minnekhanov wrote: >>> Add resets for eMMC/SD card blocks that were missed during initial >>> driver submission. &g

Re: [PATCH v2 1/3] dt-bindings: clock: gcc-sdm660: Add missing SDCC resets

2025-01-30 Thread Krzysztof Kozlowski
On Thu, Jan 30, 2025 at 12:23:25AM +0300, Alexey Minnekhanov wrote: > Add resets for eMMC/SD card blocks that were missed during initial > driver submission. > > Signed-off-by: Alexey Minnekhanov > Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for > SDM660") Your SoB

Re: [PATCH 1/2] clk: qcom: gcc-sdm660: Add missing SDCC block resets

2025-01-29 Thread Krzysztof Kozlowski
On 29/01/2025 21:52, Alexey Minnekhanov wrote: > On 1/29/25 10:06 PM, Krzysztof Kozlowski wrote: >> >> No line breaks between tags (see `git log`). >> > > Will fix in v2. > >> >>> include/dt-bindings/clock/qcom,gcc-sdm660.h | 2 ++ >> >>

Re: [PATCH 1/2] clk: qcom: gcc-sdm660: Add missing SDCC block resets

2025-01-29 Thread Krzysztof Kozlowski
On 29/01/2025 18:18, Alexey Minnekhanov wrote: > This will allow linux to properly reset eMMC/SD blocks. > > Fixes: f2a76a2955c0 ("clk: qcom: Add Global Clock controller (GCC) driver for > SDM660") > No line breaks between tags (see `git log`). > Signed-off-by: Alexey Minnekhanov > --- > in

Re: [PATCH 1/2] dt-bindings: remoteproc: qcom,wcnss-pil: Add support for single power-domain platforms

2025-01-29 Thread Krzysztof Kozlowski
On 29/01/2025 18:51, Luca Weiss wrote: > From: Matti Lehtimäki > > Support platforms such as MSM8226 and MSM8974 with only one power rail > (CX) modelled as power domain while MX and PX are regulators. > > Signed-off-by: Matti Lehtimäki > [luca: reword commit message] > Signed-off-by: Luca Weis

Re: [PATCH v3 03/13] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8926

2025-01-27 Thread Krzysztof Kozlowski
gt; +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 2/9] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8226

2025-01-26 Thread Krzysztof Kozlowski
aml | 26 > -- > 1 file changed, 24 insertions(+), 2 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

Re: [PATCH v2 1/9] dt-bindings: remoteproc: qcom,msm8916-mss-pil: Support platforms with one power domain

2025-01-26 Thread Krzysztof Kozlowski
gs/remoteproc/qcom,msm8916-mss-pil.yaml | 34 > +++--- > 1 file changed, 30 insertions(+), 4 deletions(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof

[PATCH 2/5] remoteproc: omap: Simplify returning syscon PTR_ERR

2025-01-11 Thread Krzysztof Kozlowski
No need to store PTR_ERR into temporary, local 'ret' variable. Signed-off-by: Krzysztof Kozlowski --- drivers/remoteproc/omap_remoteproc.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_re

  1   2   3   4   5   6   7   8   9   10   >