Hi,
On Fri, 2020-09-25 at 15:06 +0200, Miroslav Benes wrote:
> Hi Kristen,
>
> On Wed, 23 Sep 2020, Kristen Carlson Accardi wrote:
>
> > Function Granular Kernel Address Space Layout Randomiz
modules, forcing the algorithm
to require that only unique symbols are allowed to be patched.
Signed-off-by: Kristen Carlson Accardi
---
kernel/livepatch/core.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index f76fdb925532
together for the future by ensuring that if
CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected when used with
CONFIG_FG_KASLR the function sections will not be consolidated back
into .text. Thanks to Kees Cook for the dead code elimination changes.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by
fter
textdata bss dec hex filename
8842314 468 178320 9021102 89a6ae vmlinux.before
8842240 468 178320 9021028 89a664 vmlinux.after
Signed-off-by: Kees Cook
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/boot/compressed/kaslr.c | 4
arch/x86/boot/compre
end of the text section and the
orphaned sections, _etext must be moved so that it is after both
.text and .text.* The text size must also be calculated to
include .text AND .text.*
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
Reviewed-by: Kees Cook
---
Kees Cook
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/lib/kaslr.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c
index a53665116458..2b3eb8c948a3 100644
--- a/arch/x86/lib/kaslr.c
+++ b/arch/x86/lib/kaslr.c
On Wed, 2020-07-22 at 16:33 -0500, Josh Poimboeuf wrote:
> On Wed, Jul 22, 2020 at 12:56:10PM -0700, Kristen Carlson Accardi
> wrote:
> > On Wed, 2020-07-22 at 12:42 -0700, Kees Cook wrote:
> > > On Wed, Jul 22, 2020 at 11:07:30AM -0500, Josh Poimboeuf wrote:
> > > &
When getting the symbol index number, make sure to use the
extended symbol table information in order to support symbol
index's greater than 64K.
Signed-off-by: Kristen Carlson Accardi
---
tools/objtool/orc_dump.c | 20
1 file changed, 16 insertions(+), 4 deletions(-)
On Tue, 2020-08-04 at 14:23 -0400, Joe Lawrence wrote:
> On Fri, Jul 17, 2020 at 09:59:57AM -0700, Kristen Carlson Accardi
> wrote:
> > Function Granular Kernel Address Space Layout Randomization
On Fri, 2020-08-07 at 10:20 -0700, Kees Cook wrote:
> On Fri, Aug 07, 2020 at 09:38:11AM -0700, Kristen Carlson Accardi
> wrote:
> > Thanks for testing. Yes, Josh and I have been discussing the
> > orc_unwind
> > issues. I've root caused one issue already,
On Tue, 2020-08-04 at 14:23 -0400, Joe Lawrence wrote:
> On Fri, Jul 17, 2020 at 09:59:57AM -0700, Kristen Carlson Accardi
> wrote:
> > Function Granular Kernel Address Space Layout Randomization
Hi Mingo, thanks for taking a look, I am glad you like the idea. Some
replies below:
On Thu, 2020-08-06 at 17:32 +0200, Ingo Molnar wrote:
> * Kristen Carlson Accardi wrote:
>
> > Function Granular Kernel Address Space Layout Randomization
On Wed, 2020-07-22 at 12:42 -0700, Kees Cook wrote:
> On Wed, Jul 22, 2020 at 11:07:30AM -0500, Josh Poimboeuf wrote:
> > On Wed, Jul 22, 2020 at 07:39:55AM -0700, Kees Cook wrote:
> > > On Wed, Jul 22, 2020 at 11:27:30AM +0200, Miroslav Benes wrote:
> > > > Let me CC live-patching ML, because from
On Wed, 2020-07-22 at 10:56 -0400, Joe Lawrence wrote:
> On 7/22/20 10:51 AM, Joe Lawrence wrote:
> > On 7/22/20 10:39 AM, Kees Cook wrote:
> > > On Wed, Jul 22, 2020 at 11:27:30AM +0200, Miroslav Benes wrote:
> > > > Let me CC live-patching ML, because from a quick glance this is
> > > > something
On Sun, 2020-07-19 at 18:25 -0700, Kees Cook wrote:
> On Fri, Jul 17, 2020 at 10:00:06AM -0700, Kristen Carlson Accardi
> wrote:
> > This patch makes /proc/kallsyms display in a random order, rather
> > than sorted by address in order to hide the newly randomized
> > add
end of the text section and the
orphaned sections, _etext must be moved so that it is after both
.text and .text.* The text size must also be calculated to
include .text AND .text.*
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
Reviewed-by: Kees Cook
---
together for the future by ensuring that if
CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected when used with
CONFIG_FG_KASLR the function sections will not be consolidated back
into .text. Thanks to Kees Cook for the dead code elimination changes.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by
fter
textdata bss dec hex filename
8842314 468 178320 9021102 89a6ae vmlinux.before
8842240 468 178320 9021028 89a664 vmlinux.after
Signed-off-by: Kees Cook
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/boot/compressed/kaslr.c | 4
arch/x86/boot/compre
Kees Cook
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/lib/kaslr.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c
index a53665116458..2b3eb8c948a3 100644
--- a/arch/x86/lib/kaslr.c
+++ b/arch/x86/lib/kaslr.c
Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
Reviewed-by: Kees Cook
---
arch/x86/boot/compressed/Makefile | 7 +-
arch/x86/tools/relocs.c | 41 ---
arch/x86/tools/relocs.h | 4 +--
arch/x86/tools/relocs_common.c| 15
g relocations, but since
it is expected to be sorted by address, it will need to be resorted.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
Reviewed-by: Kees Cook
---
.../admin-guide/kernel-parameters.txt | 7 +
Documentation/security/fgkaslr.rst
elf file to read the extended symbol table info, and then
replace all direct references to st_shndx with calls to sym_index(),
which will determine whether the value can be read directly or
whether the value should be pulled out of the extended table.
Signed-off-by: Kristen Carlson Accardi
Reviewed
CONFIG_FG_KASLR is
selected.
If a module has functions split out into separate text sections
(i.e. compiled with the -ffunction-sections flag), reorder the
functions to provide some code diversification to modules.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Kees Cook
Acked-by: Ard Biesheuvel
This patch makes /proc/kallsyms display in a random order, rather
than sorted by address in order to hide the newly randomized address
layout.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
kernel/kallsyms.c | 163
If a .cold function is examined prior to it's parent, the link
to the parent/child function can be overwritten when the parent
is examined. Only update pfunc and cfunc if they were previously
nil to prevent this from happening.
Signed-off-by: Kristen Carlson Accardi
Acked-by: Josh Poim
et al.
For more information on how function layout impacts performance, see:
Optimizing Function Placement for Large-Scale Data-Center Applications,
G. Ottoni, B. Maher
Kees Cook (2):
x86/boot: Allow a "silent" kaslr random byte fetch
x86/boot/compressed: Avoid duplicate malloc(
On Tue, 2020-07-07 at 23:16 +, Luck, Tony wrote:
> > Signed-off-by: Kristen Carlson Accardi
> > Reviewed-by: Tony Luck
> > Tested-by: Tony Luck
>
> I'll happily review and test again ... but since you've made
> substantive
> changes, you should drop
On Wed, 2020-06-24 at 08:18 -0700, Kees Cook wrote:
> On Wed, Jun 24, 2020 at 12:21:16PM +0200, Jann Horn wrote:
> > On Tue, Jun 23, 2020 at 7:26 PM Kristen Carlson Accardi
> > wrote:
> > > This patch makes /proc/kallsyms display alphabetically by symbol
> > > n
On Wed, 2020-06-24 at 08:18 -0700, Kees Cook wrote:
> On Wed, Jun 24, 2020 at 12:21:16PM +0200, Jann Horn wrote:
> > On Tue, Jun 23, 2020 at 7:26 PM Kristen Carlson Accardi
> > wrote:
> > > This patch makes /proc/kallsyms display alphabetically by symbol
> > > n
or more information on how function layout impacts performance, see:
Optimizing Function Placement for Large-Scale Data-Center Applications,
G. Ottoni, B. Maher
Kees Cook (1):
x86/boot: Allow a "silent" kaslr random byte fetch
Kristen Carlson Accardi (9):
objtool: Do not assume order
g relocations, but since
it is expected to be sorted by address, it will need to be resorted.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
Documentation/security/fgkaslr.rst | 173 +
Documentation/security/index.rst | 1 +
arch/x86/boot/co
CONFIG_FG_KASLR is
selected.
If a module has functions split out into separate text sections
(i.e. compiled with the -ffunction-sections flag), reorder the
functions to provide some code diversification to modules.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Kees Cook
Acked-by: Ard Biesheuvel
elf file to read the extended symbol table info, and then
replace all direct references to st_shndx with calls to sym_index(),
which will determine whether the value can be read directly or
whether the value should be pulled out of the extended table.
Signed-off-by: Kristen Carlson Accardi
Reviewed
Kees Cook
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/lib/kaslr.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c
index a53665116458..2b3eb8c948a3 100644
--- a/arch/x86/lib/kaslr.c
+++ b/arch/x86/lib/kaslr.c
In preparation for changes to the upcoming fgkaslr commit, change misc.c
to not define STATIC as static, but instead set STATIC to "". This allows
memptr to become accessible to multiple files.
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/boot/compressed/kaslr.c | 4
arc
Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
Reviewed-by: Kees Cook
---
arch/x86/boot/compressed/Makefile | 7 +-
arch/x86/tools/relocs.c | 41 ---
arch/x86/tools/relocs.h | 4 +--
arch/x86/tools/relocs_common.c| 15
end of the text section and the
orphaned sections, _etext must be moved so that it is after both
.text and .text.* The text size must also be calculated to
include .text AND .text.*
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
arch/x86/kernel/vmlinux
together for the future by ensuring that if
CONFIG_LD_DEAD_CODE_DATA_ELIMINATION is selected when used with
CONFIG_FG_KASLR the function sections will not be consolidated back
into .text. Thanks to Kees Cook for the dead code elimination changes.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by
This patch makes /proc/kallsyms display alphabetically by symbol
name rather than sorted by address in order to hide the newly
randomized address layout.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
kernel/kallsyms.c | 128
If a .cold function is examined prior to it's parent, the link
to the parent/child function can be overwritten when the parent
is examined. Only update pfunc and cfunc if they were previously
nil to prevent this from happening.
Signed-off-by: Kristen Carlson Accardi
Acked-by: Josh Poim
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: e000acc145928693833f09152244242a678d3cd5
Gitweb:
https://git.kernel.org/tip/e000acc145928693833f09152244242a678d3cd5
Author:Kristen Carlson Accardi
AuthorDate:Wed, 15 Apr 2020 14:04:43
On Tue, 2020-06-09 at 13:42 -0700, Kees Cook wrote:
> On Tue, Jun 09, 2020 at 01:14:04PM -0700, Kristen Carlson Accardi
> wrote:
> > On Thu, 2020-05-21 at 14:33 -0700, Kees Cook wrote:
> > > Oh! And I am reminded suddenly about CONFIG_FG_KASLR needing to
> > >
On Thu, 2020-05-21 at 14:33 -0700, Kees Cook wrote:
> Oh! And I am reminded suddenly about CONFIG_FG_KASLR needing to
> interact
> correctly with CONFIG_LD_DEAD_CODE_DATA_ELIMINATION in that we do NOT
> want the sections to be collapsed at link time:
sorry - I'm a little confused and was wondering
On Thu, 2020-05-21 at 14:08 -0700, Kees Cook wrote:
> On Thu, May 21, 2020 at 09:56:38AM -0700, Kristen Carlson Accardi
> wrote:
> > At boot time, find all the function sections that have separate
> > .text
> > sections, shuffle them, and then copy them to new locations. Ad
On Thu, 2020-05-21 at 16:30 -0700, Kees Cook wrote:
> On Fri, May 22, 2020 at 12:26:30AM +0200, Thomas Gleixner wrote:
> > I understand how this is supposed to work, but I fail to find an
> > explanation how all of this is preserving the text subsections we
> > have,
> > i.e. .kprobes.text, .entry.
Hi Kees,
Thanks for your review - I will incorporate what I can into v3, or
explain why not once I give it a try :).
On Thu, 2020-05-21 at 14:08 -0700, Kees Cook wrote:
> >
> On Thu, May 21, 2020 at 09:56:38AM -0700, Kristen Carlson Accardi
> wrote:
> > + /*
> >
At boot time, find all the function sections that have separate .text
sections, shuffle them, and then copy them to new locations. Adjust
any relocations accordingly.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
Documentation/security/fgkaslr.rst
Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
arch/x86/boot/compressed/Makefile | 7 +++-
arch/x86/tools/relocs.c | 55 ---
arch/x86/tools/relocs.h | 4 +--
arch/x86/tools/relocs_common.c| 15 ++---
4 files changed, 62
Allow user to select CONFIG_FG_KASLR if dependencies are met. Change
the make file to build with -ffunction-sections if CONFIG_FG_KASLR
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
Makefile | 4
arch/x86/Kconfig | 13 +
2
end of the text section and the
orphaned sections, _etext must be moved so that it is after both
.text and .text.* The text size must also be calculated to
include .text AND .text.*
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
arch/x86/kernel/vmlinux
CONFIG_FG_KASLR is
selected.
If a module has functions split out into separate text sections
(i.e. compiled with the -ffunction-sections flag), reorder the
functions to provide some code diversification to modules.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Kees Cook
Acked-by: Ard Biesheuvel
This patch makes /proc/kallsyms display alphabetically by symbol
name rather than sorted by address in order to hide the newly
randomized address layout.
Signed-off-by: Kristen Carlson Accardi
Reviewed-by: Tony Luck
Tested-by: Tony Luck
---
kernel/kallsyms.c | 138
setto, et al.
For more information on how function layout impacts performance, see:
Optimizing Function Placement for Large-Scale Data-Center Applications,
G. Ottoni, B. Maher
Kees Cook (1):
x86/boot: Allow a "silent" kaslr random byte fetch
Kristen Carlson Accardi (8):
objtool:
If a .cold function is examined prior to it's parent, the link
to the parent/child function can be overwritten when the parent
is examined. Only update pfunc and cfunc if they were previously
nil to prevent this from happening.
Signed-off-by: Kristen Carlson Accardi
Acked-by: Josh Poim
Kees Cook
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/lib/kaslr.c | 18 --
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/x86/lib/kaslr.c b/arch/x86/lib/kaslr.c
index a53665116458..2b3eb8c948a3 100644
--- a/arch/x86/lib/kaslr.c
+++ b/arch/x86/lib/kaslr.c
elf file to read the extended symbol table info, and then
replace all direct references to st_shndx with calls to sym_index(),
which will determine whether the value can be read directly or
whether the value should be pulled out of the extended table.
Signed-off-by: Kristen Carlson Accardi
Reviewed
nd no significant performance impact.
Suggested-by: Alan Cox
Signed-off-by: Kristen Carlson Accardi
---
arch/x86/Kconfig| 9 +
arch/x86/entry/common.c | 18 ++
2 files changed, 27 insertions(+)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 1a0be022f91d..bde978e
https://bugzilla.redhat.com/show_bug.cgi?id=1271225
> against Fedora to remove the 94cpufreq file that causes the problem. It
> should be noted that pm-utils is obsoleted with newer versions of systemd.
>
> Cc: Kristen Carlson Accardi
> Cc: "Rafael J. Wysocki"
> Cc: Vi
Commit-ID: a7adb91b13c104e5ad950fbe1795aa2722f2ea0a
Gitweb: http://git.kernel.org/tip/a7adb91b13c104e5ad950fbe1795aa2722f2ea0a
Author: Kristen Carlson Accardi
AuthorDate: Tue, 22 Sep 2015 10:51:36 -0700
Committer: Ingo Molnar
CommitDate: Wed, 23 Sep 2015 09:57:24 +0200
x86/cpufeatures
0
>
> Fix this problem by 2 steps:
> 1.Normalize the user input to [min_policy, max_policy].
> 2.Make sure max_perf_pct>=min_perf_pct, suggested by Seiichi Ikarashi.
>
> Signed-off-by: Chen Yu
Acked-by: Kristen Carlson Accardi
> ---
> v2:
> - Add logic to ensur
uot;ORACLE", "X4275 M3", PPC},
> + {1, "ORACLE", "X6-2", PPC},
> + {1, "ORACLE", "Sudbury ", PPC},
> {0, "", ""},
> };
>
Acked-by: Kristen Carlson Accardi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
pstate,
> .get_turbo = knl_get_turbo_pstate,
> + .get_scaling = core_get_scaling,
> .set = core_set_pstate,
> },
> };
Acked-by: Kristen Carlson Accardi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a m
_pstate driver should not panic in this situation. This
> patch changes the div_fp() function to use div64_s64() to allow for "long"
> division. This will avoid the overflow condition on long delays.
>
> [v2]: use div64_s64() in div_fp()
Were you able to resolve your origina
t?
> >
> > Yes-- I believe my first inline comment spoke to this.
>
> So here's the changelog I'd use with this patch:
>
> "Commit 007bea098b86 (intel_pstate: Add setting voltage value for baytrail
> P states.) introduced byt_set_pstate() with the assumption that it would
> always be run by the CPU whose MSR is to be written by it. It turns out,
> however, that is not always the case in practice, so modify byt_set_pstate()
> to enforce the MSR write done by it to always happen on the right CPU."
>
> I don't think you need to say anything more in it. Mentioning governors in
> particular is unnecessary and confusing.
>
> Kristen, what do you think?
>
>
Looks good to me with the modified changelog.
Acked-by: Kristen Carlson Accardi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
a;
> > struct cpuinfo_x86 *c = &boot_cpu_data;
> >
> > Rename the local variable and use static_cpu_has_safe() which alleviates
> > the need for defining a local cpuinfo_x86 pointer.
>
> Kristen, any comments here?
Seems fine to me.
Acked-by: Kristen Ca
performance with this driver.
>
> Signed-off-by: Ethan Zhao
> Tested-by: Alexey Kodanev
> Reviewed-by: Linda Knippers
Acked-by: Kristen Carlson Accardi
> ---
> v2: change to hardware vendor specific naming parameter.
> v4: refine code and doc.
> v5&v6: fix a
On Thu, 04 Dec 2014 23:10:58 +0100
"Rafael J. Wysocki" wrote:
> On Thursday, December 04, 2014 11:07:31 AM Ethan Zhao wrote:
> > To force loading on Oracle Sun X86 servers, provide one kernel command line
> > parameter
> >
> > intel_pstate = ora_force
>
> I would suggest to change the name of
On Fri, 28 Nov 2014 12:36:17 +0900
Ethan Zhao wrote:
> To force loading on Oracle Sun X86 servers, provide one kernel command line
> parameter
>
> intel_pstate = ora_force
>
> For those who be aware of the risk of no power capping capabily working and
> try to get better performance with this
randewie
> Tested-by: Linda Knippers
Acked-by: Kristen Carlson Accardi
> ---
> v2: fix break HP Proliant issue.
> v3: expand the hardware vendor list.
> v4: refine code.
> v5v6: change enum PCC to PPC.
>
> drivers/cpufreq/intel_pstate.c | 45
> +++
On Thu, 20 Nov 2014 08:57:34 +0800
ethan wrote:
>
>
> > 在 2014年11月20日，03:05，Kristen Carlson Accardi 写道：
> >
> > On Tue, 18 Nov 2014 17:37:06 +0900
> > Ethan Zhao wrote:
> >
> >> Add kernel command line parameter
> >> in
On Tue, 18 Nov 2014 17:37:06 +0900
Ethan Zhao wrote:
> Add kernel command line parameter
> intel_pstate = ignore_acpi_ppc
> and module parameter
> ignore_acpi_ppc = 1
> to allow driver to ignore the ACPI _PPC existence even for Sun x86 servers.
> These parameter could be used for debug\test\wor
On Tue, 18 Nov 2014 17:37:05 +0900
Ethan Zhao wrote:
> From: Brian Maly
>
> To provide the flexibility of module, allow this driver to
> be configured and built as a module.
>
> Signed-off-by: Brian Maly
> Signed-off-by: Ethan Zhao
I believe the entire concept of being able to use intel_pst
On Fri, 22 Feb 2008 00:34:17 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Tue, 19 Feb 2008 20:47:08 + Paul Martin <[EMAIL PROTECTED]> wrote:
>
> > Now, this was working in 2.6.23, but is not in any later kernel.
> > Previously reported, but I guess that the previous report was
> > igno
On Fri, 22 Feb 2008 00:34:17 -0800
Andrew Morton <[EMAIL PROTECTED]> wrote:
> On Tue, 19 Feb 2008 20:47:08 + Paul Martin <[EMAIL PROTECTED]> wrote:
>
> > Now, this was working in 2.6.23, but is not in any later kernel.
> > Previously reported, but I guess that the previous report was
> > igno
On Tue, 12 Feb 2008 13:28:15 -0600
James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote:
> > I understand what you are trying to do - I guess I just doubt the
> > value you've added by doing this. I think that
On Tue, 12 Feb 2008 12:45:35 -0600
James Bottomley <[EMAIL PROTECTED]> wrote:
> On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote:
> > I apologize for taking so long to review this patch. I obviously
> > agree wholeheartedly with Luben. The problem I ran int
On Mon, 4 Feb 2008 18:01:36 -0800 (PST)
Luben Tuikov <[EMAIL PROTECTED]> wrote:
> --- On Mon, 2/4/08, James Bottomley
> <[EMAIL PROTECTED]> wrote:
> > > > The enclosure misc device is really just a
> > library providing
> > > > sysfs
> > > > support for physical enclosure devices and their
> > > >
On Sat, 01 Dec 2007 18:28:54 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Kristen Carlson Accardi wrote:
> > Enclosure Management via LED
> >
> > This patch implements Enclosure Management via the LED protocol as
> > specified in AHCI specification.
> &
Enclosure Management via LED
This patch implements Enclosure Management via the LED protocol as specified
in AHCI specification.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
---
This revision makes the change to the comment requested by Mark Lord,
fixes some bugs in t
This patch implements Enclosure Management via the LED protocol. See
the AHCI 1.1 spec for details.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
---
Ok, here's one that actually compiles...
drivers/ata/ahci.c| 154 +++
On Thu, 29 Nov 2007 13:16:07 -0500
Mark Lord <[EMAIL PROTECTED]> wrote:
> Kristen wrote:
> ...
> >+ * XXX will need Port Multiplier support
>
> What's that all about ?
>
I didn't have any hardware that had LED support as well as Port
Multiplier, so I didn't implement port multiplier support
On Thu, 29 Nov 2007 09:48:02 -0800
Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote:
> This patch implements Enclosure Management via the LED protocol. See
> the AHCI 1.1 spec for details.
Whoops, I totally messed up and sent the wrong version of this patch.
I'll send an up
This patch implements Enclosure Management via the LED protocol. See
the AHCI 1.1 spec for details.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
---
Here's a new version of the Enclosure management patch I sent a few
weeks ago. I tried to incorporate all the feedback, a
On Wed, 28 Nov 2007 13:31:47 -0800
Gary Hade <[EMAIL PROTECTED]> wrote:
> FYI, the node contains 2 hotpluggable PCIe slots and 5
> non-hotpluggable PCIe slots but 'pci_slot' only exposed
> the 2 hotpluggable slots. This does not appear to be due
> to a 'pci_slot' driver problem since I looked at
On Mon, 26 Nov 2007 19:04:54 -0800
Gary Hade <[EMAIL PROTECTED]> wrote:
> > Is this patchset appropriate for the -mm tree yet?
>
> I would defer to our illustrious maintainers on this one. :)
>
> > Or do you think it still needs more work?
>
> I am now much more comfortable with your change
On Mon, 19 Nov 2007 15:04:18 -0700
Alex Chiang <[EMAIL PROTECTED]> wrote:
> Documentation/accounting/getdelays.c | 43 +-
> Documentation/feature-removal-schedule.txt |9 -
> Documentation/hwmon/sysfs-interface | 31 +
> Documentation/markers.txt|
On Sat, 17 Nov 2007 11:29:54 -0700
Alex Chiang <[EMAIL PROTECTED]> wrote:
> I have done quite a bit more testing, and verified that this
> series plays nicely with acpiphp during all stages of the series.
> Notably, you can modprobe/rmmod acpiphp repeatedly no matter
> where you are in the series,
On Wed, 14 Nov 2007 18:55:21 +0900
Kenji Kaneshige <[EMAIL PROTECTED]> wrote:
> Matthew Wilcox :
> > On Tue, Nov 13, 2007 at 03:33:14PM -0800, Kristen Carlson Accardi wrote:
> >> As far as being able to retrieve the slot number (which it seemed from
> >>
On Tue, 13 Nov 2007 16:04:00 -0700
Matthew Wilcox <[EMAIL PROTECTED]> wrote:
> On Tue, Nov 13, 2007 at 02:56:05PM -0800, Greg KH wrote:
> > Why not just use the code in the linux firmware kit that does this
> > already today from userspace (thanks to Kristen for pointing this out to
> > me on irc.
On Tue, 13 Nov 2007 12:26:32 -0800
Greg KH <[EMAIL PROTECTED]> wrote:
> On Tue, Nov 13, 2007 at 01:21:54PM -0700, Alex Chiang wrote:
> > * Greg KH <[EMAIL PROTECTED]>:
> > > On Mon, Nov 12, 2007 at 05:08:53PM -0700, Alex Chiang wrote:
> > > >
> > > > Recently, Matthew Wilcox sent out the followin
On Mon, 05 Nov 2007 07:53:58 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> > Yep, works for me! Can we get this expedited upstream?
>
> If everybody's happy with it, I've got it ready for upstream in
> libata-dev.git#dlpm-fix
>
> Jeff
Thanks! It'd be great if you could get it in ASAP.
-
to this commit:
>
> 1556594f913fa81d008cecfe46d7211c919a853 is first bad commit
> commit 31556594f913fa81d008cecfe46d7211c919a853
> Author: Kristen Carlson Accardi <[EMAIL PROTECTED]>
> Date: Thu Oct 25 01:33:26 2007 -0400
>
> [libata] AHCI: add hw link power management support
>
> Booting an
On Thu, 01 Nov 2007 07:20:16 -0400
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Jens Axboe wrote:
> > Reverting just the default AHCI flags makes it work again. IOW, with the
> > below patch I can suspend properly with current -git.
> >
> > diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
> > ind
On Thu, 25 Oct 2007 23:35:11 +0200
Ingo Oeser <[EMAIL PROTECTED]> wrote:
> Hi Kristen,
>
> On Thursday 25 October 2007, Kristen Carlson Accardi wrote:
> > Enable enclosure management via LED
> >
> > As described in the AHCI spec, some AHCI controllers may suppor
Enable enclosure management via LED
As described in the AHCI spec, some AHCI controllers may support
Enclosure management via a variety of protocols. This patch
adds support for the LED message type that is specified in
AHCI 1.1 and higher.
Signed-off-by: Kristen Carlson Accardi <[EM
On Thu, 18 Oct 2007 13:49:25 -0400
Theodore Tso <[EMAIL PROTECTED]> wrote:
> On Thu, Oct 18, 2007 at 10:06:14AM -0700, Kristen Carlson Accardi wrote:
> > No, it actually does violate the spec. Feel free to read it yourself.
> > We are not supposed to do Native PCIe witho
On Thu, 18 Oct 2007 13:06:21 -0400
Mark Lord <[EMAIL PROTECTED]> wrote:
> Kristen Carlson Accardi wrote:
> > On Wed, 17 Oct 2007 23:09:45 -0400
> > Mark Lord <[EMAIL PROTECTED]> wrote:
> >
> >> Mark Lord wrote:
> >>> Fix PCIe Hotplug so
On Wed, 17 Oct 2007 23:09:45 -0400
Mark Lord <[EMAIL PROTECTED]> wrote:
> Mark Lord wrote:
> > Fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks
> > (and others?) in conjunction with the modparam of pciehp_force=1.
>
>
> To make things simpler for distro people, I'm cont
Enable enclosure management via LED
As described in the AHCI spec, some AHCI controllers may support
Enclosure management via a variety of protocols. This patch
adds support for the LED message type that is specified in
AHCI 1.1 and higher.
Signed-off-by: Kristen Carlson Accardi <[EM
On Tue, 16 Oct 2007 21:55:30 -0400
Mark Lord <[EMAIL PROTECTED]> wrote:
> Make use of the previously split out pcie_init_enable_events() function
> to reinitialize the hotplug hardware on resume from suspend,
> but only when pciehp_force==1. Otherwise behaviour is unmodified.
OK - definitely in
1 - 100 of 260 matches
Mail list logo
