Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-24 Thread Kiyoshi Ueda
Hi Andreas, On Sat, 23 Feb 2008 16:47:50 +0100, Andreas Schwab wrote: Kiyoshi Ueda <[EMAIL PROTECTED]> writes: > Could you try this patch? > I've only done a compile test, so this patch may not work. Unfortunately, that is not enough to get DVD burning working again. This

[PATCH] ide-cd: fix missing residual count setting in DMA mode (Was 2.6.25-rc1/2 CD/DVD burning broken)

2008-02-18 Thread Kiyoshi Ueda
Hi, On Mon, 18 Feb 2008 23:37:48 +0100, Borislav Petkov wrote: > On Mon, Feb 18, 2008 at 09:20:41PM +0100, Borislav Petkov wrote: > > On Mon, Feb 18, 2008 at 01:58:27PM -0500, Kiyoshi Ueda wrote: > > > Hi Andreas, > > > > > > On Sat, 16 Feb 2008

Re: 2.6.25-rc1/2 CD/DVD burning broken

2008-02-18 Thread Kiyoshi Ueda
BUG(); HWGROUP(drive)->rq = NULL; spin_unlock_irqrestore(&ide_lock, flags); Thanks, Kiyoshi Ueda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo inf

[APPENDIX PATCH 13/13] dm-mpath: convert to request-based

2008-02-15 Thread Kiyoshi Ueda
This patch converts dm-multipath target to request-based from bio-based. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/md/dm-mpath.c | 228 +- drivers/md/dm-r

[APPENDIX PATCH 12/13] dm-mpath: add hw-handler interface

2008-02-15 Thread Kiyoshi Ueda
This patch adds a hw-handler interface for request-based dm-multipath. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/md/dm-hw-handler.h |1 + 1 files changed, 1 insertion(+) Index: 2.6.25-rc1/drivers/m

[APPENDIX PATCH 11/13] dm: reject bad table load

2008-02-15 Thread Kiyoshi Ueda
This patch rejects bad table load for request-based dm. The following table loadings are rejected: - including non-stackable device - shrinking the current restrictions Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> -

[APPENDIX PATCH 10/13] dm: enable request-based dm

2008-02-15 Thread Kiyoshi Ueda
: request-based dm device on bio-based dm device The type of a dm device is decided at the first table loading time. Until then, mempool creations and queue initializations are deferred. Once the type of a dm device is decided, the type can't be changed. Signed-off-by: Kiyoshi Ueda <[EMAIL P

[APPENDIX PATCH 09/13] dm: add core functions

2008-02-15 Thread Kiyoshi Ueda
This patch adds core functions for request-based dm. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/md/dm.c | 452 +++- drivers/md/dm.h |7 2 files change

[APPENDIX PATCH 07/13] dm: add memory pool

2008-02-15 Thread Kiyoshi Ueda
This patch prepares memory pools for request-based dm. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/md/dm.c | 26 +- 1 files changed, 25 insertions(+), 1 deletion(-) Index: 2.6.25-rc

[APPENDIX PATCH 08/13] dm: add target interfaces

2008-02-15 Thread Kiyoshi Ueda
This patch adds target interfaces for request-based dm. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- include/linux/device-mapper.h | 23 +++ 1 files changed, 23 insertions(+) Index: 2.6.25-rc1/inc

[APPENDIX PATCH 05/13] dm: remove dead codes

2008-02-15 Thread Kiyoshi Ueda
_WQ_FLUSH_ALL type is used only in dm_suspend(). So no need any more. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/md/dm.c | 14 +-

[APPENDIX PATCH 06/13] dm: tidy local_init

2008-02-15 Thread Kiyoshi Ueda
This patch tidies local_init() as preparation for request-based dm. No functional change. This patch is just a clean up of the codes and not functionally related to request-based dm. But included here due to literal dependency. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-

[APPENDIX PATCH 04/13] block: export blk_end_io

2008-02-15 Thread Kiyoshi Ueda
ff-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/blk-core.c |6 +++--- include/linux/blkdev.h |3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) Index: 2.6.2

[APPENDIX PATCH 02/13] block: add request submission interface

2008-02-15 Thread Kiyoshi Ueda
needed. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/blk-core.c | 65 + include/linux/blkdev.h |1 2 files changed, 66 insertions(+) Index: 2.6.25-rc1

[APPENDIX PATCH 01/13] block: don't call __end_that_request_first() for clone

2008-02-15 Thread Kiyoshi Ueda
This patch adds a flag to indicate the request is a clone and avoids __end_that_request_first() call for cloned requests in blk_end_io(). So request-based dm can use blk_end_io() to complete clones while dm doesn't want to complete the data in the clones. Signed-off-by: Kiyoshi Ueda &l

[APPENDIX PATCH 03/13] block: export blk_register_queue

2008-02-15 Thread Kiyoshi Ueda
time. Then, request-based dm sets q->request_fn and wants to register the queue correctly again. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/blk-sysfs.c |1 + 1 files changed, 1 insertion(+) Index: 2.6.25-r

[RFC PATCH 3/3] block: lld busy status exporting interface

2008-02-15 Thread Kiyoshi Ueda
mmand. And scsi clears the busy flag when a command has been dispatched successfully, since there may be more spaces to dispatch (the exact limit check will be done in the next loop for the next request.) Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[E

[RFC PATCH 2/3] block: move internal request completion to kblockd

2008-02-15 Thread Kiyoshi Ueda
block layer is not ready for request stacking now. To complete all requests without the queue lock, this patch uses kblockd in such cases. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/blk-barrier.c|8 ++--

[RFC PATCH 1/3] block: add rq->complete_io hook for request stacking

2008-02-15 Thread Kiyoshi Ueda
to be used by request stacking drivers. (scsi patch is included just for an example of the setting.) To detect wrong use of the flag and the hook, some checks are also put in __blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTE

[RFC PATCH 0/3] request stacking and request-based dm-multipath

2008-02-15 Thread Kiyoshi Ueda
ompletion. So I think it's reasonable to add another hook for request stacking. (or rename the current ->end_io() to ->dtor() and make ->end_io() a request stacking hook.) Thanks, Kiyoshi Ueda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-02-01 Thread Kiyoshi Ueda
; @@ -1722,7 +1722,7 @@ static ide_startstop_t cdrom_newpc_intr(ide_drive_t > *drive) > */ > if ((stat & DRQ_STAT) == 0) { > spin_lock_irqsave(&ide_lock, flags); > - if (__blk_end_request(rq, 0, 0)) > + if (unlikel

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-02-01 Thread Kiyoshi Ueda
k_end_request(), so __end_that_reqeust_first() should never return 1 and we should never BUG() on the residual byte counts, unless inconsistency happens such as the size of remaining bios is bigger than the residual byte counts. So if __blk_end_request() returns 1 even with the Jens' patch

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-31 Thread Kiyoshi Ueda
ec40, > buffer , data , len 158 > Jan 31 22:10:06 gollum kernel: [ 26.703122] cdb: 12 00 00 00 fe 00 00 00 00 > 00 00 00 00 00 00 00 > Jan 31 22:10:06 gollum kernel: [ 26.703877] backup: data_len=158 > bi_size=158 > > ... so we've been simply silentl

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-31 Thread Kiyoshi Ueda
Hi Jens, On Thu, 31 Jan 2008 19:16:54 +0100, Jens Axboe wrote: > On 31/01/2008, at 18.04, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > > On Thu, 31 Jan 2008 14:05:58 +0100, Jens Axboe wrote: > >> On Thu, Jan 31 2008, Nai Xia wrote: > >>> My

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-31 Thread Kiyoshi Ueda
_end_request(rq, 0, 0)) > + if (__blk_end_request(rq, 0, rq->data_len)) > BUG(); > HWGROUP(drive)->rq = NULL; > spin_unlock_irqrestore(&ide_lock, flags); OK, I undarstand the leftover is legal. By the way, is it safe to

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-30 Thread Kiyoshi Ueda
Hi Roland, Borislav, Bart, Added linux-ide ML, since we may be able to get helps from other ide experts. This thread started from: http://lkml.org/lkml/2008/1/29/140 On Tue, 29 Jan 2008 18:23:56 -0500 (EST), Kiyoshi Ueda wrote: > Hi Bart, > > On Tue, 29 Jan 2008 14:22:53 -080

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-29 Thread Kiyoshi Ueda
that the rq still has a bio even after DRQ_STAT is cleared. The original ide-cd code was calling only end_that_request_last() there. So I thought that the rq should have no bio when DRQ_STAT is cleared, otherwise the bio leaks. Was my understanding wrong and is that correct behavior in ide-cd? T

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-29 Thread Kiyoshi Ueda
2.6.24-git and send outputs? --- linus-git.orig/drivers/ide/ide-cd.c 2008-01-29 10:04:51.0 -0500 +++ linus-git/drivers/ide/ide-cd.c 2008-01-29 21:00:19.0 -0500 @@ -1723,7 +1723,7 @@ if ((stat & DRQ_STAT) == 0) { spin_lock_irqsave(&ide_lock, flags);

[PATCH 3/3] block: remove end_{queued|dequeued}_request()

2008-01-11 Thread Kiyoshi Ueda
This patch removes end_queued_request() and end_dequeued_request(), which are no longer used. As a results, users of __end_request() became only end_request(). So the actual code in __end_request() is moved to end_request() and __end_request() is removed. Signed-off-by: Kiyoshi Ueda <[EM

[PATCH 2/3] block: change elevator to use blk-end-request

2008-01-11 Thread Kiyoshi Ueda
empty(&rq->queuelist)) blkdev_dequeue_request(rq); In the case of elv_next_request(), blkdev_dequeue_request() has not been done and the queuelist isn't empty. So __blk_end_request() calls blkdev_dequeue_request() and the behavior of elv_next_request() doesn't change. Signed-o

[PATCH 1/3] block: change virtio_blk to use blk-end-request

2008-01-11 Thread Kiyoshi Ueda
;t change. Cc: Rusty Russell <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/virtio_blk.c | 10 +- 1 files changed, 5 insertions(+),

[PATCH 0/3] block: remove end_{queued|dequeued}_request()

2008-01-11 Thread Kiyoshi Ueda
27; branch of your linux-2.6-block.git. Please review and apply. Thanks, Kiyoshi Ueda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please r

[PATCH] (linux-2.6-block.git) xsysace: fix size misconversion of blk_end_request

2007-12-21 Thread Kiyoshi Ueda
bytes directly to __blk_end_request(). Cc: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/xsysace.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/bloc

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-14 Thread Kiyoshi Ueda
ce a NEW problem to ub. I have investigated all code paths which call ub_end_rq() in ub.c, and confirmed that ub_end_rq() is always called with the queue lock held. (sc->lock is registered as a queue lock.) So there is no such race in the current ub code. You don't need to rewrite ub. Th

Re: [Patch 4/8] Enhanced partition statistics: cciss fix

2007-12-13 Thread Kiyoshi Ueda
disk_stat_add(rq->rq_disk, sectors[rw], > > rq->nr_sectors); > > + all_stat_add(rq->rq_disk, sectors[rw], > > +rq->nr_sectors, rq->sector); > > } > > How does this mesh with the changes submitted by

Re: [PATCH 01/30] blk_end_request: add new request completion interface (take 4)

2007-12-12 Thread Kiyoshi Ueda
Hi James, Jens, On Wed, 12 Dec 2007 07:53:36 -0500, James Bottomley wrote: > On Tue, 2007-12-11 at 17:40 -0500, Kiyoshi Ueda wrote: > > This patch adds 2 new interfaces for request completion: > > o blk_end_request() : called without queue lock > > o __blk_end_request(

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-12 Thread Kiyoshi Ueda
k held o ub_end_rq() calls end_that_request_last() without taking the queue lock in itself. So the queue lock must have been taken outside ub_end_rq(). But, if ub is calling end_that_request_last() without the queue lock, it is a bug in the original code and we should use blk_end_request()

Re: [PATCH 21/30] blk_end_request: changing cciss (take 4)

2007-12-12 Thread Kiyoshi Ueda
OMPLETE); > > Why is this removed? Sorry for the less explanation. Because it is done in __end_that_request_first() called from blk_end_request(). I'll add the explanation to the patch description when I update the patch. Thanks, Kiyoshi Ueda -- To unsubscribe from this list: send the line

Re: [PATCH 20/30] blk_end_request: changing xsysace (take 4)

2007-12-12 Thread Kiyoshi Ueda
atches again, and I found no other miss conversions. Below is the revised patch for xsysace. Thanks, Kiyoshi Ueda Subject: [PATCH 20/30] blk_end_request: changing xsysace (take 4) This patch converts xsysace to use blk_end_request interfaces. Related 'uptodate' arguments are converted to

[PATCH 29/30] blk_end_request: cleanup 'uptodate' related code (take 4)

2007-12-11 Thread Kiyoshi Ueda
OTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/ll_rw_blk.c | 56 +++-- include/linux/blkdev.h |8 --- 2 files changed, 9 insertions(+), 55 deleti

[PATCH 28/30] blk_end_request: remove/unexport end_that_request_* (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch removes the following functions: o end_that_request_first() o end_that_request_chunk() and stops exporting the functions below: o end_that_request_last() Cc: Boaz Harrosh <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ic

[PATCH 30/30] blk_end_request: cleanup of request completion (take 4)

2007-12-11 Thread Kiyoshi Ueda
() is no longer exported, the code can be merged to end_that_request_last(). Cc: Boaz Harrosh <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/ll_rw_blk.c | 31 ++---

[PATCH 27/30] blk_end_request: changing scsi (take 4)

2007-12-11 Thread Kiyoshi Ueda
AIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/scsi/scsi_lib.c | 31 +++ 1 files changed, 11 insertions(+), 20 deleti

[PATCH 26/30] blk_end_request: add bidi completion interface (take 4)

2007-12-11 Thread Kiyoshi Ueda
t_rq->end_io is not called). So if special completion handling is needed, the handler must be set to rq->end_io. And the handler must take care of freeing next_rq too, since the interface doesn't care of it if rq->end_io is not NULL. Cc: Boaz Harrosh <[EMAIL PROTECTED]> Sig

[PATCH 25/30] blk_end_request: changing ide-cd (take 4)

2007-12-11 Thread Kiyoshi Ueda
tlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/ide/ide-cd.c | 49 +++-- 1 files changed, 35 insertions(+), 14

[PATCH 22/30] blk_end_request: changing cpqarray (take 4)

2007-12-11 Thread Kiyoshi Ueda
ule (b) mentioned in the patch subject "[PATCH 01/30] blk_end_request: add new request completion interface". Cc: Mike Miller <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/cpqarray

[PATCH 24/30] blk_end_request: add callback feature (take 4)

2007-12-11 Thread Kiyoshi Ueda
blk_end_request_callback() to return without completing request. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/ll_rw_blk.c | 72 - include/linux/blkdev.h |2 +

[PATCH 20/30] blk_end_request: changing xsysace (take 4)

2007-12-11 Thread Kiyoshi Ueda
0] blk_end_request: add new request completion interface". Cc: Grant Likely <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/xsysace.c |5 + 1 files changed, 1 insertio

[PATCH 23/30] blk_end_request: changing ide normal caller (take 4)

2007-12-11 Thread Kiyoshi Ueda
eady been removed from the queue (i.e. rq->queuelist is empty) So blk_end_request can handle it correctly although ide always run thought the code above. Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun&

[PATCH 21/30] blk_end_request: changing cciss (take 4)

2007-12-11 Thread Kiyoshi Ueda
mentioned in the patch subject "[PATCH 01/30] blk_end_request: add new request completion interface". Cc: Mike Miller <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/cciss.c

[PATCH 19/30] blk_end_request: changing ide-scsi (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ide-scsi to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL

[PATCH 18/30] blk_end_request: changing s390 (take 4)

2007-12-11 Thread Kiyoshi Ueda
ED]> Cc: Heiko Carstens <[EMAIL PROTECTED]> Cc: [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/s390/block/dasd.c | 19 ++- drivers/s390/char/tape_block.c | 13 +++

[PATCH 15/30] blk_end_request: changing viocd (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts viocd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, viocd_end_request(), is changed. Cc: Stephen Rothwell <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda

[PATCH 17/30] blk_end_request: changing mmc (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts mmc to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Pierre Ossman <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTE

[PATCH 14/30] blk_end_request: changing xen-blkfront (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts xen-blkfront to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Jeremy Fitzhardinge <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[

[PATCH 16/30] blk_end_request: changing i2o_block (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts i2o_block to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, i2o_block_end_request(), is changed. Cc: Markus Lidel <[EMAIL PROTECTED]> Signed-off-by: Kiyo

[PATCH 13/30] blk_end_request: changing viodasd (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts viodasd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, viodasd_end_request(), is changed. Cc: Stephen Rothwell <[EMAIL PROTECTED]> Signed-off-by: Kiyo

[PATCH 11/30] blk_end_request: changing sx8 (take 4)

2007-12-11 Thread Kiyoshi Ueda
rsion of the 'is_ok' is done at only one place above. Cc: Jeff Garzik <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/sx8.c | 58 +-

[PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ub to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Pete Zaitcev <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> -

[PATCH 10/30] blk_end_request: changing sunvdc (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts sunvdc to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, vdc_end_request(), is changed. Cc: David S. Miller <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <

[PATCH 09/30] blk_end_request: changing ps3disk (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts ps3disk to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Geoff Levand <[EMAIL PROTECTED]> Cc: Geert Uytterhoeven <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off

[PATCH 08/30] blk_end_request: changing nbd (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts nbd to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. Cc: Paul Clements <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>

[PATCH 05/30] blk_end_request: changing um (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts um to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, ubd_end_request(), is changed. Cc: Jeff Dike <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EM

[PATCH 06/30] blk_end_request: changing DAC960 (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts DAC960 to use blk_end_request interfaces. Related 'UpToDate' arguments are converted to 'Error'. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/DAC960.c | 11 ++---

[PATCH 07/30] blk_end_request: changing floppy (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch converts floppy to use blk_end_request interfaces. Related 'uptodate' arguments are converted to 'error'. As a result, the interface of internal function, floppy_end_request(), is changed. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun

[PATCH 03/30] blk_end_request: changing block layer core (take 4)

2007-12-11 Thread Kiyoshi Ueda
dequeued_request() become identical. A future patch will merge and rename them and change users of those functions. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/ll_rw_blk.c | 35 +++

[PATCH 04/30] blk_end_request: changing arm (take 4)

2007-12-11 Thread Kiyoshi Ueda
TED]> Cc: Hiroshi DOYU <[EMAIL PROTECTED]> Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- arch/arm/plat-omap/mailbox.c | 16 ++-- 1 files changed, 6

[PATCH 00/30] blk_end_request: full I/O completion handler (take 4)

2007-12-11 Thread Kiyoshi Ueda
1, the request isn't completed and the ownership is returned to the device driver again. o rq->end_io() is called at the top of blk_end_request() to allow to hook all parts of request completion. Existing users of rq->end_io() must be changed to do all parts of request comp

[PATCH 02/30] blk_end_request: add/export functions to get request size (take 4)

2007-12-11 Thread Kiyoshi Ueda
This patch adds/exports functions to get the size of request in bytes. They are useful because blk_end_request interfaces take bytes as a completed I/O size instead of sectors. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTE

[PATCH 01/30] blk_end_request: add new request completion interface (take 4)

2007-12-11 Thread Kiyoshi Ueda
c) spin_lock_irqsave() (add_disk_randomness(), blk_queue_end_tag(), blkdev_dequeue_request()) end_that_request_last() spin_unlock_irqrestore() => blk_end_request() or spin_lock_irqsave() __blk_end_request() s

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-10 Thread Kiyoshi Ueda
> > +int blk_end_request(struct request *rq, int uptodate, int nr_bytes) > > +{ > > + return blk_end_io(rq, uptodate, nr_bytes, 0, NULL); > > +} > > EXPORT_SYMBOL_GPL(blk_end_request); > > > > All above looks fine, thanks. OK, I'll update the patc

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-06 Thread Kiyoshi Ueda
a much simpler thing. listed below > are some possible solutions. > > 1. Take extra parm to blk_end_request like > int blk_end_request(struct request *rq, int error, int nr_bytes, int > bidi_bytes) > > if the bidi_bytes is not zero than req->next_req is freed like above. OK

Re: [PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-12-05 Thread Kiyoshi Ueda
Hi Boaz, On Tue, 04 Dec 2007 15:39:12 +0200, Boaz Harrosh <[EMAIL PROTECTED]> wrote: > On Sat, Dec 01 2007 at 1:35 +0200, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: > > This patch converts bidi of scsi mid-layer to use blk_end_request(). > > > > rq->next_r

Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-04 Thread Kiyoshi Ueda
at once, I'll merge them into blk_end_request patch-set. As for the patch inclusion, do you push the driver changes to Linus all at once? Or should I ask each maintainer to take the patch? Thanks, Kiyoshi Ueda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 01/28] blk_end_request: add new request completion interface (take 3)

2007-12-04 Thread Kiyoshi Ueda
_function(rq, 0); } -- As for the holding-queue-lock-longer implementation, end_that_request_chunk() completes bios in the request and it can reaches filesystem layer and may take time. I guess many drivers like scsi are calling end_that_reques

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-04 Thread Kiyoshi Ueda
ay still gets a problem for the 'dequeue'? > > Everything seems to be fine now. > > Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Thank you for the check. OK, I'll add the explanation about the 'dequeue' to patch description. Thanks, Kiyoshi Ueda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-03 Thread Kiyoshi Ueda
Hi Bartlomiej, On Sat, 1 Dec 2007 23:53:05 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Saturday 01 December 2007, Kiyoshi Ueda wrote: > > This patch converts "normal" parts of ide to use blk_end_request(). > > > > Signed-off-by: Kiyosh

Re: [PATCH 09/28] blk_end_request: changing ps3disk (take 3)

2007-12-03 Thread Kiyoshi Ueda
Hi Geert, On Sun, 2 Dec 2007 10:34:56 +0100 (CET), Geert Uytterhoeven <[EMAIL PROTECTED]> wrote: > On Fri, 30 Nov 2007, Kiyoshi Ueda wrote: > > This patch converts ps3disk to use blk_end_request(). > ^^^ > Patch subjec

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-03 Thread Kiyoshi Ueda
Hi Bartlomiej, On Sat, 1 Dec 2007 23:42:51 +0100, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > On Saturday 01 December 2007, Kiyoshi Ueda wrote: > > This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request(). > > > > ide-cd (cdrom_newpc_intr()

[PATCH 27/28] blk_end_request: changing scsi mid-layer for bidi (take 3)

2007-11-30 Thread Kiyoshi Ueda
= cmd->request; rq->resid = scsi_out(cmd)->resid; rq->next_rq->resid = scsi_in(cmd)->resid; if (blk_end_request(req, 1, req->data_len)) BUG(); scsi_release_buffers(cmd); scsi_next_command(cmd); } Signed-off-by: Kiyoshi

[PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-11-30 Thread Kiyoshi Ueda
just returns value '1', to tell blk_end_request_callback() about that. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/ide/ide-cd.c | 78 +++ 1 files ch

[PATCH 28/28] blk_end_request: remove/unexport end_that_request_* (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch removes the following functions: o end_that_request_first() o end_that_request_chunk() and stops exporting the functions below: o end_that_request_last() Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> ---

[PATCH 25/28] blk_end_request: add callback feature (take 3)

2007-11-30 Thread Kiyoshi Ueda
d in end_that_request_chunk() by blk_trace and so on. Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- block/ll_rw_blk.c | 50 + include/linux/blkdev.h |3 ++ 2 files

[PATCH 23/28] blk_end_request: changing cpqarray (take 3)

2007-11-30 Thread Kiyoshi Ueda
add new request completion interface". Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/cpqarray.c | 27 ++- 1 files changed, 2 insertions(+), 25 deletions(-) Index: 2.

[PATCH 22/28] blk_end_request: changing cciss (take 3)

2007-11-30 Thread Kiyoshi Ueda
uest completion interface". Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/cciss.c | 25 +++-- 1 files changed, 3 insertions(+), 22 deletions(-) Index:

[PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts "normal" parts of ide to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/ide/ide-cd.c |6 +++--- drivers/ide/ide-io.c | 17 ++--- 2 files c

[PATCH 21/28] blk_end_request: changing xsysace (take 3)

2007-11-30 Thread Kiyoshi Ueda
Q_COMPLETE, respectively.) However, those states are consecutive and without any interruption inbetween. So we can just follow the standard conversion rule (b) mentioned in the patch subject "[PATCH 01/27] blk_end_request: add new request completion interface". Signed-off-by: Kiyoshi Ue

[PATCH 18/28] blk_end_request: changing s390 (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts s390 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/s390/block/dasd.c |4 +--- drivers/s390/char/tape_block.c |3 +-- 2 files changed, 2 insertions(+), 5 de

[PATCH 20/28] blk_end_request: changing ide-scsi (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts ide-scsi to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/scsi/ide-scsi.c |8 1 files changed, 4 insertions(+), 4 deletions(-) Index: 2.6.24-rc3-mm2/driver

[PATCH 19/28] blk_end_request: changing scsi (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts scsi mid-layer to use blk_end_request(). The comment above scsi_next_command() is not related to this change. It had originally been there before scsi_next_command() was included in scsi_finalize_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-

[PATCH 16/28] blk_end_request: changing i2o_block (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts i2o_block to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/message/i2o/i2o_block.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) Index: 2.6.24-rc3-mm

[PATCH 17/28] blk_end_request: changing mmc (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts mmc to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/mmc/card/block.c | 24 +--- drivers/mmc/card/queue.c |4 ++-- 2 files changed, 7 insertions

[PATCH 14/28] blk_end_request: changing xen-blkfront (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts xen-blkfront to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/xen-blkfront.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) Index: 2.6.24-rc3-mm2/

[PATCH 15/28] blk_end_request: changing viocd (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts viocd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/cdrom/viocd.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) Index: 2.6.24-rc3-mm2/driv

[PATCH 13/28] blk_end_request: changing viodasd (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts viodasd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/viodasd.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) Index: 2.6.24-rc3-mm2/driver

[PATCH 11/28] blk_end_request: changing sx8 (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts sx8 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/sx8.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) Index: 2.6.24-rc3-mm2/dr

[PATCH 12/28] blk_end_request: changing ub (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts ub to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/ub.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Index: 2.6.24-rc3-mm2/d

[PATCH 10/28] blk_end_request: changing sunvdc (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts sunvdc to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/sunvdc.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) Index: 2.6.24-rc3-mm2/drive

[PATCH 09/28] blk_end_request: changing ps3disk (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts ps3disk to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/ps3disk.c |6 +- 1 files changed, 1 insertion(+), 5 deletions(-) Index: 2.6.24-rc3-mm2/driver

[PATCH 08/28] blk_end_request: changing nbd (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts nbd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]> Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]> --- drivers/block/nbd.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) Index: 2.6.24-rc3-mm2/dr

  1   2   >