[PATCH] i2c: smbus: Fix spelling mistake in the comments

2020-06-12 Thread Keyur Patel
Fix spelling mistake in the comments with help of `codespell`. seperate ==> separate Signed-off-by: Keyur Patel --- drivers/i2c/i2c-core-smbus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbus.c index b34d2ff06

[PATCH] memory: tegra: Avoid double error messaging when IRQ absent

2020-06-11 Thread Keyur Patel
Since the commit 7723f4c ("driver core: platform: Add an error message to platform_get_irq*()") platform_get_irq() started issuing an error message. Thus, there is no need to have the same in the driver. Signed-off-by: Keyur Patel --- drivers/memory/tegra/mc.c | 4 +--- 1 file

[PATCH] memory: emif: Avoid double error messaging when IRQ absent

2020-06-11 Thread Keyur Patel
Since the commit 7723f4c ("driver core: platform: Add an error message to platform_get_irq*()") platform_get_irq() started issuing an error message. Thus, there is no need to have the same in the driver. Signed-off-by: Keyur Patel --- drivers/memory/emif.c | 5 + 1 file changed, 1

[PATCH] ext4: fix spelling mistakes in extents.c

2020-06-10 Thread Keyur Patel
Fix spelling issues over the comments in the code. requsted ==> requested deterimined ==> determined insde ==> inside neet ==> need somthing ==> something Signed-off-by: Keyur Patel --- fs/ext4/extents.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v2] power: supply: axp20x_usb_power: fix spelling mistake

2020-06-09 Thread Keyur Patel
Fix typo: "triger" --> "trigger" Signed-off-by: Keyur Patel --- drivers/power/supply/axp20x_usb_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c index 4fde24b5f3

[PATCH] power: supply: axp20x_usb_power: fix spelling mistake

2020-06-09 Thread Keyur Patel
Fix typo: "tigger" --> "trigger" Signed-off-by: Keyur Patel --- drivers/power/supply/axp20x_usb_power.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/axp20x_usb_power.c b/drivers/power/supply/axp20x_usb_power.c index 4fde24b5f3

[PATCH] iio: cros_ec: fix spelling mistake

2020-06-09 Thread Keyur Patel
Fix typo: "tigger" --> "trigger" Signed-off-by: Keyur Patel --- drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/common/cros_ec_sensors/cros_ec_sensors_core.c b/drivers/iio

[PATCH v3] fs: ocfs2: fix spelling mistake and grammar

2020-06-07 Thread Keyur Patel
./ocfs2/mmap.c:65: bebongs ==> belonging Signed-off-by: Keyur Patel --- fs/ocfs2/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/mmap.c b/fs/ocfs2/mmap.c index 3a44e461828a..39a77e903fdf 100644 --- a/fs/ocfs2/mmap.c +++ b/fs/ocfs2/mmap.c @@ -62,7 +6

[PATCH v2] fs: ocfs2: fix spelling mistake and grammar

2020-06-07 Thread Keyur Patel
./ocfs2/mmap.c:65: bebongs ==> belongs Signed-off-by: Keyur Patel --- fs/ocfs2/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/mmap.c b/fs/ocfs2/mmap.c index 3a44e461828a..39a77e903fdf 100644 --- a/fs/ocfs2/mmap.c +++ b/fs/ocfs2/mmap.c @@ -62,7 +6

[PATCH] fs: ocfs2: fix spelling mistake

2020-06-07 Thread Keyur Patel
./ocfs2/mmap.c:65: bebongs ==> belongs Signed-off-by: Keyur Patel --- fs/ocfs2/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/mmap.c b/fs/ocfs2/mmap.c index 3a44e461828a..39a77e903fdf 100644 --- a/fs/ocfs2/mmap.c +++ b/fs/ocfs2/mmap.c @@ -62,7 +6

[PATCH] xfs: Couple of typo fixes in comments

2020-06-07 Thread Keyur Patel
./xfs/libxfs/xfs_inode_buf.c:56: unnecssary ==> unnecessary ./xfs/libxfs/xfs_inode_buf.c:59: behavour ==> behaviour ./xfs/libxfs/xfs_inode_buf.c:206: unitialized ==> uninitialized Signed-off-by: Keyur Patel --- fs/xfs/libxfs/xfs_inode_buf.c | 6 +++--- 1 file changed, 3 inserti

[PATCH 2/2] xfs: Couple of typo fixes in comments

2020-06-07 Thread Keyur Patel
./xfs/libxfs/xfs_inode_buf.c:56: unnecssary ==> unnecessary ./xfs/libxfs/xfs_inode_buf.c:59: behavour ==> behaviour ./xfs/libxfs/xfs_inode_buf.c:206: unitialized ==> uninitialized Signed-off-by: Keyur Patel --- fs/xfs/libxfs/xfs_inode_buf.c | 6 +++--- 1 file changed, 3 inserti

[PATCH 1/2] befs: fix typos in btree.c

2020-06-07 Thread Keyur Patel
"countain" -> "contain" Signed-off-by: Keyur Patel --- fs/befs/btree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/befs/btree.c b/fs/befs/btree.c index 1b7e0f7128d6..53ad89bba448 100644 --- a/fs/befs/btree.c +++ b/fs/befs/btree.c @@ -322,7 +3

[PATCH v5] staging: most: Delete an error message for a failed memory allocation

2019-07-14 Thread Keyur Patel
The kfifo_alloc() failure generates enough information and doesn't need to be accompanied by another error statement. Signed-off-by: Keyur Patel --- Changes in v5: - change subject line - simplify commit description - fix checkpatch warning - removed braces around if drivers/staging/most

Re: [v4] staging: most: Delete an error message for a failed memory allocation

2019-07-14 Thread Keyur Patel
I think commit message is clear enough to understand why this is needed. You can send me what should I include in commit description and I will add and send it again. Otherwise, Greg can comment on this. Thanks. On Sun, Jul 14, 2019 at 06:55:30PM +0200, Markus Elfring wrote: > > --- > > Changes

[PATCH v4] staging: most: Delete an error message for a failed memory allocation

2019-07-14 Thread Keyur Patel
This error message for a failed memory allocation is redundant as kfifo_alloc just calls kmalloc_array without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v4: - change subject line - improve commit description - fix checkpatch warning drivers

Re: [v4] staging: most: remove redundant print statement when kfifo_alloc fails

2019-07-14 Thread Keyur Patel
I didn't get you. I stiil need to update changelog and send more version or not. If you say so, I can send one more. Thnaks. On Sun, Jul 14, 2019 at 05:23:34PM +0200, Markus Elfring wrote: > > --- > > Changes in v3: > > Thanks for your quick response. > > I find the change log incomplete (even

Re: [v4] staging: most: remove redundant print statement when kfifo_alloc fails

2019-07-14 Thread Keyur Patel

[PATCH v4] staging: most: remove redundant print statement when kfifo_alloc fails

2019-07-14 Thread Keyur Patel
This print statement is redundant as kfifo_alloc just calls kmalloc_array without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v3: - fix checkpatch warning drivers/staging/most/cdev/cdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH] scsi: g_NCR5380: Use !x in place of NULL comparisons

2019-07-11 Thread Keyur Patel
Change (x == NULL) to !x and (x != NULL) to x, to fix following checkpatch.pl warnings: CHECK: Comparison to NULL could be written "!x". Signed-off-by: Keyur Patel --- drivers/scsi/g_NCR5380.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/g_NCR5380.c

[PATCH] scsi: aha1740: Use !x in place of NULL comparisons

2019-07-11 Thread Keyur Patel
Change (x == NULL) to !x and (x != NULL) to x, to fix following checkpatch.pl warnings: CHECK: Comparison to NULL could be written "!x". Signed-off-by: Keyur Patel --- drivers/scsi/aha1740.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/aha1740.c

[PATCH v3] staging: most: remove redundant print statement when kfifo_alloc fails

2019-07-11 Thread Keyur Patel
This print statement is redundant as kfifo_alloc just calls kmalloc_array and without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel Changes in v3: - fix checkpatch warrning --- drivers/staging/most/cdev/cdev.c | 4 +--- 1 file changed, 1 insertion(+), 3

[PATCH v2] staging: most: remove redundant print statement when

2019-07-11 Thread Keyur Patel
This print statement is redundant as kfifo_alloc just calls kmalloc_array and without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- Changes in v2: - Edit subject line. --- drivers/staging/most/cdev/cdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 2/2] staging: most: remove redundant print statement when kfifo_alloc fails

2019-07-11 Thread Keyur Patel
This print statement is redundant as kfifo_alloc just calls kmalloc_array and without the __GFP_NOWARN flag, already does a dump_stack(). Signed-off-by: Keyur Patel --- drivers/staging/most/cdev/cdev.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/most

Re: [PATCH] staging: greybus: add logging statement when kfifo_alloc fails

2019-07-10 Thread Keyur Patel
On Wed, Jul 10, 2019 at 06:35:38PM +0200, Greg Kroah-Hartman wrote: > On Wed, Jul 10, 2019 at 08:20:17AM -0400, Keyur Patel wrote: > > Added missing logging statement when kfifo_alloc fails, to improve > > debugging. > > > > Signed-off-by: Keyur Patel > > --- &g

[PATCH] staging: greybus: add logging statement when kfifo_alloc fails

2019-07-10 Thread Keyur Patel
Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel --- drivers/staging/greybus/uart.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index b3bffe91ae99

[PATCH v2] gnss: core: added logging statement when kfifo_alloc fails

2019-07-09 Thread Keyur Patel
Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel --- Changes in v2: - fixed braces --- drivers/gnss/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c index e6f94501cb28

[PATCH] gnss: core: added logging statement when kfifo_alloc fails

2019-07-09 Thread Keyur Patel
Added missing logging statement when kfifo_alloc fails, to improve debugging. Signed-off-by: Keyur Patel --- drivers/gnss/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gnss/core.c b/drivers/gnss/core.c index e6f94501cb28..4377adfa25b4 100644 --- a/drivers/gnss/core.c +++ b

[PATCH] usb: core: Replace hardcoded check with inline function from usb.h

2019-02-19 Thread Keyur Patel
From: Keyur Patel Expression (urb->transfer_flags & URB_DIR_MASK) == URB_DIR_IN can be replaced by usb_urb_dir_in(struct urb *urb) from usb.h for better readability. Signed-off-by: Keyur Patel --- drivers/usb/core/devio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] orinoco : Replace function name in string with __func__

2019-02-17 Thread Keyur Patel
From: Keyur Patel Replace hard coded function name with __func__, to improve robustness and to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by: Keyur Patel --- drivers/net/wireless/intersil/orinoco/mic.c | 10 +- 1 file changed, 5 insertions(+), 5

Linux Kernel has additional MACSEC support

2017-11-22 Thread Keyur Patel
Hi,   Is there any development going on related to macsec in Linux Kernel except the current support driver from Sabrina?   Can any body help me to understand Linux TC framework?   Regards, Keyur Patel