Re: [PATCH] ASoC: Intel: sst: ipc command timeout

2020-05-05 Thread Keyon Jie
On 4/22/20 12:16 AM, Lu, Brent wrote: Regs width difference between BDW and BYT comes from specification. BDW has IPC registers which are 32 wide. This fact ain't exactly the reason to modify sst_shim32_read64. I'm sharing Amadeo's point of view. Your change should slow down execution a bit

Re: [alsa-devel] [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger

2017-08-06 Thread Keyon Jie
on it, so looks it's better to root cause and fix this noise issue, other than workaround to reset pcm_data->hw_ptr which may introduce new issues. Thanks, ~Keyon Thanks! On Tue, Aug 1, 2017 at 1:04 PM, Keyon Jie wrote: On 2017年08月01日 11:30, Vinod Koul wrote: On Mon, Jul 31,

Re: [alsa-devel] [PATCH v2] ASoC: Intel: Reset hw_ptr on resume trigger

2017-07-31 Thread Keyon Jie
On 2017年08月01日 11:30, Vinod Koul wrote: On Mon, Jul 31, 2017 at 06:47:34PM +0800, Cheng-Yi Chiang wrote: From: "U. Artie Eoff" Reset the hw_ptr before queuing the restore_stream_context work to eradicate a nasty white audio noise on resume. Liam, Jie? This on legacy BYT driver.. Tested-b

Re: [alsa-devel] [PATCH] ASoC: intel: remove unused variable data and associated code

2017-03-27 Thread Keyon Jie
On 2017年03月22日 22:36, Colin King wrote: From: Colin Ian King The variable 'data' is assigned null and never re-assigned. There is also a redundant check for data being non-null which is always false, so remove this and the variable data and dma_addr as they are not used once the dead code has

Re: [alsa-devel] [PATCH 1/7] ASoC: intel: broadwell: constify snd_soc_ops structures

2016-10-16 Thread Keyon Jie
On 2016年10月15日 22:55, Julia Lawall wrote: Check for snd_soc_ops structures that are only stored in the ops field of a snd_soc_dai_link structure. This field is declared const, so snd_soc_ops structures that have this property can be declared as const also. The semantic patch that makes this ch