Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-12-04 Thread Kenji Kaneshige
Hi Alex-san, Hi Kenji-san, * Kenji Kaneshige <[EMAIL PROTECTED]>: Hi Alex-san, On my system, hotplug slots themselves can be added, removed and replaced with the ohter type of I/O box. Are you talking about some sort of I/O cabinet/chassis that you can attach to the actual compute

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-12-02 Thread Kenji Kaneshige
patch. It would happen on other machines (might including hp machine) too. The reason is _STA evaluation fails on the hotplug slot which doesn't have _STA method. If the device object doesn't have a _STA method, we need to handle it as if it is present. I believe firmware normally doesn&#x

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-28 Thread Kenji Kaneshige
for reporting this so late. I'm attaching the patch to fix the problem. This is against 2.6.24-rc3 with your patches applied. Could you try it? BTW, acpiphp also seems to have the same problem... Thanks, Kenji Kaneshige --- drivers/acpi/pci_slot.c | 13 + 1 file changed, 13

Re: [PATCH 0/4, v3] Physical PCI slot objects

2007-11-19 Thread Kenji Kaneshige
tplug drivers only visiting your new code when the pci_slot driver is loaded, although I think this would be more difficult to implement. I agree to Gary very much. Thanks, Kenji Kaneshige - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Kenji Kaneshige
able to register kobject 1024<3>pci_slot: pci_create_slot returned -22 Thanks, Kenji Kaneshige Alex Chiang : Hello, [this patch series touches a few subsystems; hopefully I got all the right maintainers] Recently, Matthew Wilcox sent out the following mail about PCI slots: http://mar

Re: [PATCH 0/5][RFC] Physical PCI slot objects

2007-11-14 Thread Kenji Kaneshige
w the specific reason why it was added. is slot number decided according to the shpc specification, as you said. Thanks, Kenji Kaneshige - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: [Pcihpd-discuss] [PATCH 1/3] pciehp: hotplug: deal with pre-inserted ExpressCards

2007-10-18 Thread Kenji Kaneshige
Mark Lord さんは書きました: > Kenji Kaneshige wrote: >> >> - When the card is inserted *after* modprobing pciehp, the card >>is *not* automatically powered on/detected. So it is very >>natural that the card, which had been inserted before modprobing >>pciehp

Re: [Pcihpd-discuss] [PATCH 1/3] pciehp: hotplug: deal with pre-inserted ExpressCards

2007-10-18 Thread Kenji Kaneshige
sortware programmable power controller. So there is no contradiction. I think your patch has a bad effect to this kind of slots. So I think your patch needs additional checks to see if the slot should be enabled or not. And you need to test your patch on PCIe Native hotplug capable hardw

Re: [Pcihpd-discuss] [PATCH 1/3] pciehp: hotplug: deal with pre-inserted ExpressCards

2007-10-18 Thread Kenji Kaneshige
i/slots/XXX/*"? (6) I think your slot is surprise removable. Is it correct? Thanks, Kenji Kaneshige (repost to conform with akpm's subject line conventions) One of three patches to fix PCIe Hotplug so that it works with ExpressCard slots on Dell notebooks (and others?) in

Re: "Add support for vector domain" breaks boot on x355

2007-07-31 Thread Kenji Kaneshige
ommit. Thank you for reporting. I think this problem might be fixed by the commit 6ffbc82351c62aeb9e817ddf93049353493d. Could you try that? Thanks, Kenji Kaneshige - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTEC

Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-14 Thread Kenji Kaneshige
duction environment. Thanks, Kenji Kaneshige 2007-05-11 (金) の 09:25 -0700 に Stephen Hemminger さんは書きました: > On Fri, 11 May 2007 14:40:45 +0900 > Kenji Kaneshige <[EMAIL PROTECTED]> wrote: > > > Hi, > > > > I encountered the following error when I was ho

Re: [BUG][PATCH] Fix race condition about network device name allocation

2007-05-13 Thread Kenji Kaneshige
an now. Does it have no side effect? I'm worrying about if there are somebody that depend on sysfs entry until net_run_todo() is called. Anyway, I'll try your patch. Thanks, Kenji Kaneshige 2007-05-11 (金) の 09:25 -0700 に Stephen Hemminger さんは書きました: > On Fri, 11 May 2007 14:40:45 +0900 &

[BUG][PATCH] Fix race condition about network device name allocation

2007-05-10 Thread Kenji Kaneshige
list and snapshot list to find a suitable id. If some devices exists on the todo list or snapshot list, sysfs entries corresponding to them are not deleted yet. Thanks, Kenji Kaneshige --- Fix the race condition between dev_alloc_name() and net device unregistration. dev_alloc_name checks `dev

Re: [PATCH][BUG] Fix possible NULL pointer access in 8250 serial driver

2007-04-18 Thread Kenji Kaneshige
roblem is fixed by it. Thanks, Kenji Kaneshige This patch fixes the problem that uninitialized (NULL) 'info' member of uart_port structure can be accessed if serial driver is accessed through /proc filesystem before uart_open(), which initializes the 'info' member', is call

Re: [PATCH] Update Documentation/pci.txt v7

2006-12-25 Thread Kenji Kaneshige
ry. "Old style" is now deprecated. Don't use it. Left description in to document existing driver behaviors. o add section "Legacy I/O Port free driver" by Kenji Kaneshige http://lkml.org/lkml/2006/11/22/25 (renamed to "pci_enable_device_bars() and Legacy I/O Po

[BUG][PATCH] pcieport-driver: remove invalid warning message

2006-12-06 Thread Kenji Kaneshige
ch don't use an interrupt pin. Thanks, Kenji Kaneshige The following warning message should not be displayed for devices which don't use an interrupt pin. pcie_portdrv_probe->Dev[:] has invalid IRQ. Check vendor BIOS Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]

[PATCH 2.6.13 2/4] Cleanup - remove unnecessary handle_IRQ_event() prototype (ppc)

2005-09-07 Thread Kenji Kaneshige
The function prototype for handle_IRQ_event() in include/asm-ppc/irq.h seems no longer needed because ppc uses GENERIC_HARDIRQ. This patch removes it. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> include/asm-ppc/irq.h |4 1 files changed, 4 deletions(-) Index: linux-

[PATCH 2.6.13 4/4] Cleanup - remove unnecessary handle_IRQ_event() prototype (x86_64)

2005-09-07 Thread Kenji Kaneshige
The function prototype for handle_IRQ_event() in include/asm-x86_64/irq.h seems no longer needed because x86_64 uses GENERIC_HARDIRQ. This patch removes it. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> include/asm-x86_64/irq.h |4 1 files changed, 4 deletions(-) Index:

[PATCH 2.6.13 3/4] Cleanup - remove unnecessary handle_IRQ_event() prototype (sh)

2005-09-07 Thread Kenji Kaneshige
The function prototype for handle_IRQ_event() in include/asm-sh/irq.h seems no longer needed because sh uses GENERIC_HARDIRQ. This patch removes it. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> include/asm-sh/irq.h |4 1 files changed, 4 deletions(-) Index: linux-2.6.13/i

[PATCH 2.6.13 1/4] Cleanup - remove unnecessary handle_IRQ_event() prototype (mips)

2005-09-07 Thread Kenji Kaneshige
The function prototype for handle_IRQ_event() in include/asm-mips/irq.h seems no longer needed because mips uses GENERIC_HARDIRQ. This patch removes it. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> include/asm-mips/irq.h |3 --- 1 files changed, 3 deletions(-) Index: linux-

[PATCH 2.6.13 0/4] Cleanup - remove unnecessary handle_IRQ_event() prototype

2005-09-07 Thread Kenji Kaneshige
these architectures, these patches are not tested yet. I hope these patches will be tested by someone who has these architectures. Thanks, Kenji Kaneshige - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordom

Re: [ACPI] [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-03 Thread Kenji Kaneshige
Hi Bjorn, Thank you very much for the new patch and I'm very sorry for troubling you. The patch looks very good to me. Thanks, Kenji Kaneshige Bjorn Helgaas wrote: On Tuesday 02 August 2005 7:05 pm, Kenji Kaneshige wrote: This breaks the following patch that is already included int

Re: [ACPI] [PATCH] PNPACPI: fix types when decoding ACPI resources [resend]

2005-08-02 Thread Kenji Kaneshige
irq_resource[i].start = irq; + res->irq_resource[i].end = irq; } } This breaks the following patch that is already included into -mm tree. http://sourceforge.net/mailarchive/forum.php?thread_id=7844247&forum_id=6102 I think we need to check if acpi_register_gsi(

[PATCH 2.6.13-rc3 4/6] failure of acpi_register_gsi() should be handled properly - change phpacpi driver

2005-07-28 Thread Kenji Kaneshige
This patch adds the error check of acpi_register_gsi() into pnpacpi driver. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> --- linux-2.6.13-rc3-kanesige/drivers/pnp/pnpacpi/rsparser.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff -puN drivers/pnp/pnpacpi/rspa

[PATCH 2.6.13-rc3 6/6] failure of acpi_register_gsi() should be handled properly - change ia64 iosapic code

2005-07-28 Thread Kenji Kaneshige
Change iosapic_register_intr(), which called by acpi_register_gsi(), to return negative value on error instead of panic. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> --- linux-2.6.13-rc3-kanesige/arch/ia64/kernel/iosapic.c | 20 --- 1 files changed, 13 inse

[PATCH 2.6.13-rc3 0/6] failure of acpi_register_gsi() should be handled properly

2005-07-28 Thread Kenji Kaneshige
the case that acpi_register_gsi() fails. I think failure of acpi_register_gsi() should be handled properly. This series of patches changes acpi_register_gsi() to return negative value on error, and also changes callers of acpi_register_gsi() to handle failure of acpi_register_gsi(). Thanks, Kenji

[PATCH 2.6.13-rc3 5/6] failure of acpi_register_gsi() should be handled properly - change acpi based 8250 driver

2005-07-28 Thread Kenji Kaneshige
This patch adds the error check of acpi_register_gsi() into ACPI based 8250 serial driver. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> --- linux-2.6.13-rc3-kanesige/drivers/serial/8250_acpi.c | 20 +++ 1 files changed, 16 insertions(+), 4 deletions(-) dif

[PATCH 2.6.13-rc3 2/6] failure of acpi_register_gsi() should be handled properly - change acpi pci code

2005-07-28 Thread Kenji Kaneshige
This patch adds the error check of acpi_register_gsi() into acpi_pci_enable_irq(). Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> --- linux-2.6.13-rc3-kanesige/drivers/acpi/pci_irq.c |9 - 1 files changed, 8 insertions(+), 1 deletion(-) diff -puN drivers/acpi/pci

[PATCH 2.6.13-rc3 3/6] failure of acpi_register_gsi() should be handled properly - change hpet driver

2005-07-28 Thread Kenji Kaneshige
This patch adds the error check of acpi_register_gsi() into hpet driver. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> --- linux-2.6.13-rc3-kanesige/drivers/char/hpet.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff -puN drivers/char/hpet.c~handle

[PATCH 2.6.13-rc3 1/6] failure of acpi_register_gsi() should be handled properly - change acpi_register_gsi() interface

2005-07-28 Thread Kenji Kaneshige
This patch changes the type of return value of acpi_register_gsi() from "unsigned int" to "int" to indicate an error. If acpi_register_gsi() fails to register gsi, it returns negative value. Signed-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> --- linux-2.6.13-rc3

Re: [patch] properly stop devices before poweroff

2005-07-27 Thread Kenji Kaneshige
hould be removed from -mm tree. Thanks, Kenji Kaneshige Luck, Tony wrote: I started on my OLS homework from Andrew ... and began looking into what is going on here. The story so far: Pavel added calls to device_suspend() to three of the cases in the sys_reboot() path. This stopped ia64 from

Re: [RFC][PATCH] i386: Per node IDT

2005-07-11 Thread Kenji Kaneshige
. Even when we use per node approach, we need to consider interrupt migration between nodes because all CPUs on the node could be hot-removed. Thanks, Kenji Kaneshige - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTE

[PATCH] 'is_enabled' flag should be set/cleared when the device is actually enabled/disabled

2005-04-07 Thread Kenji Kaneshige
functions (Bcalled through pci_enable_device()/pci_disable_device(). (B (BSigned-off-by: Kenji Kaneshige <[EMAIL PROTECTED]> (B (B (B--- (B (B linux-2.6.12-rc2-kanesige/drivers/pci/pci.c |7 +++ (B 1 files changed, 3 insertions(+), 4 deletions(-) (B (Bdiff -puN drivers/pci/p