[PATCHv3 2/3] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-07 Thread Ken Helias
From: Ken Helias All other add functions for lists have the new item as first argument and the position where it is added as second argument. This was changed for no good reason in this function and makes using it unnecessary confusing. The name was changed to let old code generate a compile

[PATCHv3 3/3] klist: Use same naming scheme as hlist for klist_add_after

2014-06-07 Thread Ken Helias
From: Ken Helias The name was modified from hlist_add_after to hlist_add_behind when adjusting the order of arguments to match the one with klist_add_after. This is necessary to avoid old code to compile against it when it would use it the wrong way. It would be good when klist would also

[PATCHv3 1/3] list: Use argument hlist_add_after names from rcu variant

2014-06-07 Thread Ken Helias
From: Ken Helias The argument names of the hlist_add_after are poorly chosen because they look the same as the ones from hlist_add_before but have to be used completely different. This easily confuses the reader. The creator of the hlist_add_after_rcu function has made a lot better choice

[PATCH 04/13] metag: dma: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH 07/13] PCI: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH 05/13] powerpc: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH 03/13] list: Add list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. hlist already have functions to do the same which makes the code a lot more

[PATCH 09/13] jfs: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH 10/13] xhci: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCHv2 02/13] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-06 Thread Ken Helias
From: Ken Helias All other add functions for lists have the new item as first argument and the position where it is added as second argument. This was changed for no good reason in this function and makes using it unnecessary confusing. Signed-off-by: Ken Helias Cc: Linux NICS Cc: "P

[PATCH 08/13] mac80211: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH 13/13] staging: tidspbridge: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH 06/13] EDAC: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCHv2 01/13] list: Use argument hlist_add_after names from rcu variant

2014-06-06 Thread Ken Helias
From: Ken Helias The argument names of the hlist_add_after are poorly chosen because they look the same as the ones from hlist_add_before but have to be used completely different. This easily confuses the reader. The creator of the hlist_add_after_rcu function has made a lot better choice

[PATCH 11/13] iscsi-target: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH 12/13] s390: Use list_add_(before|after) macros

2014-06-06 Thread Ken Helias
From: Ken Helias Many places in the code uses list_add_tail/list_add to insert an entry before/after another entry. This confuses the reader because these are usually used to add an item to a list_head and not an entry. Better use the self explaining function name. Signed-off-by: Ken Helias Cc

[PATCH] list: Fix order of arguments for hlist_add_after(_rcu)

2014-06-06 Thread Ken Helias
changed to use the same names as hlist_add_after_rcu. Signed-off-by: Ken Helias Cc: David Airlie Cc: Jeff Kirsher Cc: Jesse Brandeburg Cc: Bruce Allan Cc: Carolyn Wyborny Cc: Don Skidmore Cc: Greg Rose Cc: Alex Duyck Cc: John Ronciak Cc: Mitch Williams Cc: Linux NICS Cc: Alexander Viro Cc