Re: [PATCH v2] PCI/AER: Change to use helper pcie_aer_is_native() in some places

2021-02-26 Thread Kelley, Sean V
On 2/4/21, 6:07 PM, "Xiaofei Tan" wrote: Use helper function pcie_aer_is_native() in some places to keep the code tidy. No function changes. Signed-off-by: Xiaofei Tan Reviewed-by: Krzysztof Wilczyński Nice use of the helper and good suggestion from Krzysztof. Acked-by: S

Re: [PATCH 1/1] PCI/RCEC: Fix failure to inject errors to some RCiEP devices

2021-02-09 Thread Kelley, Sean V
> On Feb 9, 2021, at 6:05 PM, Qiuxu Zhuo wrote: > > On a Sapphire Rapids server, it failed to inject correctable errors > to the RCiEP device e8:02.0 which was associated with the RCEC device > e8:00.4. See the following error log before applying the patch: > > aer-inject -s e8:02.0 examples/

Re: [PATCH v12 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-12-07 Thread Kelley, Sean V
Hi Bjorn, > On Dec 5, 2020, at 1:30 PM, Bjorn Helgaas wrote: > > On Fri, Dec 04, 2020 at 05:17:58PM +0000, Kelley, Sean V wrote: >>> On Dec 3, 2020, at 4:01 PM, Bjorn Helgaas wrote: >>> On Thu, Dec 03, 2020 at 12:51:40AM +, Kelley, Sean V wrote: >>>

Re: [PATCH v12 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-12-04 Thread Kelley, Sean V
Hi Bjorn, > On Dec 3, 2020, at 4:01 PM, Bjorn Helgaas wrote: > > On Thu, Dec 03, 2020 at 12:51:40AM +0000, Kelley, Sean V wrote: >>> On Dec 2, 2020, at 3:44 PM, Bjorn Helgaas wrote: >>> On Fri, Nov 20, 2020 at 04:10:33PM -0800, Sean V Kelley wrote: >>>

Re: [PATCH v12 05/15] PCI/ERR: Simplify by using pci_upstream_bridge()

2020-12-03 Thread Kelley, Sean V
Hi Bjorn, Just confirming that when switched from dev->bus->self to pci_upstream_bridge() we’re okay with the NULL case: > On Nov 20, 2020, at 4:10 PM, Sean V Kelley wrote: > > Use pci_upstream_bridge() in place of dev->bus->self. No functional change > intended. > > [bhelgaas: split to sep

Re: [PATCH v12 12/15] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-12-02 Thread Kelley, Sean V
> On Dec 2, 2020, at 3:44 PM, Bjorn Helgaas wrote: > > On Fri, Nov 20, 2020 at 04:10:33PM -0800, Sean V Kelley wrote: >> From: Qiuxu Zhuo >> >> When attempting error recovery for an RCiEP associated with an RCEC device, >> there needs to be a way to update the Root Error Status, the Uncorrect

Re: [PATCH v12 10/15] PCI/ERR: Limit AER resets in pcie_do_recovery()

2020-12-02 Thread Kelley, Sean V
Hi Bjorn, > On Dec 2, 2020, at 1:27 PM, Bjorn Helgaas wrote: > > On Wed, Dec 02, 2020 at 08:53:54PM +0000, Kelley, Sean V wrote: >>> On Nov 30, 2020, at 4:25 PM, Bjorn Helgaas wrote: >>> On Mon, Nov 30, 2020 at 07:54:37PM +, Kelley, Sean V wrote: > >>

Re: [PATCH v12 10/15] PCI/ERR: Limit AER resets in pcie_do_recovery()

2020-12-02 Thread Kelley, Sean V
Hi Bjorn, > On Nov 30, 2020, at 4:25 PM, Bjorn Helgaas wrote: > > On Mon, Nov 30, 2020 at 07:54:37PM +0000, Kelley, Sean V wrote: >>> On Nov 24, 2020, at 9:17 AM, Bjorn Helgaas wrote: >>> On Mon, Nov 23, 2020 at 11:57:35PM +, Kelley, Sean V wrote: >>>&

Re: [PATCH v12 10/15] PCI/ERR: Limit AER resets in pcie_do_recovery()

2020-11-30 Thread Kelley, Sean V
> On Nov 30, 2020, at 4:25 PM, Bjorn Helgaas wrote: > > On Mon, Nov 30, 2020 at 07:54:37PM +0000, Kelley, Sean V wrote: >>> On Nov 24, 2020, at 9:17 AM, Bjorn Helgaas wrote: >>> On Mon, Nov 23, 2020 at 11:57:35PM +, Kelley, Sean V wrote: >>>>>

Re: [PATCH v12 10/15] PCI/ERR: Limit AER resets in pcie_do_recovery()

2020-11-30 Thread Kelley, Sean V
Hi Bjorn, Was away briefly for the holidays, comments below: > On Nov 24, 2020, at 9:17 AM, Bjorn Helgaas wrote: > > On Mon, Nov 23, 2020 at 11:57:35PM +0000, Kelley, Sean V wrote: >>> On Nov 23, 2020, at 3:28 PM, Bjorn Helgaas wrote: >>> On Fri, Nov 20, 2020

Re: [PATCH v12 10/15] PCI/ERR: Limit AER resets in pcie_do_recovery()

2020-11-23 Thread Kelley, Sean V
Hi Bjorn, > On Nov 23, 2020, at 3:28 PM, Bjorn Helgaas wrote: > > On Fri, Nov 20, 2020 at 04:10:31PM -0800, Sean V Kelley wrote: >> In some cases a bridge may not exist as the hardware controlling may be >> handled only by firmware and so is not visible to the OS. This scenario is >> also possib

Re: [PATCH v11 15/16] PCI/PME: Add pcie_walk_rcec() to RCEC PME handling

2020-11-18 Thread Kelley, Sean V
Hi Sathya, > On Nov 17, 2020, at 10:03 PM, Kuppuswamy, Sathyanarayanan > wrote: > > > > On 11/17/20 11:19 AM, Sean V Kelley wrote: >> Root Complex Event Collectors (RCEC) appear as peers of Root Ports and also >> have the PME capability. As with AER, there is a need to be able to walk >> the

Re: [PATCH v11 07/16] PCI/ERR: Simplify by computing pci_pcie_type() once

2020-11-17 Thread Kelley, Sean V
Hi Sathya, > On Nov 17, 2020, at 1:58 PM, Kuppuswamy, Sathyanarayanan > wrote: > > Hi, > > On 11/17/20 11:19 AM, Sean V Kelley wrote: >> Instead of calling pci_pcie_type(dev) twice, call it once and save the >> result. No functional change intended. > > Same optimization can be applied to dr

Re: [PATCH v11 02/16] PCI/RCEC: Add RCEC class code and extended capability

2020-11-17 Thread Kelley, Sean V
Hi Sathya, Thanks for reviewing > On Nov 17, 2020, at 12:07 PM, Kuppuswamy, Sathyanarayanan > wrote: > > Hi, > > On 11/17/20 11:19 AM, Sean V Kelley wrote: >> From: Qiuxu Zhuo >> A PCIe Root Complex Event Collector (RCEC) has base class 0x08, sub-class >> 0x07, and programming interface 0x00

Re: [PATCH v8 11/14] PCI/RCEC: Add RCiEP's linked RCEC to AER/ERR

2020-10-09 Thread Kelley, Sean V
On Fri, 2020-10-09 at 15:07 -0700, Sean V Kelley wrote: > On 9 Oct 2020, at 14:30, Bjorn Helgaas wrote: > > > On Fri, Oct 09, 2020 at 12:57:45PM -0500, Bjorn Helgaas wrote: > > > On Fri, Oct 02, 2020 at 11:47:32AM -0700, Sean V Kelley wrote: > > > > From: Qiuxu Zhuo > > > > > > > > When attempti

Re: [PATCH v3 04/10] PCI/RCEC: Add pcie_walk_rcec() to walk associated RCiEPs

2020-09-04 Thread Kelley, Sean V
Hi Bjorn, Quick question below... On Wed, 2020-09-02 at 14:55 -0700, Sean V Kelley wrote: > Hi Bjorn, > > On Wed, 2020-09-02 at 14:00 -0500, Bjorn Helgaas wrote: > > On Wed, Aug 12, 2020 at 09:46:53AM -0700, Sean V Kelley wrote: > > > From: Qiuxu Zhuo > > > > > > When an RCEC device signals er