Re: [PATCH v2] selftests/seccomp: Improve error logging in get_proc_stat()

at was in your v1. :) > > Suggested-by: Kees Cook > No blank line here -- other tags should all be together with the S-o-b line. > Signed-off-by: Sameeksha Sankpal > --- > v1 -> v2: > - Used TH_LOG instead of printf for error logging > - Moved variable declaration t

Re: [PATCH] selftests: seccomp: Fix "performace" to "performance"

On Fri, 16 May 2025 18:17:22 -0700, Sumanth Gavini wrote: > Fix misspelling reported by codespell > > Applied to for-next/seccomp, thanks! [1/1] selftests: seccomp: Fix "performace" to "performance" https://git.kernel.org/kees/c/a9b33aae79ce Take care, -- Kees Cook

Re: [PATCH] selftests/seccomp: report errno and add hints on failure

to use is TH_LOG, probably like this: rc = get_nth(_metadata, proc_path, 3, &line); ASSERT_EQ(rc, 1) { TH_LOG("user_notification_fifo: failed to read stat for PID %d (rc=%d)", pid, rc); } And please don't introduce new variables in the middle -- they need to be declared at the top of the function. -Kees -- Kees Cook

Re: [PATCH 04/12] mm: move randomize_va_space into memory.c

a greater effort to move ctl tables into their > respective subsystems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH] selftests/seccomp: fix negative_ENOSYS tracer tests on arm32

fix negative_ENOSYS tracer tests on arm32 https://git.kernel.org/kees/c/73989c998814 Take care, -- Kees Cook

Re: [PATCH 1/3] selftests/timens: Print TAP headers

o need to track level any more. If you want to be able to explicitly supress KTAP output, that's probably a new thing to be added. But normally it's not needed -- things should be fairly readable even with KTAP output. -- Kees Cook

Re: [PATCH 03/12] rcu: Move rcu_stall related sysctls into rcu/tree_stall.h

gt; one file. > > This is part of a greater effort to move ctl tables into their > respective subsystems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 05/12] parisc/power: Move soft-power into power.c

educe the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 06/12] fork: mv threads-max into kernel/fork.c

cts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 09/12] sysctl: move cad_pid into kernel/pid.c

f CONFIG_PROC_SYSCTL > + { > + .procname = "cad_pid", > + .data = NULL, nit: this is redundant, any unspecified member will be zero-initialized. Regardless: Reviewed-by: Kees Cook > + .maxlen = sizeof(int), > +

Re: [PATCH 08/12] sysctl: Move tainted ctl_table into kernel/panic.c

ems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 12/12] sysctl: Remove superfluous includes from kernel/sysctl.c

ilter.h > linux/binfmts.h > > Signed-off-by: Joel Granados This is very nice! :) Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 11/12] sysctl: Remove (very) old file changelog

On Fri, May 09, 2025 at 02:54:15PM +0200, Joel Granados wrote: > These comments are older than 2003 and therefore do not bare any > relevance on the current state of the sysctl.c file. Remove them as they > confuse more than clarify. > > Signed-off-by: Joel Granados Reviewe

Re: [PATCH 02/12] locking/rtmutex: Move max_lock_depth into rtmutex.c

effort to move ctl tables into their > respective subsystems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados Yup, all looks good, including the variable relocation. Reviewed-by: Kees Cook > --- > include/linux/rtmutex.h |

Re: [PATCH 07/12] Input: sysrq: mv sysrq into drivers/tty/sysrq.c

sctl.c. nit: do_proc_dointvec_minmax > > This is part of a greater effort to move ctl tables into their > respective subsystems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados But yes, this looks correct. Reviewed-by: Kees Cook

Re: [PATCH 10/12] sysctl: Move sysctl_panic_on_stackoverflow to kernel/panic.c

s one should be called "panic_on_stack_exhaustion", but so be it. :) Reviewed-by: Kees Cook > --- > kernel/panic.c | 10 ++ > kernel/sysctl.c | 10 -- > 2 files changed, 10 insertions(+), 10 deletions(-) > > diff --gi

Re: [PATCH RESEND] selftests/seccomp: fix syscall_restart test for arm compat

_restart test for arm compat https://git.kernel.org/kees/c/797002deed03 Take care, -- Kees Cook

Re: [PATCH v3 00/32] kselftest harness and nolibc compatibility

> > > base > > > further patches on. For that I'd like to pick up all the nolibc patches > > > from > > > this series through the nolibc tree. They got Acks from Willy. > > > > > > Any objections? > > > > No objection on my side! > > > > Thanks. > > Kees, do you have any comments on this series? If you are okay > with it, I would like to apply this for next. Fine by me! :) -- Kees Cook

Re: [PATCH] lib: Ensure prime numbers tests are included in KUnit test runs

l_tests.config so they are enabled when the KUnit > runner builds the kernel. > > > [...] Applied to for-linus/hardening, thanks! [1/1] lib: Ensure prime numbers tests are included in KUnit test runs https://git.kernel.org/kees/c/4ea404fdbc39 Take care, -- Kees Cook

Re: [PATCH v2] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME_NUMBERS

f --git a/tools/testing/kunit/configs/all_tests.config b/tools/testing/kunit/configs/all_tests.config index cdd9782f9646..554da9df02f2 100644 --- a/tools/testing/kunit/configs/all_tests.config +++ b/tools/testing/kunit/configs/all_tests.config @@ -51,3 +51,5 @@ CONFIG_SOUND=y CONFIG_SND=y CONFIG_SND_SOC=y CONFIG_SND_SOC_TOPOLOGY_BUILD=y + +CONFIG_PRIME_NUMBERS=y -- Kees Cook

Re: [PATCH v2] lib: PRIME_NUMBERS_KUNIT_TEST should not select PRIME_NUMBERS

https://git.kernel.org/kees/c/3f2925174f8b Take care, -- Kees Cook

Re: [PATCH 4/4] sysctl: Close test ctl_headers with a for loop

:) Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 3/4] sysctl: call sysctl tests with a for loop

viewed-by: Kees Cook -- Kees Cook

Re: [PATCH 1/4] sysctl: move u8 register test to lib/test_sysctl.c

to lib/test_sysctl.c where the registration reference is > handled on module exit > > 'Fixes: b5ffbd139688 ("sysctl: move the extra1/2 boundary check of u8 to Typoe: drop leading ' > sysctl_check_table_array")' And avoid wrapping this line for the field. >

Re: [PATCH 2/4] sysctl: Add 0012 to test the u8 range check

out of range. > > Signed-off-by: Joel Granados Reviewed-by: Kees Cook -- Kees Cook

Re: (subset) [PATCH v9 0/6] scanf: convert self-test to KUnit

.org/kees/c/5866730da723 [2/6] scanf: remove redundant debug logs https://git.kernel.org/kees/c/6340d61b9005 [3/6] scanf: convert self-test to KUnit https://git.kernel.org/kees/c/97c1f302f2bc [4/6] scanf: break kunit into test cases https://git.kernel.org/kees/c/d62f8c95470c Take care, -- Kees Cook

Re: [PATCH v9 0/6] scanf: convert self-test to KUnit

next and the next merge window. > > > scanf: tidy header `#include`s > > This one is a bit controversial and might be added later. > > > scanf: further break kunit into test cases > > This one was just an attempt. But I personally think that > it is not worth it. > > Best Regards, > Petr -- Kees Cook

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

On Fri, Mar 14, 2025 at 05:48:00PM +0100, Christophe Leroy wrote: > > > Le 12/03/2025 à 17:30, Kees Cook a écrit : > > On Wed, Mar 12, 2025 at 04:45:24PM +0100, Vlastimil Babka wrote: > > > On 3/6/25 17:57, Luis Chamberlain wrote: > > > > + linux-

Re: [PATCH] module: Taint the kernel when write-protecting ro_after_init fails

the file. Additionally, merge the > >> message on a single line because checkpatch.pl recommends that for the > >> ability to grep for the string. > >> > >> Suggested-by: Kees Cook > >> Signed-off-by: Petr Pavlu > >> --- > >> I opted to

Re: [PATCH v3 0/2] scanf: convert self-test to KUnit

can carry this in the "lib/ kunit tests move to lib/tests/" tree. -Kees -- Kees Cook

Re: [PATCH] selftets: lib: remove reference to prime_numbers

On Fri, Feb 21, 2025 at 08:04:05PM -0500, Tamir Duberstein wrote: > On Fri, Feb 21, 2025 at 7:57 PM Kees Cook wrote: > > > > On Mon, 17 Feb 2025 08:30:44 -0500, Tamir Duberstein wrote: > > > Remove a leftover shell script reference from commit 313b38a6ecb4 > > >

Re: [PATCH] selftets: lib: remove reference to prime_numbers

selftets: lib: remove reference to prime_numbers https://git.kernel.org/kees/c/03d0e920d775 Take care, -- Kees Cook

Re: [PATCH] selftests:sysctl:Fix minor grammers in sysctl test

uot; > echo "make sure the test passes a series of tests." > echo > - echo Example uses: > + echo Example usage: > echo > echo "$TEST_NAME.sh-- executes all tests" > echo "$TEST_NAME.sh -t 0002-- Executes test ID 0002 number of times > is recomended" > -- > 2.34.1 > -- Kees Cook

Re: [PATCH v2 2/2] unicode: kunit: change tests filename and path

t right now. > > > > Log: > > https://download.copr.fedorainfracloud.org/results/@kernel-vanilla/next/fedora-rawhide-x86_64/08642966-next-next-all/builder-live.log.gz > > > > Cioa, Thorsten > > > > Hmm... this definitely seems like a problem, but I haven't been able > to reproduce it here (either under x86_64 or UML, both as a module and > built-in). The suggested fix of changing the path to "../utf8n.h" > doesn't seem to have broken it, though. Thanks for the reports! I've squashed this path correction into my tree and it should be fix in the next -next. :) -Kees -- Kees Cook

Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

ut instead of in the same work tree. :( -- Kees Cook

Re: [PATCH v5 2/2] lib/prime_numbers: convert self-test to KUnit

rtions(+), 77 deletions(-) Thanks! I've applied this and rebased it onto: https://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git/log/?h=for-next/move-kunit-tests -- Kees Cook

Re: [PATCH 0/6] KUnit test moves / renames

.com/ > > [2] > > --- > > > > Bruno Sobreira França (1): > >lib/math: Add int_log test suite > > > > Diego Vieira (1): > >lib/tests/kfifo_kunit.c: add tests for the kfifo structure > > > > Gabriela Bittencourt (2): > >

Re: [PATCH 02/16] elf, uapi: Add definition for STN_UNDEF

gt; Link: https://refspecs.linuxfoundation.org/elf/gabi4+/ch4.symtab.html > Signed-off-by: Thomas Weißschuh Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 04/16] elf, uapi: Add definitions for VER_FLG_BASE and VER_FLG_WEAK

docs.oracle.com/cd/E19683-01/816-1386/chapter6-80869/index.html > Signed-off-by: Thomas Weißschuh Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 06/16] elf, uapi: Add types ElfXX_Verdef and ElfXX_Veraux

Link: > https://refspecs.linuxfoundation.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/symversion.html#VERDEFEXTS > Signed-off-by: Thomas Weißschuh Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 05/16] elf, uapi: Add type ElfXX_Versym

; > Signed-off-by: Thomas Weißschuh Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 03/16] elf, uapi: Add definition for DT_GNU_HASH

Link: > https://refspecs.linuxbase.org/LSB_5.0.0/LSB-Core-generic/LSB-Core-generic/libc-ddefs.html > Signed-off-by: Thomas Weißschuh Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 04/16] elf, uapi: Add definitions for VER_FLG_BASE and VER_FLG_WEAK

On Tue, Feb 04, 2025 at 04:17:03PM +0100, Thomas Weißschuh wrote: > On Tue, Feb 04, 2025 at 07:10:00AM -0800, Kees Cook wrote: > > On Mon, Feb 03, 2025 at 10:05:05AM +0100, Thomas Weißschuh wrote: > > > The definitions are used by tools/testing/selftests/vDSO/parse_vdso.c. &

Re: [PATCH 04/16] elf, uapi: Add definitions for VER_FLG_BASE and VER_FLG_WEAK

ed libc header somewhere? -Kees -- Kees Cook

Re: [RFC PATCH v1 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

ritten function pointer, not that they already have arbitrary execution control. (i.e. taking a "jump anywhere" primitive and upgrading it to "execute anything".) Is the expectation that existing ROP/JOP techniques make protecting memfd irrelevant? -- Kees Cook

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

main declaration with argc/argv present. But it's mostly aesthetic. And if you think use of kselftest.h isn't universal, then perhaps we can avoid the macro, but it does seem nicer and more "normal" feeling for the rest of kernel development. -Kees -- Kees Cook

Re: [PATCH 01/16] selftests/mm: remove argc and argv unused parameters

-git a/tools/testing/selftests/mm/hugetlb-madvise.c > b/tools/testing/selftests/mm/hugetlb-madvise.c > index e74107185324f..43f16c12c8e9a 100644 > --- a/tools/testing/selftests/mm/hugetlb-madvise.c > +++ b/tools/testing/selftests/mm/hugetlb-madvise.c > @@ -58,7 +58,7 @@ void read_fault_pages(void *addr, unsigned long nr_pages) > } > } > > -int main(int argc, char **argv) > +int main(int __attribute__((unused)) argc, char **argv) Can we add a macro in kselftest.h for "__unused" like the kernel already does? Then instead of removing args, we can just mark them, like you're doing here. -- Kees Cook

Re: [RFC PATCH v1 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

On Wed, Jan 08, 2025 at 07:06:13PM +, Lorenzo Stoakes wrote: > On Mon, Jan 06, 2025 at 04:44:33PM -0800, Kees Cook wrote: > > On Mon, Jan 06, 2025 at 10:26:27AM -0800, Jeff Xu wrote: > > > + Kees because this is related to W^X memfd and security. > > > > > >

Re: [PATCH] selftests: harness: fix printing of mismatch values in __EXPECT()

:Expected exp_args[2] (3134324433) > == info.entry.args[1] (18446744072548908753) > > Fixes: b5bb6d3068ea ("selftests/seccomp: fix 32-bit build warnings") > Signed-off-by: Dmitry V. Levin Ah nice, thanks! Reviewed-by: Kees Cook -- Kees Cook

Re: [RFC PATCH v1 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

e cover > > letter, it wouldn't matter that much to an attacker whether the > > mapping is shared or private (as long as the VMA contents haven't been > > CoWed already). > +1 on this. > The concept of blocking this for only shared mapping is questionable. Right -- why does sharedness matter? It seems more robust to me to not create a corner case but rather apply the flag/behavior universally? -- Kees Cook

Re: [PATCH v1 0/3] module: Don't fail module loading when setting ro_after_init section RO failed

mode for that?) Also, why is it too late to cancel? Can we set the module to the "Unloading" state to stop any dependent modules from loading on top of it, and then request it unload? -- Kees Cook

Re: [PATCH v2 1/2] fs/proc: do_task_stat: Fix ESP not readable during coredump

it doesn't hurt to keep. > > Fixes: 92307383082d ("coredump: Don't perform any cleanups before dumping > core") > Cc: sta...@vger.kernel.org > Cc: Eric W. Biederman > Acked-by: Oleg Nesterov > Signed-off-by: Nam Cao Thanks for fixing this! Acked-by: Kees Cook -- Kees Cook

Re: [PATCH v2 2/2] selftests: coredump: Add stackdump test

mes appearing in /tmp for selftests. -Kees -- Kees Cook

Re: [RFC PATCH] get_maintainer: decouple subsystem status from maintainer role

rt of > the subsystem name. So for example, instead of "(supporter:SUBSYSTEM)" > report "(maintainer:SUBSYSTEM [supported])". > > [1] > https://lore.kernel.org/all/20221006162413.858527-1-bryan.odonog...@linaro.org/ > > Cc: "Theodore Ts'o&quo

Re: [PATCH 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case

On Sat, Nov 02, 2024 at 11:29:55AM +, Zbigniew Jędrzejewski-Szmek wrote: > On Thu, Oct 31, 2024 at 03:10:37PM -0700, Kees Cook wrote: > > On Wed, 30 Oct 2024 14:37:31 -0600, Tycho Andersen wrote: > > > Zbigniew mentioned at Linux Plumber's that systemd is intereste

Re: [PATCH 1/2] exec: fix up /proc/pid/comm in the execveat(AT_EMPTY_PATH) case

at(AT_EMPTY_PATH) case https://git.kernel.org/kees/c/7bdc6fc85c9a [2/2] selftests/exec: add a test for execveat()'s comm https://git.kernel.org/kees/c/bd104872311a Take care, -- Kees Cook

Re: [PATCH v2 1/2] exec: add a flag for "reasonable" execveat() comm

s regardless of bprm->fdpath. > > It will be a change of behavior on when executing symlinks and possibly > mount points but I don't think we care. If we do then we can add make > it conditional with "if (bprm->fdpath)" > > At the very least using the above version unconditionally ought to flush > out any bugs. I'm not super comfortable doing this regardless of bprm->fdpath; that seems like too many cases getting changed. Can we just leave it as depending on bprm->fdpath? Also, is d_name.name always going to be set? e.g. what about memfd, etc? -- Kees Cook

Re: [PATCH] kunit: Fix missing kerneldoc comment

not described in 'kunit_kfree_const' > > Reported-by: Stephen Rothwell > Closes: https://lore.kernel.org/lkml/20240827160631.67e12...@canb.auug.org.au/ > Fixes: f2c6dbd22017 ("kunit: Device wrappers should also manage driver name") > Signed-off-by: David Gow Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG

suffix before sorting symbols https://git.kernel.org/kees/c/020925ce9299 [2/2] kallsyms: Match symbols exactly with CONFIG_LTO_CLANG https://git.kernel.org/kees/c/fb6a421fb615 Take care, -- Kees Cook

Re: [PATCH v3 0/2] Fix kallsyms with CONFIG_LTO_CLANG

ching is probably not used by a lot of users, so I guess we > are OK without Fixes tags? I personally don't have a strong preference > either way. > > It is not necessary to invert the order of the two patches. Only applying > one of the two patches won't cause more issues than what we have today. Which tree should carry this series? -- Kees Cook

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

On Fri, Jul 05, 2024 at 09:10:36AM +0200, Peter Zijlstra wrote: > On Wed, Jul 03, 2024 at 01:36:19PM -0700, Kees Cook wrote: > > > Yes, please use struct_size_t(). This is exactly what it was designed for. > > Kees, please, just let up, not going to happen. I'm getting re

Re: [PATCHv2 bpf-next 1/9] uprobe: Add support for session consumer

nce with __counted_by: + int sessions_cnt; + struct session_consumer sessions[] __counted_by(sessions_cnt); -- Kees Cook

Re: [PATCH v2] KUnit: add missing MODULE_DESCRIPTION() macros for lib/test_*.ko

odpost: missing MODULE_DESCRIPTION() in lib/test_bits.o > > Add the missing invocations of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson Thanks for chasing these down! Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH v2] tracing: Add sched_prepare_exec tracepoint

thanks! [1/1] tracing: Add sched_prepare_exec tracepoint https://git.kernel.org/kees/c/5c5fad46e48c Take care, -- Kees Cook

Re: [PATCH v2] tracing: Add sched_prepare_exec tracepoint

rp=/usr/bin/dmesg filename=/usr/bin/dmesg pid=389 comm=bash > > Signed-off-by: Marco Elver This looks good to me. If tracing wants to take it: Acked-by: Kees Cook If not, I can take it in my tree if I get a tracing Ack. :) -Kees -- Kees Cook

Re: [PATCH] tracing: Add new_exec tracepoint

On Tue, Apr 09, 2024 at 08:25:45PM +0200, Marco Elver wrote: > On Tue, Apr 09, 2024 at 08:46AM -0700, Kees Cook wrote: > [...] > > > + trace_new_exec(current, bprm); > > > + > > > > All other steps in this function have explicit comments about > > wha

Re: [PATCH] tracing: Add new_exec tracepoint

gt; + __string( comm, task->comm ) > + ), > + > + TP_fast_assign( > + __assign_str(filename, bprm->filename); What about binfmt_misc, and binfmt_script? You may want bprm->interp too? -Kees > + __entry->pid = task->pid; > + __assign_str(comm, task->comm); > + ), > + > + TP_printk("filename=%s pid=%d comm=%s", > + __get_str(filename), __entry->pid, __get_str(comm)) > +); > + > #endif > > /* This part must be outside protection */ > -- > 2.44.0.478.gd926399ef9-goog > -- Kees Cook

Re: [PATCH 0/8] tracing: Persistent traces across a reboot or crash

On Sat, Mar 09, 2024 at 01:51:16PM -0500, Steven Rostedt wrote: > On Sat, 9 Mar 2024 10:27:47 -0800 > Kees Cook wrote: > > > On Tue, Mar 05, 2024 at 08:59:10PM -0500, Steven Rostedt wrote: > > > This is a way to map a ring buffer instance across reboots. > > &

Re: [PATCH 0/8] tracing: Persistent traces across a reboot or crash

/ https://docs.kernel.org/admin-guide/ramoops.html [2] https://www.freedesktop.org/software/systemd/man/latest/systemd-pstore.service.html -- Kees Cook

Re: [kees:devel/overflow/sanitizers] [overflow] 660787b56e: UBSAN:signed-integer-overflow_in_lib/test_memcat_p.c

.db90a6d5-oliver.s...@intel.com > > > [ 42.894536][T1] [ cut here ] > [ 42.895474][T1] UBSAN: signed-integer-overflow in > lib/test_memcat_p.c:47:10 > [ 42.897128][T1] 6570 * 725861 cannot be represented in type 'int' I'm surprised to see the sanitizer catching anything here since the kernel is built with -fno-strict-overflow, but regardless, I'll send a patch... -Kees -- Kees Cook

Re: [PATCH] eventfs: Save directory inodes in the eventfs_inode structure

es > all be the same") > Signed-off-by: Steven Rostedt (Google) Since I reviewed the earlier patch, I will repeat here for the formal one too. :) Thanks for avoiding the hashing! Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 1/3] init: Declare rodata_enabled and mark_rodata_ro() at all time

on.\n"); >> +} >> } >> -#elif defined(CONFIG_ARCH_HAS_STRICT_KERNEL_RWX) >> -static inline void mark_readonly(void) >> -{ >> -pr_warn("Kernel memory protection not selected by kernel config.\n"); >> -} >> -#else >> -static inline void mark_readonly(void) >> -{ >> -pr_warn("This architecture does not have kernel memory protection.\n"); >> -} >> -#endif >> >> void __weak free_initmem(void) >> { >> -- >> 2.41.0 -- Kees Cook

Re: [PATCH v3 0/5] params: harden string ops and allocatio ops

yle https://git.kernel.org/kees/c/c62c9771b7d6 Take care, -- Kees Cook

Re: [PATCH] eventfs: Use ERR_CAST() in eventfs_create_events_dir()

exact situation (casting an error pointer to another type). > > Closes: https://github.com/ClangBuiltLinux/linux/issues/1947 > Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use > eventfs_inode") > Signed-off-by: Nathan Chancellor Yes, please. That's the correct method to do such casts. Thanks! Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH] KVM: deprecate KVM_WERROR in favor of general WERROR

option. Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH v2 0/5] params: harden string ops and allocatio ops

e comment style Seems like a nice bit of clean-up. Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH v2 2/5] params: Do not go over the limit when getting the string length

st struct > kernel_param *kp) > { > const struct kparam_string *kps = kp->str; > > - if (strlen(val)+1 > kps->maxlen) { > + if (strnlen(val, kps->maxlen) == kps->maxlen) { > pr_err("%s: string doesn't fit in %u chars.\n", > kp->name, kps->maxlen-1); > return -ENOSPC; > -- > 2.40.0.1.gaa8946217a0b > -- Kees Cook

Re: [PATCH 3/3] get_maintainer: add patch-only pattern matching type

@@ -19302,8 +19302,8 @@ F: include/uapi/linux/seccomp.h F: kernel/seccomp.c F: tools/testing/selftests/kselftest_harness.h F: tools/testing/selftests/seccomp/* -K: \bsecure_computing -K: \bTIF_SECCOMP\b +D: \bsecure_computing +D: \bTIF_SECCOMP\b SECURE DIGITAL HOST CONTROLLER INTERFACE (SDHCI) Broadcom BRCMSTB DRIVER M: Kamal Dasu -- Kees Cook

Re: [PATCH 1/3] MAINTAINERS: add documentation for D:

re are used when rendering: https://docs.kernel.org/process/maintainers.html In this case, I assume "D" is inspired by "Diff", so perhaps reword this to get a proper emphasis hint, and add additional context: D: *Diff content regex* (perl extended) pattern match that applies only to patches and not entire files (e.g. when using the get_maintainers.pl script). -- Kees Cook

Re: [PATCH 0/3] get_maintainer: add patch-only keyword matching

hanged in a patch, but we're not maintainers of the files they appear in. > > Justin Stitt (3): > > MAINTAINERS: add documentation for D: > > get_maintainer: add patch-only pattern matching type Can we squash these two changes together, and then likely add some patches for moving things out of K: ? -- Kees Cook

Re: [PATCH] MAINTAINERS: add include/linux/module*.h to modules

On Wed, Sep 20, 2023 at 02:10:09PM -0700, Luis Chamberlain wrote: > Use glob include/linux/module*.h to capture all module changes. > > Suggested-by: Kees Cook > Signed-off-by: Luis Chamberlain Thanks! Reviewed-by: Kees Cook -- Kees Cook

[PATCH] x86/mm/dump_pagetables: Add SLAB_VIRTUAL knowledge

Add the markings for the SLAB_VIRTUAL area. Cc: Matteo Rizzo Cc: Jann Horn Cc: Dave Hansen Cc: Andy Lutomirski Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: Ingo Molnar Cc: Borislav Petkov Cc: x...@kernel.org Cc: "H. Peter Anvin" Signed-off-by: Kees Cook --- This is on

Re: [PATCH] HID: uhid: refactor deprecated strncpy

On Fri, Sep 15, 2023 at 09:36:23AM +0200, David Rheinsberg wrote: > Hi > > On Fri, Sep 15, 2023, at 7:13 AM, Kees Cook wrote: > >> - /* @hid is zero-initialized, strncpy() is correct, strlcpy() not */ > >> - len = min(sizeof(hid->name), sizeof(ev->u.create2.name

[PATCH] ceph: Annotate struct ceph_osd_request with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct ceph_osd_request. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Ilya Dryomov Cc: Xiubo Li Cc: Jeff Layton Cc: ceph-de...@vger.kernel.org Signed-off-by: Kees Cook --- include/linux

[PATCH] afs: Annotate struct afs_permits with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct afs_permits. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: David Howells Cc: Marc Dionne Cc: linux-...@lists.infradead.org Signed-off-by: Kees Cook --- fs/afs/internal.h | 2 +- 1

[PATCH] ceph: Annotate struct ceph_monmap with __counted_by

/counted_by.cocci Cc: Ilya Dryomov Cc: Xiubo Li Cc: Jeff Layton Cc: "David S. Miller" Cc: Eric Dumazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: ceph-de...@vger.kernel.org Cc: net...@vger.kernel.org Signed-off-by: Kees Cook --- include/linux/ceph/mon_client.h | 2 +- net/ceph/mo

[PATCH] ocfs2: Annotate struct ocfs2_slot_info with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct ocfs2_slot_info. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Mark Fasheh Cc: Joel Becker Cc: Joseph Qi Cc: ocfs2-de...@lists.linux.dev Signed-off-by: Kees Cook --- fs/ocfs2

[PATCH] afs: Annotate struct afs_addr_list with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct afs_addr_list. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: David Howells Cc: Marc Dionne Cc: linux-...@lists.infradead.org Signed-off-by: Kees Cook --- fs/afs/internal.h | 2

[PATCH] NFS/flexfiles: Annotate struct nfs4_ff_layout_segment with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct nfs4_ff_layout_segment. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Trond Myklebust Cc: Anna Schumaker Cc: linux-...@vger.kernel.org Signed-off-by: Kees Cook --- fs/nfs

[PATCH] nfs41: Annotate struct nfs4_file_layout_dsaddr with __counted_by

ned-off-by: Kees Cook --- fs/nfs/filelayout/filelayout.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/filelayout/filelayout.h b/fs/nfs/filelayout/filelayout.h index aed0748fd6ec..c7bb5da93307 100644 --- a/fs/nfs/filelayout/filelayout.h +++ b/fs/nfs/filelayout/filelayout.

[PATCH] aio: Annotate struct kioctx_table with __counted_by

Signed-off-by: Kees Cook --- fs/aio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/aio.c b/fs/aio.c index a4c2a6bac72c..f8589caef9c1 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -80,7 +80,7 @@ struct aio_ring { struct kioctx_table { struct rcu_head rcu

[PATCH] mtd: rawnand: ingenic: Annotate struct ingenic_nfc with __counted_by

...@vger.kernel.org Cc: linux-...@lists.infradead.org Signed-off-by: Kees Cook --- drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c index

[PATCH] udf: Annotate struct udf_bitmap with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct udf_bitmap. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Jan Kara Signed-off-by: Kees Cook --- fs/udf/udf_sb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PATCH] mtd: rawnand: sunxi: Annotate struct sunxi_nand_chip with __counted_by

Cc: Manuel Dipolt Cc: linux-...@lists.infradead.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-su...@lists.linux.dev Signed-off-by: Kees Cook --- drivers/mtd/nand/raw/sunxi_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/sunxi_nand.c b

[PATCH] mtd: rawnand: marvell: Annotate struct marvell_nand_chip with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct marvell_nand_chip. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: linux-...@lists.infradead.org Signed-off-by: Kees

[PATCH] mtd: cfi: Annotate struct cfi_private with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct cfi_private. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: linux-...@lists.infradead.org Signed-off-by: Kees Cook

[PATCH] mtd: rawnand: meson: Annotate struct meson_nfc_nand_chip with __counted_by

Cc: Jerome Brunet Cc: Martin Blumenstingl Cc: linux-...@lists.infradead.org Cc: linux-arm-ker...@lists.infradead.org Cc: linux-amlo...@lists.infradead.org Signed-off-by: Kees Cook --- drivers/mtd/nand/raw/meson_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH] mtd: rawnand: renesas: Annotate struct rnand_chip with __counted_by

-...@vger.kernel.org Signed-off-by: Kees Cook --- drivers/mtd/nand/raw/renesas-nand-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/renesas-nand-controller.c b/drivers/mtd/nand/raw/renesas-nand-controller.c index 589021ea9eb2..c9a01feff8df 100644 --- a

[PATCH] mtd: rawnand: atmel: Annotate struct atmel_nand with __counted_by

Cc: Claudiu Beznea Cc: linux-...@lists.infradead.org Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Kees Cook --- drivers/mtd/nand/raw/atmel/nand-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd

[PATCH] mtd: rawnand: denali: Annotate struct denali_chip with __counted_by

functions). As found with Coccinelle[1], add __counted_by for struct denali_chip. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: linux-...@lists.infradead.org Signed-off-by: Kees Cook

  1   2   3   4   5   6   7   8   9   10   >