[RFC PATCH] mmc: sdhci-pxav3: set NEED_RSP_BUSY capability

2025-03-11 Thread Karel Balej
s...@linaro.org/ Link: https://lore.kernel.org/r/d7204pwigqgi.1frfqppiee...@matfyz.cz/ Link: https://lore.kernel.org/r/20250115-pxa1908-lkml-v14-0-847d24f36...@skole.hr/ Cc: Duje Mihanović Cc: sta...@vger.kernel.org Signed-off-by: Karel Balej --- drivers/mmc/host/sdhci-pxav3.c | 1 + 1 file chang

Re: [RFC PATCH] mmc: sdhci-pxav3: set NEED_RSP_BUSY capability

2025-03-11 Thread Karel Balej
Adrian Hunter, 2025-03-11T09:34:28+02:00: > On 10/03/25 16:07, Karel Balej wrote: >> Set the MMC_CAP_NEED_RSP_BUSY capability for the sdhci-pxav3 host to >> prevent conversion of R1B responses to R1. Without this, the eMMC card >> in the samsung,coreprimevelte smartphone usin

Re: [RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-11-11 Thread Karel Balej
Lee Jones, 2024-10-15T09:36:03+01:00: > On Sat, 12 Oct 2024, Karel Balej wrote: > > > Add a MFD cell for the chip's real-time clock. > > > > Signed-off-by: Karel Balej > > --- > > > > Notes: > > RFC v2: > > - Break

[RFC PATCH v2 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-10-12 Thread Karel Balej
d-off-by: Karel Balej --- Notes: RFC v2: - Move in the register definitions from the preceding patch and reword the commit message accordingly. - Rebase to v6.12-rc2. MAINTAINERS | 1 + drivers/rtc/Kconfig | 10 drivers/rtc/Makefile| 1 + dr

[RFC PATCH v2 1/2] mfd: 88pm886: add the RTC cell

2024-10-12 Thread Karel Balej
Add a MFD cell for the chip's real-time clock. Signed-off-by: Karel Balej --- Notes: RFC v2: - Break out the register definitions and reword the commit message accordingly. - RFC v1: https://lore.kernel.org/r/20240920161518.32346-1-bal...@matfyz.cz/ drivers/mfd/88pm886.

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-10 Thread Karel Balej
Lee Jones, 2024-10-10T09:35:19+01:00: > On Thu, 10 Oct 2024, Lee Jones wrote: > > > On Wed, 09 Oct 2024, Karel Balej wrote: > > > > > Lee Jones, 2024-10-09T11:06:43+01:00: > > > > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > > > >

Re: (subset) [RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-10-09 Thread Karel Balej
Lee Jones, 2024-10-09T11:06:43+01:00: > On Fri, 20 Sep 2024 18:12:34 +0200, Karel Balej wrote: > > RTC lives on the base register page of the chip. Add definitions of the > > registers needed for a basic set/read time functionality. > > > > > > Applied, thanks!

[RFC PATCH 1/2] mfd: 88pm886: add the RTC cell and relevant definitions

2024-09-20 Thread Karel Balej
RTC lives on the base register page of the chip. Add definitions of the registers needed for a basic set/read time functionality. Signed-off-by: Karel Balej --- drivers/mfd/88pm886.c | 1 + include/linux/mfd/88pm886.h | 9 + 2 files changed, 10 insertions(+) diff --git a/drivers

[RFC PATCH 2/2] rtc: add driver for Marvell 88PM886 PMIC RTC

2024-09-20 Thread Karel Balej
Only basic set/read time functionality is supported at the moment. Tested with the samsung,coreprimevelte smartphone which contains this PMIC and whose vendor kernel tree has also served as the sole reference for this. Signed-off-by: Karel Balej --- MAINTAINERS | 1 + drivers/rtc

Re: [PATCH v7 0/5] initial support for Marvell 88PM886 PMIC

2024-06-28 Thread Karel Balej
Lee Jones, 2024-06-28T15:41:39+01:00: > On Fri, 31 May 2024 19:34:55 +0200, Karel Balej wrote: > > the following implements basic support for Marvell's 88PM886 PMIC which > > is found for instance as a component of the samsung,coreprimevelte > > smartphone which inspired

[PATCH v7 5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC

2024-05-31 Thread Karel Balej
Add an entry to MAINTAINERS for the Marvell 88PM886 PMIC MFD, onkey and regulator drivers. Signed-off-by: Karel Balej --- Notes: RFC v3: - Remove onkey bindings file. RFC v2: - Only mention 88PM886 in the commit message. - Add regulator driver. - Rename the entry

[PATCH v7 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-05-31 Thread Karel Balej
Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Signed-off-by: Karel Balej --- Notes: v7: - Address Mark's feedback: - Drop get_current_limit op, max_uA values and thus unneeded struct pm886_regulator and adapt the code accordingly. v6: - R

[PATCH v7 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-05-31 Thread Karel Balej
Marvell 88PM886 PMIC provides onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Acked-by: Dmitry Torokhov Signed-off-by: Karel Balej

[PATCH v7 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-05-31 Thread Karel Balej
Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Implement basic support to allow for the use of regulators and onkey. Signed-off-by: Karel Balej

[PATCH v7 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-05-31 Thread Karel Balej
Marvell 88PM886 is a PMIC with several subdevices such as onkey, regulators or battery and charger. It comes in at least two revisions, A0 and A1 -- only A1 is described here at the moment. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Karel Balej --- Notes: RFC v4: - Address

[PATCH v7 0/5] initial support for Marvell 88PM886 PMIC

2024-05-31 Thread Karel Balej
7131838.7569-1-kar...@gimli.ms.mff.cuni.cz/ - regulators RFC v1: https://lore.kernel.org/all/20231228100208.2932-1-kar...@gimli.ms.mff.cuni.cz/ Karel Balej (5): dt-bindings: mfd: add entry for Marvell 88PM886 PMIC mfd: add driver for Marvell 88PM886 PMIC regulator: add regulators driver for Ma

Re: [PATCH v6 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-05-31 Thread Karel Balej
Lee Jones, 2024-05-31T11:24:52+01:00: > Are you planning on seeing to Mark's review comments? Indeed, I'm hoping that I will be able to send it over the weekend. K. B.

Re: [PATCH v6 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-05-05 Thread Karel Balej
Mark Brown, 2024-05-06T00:15:01+09:00: > On Sat, May 04, 2024 at 09:37:06PM +0200, Karel Balej wrote: > > > +static const struct regulator_ops pm886_ldo_ops = { > > + .list_voltage = regulator_list_voltage_table, > > + .map_voltage = regulator_map_voltage_iterate,

[PATCH v6 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-05-04 Thread Karel Balej
Marvell 88PM886 is a PMIC with several subdevices such as onkey, regulators or battery and charger. It comes in at least two revisions, A0 and A1 -- only A1 is described here at the moment. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Karel Balej --- Notes: RFC v4: - Address

[PATCH v6 0/5] initial support for Marvell 88PM886 PMIC

2024-05-04 Thread Karel Balej
8100208.2932-1-kar...@gimli.ms.mff.cuni.cz/ Karel Balej (5): dt-bindings: mfd: add entry for Marvell 88PM886 PMIC mfd: add driver for Marvell 88PM886 PMIC regulator: add regulators driver for Marvell 88PM886 PMIC input: add onkey driver for Marvell 88PM886 PMIC MAINTAINERS: add myself f

[PATCH v6 5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC

2024-05-04 Thread Karel Balej
Add an entry to MAINTAINERS for the Marvell 88PM886 PMIC MFD, onkey and regulator drivers. Signed-off-by: Karel Balej --- Notes: RFC v3: - Remove onkey bindings file. RFC v2: - Only mention 88PM886 in the commit message. - Add regulator driver. - Rename the entry

[PATCH v6 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-05-04 Thread Karel Balej
Marvell 88PM886 PMIC provides onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Acked-by: Dmitry Torokhov Signed-off-by: Karel Balej

[PATCH v6 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-05-04 Thread Karel Balej
Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Signed-off-by: Karel Balej --- Notes: v6: - Remove all definitions (now present in the header). v5: - Add remaining regulators. - Clean up includes. - Address Mark's feedback: - Use dedicated r

[PATCH v6 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-05-04 Thread Karel Balej
Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Implement basic support to allow for the use of regulators and onkey. Signed-off-by: Karel Balej

Re: [PATCH 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-04-11 Thread Karel Balej
Lee Jones, 2024-04-11T12:37:26+01:00: [...] > > diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c > > new file mode 100644 > > index ..e06d418a5da9 > > --- /dev/null > > +++ b/drivers/mfd/88pm886.c > > @@ -0,0 +1,157 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +#includ

[PATCH 5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC

2024-03-31 Thread Karel Balej
Add an entry to MAINTAINERS for the Marvell 88PM886 PMIC MFD, onkey and regulator drivers. Signed-off-by: Karel Balej --- Notes: RFC v3: - Remove onkey bindings file. RFC v2: - Only mention 88PM886 in the commit message. - Add regulator driver. - Rename the entry

[PATCH 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-31 Thread Karel Balej
Marvell 88PM886 PMIC provides onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Acked-by: Dmitry Torokhov Signed-off-by: Karel Balej

[PATCH 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-03-31 Thread Karel Balej
Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Signed-off-by: Karel Balej --- Notes: v1: - Add remaining regulators. - Clean up includes. - Address Mark's feedback: - Use dedicated regmap config. RFC v4: - Initialize regulators regmap i

[PATCH 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-03-31 Thread Karel Balej
Marvell 88PM886 is a PMIC with several subdevices such as onkey, regulators or battery and charger. It comes in at least two revisions, A0 and A1 -- only A1 is described here at the moment. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Karel Balej --- Notes: RFC v4: - Address

[PATCH 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-31 Thread Karel Balej
Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Implement basic support to allow for the use of regulators and onkey. Signed-off-by: Karel Balej

[PATCH 0/5] initial support for Marvell 88PM886 PMIC

2024-03-31 Thread Karel Balej
justify the use of the MFD framework. - Rebase on v6.8-rc3. - Reorder patches. - MFD RFC v1: https://lore.kernel.org/all/20231217131838.7569-1-kar...@gimli.ms.mff.cuni.cz/ - regulators RFC v1: https://lore.kernel.org/all/20231228100208.2932-1-kar...@gimli.ms.mff.cuni.cz/ Karel Balej (5): dt-

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T19:00:24+00:00: > On Thu, Mar 21, 2024 at 07:16:43PM +0100, Karel Balej wrote: > > Mark Brown, 2024-03-21T17:48:28+00:00: > > > > > They do according to the downstream driver which is my only reference. > > > > In fact, there the drive

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T17:48:28+00:00: > On Thu, Mar 21, 2024 at 06:32:03PM +0100, Karel Balej wrote: > > Mark Brown, 2024-03-21T17:17:40+00:00: > > > > Do they both genuinely have the same maximum register? > > > They do according to the downstream driver which is

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T17:17:40+00:00: > On Thu, Mar 21, 2024 at 06:08:16PM +0100, Karel Balej wrote: > > Mark Brown, 2024-03-21T16:58:44+00:00: > > > > > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > > > >

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Mark Brown, 2024-03-21T16:58:44+00:00: > On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote: > > Lee Jones, 2024-03-21T16:20:45+00:00: > > > On Thu, 21 Mar 2024, Karel Balej wrote: > > > > > > > +static const struct regmap_config pm886_i2c_r

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Lee Jones, 2024-03-21T16:20:45+00:00: > On Thu, 21 Mar 2024, Karel Balej wrote: > > > Lee Jones, 2024-03-21T15:42:11+00:00: > > > On Mon, 11 Mar 2024, Karel Balej wrote: > > > > diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h > >

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Karel Balej
Lee Jones, 2024-03-21T15:42:11+00:00: > On Mon, 11 Mar 2024, Karel Balej wrote: > > > From: Karel Balej > > > > Marvell 88PM886 is a PMIC which provides various functions such as > > onkey, battery, charger and regulators. It is found for instance in the > &g

[RFC PATCH v4 5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
From: Karel Balej Add an entry to MAINTAINERS for the Marvell 88PM886 PMIC MFD, onkey and regulator drivers. Signed-off-by: Karel Balej --- Notes: RFC v3: - Remove onkey bindings file. RFC v2: - Only mention 88PM886 in the commit message. - Add regulator driver

[RFC PATCH v4 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
From: Karel Balej Marvell 88PM886 PMIC provides onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Acked-by: Dmitry Torokhov Signed-off

[RFC PATCH v4 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
From: Karel Balej Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Signed-off-by: Karel Balej --- Please note that most of the regulators are not yet described: the descriptions will be added to pm886_regulators in the same manner as the already present ones before the series

[RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
From: Karel Balej Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Implement basic support to allow for the use of regulators and onkey. Signed

[RFC PATCH v4 0/5] initial support for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
From: Karel Balej Hello, the following implements basic support for Marvell's 88PM886 PMIC which is found for instance as a component of the samsung,coreprimevelte smartphone which inspired this and also serves as a testing platform. The code for the MFD is based primarily on this old s

[RFC PATCH v4 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
From: Karel Balej Marvell 88PM886 is a PMIC with several subdevices such as onkey, regulators or battery and charger. It comes in at least two revisions, A0 and A1 -- only A1 is described here at the moment. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Karel Balej --- Notes: RFC v4

Re: [RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
Krzysztof Kozlowski, 2024-03-11T11:41:53+01:00: > On 11/03/2024 11:26, Karel Balej wrote: > > Krzysztof Kozlowski, 2024-03-10T21:35:36+01:00: > >> On 10/03/2024 12:35, Karel Balej wrote: > >>> Dmitry Torokhov, 2024-03-04T17:10:59-08:00: > >>>> On Mon,

Re: [RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-11 Thread Karel Balej
Krzysztof Kozlowski, 2024-03-10T21:35:36+01:00: > On 10/03/2024 12:35, Karel Balej wrote: > > Dmitry Torokhov, 2024-03-04T17:10:59-08:00: > >> On Mon, Mar 04, 2024 at 09:28:45PM +0100, Karel Balej wrote: > >>> Dmitry, > >>> > >>> Dmitry Toro

Re: [RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-10 Thread Karel Balej
Dmitry Torokhov, 2024-03-04T17:10:59-08:00: > On Mon, Mar 04, 2024 at 09:28:45PM +0100, Karel Balej wrote: > > Dmitry, > > > > Dmitry Torokhov, 2024-03-03T12:39:46-08:00: > > > On Sun, Mar 03, 2024 at 11:04:25AM +0100, Karel Balej wrote: > > > > From: Kar

Re: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-05 Thread Karel Balej
Lee Jones, 2024-03-05T11:44:18+00:00: > > +static struct mfd_cell pm886_devs[] = { > > + { > > + .name = "88pm886-onkey", > > + .num_resources = ARRAY_SIZE(pm886_onkey_resources), > > + .resources = pm886_onkey_resources, > > + }, > > + { > > + .name =

Re: [RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-04 Thread Karel Balej
Dmitry, Dmitry Torokhov, 2024-03-03T12:39:46-08:00: > On Sun, Mar 03, 2024 at 11:04:25AM +0100, Karel Balej wrote: > > From: Karel Balej > > > > Marvell 88PM886 PMIC provides onkey among other things. Add client > > driver to handle it. The driver currently on

[RFC PATCH v3 5/5] MAINTAINERS: add myself for Marvell 88PM886 PMIC

2024-03-03 Thread Karel Balej
From: Karel Balej Add an entry to MAINTAINERS for the Marvell 88PM886 PMIC MFD, onkey and regulator drivers. Signed-off-by: Karel Balej --- Notes: RFC v3: - Remove onkey bindings file. RFC v2: - Only mention 88PM886 in the commit message. - Add regulator driver

[RFC PATCH v3 4/5] input: add onkey driver for Marvell 88PM886 PMIC

2024-03-03 Thread Karel Balej
From: Karel Balej Marvell 88PM886 PMIC provides onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Signed-off-by: Karel Balej --- Notes

[RFC PATCH v3 1/5] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-03-03 Thread Karel Balej
From: Karel Balej Marvell 88PM886 is a PMIC with several subdevices such as onkey, regulators or battery and charger. It comes in at least two revisions, A0 and A1 -- only A1 is described here at the moment. Signed-off-by: Karel Balej --- Notes: RFC v3: - Add wakeup-source property

[RFC PATCH v3 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-03-03 Thread Karel Balej
From: Karel Balej Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Signed-off-by: Karel Balej --- Notes: RFC v3: - Do not have a variable for each regulator -- define them all in the pm886_regulators array. - Use new regulators regmap index name. - Use

[RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-03 Thread Karel Balej
From: Karel Balej Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Only implement basic support to allow for the use of regulators and onkey

[RFC PATCH v3 0/5] initial support for Marvell 88PM886 PMIC

2024-03-03 Thread Karel Balej
From: Karel Balej Hello, the following implements basic support for Marvell's 88PM886 PMIC which is found for instance as a component of the samsung,coreprimevelte smartphone which inspired this and also serves as a testing platform. The code for the MFD is based primarily on this old s

[RESEND PATCH v5 5/5] input/touchscreen: imagis: add support for IST3032C

2024-03-01 Thread Karel Balej
From: Karel Balej IST3032C is a touchscreen chip used for instance in the samsung,coreprimevelte smartphone, with which this was tested. Add the chip specific information to the driver. Reviewed-by: Markuss Broks Signed-off-by: Karel Balej --- Notes: v4: * Change the WHOAMI

[RESEND PATCH v5 4/5] dt-bindings: input/touchscreen: imagis: add compatible for IST3032C

2024-03-01 Thread Karel Balej
From: Karel Balej IST3032C is a touchscreen IC which seems mostly compatible with IST3038C except that it reports a different chip ID value. Acked-by: Rob Herring Signed-off-by: Karel Balej --- Notes: v5: - Add Rob's trailer. v4: - Reword commit description to mentio

[RESEND PATCH v5 3/5] input/touchscreen: imagis: Add support for Imagis IST3038B

2024-03-01 Thread Karel Balej
, IST3032B) have a different format for coordinates, and they'd need additional effort to be supported by this driver. Signed-off-by: Markuss Broks Signed-off-by: Karel Balej --- Notes: v4: * Sort the definitions in alphanumerical order. drivers/input/touchscreen/imagis.c

[RESEND PATCH v5 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B

2024-03-01 Thread Karel Balej
commit message] Signed-off-by: Karel Balej --- Notes: v4: * Mention how the chip is different in terms of the programming model in the commit message. * Add Conor's trailer. .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + 1 file changed, 1 inse

[RESEND PATCH v5 0/5] input/touchscreen: imagis: add support for IST3032C

2024-03-01 Thread Karel Balej
From: Karel Balej Hello, this patch series generalizes the Imagis touchscreen driver to support other Imagis chips, namely IST3038B and IST3032C. The motivation for IST3032C is the samsung,coreprimevelte smartphone with which this series has been tested. However, the support for this device is

[RESEND PATCH v5 1/5] input/touchscreen: imagis: Correct the maximum touch area value

2024-03-01 Thread Karel Balej
From: Markuss Broks As specified in downstream IST3038B driver and proved by testing, the correct maximum reported value of touch area is 16. Signed-off-by: Markuss Broks Signed-off-by: Karel Balej --- drivers/input/touchscreen/imagis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [RFC PATCH v2 1/6] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-02-18 Thread Karel Balej
Rob Herring, 2024-02-15T08:20:52-06:00: > > .../bindings/mfd/marvell,88pm88x.yaml | 74 +++ > > Filename should match the compatible. > > In general, drop the 'x' wildcard. By "in general", do you mean for the drivers code also? As I have mentioned in the commit message fo

[RFC PATCH v2 6/6] MAINTAINERS: add myself for Marvell 88PM886 PMIC

2024-02-11 Thread Karel Balej
From: Karel Balej Add an entry to MAINTAINERS for the Marvell 88PM886 PMIC MFD, onkey and regulator drivers. Signed-off-by: Karel Balej --- Notes: RFC v2: - Only mention 88PM886 in the commit message. - Add regulator driver. - Rename the entry. MAINTAINERS | 11

[RFC PATCH v2 5/6] input: add onkey driver for Marvell 88PM88X PMICs

2024-02-11 Thread Karel Balej
From: Karel Balej Marvell 88PM88X PMICs provide onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Signed-off-by: Karel Balej --- Notes

[RFC PATCH v2 4/6] dt-bindings: input: add entry for Marvell 88PM88X PMICs onkey

2024-02-11 Thread Karel Balej
From: Karel Balej Marvell 88PM88X PMICs provide onkey functionality -- add the bindings. Signed-off-by: Karel Balej --- Notes: RFC v2: - Add wakeup-source property and reference onkey schema from MFD. - Reword commit message. .../bindings/input/marvell,88pm88x-onkey.yaml | 32

[RFC PATCH v2 3/6] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-02-11 Thread Karel Balej
From: Karel Balej Support the LDO and buck regulators of the Marvell 88PM886 PMIC. 88PM886 LDOs match those of 88PM880 which also has several more of them. 88PM880 buck regulators descriptions do not match and they sit on a different register page and thus need a separate I2C client and regmap

[RFC PATCH v2 1/6] dt-bindings: mfd: add entry for Marvell 88PM886 PMIC

2024-02-11 Thread Karel Balej
From: Karel Balej Marvell 88PM886 is a PMIC with several subdevices such as onkey, regulators or battery and charger. It comes in at least two revisions, A0 and A1 -- only A1 is described here at the moment. Signed-off-by: Karel Balej --- Notes: RFC v2: - Address Rob's fee

[RFC PATCH v2 0/6] support for Marvell 88PM886 PMIC

2024-02-11 Thread Karel Balej
From: Karel Balej Hello, the following implements basic support for Marvell's 88PM886 PMIC which is found for instance as a component of the samsung,coreprimevelte smartphone which inspired this and also serves as a testing platform. The code for the MFD is based primarily on this old s

[RFC PATCH v2 2/6] mfd: add driver for Marvell 88PM886 PMIC

2024-02-11 Thread Karel Balej
From: Karel Balej Marvell 88PM886 is a PMIC which provides various functions such as onkey, battery, charger and regulators. It is found for instance in the samsung,coreprimevelte smartphone with which this was tested. Only implement basic support to allow for the use of regulators and onkey

[PATCH v5 0/5] input/touchscreen: imagis: add support for IST3032C

2024-02-09 Thread Karel Balej
From: Karel Balej Hello, this patch series generalizes the Imagis touchscreen driver to support other Imagis chips, namely IST3038B and IST3032C, which use a slightly different protocol. The motivation for IST3032C is the samsung,coreprimevelte smartphone with which this series has been tested

[PATCH v5 3/5] input/touchscreen: imagis: Add support for Imagis IST3038B

2024-02-09 Thread Karel Balej
, IST3032B) have a different format for coordinates, and they'd need additional effort to be supported by this driver. Signed-off-by: Markuss Broks Signed-off-by: Karel Balej --- Notes: v4: * Sort the definitions in alphanumerical order. drivers/input/touchscreen/imagis.c

[PATCH v5 4/5] dt-bindings: input/touchscreen: imagis: add compatible for IST3032C

2024-02-09 Thread Karel Balej
From: Karel Balej IST3032C is a touchscreen IC which seems mostly compatible with IST3038C except that it reports a different chip ID value. Acked-by: Rob Herring Signed-off-by: Karel Balej --- Notes: v5: - Add Rob's trailer. v4: - Reword commit description to mentio

[PATCH v5 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B

2024-02-09 Thread Karel Balej
commit message] Signed-off-by: Karel Balej --- Notes: v4: * Mention how the chip is different in terms of the programming model in the commit message. * Add Conor's trailer. .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + 1 file changed, 1 inse

[PATCH v5 1/5] input/touchscreen: imagis: Correct the maximum touch area value

2024-02-09 Thread Karel Balej
From: Markuss Broks As specified in downstream IST3038B driver and proved by testing, the correct maximum reported value of touch area is 16. Signed-off-by: Markuss Broks Signed-off-by: Karel Balej --- drivers/input/touchscreen/imagis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v5 5/5] input/touchscreen: imagis: add support for IST3032C

2024-02-09 Thread Karel Balej
From: Karel Balej IST3032C is a touchscreen chip used for instance in the samsung,coreprimevelte smartphone, with which this was tested. Add the chip specific information to the driver. Reviewed-by: Markuss Broks Signed-off-by: Karel Balej --- Notes: v4: * Change the WHOAMI

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-02-02 Thread Karel Balej
Lee Jones, 2024-02-02T12:45:50+00:00: > On Thu, 01 Feb 2024, Karel Balej wrote: > > > Lee Jones, 2024-01-31T11:03:11+00:00: > > > On Sun, 28 Jan 2024, Karel Balej wrote: > > > > > > + /* GPIO1: DVC, GPIO0: input */ > > &g

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-02-01 Thread Karel Balej
Lee Jones, 2024-01-31T11:03:11+00:00: > On Sun, 28 Jan 2024, Karel Balej wrote: > > > > + /* GPIO1: DVC, GPIO0: input */ > > > > + REG_SEQ0(PM88X_REG_GPIO_CTRL1, 0x40), > > > > > > Shouldn't you set these up using Pintrl? > > &

Re: [RFC PATCH 2/5] mfd: add 88pm88x driver

2024-01-28 Thread Karel Balej
Lee, thank you for your feedback. On Thu Jan 25, 2024 at 1:26 PM CET, Lee Jones wrote: [...] > > +#define PM88X_REG_INT_STATUS1 0x05 > > + > > +#define PM88X_REG_INT_ENA_10x0a > > +#define PM88X_INT_ENA1_ONKEY BIT(0) > > + > > +

[PATCH v4 5/5] input/touchscreen: imagis: add support for IST3032C

2024-01-20 Thread Karel Balej
From: Karel Balej IST3032C is a touchscreen chip used for instance in the samsung,coreprimevelte smartphone, with which this was tested. Add the chip specific information to the driver. Reviewed-by: Markuss Broks Signed-off-by: Karel Balej --- Notes: v4: * Change the WHOAMI

[PATCH v4 4/5] dt-bindings: input/touchscreen: imagis: add compatible for IST3032C

2024-01-20 Thread Karel Balej
From: Karel Balej IST3032C is a touchscreen IC which seems mostly compatible with IST3038C except that it reports a different chip ID value. Signed-off-by: Karel Balej --- Notes: v4: * Reword commit description to mention how this IC differs from the already supported

[PATCH v4 3/5] input/touchscreen: imagis: Add support for Imagis IST3038B

2024-01-20 Thread Karel Balej
, IST3032B) have a different format for coordinates, and they'd need additional effort to be supported by this driver. Signed-off-by: Markuss Broks Signed-off-by: Karel Balej --- Notes: v4: * Sort the definitions in alphanumerical order. drivers/input/touchscreen/imagis.c

[PATCH v4 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B

2024-01-20 Thread Karel Balej
commit message] Signed-off-by: Karel Balej --- Notes: v4: * Mention how the chip is different in terms of the programming model in the commit message. * Add Conor's trailer. .../devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml | 1 + 1 file changed, 1 inse

[PATCH v4 1/5] input/touchscreen: imagis: Correct the maximum touch area value

2024-01-20 Thread Karel Balej
From: Markuss Broks As specified in downstream IST3038B driver and proved by testing, the correct maximum reported value of touch area is 16. Signed-off-by: Markuss Broks Signed-off-by: Karel Balej --- drivers/input/touchscreen/imagis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v4 0/5] input/touchscreen: imagis: add support for IST3032C

2024-01-20 Thread Karel Balej
From: Karel Balej Hello, this patch series generalizes the Imagis touchscreen driver to support other Imagis chips, namely IST3038B and IST3032C, which use a slightly different protocol. It also adds necessary information to the driver so that the IST3032C touchscreen can be used with it. The

Re: [RFC PATCH 1/5] mfd: 88pm88x: differences with respect to the PMIC RFC series

2024-01-11 Thread Karel Balej
On Thu Jan 11, 2024 at 4:25 PM CET, Lee Jones wrote: [...] > > > > diff --git a/include/linux/mfd/88pm88x.h b/include/linux/mfd/88pm88x.h > > > > index a34c57447827..9a335f6b9c07 100644 > > > > --- a/include/linux/mfd/88pm88x.h > > > > +++ b/include/linux/mfd/88pm88x.h > > > > @@ -49,6 +49,8 @@ s

Re: [RFC PATCH 1/5] mfd: 88pm88x: differences with respect to the PMIC RFC series

2024-01-11 Thread Karel Balej
Lee, On Thu Jan 11, 2024 at 11:54 AM CET, Lee Jones wrote: > The subject needs work. Please tell us what the patches is doing. > > On Thu, 28 Dec 2023, Karel Balej wrote: > > > From: Karel Balej > > A full an complete commit message is a must. I have not provided a d

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Karel Balej
On Sun Jan 7, 2024 at 11:35 AM CET, Krzysztof Kozlowski wrote: > On 28/12/2023 10:39, Karel Balej wrote: > > diff --git a/drivers/mfd/88pm88x.c b/drivers/mfd/88pm88x.c > > index 69a8e39d43b3..999d0539b720 100644 > > --- a/drivers/mfd/88pm88x.c > > +++ b/drivers/mfd/88

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Karel Balej
Krzysztof, On Sun Jan 7, 2024 at 11:34 AM CET, Krzysztof Kozlowski wrote: > On 07/01/2024 10:49, Karel Balej wrote: > > Mark, > > > > On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: > >> On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: > >>

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Karel Balej
Mark, On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: > On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: > > > @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { > > .num_resources = ARRAY_SIZE(pm88x_onkey_resources), > >

[RFC PATCH 5/5] MAINTAINERS: add entries for the 88pm88x regulators driver

2023-12-28 Thread Karel Balej
From: Karel Balej List the related files under the Marvell 88PM88X PMICs entry. Signed-off-by: Karel Balej --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f35ec0f186a9..f9676aec7397 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -12743,8

[RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2023-12-28 Thread Karel Balej
From: Karel Balej Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Support for 88PM880 is not included but should be easy to implement being just a matter of defining the additional LDOs and all bucks and modifying the 88PM88X MFD driver appropriately. Signed-off-by: Karel Balej

[RFC PATCH 3/5] dt-bindings: regulator: add documentation entry for 88pm88x-regulator

2023-12-28 Thread Karel Balej
From: Karel Balej The Marvell 88PM88X PMICs provide regulators among other things. Document how to use them. Signed-off-by: Karel Balej --- .../bindings/mfd/marvell,88pm88x.yaml | 17 +++ .../regulator/marvell,88pm88x-regulator.yaml | 28 +++ 2 files changed

[RFC PATCH 2/5] mfd: 88pm88x: initialize the regulators regmaps

2023-12-28 Thread Karel Balej
From: Karel Balej The regulators registers are accessed via a different I2C address than the already implemented functionality. Initialize the new regmap for the regulator driver to use. For 88PM886 the buck regmap is the same as LDO regmap, however this is not the case for 88PM880. Signed-off

[RFC PATCH 1/5] mfd: 88pm88x: differences with respect to the PMIC RFC series

2023-12-28 Thread Karel Balej
From: Karel Balej Signed-off-by: Karel Balej --- drivers/mfd/88pm88x.c | 14 -- include/linux/mfd/88pm88x.h | 2 ++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/mfd/88pm88x.c b/drivers/mfd/88pm88x.c index 5db6c65b667d..3424d88a58f6 100644 --- a

[RFC PATCH 0/5] regulator: support for Marvell 88PM886 LDOs and bucks

2023-12-28 Thread Karel Balej
From: Karel Balej Hello, the following adds the regulators driver for Marvell 88PM88X PMICs implementing only the 88PM886 specific parts - however extension for 88PM880 should be trivial. The series adding MFD driver for these PMICs is available here [1]. Please note that this series depends on

Re: [PATCH v3 2/5] dt-bindings: input/touchscreen: Add compatible for IST3038B

2023-12-27 Thread Karel Balej
Markuss, On Sat Dec 9, 2023 at 11:58 AM CET, Conor Dooley wrote: > On Sat, Dec 09, 2023 at 10:05:27AM +0100, Karel Balej wrote: > > On Mon Dec 4, 2023 at 1:52 PM CET, Conor Dooley wrote: > > > On Mon, Dec 04, 2023 at 02:40:44PM +0200, Markuss Broks wrote: > > > >

Re: [RFC PATCH 1/5] dt-bindings: mfd: add entry for the Marvell 88PM88X PMICs

2023-12-22 Thread Karel Balej
Rob, thank you very much for your feedback. On Mon Dec 18, 2023 at 4:17 PM CET, Rob Herring wrote: > > + Marvell 88PM880 and 88PM886 are two similar PMICs providing > > + several functions such as onkey, regulators or battery and > > + charger. Both seem to come in two revisions -- A0 and A1.

[RFC PATCH 0/5] support for Marvell 88PM886 PMIC

2023-12-17 Thread Karel Balej
From: Karel Balej Hello, the following implements basic support for Marvell's 88PM886 PMIC which is found for instance as a component of the samsung,coreprimevelte smartphone which inspired this and also serves as a testing platform. The code for the MFD is based primarily on this old s

[RFC PATCH 5/5] MAINTAINERS: add myself for Marvell 88PM88X PMICs

2023-12-17 Thread Karel Balej
From: Karel Balej Add an entry to MAINTAINERS for the Marvell 88PM88X PMICs MFD and onkey drivers. Signed-off-by: Karel Balej --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index e2c6187a3ac8..eb0171cd2323 100644 --- a/MAINTAINERS +++ b

[RFC PATCH 4/5] input: add onkey driver for Marvell 88PM88X PMICs

2023-12-17 Thread Karel Balej
From: Karel Balej The Marvell 88PM88X PMICs provide onkey among other things. Add client driver to handle it. The driver currently only provides a basic support omitting additional functions found in the vendor version, such as long onkey and GPIO integration. Signed-off-by: Karel Balej

[RFC PATCH 3/5] dt-bindings: input: add entry for 88pm88x-onkey

2023-12-17 Thread Karel Balej
From: Karel Balej Marvell 88PM88X PMICs provide onkey functionality. Document it. Signed-off-by: Karel Balej --- .../bindings/input/marvell,88pm88x-onkey.yaml | 30 +++ .../bindings/mfd/marvell,88pm88x.yaml | 4 +++ 2 files changed, 34 insertions(+) create mode

  1   2   >