Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

Bastien Nocera writes: > On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: >> Ensure checkpatch compliance >> >> > Signed-off-by: Justin Vreeland >> --- >> v2: >>   - Added commit message >>   - Fixed overly long lines >> &g

Re: [PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

Bastien Nocera writes: > On Mon, 2017-05-01 at 18:52 -0600, Justin Vreeland wrote: >> Ensure checkpatch compliance >> >> > Signed-off-by: Justin Vreeland >> --- >> v2: >>   - Added commit message >>   - Fixed overly long lines >> &g

[PATCH v2 1/7] staging: rtl8723bs: Fix initialization of static variables

Do not initialize static to 0 Do not initialize static to false Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging

[PATCH v2 5/7] staging: rtl8723bs: Fix pointer style

Fix "(foo*)" should be "(foo *)" Fix "foo * bar" should be "foo *bar" Signed-off-by: Justin Vreeland Reviewed-by: Bastien Nocera --- v2: - Added Reviewed-by tag drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- 1 file changed, 3 insertions(

[PATCH v2 4/7] staging: rtl8723bs: Move braces to same line as conditional

Ensure checkpatch compliance Signed-off-by: Justin Vreeland --- v2: - Added commit message - Fixed overly long lines drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 18 -- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 12 ++-- drivers/staging/rtl8723bs/hal

[PATCH v2 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

Enclosing macros with complex values ensures expression is evaluated as expected. Signed-off-by: Justin Vreeland --- v2: - Added spaces around plus signs - Fixed line over 80 columns - Added commit message drivers/staging/rtl8723bs/hal/odm.h | 5 - 1 file changed, 4 insertions(+), 1

[PATCH v2 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

Wrapping in do-while ensures macros are executed as expected. Signed-off-by: Justin Vreeland --- v2: - Added commit message drivers/staging/rtl8723bs/hal/odm_debug.h | 81 +-- 1 file changed, 45 insertions(+), 36 deletions(-) diff --git a/drivers/staging

[PATCH v2 7/7] staging: rtl8723bs: Do not use assignment in if condition

Ensure checkpatch compliance Signed-off-by: Justin Vreeland Reviewed-by: Bastien Nocera --- v2: - Added commit message - Added Reviewed-by tag drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH v2 6/7] staging: rtl8723bs: Fix spacing around '<'

Ensure checkpatch compliance Signed-off-by: Justin Vreeland Reviewed-by: Bastien Nocera --- v2: - Added commit message - Added Reviewed-by tag drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal

[PATCH v2 0/7] staging: rtl8732: Various checkpatch fixes

v2: Added commit messages Fixed overly long lines Added Bastien Nocera's Reviewed-by tag - Also fixed commit messages marked reviewed, hope that's OK. The patch contents are identical. Justin Vreeland (7): staging: rtl8723bs: Fix initialization of static variables

[PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h index 0b3541a91548..13c4aebd178e 100644 --- a/drivers/staging/rtl8723bs/hal/odm.h

[PATCH 2/7] staging: rtl8723bs: Wrap multi-line macros in do-while loop

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/odm_debug.h | 80 +-- 1 file changed, 44 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8723bs/hal/odm_debug.h b/drivers/staging/rtl8723bs/hal/odm_debug.h index a89690ea6ba9

[PATCH 1/7] staging: rtl8723bs: Fix initialization of static variables

Do not initialize static to 0 Do not initialize static to false Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/HalBtc8723b1Ant.c | 8 drivers/staging/rtl8723bs/hal/HalBtc8723b2Ant.c | 4 ++-- drivers/staging/rtl8723bs/hal/hal_btcoex.c | 2 +- drivers/staging

[PATCH 7/7] staging: rtl8723bs: Do not use assignment in if condition

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index cc6eb32c5f71..c189eb575654 100644 --- a

[PATCH 4/7] staging: rtl8723bs: Move braces to same line as conditional

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 15 +-- drivers/staging/rtl8723bs/hal/rtl8723b_rf6052.c | 9 +++-- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 ++ 3 files changed, 10 insertions(+), 20 deletions(-) diff --git a

[PATCH 6/7] staging: rtl8723bs: Fix spacing around '<'

Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c b/drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c index 991e3adcc42c..cc6eb32c5f71 100644 --- a

[PATCH 5/7] staging: rtl8723bs: Fix pointer style

Fix "(foo*)" should be "(foo *)" Fix "foo * bar" should be "foo *bar" Signed-off-by: Justin Vreeland --- drivers/staging/rtl8723bs/hal/rtl8723bs_xmit.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723bs

[PATCH 0/7] staging: rtl8732: Various checkpatch fixes

Justin Vreeland (7): staging: rtl8723bs: Fix initialization of static variables staging: rtl8723bs: Wrap multi-line macros in do-while loop staging: rtl8723bs: Macros with complex values should be enclosed in parentheses staging: rtl8723bs: Move braces to same line as conditional