[PATCH 2/2] audit: uninitialize variable audit_sig_sid

Checkpatch tool reports "ERROR: do not initialise globals/statics to 0" To fix this, audit_sig_sid is uninitialized As this is stored in the .bss section, the compiler can initialize the variable automatically. Signed-off-by: Jules Irenge --- kernel/audit.c | 2 +- 1 file changed, 1

[RESEND PATCH 2/2] audit: uninitialize variable audit_sig_sid

Checkpatch tool reports "ERROR: do not initialise globals/statics to 0" To fix this, audit_sig_sid is uninitialized As this is stored in the .bss section, the compiler can initialize the variable automatically. Signed-off-by: Jules Irenge --- kernel/audit.c | 2 +- 1 file changed, 1

[RESEND PATCH 1/2] audit: change unnecessary globals into statics

Variables sig_pid, audit_sig_uid and audit_sig_sid are only used in the audit.c file across the kernel Hence it appears no reason for declaring them as globals This patch removes their global declarations from the .h file and change them into static in the .c file. Signed-off-by: Jules Irenge

[RESEND PATCH 0/2] cleanups

I am proposing these 2 patches, one of which is recommendation of Joe Perches, namely the removing of unnecessary globals and change them to static. I am currently learning the core kernel the hard way. I will appreciate any feedback negative or positive. Thanks Jules Irenge (2): audit: change

[PATCH 1/2] audit: change unnecessary globals into statics

Variables sig_pid, audit_sig_uid and audit_sig_sid are only used in the audit.c file across the kernel Hence it appears no reason for declaring them as globals This patch removes their global declarations from the .h file and change them into static in the .c file. Signed-off-by: Jules Irenge

Re: [PATCH 4/4] context_tracking: uninitialize static variables

On Mon, 3 Aug 2020, pet...@infradead.org wrote: > So personally I prefer having the '= false' there. It used to be that > compilers were stupid and would put any initialized static variable in > .data, even if it was initialized with 0. But AFAIK compilers are no > longer that stupid. > Thank

Re: [PATCH 0/4] Checkpatch tool errors clean up

On Sat, 1 Aug 2020, Joe Perches wrote: > On Sat, 2020-08-01 at 19:45 +0100, Jules Irenge wrote: > > Hi > > I am proposing these 4 patches. > > I am currently learning the core kernel the hard way. > > I will appreciate any feedback negative or positive. > > T

Re: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid

On Sat, 1 Aug 2020, Joe Perches wrote: > On Sat, 2020-08-01 at 19:46 +0100, Jules Irenge wrote: > > Checkpatch tool reports an error at variable audit_sig_sid declaration > [] > > diff --git a/kernel/audit.c b/kernel/audit.c > [] > > @@ -125,7 +125,7 @@ static u32

[PATCH 2/4] audit: uninitialize global variable audit_sig_sid

Checkpatch tool reports an error at variable audit_sig_sid declaration "ERROR: do not initialise globals to 0" To fix this, the global variable has been uninitialized. Signed-off-by: Jules Irenge --- kernel/audit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --gi

[PATCH 4/4] context_tracking: uninitialize static variables

m to false. The variable has since been uninitialized. Signed-off-by: Jules Irenge --- kernel/context_tracking.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c index 36a98c48aedc..21881c534152 100644 --- a/kernel/context_

[PATCH 0/4] Checkpatch tool errors clean up

Hi I am proposing these 4 patches. I am currently learning the core kernel the hard way. I will appreciate any feedback negative or positive. Thanks Jules Irenge (4): acct: Add required space between variable and operator audit: uninitialize global variable audit_sig_sid audit

[PATCH 1/4] acct: Add required space between variable and operator

Checkpatch tool reports an error "ERROR: spaces required around that == (ctx:VxV)" To fix this space has been added between the variable, the operator and the value. Add the missing required space. Signed-off-by: Jules Irenge --- kernel/acct.c | 2 +- 1 file changed, 1 inser

[PATCH 3/4] audit: uninitialize static variables

zero. The variable has since been uninitialized. Signed-off-by: Jules Irenge --- kernel/audit.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 7b1a38a211a9..7d79ecb58b01 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -311,8 +311

[tip: core/rcu] rcu/rcutorture: Replace 0 with false

The following commit has been merged into the core/rcu branch of tip: Commit-ID: 8f43d5911b38f00dfa46169dcb1feb1e101dd906 Gitweb: https://git.kernel.org/tip/8f43d5911b38f00dfa46169dcb1feb1e101dd906 Author:Jules Irenge AuthorDate:Mon, 01 Jun 2020 19:45:48 +01:00 Committer

[tip: core/rcu] rcu: Replace 1 with true

The following commit has been merged into the core/rcu branch of tip: Commit-ID: e40bb921119814c6f746891af9cd37eccda616a4 Gitweb: https://git.kernel.org/tip/e40bb921119814c6f746891af9cd37eccda616a4 Author:Jules Irenge AuthorDate:Mon, 01 Jun 2020 19:45:49 +01:00 Committer

[PATCH 5/5] sfc: add missing annotation for efx_ef10_try_update_nic_stats_vf()

Signed-off-by: Jules Irenge --- drivers/net/ethernet/sfc/ef10.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/sfc/ef10.c b/drivers/net/ethernet/sfc/ef10.c index 3f16bd807c6e..e8bbbd366625 100644 --- a/drivers/net/ethernet/sfc/ef10.c +++ b/drivers/net/ethernet/sfc

[PATCH 1/5] rcu/rcutorture: replace 0 with false

Coccinelle reports a warning WARNING: Assignment of 0/1 to bool variable The root cause is the variable lastphase is of bool type is initialised with integer 0 Replacing 0 with false fixes the issue. Signed-off-by: Jules Irenge --- kernel/rcu/rcutorture.c | 2 +- 1 file changed, 1 insertion

[PATCH 0/5] cleanups

Jules Irenge (5): rcu/rcutorture: replace 0 with false rcu: replace 1 with true rcu: replace + with | x86/ftrace: Add annotations for ftrace_arch_code_modify_prepare() and ftrace_arch_code_modify_post_process() sfc: add missing annotation for efx_ef10_try_update_nic_stats_vf

[PATCH 4/5] x86/ftrace: Add annotations for ftrace_arch_code_modify_prepare() and ftrace_arch_code_modify_post_process()

, mutex do not support annotation This makes Sparse to complain. To fix this, __acquire(&text_mutex) and __release(&text_mutex) annotations are added inside ftrace_arch_code_modify_prepare() and ftrace_arch_code_modify_post_process() respectively. Signed-off-by: Jules Irenge --- arch/x8

[PATCH 2/5] rcu: replace 1 with true

Coccinelle reports a warning WARNING: Assignment of 0/1 to bool variable The root cause is the variable rcu_boot_ended of bool type is initialised with integer 1 Replacing 1 with true fixes the issue. Signed-off-by: Jules Irenge --- kernel/rcu/update.c | 2 +- 1 file changed, 1 insertion

[PATCH 3/5] rcu: replace + with |

Coccinelle reports warnings at rcu_preempt_ctxt_queue() WARNING: sum of probable bitmasks, consider | The root cause is the use of addition operator + for bitmask defined macros variables Replacing + with | fixes the issue. Signed-off-by: Jules Irenge --- kernel/rcu/tree_plugin.h | 22

[tip: core/rcu] rcu: Replace 1 by true

The following commit has been merged into the core/rcu branch of tip: Commit-ID: da44cd6c8e88b6da3d5277d0e7b0e4d38faf4532 Gitweb: https://git.kernel.org/tip/da44cd6c8e88b6da3d5277d0e7b0e4d38faf4532 Author:Jules Irenge AuthorDate:Mon, 30 Mar 2020 02:24:48 +01:00 Committer

[tip: core/rcu] rcu: Replace assigned pointer ret value by corresponding boolean value

The following commit has been merged into the core/rcu branch of tip: Commit-ID: a66dbda7893f48b97d7406ae42fa29190aa672a0 Gitweb: https://git.kernel.org/tip/a66dbda7893f48b97d7406ae42fa29190aa672a0 Author:Jules Irenge AuthorDate:Fri, 27 Mar 2020 21:23:53 Committer

[PATCH 0/2] Lock warning cleanup

This patchset proposes a solution to functions that regiter context imbalance warnin, we add annotations to fix the warnings. Jules Irenge (2): cxgb4: Add missing annotation for service_ofldq() spi: atmel: Add missing annotation for atmel_spi_next_xfer_dma_submit() drivers/net/ethernet

[PATCH 2/2] spi: atmel: Add missing annotation for atmel_spi_next_xfer_dma_submit()

Signed-off-by: Jules Irenge --- drivers/spi/spi-atmel.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c index 013458cabe3c..57ee8c3b7972 100644 --- a/drivers/spi/spi-atmel.c +++ b/drivers/spi/spi-atmel.c @@ -706,6 +706,7 @@ stat

[PATCH 1/2] cxgb4: Add missing annotation for service_ofldq()

Sparse reports a warning at service_ofldq() warning: context imbalance in service_ofldq() - unexpected unlock The root cause is the missing annotation at service_ofldq() Add the missing __must_hold(&q->sendq.lock) annotation Signed-off-by: Jules Irenge --- drivers/net/ethernet/chelsi

[PATCH v2] net: atm: Add annotation for lec_priv_walk() and lec_seq_stop()

on Add __release(&state->locked->lec_arp_lock) annotation Signed-off-by: Jules Irenge --- Changes since v2 - merge patch No 6 and No 4 into one net/atm/lec.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/net/atm/lec.c b/net/atm/lec.c index 25fa3a7b72bd..7947abb17af2 10

[PATCH 1/6] usb: gadget: Add missing annotation for xudc_handle_setup()

Sparse reports a warning at xudc_handle_setup() warning: context imbalance in xudc_handle_setup() - unexpected unlock The root cause is the missing annotation at xudc_handle_setup() Add the missing __must_hold(&udc->lock) annotation Signed-off-by: Jules Irenge --- drivers/usb/gadget/

[PATCH 3/6] udp: Add annotations for udp_rmem_release()

e warning Add __acquire(&sk_queue->lock) annotation Add the __release(&sk_queue->lock) annotation Signed-off-by: Jules Irenge --- net/ipv4/udp.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 5ca12a945ac3..175bd14bfac8 100644 --- a/n

[PATCH 0/6] Lock warnings cleanup

This patch serie propose a solution to functions that record context imbalance by adding annotations Jules Irenge (6): usb: gadget: Add missing annotation for xudc_handle_setup() udp: Add missing annotations for busylock_acquire() and busylock_release() udp: Add annotations for

[PATCH 6/6] net: atm: Add annotation for lec_priv_walk()

shutdown the warning Add the __acquire(&priv->lec_arp_lock) Add __release(&priv->lec_arp_lock) annotation Signed-off-by: Jules Irenge --- net/atm/lec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/net/atm/lec.c b/net/atm/lec.c index 22415bc11878..6070acaa3d5c 100644

[PATCH 2/6] udp: Add missing annotations for busylock_acquire() and busylock_release()

busylock_release() tells Sparse and not GCC to shutdown the warning in case the condition is not satisfied. Add the missing __acquires(busy) annotation Add the missing __releases(busy) annotation Add the __release(busy) annotation Signed-off-by: Jules Irenge --- net/ipv4/udp.c | 5 + 1 file

[PATCH 5/6] USB: dummy-hcd: Add missing annotation for set_link_state()

Sparse reports a warning at set_link_state() warning: context imbalance in set_link_state() - unexpected unlock The root cause is the missing annotation at set_link_state() Add the missing __must_hold(&dum->lock) Signed-off-by: Jules Irenge --- drivers/usb/gadget/udc/dummy_hcd.c | 1 +

[PATCH 4/6] net: atm: Add missing annotation for lec_seq_stop()

tate->locked->lec_arp_lock) Add __release(&state->locked->lec_arp_lock) annotation Signed-off-by: Jules Irenge --- net/atm/lec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/atm/lec.c b/net/atm/lec.c index 25fa3a7b72bd..22415bc11878 100644 --- a/net/atm

Re: [PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

On Sat, 19 Oct 2019, Dan Carpenter wrote: > On Sat, Oct 19, 2019 at 03:07:15PM +0100, Jules Irenge wrote: > > diff --git a/drivers/staging/wfx/bh.c b/drivers/staging/wfx/bh.c > > index 3355183fc86c..573216b08042 100644 > > --- a/drivers/staging/wfx/bh.c > > +++

[PATCH v1 0/5] staging: wfx: fix checkpatch warnings

Fix checkpatch warnings. Jules Irenge (5): staging: wfx: fix warnings of no space is necessary staging: wfx: fix warning of line over 80 characters staging: wfx: fix warnings of logical continuation staging: wfx: correct misspelled words staging: wfx: fix warnings of alignment should

[PATCH v1 3/5] staging: wfx: fix warnings of logical continuation

Fix check warnings of logical continuations should be on the previous line. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/data_rx.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/wfx/data_rx.c b/drivers

[PATCH v1 5/5] staging: wfx: fix warnings of alignment should match open parenthesis

: Fix warnings of alignment should match open parenthesis. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/data_rx.c | 2 +- drivers/staging/wfx/data_tx.c | 2 +- drivers/staging/wfx/debug.c | 14 -- 3 files changed, 10 insertions(+), 8

[PATCH v1 4/5] staging: wfx: correct misspelled words

Correct misspelled words: retrieved and auxiliary. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/data_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wfx/data_tx.c b/drivers/staging/wfx/data_tx.c index

[PATCH v1 1/5] staging: wfx: fix warnings of no space is necessary

Fix warnings of no space is necessary after a cast. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/bh.c | 8 drivers/staging/wfx/bus_sdio.c | 6 +++--- drivers/staging/wfx/bus_spi.c | 2 +- drivers/staging/wfx/data_rx.c | 8

[PATCH v1 2/5] staging: wfx: fix warning of line over 80 characters

Fix warning of lines over 80 characters. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/wfx/bh.c | 17 -- drivers/staging/wfx/bus.h | 6 +- drivers/staging/wfx/bus_sdio.c | 3 +- drivers/staging/wfx/bus_spi.c | 9 ++- drivers/staging

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix line over 80 characters checks warning

On Wed, 16 Oct 2019, Julia Lawall wrote: > > #ifndef VCHI_BULK_GRANULARITY > > # if __VCCOREVER__ >= 0x0400 > > -# define VCHI_BULK_GRANULARITY 32 // Allows for the need to do cache > > cleans > > +# define VCHI_BULK_GRANULARITY 32 // Allows for the need of cache cleans > > #

[PATCH] staging: vc04_services: add space to fix check warning

Add space betwen operator to fix check warning. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/vc04_services/interface/vchi/vchi_cfg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi

[PATCH] staging: vc04_services: fix line over 80 characters checks warning

Fix line over 80 characters checks warning. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../vc04_services/interface/vchi/vchi_cfg.h | 150 ++ 1 file changed, 88 insertions(+), 62 deletions(-) diff --git a/drivers/staging/vc04_services/interface/vchi

Re: [Outreachy kernel] [PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

On Sun, 13 Oct 2019, Julia Lawall wrote: > > > On Sun, 13 Oct 2019, Jules Irenge wrote: > > > Fix lines ending with open parenthesis. Issue detected by checkpatch tool. > > In the process, change driver functions name in the multiple files from: > > vc

[PATCH 2/2] staging: vc04_services: fix lines ending with open parenthesis

Fix lines ending with open parenthesis. Issue detected by checkpatch tool. Within "controls.c", "mmal-vchiq.c" and" mmal-vchiq.h" files. Signed-off-by: Jules Irenge --- .../vc04_services/bcm2835-camera/controls.c | 208 +- .../vc04_services/bcm

[PATCH 1/2] staging: vc04_services: fix lines ending with open parenthesis

vchiq_mmal_component_enable to vm_cmpnt_enable Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 191 -- 1 file changed, 89 insertions(+), 102 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c b/drivers/staging

[PATCH v2] staging: vc04_services: place the AND operator at the end of the previous line

Place the AND logical operator at the end of the previous line; to fix warning of "Logical continuations should be on the previous line". Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- drivers/staging/vc04_services/bcm2835-camera/bcm2835-camera.c | 4 ++-- 1 file

Re: [Outreachy kernel] [PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

On Fri, 11 Oct 2019, Julia Lawall wrote: On Fri, 11 Oct 2019, Jules Irenge wrote: Fix warning of logical continuations should be on the previous line. Issue detected by checkpatch tool. There seem to be several changes mixed together in this patch. Don't have a subject line th

[PATCH] staging: vc04_services: fix warning of Logical continuations should be on the previous line

Fix warning of logical continuations should be on the previous line. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 41 --- 1 file changed, 17 insertions(+), 24 deletions(-) diff --git a/drivers/staging

[PATCH] staging: vc04_services: fix warnings of lines should not end with open parenthesis

Fix warning of lines should not end with open parenthesis. Issue detected by checkpatch tool. Signed-off-by: Jules Irenge --- .../bcm2835-camera/bcm2835-camera.c | 38 --- 1 file changed, 16 insertions(+), 22 deletions(-) diff --git a/drivers/staging/vc04_services

[RESEND PATCH v1 2/5] staging: qlge: fix "alignment should match open parenthesis" checks

Fix "alignment should mactch open parenthesis" checks issued by checkpatch.pl tool: "CHECK: Alignment should match open parenthesis". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 182 1 file changed, 91 insertions(+), 9

[RESEND PATCH v1 4/5] staging: qlge: add space to fix check warning

Add space to fix warning of preferred space near the division operator issue detected by checkpatch. Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge

[RESEND PATCH v1 5/5] staging: qlge: fix comparison to NULL warning

Fix comparison to NULL by replacing with !ptr instead. Issue detected by checkpatch. Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index

[RESEND PATCH v1 3/5] staging: qlge: Fix multiple assignments warning by replacing integer variables to bool

Fix multiple assignments warning " check issue detected by checkpatch tool: "CHECK: multiple assignments should be avoided". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff

[RESEND PATCH v1 0/5] checkpatch warnings cleanup

Clean up multiple warnings reported by checkpatch tool. These are a resend in the order they were patched. Jules Irenge (5): staging: qlge: correct a misspelled word staging: qlge: fix "alignment should match open parenthesis" checks staging: qlge: Fix multiple assignments

[RESEND PATCH v1 1/5] staging: qlge: correct a misspelled word

Fix a misspelling of "several" detected by checkpatch Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 5599525a19d5..28fc974ce

[RESEND PATCH] staging: qlge: correct a misspelled word

Fix a misspelling of "several" detected by checkpatch Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 5599525a19d5..28fc974ce

[PATCH v2] staging: qlge: correct a misspelled word

Fix a misspelling of "several" detected by checkpatch Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_dbg.c b/drivers/staging/qlge/qlge_dbg.c index 5599525a19d5..28fc974ce

[PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

Fix multiple assignments warning " check issued by checkpatch.pl tool: "CHECK: multiple assignments should be avoided". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ql

[PATCH] staging: qlge: Fix multiple assignments warning by splitting the assignement into two each

Fix multiple assignments warning " check issued by checkpatch.pl tool: "CHECK: multiple assignments should be avoided". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ql

[PATCH] staging: qlge: fix "alignment should match open parenthesis" checks

Fix "alignment should mactch open parenthesis" checks issued by checkpatch.pl tool: "CHECK: Alignment should match open parenthesis". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 127 1 file changed, 64 insertions(+), 6

[PATCH] staging: qlge: correct misspelled word

Correct misspelled word " check issued by checkpatch.pl tool: "CHECK: serveral may be misspelled - perhaps several?". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_

[PATCH] staging: qlge: correct misspelled word

Correct misspelled word " check issued by checkpatch.pl tool: "CHECK: serveral may be misspelled - perhaps several?". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/qlge/qlge_

[PATCH] staging: qlge: fix "alignment should match open parenthesis" checks

Fix "alignment should mactch open parenthesis" checks issued by checkpatch.pl tool: "CHECK: Alignment should match open parenthesis". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 127 1 file changed, 64 insertions(+), 6

[PATCH] staging: qlge: fix "alignment should match open parenthesis" check

Fix "alignment should match open parenthesis" check issued by checkpatch.pl tool: "CHECK: Alignment should match open parenthesis". Signed-off-by: Jules Irenge --- drivers/staging/qlge/qlge_dbg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging

[PATCH] staging: comedi: Fix camelcase check warning

Capitalize unit_ma to fix camelcase check warning. Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedi.h| 4 ++-- drivers/staging/comedi/comedidev.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/comedi.h b/drivers/staging/comedi

[PATCH] staging: comedi: Capitalize macro name to fix camelcase checkpatch warning

Capitalize RANGE_mA to fix camelcase check warning. Issue reported by checkpatch.pl Signed-off-by: Jules Irenge --- drivers/staging/comedi/comedidev.h | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- drivers/staging/comedi/drivers/dac02.c | 2 +- drivers/staging

[PATCH] staging: speakup: fix line over 80 characters.

Fix coding style issues, which solves checkpatch.pl warning: "WARNING: line over 80 characters". --- drivers/staging/speakup/kobjects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index 2eb5af3

[PATCH v3 0/2] SPDX Cleanups

This v3 corrects grammar and ensures it is ccied to the right maintainer Jules Irenge (2): staging: rtl8192e: add SPDX GPL-2.0 license identifier staging: rtl8192e: remove boilerplate license text drivers/staging/rtl8192e/dot11d.c | 9 + 1 file changed, 1 insertion(+), 8 deletions

[PATCH v3 1/2] staging: rtl8192e: add SPDX GPL-2.0 license identifier

Add the SPDX GPL-2.0 license identifier to fix checkpatch.pl warning Issue found by checkpatch.pl warning: "WARNING: Missing or malformed SPDX-License-Identifier tag in line 1" Signed-off-by: Jules Irenge --- drivers/staging/rtl8192e/dot11d.c | 1 + 1 file changed, 1 insertion(+) di

[PATCH v3 2/2] staging: rtl8192e: remove boilerplate license text

Remove boilerplate license text. Signed-off-by: Jules Irenge --- drivers/staging/rtl8192e/dot11d.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/rtl8192e/dot11d.c b/drivers/staging/rtl8192e/dot11d.c index 6d57abedaa34..82c11caeee7a 100644 --- a/drivers/staging

[PATCH] net: ax25: Fix multiple blank lines warning

Signed-off-by: Jules Irenge --- net/ax25/af_ax25.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 5048790a75f6..2da349b7854a 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -49,8 +49,6 @@ #include #include - - HLIST_HEAD

[PATCH] net: ax25: Add SPDX License to fix missing License warning

Signed-off-by: Jules Irenge --- net/ax25/af_ax25.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ax25/af_ax25.c b/net/ax25/af_ax25.c index 5d01edf8d819..5048790a75f6 100644 --- a/net/ax25/af_ax25.c +++ b/net/ax25/af_ax25.c @@ -1,3 +1,4 @@ +// SPDX-License-Identifier: GPL-2.0