Re: [PATCH 05/14] rtc: ds1685: use rtc_lock/rtc_unlock

ctrlb = rtc->read(rtc, RTC_CTRL_B); > @@ -713,7 +711,7 @@ ds1685_rtc_irq_handler(int irq, void *dev_id) > } > } > rtc_update_irq(rtc->dev, num_irqs, events); > - mutex_unlock(rtc_mutex); > + rtc_unlock(rtc->dev); > > return events ? IRQ_HANDLED : IRQ_NONE; > } > Acked-by: Joshua Kinard

Re: [PATCH] rtc: ds1685: Fix bank switching to avoid endless loop

; > > /* Clear the SET bit in Ctrl B */ > rtc->write(rtc, RTC_CTRL_B, > This probably needs to be sent to stable as well. Acked-by: Joshua Kinard

Re: [PATCH] MIPS: SGI-IP27: always enable NUMA in Kconfig

/arch/mips/Kconfig b/arch/mips/Kconfig > index 6fee1a133e9d..a7e40bb1e5bc 100644 > --- a/arch/mips/Kconfig > +++ b/arch/mips/Kconfig > @@ -678,6 +678,7 @@ config SGI_IP27 > select SYS_SUPPORTS_NUMA > select SYS_SUPPORTS_SMP > select MIPS_L1_CACHE_SHIFT_7 > + select NUMA > help > This are the SGI Origin 200, Origin 2000 and Onyx 2 Graphics > workstations. To compile a Linux kernel that runs on these, say Y > Reviewed-by: Joshua Kinard

Re: arch/mips/include/asm/mach-ip27/topology.h:19:7: error: implicit declaration of function 'hub_data'

to turn NUMA off. I happen to have both a single Origin 200 system and an Onyx2 w/ two nodeboards. Haven't fired them up recently on modern kernels, though. I can't think of a good workaround off the top of my head for this case. NUMA shouldn't hurt an Origin 200, but I recall Ral

Re: [PATCH] MIPS: Only include the platform file needed

_IP32)+= -I$(srctree)/arch/mips/include/asm/mach-ip32 > load-$(CONFIG_SGI_IP32) += 0x80004000 > diff --git a/arch/mips/sibyte/Platform b/arch/mips/sibyte/Platform > index af117330ce14..65b2225b76b2 100644 > --- a/arch/mips/sibyte/Platform > +++ b/arch/mips/sibyte/Platform > @@ -1,10 +1,6 @@ > # > # These are all rather similar so we consider them a single platform > # > -platform-$(CONFIG_SIBYTE_BCM112X)+= sibyte/ > -platform-$(CONFIG_SIBYTE_SB1250) += sibyte/ > -platform-$(CONFIG_SIBYTE_BCM1x55)+= sibyte/ > -platform-$(CONFIG_SIBYTE_BCM1x80)+= sibyte/ > > # > # Sibyte SB1250 / BCM1480 family of SOCs > diff --git a/arch/mips/sni/Platform b/arch/mips/sni/Platform > index 2644a9d63c0f..b0b3dde0bef8 100644 > --- a/arch/mips/sni/Platform > +++ b/arch/mips/sni/Platform > @@ -1,7 +1,6 @@ > # > # SNI RM > # > -platform-$(CONFIG_SNI_RM)+= sni/ > cflags-$(CONFIG_SNI_RM) += > -I$(srctree)/arch/mips/include/asm/mach-rm > ifdef CONFIG_CPU_LITTLE_ENDIAN > load-$(CONFIG_SNI_RM)+= 0x8060 > diff --git a/arch/mips/txx9/Platform b/arch/mips/txx9/Platform > index a176d1fd5799..7f4429ba22eb 100644 > --- a/arch/mips/txx9/Platform > +++ b/arch/mips/txx9/Platform > @@ -1,6 +1,3 @@ > -platform-$(CONFIG_MACH_TX39XX) += txx9/ > -platform-$(CONFIG_MACH_TX49XX) += txx9/ > - > cflags-$(CONFIG_MACH_TX39XX) += \ > -I$(srctree)/arch/mips/include/asm/mach-tx39xx > cflags-$(CONFIG_MACH_TX49XX) += \ > Tested-by: Joshua Kinard Reviewed-by: Joshua Kinard

Re: [PATCH v2] rtc: ds1685: add indirect access method and remove plat_read/plat_write

685.h > @@ -42,6 +42,7 @@ > struct ds1685_priv { > struct rtc_device *dev; > void __iomem *regs; > + void __iomem *data; > u32 regstep; > int irq_num; > bool bcd_mode; > @@ -70,12 +71,13 @@ struct ds1685_rtc_platform_data { > const bool bcd_mode; > const bool no_irq; > const bool uie_unsupported; > - const bool alloc_io_resources; > - u8 (*plat_read)(struct ds1685_priv *, int); > - void (*plat_write)(struct ds1685_priv *, int, u8); > void (*plat_prepare_poweroff)(void); > void (*plat_wake_alarm)(void); > void (*plat_post_ram_clear)(void); > + enum { > + ds1685_reg_direct, > + ds1685_reg_indirect > + } access_type; > }; > > > -- 2.16.4 > Acked-by: Joshua Kinard Reviewed-by: Joshua Kinard

Re: [PATCH 3/3] rtc: ds1685: add indirect access method and remove plat_read/plat_write

On 10/11/2019 11:05, Thomas Bogendoerfer wrote: > Use of provided plat_read/plat_write introduces the problem of possible > different lifetime of rtc driver and plat_XXX function provider. As > this was only intended for SGI Octane (IP30) this patchset implements > a register indirect access method

Re: [PATCH 2/3] rtc: ds1685: use devm_platform_ioremap_resource helper

} > > /* Get the register step size. */ > diff --git a/include/linux/rtc/ds1685.h b/include/linux/rtc/ds1685.h > index b9671d00d964..101c7adc05a2 100644 > --- a/include/linux/rtc/ds1685.h > +++ b/include/linux/rtc/ds1685.h > @@ -43,7 +43,6 @@ struct ds1685_priv { > struct rtc_device *dev; > void __iomem *regs; > u32 regstep; > - size_t size; > int irq_num; > bool bcd_mode; > bool no_irq; > Acked-by: Joshua Kinard

Re: [PATCH 1/3] rts: ds1685: remove not needed fields from private struct

gstep; > - resource_size_t baseaddr; > size_t size; > int irq_num; > bool bcd_mode; > bool no_irq; > - bool uie_unsupported; > - bool alloc_io_resources; > u8 (*read)(struct ds1685_priv *, int); > void (*write)(struct ds1685_priv *, int, u8); > void (*prepare_poweroff)(void); > Acked-by: Joshua Kinard

Re: [PATCH] MIPS: add support for SGI Octane (IP30)

g, because my Onyx2 has 8GB of RAM and it usually boots fine on its own. Pop more than 2GB into an Octane, though, and, if it boots at all, disk or network I/O will usually bus error it at some point. -- Joshua Kinard Gentoo/MIPS ku...@gentoo.org rsa6144/5C63F4E3F5C6C943 2015-04-27 177C 1972

Re: [PATCH 2/3] rtc: ds1685: use correct device struct to get platform device struct

r, but stopped after some unidentified point, and I never found the time to try and track it down. Which machine are you testing on, out of curiosity? -- Joshua Kinard Gentoo/MIPS ku...@gentoo.org rsa6144/5C63F4E3F5C6C943 2015-04-27 177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943 "The pa

Re: [PATCH RFC 01/15] MIPS: replace **** with a hug

0x48)) > return PCIBIOS_SUCCESSFUL; > > /* > - * IOC3 is fucking fucked beyond belief ... Don't try to access > + * IOC3 is hugging hugged beyond belief ... Don't try to access >* anything but 32-bit words ... >*/ >

Re: [PATCH] net/ethernet/sgi: Code cleanup

On 10/19/2017 08:27, David Miller wrote: > From: Joshua Kinard > Date: Tue, 17 Oct 2017 13:54:30 -0400 > >> From: Joshua Kinard >> >> The below patch attempts to clean up the code for the in-tree driver >> for IOC3 ethernet and serial console support, primar

[PATCH] net/ethernet/sgi: Code cleanup

From: Joshua Kinard The below patch attempts to clean up the code for the in-tree driver for IOC3 ethernet and serial console support, primarily used by SGI MIPS platforms. Notable changes include: - Lots of whitespace cleanup - Using shorthand integer types (u16, u32, etc) where

Re: [PATCH v2] MIPS: PCI: Fix smp_processor_id() in preemptible

> - lsize = c->dcache.linesz; > - lsize = c->scache.linesz ? : lsize; > - lsize = c->tcache.linesz ? : lsize; > + lsize = cpu_dcache_line_size(); > + lsize = cpu_scache_line_size() ? : lsize; > + lsize = cpu_tcache_line_size() ? : lsize; > > BUG_O

Re: [PATCH v1 2/2] MIPS: PCI: Remove unused busn_offset

tly unused but may be used by future SGI IP27 fixes, so I left it > there. > > Signed-off-by: Bjorn Helgaas > CC: Joshua Kinard > --- > arch/mips/include/asm/pci.h |1 - > arch/mips/pci/pci-legacy.c |3 +-- > 2 files changed, 1 insertion(+), 3 deletions(-) >

Re: [PATCH 00/21] MIPS memblock: Remove bootmem code and switch to NO_BOOTMEM

of this? > > Regards, > -Sergey I have an SGI Onyx2 and just recently acquired a working SGI Origin 200. The Onyx2 has NUMA issues yet to be hunted down, but I got ~3 days uptime out of the Origin 200 running compiles before powering it down. Mainline needs 2-3 small patches to make IP

Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ?

7; is assigned a >> value that is never used. This needs to be wrapped in #ifdef CONFIG_RTC_DS1685_PROC_REGS, as the value of 'ctrlc' is displayed in /proc/drivers/rtc if that kconfig option is selected on supported systems. -- Joshua Kinard Gentoo/MIPS ku...@gentoo.org 6144R/F5C6C943 2015-04-2

Re: [PATCH] rtc: ds1685: actually spin forever in poweroff error path

1685.c > +++ b/drivers/rtc/rtc-ds1685.c > @@ -2161,6 +2161,7 @@ ds1685_rtc_poweroff(struct platform_device *pdev) > /* Check for valid RTC data, else, spin forever. */ > if (unlikely(!pdev)) { > pr_emerg("platform device data not available, spinning forever

Re: [PATCH 1/2] MIPS: Add barriers between dcache & icache flushes

On 02/22/2016 13:09, Paul Burton wrote: > Index-based cache operations may be arbitrarily reordered by out of > order CPUs. Thus code which writes back the dcache & then invalidates > the icache using indexed cache ops must include a barrier between > operating on the 2 caches in order to prevent t

Re: [PATCH] MIPS: Always page align TASK_SIZE

fff8000UL & PAGE_MASK) > > I'll do a v2 now. > FYI, TASK_SIZE was recently changed to 0x8000UL in commit 7f8ca9cb1ed3 on the linux-mips.org tree. >> >>> #endif >>> >>> #define STACK_TOP_MAXTASK_SIZE >>> @@ -62,7 +62,7 @@

Re: [PATCH 1/3] MIPS: R6: Use lightweight SYNC instruction in smp_* memory barriers

On 01/29/2016 08:32, Maciej W. Rozycki wrote: > On Wed, 27 Jan 2016, Joshua Kinard wrote: > >> On 06/05/2015 09:10, Ralf Baechle wrote: >>> >>> Maciej, >>> >>> do you have an R4000 / R4600 / R5000 / R7000 / SiByte system at hand to >>> tes

Re: [PATCH 1/3] MIPS: R6: Use lightweight SYNC instruction in smp_* memory barriers

005e8: 03a0f021moves8,sp 4005ec: afc40008sw a0,8(s8) 4005f0: afc5000csw a1,12(s8) > 4005f4: 040fsync.p > 4005f8: 050f0x50f > 4005fc: 010f0x10f 400600: 1021movev

Re: [PATCH 0/3] MIPS: SMP memory barriers: lightweight sync, acquire-release

On 06/02/2015 05:59, Ralf Baechle wrote: > On Tue, Jun 02, 2015 at 04:41:21AM -0400, Joshua Kinard wrote: > >> On 06/01/2015 20:09, Leonid Yegoshin wrote: >>> The following series implements lightweight SYNC memory barriers for SMP >>> Linux >>> and a corre

Re: [PATCH 0/3] MIPS: SMP memory barriers: lightweight sync, acquire-release

On 06/01/2015 20:09, Leonid Yegoshin wrote: > The following series implements lightweight SYNC memory barriers for SMP Linux > and a correct use of SYNCs around atomics, futexes, spinlocks etc LL-SC loops > - > the basic building blocks of any atomics in MIPS. > > Historically, a generic MIPS doe

Re: [PATCH] mips:Fix build error for ip32_defconfig configuration

On 05/07/2015 20:52, Nicholas Krause wrote: > This fixes the make error when building the ip32_defconfig > configuration due to using sgio2_cmos_devinit rather then > the correct function,sgio2_rtc_devinit in a device_initcall > below this function's definition. > > Signed-off-by: Nicholas Krause

Re: MIPS: BUG() in isolate_lru_pages in mm/vmscan.c?

On 04/25/2015 11:56, Joshua Kinard wrote: > I keep tripping up a BUG() in isolate_lru_pages in mm/vmscan.c:1345: > > switch (__isolate_lru_page(page, mode)) { > case 0: > nr_pages = hpage_nr_pages(page); > mem_cgroup_update_lru_size(lruv

MIPS: BUG() in isolate_lru_pages in mm/vmscan.c?

I keep tripping up a BUG() in isolate_lru_pages in mm/vmscan.c:1345: switch (__isolate_lru_page(page, mode)) { case 0: nr_pages = hpage_nr_pages(page); mem_cgroup_update_lru_size(lruvec, lru, -nr_pages); list_move(&page->lru, dst);

[PATCH]: MIPS: IP32: Fix two build errors in reset code introduced in DS1685 platform hook patch

From: Joshua Kinard Fix two build errors that somehow got into upstream. Signed-off-by: Joshua Kinard Fixes: 15beb694c661: "mips: ip32: add platform data hooks to use DS1685 driver" --- arch/mips/sgi-ip32/ip32-platform.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH v2] MIPS: IP32: Add platform data hooks to use DS1685 driver

On 03/31/2015 06:56, Ralf Baechle wrote: > On Thu, Feb 26, 2015 at 09:23:50PM -0500, Joshua Kinard wrote: > >> This modifies the IP32 (SGI O2) platform and reset code to utilize the new >> rtc-ds1685 driver. The old mc146818rtc.h header is removed and >> ip32_defconf

[PATCH]: rtc: ds1685: Fix sparse warnings

From: Joshua Kinard Fix two minor sparse warnings: CHECK drivers/rtc/rtc-ds1685.c drivers/rtc/rtc-ds1685.c:2178:1: warning: function 'ds1685_rtc_poweroff' with external linkage has definition drivers/rtc/rtc-ds1685.c:802:23: warning: Using plain integer as NULL pointer Sig

[PATCH]: rtc: ds1685: Remove .owner assignment from platform_driver

From: Joshua Kinard The rtc driver core now sets the platform_driver 'owner' property, so remove the assignment from the DS1685 driver. Signed-off-by: Joshua Kinard Reported-by: kbuild test robot Fixes: aaaf5fbf56f1: "rtc: add driver for DS1685 family of real time clocks"

[PATCH v2] MIPS: IP32: Add platform data hooks to use DS1685 driver

From: Joshua Kinard This modifies the IP32 (SGI O2) platform and reset code to utilize the new rtc-ds1685 driver. The old mc146818rtc.h header is removed and ip32_defconfig is updated as well. Signed-off-by: Joshua Kinard --- arch/mips/configs/ip32_defconfig |3 arch/mips

Re: linux-next: Tree for Feb 23 (rtc-ds1685)

685_rtc_alarm_irq_enable' > undeclared here (not in a function) > .alarm_irq_enable = ds1685_rtc_alarm_irq_enable, > > when CONFIG_RTC_INTF_DEV is not enabled. A patch was sent upstream already for this: http://ozlabs.org/~akpm/mmots/broken-out/rtc-ds1685-fix-ds1685_rtc_alarm_irq_enable-bui

[PATCH]: rtc: ds1685: Fix conditional in ds1685_rtc_sysfs_time_regs_{show,store}

From: Joshua Kinard Fix a conditional statement checking for NULL in both ds1685_rtc_sysfs_time_regs_show and ds1685_rtc_sysfs_time_regs_store that was using a logical AND when it should be using a logical OR so that we fail out of the function properly if the condition ever evaluates to true

Re: [PATCH] rtc: ds1685: fix ds1685_rtc_alarm_irq_enable build error

xes: aaaf5fbf56f ("rtc: add driver for DS1685 family of real time clocks") I probably copied that #define out of another RTC driver before the change was made, then discovered the compile failure later on and just didn't read enough to understand the change, thus only fixing it enough t

Re: [PATCH] rtc: ds1685: Remove superfluous checks for out-of-range u8 values

hence drop the checks. > Wrapping the checks in unlikely() indicated some sense of humor, though ;-) > > Signed-off-by: Geert Uytterhoeven Actually, I think I was operating in -pedantic mode the night I added those checks. Good catch, thanks! Acked-by: Joshua Kinard > --- >

Re: [rtc-linux] [PATCH 01/02 resend] RTC: Add driver for DS1685 family of real time clocks

On 02/09/2015 19:18, Andrew Morton wrote: > On Fri, 12 Dec 2014 17:13:38 -0500 Joshua Kinard wrote: > >> From: Joshua Kinard >> >> This adds a driver for the Dallas/Maxim DS1685-family of RTC chips. It >> supports the DS1685/DS1687, DS1688/DS1691, DS1689/DS169

[PATCH 01/02 resend #2] RTC: Add driver for DS1685 family of real time clocks

From: Joshua Kinard This adds a driver for the Dallas/Maxim DS1685-family of RTC chips. It supports the DS1685/DS1687, DS1688/DS1691, DS1689/DS1693, DS17285/DS17287, DS17485/DS17487, and DS17885/DS17887 RTC chips. These chips are commonly found in SGI O2 and SGI Octane systems. It was

[PATCH 02/02 resend #2] MIPS: IP32: Add platform data hooks to use DS1685 driver

From: Joshua Kinard This modifies the IP32 (SGI O2) platform and reset code to utilize the new rtc-ds1685 driver. The old mc146818rtc.h header is removed and ip32_defconfig is updated as well. Signed-off-by: Joshua Kinard --- arch/mips/configs/ip32_defconfig |3 arch/mips

Re: [PATCH 02/02 resend] MIPS: IP32: Add platform data hooks to use DS1685 driver

On 12/15/2014 11:29, Ralf Baechle wrote: > On Fri, Dec 12, 2014 at 05:13:46PM -0500, Joshua Kinard wrote: > >> This modifies the IP32 (SGI O2) platform and reset code to utilize the new >> rtc-ds1685 driver. The old mc146818rtc.h header is removed and >> ip32_defconf

[PATCH 01/02 resend] RTC: Add driver for DS1685 family of real time clocks

From: Joshua Kinard This adds a driver for the Dallas/Maxim DS1685-family of RTC chips. It supports the DS1685/DS1687, DS1688/DS1691, DS1689/DS1693, DS17285/DS17287, DS17485/DS17487, and DS17885/DS17887 RTC chips. These chips are commonly found in SGI O2 and SGI Octane systems. It was

[PATCH 02/02 resend] MIPS: IP32: Add platform data hooks to use DS1685 driver

From: Joshua Kinard This modifies the IP32 (SGI O2) platform and reset code to utilize the new rtc-ds1685 driver. The old mc146818rtc.h header is removed and ip32_defconfig is updated as well. Signed-off-by: Joshua Kinard --- arch/mips/configs/ip32_defconfig |3 arch/mips

[PATCH 02/02] IP32: Add platform data hooks to use DS1685 driver

From: Joshua Kinard This modifies the IP32 (SGI O2) platform and reset code to utilize the new rtc-ds1685 driver. The old mc146818rtc.h header is removed and ip32_defconfig is updated as well. Signed-off-by: Joshua Kinard --- arch/mips/configs/ip32_defconfig |3 arch/mips

[PATCH 01/02] RTC: Add driver for DS1685 family of real time clocks

From: Joshua Kinard This adds a driver for the Dallas/Maxim DS1685-family of RTC chips. It supports the DS1685/DS1687, DS1688/DS1691, DS1689/DS1693, DS17285/DS17287, DS17485/DS17487, and DS17885/DS17887 RTC chips. These chips are commonly found in SGI O2 and SGI Octane systems. It was

Re: [PATCH v4 0/2] mm/highmem: make kmap cache coloring aware

On 08/26/2014 13:45, David Daney wrote: > On 08/25/2014 07:41 PM, Joshua Kinard wrote: >> On 08/25/2014 20:36, David Daney wrote: >>> On 08/25/2014 04:55 PM, Joshua Kinard wrote: >>>> On 08/25/2014 13:16, Ralf Baechle wrote: >>>>> On Sat, Aug 02,

Re: [PATCH v4 0/2] mm/highmem: make kmap cache coloring aware

On 08/25/2014 20:36, David Daney wrote: > On 08/25/2014 04:55 PM, Joshua Kinard wrote: >> On 08/25/2014 13:16, Ralf Baechle wrote: >>> On Sat, Aug 02, 2014 at 05:11:37AM +0400, Max Filippov wrote: >>> >>>> this series adds mapping color control to the generic

Re: [PATCH v4 0/2] mm/highmem: make kmap cache coloring aware

e it will entirly do away with cache aliases. Won't setting PAGE_SIZE to 16k break some existing userlands (o32)? I use a 4k PAGE_SIZE because the last few times I've tried 16k or 64k, init won't load (SIGSEGVs or such, which panicks the kernel). -- Joshua Kinard Gentoo/MIPS ku...@gen