On 11/09/2016 01:56 AM, Thomas Gleixner wrote:
On Wed, 9 Nov 2016, Joonwoo Park wrote:
When a new timer list enqueued into the time wheel, array index
for the given expiry time is:
expires = (expires + LVL_GRAN(lvl)) >> LVL_SHIFT(lvl);
idx = LVL_OFFS(lvl) + (expires & LVL_M
ijlstra
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joonwoo Park
---
kernel/time/timer.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index c611c47..f6ad4e9 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/t
On 10/28/2016 10:39 AM, Ingo Molnar wrote:
* Arnaldo Carvalho de Melo wrote:
Em Fri, Oct 28, 2016 at 11:30:41AM -0200, Arnaldo Carvalho de Melo escreveu:
Em Fri, Oct 28, 2016 at 10:53:38AM -0200, Arnaldo Carvalho de Melo escreveu:
Em Thu, Oct 27, 2016 at 04:14:55PM -0700, Joonwoo Park
Also I found that sched map has similar problem, fix it too.
Reported-and-Acked-by: Joonwoo Park
Hmm.. I didn't ACK this patch because of bug I commented at
https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1256724.html
s/work_list->max_lat/work_list->max_lat_at/
Do
p has similar problem, fix it too.
Reported-by: Joonwoo Park
Sorry I was busy with something else so didn't have chance to follow up
on my initial proposal and thanks for take caring of this.
Signed-off-by: Namhyung Kim
---
tools/perf/builtin-sched.c | 9 ++---
tools/perf/builtin-sc
is is the exact thing I was also worried about and that's the reason I
tried to fix this in a different way.
However I didn't find any behaviour difference once any task attached to
child cfs_rq which is the point we really care about.
I found this bug while making patch at https://lkml.
howed 13% of hrtick rearm reduction
with this optimization whereas there was no measurable throughput
degradation when both sender and receiver groups are in the same cgroup.
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joonwoo Park
The first time when sched_slice becomes equal to sched_min_granularity
is when cfs_rq's nr_running becomes equal to sched_nr_latency. Fix
the condition to rearm the hrtick nr_running up to sched_nr_latency.
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: Thomas Gleixner
Cc: linux-kernel@vger.kernel.o
On 10/18/2016 04:56 AM, Vincent Guittot wrote:
Le Tuesday 18 Oct 2016 à 12:34:12 (+0200), Peter Zijlstra a écrit :
On Tue, Oct 18, 2016 at 11:45:48AM +0200, Vincent Guittot wrote:
On 18 October 2016 at 11:07, Peter Zijlstra wrote:
So aside from funny BIOSes, this should also show up when cr
On 10/18/2016 02:37 PM, Peter Zijlstra wrote:
Have you read this thread:
lkml.kernel.org/r/20161018115651.ga20...@linaro.org
Yeah... I noticed the thread... I'm replying to the thread too.
Thanks,
Joonwoo
: 1768.195390
Fix such fairness problems by updating parent's task group load_avg
only once when a new child cgroup is being created.
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joonwoo Park
---
kernel/sched/core.c | 2
On 10/04/2016 05:04 AM, Namhyung Kim wrote:
On Mon, Oct 03, 2016 at 03:04:48PM -0700, Joonwoo Park wrote:
On 09/30/2016 10:15 PM, Namhyung Kim wrote:
Hi Joonwoo,
On Wed, Sep 28, 2016 at 07:25:26PM -0700, Joonwoo Park wrote:
Perf sched latency is handy to find out the maximum sched
On 09/30/2016 10:15 PM, Namhyung Kim wrote:
Hi Joonwoo,
On Wed, Sep 28, 2016 at 07:25:26PM -0700, Joonwoo Park wrote:
Perf sched latency is handy to find out the maximum sched latency and
the time stamp of the event. After running sched latency, if a found
latency looks suspicious it&#
On 09/28/2016 07:25 PM, Joonwoo Park wrote:
Perf sched latency is handy to find out the maximum sched latency and
the time stamp of the event. After running sched latency, if a found
latency looks suspicious it's quite reasonable to run perf script
subsequently and search with the time
shkin
Cc: Steven Rostedt
Cc: Namhyung Kim
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joonwoo Park
---
I was tempted to get rid of all u64 to double casting in the function
output_lat_thread but didn't because there is no data loss as of
today. Double float gives at least 15 signifi
rg
Signed-off-by: Joonwoo Park
---
I think we can get rid of ops->get_optimum_mode since *most* of regulator
drivers' get_optimum_mode ops are dead code.
The only driver at least I found which has valid vaild_modes_mask with proper
ops->get_optimum_mode is wm8350-regulator.c used by mach-
On Mon, Sep 19, 2016 at 11:04:49AM -0700, Joonwoo Park wrote:
> On Mon, Sep 19, 2016 at 10:21:58AM +0200, Peter Zijlstra wrote:
> > On Fri, Sep 16, 2016 at 06:28:51PM -0700, Joonwoo Park wrote:
> > > From: Srivatsa Vaddagiri
> > >
> > > SCHED_HRTICK feature i
On Sun, Sep 18, 2016 at 07:28:32AM +0800, Wanpeng Li wrote:
> 2016-09-17 9:28 GMT+08:00 Joonwoo Park :
> > From: Srivatsa Vaddagiri
> >
> > SCHED_HRTICK feature is useful to preempt SCHED_FAIR tasks on-the-dot
> > (just when they would have exceeded their ideal_runtime)
On Mon, Sep 19, 2016 at 10:21:58AM +0200, Peter Zijlstra wrote:
> On Fri, Sep 16, 2016 at 06:28:51PM -0700, Joonwoo Park wrote:
> > From: Srivatsa Vaddagiri
> >
> > SCHED_HRTICK feature is useful to preempt SCHED_FAIR tasks on-the-dot
>
> Right, but I always found th
for tasks in other cfs_rq on same cpu.
Fix this by alarming sched hrtimer based on total number of SCHED_FAIR
tasks a CPU has across its various cfs_rqs.
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Srivatsa Vaddagiri
Signed-off-by: Joonwoo Park
The top cpuset's effective_cpus are guaranteed to be identical to
cpu_online_mask eventually. Hence fall back to cpu_online_mask when
there is no intersection between top cpuset's effective_cpus and
cpu_online_mask.
Signed-off-by: Joonwoo Park
Cc: Li Zefan
Cc: Tejun Heo
Cc: cgro...@vger.k
On Mon, Sep 12, 2016 at 10:48:31AM +0800, Zefan Li wrote:
> Cc: Tejun
>
> On 2016/9/9 8:41, Joonwoo Park wrote:
> > Discrepancy between cpu_online_mask and cpuset's effective CPU masks on
> > cpuset hierarchy is inevitable since cpuset defers updating of
> > ef
ed to be identical to online
CPUs eventually. Hence fall back to online CPU mask when there is no
intersection between top cpuset's effective_cpus and online CPU mask.
Signed-off-by: Joonwoo Park
Cc: Li Zefan
Cc: cgro...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
kernel/cpuset.c | 17
Commit-ID: 3ea94de15ce9f3a217f6d0a7e9e0f48388902bb7
Gitweb: http://git.kernel.org/tip/3ea94de15ce9f3a217f6d0a7e9e0f48388902bb7
Author: Joonwoo Park
AuthorDate: Thu, 12 Nov 2015 19:38:54 -0800
Committer: Ingo Molnar
CommitDate: Mon, 23 Nov 2015 09:48:17 +0100
sched/core: Fix incorrect
SK_ON_RQ_MIGRATING while dequeuing and enqueuing due to migration.
To: Ingo Molnar
To: Peter Zijlstra
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joonwoo Park
---
Changes in v2:
* Set p->on_rq = TASK_ON_RQ_MIGRATING while doing migration dequeue/enqueue
and check whether
On Fri, Nov 06, 2015 at 02:57:49PM +0100, Peter Zijlstra wrote:
> On Tue, Oct 27, 2015 at 09:46:53PM -0700, Joonwoo Park wrote:
> > @@ -1272,6 +1272,15 @@ void set_task_cpu(struct task_struct *p, unsigned
> > int new_cpu)
> > WARN_ON_ONCE(p->state != TASK_RUNNING &a
ask->on_rq with
TASK_ON_RQ_MIGRATING while dequeuing and enqueuing due to migration.
To: Ingo Molnar
To: Peter Zijlstra
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joonwoo Park
---
Changes in v2:
* Set p->on_rq = TASK_ON_RQ_MIGRATING while doing migration dequeue/enqueue
and check whether
On Tue, Oct 27, 2015 at 01:57:28PM +0100, Peter Zijlstra wrote:
>
> (Excessive quoting for Olav)
>
> On Mon, Oct 26, 2015 at 06:44:48PM -0700, Joonwoo Park wrote:
> > On 10/25/2015 03:26 AM, Peter Zijlstra wrote:
>
> > > Also note that on both sites we also set
SK_ON_RQ_MIGRATING while dequeuing and enqueuing due to migration.
To: Ingo Molnar
To: Peter Zijlstra
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Joonwoo Park
---
Changes in v2:
* Set p->on_rq = TASK_ON_RQ_MIGRATING while doing migration dequeue/enqueue
and check whether
On 10/25/2015 03:26 AM, Peter Zijlstra wrote:
> On Sat, Oct 24, 2015 at 10:23:14PM -0700, Joonwoo Park wrote:
>> @@ -1069,7 +1069,7 @@ static struct rq *move_queued_task(struct rq *rq,
>> struct task_struct *p, int new
>> {
>> lockdep_assert_held(&rq->lock
event which can be seen by trace or /proc//sched with
CONFIG_SCHEDSTATS=y.
Carry forward migrating task's wait time prior to migration and don't
count migration as a wait end event to fix such statistics error.
Cc: Ingo Molnar
Cc: Peter Zijlstra
Cc: linux-kernel@vger.kernel.org
Signed-
Commit-ID: 781978e6e156101209f62b9ebc8783b70ef248de
Gitweb: http://git.kernel.org/tip/781978e6e156101209f62b9ebc8783b70ef248de
Author: Joonwoo Park
AuthorDate: Mon, 27 Apr 2015 19:21:49 -0700
Committer: Thomas Gleixner
CommitDate: Tue, 5 May 2015 10:40:43 +0200
timer: Use timer->b
Thomas, I made some clean up. Will much appreciate if you can give me some
feedback on this.
Thanks,
Joonwoo
On 04/27/2015 07:39 PM, Joonwoo Park wrote:
> When a deferrable work (INIT_DEFERRABLE_WORK, etc.) is queued via
> queue_delayed_work() it's probably intended to run the work
le, introduce a common
timer base which is only for cpu unbound deferrable timers to make those
are indeed cpu unbound so that can be scheduled by tick_do_timer_cpu.
This common timer fixes scalability issue of delayed work and all other cpu
unbound deferrable timer using implementations.
CC: Thomas G
At present, internal_add_timer() examines flags with 'base' which doesn't
contain flags. Examine with 'timer->base' to avoid unnecessary waking up
of nohz CPU when timer base has TIMER_DEFERRABLE.
CC: Thomas Gleixner
CC: John Stultz
Signed-off-by: Joonwoo Park
Hi Thomas,
Please find patch v3 which makes only tick_do_timer_cpu to run deferral timer
wheel to reduce cache bouncing and let me know what you think.
Thanks,
Joonwoo
>From 0c91f82a0b43b247f1ed310212ef3aada7ccc9f7 Mon Sep 17 00:00:00 2001
From: Joonwoo Park
Date: Thu, 11 Sep 2014 15:34
On Tue, Sep 23, 2014 at 08:33:34PM +0200, Thomas Gleixner wrote:
> On Mon, 15 Sep 2014, Joonwoo Park wrote:
> > +#ifdef CONFIG_SMP
> > +static struct tvec_base *tvec_base_deferral = &boot_tvec_bases;
> > +#endif
>
> In principle I like the idea of a deferrable whee
le, introduce a common
timer base which is only for cpu unbound deferrable timers to make those
are indeed cpu unbound so that can be scheduled by any of non idle cpus.
This common timer fixes scalability issue of delayed work and all other cpu
unbound deferrable timer using implementations.
CC: Thomas
On Thu, Sep 11, 2014 at 04:56:52PM -0700, Joonwoo Park wrote:
> When a deferrable work (INIT_DEFERRABLE_WORK, etc.) is queued via
> queue_delayed_work() it's probably intended to run the work item on any
> CPU that isn't idle. However, we queue the work to run at a later t
le, introduce a common
timer base which is only for cpu unbound deferrable timers to make those
are indeed cpu unbound so that can be scheduled by any of non idle cpus.
This common timer fixes scalability issue of delayed work and all other cpu
unbound deferrable timer using implementations.
cc: Thoma
eview netconsole
target configs from cmdline.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/netconsole.c | 91 --
1 files changed, 72 insertions(+), 19 deletions(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
in
default_groups was allocated with kcalloc, so initialize to NULL
is unnecessary.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
fs/ocfs2/cluster/nodemanager.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/cluster/nodemanager.c b/fs/ocfs2/c
default_groups was allocated with kcalloc, so initialize to NULL
is unnecessary.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
fs/dlm/config.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/config.c b/fs/dlm/config.c
index c3ad1df..2b96428 100644
--
2008/2/9, Jan Engelhardt <[EMAIL PROTECTED]>:
>
> On Feb 9 2008 00:14, Joonwoo Park wrote:
> >2008/2/8, rohit h <[EMAIL PROTECTED]>:
> >> Hi,
> >> I am a kernel newbie.
> >> I tried to insmod a C++ module containing classes, inheritance.
>
2008/2/8, rohit h <[EMAIL PROTECTED]>:
> Hi,
> I am a kernel newbie.
> I tried to insmod a C++ module containing classes, inheritance.
> I am getting 'unresolved symbol' error when I use the 'new' keyword.
> What could the problem be?
>
> What kind of runtime support is needed ( arm linux kern
uld be
called after doing synchronize_irq.
To avoid races between iwl_synchronize_irq and iwl_irq_tasklet
STATUS_INT_ENABLED flag is needed.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 33 ++-
1 files changed,
Joonwoo Park wrote:
2008/1/11, Chatre, Reinette <[EMAIL PROTECTED]>:
On Thursday, January 10, 2008 5:25 PM, Joonwoo Park wrote:
What modification are you considering?
Roughly, I'm considering make synchronize_irq() be moved into
iwl_disable_interrupts() and fix iwl_irq_tasket
2008/1/11, Zhu Yi <[EMAIL PROTECTED]>:
>
> The version doesn't work on a .24-rc kernel. Can you compile it
> with .23?
>
Thank you for your help, I built it.
Thanks,
Joonwoo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Mo
2008/1/11, Zhu Yi <[EMAIL PROTECTED]>:
> Hi Joonwoo,
>
> We already did something similiar in our code base. Could you please
> take a look at this patch?
>
> http://intellinuxwireless.org/repos/?p=iwlwifi.git;a=commitdiff;h=57aa02255e9d7be5e2494683fc2793bd1d0707e2
>
> Thanks,
> -yi
Ooops :-)
I sh
Hello Reinette,
2008/1/11, Chatre, Reinette <[EMAIL PROTECTED]>:
>
> Could synchronize_irq() be moved into iwl_disable_interrupts() ? I am
At this time, iwl_disable_interrupts() can be called with irq
disabled, so for do that I think additional modification would be
needed.
> also wondering if w
The ieee80211 provides workqueue for nic drivers. private workqueue dosen't
need anymore
TODO: remove workqueue in iwl_priv
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/wireless/iwlwifi/iwl-3945.c |6 ++--
drivers/net/wireless/iwlwifi/iwl3945-ba
Eleminiate task queuing of iwl_pci_probe, register hw to ieee80211 immediately
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c | 66 +-
1 files changed, 43 insertions(+), 23 deletions(-)
diff --git a/drivers/net/wi
EIP: [] iwl_irq_tasklet+0x82d/0x1010 [iwl3945] SS:ESP 0068:f7c4ff1c
Kernel panic - not syncing: Fatal exception in interrupt
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --gi
After disabling interrupts, it's possible irq & tasklet is pending or running
This patch eleminates races for down iwlwifi
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/wireless/iwlwifi/iwl3945-base.c |4
1 files changed, 4 insertions(+), 0 deletions(-
After enabling/disabling interrupts flushing is required
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/wireless/iwlwifi/iwl-io.h |2 ++
drivers/net/wireless/iwlwifi/iwl3945-base.c |6 ++
2 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/d
Hello,
This patchset does fix iwl3945's races and some other stuff.
For now it works for just iwl3945 but if some of them is needed for iwl4965, I
would work for it.
patch against 2.6.24-rc7
[PATCH 1/5] iwlwifi: iwl3945 flush interrupt mask
[PATCH 2/5] iwlwifi: iwl3945 synchronize interrupt and
Hi Jay,
+ if ((work_done < budget) || !netif_running(poll_dev)) {
+quit_polling:
+ netif_rx_complete(poll_dev, napi);
+
+ if (!test_bit(__ATL1_DOWN, &adapter->flags))
+ atlx_irq_enable(adapter);
+ }
Not enough :)
If netif_running() is
2008/1/1, [EMAIL PROTECTED] <[EMAIL PROTECTED]>:
> From: Jay Cliburn <[EMAIL PROTECTED]>
>
> Add support for NAPI, styled after the e1000 NAPI implementation. That we
> follow the e1000 for NAPI shouldn't come as much of a surprise, since the
> entire atl1 driver is based heavily upon it.
>
> Sign
eview netconsole target
configs from cmdline.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/netconsole.c | 91 --
1 files changed, 72 insertions(+), 19 deletions(-)
diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
in
120
[] lock_acquire+0x82/0xa0
[] mutex_lock_nested+0x98/0x2e0
[] configfs_attach_group+0x4f/0x190
[] configfs_register_subsystem+0xc6/0x130
[] init_netconsole+0x2b6/0x300
[] kernel_init+0x142/0x320
[] kernel_thread_helper+0x7/0x14
=======
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
--
00
[] kernel_init+0x142/0x320
[] kernel_thread_helper+0x7/0x14
=======
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
fs/configfs/file.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/configfs/file.c b/fs/configfs/file.c
index a3658f9..397cb50 1006
default_groups was allocated with kcalloc, so initialization to NULL is
unnecessary.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
fs/dlm/config.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/fs/dlm/config.c b/fs/dlm/config.c
index 2f8e3c8..95085d1
default_groups was allocated with kcalloc, so initialization to NULL is
unnecessary.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
fs/ocfs2/cluster/nodemanager.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/ocfs2/cluster/nodemanager.c b/fs/ocfs2/c
2007/12/13, David Miller <[EMAIL PROTECTED]>:
> From: "Joonwoo Park" <[EMAIL PROTECTED]>
> Date: Thu, 13 Dec 2007 19:18:56 +0900
>
> > Just blowing netif_running up is not best solution I think, it makes
> > ifconfig down hang at least for e1000.
>
&g
2007/12/13, Andrew Gallatin <[EMAIL PROTECTED]>:
>
> If the netif_running() check is indeed required to make a device break
> out of napi polling and respond to an ifconfig down, then I think the
> netif_running() check should be moved up into net_rx_action() to avoid
> potential for driver complex
2007/12/12, Joonwoo Park <[EMAIL PROTECTED]>:
> [NETDEV]: e1000 Fix possible causing oops of net_rx_action
> returning work_done == weight as true after calling netif_rx_complete will
> cause oops in net_rx_action.
>
I tried two types of patches for oops and ifconfig down ha
2007/12/13, Kok, Auke <[EMAIL PROTECTED]>:
> David Miller wrote:
> > From: Andrew Gallatin <[EMAIL PROTECTED]>
> > Date: Wed, 12 Dec 2007 12:29:23 -0500
> >
> >> Is the netif_running() check even required?
> >
> > No, it is not.
> >
> > When a device is brought down, one of the first things
> > tha
2007/12/13, David Miller <[EMAIL PROTECTED]>:
> From: "Joonwoo Park" <[EMAIL PROTECTED]>
> Date: Wed, 12 Dec 2007 13:01:27 +0900
>
>
> Any time your trying to make a caller "happy" by adjusting
> a return value forcefully, it's a hack.
2007/12/12, Subrata Modak <[EMAIL PROTECTED]>:
> Would you like to submit the Driver Test Cases to LTP ? Or, if you have
> your Driver test cases written in C, we can port to LTP and have it
> inside the LTP package.
> You can also check out the following links for more info, and can always
> ping
2007/12/12, Andrew Morton <[EMAIL PROTECTED]>:
>
> Did drivers/net/wireless/iwlwifi/iwl4965-base.c get fixed in a simlar
> fashion?
>
Hi Andrew,
Both of them was applied to mainline.
commit 3ae6a054553ee8b7f74bf7de8904022b26705778
Author: Joonwoo Park <[EMAIL PROTECTED]>
2007/12/12, Stephen Hemminger <[EMAIL PROTECTED]>:
> Isn't this a better fix for all drivers, rather than peppering every
> driver with the special case. This is how the logic worked up until
> 2.6.24.
>
>
> --- a/net/core/dev.c2007-12-11 12:16:20.0 -0800
> +++ b/net/core/dev.c2007-
2007/12/12, Stephen Hemminger <[EMAIL PROTECTED]>:
> On Wed, 12 Dec 2007 13:01:27 +0900
> "Joonwoo Park" <[EMAIL PROTECTED]> wrote:
>
> > [NETDEV]: tehuti Fix possible causing oops of net_rx_action
> >
> > Signed-off-by: Joonwoo Park <[EMAIL
[NETDEV]: tehuti Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/tehuti.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/tehuti.c b/drivers/net/tehuti.c
index 21230c9..955e749 100644
--- a/d
[NETDEV]: e1000e Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/e1000e/netdev.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000e/netdev.c b/drivers/net/e1000e/netdev.c
index 4fd2e23..8
[NETDEV]: ixgb Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/ixgb/ixgb_main.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ixgb/ixgb_main.c b/drivers/net/ixgb/ixgb_main.c
index 3021234..a
[NETDEV]: e1000 Fix possible causing oops of net_rx_action
returning work_done == weight as true after calling netif_rx_complete will
cause oops in net_rx_action.
Thanks
Joonwoo
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/e1000/e1000_main.c |2 ++
1 files chan
[NETDEV]: e100 Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/e100.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e100.c b/drivers/net/e100.c
index e1c8a0d..7cb4ed0 100644
--- a/drivers/ne
[NETDEV]: ixgbe Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/ixgbe/ixgbe_main.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
index 0
[NETDEV]: myri10ge Fix possible causing oops of net_rx_action
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
drivers/net/myri10ge/myri10ge.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/myri10ge/myri10ge.c b/drivers/net/myri10ge/myri10ge.c
2007/12/12, Brandeburg, Jesse <[EMAIL PROTECTED]>:
>
> all drivers using NAPI in 2.6.24+ (NNAPI??) must return zero here, after
> calling netif_rx_complete. netif_rx_complete plus work_done != 0 causes
> a bug.
>
Brandeburg,
Don't we need to return non-zero work_done after netif_rx_complete if
wo
2007/12/12, Brandeburg, Jesse <[EMAIL PROTECTED]>:
> Joonwoo Park wrote:
> > /* If no Tx and not enough Rx work done, exit the polling mode */
> > if ((!tx_cleaned && (work_done == 0)) ||
> >!netif_running(poll_dev)) {
> > quit_polling:
&g
2007/12/11, David Miller <[EMAIL PROTECTED]>:
> From: "Joonwoo Park" <[EMAIL PROTECTED]>
> Date: Tue, 11 Dec 2007 18:13:34 +0900
>
> Joonwoo-ssi annyoung haseyo,
Wow Great! :-)
> How can the NAPI_STATE_SCHED bit be cleared externally yet we take
>
[NET]: Fix Ooops of napi net_rx_action.
Before doing list_move_tail napi poll_list, it should be ensured
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/net/core/dev.c b/net/core/dev.c
index 86d6261..74bd5ab 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -2207,7 +
2007/12/5, Herbert Xu <[EMAIL PROTECTED]>:
> The idea is to not touch the unicast stuff at all on the multicast path.
>
> Anyway, this was discussed on netdev so please check the archives because
> there is more to this than just changing the multicast handling. We also
> talked about consolidatin
2007/12/5, Herbert Xu <[EMAIL PROTECTED]>:
> Joonwoo Park <[EMAIL PROTECTED]> wrote:
> > Hi,
> > dev_set_rx_mode calls __dev_set_rx_mode with softirq disabled (by
> > netif_tx_lock_bh)
> > therefore __dev_set_promiscuity can be called with softirq disabl
Hi,
dev_set_rx_mode calls __dev_set_rx_mode with softirq disabled (by
netif_tx_lock_bh)
therefore __dev_set_promiscuity can be called with softirq disabled.
It will cause in_interrupt() to return true and ASSERT_RTNL warning.
Is there a good solution to fix it besides blowing ASSERT_RTNL up?
Than
The cancel_delayed_work_sync has moved into ilw_cancel_deferred_work.
Thanks Zhu Yi.
[net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c
b/drivers/net/wireless/i
[net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c
b/drivers/net/wireless/iwlwifi/iwl3945-base.c
index 465da4f..e51e872 100644
--- a/drivers/net/wireless/iwlwifi/iwl
04 00
00 <3b> 06 74 0d 43 83 fb 02 77 23 c7 45 e8 fb ff ff ff 83 c1 64 39
EIP: [] iwl_verify_inst_sparse+0x101/0x140 [iwl3945] SS:ESP
0068:dfef5f00
Thanks
Joonwoo
[net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
I think 4965 may suffer it too, but I could not test.
Thanks
Joonwoo
[net/wireless/iwlwifi] : iwlwifi 4965 Fix race conditional panic.
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/drivers/net/wireless/iwlwifi/iwl4965-base.c
b/drivers/net/wireless/iwlwifi/iwl4965-
2007/11/27, Herbert Xu <[EMAIL PROTECTED]>:
> On Tue, Nov 27, 2007 at 02:32:49PM +0900, Joonwoo Park wrote:
> >
> > Thanks Herbert.
> > Well.. I think patch would work propely for AF_PACKET also.
> > (I did not insert BUG() macro in my patch)
> > How do you
2007/11/26, Herbert Xu <[EMAIL PROTECTED]>:
> On Fri, Nov 23, 2007 at 12:12:52PM +, Joonwoo Park wrote:
> > This patch fixes http://bugzilla.kernel.org/show_bug.cgi?id=8766
> >
> > Is it possible?
> > BUG((veth->h_vlan_proto != htons(ETH_P_8021Q))
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> i realized that. but all you can say is that only amb_init() calls
> setup_dev() *currently*. when you're not looking, someone else might
> (for whatever reason) call setup_dev() from elsewhere, and *that* call
> might not zero that memory area.
>
> i believe the more common standard for the above is:
>
> else if (hashdist) {
>
> to reduce the level of overall indentation, no?
>
No, it was.
Because there was a memset in that indentation, but I made it by
removing memset.
Thanks.
Joonwoo
-
To unsubscribe from this list: send the line "un
fib_semantics: kmalloc + memset conversion to kzalloc
fix to avoid memset entirely.
Thanks.
Joonwoo
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/net/ipv4/fib_semantics.c b/net/ipv4/fib_semantics.c
index 1351a26..352f8c4 100644
--- a/net/ipv4/fib_semantics.c
+++ b/ne
ks.
Joonwoo
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/net/xfrm/xfrm_hash.c b/net/xfrm/xfrm_hash.c
index 55ab579..a2023ec 100644
--- a/net/xfrm/xfrm_hash.c
+++ b/net/xfrm/xfrm_hash.c
@@ -17,17 +17,14 @@ struct hlist_head *xfrm_hash_alloc(unsigned int sz)
fib_hash: kmalloc + memset conversion to kzalloc
fix to avoid memset entirely.
Thanks.
Joonwoo
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
---
diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c
index 527a6e0..9d0cee2 100644
--- a/net/ipv4/fib_hash.c
+++ b/net/ipv4/fib_hash.c
@@ -
2007/11/26, Robert P. J. Day <[EMAIL PROTECTED]>:
> i'm not sure the above is a safe thing to do, as you're zeroing that
> area, then making a function call and assuming, upon entry to the
> function call, that the caller has done the right thing. i don't see
> how you can count on that, depending
fib_hash: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Thanks.
Joonwoo
---
diff --git a/net/ipv4/fib_hash.c b/net/ipv4/fib_hash.c
index 527a6e0..2874fe7 100644
--- a/net/ipv4/fib_hash.c
+++ b/net/ipv4/fib_hash.c
@@ -102,10 +102,14 @@ static
atm/ambassador: kmalloc + memset conversion to kzalloc
Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]>
Thanks.
Joonwoo
---
diff --git a/drivers/atm/ambassador.c b/drivers/atm/ambassador.c
index b34b382..4f99ba3 100644
--- a/drivers/atm/ambassador.c
+++ b/drivers/atm/ambassador.c
@@ -
1 - 100 of 114 matches
Mail list logo
