Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-25 Thread Jonathan Lim
Randy Dunlap. Diff'd against: linux/kernel/git/torvalds/linux-2.6.git Signed-off-by: Jonathan Lim <[EMAIL PROTECTED]> --- a/include/linux/jiffies.h Thu Feb 14 18:04:14 PST 2008 +++ b/include/linux/jiffies.h Thu Feb 14 18:07:17 PST 2008 @@ -42,7 +42,7 @@ /* LATCH is used in the in

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Jonathan Lim
Randy Dunlap. Diff'd against: linux/kernel/git/torvalds/linux-2.6.git Signed-off-by: Jonathan Lim <[EMAIL PROTECTED]> --- a/include/linux/jiffies.h Thu Feb 14 18:04:14 PST 2008 +++ b/include/linux/jiffies.h Thu Feb 14 18:07:17 PST 2008 @@ -42,7 +42,7 @@ /* LATCH is used in the in

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in

2008-02-19 Thread Jonathan Lim
On Tue Feb 19 13:25:25 2008, [EMAIL PROTECTED] wrote: > > > +u64 inline jiffies_64_to_usecs(const u64 j) > > +{ > > + u64 tmp = j*HZ_TO_USEC_NUM + HZ_TO_USEC_DEN-1; > > + do_div(tmp, HZ_TO_USEC_DEN); > > do_div() is: > * The semantics of do_div() are: > * > * uint32_t do_div(uint64_t *n, u

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-19 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Diff'd against: linux/kernel/git/torvalds/linux-2.6.git Signed-off-by: Jo

[PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-02-14 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Diff'd against: linux/kernel/git/torvalds/linux-2.6.git Signed-off-by: Jo

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-07 Thread Jonathan Lim
nst: linux/kernel/git/torvalds/linux-2.6.git Signed-off-by: Jonathan Lim <[EMAIL PROTECTED]> --- a/include/linux/jiffies.h 2008-01-07 16:09:17.737040981 -0800 +++ b/include/linux/jiffies.h 2008-01-07 16:09:17.693033003 -0800 @@ -36,7 +36,7 @@ /* LATCH is used in the interval timer

Re: [PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2008-01-02 Thread Jonathan Lim
On Wed Jan 2 16:36:47 2008, [EMAIL PROTECTED] wrote: > > Andrew Morton wrote: > > On Fri, 28 Dec 2007 13:26:07 -0800 (PST) Jonathan Lim <[EMAIL PROTECTED]> > > wrote: > > > >> It's possible that the values used in and returned from jiffies_to_usec

[PATCH] Provide u64 version of jiffies_to_usecs() in kernel/tsacct.c

2007-12-28 Thread Jonathan Lim
It's possible that the values used in and returned from jiffies_to_usecs() are incorrect because of truncation when variables of type u64 are involved. So a function specific to that type is used instead. Diff'd against: linux/kernel/git/stable/linux-2.6.23.y.git Signed-off-by: Jo

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-09-07 Thread Jonathan Lim
On Fri Aug 31 00:24:47 2007, [EMAIL PROTECTED] wrote: > > Jonathan Lim wrote: > > On Sat Aug 25 21:58:44 2007, [EMAIL PROTECTED] wrote: > >>> Also, I don't understand why the code to update btime: > >>> > >>&g

Re: [PATCH] Add all thread stats for TASKSTATS_CMD_ATTR_TGID

2007-08-30 Thread Jonathan Lim
On Sat Aug 25 21:58:44 2007, [EMAIL PROTECTED] wrote: > > > Also, I don't understand why the code to update btime: > > > > /* calculate task elapsed time in timespec */ > > do_posix_clock_monotonic_gettime(&uptime); > > ts = timespec_sub(uptime, tsk->start_time); > > .

[PATCH] Assign task_struct.exit_code before taskstats_exit()

2007-08-21 Thread Jonathan Lim
stats_exit() has been called. So we need to move the assignment before taskstats_exit(). Diff'd against: linux/kernel/git/stable/linux-2.6.22.y.git Signed-off-by: Jonathan Lim <[EMAIL PROTECTED]> --- a/kernel/exit.c 2007-08-20 16:37:55.0 -0700 +++ b/kernel/exit.c

Re: [PATCH] Send exit code through for taskstats.ac_exitcode

2007-08-21 Thread Jonathan Lim
On Tue Aug 21 11:27:07 2007, [EMAIL PROTECTED] wrote: > > > Hi Balbir, > > > > That was what I wanted to do at first, but there was some concern over > > whether it would affect any of the intervening function calls. If there's > > no particular reason why the tsk->exit_code assignment is placed

Re: [PATCH] Send exit code through for taskstats.ac_exitcode

2007-08-21 Thread Jonathan Lim
On Mon Aug 20 20:44:13 2007, [EMAIL PROTECTED] wrote: > > Jonathan Lim wrote: > > taskstats.ac_exitcode is assigned to task_struct.exit_code in > > bacct_add_tsk() through the following kernel function calls: > > > > do_exit() > > task

[PATCH] Send exit code through for taskstats.ac_exitcode

2007-08-20 Thread Jonathan Lim
only after taskstats_exit_send() has been called. So we need to send 'code' through to bacct_add_tsk(). Diff'd against: linux/kernel/git/stable/linux-2.6.22.y.git Signed-off-by: Jonathan Lim <[EMAIL PROTECTED]> --- a/kernel/exit.c 2007-08-20 16:37:55.0 -0700 +++ b/ker

Re: [PATCH] Performance Stats: Kernel patch

2007-06-04 Thread Jonathan Lim
Looking at the diffs below, I see context switch counters added. What is actually being removed? Jonathan On Mon Jun 4 12:33:15 2007, [EMAIL PROTECTED] wrote: > > Add Jonathan Lim to cc, who is working on CSA userland implementation > to use the taskstats data that this patch is