[net-next,v3] tcp: Improve setsockopt() TCP_USER_TIMEOUT accuracy

2018-07-09 Thread Jon Maxwell
expected 10 second timeout: 1st retransmit: 01:37:59.022555 IP host1.49310 > host2.search-agent: Flags [.] Last retransmit: 01:38:06.486558 IP host1.49310 > host2.search-agent: Flags [.] Timeout: send: Connection timed out Mon Jul 2 01:38:09 EDT 2018 Signed-off-by: Jon Maxwell ---

[PATCH net-next] ifb: fix packets checksum

2018-05-24 Thread Jon Maxwell
Fixup the checksum for CHECKSUM_COMPLETE when pulling skbs on RX path. Otherwise we get splats when tc mirred is used to redirect packets to ifb. Before fix: nic: hw csum failure Signed-off-by: Jon Maxwell --- drivers/net/ifb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH net-next v2] tcp: Add mark for TIMEWAIT sockets

2018-05-09 Thread Jon Maxwell
ginal sk->sk_mark in __inet_twsk_hashdance() to the new tw->tw_mark location. Then progate this so that the skb gets sent with the correct mark. Do the same for resets. Give the "fwmark_reflect" sysctl precedence over sk->sk_mark so that netfilter rules are still honored. Sign

[PATCH net-next v1] tcp: Add mark for TIMEWAIT sockets

2018-05-09 Thread Jon Maxwell
tw->tw_mark location. Then progate this so that the skb gets sent with the correct mark. Do the same for resets. Give the "fwmark_reflect" sysctl precedence over sk->sk_mark so that netfilter rules are still honored. Signed-off-by: Jon Maxwell --- include/net/inet_timewait_sock

[PATCH net-next] tcp: Add mark for TIMEWAIT sockets

2018-05-09 Thread Jon Maxwell
k_mark so that netfilter rules are still honored. Signed-off-by: Jon Maxwell --- include/net/inet_timewait_sock.h | 1 + net/ipv4/ip_output.c | 3 ++- net/ipv4/tcp_ipv4.c | 18 -- net/ipv4/tcp_minisocks.c | 1 + net/ipv6/tcp_ipv6.c

[PATCH net-next] cryptd: Add cryptd_max_cpu_qlen module parameter

2017-11-21 Thread Jon Maxwell
Make the cryptd queue length configurable. We recently had customer where this needed to be tuned to accommodate the aesni_intel module and prevent packet drop. Signed-off-by: Jon Maxwell --- crypto/cryptd.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/crypto

[PATCH net, v2] dccp/tcp: fix routing redirect race

2017-03-09 Thread Jon Maxwell
utes. Which can set the dst->obsolete flag so that ipv4_dst_check() returns null and triggers the dst_release(). Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") Cc: Eric Garver Cc: Hannes Sowa Signed-off-by: Jon Maxwell --- net/dccp/ipv4.c | 3 ++- ne

[PATCH net, v1] dccp/tcp: fix routing redirect race

2017-03-09 Thread Jon Maxwell
s. Which can set the dst->obsolete flag so that ipv4_dst_check() returns null and triggers the dst_release(). Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") Cc: Eric Garver Cc: Hannes Sowa Signed-off-by: Jon Maxwell --- net/dccp/ipv4.c | 3 ++

[PATCH net] dccp/tcp: fix routing redirect race

2017-03-08 Thread Jon Maxwell
_release(). Fixes: ceb3320610d6 ("ipv4: Kill routes during PMTU/redirect updates.") Cc: Eric Garver Cc: Hannes Sowa Signed-off-by: Jon Maxwell --- net/dccp/ipv4.c | 3 ++- net/ipv4/tcp_ipv4.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/net/dccp/ipv4.c b/net/d

[PATCH net-next] ibmveth: v1 calculate correct gso_size and set gso_type

2016-10-25 Thread Jon Maxwell
able to reproduce this and worked with IBM to fix this. Thanks Tom and Marcelo for all your help and review on this. The patch fixes both our internal reproduction tests and our customers tests. Signed-off-by: Jon Maxwell --- drivers/net/ethernet/ibm/ibmveth.c | 20 1 file

[PATCH net-next] ibmveth: calculate correct gso_size and set gso_type

2016-10-24 Thread Jon Maxwell
able to reproduce this and worked with IBM to fix this. Thanks Tom and Marcelo for all your help and review on this. The patch fixes both our internal reproduction tests and our customers tests. Signed-off-by: Jon Maxwell --- drivers/net/ethernet/ibm/ibmveth.c | 19 +++ 1 file

[PATCH net-next] cnic: call cp->stop_hw() in cnic_start_hw() on allocation failure

2016-05-04 Thread Jon Maxwell
nic_cm_alloc_mem()s return code. # ip link set dev enpX down # ip link set dev enpX up <--- hit's allocation failure # ip link set dev enpX down <--- crashes here With this patch I confirmed there was no crash in the reproducer. Signed-off-by: Jon Maxwell --- drivers/net/ethern

[net] igbvf: remove "link is Up" message when registering mcast address

2016-01-24 Thread Jon Maxwell
the igbvf driver and downing the adapter with the PF entity on the host where the VM has this patch. When I bring it back up again connectivity is restored as expected. Therefore I request that this patch gets submitted. Signed-off-by: Jon Maxwell --- drivers/net/ethernet/intel/igbvf/netdev.c | 1

[PATCH net] netconsole: Check for carrier before calling netpoll_send_udp()

2015-08-10 Thread Jon Maxwell
and the crash is avoided. When the adapter is back online and carrier is reasserted netconsole will succeed again. Signed-off-by: Jon Maxwell --- drivers/net/netconsole.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c in

[PATCH net-next] tcp: v1 always send a quick ack when quickacks are enabled

2015-07-07 Thread Jon Maxwell
utine which ensures that a quickack is always sent when the quickack knob is enabled for that dst. Signed-off-by: Jon Maxwell --- net/ipv4/tcp_input.c | 11 +-- net/ipv4/tcp_output.c | 6 ++ 2 files changed, 7 insertions(+), 10 deletions(-) diff --git a/net/ipv4/tcp_input.c b/net/i

[PATCH net-next] tcp: always send a quick ack when quickacks are enabled

2015-07-06 Thread Jon Maxwell
When that occurs the icsk_ack.pingpong value is ignored and a delayed ACK is sent regardless. This patch moves the RTAX_QUICKACK per dst check into the __tcp_ack_snd_check() routine which ensures that a quickack is always sent when the quickack knob is enabled for that dst. Signed-off-by: Jon

[PATCH net] tcp: fix connect() invalid -EADDRNOTAVAIL error

2014-11-18 Thread Jon Maxwell
p ports are in use for connection from IP Address (1). Connecting to the same ports via IP Address (2) should work based on the 4 tuple rule. But it fails under this condition. To fix this make __inet_hash_connect() honour inet_csk_get_port()'s tb->fastreuse* variables. Signed-off-by:

[PATCH net] bridge: notify user space after fdb update

2014-05-29 Thread Jon Maxwell
s ARP cache. This patch will notify the bridge command, after a fdb has been updated to identify such port toggling. Signed-off-by: Jon Maxwell --- net/bridge/br_fdb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index 92

[PATCH net] bridge: notify user space after fdb update

2014-05-27 Thread Jon Maxwell
s ARP cache. This patch will notify the bridge command, after a fdb has been updated to identify such port toggling. Signed-off-by: Jon Maxwell --- net/bridge/br_fdb.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index 92

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-23 Thread Jon Maxwell
> I have no more comments except for style problems (bracket position, > indentation, type mismatch). > thank you for rewriting :) np, yes this is a draft but I will make sure complies with checkpatch.pl before submitting it. Regards Jon > > Thanks, > Toshiaki Makita > > > > > $ diff -Naur

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-22 Thread Jon Maxwell
> - Original Message - > > From: "Toshiaki Makita" > > To: "Jon Maxwell" , step...@networkplumber.org > > Cc: da...@davemloft.net, vyase...@redhat.com, > > bri...@lists.linux-foundation.org, net...@vger.kernel.org, > > linux-kernel@vg

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
- Original Message - > From: "Jon Maxwell" > To: step...@networkplumber.org > Cc: da...@davemloft.net, "makita toshiaki" , > vyase...@redhat.com, > bri...@lists.linux-foundation.org, net...@vger.kernel.org, > linux-kernel@vger.kernel.org, jpi...@r

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
Please use this patch. My bad, the previous one incorrectly did the notify before fdb->added_by_user = 1. - Original Message - > From: "Jon Maxwell" > To: step...@networkplumber.org > Cc: da...@davemloft.net, "makita toshiaki" , > vyase.

[PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
From: Jon Maxwell There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network. However some NICs have an inbuilt

[PATCH net] bridge: notify user space of fdb port change

2014-05-16 Thread Jon Maxwell
From: Jon Maxwell There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network. However some NICs have an inbuilt

Re: [PATCH net] bridge: notify user space of fdb port change

2014-05-14 Thread Jon Maxwell
- Original Message - > From: "Toshiaki Makita" > To: "Jon Maxwell" , step...@networkplumber.org > Cc: da...@davemloft.net, vyase...@redhat.com, > bri...@lists.linux-foundation.org, net...@vger.kernel.org, > linux-kernel@vger.kernel.org, jpi...@red

[PATCH net] bridge: notify user space of fdb port change

2014-05-13 Thread Jon Maxwell
From: Jon Maxwell There has been a number incidents recently where customers running KVM have reported that VM hosts on different Hypervisors are unreachable. Based on pcap traces we found that the bridge was broadcasting the ARP request out onto the network. However some NICs have an inbuilt

Re: [PATCH net] bridge: Add port flap detection

2014-05-04 Thread Jon Maxwell
e dev = %s mac = %pM, port_no = %d, existing dev = %s mac = %pM, port_no = %d\n", - Original Message - From: "Alexei Starovoitov" To: "Stephen Hemminger" Cc: "Jon Maxwell" , net...@vger.kernel.org, "David S. Miller" , "makita toshiaki"

[PATCH net] bridge: Add port flap detection

2014-05-04 Thread Jon Maxwell
x27;s ARP cache. This patch will detect port flapping and log a message so that this condition can be detected earlier. Signed-off-by: Jon Maxwell --- net/bridge/br_fdb.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c index 9203d5a..c0