Re: [PATCH v6 12/16] net: tip: fix a couple kernel-doc markups

2021-01-14 Thread Jon Maloy
* @dnode: address of destination node Acked-by: Jon Maloy

RE: [PATCH v2] tipc: initialise addr_trail_end when setting node addresses

2019-08-10 Thread Jon Maloy
et by the user. Acked-by: Jon Maloy > -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Chris Packham > Sent: 8-Aug-19 20:55 > To: Jon Maloy ; ying@windriver.com; > da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.so

RE: [PATCH] tipc: set addr_trail_end when using explicit node addresses

2019-08-08 Thread Jon Maloy
From: netdev-ow...@vger.kernel.org On > Behalf Of Chris Packham > Sent: 7-Aug-19 00:56 > To: Jon Maloy ; ying@windriver.com; > da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org; Chris Packham > Subject: [PATCH

RE: Slowness forming TIPC cluster with explicit node addresses

2019-08-06 Thread Jon Maloy
> -Original Message- > From: Chris Packham > Sent: 4-Aug-19 19:05 > To: Jon Maloy ; tipc- > discuss...@lists.sourceforge.net > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: Slowness forming TIPC cluster with explicit node addresses > &g

RE: Slowness forming TIPC cluster with explicit node addresses

2019-08-04 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Chris Packham > Sent: 2-Aug-19 01:11 > To: Jon Maloy ; tipc- > discuss...@lists.sourceforge.net > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: Slowness forming TI

RE: Slowness forming TIPC cluster with explicit node addresses

2019-07-26 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Chris Packham > Sent: 25-Jul-19 19:37 > To: tipc-discuss...@lists.sourceforge.net > Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Slowness forming TIPC cluster with explicit node addresses > >

RE: [PATCH v2] tipc: ensure head->lock is initialised

2019-07-12 Thread Jon Maloy
Acked-by: Jon Maloy Actually, this was not what I meant, but it solves our problem in a simple and safe way, for now. Later, when net-next opens, I will revert this and do it the right way, which is to change from skb_queue_purge() to __skb_queue_purge as Eric correctly noted. That change has

RE: [PATCH] tipc: ensure skb->lock is initialised

2019-07-11 Thread Jon Maloy
> -Original Message- > From: Chris Packham > Sent: 10-Jul-19 16:58 > To: Jon Maloy ; Eric Dumazet > ; ying@windriver.com; > da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org > Subjec

RE: [PATCH] tipc: ensure skb->lock is initialised

2019-07-10 Thread Jon Maloy
> -Original Message- > From: Eric Dumazet > Sent: 10-Jul-19 04:00 > To: Jon Maloy ; Eric Dumazet > ; Chris Packham > ; ying@windriver.com; > da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kerne

RE: [PATCH] tipc: ensure skb->lock is initialised

2019-07-09 Thread Jon Maloy
> -Original Message- > From: Eric Dumazet > Sent: 9-Jul-19 09:46 > To: Jon Maloy ; Eric Dumazet > ; Chris Packham > ; ying@windriver.com; > da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kerne

RE: [PATCH] tipc: ensure skb->lock is initialised

2019-07-09 Thread Jon Maloy
> -Original Message- > From: Eric Dumazet > Sent: 9-Jul-19 03:31 > To: Chris Packham ; Eric Dumazet > ; Jon Maloy ; > ying@windriver.com; da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.o

RE: memory leak in tipc_buf_acquire

2019-06-10 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org On > Behalf Of Xin Long > Sent: 9-Jun-19 14:45 > To: syzbot > Cc: davem ; Jon Maloy ; > LKML ; network dev > ; syzkaller-bugs b...@googlegroups.com>; tipc-discuss...@lists.sourceforge.net; Ying Xue &g

RE: Userspace woes with 5.1.5 due to TIPC

2019-05-31 Thread Jon Maloy
> -Original Message- > From: Ying Xue > Sent: 30-May-19 20:41 > To: Mihai Moldovan ; Jon Maloy > ; linux-kernel@vger.kernel.org > Subject: Re: Userspace woes with 5.1.5 due to TIPC > > On 5/31/19 4:47 AM, Mihai Moldovan wrote: > > * On 5/30/19 9:51 PM, J

RE: Userspace woes with 5.1.5 due to TIPC

2019-05-30 Thread Jon Maloy
uot;Revert tipc: fix modprobe tipc failed after switch order of device registration" It was then replaced with this one: commit 526f5b851a96 "tipc: fix modprobe tipc failed after switch order of device registration" BR Jon Maloy > -Original Message- > From: Mihai Mold

RE: WARNING: locking bug in rhashtable_walk_enter

2019-05-22 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of syzbot > Sent: 21-May-19 17:08 > To: da...@davemloft.net; hujunw...@huawei.com; Jon Maloy > ; linux-kernel@vger.kernel.org; > net...@vger.kernel.org; syzkaller-b...@googlegroups

RE: [PATCH v4] tipc: fix modprobe tipc failed after switch order of device registration

2019-05-20 Thread Jon Maloy
Reviewed and tested. I found no problems with this. Reviewed-by: Jon Maloy > -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of David Miller > Sent: 20-May-19 13:46 > To: hujunw...@huawei.com > Cc: Jon Maloy ; ying@windriver.com; &g

RE: general protection fault in fib6_purge_rt

2019-03-20 Thread Jon Maloy
the source of the dump. Once again, a dump from 4.20/5.0 might be a help. ///jon > -Original Message- > From: syzbot > Sent: 18-Mar-19 08:28 > To: da...@davemloft.net; Jon Maloy ; > kuz...@ms2.inr.ac.ru; linux-kernel@vger.kernel.org; > net...@vger.kernel.org; syzkaller

RE: general protection fault in dst_dev_put (2)

2019-03-20 Thread Jon Maloy
ybe we are looking at two different problems here? ///jon > -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of syzbot > Sent: 19-Mar-19 18:24 > To: da...@davemloft.net; dsah...@gmail.com; Jon Maloy > ; linux-kernel@vger.kernel.org; > net...@vger.

RE: KMSAN: uninit-value in __inet6_bind

2018-12-14 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org > On Behalf Of Eric Dumazet > Sent: 14-Dec-18 10:15 > To: Jon Maloy ; Cong Wang > ; Dmitry Vyukov > Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Ying Xue > ; tipc-discuss...@lists.sourcef

RE: KMSAN: uninit-value in __inet6_bind

2018-12-14 Thread Jon Maloy
> -Original Message- > From: Cong Wang > Sent: 12-Dec-18 01:17 > To: Dmitry Vyukov > Cc: syzbot+c56449ed3652e6720...@syzkaller.appspotmail.com; Jon Maloy > ; Ying Xue ; tipc- > discuss...@lists.sourceforge.net; David Miller ; > Alexey Kuznetsov ; LKML ker...

RE: KASAN: use-after-free Read in tipc_group_cong

2018-12-13 Thread Jon Maloy
> -Original Message- > From: Dmitry Vyukov > Sent: 13-Dec-18 04:47 > To: Jon Maloy > Cc: syzbot+9845fed98688e01f4...@syzkaller.appspotmail.com; David Miller > ; LKML ; netdev > ; syzkaller-bugs b...@googlegroups.com>; tipc-discuss...@lists.sourceforge.net; Y

RE: general protection fault in __ip_append_data

2018-12-12 Thread Jon Maloy
> -Original Message- > From: Dmitry Vyukov > Sent: 12-Dec-18 06:03 > To: syzbot+aab62b9c7b12e7c6a...@syzkaller.appspotmail.com; Jon Maloy > ; Ying Xue ; David > Miller ; tipc-discuss...@lists.sourceforge.net > Cc: Alexey Kuznetsov ; LKML ker...@vger.kernel.org>;

RE: KASAN: use-after-free Read in tipc_group_cong

2018-12-12 Thread Jon Maloy
> -Original Message- > From: syzbot > Sent: 12-Dec-18 06:11 > To: da...@davemloft.net; Jon Maloy ; linux- > ker...@vger.kernel.org; net...@vger.kernel.org; syzkaller- > b...@googlegroups.com; tipc-discuss...@lists.sourceforge.net; > ying@windriver.com > S

RE: [PATCH net] tipc: eliminate possible recursive locking detected by LOCKDEP

2018-10-11 Thread Jon Maloy
Acked-by: Jon Maloy ///jon > -Original Message- > From: Ying Xue > Sent: October 11, 2018 7:58 AM > To: Jon Maloy ; dvyu...@google.com > Cc: da...@davemloft.net; parthasarathy.bhuvara...@ericsson.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.or

RE: net/tipc: recursive locking in tipc_link_reset

2018-10-11 Thread Jon Maloy
Hi Dmitry, Yes, we are aware of this, the kernel test robot warned us about this a few days ago. I am looking into it. ///jon > -Original Message- > From: Dmitry Vyukov > Sent: October 11, 2018 3:55 AM > To: parthasarathy.bhuvara...@ericsson.com; Jon Maloy > ; David Mi

RE: KMSAN: uninit-value in strcmp

2018-05-03 Thread Jon Maloy
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Thursday, May 03, 2018 15:22 > To: syzbot+df0257c92ffd4fcc5...@syzkaller.appspotmail.com > Cc: Jon Maloy ; linux-kernel@vger.kernel.org; > net...@vger.kernel.org; syzkaller-b...@goog

RE: [PATCH] tipc: fix a potential missing-check bug

2018-05-01 Thread Jon Maloy
> -Original Message- > From: Wenwen Wang [mailto:wang6...@umn.edu] > Sent: Tuesday, May 01, 2018 00:26 > To: Wenwen Wang > Cc: Kangjie Lu ; Jon Maloy ; Ying > Xue ; David S. Miller ; > open list:TIPC NETWORK LAYER ; open list:TIPC > NETWORK LAYER ; open list

RE: [PATCH v3] net: tipc: Replace GFP_ATOMIC with GFP_KERNEL in tipc_mon_create

2018-04-11 Thread Jon Maloy
> -Original Message- > From: Ying Xue [mailto:ying@windriver.com] > Sent: Wednesday, April 11, 2018 06:27 > To: Jia-Ju Bai ; Jon Maloy > ; da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org >

RE: general protection fault in tipc_nametbl_unsubscribe

2018-04-03 Thread Jon Maloy
#syz dup: general protection fault in __list_del_entry_valid (3) > -Original Message- > From: syzbot > [mailto:syzbot+4859fe19555ea87c4...@syzkaller.appspotmail.com] > Sent: Monday, April 02, 2018 02:01 > To: da...@davemloft.net; Jon Maloy ; linux- > ker...@vg

RE: [PATCH] tipc: avoid possible string overflow

2018-03-28 Thread Jon Maloy
> -Original Message- > From: Arnd Bergmann [mailto:a...@arndb.de] > Sent: Wednesday, March 28, 2018 10:02 > To: Jon Maloy ; Ying Xue > ; David S. Miller > Cc: Arnd Bergmann ; Parthasarathy Bhuvaragan > ; net...@vger.kernel.org; tipc- > discuss...@lists.sourc

RE: [RFC PATCH net-next] tipc: tipc_disc_addr_trial_msg() can be static

2018-03-24 Thread Jon Maloy
Acked-by: Jon Maloy jon.ma...@ericsson.com Thanks, Fengguang > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of kbuild test robot > Sent: Friday, March 23, 2018 15:48 > To: Jon Maloy > Cc: kbui

RE: BUG: sleeping function called from invalid context at net/core/sock.c:LINE (3)

2018-02-19 Thread Jon Maloy
com] > Sent: Saturday, February 17, 2018 23:23 > To: Dmitry Vyukov ; syzbot > ; Jon Maloy > ; Ying Xue > Cc: Andrei Vagin ; David Miller > ; Eric W. Biederman ; > Florian Westphal ; LKML ; > netdev ; Nicolas Dichtel > ; roman.k...@sysgo.com; syzkaller-

RE: KASAN: use-after-free Read in tipc_group_is_open

2018-01-16 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Cong Wang > Sent: Tuesday, January 16, 2018 13:56 > To: Jon Maloy > Cc: syzbot ; > David Miller ; LKML ker...@vger.kernel.org>; Linux Kernel Network

RE: KASAN: use-after-free Read in tipc_group_is_open

2018-01-16 Thread Jon Maloy
> -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Monday, January 15, 2018 23:44 > To: syzbot > Cc: David Miller ; Jon Maloy > ; LKML ; Linux > Kernel Network Developers ; syzkaller- > b...@googlegroups.com; tipc-discuss...@lists.s

RE: [PATCH 13/32] net/tipc: convert to ->poll_mask

2018-01-10 Thread Jon Maloy
Acked. ///jon > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Christoph Hellwig > Sent: Wednesday, January 10, 2018 10:59 > To: v...@zeniv.linux.org.uk > Cc: Avi Kivity ; linux-...@kvack.org; linux- > fsde...@vger.kernel.org;

RE: KASAN: use-after-free Read in tipc_group_size

2018-01-08 Thread Jon Maloy
> -Original Message- > From: Cong Wang [mailto:xiyou.wangc...@gmail.com] > Sent: Monday, January 08, 2018 13:44 > To: syzbot > Cc: David Miller ; Jon Maloy > ; LKML ; Linux > Kernel Network Developers ; syzkaller- > b...@googlegroups.com; tipc-discuss...@lists.s

RE: [PATCH 8/8] net: tipc: remove unused hardirq.h

2017-12-07 Thread Jon Maloy
ry...@vger.kernel.org; net...@vger.kernel.org; Jon Maloy > ; Ying Xue ; David S. > Miller > Subject: Re: [PATCH 8/8] net: tipc: remove unused hardirq.h > > Hi folks, > > Any comment on this one? If it compiles it is ok with me. Don't know why it was put there in

RE: [PATCH net v2] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-12-01 Thread Jon Maloy
, 2017 09:03 > To: Ying Xue ; Jon Maloy > ; David S. Miller ; > net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH net v2] tipc: call tipc_rcv() only if bearer is up in > tipc_udp_recv() > > On 01.12.2017 15

RE: [PATCH] tipc: call tipc_rcv() only if bearer is up in tipc_udp_recv()

2017-11-28 Thread Jon Maloy
Acked. ///jon > -Original Message- > From: Tommi Rantala [mailto:tommi.t.rant...@nokia.com] > Sent: Tuesday, November 28, 2017 07:53 > To: Jon Maloy ; Ying Xue > ; David S. Miller ; > net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...

RE: tipc_node_calculate_timer div-by-zero

2017-11-27 Thread Jon Maloy
ays. ///jon > -Original Message- > From: Tommi Rantala [mailto:tommi.t.rant...@nokia.com] > Sent: Monday, November 27, 2017 04:51 > To: Jon Maloy ; Ying Xue > ; David S. Miller ; > net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; open list > > Su

RE: tipc_udp_send_msg oops in 4.4 when setting link tolerance

2017-11-14 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Tommi Rantala > Sent: Tuesday, November 14, 2017 05:16 > To: Jon Maloy ; Ying Xue > ; David S. Miller ; > net...@vger.kernel.org; tipc-discuss...@lists.s

RE: tipc_udp_send_msg oops in 4.4 when setting link tolerance

2017-11-13 Thread Jon Maloy
@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Tommi Rantala > Sent: Monday, November 13, 2017 11:23 > To: Jon Maloy ; Ying Xue > ; David S. Miller ; > net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org > Subjec

syzbot:dup: general protection fault in __lock_acquire (2)

2017-11-05 Thread Jon Maloy
The problem was already known, but the solution is non-trivial, and needs some more review and testing before I can submit it. ///Jon Maloy > -Original Message- > From: syzbot > [mailto:bot+0cea668556ca5b811dc9725d82edbd87fea4defb@syzkaller.appsp > otmail.com] > Sent: S

RE: [PATCH v2] net: tipc: Convert timers to use timer_setup()

2017-10-31 Thread Jon Maloy
Acked. ///jon > -Original Message- > From: Kees Cook [mailto:keesc...@chromium.org] > Sent: Monday, October 30, 2017 22:07 > To: David S. Miller > Cc: Jon Maloy ; Ying Xue > ; net...@vger.kernel.org; tipc- > discuss...@lists.sourceforge.net; linux-kernel@vger

RE: [PATCH] net: tipc: Convert timers to use timer_setup()

2017-10-30 Thread Jon Maloy
> -Original Message- > From: keesc...@google.com [mailto:keesc...@google.com] On Behalf Of > Kees Cook > Sent: Friday, October 27, 2017 06:58 > To: Jon Maloy > Cc: David S. Miller ; Ying Xue > ; net...@vger.kernel.org; tipc- > discuss...@lists.sourc

RE: [PATCH] net: tipc: Convert timers to use timer_setup()

2017-10-24 Thread Jon Maloy
d S. Miller > Cc: Jon Maloy ; Ying Xue > ; net...@vger.kernel.org; tipc- > discuss...@lists.sourceforge.net; linux-kernel@vger.kernel.org > Subject: [PATCH] net: tipc: Convert timers to use timer_setup() > > In preparation for unconditionally passing the struct timer_list pointer to

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-18 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Joe Perches > Sent: Sunday, September 17, 2017 23:15 > To: Jon Maloy ; Thomas Meyer > > Cc: Ying Xue ; net...@vger.kernel.org; tipc- > discuss...@list

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-17 Thread Jon Maloy
> -Original Message- > From: Thomas Meyer [mailto:tho...@m3y3r.de] > Sent: Sunday, September 17, 2017 11:00 > To: Jon Maloy > Cc: Joe Perches ; Ying Xue ; > net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.kernel.org; da...@daveml

RE: [PATCH V2] tipc: Use bsearch library function

2017-09-16 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Joe Perches > Sent: Saturday, September 16, 2017 06:18 > To: Ying Xue ; Thomas Meyer > ; Jon Maloy ; > net...@vger.kernel.org; tipc-discuss...@lists.s

RE: [PATCH] net: tipc: Fix a sleep-in-atomic bug in tipc_msg_reverse

2017-06-10 Thread Jon Maloy
Acked. ///jon > -Original Message- > From: Jia-Ju Bai [mailto:baijiaju1...@163.com] > Sent: Saturday, June 10, 2017 05:04 > To: Jon Maloy ; Ying Xue > ; da...@davemloft.net > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge.net; linux- > ker...@vger.k

RE: [PATCH 1/1] tipc: check return value of nlmsg_new

2017-04-23 Thread Jon Maloy
Acknowledged. Thank you for doing this job. ///jon > -Original Message- > From: Pan Bian [mailto:bianpan2...@163.com] > Sent: Sunday, April 23, 2017 03:09 AM > To: Jon Maloy ; Ying Xue > ; David S. Miller > Cc: net...@vger.kernel.org; tipc-discuss...@lists.sourceforge

RE: [PATCH] tipc: fix NULL pointer dereference in shutdown()

2016-08-15 Thread Jon Maloy
Sorry, I just came back from vacation today. Acked-by: Jon Maloy > -Original Message- > From: Vegard Nossum [mailto:vegard.nos...@oracle.com] > Sent: Friday, 12 August, 2016 10:38 > To: Ying Xue ; Jon Maloy ; > David S. Miller > Cc: net...@vger.kernel.org; Michael

RE: [PATCH 27/31] net/tipc: use kmemdup rather than duplicating its implementation

2015-09-17 Thread Jon Maloy
Acked-by: Jon Maloy ///jon > -Original Message- > From: Andrzej Hajda [mailto:a.ha...@samsung.com] > Sent: Wednesday, 16 September, 2015 06:07 > To: Jon Maloy; Ying Xue > Cc: Bartlomiej Zolnierkiewicz; Marek Szyprowski; linux- > ker...@vger.kernel.org; Da

RE: [PATCH] net: tipc: fix stall during bclink wakeup procedure

2015-09-04 Thread Jon Maloy
Reviewed again, and finally understood. You are right; I just didn't understand the problem description correctly. Reviewed-by: Jon Maloy ///jon > -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Jon Maloy &g

RE: [PATCH] net: tipc: fix stall during bclink wakeup procedure

2015-09-03 Thread Jon Maloy
> -Original Message- > From: Kolmakov Dmitriy [mailto:kolmakov.dmit...@huawei.com] > Sent: Thursday, 03 September, 2015 10:39 > To: da...@davemloft.net > Cc: Jon Maloy; Ying Xue; tipc-discuss...@lists.sourceforge.net; > net...@vger.kernel.org; linux-kernel@vger.ke

RE: [PATCH] tipc: fix stall during bclink wakeup procedure

2015-09-03 Thread Jon Maloy
> -Original Message- > From: Kolmakov Dmitriy [mailto:kolmakov.dmit...@huawei.com] > Sent: Thursday, 03 September, 2015 04:31 > To: David Miller > Cc: Jon Maloy; Ying Xue; tipc-discuss...@lists.sourceforge.net; > net...@vger.kernel.org; linux-kernel@vger.kernel.org >

RE: ipv4: Use standard iovec primitive in raw_probe_proto_opt

2014-11-06 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Al Viro > Sent: November-06-14 8:11 AM > To: Herbert Xu > Cc: David Miller; net...@vger.kernel.org; linux-kernel@vger.kernel.org; > b...@kvack.org; Masahide Nakamura; Hideaki YO

RE: [PATCH 1/4] inet: Add skb_copy_datagram_iter

2014-11-06 Thread Jon Maloy
> -Original Message- > From: netdev-ow...@vger.kernel.org [mailto:netdev- > ow...@vger.kernel.org] On Behalf Of Al Viro > Sent: November-06-14 4:26 AM > To: David Miller > Cc: herb...@gondor.apana.org.au; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; b...@kvack.org > Subject: R

Re: [ 072/143] tipc: fix lockdep warning during bearer initialization

2014-05-12 Thread Jon Maloy
On 05/12/2014 01:12 PM, Willy Tarreau wrote: > On Mon, May 12, 2014 at 04:41:00PM +0000, Jon Maloy wrote: >> Sorry, I should have mentioned that it is still only in net-next. >> It is pretty recent. > > OK indeed, got it here for reference : > > > https://git.ke

RE: [ 072/143] tipc: fix lockdep warning during bearer initialization

2014-05-12 Thread Jon Maloy
Sorry, I should have mentioned that it is still only in net-next. It is pretty recent. ///jon > -Original Message- > From: Willy Tarreau [mailto:w...@1wt.eu] > Sent: May-12-14 12:16 PM > To: Jon Maloy > Cc: linux-kernel@vger.kernel.org; sta...@vger.kernel.org; Ying Xue; P

Re: [ 072/143] tipc: fix lockdep warning during bearer initialization

2014-05-12 Thread Jon Maloy
esn't occur at all when the > first TIPC bearer is enabled. Before enable_bearer() -- running on > CPU1 does not hold ptype_lock, so the TIPC receive handler (i.e. > recv_msg()) is not registered successfully via dev_add_pack(), so > the tipc_recv_msg() cannot be called by recv_msg()

Re: [tipc-discussion] [RFC: 2.6 patch] net/tipc/: possible cleanups

2007-01-25 Thread Jon Maloy
Adrian Bunk wrote: This patch contains the following possible cleanups: - make needlessly global functions static - #if 0 unused functions Thanks. I think most of those were due for our next release, anyway. But we'll get it in, one way or another. - remove all EXPORT_SYMBOL's My impress

Re: [PATCH] tipc: checking returns and Re: Possible Circular Locking in TIPC

2007-01-05 Thread Jon Maloy
Jarek Poplawski wrote: If you are sure there is no circular locking possible between these two functions and this entry->lock here isn't endangered by other functions, you could try to make lockdep "silent" like this: write_lock_bh(&ref_table_lock); if (tipc_ref_table.first_fr

Re: [PATCH] tipc: checking returns and Re: Possible Circular Locking in TIPC

2007-01-04 Thread Jon Maloy
Regards ///jon Jarek Poplawski wrote: I know lockdep is sometimes too careful but nevertheless some change is needed to fix a real bug or give additional information to lockdep. I don't know lockdep well enough yet, but I will try to find out if that is possible. Btw. there is a prob

Re: [PATCH] tipc: checking returns and Re: Possible Circular Locking in TIPC

2007-01-03 Thread Jon Maloy
See my comments below. Regards ///jon Jarek Poplawski wrote: .. Maybe I misinterpret this but, IMHO lockdep complains about locks acquired in different order: tipc_ref_acquire() gets ref_table_lock and then tipc_ret_table.entries[index]->lock, but tipc_deleteport() inversely (with: t