Re: [PATCH 1/1] block: move the PAGE_SECTORS definition into

2020-11-19 Thread John Dorminy
Greetings; There are a lot of uses of PAGE_SIZE/SECTOR_SIZE scattered around, and it seems like a medium improvement to be able to refer to it as PAGE_SECTORS everywhere instead of just inside dm, bcache, and null_blk. Did this change progress forward somewhere? Thanks! John Dorminy On Mon

Re: [PATCH 21/29] mm: remove the pgprot argument to __vmalloc

2020-04-30 Thread John Dorminy
iption to clarify so would be nice. Many thanks. John Dorminy

Re: block: be more careful about status in __bio_chain_endio

2019-02-22 Thread John Dorminy
I'm also worried about the other two versions, though: memory-barriers.txt#1724: 1724 (*) The compiler is within its rights to invent stores to a variable, i.e. the compiler is free to decide __bio_chain_endio looks like this: static struct bio *__bio_chain_endio(struct bio *bio) { struct bio

Re: block: be more careful about status in __bio_chain_endio

2019-02-22 Thread John Dorminy
I am perhaps not understanding the intricacies here, or not seeing a barrier protecting it, so forgive me if I'm off base. I think reading parent->bi_status here is unsafe. Consider the following sequence of events on two threads. Thread 0 Thread 1 In __bio_chain_en