[PATCH v2 10/10] selftests/sched_ext: Add test for sched_ext dl_server

2025-06-02 Thread Joel Fernandes
From: Andrea Righi Add a selftest to validate the correct behavior of the deadline server for the ext_sched_class. [ Joel: Replaced occurences of CFS in the test with EXT. ] Signed-off-by: Andrea Righi Signed-off-by: Joel Fernandes --- tools/testing/selftests/sched_ext/Makefile| 1

Re: [QUESTION] problems report: rcu_read_unlock_special() called in irq_exit() causes dead loop

2025-05-28 Thread Joel Fernandes
On Wed, May 21, 2025 at 5:43 AM Xiongfeng Wang wrote: > > Hi RCU experts, > > When I ran syskaller in Linux 6.6 with CONFIG_PREEMPT_RCU enabled, I got > the following soft lockup. The Calltrace is too long. I put it in the end. > The issue can also be reproduced in the latest kernel. > > The issue

RCU changes for v6.16

2025-05-19 Thread Joel Fernandes
test on rcu_seq_done_exact() rcu: Remove swake_up_one_online() bandaid Revert "rcu/nocb: Fix rcuog wake-up from offline softirq" I Hsin Cheng (1): rust: sync: rcu: Mark Guard methods as inline Joel Fernandes (7): MAINTAINERS: Update Joel's email address

Re: [PATCH] MAINTAINERS: Update Zqiang's email address

2025-05-16 Thread Joel Fernandes
On 5/16/2025 7:20 AM, Zqiang wrote: > This patch updates Zqiang's email address to qiang.zh...@linux.dev. > > Signed-off-by: Zqiang Acked-by: Joel Fernandes Will apply for 6.16. Thanks, - Joel > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 dele

Re: [PATCH] rcu/nocb: Fix possible invalid rdp's->nocb_cb_kthread pointer access

2025-05-09 Thread Joel Fernandes
On 5/7/2025 7:26 AM, Zqiang wrote: > In the preparation stage of CPU online, if the corresponding > the rdp's->nocb_cb_kthread does not exist, will be created, > there is a situation where the rdp's rcuop kthreads creation fails, > and then de-offload this CPU's rdp, does not assign this CPU's >

Re: [PATCH v2] rcu/nocb: Add Safe checks for access offloaded rdp

2025-05-09 Thread Joel Fernandes
On 5/9/2025 9:33 AM, Frederic Weisbecker wrote: > Le Thu, May 08, 2025 at 02:43:11PM +0800, Z qiang a écrit : >> On Thu, May 8, 2025 at 12:25 AM Frederic Weisbecker >> wrote: >>> On a second thought, isn't "rdp == this_cpu_ptr(&rcu_data)" enough? >> >> If the CONFIG_DEBUG_PREEMPT=y, the follow

Re: [PATCH] rcutorture: Fix rcutorture_one_extend_check() splat in RT kernels

2025-05-09 Thread Joel Fernandes
On 5/7/2025 5:04 PM, Paul E. McKenney wrote: > On Wed, May 07, 2025 at 07:26:03PM +0800, Zqiang wrote: >> For built with CONFIG_PREEMPT_RT=y kernels, running rcutorture >> tests resulted in the following splat: >> >> [ 68.797425] rcutorture_one_extend_check during change: Current 0x1 To >> a

Re: [PATCH] rcu/nocb: Fix possible invalid rdp's->nocb_cb_kthread pointer access

2025-05-09 Thread Joel Fernandes
On 5/9/2025 3:07 PM, Joel Fernandes wrote: > > > On 5/7/2025 7:26 AM, Zqiang wrote: >> In the preparation stage of CPU online, if the corresponding >> the rdp's->nocb_cb_kthread does not exist, will be created, >> there is a situation where the rdp's rcuop

Re: [PATCH 0/3] Make rcutorture safe(r) for arm64

2025-05-09 Thread Joel Fernandes
> TRACE01, and TRACE02 scenarios, preferably in a script. (But if you > want typing practice, don't let me stand in your way!) > > 1.Check for "Call trace:" as well as "Call Trace:". > > 2.Reduce TREE01 CPU overcommit. > > 3.Remove MAXSMP

Re: [PATCH 0/3] Make rcutorture safe(r) for arm64

2025-05-09 Thread Joel Fernandes
On 5/8/2025 7:42 PM, Paul E. McKenney wrote: > Hello! > > This series makes a few small updates to make rcutorture run better > on arm64 servers. Remaining issues include TREE07 .config issues > that are addressed by Mark Rutland's porting of PREEMPT_LAZY to arm64 > and by upcoming work to han

Re: [PATCH 0/5] Miscellaneous rcutorture updates

2025-05-09 Thread Joel Fernandes
On 5/8/2025 7:44 PM, Paul E. McKenney wrote: > Hello! > > This series provides miscellaneous rcutorture updates: > > 1.Suppress torture.sh "Zero time" messages for disabled tests. > > 2.Print number of RCU up/down readers and migrations. > > 3.Check for no up/down readers at task

Re: [PATCH 03/12] rcu: Move rcu_stall related sysctls into rcu/tree_stall.h

2025-05-09 Thread Joel Fernandes
This is part of a greater effort to move ctl tables into their > respective subsystems which will reduce the merge conflicts in > kernel/sysctl.c. > > Signed-off-by: Joel Granados For RCU: Reviewed-by: Joel Fernandes thanks, - Joel > --- > include/linux/panic.h |

Re: [PATCH v2] rcu/nocb: Add Safe checks for access offloaded rdp

2025-05-07 Thread Joel Fernandes
On 5/7/2025 12:31 PM, Frederic Weisbecker wrote: > Le Wed, May 07, 2025 at 12:06:29PM -0400, Joel Fernandes a écrit : >> >> >> On 5/7/2025 7:26 AM, Zqiang wrote: >>> For built with CONFIG_PROVE_RCU=y and CONFIG_PREEMPT_RT=y kernels, >>> Disable BH does no

Re: [PATCH v2] rcu/nocb: Add Safe checks for access offloaded rdp

2025-05-07 Thread Joel Fernandes
; corresponding cpu is online. > > This commit therefore add softirq_count() check for > Preempt-RT kernels. > > Suggested-by: Joel Fernandes > Signed-off-by: Zqiang > --- > kernel/rcu/tree_plugin.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH] rcu/nocb: Add Safe checks for access offloaded rdp

2025-05-06 Thread Joel Fernandes
> On May 6, 2025, at 2:26 AM, Z qiang wrote: > >  >> >> >> >> >>> On 4/30/2025 12:14 PM, Joel Fernandes wrote: >>> >>> >>> On 4/30/2025 10:57 AM, Z qiang wrote: >>>>> >>>>> >>

Re: [PATCH] rcu/nocb: Add Safe checks for access offloaded rdp

2025-05-05 Thread Joel Fernandes
On 4/30/2025 12:14 PM, Joel Fernandes wrote: > > > On 4/30/2025 10:57 AM, Z qiang wrote: >>> >>> >>> >>> On 4/28/2025 6:59 AM, Z qiang wrote: >>>>> >>>>> Le Mon, Apr 28, 2025 at 05:54:03PM +0800, Zqiang a

Re: [PATCH v2] rcu: Robustify rcu_is_cpu_rrupt_from_idle()

2025-05-02 Thread Joel Fernandes
On 4/29/2025 6:08 AM, Frederic Weisbecker wrote: > RCU relies on the context tracking nesting counter in order to determine > if it is running in extended quiescent state. > > However the context tracking nesting counter is not completely > synchronized with the actual context tracking state: >

Re: [PATCH 5/5] rcu/exp: Warn on CPU lagging for too long within hotplug IPI's blindspot

2025-05-02 Thread Joel Fernandes
On 5/1/2025 5:49 PM, Frederic Weisbecker wrote: > Le Wed, Apr 30, 2025 at 02:20:31AM +0000, Joel Fernandes a écrit : >> >> >>> On Apr 29, 2025, at 9:44 AM, Frederic Weisbecker >>> wrote: >> >> Hi Frederic, >> These all look good to me. Do

Re: [PATCH] rcu/nocb: Add Safe checks for access offloaded rdp

2025-04-30 Thread Joel Fernandes
On 4/30/2025 10:57 AM, Z qiang wrote: >> >> >> >> On 4/28/2025 6:59 AM, Z qiang wrote: Le Mon, Apr 28, 2025 at 05:54:03PM +0800, Zqiang a écrit : > For Preempt-RT kernel, when enable CONFIG_PROVE_RCU Kconfig, > disable local bh in rcuc kthreads will not affect preempt_count(),

Re: [PATCH 5/5] rcu/exp: Warn on CPU lagging for too long within hotplug IPI's blindspot

2025-04-29 Thread Joel Fernandes
> On Apr 29, 2025, at 9:44 AM, Frederic Weisbecker wrote: Hi Frederic, These all look good to me. Do you wish for these to go into the upcoming merge window or can I push them to a for-Neeraj branch as he is doing the merge window after the next? Thanks, - Joel > > A CPU within hotplug o

Re: [PATCH] rcu/nocb: Add Safe checks for access offloaded rdp

2025-04-28 Thread Joel Fernandes
On 4/28/2025 6:59 AM, Z qiang wrote: >> >> Le Mon, Apr 28, 2025 at 05:54:03PM +0800, Zqiang a écrit : >>> For Preempt-RT kernel, when enable CONFIG_PROVE_RCU Kconfig, >>> disable local bh in rcuc kthreads will not affect preempt_count(), >>> this resulted in the following splat: >>> >>> WARNING:

Re: [PATCH] tools/memory-model/Documentation: Fix SRCU section in explanation.txt

2025-04-22 Thread Joel Fernandes
On 4/22/2025 6:55 PM, Joel Fernandes wrote: > > > On 4/22/2025 1:56 PM, Paul E. McKenney wrote: >> On Tue, Apr 22, 2025 at 07:38:30PM +0200, Uladzislau Rezki (Sony) wrote: >>> The SRCU read-side critical sections describes the difference between >>> sr

Re: [PATCH] tools/memory-model/Documentation: Fix SRCU section in explanation.txt

2025-04-22 Thread Joel Fernandes
On 4/22/2025 1:56 PM, Paul E. McKenney wrote: > On Tue, Apr 22, 2025 at 07:38:30PM +0200, Uladzislau Rezki (Sony) wrote: >> The SRCU read-side critical sections describes the difference between >> srcu_down_read()/srcu_up_read() and srcu_read_lock()/srcu_read_unlock() >> in a way that a last pai

Re: [v3,1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-19 Thread Joel Fernandes
Hello, Paul, On April 20, 2025, 12:21 a.m. UTC Paul E. McKenney wrote: > On Wed, Apr 16, 2025 at 11:19:22AM +0000, Joel Fernandes wrote: > > > > > > > On Apr 15, 2025, at 8:19 PM, Paul E. McKenney wrote: > > > > > > On Mon, Apr 14, 2025 at 11:05:45A

Re: [12/14] torture: Add testing of RCU's Rust bindings to torture.sh

2025-04-19 Thread Joel Fernandes
Hi Paul, On 4/18/2025 6:45 PM, Paul E. McKenney wrote: > Suppose we fired up a guest OS and captured the console output. Is there > a way to make that guest OS shut down automatically at the end of the > test and to extract the test results? Ah, sorry, I thought you were already

Re: [12/14] torture: Add testing of RCU's Rust bindings to torture.sh

2025-04-18 Thread Joel Fernandes
Hello, Paul, On Fri, 18 Apr 2025 22:26:17 GMT, "Paul E. McKenney" wrote: > On Fri, Apr 18, 2025 at 08:32:46PM +0200, Miguel Ojeda wrote: > > On Fri, Apr 18, 2025 at 8:04 PM Paul E. McKenney wrot > e: > > > > > > Suppose we fired up a guest OS and captured the console output. Is ther > e > > > a

Re: [12/14] torture: Add testing of RCU's Rust bindings to torture.sh

2025-04-18 Thread Joel Fernandes
Hello, Paul, On Fri, 18 Apr 2025 22:26:17 GMT, "Paul E. McKenney" wrote: > On Fri, Apr 18, 2025 at 08:32:46PM +0200, Miguel Ojeda wrote: > > On Fri, Apr 18, 2025 at 8:04 PM Paul E. McKenney wrot > e: > > > > > > Suppose we fired up a guest OS and captured the console output. Is ther > e > > > a

Re: [PATCH 09/14] rcutorture: Check for ->up_read() without matching ->down_read()

2025-04-18 Thread Joel Fernandes
On 4/18/2025 12:09 PM, Joel Fernandes wrote: > From: "Paul E. McKenney" > > This commit creates counters in the rcu_torture_one_read_state_updown > structure that check for a call to ->up_read() that lacks a matching > call to ->down_read(). > > While in

Re: [PATCH 00/14] RCU torture changes for v6.16

2025-04-18 Thread Joel Fernandes
On 4/18/2025 12:09 PM, Joel Fernandes wrote: > Hi, > > Please find the upcoming miscellaneous RCU changes. The changes can also FYI: Sorry, s/miscellaneous/torture-related/ here. Also please ignore patches with "XX/12" in their subject, that was an error on my part. The

[PATCH 2/4] rcu: Add warning to ensure rcu_seq_done_exact() is working

2025-04-18 Thread Joel Fernandes
The previous patch improved the rcu_seq_done_exact() function by adding a meaningful constant for the guardband. Ensure that this is working for the future by a quick check during rcu_gp_init(). Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 6 ++ 1

[PATCH 0/4] Sequence counter related RCU changes for v6.16

2025-04-18 Thread Joel Fernandes
() Joel Fernandes (3): rcu: Replace magic number with meaningful constant in rcu_seq_done_exact() rcu: Add warning to ensure rcu_seq_done_exact() is working srcu: Use rcu_seq_done_exact() for polling API kernel/rcu/rcu.h | 14 +- kernel/rcu/srcutree.c | 2 +- kernel/rcu

[PATCH 4/4] srcu: Use rcu_seq_done_exact() for polling API

2025-04-18 Thread Joel Fernandes
dhyay Reviewed-by: Paul E. McKenney Reviewed-by: Kent Overstreet Cc: Kent Overstreet Signed-off-by: Joel Fernandes --- kernel/rcu/srcutree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c index 9a59b071501b..48047260697e 100644 --- a/k

[PATCH 3/4] rcu: Comment on the extraneous delta test on rcu_seq_done_exact()

2025-04-18 Thread Joel Fernandes
he example scenario describe above which a warning added in an earlier patch does. [ Comment wordsmithing by Joel ] Signed-off-by: Frederic Weisbecker Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcu.h | 9 + 1 file changed, 9 insertions(+) diff --git a/k

[PATCH 1/4] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-04-18 Thread Joel Fernandes
making the intent clearer as well. Suggested-by: Frederic Weisbecker Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcu.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcu.h b/kernel/rcu/rcu.h index eed2951a4962..5e1ee570bb27 100

[PATCH 5/7] Revert "rcu/nocb: Fix rcuog wake-up from offline softirq"

2025-04-18 Thread Joel Fernandes
/20241231170712.149394-4-frede...@kernel.org/ Reviewed-by: Usama Arif Reviewed-by: Joel Fernandes Signed-off-by: Frederic Weisbecker Signed-off-by: Joel Fernandes --- kernel/rcu/tree_nocb.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/kernel/rcu/tree_nocb.h b/kernel

[PATCH 4/7] rust: sync: rcu: Mark Guard methods as inline

2025-04-18 Thread Joel Fernandes
pfx__kernel::sync::rcu::Guard::new 16 - -16 Total: Before=23365955, After=23365823, chg -0.00% Link: https://github.com/Rust-for-Linux/linux/issues/1145 Signed-off-by: I Hsin Cheng Reviewed-by: Joel Fernandes Reviewed-by: Benno Lossin Reviewed-by: Charalampos Mitrodimas Acked-by

[PATCH 2/7] rcu: Remove swake_up_one_online() bandaid

2025-04-18 Thread Joel Fernandes
frede...@kernel.org/ Reviewed-by: Usama Arif Reviewed-by: Joel Fernandes Signed-off-by: Frederic Weisbecker Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 34 +- kernel/rcu/tree_exp.h | 2 +- kernel/rcu/tree_nocb.h | 2 +- 3 files changed, 3 insertions(+

[PATCH 3/7] rcu/cpu_stall_cputime: fix the hardirq count for x86 architecture

2025-04-18 Thread Joel Fernandes
1090842.sfi6qpgs-...@intel.com/ Signed-off-by: Yongliang Gao Reviewed-by: Neeraj Upadhyay Link: https://lore.kernel.org/r/20250216084109.3109837-1-leonyl...@gmail.com Signed-off-by: Boqun Feng Signed-off-by: Joel Fernandes --- kernel/rcu/tree.c | 10 +++--- kernel/rcu/tree.h |

[PATCH 0/7] Miscellaneous RCU changes for v6.16

2025-04-18 Thread Joel Fernandes
ke-up from offline softirq" I Hsin Cheng (1): rust: sync: rcu: Mark Guard methods as inline Joel Fernandes (1): MAINTAINERS: Update Joel's email address Paul E. McKenney (1): doc: Update LWN RCU API links in whatisRCU.rst Wei Yang (1): doc/RCU/listRCU: refine example code for el

[PATCH 1/7] MAINTAINERS: Update Joel's email address

2025-04-18 Thread Joel Fernandes
Update MAINTAINERS file to reflect changes to Joel's email address for upstream work. Reviewed-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- MAINTAINERS | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 96b827049501..8eb7e05

[PATCH 12/12] torture: Add testing of RCU's Rust bindings to torture.sh

2025-04-18 Thread Joel Fernandes
rproper parameter to torture.sh to make the user explicitly ask for it? Co-developed-by: Boqun Feng Signed-off-by: Boqun Feng Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../selftests/rcutorture/bin/torture.sh | 45 +++ 1 file changed, 45 insertions(+)

[PATCH 09/12] rcutorture: Check for ->up_read() without matching ->down_read()

2025-04-18 Thread Joel Fernandes
t robot feedback. ] Signed-off-by: Paul E. McKenney Tested-by: kernel test robot Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index d2728e95a69b..079

[PATCH 11/12] torture: Add --do-{,no-}normal to torture.sh

2025-04-18 Thread Joel Fernandes
ly KCSAN runs. Note that specifying "--do-no-kasan --do-no-kcsan --do-no-normal" gets normal runs, so you should not try to use this as a synonym for --do-none. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../selftests/rcutorture/bin/torture.sh | 30 +

[PATCH 07/12] rcutorture: Comment invocations of tick_dep_set_task()

2025-04-18 Thread Joel Fernandes
und kernel execution. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 7eccc74e60a7..ea40f3ad32dc 100644 --- a/kernel/rcu/rcutortur

[PATCH 10/12] checkpatch: Deprecate srcu_read_lock_lite() and srcu_read_unlock_lite()

2025-04-18 Thread Joel Fernandes
months ago. Therefore, mark them deprecated. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- scripts/checkpatch.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7b28ad331742..de8ed5efc5b1 100755 --- a/scripts/checkpatc

[PATCH 04/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-18 Thread Joel Fernandes
ing of RCU callbacks. If it turns out to be possible to make kernels built with CONFIG_PREEMPT_RT=y to tolerate testing of both, both will be enabled. [ paulmck: Apply Sebastian Siewior feedback. ] Signed-off-by: Paul E. McKenney Cc: Sebastian Andrzej Siewior Signed-off-by: Joel Fernandes --- too

[PATCH 08/12] rcutorture: Complain if an ->up_read() is delayed more than 10 seconds

2025-04-18 Thread Joel Fernandes
is delayed for more than ten seconds. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index ea40f3ad32dc..d2728e95a69b 100644 --

[PATCH 03/12] rcutorture: Split out beginning and end from rcu_torture_one_read()

2025-04-18 Thread Joel Fernandes
ad() while still using the same validation code. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 124 ++-- 1 file changed, 81 insertions(+), 43 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutortu

[PATCH 05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-18 Thread Joel Fernandes
an per-reader array looking for elements whose readers have ended. This kthread sleeps between one and two milliseconds between consecutive scans. [ paulmck: Apply kernel test robot feedback. ] [ paulmck: Apply Z qiang feedback. ] Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernan

[PATCH 06/12] rcutorture: Pull rcu_torture_updown() loop body into new function

2025-04-18 Thread Joel Fernandes
re test and the current structure being in use remain in the rcu_torture_updown() function. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 46 ++--- 1 file changed, 25 insertions(+), 21 deletions(-) diff --g

[PATCH 01/12] rcutorture: Make srcu_lockdep.sh check kernel Kconfig

2025-04-18 Thread Joel Fernandes
t verifies that the .config file has lockdep enabled. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../testing/selftests/rcutorture/bin/srcu_lockdep.sh | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/rcut

[PATCH 02/12] rcutorture: Make srcu_lockdep.sh check reader-conflict handling

2025-04-18 Thread Joel Fernandes
therefore adds such tests to srcu_lockdep.sh. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../selftests/rcutorture/bin/srcu_lockdep.sh | 31 +++ 1 file changed, 31 insertions(+) diff --git a/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh b/too

[PATCH 13/14] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-18 Thread Joel Fernandes
hen for 5 minutes, we switch to a smaller delta causing 1-2 wraps in 5 minutes. I believe this is reasonable since we at least add a little bit of testing for usecases where ->gpwrap is set. Tested-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcu.h| 4

[PATCH 14/14] rcutorture: Fix issue with re-using old images on ARM64

2025-04-18 Thread Joel Fernandes
by: Paul E. McKenney Signed-off-by: Joel Fernandes --- tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh b/tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh index ad

[PATCH 12/14] torture: Add testing of RCU's Rust bindings to torture.sh

2025-04-18 Thread Joel Fernandes
rproper parameter to torture.sh to make the user explicitly ask for it? Co-developed-by: Boqun Feng Signed-off-by: Boqun Feng Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../selftests/rcutorture/bin/torture.sh | 45 +++ 1 file changed, 45 insertions(+)

[PATCH 10/14] checkpatch: Deprecate srcu_read_lock_lite() and srcu_read_unlock_lite()

2025-04-18 Thread Joel Fernandes
months ago. Therefore, mark them deprecated. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- scripts/checkpatch.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3d22bf863eec..b3b1939ccd19 100755 --- a/scripts/checkpatc

[PATCH 11/14] torture: Add --do-{,no-}normal to torture.sh

2025-04-18 Thread Joel Fernandes
ly KCSAN runs. Note that specifying "--do-no-kasan --do-no-kcsan --do-no-normal" gets normal runs, so you should not try to use this as a synonym for --do-none. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../selftests/rcutorture/bin/torture.sh | 30 +

[PATCH 09/14] rcutorture: Check for ->up_read() without matching ->down_read()

2025-04-18 Thread Joel Fernandes
t robot feedback. ] Signed-off-by: Paul E. McKenney Tested-by: kernel test robot Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 0b998609c7dc..402

[PATCH 07/14] rcutorture: Comment invocations of tick_dep_set_task()

2025-04-18 Thread Joel Fernandes
und kernel execution. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index daa55ff05570..25010666576b 100644 --- a/kernel/rcu/rcutortur

[PATCH 08/14] rcutorture: Complain if an ->up_read() is delayed more than 10 seconds

2025-04-18 Thread Joel Fernandes
is delayed for more than ten seconds. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c index 25010666576b..0b998609c7dc 100644 --

[PATCH 05/14] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-18 Thread Joel Fernandes
tup. ] [ joel: Apply Boqun bug fix to drop extra up_read() call in rcu_torture_updown()]. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 225 1 file changed, 206 insertions(+), 19 deletions(-) dif

[PATCH 06/14] rcutorture: Pull rcu_torture_updown() loop body into new function

2025-04-18 Thread Joel Fernandes
re test and the current structure being in use remain in the rcu_torture_updown() function. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 44 ++--- 1 file changed, 24 insertions(+), 20 deletions(-) diff --g

[PATCH 03/14] rcutorture: Split out beginning and end from rcu_torture_one_read()

2025-04-18 Thread Joel Fernandes
ad() while still using the same validation code. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 124 ++-- 1 file changed, 81 insertions(+), 43 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutortu

[PATCH 04/14] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-18 Thread Joel Fernandes
ing of RCU callbacks. If it turns out to be possible to make kernels built with CONFIG_PREEMPT_RT=y to tolerate testing of both, both will be enabled. [ paulmck: Apply Sebastian Siewior feedback. ] Signed-off-by: Paul E. McKenney Cc: Sebastian Andrzej Siewior Signed-off-by: Joel Fernandes --- too

[PATCH 02/14] rcutorture: Make srcu_lockdep.sh check reader-conflict handling

2025-04-18 Thread Joel Fernandes
therefore adds such tests to srcu_lockdep.sh. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../selftests/rcutorture/bin/srcu_lockdep.sh | 31 +++ 1 file changed, 31 insertions(+) diff --git a/tools/testing/selftests/rcutorture/bin/srcu_lockdep.sh b/too

[PATCH 01/14] rcutorture: Make srcu_lockdep.sh check kernel Kconfig

2025-04-18 Thread Joel Fernandes
t verifies that the .config file has lockdep enabled. Signed-off-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- .../testing/selftests/rcutorture/bin/srcu_lockdep.sh | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/rcut

[PATCH 00/14] RCU torture changes for v6.16

2025-04-18 Thread Joel Fernandes
Hi, Please find the upcoming miscellaneous RCU changes. The changes can also be found at: git://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git torture.2025.04.18a Thanks. Joel Fernandes (2): rcutorture: Perform more frequent testing of ->gpwrap rcutorture: Fix issue w

Re: [PATCH v3 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-16 Thread Joel Fernandes
> On Apr 15, 2025, at 8:19 PM, Paul E. McKenney wrote: > > On Mon, Apr 14, 2025 at 11:05:45AM -0400, Joel Fernandes wrote: >> On 4/10/2025 2:29 PM, Paul E. McKenney wrote: >>>> +static int rcu_gpwrap_lag_init(void) >>>> +{ >>>> +if (g

Re: [PATCH v2 05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-15 Thread Joel Fernandes
On 3/31/2025 5:03 PM, Paul E. McKenney wrote: > This commit adds a new rcutorture.n_up_down kernel boot parameter > that specifies the number of outstanding SRCU up/down readers, which > begin in kthread context and end in an hrtimer handler. There is a new > kthread ("rcu_torture_updown") that

[PATCH v4 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-15 Thread Joel Fernandes
hen for 5 minutes, we switch to a smaller delta causing 1-2 wraps in 5 minutes. I believe this is reasonable since we at least add a little bit of testing for usecases where ->gpwrap is set. Tested-by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcu.h| 4

Re: [PATCH v4 2/2] rcutorture: Fix issue with re-using old images on ARM64

2025-04-15 Thread Joel Fernandes
On 4/15/2025 9:36 AM, Joel Fernandes wrote: > On ARM64, when running with --configs '36*SRCU-P', I noticed that only 1 > instance > instead of 36 for starting. > > Fix it by checking for Image files, instead of bzImage which ARM does > not seem to have. With

[PATCH v4 2/2] rcutorture: Fix issue with re-using old images on ARM64

2025-04-15 Thread Joel Fernandes
by: Paul E. McKenney Signed-off-by: Joel Fernandes --- kernel/rcu/rcutorture.c | 3 ++- tools/testing/selftests/rcutorture/bin/kvm-test-1-run.sh | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutortu

Re: [PATCH v3 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-14 Thread Joel Fernandes
On 4/10/2025 2:29 PM, Paul E. McKenney wrote: >> +static int rcu_gpwrap_lag_init(void) >> +{ >> +if (gpwrap_lag_cycle_mins <= 0 || gpwrap_lag_active_mins <= 0) { >> +pr_alert("rcu-torture: lag timing parameters must be >> positive\n"); >> +return -EINVAL; > When rcutort

Re: [v3,1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-14 Thread Joel Fernandes
On 4/14/2025 10:24 AM, Paul E. McKenney wrote: > On Mon, Apr 14, 2025 at 08:07:24AM -0400, Joel Fernandes wrote: >> >> >>> On Apr 11, 2025, at 3:18 PM, Paul E. McKenney wrote: >>> >>> On Fri, Apr 11, 2025 at 05:36:32AM -, Joel Fernandes wrote: &

Re: [v3,1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-14 Thread Joel Fernandes
> On Apr 11, 2025, at 3:18 PM, Paul E. McKenney wrote: > > On Fri, Apr 11, 2025 at 05:36:32AM -0000, Joel Fernandes wrote: >> Hello, Paul, >> >>> On Fri, 11 Apr 2025 05:33:16 GMT, "Paul E. McKenney" wrote: >>> On Thu, Apr 10, 2025 at 11:5

Re: [v3,1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Hello, Paul, On Fri, 11 Apr 2025 05:33:16 GMT, "Paul E. McKenney" wrote: > On Thu, Apr 10, 2025 at 11:54:13AM -0700, Paul E. McKenney wrote: > > On Thu, Apr 10, 2025 at 11:29:03AM -0700, Paul E. McKenney wrote: > > > On Thu, Apr 10, 2025 at 11:03:27AM

Re: [v3,1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Hello, Paul, On Fri, 11 Apr 2025 05:33:16 GMT, "Paul E. McKenney" wrote: > On Thu, Apr 10, 2025 at 11:54:13AM -0700, Paul E. McKenney wrote: > > On Thu, Apr 10, 2025 at 11:29:03AM -0700, Paul E. McKenney wrote: > > > On Thu, Apr 10, 2025 at 11:03:27AM

[PATCH v3 1/2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
hen for 5 minutes, we switch to a smaller delta causing 1-2 wraps in 5 minutes. I believe this is reasonable since we at least add a little bit of testing for usecases where ->gpwrap is set. Signed-off-by: Joel Fernandes --- kernel/rcu/rcu.h| 4

Re: rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Hello, Paul, On Thu, 10 Apr 2025 13:35:35 GMT, "Paul E. McKenney" wrote: [...] > > > > kernel/rcu/rcu.h| 4 +++ > > > > kernel/rcu/rcutorture.c | 64 > > > > kernel/rcu/tree.c | 34 -- > > > > kernel/rcu/tree.h | 1

[PATCH v3 2/2] rcutorture: Fix issue with re-using old images on ARM64

2025-04-10 Thread Joel Fernandes
On ARM64, when running with --configs '36*SRCU-P', I noticed that only 1 instance instead of 36 for starting. Fix it by checking for Image files, instead of bzImage which ARM does not seem to have. With this I see all 36 instances running at the same time in the batch. Signed-of

Re: [PATCH v2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
On 4/10/2025 9:54 AM, Joel Fernandes wrote: > Currently, the ->gpwrap is not tested (at all per my testing) due to the > requirement of a large delta between a CPU's rdp->gp_seq and its node's > rnp->gpseq. > > This results in no testing of ->gpwrap bein

[PATCH v2] rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
hen for 5 minutes, we switch to a smaller delta causing 1-2 wraps in 5 minutes. I believe this is reasonable since we at least add a little bit of testing for usecases where ->gpwrap is set. Signed-off-by: Joel Fernandes --- kernel/rcu/rcu.h| 4

Re: rcutorture: Perform more frequent testing of ->gpwrap

2025-04-10 Thread Joel Fernandes
Hello, Paul, On Thu, 10 Apr 2025 13:35:35 GMT, "Paul E. McKenney" wrote: [...] > > > > kernel/rcu/rcu.h| 4 +++ > > > > kernel/rcu/rcutorture.c | 64 > > > > kernel/rcu/tree.c | 34 -- > > > > kernel/rcu/tree.h | 1

Re: [v2,05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-08 Thread Joel Fernandes
Hello, Paul, On Tue, 8 Apr 2025 20:16:08 GMT, "Paul E. McKenney" wrote: > This commit adds a new rcutorture.n_up_down kernel boot parameter > that specifies the number of outstanding SRCU up/down readers, which > begin in kthread context and end in an hrtimer handler. There is a new > kthread ("r

Re: [v2,05/12] rcutorture: Add tests for SRCU up/down reader primitives

2025-04-08 Thread Joel Fernandes
On 4/8/2025 4:58 PM, Paul E. McKenney wrote: > On Tue, Apr 08, 2025 at 08:18:05PM -0000, Joel Fernandes wrote: >> Hello, Paul, >> >> On Tue, 8 Apr 2025 20:16:08 GMT, "Paul E. McKenney" wrote: >>> This commit adds a new rcutorture.n_up_down kernel boot pa

Re: [v3,4/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-08 Thread Joel Fernandes
Hello, Paul, On Tue, 8 Apr 2025 14:23:32 GMT, "Paul E. McKenney" wrote: > The torture.sh --do-rt command-line parameter is intended to mimic -rt > kernels. Now that CONFIG_PREEMPT_RT is upstream, this commit makes this > mimicking more precise. > > Note that testing of RCU priority boosting is d

Re: [v2,04/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-05 Thread Joel Fernandes
> On Apr 5, 2025, at 1:10 PM, Paul E. McKenney wrote: > > On Sat, Apr 05, 2025 at 07:01:13AM -0400, Joel Fernandes wrote: >> >> >>> On 4/2/2025 3:17 PM, Paul E. McKenney wrote: >>> On Wed, Apr 02, 2025 at 12:19:13PM -0400, Joel Fernandes wrote: >&

Re: rcutorture: Perform more frequent testing of ->gpwrap

2025-04-05 Thread Joel Fernandes
> On Apr 5, 2025, at 1:23 PM, Paul E. McKenney wrote: > > On Sat, Apr 05, 2025 at 12:30:58PM -0000, Joel Fernandes wrote: >> Hello, Paul, >> >>> On Sat, 5 Apr 2025 12:26:12 GMT, "Paul E. McKenney" wrote: >>> On Sat, Mar 29, 2025 at 07:01:42PM

Re: [PATCH v2 0/12]

2025-04-05 Thread Joel Fernandes
Hello Paul, On 3/31/2025 5:02 PM, Paul E. McKenney wrote: > Hello! > > The following series improves testing of SRCU-fast and SRCU up/down, > deprecates SRCU-lite, enables torture.sh to skip non-debug testing, > and adds testing for Rust's RCU bindings. The Rust RCU patch is very > much in RFC s

Re: [PATCH 3/3] rcu: Comment on the extraneous delta test on rcu_seq_done_exact()

2025-04-05 Thread Joel Fernandes
> On Mar 26, 2025, at 6:37 PM, Paul E. McKenney wrote: > > On Mon, Mar 24, 2025 at 01:01:55PM -0400, Joel Fernandes wrote: >> From: Frederic Weisbecker >> >> The numbers used in rcu_seq_done_exact() lack some explanation behind >> their m

Re: rcutorture: Perform more frequent testing of ->gpwrap

2025-04-05 Thread Joel Fernandes
Hello, Paul, On Sat, 5 Apr 2025 12:26:12 GMT, "Paul E. McKenney" wrote: > On Sat, Mar 29, 2025 at 07:01:42PM -0400, Joel Fernandes wrote: > > Currently, the ->gpwrap is not tested (at all per my testing) due to the > > requirement of a large delta between a CPU&

Re: [1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact() - Patchwork

2025-04-05 Thread Joel Fernandes
Hi Frederic, On 4/2/2025 10:22 AM, Frederic Weisbecker wrote: >> On Tue, 1 Apr 2025 16:27:36 GMT, Frederic Weisbecker wrote: >>> Le Mon, Mar 31, 2025 at 02:29:52PM -0700, Paul E. McKenney a écrit : The disagreement is a feature, at least up to a point. That feature allows CPUs to go id

Re: [v2,04/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-05 Thread Joel Fernandes
On 4/2/2025 3:17 PM, Paul E. McKenney wrote: > On Wed, Apr 02, 2025 at 12:19:13PM -0400, Joel Fernandes wrote: >> Hello, >> >> On Wed, 2 Apr 2025 16:17:06 GMT, Sebastian Andrzej Siewior wrote: >>> On 2025-03-31 14:03:06 [-0700], Paul E. McKenney wrote: >>&g

Re: [v2,04/12] rcutorture: Make torture.sh --do-rt use CONFIG_PREEMPT_RT

2025-04-02 Thread Joel Fernandes
Hello, On Wed, 2 Apr 2025 16:17:06 GMT, Sebastian Andrzej Siewior wrote: > On 2025-03-31 14:03:06 [-0700], Paul E. McKenney wrote: > > The torture.sh --do-rt command-line parameter is intended to mimic -rt > > kernels. Now that CONFIG_PREEMPT_RT is upstream, this commit makes this > > mimicking m

Re: [1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact() - Patchwork

2025-04-01 Thread Joel Fernandes
Hello, Frederic, On Tue, 1 Apr 2025 16:27:36 GMT, Frederic Weisbecker wrote: > Le Mon, Mar 31, 2025 at 02:29:52PM -0700, Paul E. McKenney a écrit : > > The disagreement is a feature, at least up to a point. That feature > > allows CPUs to go idle for long periods without RCU having to bother > >

[PATCH] rcutorture: Perform more frequent testing of ->gpwrap

2025-03-29 Thread Joel Fernandes
hen for 5 minutes, we switch to a smaller delta causing 1-2 wraps in 5 minutes. I believe this is reasonable since we at least add a little bit of testing for usecases where ->gpwrap is set. Signed-off-by: Joel Fernandes --- kernel/rcu/rcu.h| 4

Re: [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-03-27 Thread Joel Fernandes
On 3/27/2025 1:09 PM, Paul E. McKenney wrote: >>> In contrast, making the guard band a bit longer than it needs to be >>> has little or no downside. >> Making it 3 GP instead of 2 should be ok with me as long as we document it >> but at least it will not be a magic number based on an equation.

Re: [PATCH 5/9] rcutorture: Add tests for SRCU up/down reader primitives

2025-03-27 Thread Joel Fernandes
> On Mar 27, 2025, at 12:48 PM, Paul E. McKenney wrote: > > On Thu, Mar 27, 2025 at 12:22:12PM -0400, Joel Fernandes wrote: >> Paul, >> >>>> If rtorsu_hrt timer is still in timer_queue, invoke hrtimer_cancel() will >>>> remove i

Re: [PATCH 5/9] rcutorture: Add tests for SRCU up/down reader primitives

2025-03-27 Thread Joel Fernandes
Paul, >> If rtorsu_hrt timer is still in timer_queue, invoke hrtimer_cancel() will >> remove it from timerqueue and directly return, so the >> rcu_torture_updown_hrt() >> will not be executed and the rtorsup->rtorsu_inuse cannot be set false. >> >> How about modifying it as follows: >> >> diff --

Re: [PATCH 1/3] rcu: Replace magic number with meaningful constant in rcu_seq_done_exact()

2025-03-26 Thread Joel Fernandes
> On Mar 26, 2025, at 6:33 PM, Paul E. McKenney wrote: > > On Mon, Mar 24, 2025 at 01:01:53PM -0400, Joel Fernandes wrote: >> The rcu_seq_done_exact() function checks if a grace period has completed by >> comparing sequence numbers. It includes a guard band to handl

  1   2   3   4   5   6   7   8   9   10   >