Re: [PATCH RFC V9 0/19] Paravirtualized ticket spinlocks

2013-06-07 Thread Jiannan Ouyang
gt;>> >>> On 06/02/2013 09:50 PM, Jiannan Ouyang wrote: >>>> >>>> On Sun, Jun 2, 2013 at 1:07 AM, Gleb Natapov wrote: >>>> >>>>> High level question here. We have a big hope for "Preemptable Ticket >>>>> Spinlock

Re: [PATCH RFC V9 0/19] Paravirtualized ticket spinlocks

2013-06-02 Thread Jiannan Ouyang
On Sun, Jun 2, 2013 at 1:07 AM, Gleb Natapov wrote: > High level question here. We have a big hope for "Preemptable Ticket > Spinlock" patch series by Jiannan Ouyang to solve most, if not all, > ticketing spinlocks in overcommit scenarios problem without need for PV. > So

Re: Preemptable Ticket Spinlock

2013-04-22 Thread Jiannan Ouyang
On Mon, Apr 22, 2013 at 4:55 PM, Peter Zijlstra wrote: > > Which pv_lock? The current pv spinlock mess is basically the old unfair > thing. The later patch series I referred to earlier implemented a > paravirt ticket lock, that should perform much better under overcommit. > Yes, it is a paravirt

Re: Preemptable Ticket Spinlock

2013-04-22 Thread Jiannan Ouyang
On Mon, Apr 22, 2013 at 4:44 PM, Peter Zijlstra wrote: > On Mon, 2013-04-22 at 16:32 -0400, Rik van Riel wrote: >> >> IIRC one of the reasons was that the performance improvement wasn't >> as obvious. Rescheduling VCPUs takes a fair amount of time, quite >> probably more than the typical hold tim

Re: Preemptable Ticket Spinlock

2013-04-22 Thread Jiannan Ouyang
On Mon, Apr 22, 2013 at 4:08 PM, Peter Zijlstra wrote: > > I much prefer the entire series from Jeremy since it maintains the > ticket semantics and doesn't degrade the lock to unfair under > contention. > > Now I suppose there's a reason its not been merged yet and I suspect > its !paravirt hotp

Re: Preemptable Ticket Spinlock

2013-04-22 Thread Jiannan Ouyang
On Mon, Apr 22, 2013 at 3:56 PM, Rik van Riel wrote: > On 04/22/2013 03:49 PM, Peter Zijlstra wrote: >> >> On Mon, 2013-04-22 at 08:52 -0400, Rik van Riel wrote: > > >>> If the native spin_lock code has been called already at >>> that time, the native code would still need to be modified >>> to in

Re: Preemptable Ticket Spinlock

2013-04-22 Thread Jiannan Ouyang
On Mon, Apr 22, 2013 at 1:58 AM, Raghavendra K T wrote: > The intuition is to >> >> downgrade a fair lock to an unfair lock automatically upon preemption, >> and preserve the fairness otherwise. > > > I also hope being little unfair, does not affect the original intention > of introducing ticket

Re: Preemptable Ticket Spinlock

2013-04-21 Thread Jiannan Ouyang
On Sun, Apr 21, 2013 at 5:12 PM, Rik van Riel wrote: > Your algorithm is very clever, and very promising. > > However, it does increase the size of the struct spinlock, and adds > an additional atomic operation to spin_unlock, neither of which I > suspect are necessary. > > If we always incremente