[PATCH v2] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-11 Thread Jeremy Cline
mically (v2)") Suggested-by: Felix Kuehling Signed-off-by: Jeremy Cline --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index 8cac497c2c45..a56

Re: [PATCH] drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()

2021-01-11 Thread Jeremy Cline
On Mon, Jan 11, 2021 at 09:21:48PM +0100, Christian König wrote: > Am 11.01.21 um 17:40 schrieb Jeremy Cline: > > check_unmap() is producing a warning about a missing map error check. > > The return value from dma_map_page() should be checked for an error, not > > the cal

[PATCH] drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map()

2021-01-11 Thread Jeremy Cline
check_unmap() is producing a warning about a missing map error check. The return value from dma_map_page() should be checked for an error, not the caller-provided dma_addr. Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") Signed-off-by: Jeremy Cline --- drivers/g

Re: [PATCH] amdgpu: Avoid sleeping during FPU critical sections

2021-01-11 Thread Jeremy Cline
Hi, On Mon, Jan 11, 2021 at 09:53:56AM +0100, Christian König wrote: > Am 08.01.21 um 22:58 schrieb Jeremy Cline: > > dcn20_resource_construct() includes a number of kzalloc(GFP_KERNEL) > > calls which can sleep, but kernel_fpu_begin() disables preemption and > > sleepi

Re: [PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-08 Thread Jeremy Cline
On Fri, Jan 08, 2021 at 06:46:17PM -0500, Felix Kuehling wrote: > Am 2021-01-08 um 11:31 a.m. schrieb Jeremy Cline: > > KASAN reported a slab-out-of-bounds read of size 1 in > > kdf_create_vcrat_image_cpu(). > > > > This occurs when, for example, when on an x86

[PATCH] amdgpu: Avoid sleeping during FPU critical sections

2021-01-08 Thread Jeremy Cline
,max}_fill_clk_mhz. Narrow the scope to just these two parts to avoid sleeping while using the FPU. Fixes: 7a8a3430be15 ("amdgpu: Wrap FPU dependent functions in dc20") Cc: Timothy Pearson Signed-off-by: Jeremy Cline --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 8 --

[PATCH] drm/amdkfd: Fix out-of-bounds read in kdf_create_vcrat_image_cpu()

2021-01-08 Thread Jeremy Cline
ad and hopefully makes the pointer arithmetic clearer. It should have no functional change beyond removing the out-of-bounds read. Fixes: b7b6c38529c9 ("drm/amdkfd: Calculate CPU VCRAT size dynamically (v2)") Signed-off-by: Jeremy Cline --- drivers/gpu/drm/amd/amdkfd

[PATCH] drm/nouveau: avoid a use-after-free when BO init fails

2020-12-02 Thread Jeremy Cline
memory freed by nouveau_bo_del_ttm(). Fixes: 019cbd4a4feb ("drm/nouveau: Initialize GEM object before TTM object") Cc: Thierry Reding Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_gem.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/d

[PATCH v2 3/3] drm/nouveau: clean up all clients on device removal

2020-11-25 Thread Jeremy Cline
Thus, I've broken this out so the fix can be easily backported. Cc: sta...@vger.kernel.org Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_drm.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers

[PATCH v2 2/3] drm/nouveau: Add a dedicated mutex for the clients list

2020-11-25 Thread Jeremy Cline
e list and potentially lock their mutex, which is the same class as the lock protecting the entire list. Cc: sta...@vger.kernel.org Signed-off-by: Jeremy Cline --- Changes since v1: - Add a mutex_destroy() call when destroying the device struct drivers/gpu/drm/nouveau/nouveau_drm.c | 10 ++ d

[PATCH v2 1/3] drm/nouveau: use drm_dev_unplug() during device removal

2020-11-25 Thread Jeremy Cline
truly support hot-unplugging. Cc: sta...@vger.kernel.org Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index d141a5f004af..4fe4d66

[PATCH v2 0/3] drm/nouveau: fix a use-after-free in postclose()

2020-11-25 Thread Jeremy Cline
postclose() handler. While this does not enable hot-unplug support for nouveau, it's enough to avoid crashing the kernel and leads to all the core_hotunplug tests to pass. This series reroll addresses a missing mutex_destroy() call and a typo in a commit message. Jeremy Cline (3): d

Re: [PATCH 2/3] drm/nouveau: Add a dedicated mutex for the clients list

2020-11-25 Thread Jeremy Cline
On Wed, Nov 25, 2020 at 01:37:06PM -0500, Lyude Paul wrote: > On Tue, 2020-11-03 at 14:49 -0500, Jeremy Cline wrote: > > Rather than protecting the nouveau_drm clients list with the lock within > > the "client" nouveau_cli, add a dedicated lock to serialize access to &

Re: [Nouveau] [PATCH 2/3] drm/nouveau: manage nouveau_drm lifetime with devres

2020-11-10 Thread Jeremy Cline
On Fri, Nov 06, 2020 at 02:31:44PM +0100, Karol Herbst wrote: > On Fri, Nov 6, 2020 at 3:17 AM Jeremy Cline wrote: > > > > Make use of the devm_drm_dev_alloc() API to bind the lifetime of > > nouveau_drm structure to the drm_device. This is important because a > >

Re: [Nouveau] [PATCH 2/3] drm/nouveau: manage nouveau_drm lifetime with devres

2020-11-06 Thread Jeremy Cline
On Fri, Nov 06, 2020 at 02:31:44PM +0100, Karol Herbst wrote: > On Fri, Nov 6, 2020 at 3:17 AM Jeremy Cline wrote: > > > > Make use of the devm_drm_dev_alloc() API to bind the lifetime of > > nouveau_drm structure to the drm_device. This is important because a > >

[PATCH 2/3] drm/nouveau: manage nouveau_drm lifetime with devres

2020-11-05 Thread Jeremy Cline
currently occurs. Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_drm.c | 44 --- drivers/gpu/drm/nouveau/nouveau_drv.h | 10 -- 2 files changed, 26 insertions(+), 28 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm

[PATCH 1/3] drm/nouveau: Use helper to convert nouveau_drm to drm_device

2020-11-05 Thread Jeremy Cline
patch should introduce no functional changes. Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/dispnv04/crtc.c | 10 +++--- drivers/gpu/drm/nouveau/dispnv50/base.c | 2 +- drivers/gpu/drm/nouveau/dispnv50/base507c.c | 7 ++-- drivers/gpu/drm/nouveau/dispnv50/core.c | 2

[PATCH 3/3] drm/nouveau: begin documenting core nouveau structures

2020-11-05 Thread Jeremy Cline
Start on documentation for the Nouveau device structure and the NVIF client structure it uses. This documentation is not complete as the structures are non-trivial and I am not familiar with large portions of them. Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_drv.h | 67

[PATCH 0/3] drm/nouveau: extend the lifetime of nouveau_drm

2020-11-05 Thread Jeremy Cline
tions before the drm_device is destroyed, so I suspect much of the current cleanup code in Nouveau would benefit from some refactoring to use this. Finally, although not *strictly* necessary for this series, I included some documentation for structures I investigated for this work. Jeremy Cline (3):

[PATCH 2/3] drm/nouveau: Add a dedicated mutex for the clients list

2020-11-03 Thread Jeremy Cline
e list and potentially lock their mutex, which is the same class as the lock protecting the entire list. Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_drm.c | 9 + drivers/gpu/drm/nouveau/nouveau_drv.h | 5 + 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/d

[PATCH 1/3] drm/nouveau: use drm_dev_unplug() during device removal

2020-11-03 Thread Jeremy Cline
truly support hot-unplugging. Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c index d141a5f004af..4fe4d664c5f2 100644 --- a/drivers/gp

[PATCH 3/3] drm/nouveau: clean up all clients on device removal

2020-11-03 Thread Jeremy Cline
hange. Thus, I've broken this out so the fix can be easily backported. Signed-off-by: Jeremy Cline --- drivers/gpu/drm/nouveau/nouveau_drm.c | 30 +++ 1 file changed, 30 insertions(+) diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nou

[PATCH 0/3] drm/nouveau: fix a use-after-free in postclose()

2020-11-03 Thread Jeremy Cline
postclose() handler. While this does not enable hot-unplug support for nouveau, it's enough to avoid crashing the kernel and leads to all the core_hotunplug tests to pass. Jeremy Cline (3): drm/nouveau: use drm_dev_unplug() during device removal drm/nouveau: Add a dedicated mutex for the cli

Re: [PATCH v2 1/2] drm/nouveau: return temperatures in temp_get() via parameter

2020-09-17 Thread Jeremy Cline
On Wed, Sep 16, 2020 at 10:03:22PM +0200, Karol Herbst wrote: > On Wed, Sep 16, 2020 at 10:01 PM Karol Herbst wrote: > > > > On Wed, Sep 16, 2020 at 9:47 PM Jeremy Cline wrote: > > > > > > The temp_get() function currently returns negative error numbers or

[PATCH v2 1/2] drm/nouveau: return temperatures in temp_get() via parameter

2020-09-16 Thread Jeremy Cline
some, like gp100_temp_get(), do not. Rather than relying on implementations remembering to clamp values, dedicate the function return value to error codes and accept a pointer to an integer where the temperature reading should be stored. Signed-off-by: Jeremy Cline --- .../drm/nouveau/include/nvkm

[PATCH v2 2/2] drm/nouveau: Add fine-grain temperature reporting

2020-09-16 Thread Jeremy Cline
clear what the unit is. Signed-off-by: Jeremy Cline --- .../nouveau/include/nvkm/subdev/bios/therm.h | 13 ++ .../drm/nouveau/include/nvkm/subdev/therm.h | 26 +++ drivers/gpu/drm/nouveau/nouveau_hwmon.c | 2 +- .../gpu/drm/nouveau/nvkm/subdev/therm/ba

[PATCH v2 0/2] Add fine-grain temperature reporting

2020-09-16 Thread Jeremy Cline
r than adding a separate helper, but was torn about whether this is clearer than a separate helper function. * I added a WARN_ON in places that previously called nvkm_therm_temp_get() and didn't check the return value for an error. This may not be a reasonable error handling method. Jer

Re: [Nouveau] [PATCH] drm/nouveau: Add fine-grain temperature reporting

2020-09-09 Thread Jeremy Cline
On Wed, Sep 09, 2020 at 10:22:14AM +0200, Karol Herbst wrote: > On Wed, Sep 9, 2020 at 6:06 AM Ben Skeggs wrote: > > > > On Thu, 13 Aug 2020 at 06:50, Jeremy Cline wrote: > > > > > > Commit d32656373857 ("drm/nouveau/therm/gp100: initial implementation

[PATCH] drm/nouveau: Add fine-grain temperature reporting

2020-08-12 Thread Jeremy Cline
p_get() to report finer-grain temperatures, which would be inconvenient for other users of the function, a second interface has been added to line up with hwmon's native unit of temperature. Signed-off-by: Jeremy Cline --- .../drm/nouveau/include/nvkm/subdev/therm.h | 18 +

[PATCH RESEND] lockdown: Allow unprivileged users to see lockdown status

2020-05-14 Thread Jeremy Cline
read the state. Fixes: 000d388ed3bb ("security: Add a static lockdown policy LSM") Cc: Frank Ch. Eigler Signed-off-by: Jeremy Cline --- security/lockdown/lockdown.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/security/lockdown/lockdown.c b/security/lockdown/

Re: [PATCH] lockdown: Allow unprivileged users to see lockdown status

2020-05-11 Thread Jeremy Cline
On Sat, Feb 22, 2020 at 03:51:24AM +1100, James Morris wrote: > On Thu, 20 Feb 2020, Jeremy Cline wrote: > > > A number of userspace tools, such as systemtap, need a way to see the > > current lockdown state so they can gracefully deal with the kernel being > > locked do

[PATCH] docs: kmemleak: DEBUG_KMEMLEAK_EARLY_LOG_SIZE changed names

2019-09-25 Thread Jeremy Cline
Commit c5665868183f ("mm: kmemleak: use the memory pool for early allocations") renamed CONFIG_DEBUG_KMEMLEAK_EARLY_LOG_SIZE to CONFIG_DEBUG_KMEMLEAK_MEM_POOL_SIZE. Update the documentation reference to reflect that. Signed-off-by: Jeremy Cline --- Documentation/dev-tools/kmemleak.rst

[PATCH] arm64: Fix reference to docs for ARM64_TAGGED_ADDR_ABI

2019-09-17 Thread Jeremy Cline
The referenced file does not exist, but tagged-address-abi.rst does. Signed-off-by: Jeremy Cline --- arch/arm64/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 6ae6ad8a4db0..8960310b4f64 100644 --- a/arch/arm64/Kconfig

Re: [PATCH v2] HID: input: fix a4tech horizontal wheel custom usage

2019-07-18 Thread Jeremy Cline
On Fri, Jun 14, 2019 at 03:36:03PM +0200, Benjamin Tissoires wrote: > Hi Wolfgang, > > On Thu, Jun 13, 2019 at 1:49 PM Wolfgang Bauer wrote: > > > > On Tuesday, 11. Juni 2019, 16:42:37 Benjamin Tissoires wrote: > > > On Tue, Jun 11, 2019 at 2:13 PM Nicolas Saenz Julienne > > > > > > wrote: > > >

Re: [PATCH v2] KEYS: Make use of platform keyring for module signature verify

2019-04-25 Thread Jeremy Cline
Hi, On Thu, Apr 25, 2019 at 07:55:50AM -0400, Mimi Zohar wrote: > On Wed, 2019-04-24 at 14:33 +, Robert Holmes wrote: > > This patch completes commit 278311e417be ("kexec, KEYS: Make use of > > platform keyring for signature verify") which, while adding the > > platform keyring for bzImage ver

Re: [PATCH] Bluetooth: hci_ldisc: Postpone HCI_UART_PROTO_READY bit set in hci_uart_set_proto()

2019-02-23 Thread Jeremy Cline
rt_register_dev(hu); > if (err) { > - clear_bit(HCI_UART_PROTO_READY, &hu->flags); > return err; > } > > + set_bit(HCI_UART_PROTO_READY, &hu->flags); > return 0; > } > > -- > 2.20.1 > For what it's worth: Reviewed-by: Jeremy Cline

Re: [PATCH] proc: update i_atime when reading files

2019-02-22 Thread Jeremy Cline
On Fri, Feb 22, 2019 at 08:37:42AM +0300, Alexey Dobriyan wrote: > On Thu, Feb 21, 2019 at 11:37:14AM -0500, Jeremy Cline wrote: > > Prior to commit 1da4d377f943 ("proc: revalidate misc dentries"), the > > access, modify, and change times of files in /proc were just the c

[PATCH] proc: update i_atime when reading files

2019-02-21 Thread Jeremy Cline
ates the access time of /proc files when they are read. Reported-by: David Both Signed-off-by: Jeremy Cline --- fs/proc/inode.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/proc/inode.c b/fs/proc/inode.c index da649ccd6804..34d8603b9aa1 100644 --- a/fs/proc/inode.

[PATCH] Bluetooth: hci_ldisc: Initialize hci_dev before open()

2019-02-06 Thread Jeremy Cline
otmail.com Signed-off-by: Jeremy Cline --- drivers/bluetooth/hci_ldisc.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/bluetooth/hci_ldisc.c b/drivers/bluetooth/hci_ldisc.c index fbf7b4df23ab..4918fefc4a6f 100644 --- a/drivers/bluetooth/hci_ldi

[regression] mei: me: allow runtime pm for platform with D0i3

2019-01-23 Thread Jeremy Cline
Hi folks, Fedora has received a number of reports of e1000e-driven ethernet ports negotiating 10Mbps links if the cable is disconnected and reconnected after boot on a number of laptops, including the Lenovo T480s[0]. Kamil git-bisected the issue to commit cc365dcf0e56 ("mei: me: allow runtime pm

Re: [PATCH 4.19 061/110] ACPICA: AML interpreter: add region addresses in global list during initialization

2018-12-14 Thread Jeremy Cline
Hi folks, On 11/29/18 9:12 AM, Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Erik Schmauss > > commit 4abb951b73ff0a8a979113ef185651aa3c8da19b upstream. > > The table load process omitted adding the op

Re: [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary mode

2018-12-13 Thread Jeremy Cline
On Thu, Dec 13, 2018 at 08:37:08AM +0100, Uwe Kleine-König wrote: > On Wed, Dec 12, 2018 at 01:14:10PM -0500, Jeremy Cline wrote: > > Hi, > > > > On Wed, Dec 12, 2018 at 02:12:09PM +0100, Thierry Reding wrote: > > > From: Thierry Reding > > > > > >

Re: [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary mode

2018-12-12 Thread Jeremy Cline
; It might be worth noting this fixes commit 6f4d29df66ac ("scripts/spdxcheck.py: make python3 compliant") and also Cc this for stable since 6f4d29df66ac got backported to v4.19. While that commit did indeed make the script work with Python 3 for piping data, it broke Python 2 and made its way to stable. Reviewed-by: Jeremy Cline Regards, Jeremy

Re: Regression: very quiet speakers on Thinkpad T570s

2018-12-02 Thread Jeremy Cline
On 12/1/18 9:44 AM, Takashi Iwai wrote: > On Fri, 30 Nov 2018 17:51:33 +0100, > Jeremy Cline wrote: >> >> On 11/30/18 11:00 AM, Takashi Iwai wrote: >>> On Fri, 30 Nov 2018 15:49:17 +0100, >>> Jeremy Cline wrote: >>>> >>>> Hi, >>>

Re: Regression: very quiet speakers on Thinkpad T570s

2018-11-30 Thread Jeremy Cline
On 11/30/18 11:00 AM, Takashi Iwai wrote: > On Fri, 30 Nov 2018 15:49:17 +0100, > Jeremy Cline wrote: >> >> Hi, >> >> Some folks have reported on the Fedora bug tracker[0] that the laptop >> speaker volume is very low on the Thinkpad T570 when running a kernel

Regression: very quiet speakers on Thinkpad T570s

2018-11-30 Thread Jeremy Cline
Hi, Some folks have reported on the Fedora bug tracker[0] that the laptop speaker volume is very low on the Thinkpad T570 when running a kernel that includes commit 61fcf8ece9b6 ("ALSA: hda/realtek - Enable Thinkpad Dock device for ALC298 platform"). alsa-info.sh from v4.15.4 (just before commit

[PATCH] ALSA: hda - Add mic quirk for the Lenovo G50-30 (17aa:3905)

2018-10-11 Thread Jeremy Cline
The Lenovo G50-30, like other G50 models, has a Conexant codec that requires a quirk for its inverted stereo dmic. Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1249364 Reported-by: Alexander Ploumistos Tested-by: Alexander Ploumistos Cc: sta...@vger.kernel.org Signed-off-by: Jeremy

Re: [PATCH] scripts: spdxcheck: resovle decode warning for python3

2018-10-01 Thread Jeremy Cline
Hi Shubham, On 10/01/2018 04:38 AM, Shubham Singh wrote: > From: shubhsherl > > Resolve a warning issue by spdxcheck in Python3 > FAIL: 'str' object has no attribute 'decode' > > Signed-off-by: Shubham Singh > --- > scripts/spdxcheck.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-

Re: [PATCH] scripts/spdxcheck.py: improve Python 3 compat

2018-09-17 Thread Jeremy Cline
parser.parse_lines(open(p, 'rb'), args.maxlines, p) > elif os.path.isdir(p): > scan_git_subtree(repo.head.reference.commit.tree, p) > else: > For what it's worth: Reviewed-by: Jeremy Cline

Re: [PATCH] cpufreq: governor: Protect cpufreq governor_data

2018-09-13 Thread Jeremy Cline
Hi folks, On 08/14/2018 08:01 PM, Henry Willard wrote: > If cppc_cpufreq.ko is deleted at the same time that tuned-adm is, > changing profiles, there is a small chance that a race can occur > between cpufreq_dbs_governor_exit() and cpufreq_dbs_governor_limits() > resulting in a system failure when

[PATCH 0/2] fs/quota: Fix potential spectre v1 gadgets

2018-07-30 Thread Jeremy Cline
Hi folks, This series unifies XQM_MAXQUOTAS with MAXQUOTAS, which were both being used to perform bounds checks on arrays, and then sanitizes 'type' so it can't be used in speculative out-of-bounds array access. Jeremy Cline (2): fs/quota: Replace XQM_MAXQUOTAS usage with MAXQU

[PATCH 2/2] fs/quota: Fix spectre gadget in do_quotactl

2018-07-30 Thread Jeremy Cline
_file_info() warn: potential spectre issue 'dqopt->info' [r] Additionally, a quick inspection indicates there are array accesses with 'type' in quota_on() and quota_off() functions which are also addressed by this. Cc: Josh Poimboeuf Cc: sta...@vger.kernel.org Signed-of

[PATCH 1/2] fs/quota: Replace XQM_MAXQUOTAS usage with MAXQUOTAS

2018-07-30 Thread Jeremy Cline
XQM_MAXQUOTAS and MAXQUOTAS are, it appears, equivalent. Replace all usage of XQM_MAXQUOTAS and remove it along with the unused XQM_*QUOTA definitions. Signed-off-by: Jeremy Cline --- fs/quota/quota.c | 12 +--- include/linux/quota.h | 8 +--- include/uapi

Re: [PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-07-30 Thread Jeremy Cline
Hi Ted, On 07/30/2018 02:36 PM, Theodore Y. Ts'o wrote: > Hey Jeremy, > > I think you are also going to be changing the 1/3 patch from the > original patch series that this was part of. That's correct, right? > > It would be easier for me if you could simply make all of the > revisions you plan

[PATCH v2] ext4: mballoc: Fix spectre gadget in ext4_mb_regular_allocator

2018-07-30 Thread Jeremy Cline
SB(e4b->bd_sb)->s_mb_offsets' [r] (local cap) * fs/ext4/mballoc.c:446 mb_find_buddy() warn: potential spectre issue 'EXT4_SB(e4b->bd_sb)->s_mb_maxs' [r] (local cap) Cc: Josh Poimboeuf Cc: sta...@vger.kernel.org Suggested-by: Josh Poimboeuf Signed-off-by: Jeremy Cline ---

[PATCH v2] scripts: Add Python 3 support to tracing/draw_functrace.py

2018-07-28 Thread Jeremy Cline
Use the print function. This maintains Python 2 support and should have no functional change. Signed-off-by: Jeremy Cline --- Changes from v1: - Drop "from __future__ import print_function" as Python 2 is not long for this world and in this case the statement and function beha

Re: [PATCH 1/3] ext4: super: Fix spectre gadget in ext4_quota_on

2018-07-27 Thread Jeremy Cline
On 07/27/2018 01:46 PM, Josh Poimboeuf wrote: > On Fri, Jul 27, 2018 at 04:23:55PM +0000, Jeremy Cline wrote: >> 'type' is a user-controlled value used to index into 's_qf_names', which >> can be used in a Spectre v1 attack. Clamp 'type' to the size

[PATCH 3/3] ext4: mballoc: Fix spectre gadget in ext4_mb_simple_scan_group

2018-07-27 Thread Jeremy Cline
* fs/ext4/mballoc.c:445 mb_find_buddy() warn: potential spectre issue 'EXT4_SB(e4b->bd_sb)->s_mb_offsets' [r] (local cap) * fs/ext4/mballoc.c:446 mb_find_buddy() warn: potential spectre issue 'EXT4_SB(e4b->bd_sb)->s_mb_maxs' [r] (local cap) Cc: Josh Poimboe

[PATCH 1/3] ext4: super: Fix spectre gadget in ext4_quota_on

2018-07-27 Thread Jeremy Cline
'type' is a user-controlled value used to index into 's_qf_names', which can be used in a Spectre v1 attack. Clamp 'type' to the size of the array to avoid a speculative out-of-bounds read. Cc: Josh Poimboeuf Cc: sta...@vger.kernel.org Signed-off-by: Jeremy Cline

[PATCH 2/3] ext4: super: Fix spectre gadgets in ext4_quota_{read,write,off}

2018-07-27 Thread Jeremy Cline
ctre issue 'sb_dqopt(sb)->files' [r] * fs/ext4/super.c:5778 ext4_quota_write() warn: potential spectre issue 'sb_dqopt(sb)->files' [r] Cc: Josh Poimboeuf Cc: sta...@vger.kernel.org Signed-off-by: Jeremy Cline --- fs/ext4/super.c | 18 ++ 1 file chan

[PATCH 0/3] ext4: fix spectre v1 gadgets

2018-07-27 Thread Jeremy Cline
://marc.info/?l=linux-kernel&m=152449131114778 Jeremy Cline (3): ext4: super: Fix spectre gadget in ext4_quota_on ext4: super: Fix spectre gadgets in ext4_quota_{read,write,off} ext4: mballoc: Fix spectre gadget in ext4_mb_simple_scan_group fs/ext4/mballoc.c | 2 ++ fs/ext4/super.c

Re: [PATCH] scripts: Add Python 3 support to tracing/draw_functrace.py

2018-07-25 Thread Jeremy Cline
On 07/25/2018 10:39 AM, Masahiro Yamada wrote: > 2018-07-21 4:35 GMT+09:00 Jeremy Cline : >> Use the print function. This maintains Python 2 support and should have >> no functional change. >> >> Signed-off-by: Jeremy Cline >> --- >> scripts/tracing/draw_

[PATCH] scripts: Add Python 3 support to tracing/draw_functrace.py

2018-07-20 Thread Jeremy Cline
Use the print function. This maintains Python 2 support and should have no functional change. Signed-off-by: Jeremy Cline --- scripts/tracing/draw_functrace.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/scripts/tracing/draw_functrace.py b/scripts/tracing

[PATCH] bpf: Add Python 3 support to selftests scripts for bpf

2018-07-18 Thread Jeremy Cline
Adjust tcp_client.py and tcp_server.py to work with Python 3 by using the print function, marking string literals as bytes, and using the newer exception syntax. This should be functionally equivalent and support Python 2.6 through Python 3.7. Signed-off-by: Jeremy Cline --- tools/testing

[PATCH] scripts: Add Python 3 compatibility to spdxcheck.py

2018-07-17 Thread Jeremy Cline
gnoring encoding errors. This remains compatible with Python 2 and should have no functional change. Signed-off-by: Jeremy Cline --- scripts/spdxcheck.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/spdxcheck.py b/scripts/spdxcheck.py index a6041f29b18e..839

[tip:perf/urgent] perf tools: Use python-config --includes rather than --cflags

2018-07-12 Thread tip-bot for Jeremy Cline
Commit-ID: 32aa928a7b817140c84987b726d5014911808fa4 Gitweb: https://git.kernel.org/tip/32aa928a7b817140c84987b726d5014911808fa4 Author: Jeremy Cline AuthorDate: Tue, 10 Jul 2018 11:46:12 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 Jul 2018 09:48:31 -0400 perf tools

[tip:perf/urgent] perf scripts python: Add Python 3 support to EventClass.py

2018-07-12 Thread tip-bot for Jeremy Cline
Commit-ID: 12aa6c7389a321b4b5d921f89c3f83b9750598f7 Gitweb: https://git.kernel.org/tip/12aa6c7389a321b4b5d921f89c3f83b9750598f7 Author: Jeremy Cline AuthorDate: Tue, 8 May 2018 21:27:48 + Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 Jul 2018 10:01:50 -0300 perf scripts

[tip:perf/urgent] perf scripts python: Add Python 3 support to sched-migration.py

2018-07-12 Thread tip-bot for Jeremy Cline
Commit-ID: 8c1c1ab2d2a77cb50841822168e56d11c4ebfd6e Gitweb: https://git.kernel.org/tip/8c1c1ab2d2a77cb50841822168e56d11c4ebfd6e Author: Jeremy Cline AuthorDate: Tue, 8 May 2018 21:27:47 + Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 Jul 2018 10:01:50 -0300 perf scripts

[tip:perf/urgent] perf scripts python: Add Python 3 support to Util.py

2018-07-12 Thread tip-bot for Jeremy Cline
Commit-ID: c45b168effb12719f6dfc8d2c20ba8c057e8c16b Gitweb: https://git.kernel.org/tip/c45b168effb12719f6dfc8d2c20ba8c057e8c16b Author: Jeremy Cline AuthorDate: Tue, 8 May 2018 21:27:46 + Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 Jul 2018 10:01:50 -0300 perf scripts

[tip:perf/urgent] perf tools: Generate a Python script compatible with Python 2 and 3

2018-07-12 Thread tip-bot for Jeremy Cline
Commit-ID: 877cc639686b68c7de179a485544f4761e376b30 Gitweb: https://git.kernel.org/tip/877cc639686b68c7de179a485544f4761e376b30 Author: Jeremy Cline AuthorDate: Tue, 8 May 2018 21:27:43 + Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 Jul 2018 10:01:50 -0300 perf tools

[tip:perf/urgent] perf scripts python: Add Python 3 support to SchedGui.py

2018-07-12 Thread tip-bot for Jeremy Cline
Commit-ID: 2ab89262ff8895b8476b97345507c676fe3081fa Gitweb: https://git.kernel.org/tip/2ab89262ff8895b8476b97345507c676fe3081fa Author: Jeremy Cline AuthorDate: Tue, 8 May 2018 21:27:45 + Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 Jul 2018 10:01:50 -0300 perf scripts

[tip:perf/urgent] perf scripts python: Add Python 3 support to Core.py

2018-07-12 Thread tip-bot for Jeremy Cline
Commit-ID: 770d2f86c0051d4f2c0ab9d74d68434cb383241d Gitweb: https://git.kernel.org/tip/770d2f86c0051d4f2c0ab9d74d68434cb383241d Author: Jeremy Cline AuthorDate: Tue, 8 May 2018 21:27:45 + Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 11 Jul 2018 10:01:50 -0300 perf scripts

[PATCH] perf: Use python-config --includes rather than --cflags

2018-07-10 Thread Jeremy Cline
s to have fixed a similar problem. "python-config --includes" provides the proper -I flags and doesn't introduce additional CFLAGS. Signed-off-by: Jeremy Cline --- tools/perf/Makefile.config | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/Makefile.c

Re: [PATCH 4.4 128/268] scsi: sd: Keep disk read-only when re-reading partition

2018-06-14 Thread Jeremy Cline
Hi Ben, On 06/13/2018 05:25 PM, Ben Hutchings wrote: > On Mon, 2018-05-28 at 12:01 +0200, Greg Kroah-Hartman wrote: >> 4.4-stable review patch.  If anyone has any objections, please let me know. >> >> ------ >> >> From: Jere

Re: Regression: x86/tsc: Fix mark_tsc_unstable()

2018-06-11 Thread Jeremy Cline
On 06/11/2018 03:23 PM, Diego Viola wrote: > On Mon, Jun 11, 2018 at 3:11 PM, Jeremy Cline wrote: >> On 06/11/2018 01:56 PM, Jeremy Cline wrote: >>> On 06/11/2018 11:30 AM, Peter Zijlstra wrote: >>>> On Mon, Jun 11, 2018 at 04:38:01PM +0200, Peter Zijlstra wrote:

Re: Regression: x86/tsc: Fix mark_tsc_unstable()

2018-06-11 Thread Jeremy Cline
On 06/11/2018 11:30 AM, Peter Zijlstra wrote: > On Mon, Jun 11, 2018 at 04:38:01PM +0200, Peter Zijlstra wrote: >> On Mon, Jun 11, 2018 at 04:17:42PM +0200, Peter Zijlstra wrote: >>> On Mon, Jun 11, 2018 at 01:59:15PM +, Jeremy Cline wrote: >>>> A user has bis

Regression: x86/tsc: Fix mark_tsc_unstable()

2018-06-11 Thread Jeremy Cline
Hi folks, A few Fedora users have reported[0] a regression starting in v4.16.8 where the boot will hang ~1/3 of the time with the following RCU stall warning: INFO: rcu_sched detected stalls on CPUs/tasks: o1-...!: (0 ticks this GP) idle=688/0/0 softirq=171/171 fqs=0 o(detected by 0, t=60002 jiff

[PATCH 1/8] perf tools: Generate a Python script compatible with Python 2 and 3

2018-05-08 Thread Jeremy Cline
int(get_dict_as_string(event_fields_dict)) + print('Sample: {'+get_dict_as_string(perf_sample_dict['sample'], ', ')+'}') def print_header(event_name, cpu, secs, nsecs, pid, comm): - print "%-20s %5u %05u.%09u %8u %-20s "

[PATCH 3/8] perf scripts python: Add Python 3 support to SchedGui.py

2018-05-08 Thread Jeremy Cline
Fix a single syntax error in SchedGui.py to support both Python 2 and Python 3. This should have no functional change. Signed-off-by: Jeremy Cline --- .../scripts/python/Perf-Trace-Util/lib/Perf/Trace/SchedGui.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf

[PATCH 2/8] perf scripts python: Add Python 3 support to Core.py

2018-05-08 Thread Jeremy Cline
Support both Python 2 and Python 3 in Core.py. This should have no functional change. Signed-off-by: Jeremy Cline --- .../Perf-Trace-Util/lib/Perf/Trace/Core.py| 40 --- 1 file changed, 17 insertions(+), 23 deletions(-) diff --git a/tools/perf/scripts/python/Perf-Trace-Util

[PATCH 4/8] perf scripts python: Add Python 3 support to Util.py

2018-05-08 Thread Jeremy Cline
Support both Python 2 and Python 3 in Util.py. The dict class no longer has a ``has_key`` method and print is now a function rather than a statement. This should have no functional change. Signed-off-by: Jeremy Cline --- .../python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 11 ++- 1

[PATCH 8/8] perf tests: Add Python 3 support to attr.py

2018-05-08 Thread Jeremy Cline
Support both Python 2 and Python 3 in attr.py. This should have no functional change. Signed-off-by: Jeremy Cline --- tools/perf/tests/attr.py | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/tools/perf/tests/attr.py b/tools/perf/tests

[PATCH 7/8] perf scripts python: Add Python 3 support to stat-cpi.py

2018-05-08 Thread Jeremy Cline
Support both Python 2 and Python 3 in stat-cpi.py. This should have no functional change. Signed-off-by: Jeremy Cline --- tools/perf/scripts/python/stat-cpi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/scripts/python/stat-cpi.py b/tools/perf/scripts

[PATCH 5/8] perf scripts python: Add Python 3 support to EventClass.py

2018-05-08 Thread Jeremy Cline
Support both Python 2 and Python 3 in EventClass.py. ``print`` is now a function rather than a statement. This should have no functional change. Signed-off-by: Jeremy Cline --- .../python/Perf-Trace-Util/lib/Perf/Trace/EventClass.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 6/8] perf scripts python: Add Python 3 support to sched-migration.py

2018-05-08 Thread Jeremy Cline
Support both Python 2 and Python 3 in the sched-migration.py script. This should have no functional change. Signed-off-by: Jeremy Cline --- tools/perf/scripts/python/sched-migration.py | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/tools/perf/scripts/python

[PATCH 0/8] Improve Python 3 support in perf

2018-05-08 Thread Jeremy Cline
Hi folks, This patch set adds Python 3 support to a number of perf scripts, including those generated by "perf script -g python", without breaking Python 2 compatibility. Jeremy Cline (8): perf tools: Generate a Python script compatible with Python 2 and 3 perf scripts python: Ad

Re: Linux messages full of `random: get_random_u32 called from`

2018-04-30 Thread Jeremy Cline
On 04/29/2018 06:05 PM, Theodore Y. Ts'o wrote: > On Sun, Apr 29, 2018 at 01:20:33PM -0700, Sultan Alsawaf wrote: >> On Sun, Apr 29, 2018 at 08:41:01PM +0200, Pavel Machek wrote: >>> Umm. No. https://www.youtube.com/watch?v=xneBjc8z0DE >> >> Okay, but /dev/urandom isn't a solution to this problem b

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-13 Thread Jeremy Cline
On 03/13/2018 03:59 AM, Ard Biesheuvel wrote: > On 13 March 2018 at 07:47, Hans de Goede wrote: >> Hi, >> >> >> On 12-03-18 20:55, Thiebaud Weksteen wrote: >>> > ... >>> >>> Hans, you said you configured the tablet to use the 32-bit version of grub >>> instead >>> of 64. Why's that? >> >> >> Becau

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Jeremy Cline
On 03/12/2018 03:55 PM, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 7:33 PM Jeremy Cline wrote: > >> On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: >>> On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel < > ard.biesheu...@linaro.org> >>> wrote: >

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Jeremy Cline
On 03/12/2018 02:29 PM, Thiebaud Weksteen wrote: > On Mon, Mar 12, 2018 at 6:30 PM Ard Biesheuvel > wrote: > >> On 12 March 2018 at 17:01, Jeremy Cline wrote: >>> On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >>>> On 12 March 2018 at 14:30, Jeremy Cline wrot

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Jeremy Cline
On 03/12/2018 01:30 PM, Ard Biesheuvel wrote: > On 12 March 2018 at 17:01, Jeremy Cline wrote: >> On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: >>> On 12 March 2018 at 14:30, Jeremy Cline wrote: >>>> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >>>>>

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Jeremy Cline
On 03/12/2018 10:56 AM, Ard Biesheuvel wrote: > On 12 March 2018 at 14:30, Jeremy Cline wrote: >> On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: >>> On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >>>> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >>

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-12 Thread Jeremy Cline
On 03/12/2018 07:08 AM, Ard Biesheuvel wrote: > On 10 March 2018 at 10:45, Thiebaud Weksteen wrote: >> On Fri, Mar 9, 2018 at 5:54 PM Jeremy Cline wrote: >> >>> On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: >>>> Thanks a lot for trying o

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-09 Thread Jeremy Cline
On Fri, Mar 09, 2018 at 10:43:50AM +, Thiebaud Weksteen wrote: > Thanks a lot for trying out the patch! > > Please don't modify your install at this stage, I think we are hitting a > firmware bug and that would be awesome if we can fix how we are handling it. > So, if we reach that stage in th

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-08 Thread Jeremy Cline
On 03/08/2018 03:45 AM, Thiebaud Weksteen wrote: > Jeremy, Hans, could you both describe precisely how your boot is > configured? This feature is only triggered when booting the EFI stub of the > kernel so this may be not executed if you are using something else in > between. I put everything I kn

Re: Regression from efi: call get_event_log before ExitBootServices

2018-03-08 Thread Jeremy Cline
On 03/08/2018 11:50 AM, Hans de Goede wrote: > added these now> > > Hi, > > On 07-03-18 12:34, Javier Martinez Canillas wrote: >> Are you also able to read the TPM event logs? >> >> $ hexdump /sys/kernel/security/tpm0/binary_bios_measurements > > Yes for me that outputs a lot of hex :) For

[PATCH v2] scsi: sd: Keep disk read-only when re-reading partition

2018-03-06 Thread Jeremy Cline
h the device disk-reported state rather than unconditionally marking it as RW. Reported-by: Li Ning Signed-off-by: Jeremy Cline --- Sorry about this, but there's a bug in the first version of this patch. I'm not sure what the protocol is for sending revised patches when the earlier versi

Regression from efi: call get_event_log before ExitBootServices

2018-03-06 Thread Jeremy Cline
Hi folks, Commit 33b6d03469b2 ("efi: call get_event_log before ExitBootServices") causes my GP-electronic T701 tablet to hang when booting. Reverting the patch series or hiding the TPM in the BIOS fixes the problem. I've never fiddled with TPMs before so I'm not sure what what debugging informati

Re: [PATCH] scsi: sd: Keep disk read-only when re-reading partition

2018-03-02 Thread Jeremy Cline
On 03/02/2018 07:00 AM, Johannes Thumshirn wrote: > On Thu, Mar 01, 2018 at 02:08:10PM +0000, Jeremy Cline wrote: >> If the read-only flag is true on a SCSI disk, re-reading the partition >> table sets the flag back to false. >> >> To observe this bug, you can run: >

[PATCH] scsi: sd: Keep disk read-only when re-reading partition

2018-03-01 Thread Jeremy Cline
h the device disk-reported state rather than unconditionally marking it as RW. Reported-by: Li Ning Signed-off-by: Jeremy Cline --- drivers/scsi/sd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index bff21e636ddd..7a3a66a7890f 1

  1   2   >