Re: [PATCH v2] scsi: libsas: Reset num_scatter if libata mark qc as NODATA

在 2021/3/19 6:56, Jolly Shah 写道: When the cache_type for the scsi device is changed, the scsi layer issues a MODE_SELECT command. The caching mode details are communicated via a request buffer associated with the scsi command with data direction set as DMA_TO_DEVICE (scsi_mode_select). When th

Re: [PATCH] scsi: libsas: Reset num_scatter if libata mark qc as NODATA

nctional errors? The code looks good to me, Reviewed-by: Jason Yan

Re: [PATCH 00/11] scsi: libsas: Remove in_interrupt() check

在 2020/12/21 18:13, John Garry 写道: On 18/12/2020 20:43, Ahmed S. Darwish wrote: Folks, In the discussion about preempt count consistency across kernel configurations:    https://lkml.kernel.org/r/20200914204209.256266...@linutronix.de it was concluded that the usage of in_interrupt() and re

[PATCH] lib/lzo: make lzogeneric1x_1_compress() static

Fix the following sparse warning: lib/lzo/lzo1x_compress.c:304:5: warning: symbol 'lzogeneric1x_1_compress' was not declared. Should it be static? Signed-off-by: Jason Yan --- lib/lzo/lzo1x_compress.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/lzo/lzo1x_

Re: [PATCH -next] scsi: libsas: simplify the return expression of sas_discover_* functions

return sas_notify_lldd_dev_found(dev); } /* -- Device registration and unregistration -- */ Please add a version descriptor and describe the change against the first version next time . Otherwise this looks good to me. Reviewed-by: Jason Yan Thanks, Jason

[PATCH] bootconfig: init: make xbc_namebuf static

This eliminates the following sparse warning: init/main.c:306:6: warning: symbol 'xbc_namebuf' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- init/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/init/main.c b/i

[PATCH] powerpc/ps3: make two symbols static

static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- arch/powerpc/platforms/ps3/spu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/platforms/ps3/spu.c b/arch/powerpc/platforms/ps3/spu.c index 1193c294b8d0..0c252478e556 100644 --- a/arch/powerpc/platf

[PATCH] MIPS: Make setup_elfcorehdr and setup_elfcorehdr_size static

This addresses the following sparse warning: arch/mips/kernel/setup.c:446:33: warning: symbol 'setup_elfcorehdr_size' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- arch/mips/kernel/setup.c | 2 +- 1 file changed, 1 insertion(+),

[PATCH] clk: qcom: gcc-msm8939: remove defined but not used variables

gpll0a_map[] = { ^~~ drivers/clk/qcom/gcc-msm8939.c:598:32: warning: ‘gcc_xo_gpll6_gpll0_map’ defined but not used [-Wunused-const-variable=] static const struct parent_map gcc_xo_gpll6_gpll0_map[] = { ^~ Reported-by: Hulk Robot Signed-off-by:

[PATCH] drm/i810: make i810_flush_queue() return void

This function always return '0' and no callers use the return value. So make it a void function. This eliminates the following coccicheck warning: drivers/gpu/drm/i810/i810_dma.c:860:8-11: Unneeded variable: "ret". Return "0" on line 885 Reported-by: Hulk R

[PATCH] soc: sunxi: sram: remove unneeded semicolon

Eliminate the following coccicheck warning: drivers/soc/sunxi/sunxi_sram.c:197:2-3: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/soc/sunxi/sunxi_sram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/sunxi/sunxi_sram.c b

[PATCH] pcmcia: db1xxx_ss: remove unneeded semicolon

Eliminate the following coccicheck warning: drivers/pcmcia/db1xxx_ss.c:455:2-3: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/pcmcia/db1xxx_ss.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pcmcia/db1xxx_ss.c b/drivers/pcmcia

[PATCH] video: fbdev: fsl-diu-fb: remove unneeded variable 'res'

Eliminate the following coccicheck warning: drivers/video/fbdev/fsl-diu-fb.c:1428:5-8: Unneeded variable: "res". Return "0" on line 1450 Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/video/fbdev/fsl-diu-fb.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[PATCH] drm: xlnx: remove defined but not used 'scaling_factors_666'

d-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/xlnx/zynqmp_disp.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c b/drivers/gpu/drm/xlnx/zynqmp_disp.c index a455cfc1bee5..98bd48f13fd1 100644 --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c +++ b/d

[PATCH] brcmsmac: phytbl_lcn: Eliminate defined but not used 'dot11lcn_gain_tbl_rev1'

n_tbl_rev1[] = { | ^~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- .../brcm80211/brcmsmac/phy/phytbl_lcn.c | 99 --- 1 file changed, 99 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phytbl_lcn.c b/drivers/net/wireles

[PATCH] video: fbdev: sis: remove unneeded semicolon

semicolon drivers/video/fbdev/sis/sis_accel.h:274:75-76: Unneeded semicolon drivers/video/fbdev/sis/sis_accel.h:275:73-74: Unneeded semicolon drivers/video/fbdev/sis/sis_accel.h:276:75-76: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/video/fbdev/sis

[PATCH] brcmsmac: phy_lcn: Eliminate defined but not used 'lcnphy_rx_iqcomp_table_rev0'

table_rev0[] = { | ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- .../broadcom/brcm80211/brcmsmac/phy/phy_lcn.c | 55 --- 1 file changed, 55 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_lcn.c b/d

[PATCH] brcmsmac: main: Eliminate empty brcms_c_down_del_timer()

This function does nothing so remove it. This addresses the following coccicheck warning: drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c:5103:6-15: Unneeded variable: "callbacks". Return "0" on line 5105 Reported-by: Hulk Robot Signed-off-by: Jason Yan ---

[PATCH] soc: fsl: dpio: remove set but not used 'addr_cena'

addr_cena; | ^ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/soc/fsl/dpio/qbman-portal.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/soc/fsl/dpio/qbman-portal.c b/drivers/soc/fsl/dpio/qbman-portal.c index 0ab85bfb116f..659b4a570d5b 100644 ---

Re: [PATCH] scsi: libsas: Fix error path in sas_notify_lldd_dev_found()

dev_name(sas_ha->dev), SAS_ADDR(dev->sas_addr), res); + return res; } set_bit(SAS_DEV_FOUND, &dev->state); kref_get(&dev->kref); - return res; + return 0; } Hi Dan, thanks for finding this, Reviewed-by: Jason Yan

[PATCH] ath6kl: wmi: remove set but not used 'rate'

^~~~ The variable 'sgi' is alse removed because after 'rate' is removed, it is not used too. Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/net/wireless/ath/ath6kl/wmi.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/ne

Re: [PATCH v1] scsi: libsas: set data_dir as DMA_NONE if libata mark qc as NODATA

ATA) + task->data_dir = DMA_NONE; + else + task->data_dir = qc->dma_dir; task->scatter = qc->sg; task->ata_task.retry_count = 1; task->task_state_flags = SAS_TASK_STATE_PENDING; Reviewed-by: Jason Yan

[PATCH] video: fbdev: remove set but not used 'ulBestVCO'

ulBestClk = 0, ulBestScore = 0; | ^ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/video/fbdev/kyro/STG4000InitDevice.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/

[PATCH] video: fbdev: remove set but not used 'ulCoreClock'

247 | u32 ulCoreClock; | ^~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/video/fbdev/kyro/STG4000InitDevice.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/video/fbdev/kyro/STG4000InitDevice.c b/drivers/video/fbdev/kyro/STG4000In

[PATCH] drm/nouveau/svm: remove set but not used 'ret'

d-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/nouveau/nouveau_svm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c b/drivers/gpu/drm/nouveau/nouveau_svm.c index 2df1c0460559..7c95ffcbd18f 100644 --- a/drivers/gpu/d

[PATCH] scsi: mptscsih: remove set but not used 'timeleft'

timeleft; | ^~~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/message/fusion/mptscsih.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/message/fusion/mptscsih.c b/drivers/message/fusion/mptscsih.c index 8543f0324d5a..a5ef9faf71c7 10

[PATCH] scsi: isci: remove set but not used 'index'

Hulk Robot Signed-off-by: Jason Yan --- drivers/scsi/isci/host.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/isci/host.c b/drivers/scsi/isci/host.c index 7b5deae68d33..7ebfa3c8cdc7 100644 --- a/drivers/scsi/isci/host.c +++ b/drivers/scsi/isci/host.c @@ -2671,7 +2671,6 @@ enum

[PATCH] scsi: dpt_i2o: remove set but not used 'pHba'

Hulk Robot Signed-off-by: Jason Yan --- drivers/scsi/dpt_i2o.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index f654ad8a3d69..4251212acbbe 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @@ -408,9 +408,6 @@ static void ad

Re: [PATCH v1 2/2] {topost} scsi: libsas: check link status at ATA prereset() ops

mentioned before. Signed-off-by: Luo Jiaxing Reviewed-by: John Garry --- drivers/scsi/libsas/sas_ata.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) The same as the first one, after fix the subject: Reviewed-by: Jason Yan

Re: [PATCH v1 1/2] {topost} scsi: libsas: delete postreset at sas_sata_ops

other than that: Reviewed-by: Jason Yan

[PATCH] f2fs: Eliminate usage of uninitialized_var() macro

wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ Cc: Kees Cook Suggested-by: Chao Yu Signed-off-by: Jason Yan --- v2: Directly remove this variable. fs/f2fs/data.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 326c63879ddc..3753ba06

Re: [f2fs-dev] [PATCH] f2fs: Eliminate usage of uninitialized_var() macro

在 2020/6/15 16:26, Chao Yu 写道: On 2020/6/15 12:02, Jason Yan wrote: This is an effort to eliminate the uninitialized_var() macro[1]. The use of this macro is the wrong solution because it forces off ANY analysis by the compiler for a given variable. It even masks "unused variable"

Re: [PATCH] erofs: Eliminate usage of uninitialized_var() macro

在 2020/6/15 15:25, Gao Xiang 写道: Hi Jason, On Mon, Jun 15, 2020 at 12:01:41PM +0800, Jason Yan wrote: This is an effort to eliminate the uninitialized_var() macro[1]. The use of this macro is the wrong solution because it forces off ANY analysis by the compiler for a given variable. It

[PATCH] ata: Eliminate usage of uninitialized_var() macro

://github.com/KSPP/linux/issues/81 [2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ Cc: Kees Cook Signed-off-by: Jason Yan --- drivers/ata/libata-scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-scsi.c b

[PATCH] f2fs: Eliminate usage of uninitialized_var() macro

://github.com/KSPP/linux/issues/81 [2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ Cc: Kees Cook Signed-off-by: Jason Yan --- fs/f2fs/data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 32

[PATCH] erofs: Eliminate usage of uninitialized_var() macro

://github.com/KSPP/linux/issues/81 [2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ Cc: Kees Cook Cc: Chao Yu Signed-off-by: Jason Yan --- fs/erofs/data.c | 4 ++-- fs/erofs/zdata.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --

[PATCH] ACPI: Eliminate usage of uninitialized_var() macro

://github.com/KSPP/linux/issues/81 [2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ Cc: Kees Cook Signed-off-by: Jason Yan --- drivers/acpi/acpi_pad.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpi_pad.c

[PATCH] block: Eliminate usage of uninitialized_var() macro

://github.com/KSPP/linux/issues/81 [2] https://lore.kernel.org/lkml/CA+55aFz2500WfbKXAx8s67wrm9=yvju65tplgn_ybynv0ve...@mail.gmail.com/ Cc: Kees Cook Cc: Ming Lei Signed-off-by: Jason Yan --- block/blk-merge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-merge.c b/block

Re: [PATCH] powerpc/fsl_booke/32: fix build with CONFIG_RANDOMIZE_BASE

ced because there's no in-tree defconfig with CONFIG_RANDOMIZE_BASE set. Fixes: 2b0e86cc5de6 ("powerpc/fsl_booke/32: implement KASLR infrastructure") Cc: sta...@vger.kernel.org Signed-off-by: Arseny Solokha --- arch/powerpc/mm/nohash/kaslr_booke.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Jason Yan

[PATCH v5] block: Fix use-after-free in blkdev_get()

89d380 ("block: make blkdev_get/put() handle exclusive access") Cc: Christoph Hellwig Cc: Jens Axboe Cc: Ming Lei Cc: Jan Kara Reported-by: Hulk Robot Signed-off-by: Jason Yan Reviewed-by: Jan Kara Reviewed-by: Christoph Hellwig --- v5: Add fixes tag and Reviewed-by tag from Christ

Re: [PATCH v4] block: Fix use-after-free in blkdev_get()

Hi Christoph, 在 2020/6/8 14:15, Christoph Hellwig 写道: Looks good, Reviewed-by: Christoph Hellwig Can you dig into the history for a proper fixes tag? This one started to accessing bdev after __blkdev_get(). So I think it may be a proper fixes tag: Fixes: e525fd89d380 ("block: make blkde

[PATCH v4] block: Fix use-after-free in blkdev_get()

ph Hellwig Cc: Jens Axboe Cc: Ming Lei Cc: Jan Kara Reported-by: Hulk Robot Signed-off-by: Jason Yan Reviewed-by: Jan Kara --- v4: Remove uneeded braces and add Reviewed-by tag from Jan Kara. v3: Add bdput() when __blkdev_get() calling itself failed. v2: Add Reported-by tag and cc linux-bloc

Re: [PATCH v3] block: Fix use-after-free in blkdev_get()

在 2020/6/5 22:37, Jan Kara 写道: No need for braces here after you remove bdput(). With this fixed, feel free to add: Reviewed-by: Jan Kara Thanks, I will fix it in v4. Jason

Re: [PATCH v3] block: Fix use-after-free in blkdev_get()

在 2020/6/5 19:05, Sedat Dilek 写道: On Fri, Jun 5, 2020 at 12:23 PM Jason Yan wrote: In blkdev_get() we call __blkdev_get() to do some internal jobs and if there is some errors in __blkdev_get(), the bdput() is called which means we have released the refcount of the bdev (actually the

[PATCH v3] block: Fix use-after-free in blkdev_get()

ph Hellwig Cc: Jens Axboe Cc: Ming Lei Cc: Jan Kara Reported-by: Hulk Robot Signed-off-by: Jason Yan --- v3: Add bdput() when __blkdev_get() calling itself failed. v2: Add Reported-by tag and cc linux-block mailing list fs/block_dev.c | 9 ++--- 1 file changed, 6 insertions(+), 3 dele

Re: [PATCH v2] block: Fix use-after-free in blkdev_get()

Hi, Markus Thanks for the review. Sorry for the wording because I'm not an English native speaker. 在 2020/6/5 16:30, Markus Elfring 写道: Would you like to add the tag “Fixes” to the commit message? I tried to find the commit in the git history which introduced this issue, but I am not sur

[PATCH v2] block: Fix use-after-free in blkdev_get()

ph Hellwig Cc: Jens Axboe Cc: Ming Lei Cc: Jan Kara Reported-by: Hulk Robot Signed-off-by: Jason Yan --- v2: Add Reported-by tag and cc linux-block mailing list fs/block_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c inde

[PATCH] block: Fix use-after-free in blkdev_get()

ph Hellwig Cc: Jens Axboe Cc: Ming Lei Cc: Jan Kara Signed-off-by: Jason Yan --- fs/block_dev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/block_dev.c b/fs/block_dev.c index 47860e589388..8faec9fb47b6 100644 --- a/fs/block_dev.c +++ b/fs/block_dev.c @@ -1566,7 +15

[tip: timers/core] clocksource/drivers/atmel-st: Remove useless 'status'

The following commit has been merged into the timers/core branch of tip: Commit-ID: 8c42c0f72d7c4f295646d3eba73f62e5579b1732 Gitweb: https://git.kernel.org/tip/8c42c0f72d7c4f295646d3eba73f62e5579b1732 Author:Jason Yan AuthorDate:Tue, 14 Apr 2020 20:02:38 +08:00 Committer

[PATCH v2] scsi: hisi_sas: display proc_name in sysfs

scsi_host/host0/proc_name megaraid_sas Cc: John Garry Cc: Xiang Chen Signed-off-by: Jason Yan Acked-by: John Garry --- v2: change subject to "display proc_name in sysfs" and add "Acked-by" tag. drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 1 + drivers/scsi/hisi_sas/

Re: [PATCH] scsi: hisi_sas: display correct proc_name in sysfs

在 2020/5/12 19:07, John Garry 写道: On 12/05/2020 11:30, Jason Yan wrote: 在 2020/5/12 18:00, John Garry 写道: On 12/05/2020 10:35, Jason Yan wrote: 在 2020/5/12 16:23, John Garry 写道: On 12/05/2020 07:33, Jason Yan wrote: The 'proc_name' entry in sysfs for hisi_sas is 'null&#

Re: [PATCH] scsi: hisi_sas: display correct proc_name in sysfs

在 2020/5/12 18:00, John Garry 写道: On 12/05/2020 10:35, Jason Yan wrote: 在 2020/5/12 16:23, John Garry 写道: On 12/05/2020 07:33, Jason Yan wrote: The 'proc_name' entry in sysfs for hisi_sas is 'null' now becuase it is not initialized in scsi_host_template. It looks li

Re: [PATCH] scsi: hisi_sas: display correct proc_name in sysfs

在 2020/5/12 16:23, John Garry 写道: On 12/05/2020 07:33, Jason Yan wrote: The 'proc_name' entry in sysfs for hisi_sas is 'null' now becuase it is not initialized in scsi_host_template. It looks like: [root@localhost ~]# cat /sys/class/scsi_host/host2/proc_name (null)

[PATCH] scsi: hisi_sas: display correct proc_name in sysfs

scsi_host/host0/proc_name megaraid_sas Cc: John Garry Cc: Xiang Chen Signed-off-by: Jason Yan --- drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 1 + drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 1 + 3 files changed, 3 insertions(+) diff --git a/drivers/scsi/

[tip: core/rcu] rcutorture: Make rcu_fwds and rcu_fwd_emergency_stop static

The following commit has been merged into the core/rcu branch of tip: Commit-ID: afbc1574f1da13d2fd2b30a96090b37c5933f957 Gitweb: https://git.kernel.org/tip/afbc1574f1da13d2fd2b30a96090b37c5933f957 Author:Jason Yan AuthorDate:Thu, 09 Apr 2020 19:42:38 +08:00 Committer

Re: [PATCH] scsi: libsas: Replace zero-length array with flexible-array

undefined behaviour") Signed-off-by: Gustavo A. R. Silva Reviewed-by: Jason Yan

Re: [PATCH] drm/panel: visionox-rm69299: Add module license

在 2020/5/9 14:36, Randy Dunlap 写道: On 5/8/20 11:30 PM, Jason Yan wrote: Fix the following build warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-visionox-rm69299.o see include/linux/module.h for more information Signed-off-by: Jason Yan --- drivers/gpu

[PATCH] drm/panel: visionox-rm69299: Add module license

Fix the following build warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-visionox-rm69299.o see include/linux/module.h for more information Signed-off-by: Jason Yan --- drivers/gpu/drm/panel/panel-visionox-rm69299.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH] drm/amd/amdgpu: remove defined but not used 'crtc_offsets'

Fix the following gcc warning: drivers/gpu/drm/amd/amdgpu/gmc_v6_0.c:65:18: warning: ‘crtc_offsets’ defined but not used [-Wunused-const-variable=] static const u32 crtc_offsets[6] = ^~~~ Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/gpu/drm/amd

[PATCH net-next] igb: make igb_set_fc_watermarks() return void

This function always return 0 now, we can make it return void to simplify the code. This fixes the following coccicheck warning: drivers/net/ethernet/intel/igb/e1000_mac.c:728:5-12: Unneeded variable: "ret_val". Return "0" on line 751 Signed-off-by: Jason Yan --- drivers/ne

[PATCH net-next] net: encx24j600: make encx24j600_hw_init() return void

This function always return 0 now, we can make it return void to simplify the code. This fixes the following coccicheck warning: drivers/net/ethernet/microchip/encx24j600.c:609:5-8: Unneeded variable: "ret". Return "0" on line 653 Signed-off-by: Jason Yan --- drivers/ne

[PATCH net-next] net: tulip: de4x5: make PCI_signature() return void

This function always return 0 now, we can make it return void to simplify the code. This fixes the following coccicheck warning: drivers/net/ethernet/dec/tulip/de4x5.c:3908:11-17: Unneeded variable: "status". Return "0" on line 3912 Signed-off-by: Jason Yan --- drivers/ne

[PATCH net-next] net: atheros: remove dead code in atl1c_resume()

This code has been marked dead for nearly 10 years. Remove it. Signed-off-by: Jason Yan --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c

[PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_ethtool_add_mac_rule()

Fix the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1396:5-8: Unneeded variable: "err". Return "0" on line 1411 Signed-off-by: Jason Yan --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[PATCH] drm/vmwgfx: Return true in function vmw_fence_obj_signaled()

Fix the following coccicheck warning: drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:518:9-10: WARNING: return of 0/1 in function 'vmw_fence_obj_signaled' with return type bool Signed-off-by: Jason Yan --- drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH] USB: Remove dead code in usb_choose_configuration()

This code is dead for more than 10 years. Remove it. Signed-off-by: Jason Yan --- drivers/usb/core/generic.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/usb/core/generic.c b/drivers/usb/core/generic.c index 4626227a6dd2..1c93192fc136 100644 --- a/drivers/usb/core/generic.c

[PATCH] b43: remove dead function b43_rssinoise_postprocess()

This function is dead for more than 10 years. Remove it. Signed-off-by: Jason Yan --- drivers/net/wireless/broadcom/b43/xmit.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/net/wireless/broadcom/b43/xmit.c b/drivers/net/wireless/broadcom/b43/xmit.c index

[PATCH] kgdb: Return true in kgdb_nmi_poll_knock()

Fix the following coccicheck warning: include/linux/kgdb.h:301:54-55: WARNING: return of 0/1 in function 'kgdb_nmi_poll_knock' with return type bool Signed-off-by: Jason Yan --- include/linux/kgdb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linu

[PATCH] drm/amd/display: remove variable "result" in dcn20_patch_unknown_plane_state()

Fix the following coccicheck warning: drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c:3216:16-22: Unneeded variable: "result". Return "DC_OK" on line 3229 Signed-off-by: Jason Yan --- drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 4 +--- 1 file change

[PATCH] ata: return true in ata_is_host_link()

Fix the following coccicheck warning: include/linux/libata.h:1446:8-9: WARNING: return of 0/1 in function 'ata_is_host_link' with return type bool Signed-off-by: Jason Yan --- include/linux/libata.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/

[PATCH] sched/fair: Return true,false in voluntary_active_balance()

Fix the following coccicheck warning: kernel/sched/fair.c:9375:9-10: WARNING: return of 0/1 in function 'voluntary_active_balance' with return type bool Signed-off-by: Jason Yan --- kernel/sched/fair.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ke

Re: [PATCH] MIPS: Lasat: Remove dead code in lasat.h

在 2020/5/7 16:38, Thomas Bogendoerfer 写道: On Wed, May 06, 2020 at 09:42:58PM +0800, Jason Yan wrote: This code has been marked dead for more than 10 years. Seems no need to keep it now. Signed-off-by: Jason Yan --- arch/mips/include/asm/lasat/lasat.h | 5 - 1 file changed, 5

[PATCH v2] bpf, i386: remove unneeded conversion to bool

re Signed-off-by: Jason Yan --- v2: change the name 'x32' to 'i386'. arch/x86/net/bpf_jit_comp32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/x86/net/bpf_jit_comp32.c b/arch/x86/net/bpf_jit_comp32.c index 66cd150b7e54..96fde03a

[PATCH] MIPS: Octeon: Remove dead code in __cvmx_helper_npi_probe()

This code has been marked dead for more than 10 years. Seems no need to keep it now. Signed-off-by: Jason Yan --- arch/mips/cavium-octeon/executive/cvmx-helper-npi.c | 12 1 file changed, 12 deletions(-) diff --git a/arch/mips/cavium-octeon/executive/cvmx-helper-npi.c b/arch/mips

[PATCH] MIPS: Remove dead code in pci.h

This code has been marked dead for more than 10 years. Seems no need to keep it now. Signed-off-by: Jason Yan --- arch/mips/include/asm/mach-rc32434/pci.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/mips/include/asm/mach-rc32434/pci.h b/arch/mips/include/asm/mach-rc32434/pci.h

[PATCH] MIPS: Lasat: Remove dead code in lasat.h

This code has been marked dead for more than 10 years. Seems no need to keep it now. Signed-off-by: Jason Yan --- arch/mips/include/asm/lasat/lasat.h | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/mips/include/asm/lasat/lasat.h b/arch/mips/include/asm/lasat/lasat.h index

[PATCH] MIPS: CFE: Remove dead code in cfe_getfwinfo()

This code has been marked dead since the beginning of the git history. Seems no need to keep it now. Signed-off-by: Jason Yan --- arch/mips/fw/cfe/cfe_api.c | 5 - 1 file changed, 5 deletions(-) diff --git a/arch/mips/fw/cfe/cfe_api.c b/arch/mips/fw/cfe/cfe_api.c index c020b29f561c

Re: [PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

在 2020/5/6 16:29, Russell King - ARM Linux admin 写道: On Wed, May 06, 2020 at 02:19:00PM +0800, Jason Yan wrote: Fix the following coccicheck warning: arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 NAK. Look closer at what the c

[PATCH] dma-buf: heaps: Remove Unneeded variable "ret" in dma_heap_dma_buf_begin_cpu_access()

Fix the following coccicheck warning: drivers/dma-buf/heaps/heap-helpers.c:203:5-8: Unneeded variable: "ret". Return "0" on line 216 Signed-off-by: Jason Yan --- drivers/dma-buf/heaps/heap-helpers.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/d

[PATCH] spi: a3700: make a3700_spi_init() return void

Fix the following coccicheck warning: drivers/spi/spi-armada-3700.c:283:8-11: Unneeded variable: "ret". Return "0" on line 315 Signed-off-by: Jason Yan --- drivers/spi/spi-armada-3700.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/s

[PATCH] ARM: OMAP2+: remove unneeded variable "errata" in configure_dma_errata()

Fix the following coccicheck warning: arch/arm/mach-omap2/dma.c:82:10-16: Unneeded variable: "errata". Return "0" on line 161 Signed-off-by: Jason Yan --- arch/arm/mach-omap2/dma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/arm/mach-omap2/d

[PATCH net-next] i40e: Make i40e_shutdown_adminq() return void

Fix the following coccicheck warning: drivers/net/ethernet/intel/i40e/i40e_adminq.c:699:13-21: Unneeded variable: "ret_code". Return "0" on line 710 Signed-off-by: Jason Yan --- drivers/net/ethernet/intel/i40e/i40e_adminq.c| 6 +- drivers/net/ethernet/intel/i40e/

[PATCH] video: fbdev: pxa168fb: make pxa168fb_init_mode() return void

No other functions use the return value of pxa168fb_init_mode() and the return value is always 0 now. Make it return void. This fixes the following coccicheck warning: drivers/video/fbdev/pxa168fb.c:565:5-8: Unneeded variable: "ret". Return "0" on line 597 Signed-off-by: Jas

[PATCH] scsi: qla2xxx: make qlafx00_process_aen() return void

No other functions use the return value of qlafx00_process_aen() and the return value is always 0 now. Make it return void. This fixes the following coccicheck warning: drivers/scsi/qla2xxx/qla_mr.c:1716:5-9: Unneeded variable: "rval". Return "0" on line 1768 Sign

[PATCH] tty: mxser: make mxser_change_speed() return void

No other functions use the return value of mxser_change_speed() and the return value is always 0 now. Make it return void. This fixes the following coccicheck warning: drivers/tty/mxser.c:645:5-8: Unneeded variable: "ret". Return "0" on line 650 Signed-off-by: Jason Yan ---

[PATCH] ALSA: hda: Return true,false for return type bool

Fix the following coccicheck warning: include/sound/hdaudio.h:210:73-74: WARNING: return of 0/1 in function 'snd_hdac_is_in_pm' with return type bool include/sound/hdaudio.h:211:76-77: WARNING: return of 0/1 in function 'snd_hdac_is_power_on' with return type bool Sign

[PATCH] regulator: db8500-prcmu: Use true,false for bool variable

Fix the following coccicheck warning: drivers/regulator/db8500-prcmu.c:184:1-17: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/regulator/db8500-prcmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/db8500-prcmu.c b

[PATCH] sparc: mm: return true,false in kern_addr_valid()

This function's return type is bool and returns both true/false and 0/1. This fixes the following coccicheck warning: arch/sparc/mm/init_64.c:1652:9-10: WARNING: return of 0/1 in function 'kern_addr_valid' with return type bool Signed-off-by: Jason Yan --- arch/sparc/mm

[PATCH net-next] net: mlx4: remove unneeded variable "err" in mlx4_en_get_rxfh()

Fix the following coccicheck warning: drivers/net/ethernet/mellanox/mlx4/en_ethtool.c:1238:5-8: Unneeded variable: "err". Return "0" on line 1252 Signed-off-by: Jason Yan --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 3 +-- 1 file changed, 1 insertion(+), 2 deleti

[PATCH net-next] net: bridge: return false in br_mrp_enabled()

Fix the following coccicheck warning: net/bridge/br_private.h:1334:8-9: WARNING: return of 0/1 in function 'br_mrp_enabled' with return type bool Signed-off-by: Jason Yan --- net/bridge/br_private.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/bridge/br_p

[PATCH net-next] net: ethernet: ti: use true,false for bool variables in cpsw_new.c

Fix the following coccicheck warning: drivers/net/ethernet/ti/cpsw_new.c:1924:2-17: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/ti/cpsw_new.c:1231:1-16: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/ti/cpsw_new.c | 4 ++-- 1

[PATCH net-next] net: atheros: remove conversion to bool in atl1c_start_mac()

No need to convert '==' expression to bool. This fixes the following coccicheck warning: drivers/net/ethernet/atheros/atl1c/atl1c_main.c:1189:63-68: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- 1 fi

[PATCH net-next] net: agere: use true,false for bool variable

Fix the following coccicheck warning: drivers/net/ethernet/agere/et131x.c:717:3-22: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/agere/et131x.c:721:1-20: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/agere/et131x.c | 4 ++-- 1

[PATCH net-next] net: bnxt: Remove Comparison to bool in bnxt_ethtool.c

to bool Signed-off-by: Jason Yan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index 34046a6286e8..75f60aea8dec

[PATCH net-next] net: qede: Use true for bool variable in qede_init_fp()

Fix the following coccicheck warning: drivers/net/ethernet/qlogic/qede/qede_main.c:1717:5-19: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/qlogic/qede/qede_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next] qlcnic: use true,false for bool variable in qlcnic_sriov_common.c

Fix the following coccicheck warning: drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1585:3-25: WARNING: Assignment of 0/1 to bool variable drivers/net/ethernet/qlogic/qlcnic/qlcnic_sriov_common.c:1588:3-25: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan

[PATCH net-next] bnx2x: Remove Comparison to bool in bnx2x_dcb.c

bool Signed-off-by: Jason Yan --- drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.c index 2c6ba046d2a8..17ae6df90723 100644

[PATCH net-next] ixgbe: Use true,false for bool variable in __ixgbe_enable_sriov()

Fix the following coccicheck warning: drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c:105:2-38: WARNING: Assignment of 0/1 to bool variable Signed-off-by: Jason Yan --- drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net

[PATCH net-next] ixgbe: Remove conversion to bool in ixgbe_device_supports_autoneg_fc()

No need to convert '==' expression to bool. This fixes the following coccicheck warning: drivers/net/ethernet/intel/ixgbe/ixgbe_common.c:68:11-16: WARNING: conversion to bool not needed here Signed-off-by: Jason Yan --- drivers/net/ethernet/intel/ixgbe/ixgbe_common.c | 3 +-- 1 file

[PATCH] scsi: bfa: make bfad_iocmd_ioc_get_stats() static

Fix the following sparse warning: drivers/scsi/bfa/bfad_bsg.c:140:1: warning: symbol 'bfad_iocmd_ioc_get_stats' was not declared. Should it be static? Reported-by: Hulk Robot Signed-off-by: Jason Yan --- drivers/scsi/bfa/bfad_bsg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

  1   2   3   4   >