Re: [PATCH] kgdb: fix gcc-11 warning on indentation

2021-03-22 Thread Jason Wessel
On 3/22/21 2:22 PM, Doug Anderson wrote: Hi, On Mon, Mar 22, 2021 at 11:19 AM Arnd Bergmann wrote: On Mon, Mar 22, 2021 at 6:07 PM Doug Anderson wrote: On Mon, Mar 22, 2021 at 9:43 AM Arnd Bergmann wrote: -#define v1printk(a...) do { \ - if (verbose) \ - printk(KER

Re: [PATCH] kgdb: Remove kgdb_schedule_breakpoint()

2021-02-10 Thread Jason Wessel
stage it looks better to stop carrying this code in the kernel and integrate the code into the out-of-tree driver instead. Because it has no in tree users, it absolutely makes the most sense to purge this function. Acked-by: Jason Wessel The long term trajectory for the kernel looks likely to in

Re: [PATCH] gdbstub: mark expected switch fall-throughs

2019-02-26 Thread Jason Wessel
We'll have to fix them at some point. Acked-by: Jason Wessel Cheers, Jason. On 2/26/19 1:16 PM, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: kernel/

Re: [PATCH] kdb: use correct pointer when 'btc' calls 'btt'

2018-10-01 Thread Jason Wessel
On 09/28/2018 07:57 AM, Michael Ellerman wrote: Christophe LEROY writes: Le 27/09/2018 à 13:09, Michael Ellerman a écrit : Christophe LEROY writes: Le 26/09/2018 à 13:11, Daniel Thompson a écrit : The Fixes: and now your Reviewed-by: appear automatically in patchwork (https://patchwork.ozla

[GIT PULL] KGDB/KDB fixes for 4.16

2018-04-12 Thread Jason Wessel
Linus, Please pull the kgdb tree. Summary of changes: * Fix 2032 time access issues and new compiler warnings * minor regression test cleanup * formatting fixes for end user use of kdb git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git tags/for_linus-4.16 Thanks, Jason. -

Re: [PATCH] kdb: use memmove instead of overlapping memcpy

2018-02-02 Thread Jason Wessel
_name_table+i, kdb_name_table+i+1, + memmove(kdb_name_table+i, kdb_name_table+i+1, sizeof(kdb_name_table[0]) * (ARRAY_SIZE(kdb_name_table)-i-1)); } That is good by me. Many thanks! Added to queue. Reviewed-by: Jason Wessel Jason.

Re: [PATCH v2] kdb: use ktime_get_mono_fast_ns() instead of ktime_get_ts()

2018-01-30 Thread Jason Wessel
On 01/30/2018 07:35 AM, Arnd Bergmann wrote: On Mon, Jan 29, 2018 at 3:22 AM, Baolin Wang wrote: The kdb code will print the monotonic time by ktime_get_ts(), but the ktime_get_ts() will be protected by a sequence lock, that will introduce one deadlock risk if the lock was already held in the c

Re: [PATCH] kdb: use ktime_get_seconds() instead of ktime_get_ts()

2018-01-25 Thread Jason Wessel
is only interested in the second field, we can use the ktime_get_seconds() to get the monotonic time without a lock, moreover we can remove the 'struct timespec', which is not y2038 safe. Signed-off-by: Baolin Wang Acked-by: Jason Wessel Thanks.   Added to the kgdb-next branch fo

Re: [PATCH] kdb: Change timespec to use timespec64

2018-01-25 Thread Jason Wessel
On 01/25/2018 05:38 AM, Daniel Thompson wrote: On Thu, Jan 25, 2018 at 05:18:54PM +0800, Baolin Wang wrote: On 25 January 2018 at 16:55, Arnd Bergmann wrote: On Thu, Jan 25, 2018 at 9:05 AM, Baolin Wang wrote: @@ -2554,7 +2554,7 @@ static int kdb_summary(int argc, const char **argv)

Re: [PATCH] misc: kgdbts: Display progress of asynchronous tests

2017-12-14 Thread Jason Wessel
On 12/12/2017 06:10 AM, Daniel Thompson wrote: kgdbts includes a couple of different "thrashing" style tests that may have long runtimes (especially on simulated platforms) and which run asynchronously. This is uncomfortable for interactive use and makes setting timeouts tricky for automatic use.

Re: [PATCH 2/3] kdb: drop newline in unknown command output

2017-12-08 Thread Jason Wessel
, including the newline character. This causes the ending single-quote mark to be printed on the next line by itself, so just change the ending newline character to a null character (end of string) so that it won't be "printed." Signed-off-by: Randy Dunlap Cc: Daniel Thompson Cc:

Re: [PATCH 2/2] kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson

2017-12-06 Thread Jason Wessel
On 12/06/2017 06:52 PM, Randy Dunlap wrote: On 12/06/2017 02:33 PM, Jason Wessel wrote: L:kgdb-bugrep...@lists.sourceforge.net T:git git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git I would urge you to move to a different mailing list server. No argument here

Re: [Kgdb-bugreport] [PATCH] MAINTAINERS: kgdb: Replace Jason with Daniel

2017-12-06 Thread Jason Wessel
On 12/05/2017 10:42 AM, Randy Dunlap wrote: On 12/05/2017 06:55 AM, Daniel Thompson wrote: On 05/12/17 14:37, Jason Wessel wrote: I have a series of 50+ patches for kgdb/kdb/usb which have never been published.  I am not saying that we actually need any of those patches, but it would be nice

[GIT PULL] KGDB/KDB fixes for 4.15-rc2

2017-12-06 Thread Jason Wessel
Daniel Thompson (1): kdb: Fix handling of kallsyms_symbol_next() return value Jason Wessel (1): kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson MAINTAINERS | 1 + kernel/debug/kdb/kdb_io.c | 2 +- 2 files changed

[PATCH 1/2] kdb: Fix handling of kallsyms_symbol_next() return value

2017-12-06 Thread Jason Wessel
a WARN_ON(). Reported-by: Dan Carpenter Signed-off-by: Daniel Thompson Cc: linux-stable Signed-off-by: Jason Wessel --- kernel/debug/kdb/kdb_io.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c index e74be38..ed5d349

[PATCH 2/2] kgdb/kdb/debug_core: Add co-maintainer Daniel Thompson

2017-12-06 Thread Jason Wessel
Signed-off-by: Jason Wessel --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 2811a21..74be63b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7659,6 +7659,7 @@ F:security/keys/ KGDB / KDB /debug_core M: Jason Wessel +M

Re: [PATCH] kdb: use __ktime_get_real_seconds instead of __current_kernel_time

2017-12-06 Thread Jason Wessel
ifference was that I added a comment about the __ktime_get_real_seconds() not taking the lock because it was done that way in other places in the header file. === extern time64_t ktime_get_real_seconds(void); +/* does not take xtime_lock */ +extern time64_t __ktime_get_real_seconds(void);

Re: [PATCH] kdb: use __ktime_get_real_seconds instead of __current_kernel_time

2017-12-06 Thread Jason Wessel
On 10/13/2017 03:26 AM, Daniel Thompson wrote: On 12/10/17 23:40, Andrew Morton wrote: On Thu, 12 Oct 2017 16:06:11 +0200 Arnd Bergmann wrote: kdb is the only user of the __current_kernel_time() interface, which is not y2038 safe and should be removed at some point. The kdb code also goes to

Re: [Kgdb-bugreport] [PATCH] MAINTAINERS: kgdb: Replace Jason with Daniel

2017-12-05 Thread Jason Wessel
On 12/05/2017 08:09 AM, Lee Jones wrote: On Tue, 05 Dec 2017, Daniel Thompson wrote: ... with many, many thanks for Jason for all his hard work. Cc: Jason Wessel Signed-off-by: Daniel Thompson --- Notes: Over the years Jason has become increasingly hard to get hold off and I

Re: [BUG] kgdb/ftrace - sleeping in invalid context

2016-11-17 Thread Jason Wessel
On 11/17/2016 01:16 PM, Brian Norris wrote: Hi, I've been poking around KGDB, and I noticed that the KDB 'ftdump' command (to dump ftrace logs) produces warnings like this: (gdb) monitor ftdump Dumping ftrace buffer: BUG: sleeping function called from invalid context at mm/slab.h:359 in_atomic(

Re: [RESEND PATCH] arm64: kgdb: fix single stepping

2016-09-19 Thread Jason Wessel
On 09/15/2016 11:32 PM, AKASHI Takahiro wrote: @@ -176,18 +183,14 @@ int kgdb_arch_handle_exception(int exception_vector, int signo, * over and over again. */ kgdb_arch_update_addr(linux_regs, remcom_in_buffer); - atomic_set(&kgdb_

Re: [RESEND PATCH] arm64: kgdb: fix single stepping

2016-09-19 Thread Jason Wessel
On 09/16/2016 02:45 AM, Will Deacon wrote: On Fri, Sep 16, 2016 at 01:32:19PM +0900, AKASHI Takahiro wrote: On Thu, Sep 15, 2016 at 08:04:57AM -0500, Jason Wessel wrote: I added the patch to kgdb-next after fixing up the context since it no longer applied to the mainline ( https

Re: [RESEND PATCH] arm64: kgdb: fix single stepping

2016-09-15 Thread Jason Wessel
On 04/20/2015 08:13 PM, AKASHI Takahiro wrote: Jason, Could you please review my patch below? See also arm64 maintainer's comment: http://lists.infradead.org/pipermail/linux-arm-kernel/2015-January/313712.html Thanks, -Takahiro AKASHI I tried to verify kgdb in vanilla kernel on fast model, but

Re: [RESEND PATCH] arm64: kgdb: fix single stepping

2016-09-15 Thread Jason Wessel
On 09/15/2016 05:41 AM, Daniel Thompson wrote: On 15/09/16 08:56, AKASHI Takahiro wrote: On Wed, Sep 14, 2016 at 03:58:51PM +0100, Will Deacon wrote: Hi Akashi, On Tue, Apr 21, 2015 at 02:13:13AM +0100, AKASHI Takahiro wrote: Could you please review my patch below? See also arm64 maintainer's

Re: linux-next: removal of the kgdb tree

2016-09-15 Thread Jason Wessel
On 03/08/2016 11:16 PM, Stephen Rothwell wrote: Hi Jason, I noticed that the kgdb tree git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git branch kgdb-next has not been updated since March 2015. I am going to remove it from linux-next tomorrow unless I hear that it may be useful

Re: [PATCH -repost] kgdb: depends on VT

2016-03-31 Thread Jason Wessel
5d5): undefined reference to `vc_cons' kgdboc.o is built when KGDB_SERIAL_CONSOLE is set. So make KGDB_SERIAL_CONSOLE depend on HW_CONSOLE which includes those symbols. Acked-by: Jason Wessel I'll put this in the kgdb-next branch and submit it to the upstream, unless it gets merged

Re: [PATCH 4/4] drivers/misc: make kgdbts.c slightly more explicitly non-modular

2015-08-10 Thread Jason Wessel
worked to show there is a problem. :-) Acked-by: Jason Wessel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] kdb: Fix handling of kallsyms_symbol_next() return value

2015-03-02 Thread Jason Wessel
On 03/02/2015 08:13 AM, Daniel Thompson wrote: > kallsyms_symbol_next() returns a boolean (true on success). Currently > kdb_read() tests the return value with an inequality that > unconditionally evaluates to true. > > This is fixed in the obvious way and, since the conditional branch is > suppos

[GIT PULL] KGDB/KDB fixes for 3.20-rc1

2015-02-19 Thread Jason Wessel
kdb_getstr's prompt argument Jason Wessel (1): kdb: Fix off by one error in kdb_cpu() Jay Lan (1): kdb: fix incorrect counts in KDB summary command output Rajaneesh Acharya (1): kgdb, docs: Fix pdfdocs build errors Documentation/DocBook/kgdb.tmpl | 6 +++--- include/linux/

[GIT PULL] KGDB/KDB fixes for 3.19-rc4

2015-01-08 Thread Jason Wessel
Linus, Please pull the kgdb tree bug fixes. These have been around since 3.17 and in kgdb-next for the last 9 weeks and some will go back to -stable. Summary of changes: KGDB/KDB fixes and cleanups Cleanups kdb: Remove unused command flags, repeat flags and KDB_REPEAT_NONE Fixes kgdb/k

Re: kgdb-next not pushed to Linus for 3.19

2015-01-06 Thread Jason Wessel
On 01/06/2015 03:21 PM, Andrew Morton wrote: > On Tue, 06 Jan 2015 10:57:42 -0800 Joe Perches wrote: > >> On Tue, 2015-01-06 at 18:54 +, Daniel Thompson wrote: >>> Hi Jason >>> >>> I'm trying to figure out what to do with my long-outstanding kgdb/kdb >>> patches in preparation for the 3.20 mer

Re: [RESEND PATCH v5 3.16-rc4 0/8] kdb: Allow selective reduction in capabilities

2014-07-11 Thread Jason Wessel
On 07/11/2014 06:33 AM, Daniel Thompson wrote: > This patchset implements restricted modes for the KDB debugger. It is a > continuation of previous work of Anton Vorontsov. There are no > outstanding review comments for this patchset. > > It provides a means for the root user to choose the set of k

Re: [RFC PATCH] kgdb: Timeout if secondary CPUs ignore the roundup

2014-07-01 Thread Jason Wessel
On 07/01/2014 09:16 AM, Daniel Thompson wrote: > Currently if an active CPU fails to respond to a roundup request the > CPU that requested the roundup will become stuck. This needlessly > reduces the robustness of the debugger. > > This patch introduces a timeout allowing the system state to be exa

Re: [PATCH 1/1] kernel/debug/debug_core.c: Logging clean-up

2014-06-12 Thread Jason Wessel
On 06/12/2014 01:48 PM, Fabian Frederick wrote: > -Convert printk( to pr_foo() > -Add pr_fmt > -Coalesce formats > > Cc: Jason Wessel > Cc: Andrew Morton > Signed-off-by: Fabian Frederick Thanks. I looked through all the bits to make sure there were no cases were we reli

Re: [PATCH 1/4] serial: core: Consistent LF handling for poll_put_char

2014-05-14 Thread Jason Wessel
On 05/14/2014 09:55 AM, Daniel Thompson wrote: > The behaviour of the UART poll_put_char infrastructure is inconsistent > with respect to linefeed conversions. This in turn leads to difficulty > using kdb on serial ports that are not also consoles > (e.g. console=ttyAMA0,115200 kgdboc=ttyAMA1,11520

Re: [PATCH 5/7] KGDB/KDB: add support for external NMI handler to call KGDB/KDB.

2013-09-26 Thread Jason Wessel
gt; Reviewed-by: Dimitri Sivanich > Reviewed-by: Hedi Berriche One problem that I pointed out before and then you can add Acked-by: Jason Wessel > --- > include/linux/kdb.h |1 + > include/linux/kgdb.h|1 + > kernel/debug/debug_core.c | 30

Re: [PATCH 7/9] KGDB/KDB: add new system NMI entry code to KDB

2013-09-05 Thread Jason Wessel
On 09/05/2013 05:50 PM, Mike Travis wrote: > This patch adds a new "KDB_REASON" code (KDB_REASON_SYSTEM_NMI). This > is purely cosmetic to distinguish it from the other various reasons that > NMI may occur and are usually after an error occurred. Also the dumping > of registers is not done to mor

Re: [PATCH 5/9] KGDB/KDB: add support for external NMI handler to call KGDB/KDB.

2013-09-05 Thread Jason Wessel
On 09/05/2013 05:50 PM, Mike Travis wrote: > This patch adds a kgdb_nmicallin() interface that can be used by > external NMI handlers to call the KGDB/KDB handler. The primary need > for this is for those types of NMI interrupts where all the CPUs > have already received the NMI signal. Therefore

[tip:perf/core] perf machine: Do not require /lib/modules/ * on a guest

2013-08-12 Thread tip-bot for Jason Wessel
Commit-ID: 8f76fcd902e3b3a7d6f6c695cc8bc053579eb179 Gitweb: http://git.kernel.org/tip/8f76fcd902e3b3a7d6f6c695cc8bc053579eb179 Author: Jason Wessel AuthorDate: Mon, 15 Jul 2013 15:27:53 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 7 Aug 2013 17:35:41 -0300 perf machine

[PATCH] perf: Do not require /lib/modules/* on a guest

2013-07-15 Thread Jason Wessel
kvm report that has no guest symbols resolved. This patch changes the failure to locate kernel modules to be non-fatal. Signed-off-by: Jason Wessel --- tools/perf/util/machine.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util

Re: kdb: kgdb: CONFIG_DEBUG_RODATA setting?

2013-04-09 Thread Jason Wessel
On 04/09/2013 08:06 AM, Sedat Dilek wrote: > config DEBUG_RODATA > bool "Write protect kernel read-only data structures" > - default y > depends on DEBUG_KERNEL > + default n if KGDB > + default y > ---help--- > Mark the kernel read-only data as write-protect

Re: [PATCH 03/15] KDB: up the default LINES value

2013-03-25 Thread Jason Wessel
On 03/25/2013 01:50 PM, Mike Travis wrote: > Currently the default for the # of lines displayed by the KDB pager > is 24. This does not allow all of the lines for the entry messages, > reg dump and process trace. Increase it to something more reasonable. > Unfortunately this is something that

Re: [PATCH 01/15] KDB: fix the interrupt of the KDB btc command

2013-03-25 Thread Jason Wessel
On 03/25/2013 01:50 PM, Mike Travis wrote: > The KDB 'btc' (backtrace cpus) command ignores the 'quit' reply > to the 'more>' prompt. This is quite annoying when you have a > large number of processors and thousands of lines are being > printed. This fixes that problem. > Merged to kgdb-next an

Re: [PATCH 07/13] tracing/kdb: remove redundant checking

2013-03-11 Thread Jason Wessel
On 03/11/2013 09:09 AM, Steven Rostedt wrote: > This is Jason's code. > > Jason, please give an Ack or Nack. > > Thanks, > > -- Steve > > > On Mon, 2013-03-11 at 15:13 +0800, zhangwei(Jovi) wrote: >> trace_empty is checking in while-loop, so the previous checking >> is totally redundant, and more w

[PATCH] menuconfig,check-lxdiaglog.sh: Allow specification of ncurses location

2013-03-03 Thread Jason Wessel
ES_LIB and CROSS_CURSES_INC solves the issue and allowing compiling and linking against the right headers and libraries. Signed-off-by: Jason Wessel cc: Michal Marek cc: linux-kbu...@vger.kernel.org --- scripts/kconfig/lxdialog/check-lxdialog.sh |8 1 file changed, 8 insertions(+) diff --git

[GIT PULL] KGDB/KDB fixes for 3.9

2013-03-02 Thread Jason Wessel
lp command truncated text ppc64 support for kgdbts Add missing kconfig option from original kdb port for dealing with catastrophic kernel crashes such that you can reboot automatically on continue from kdb ---- Jason W

Re: [PATCH] powerpc: kernel/kgdb.c: fix memory leakage

2013-01-31 Thread Jason Wessel
On 01/14/2013 11:26 AM, Cong Ding wrote: > the variable backup_current_thread_info isn't freed before existing the > function. > > Signed-off-by: Cong Ding > --- > arch/powerpc/kernel/kgdb.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/kgd

Re: [PATCH v2 57/76] ARC: kgdb support

2013-01-18 Thread Jason Wessel
On 01/18/2013 07:31 AM, Vineet Gupta wrote: > On Friday 18 January 2013 06:45 PM, Jason Wessel wrote: >> On 01/18/2013 06:25 AM, Vineet Gupta wrote: >>> From: Mischa Jonker >>> >>> Signed-off-by: Mischa Jonker >>> Signed-off-by: Vineet Gupta &g

Re: [PATCH v2 57/76] ARC: kgdb support

2013-01-18 Thread Jason Wessel
On 01/18/2013 06:25 AM, Vineet Gupta wrote: > From: Mischa Jonker > > Signed-off-by: Mischa Jonker > Signed-off-by: Vineet Gupta > Cc: Jason Wessel Acked-by: Jason Wessel > --- > arch/arc/Kconfig|3 +- > arch/arc/include/asm/kgdb.h | 61

Re: [PATCH 003/193] Documentation: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Jason Wessel
On 10/23/2012 03:01 PM, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > Works for me. Acked-by: Jason Wessel Cheers, Jason. -- To unsubscribe fr

[GIT PULL] KGDB/KDB fixes for 3.7

2012-10-12 Thread Jason Wessel
a kernel module Allow kgdboc=kdb to setup kdb on the vga console Arnd Bergmann (1): tty/console: fix warnings in drivers/tty/serial/kgdboc.c Jason Wessel (6): kgdb: Add module event hooks mips,kgdb: fix recursive

Re: [PATCH 09/12] tty/console: fix warnings in drivers/tty/serial/kgdboc.c

2012-09-28 Thread Jason Wessel
r': > drivers/tty/serial/kgdboc.c:293:3: warning: statement with no effect > [-Wunused-value] Thanks Arnd! I'll put this in kgdb-next for the upcoming merge window, unless Greg pulls it into his queue first. Acked-by: Jason Wessel Cheers, Jason. -- To unsubscribe from this list: s

Re: [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger

2012-09-24 Thread Jason Wessel
On 09/20/2012 08:40 AM, Jason Wessel wrote: > On 09/19/2012 06:40 PM, Anton Vorontsov wrote: >> Hi all, >> >> In v8, addressed Jason's comments: >> >> - Changed kgdb_enable_nmi() weak function to kgdb_arch callbck; >> - We no longer register disable_nmi

3.4.5 regression kernel oops in mount attempt without lockd present

2012-09-22 Thread Jason Wessel
Greg, In 3.4.5, a regression was introduced from commit: ee92389156 "SUNRPC: move per-net operations from svc_destroy()". This regression was actually fixed in a later upstream patch in v3.5-rc1, specifically 4db77695bf5 "LockD: pass service to per-net up and down functions", which means there

Re: [PATCH] kgdb: Fix warning with !CONFIG_DEBUG_RODATA

2012-09-21 Thread Jason Wessel
efined. > This is already pending along with other fixes in kgdb-next / linux next for the 3.7 merge window. Jason. -- commit 9a15c35d16cf76482be076125f631f1193e29413 Author: Jason Wessel Date: Wed Aug 8 21:12:19 2012 -0500 kgdb,x86: fix warning about unused variable When compili

Re: [PATCH 07/11] tty/serial: Add kgdb_nmi driver

2012-09-20 Thread Jason Wessel
On 09/19/2012 06:41 PM, Anton Vorontsov wrote: > This special driver makes it possible to temporary use NMI debugger port > as a normal console by issuing 'nmi_console' command (assuming that the > port is attached to KGDB). > The kgdb regression compiler also does checkpatch, so the "check patc

Re: [PATCH v8 0/11] KGDB/KDB FIQ (NMI) debugger

2012-09-20 Thread Jason Wessel
On 09/19/2012 06:40 PM, Anton Vorontsov wrote: > Hi all, > > In v8, addressed Jason's comments: > > - Changed kgdb_enable_nmi() weak function to kgdb_arch callbck; > - We no longer register disable_nmi command if arch does not register > KGDB NMI handling (i.e. not filling kgdb_arch.enable_nmi ca

Re: [PATCH v7 0/11] KGDB/KDB FIQ (NMI) debugger

2012-09-19 Thread Jason Wessel
series, and it depends on >> amba-pl1011 and tty_port work, which is in tty-next. >> >> So, the series have to go via tty-next; I believe Jason won't able >> to take it via his tree. > Ok, I'll wait for Jason to review them. Jason, let me know how it > goes..

Re: [PATCH 07/11] tty/serial: Add kgdb_nmi driver

2012-09-19 Thread Jason Wessel
On 09/13/2012 10:03 AM, Anton Vorontsov wrote: > This special driver makes it possible to temporary use NMI debugger port > as a normal console by issuing 'nmi_console' command (assuming that the > port is attached to KGDB). > > Unlike KDB's disable_nmi command, with this driver you are always abl

Re: [PATCH 02/11] kdb: Implement disable_nmi command

2012-09-19 Thread Jason Wessel
On 09/13/2012 10:03 AM, Anton Vorontsov wrote: > This command disables NMI-entry. If NMI source has been previously shared > with a serial console ("debug port"), this effectively releases the port > from KDB exclusive use, and makes the console available for normal use. > > Of course, NMI can be

Re: [PATCH 01/11] kernel/debug: Mask KGDB NMI upon entry

2012-09-19 Thread Jason Wessel
On 09/13/2012 10:03 AM, Anton Vorontsov wrote: > The new arch callback should manage NMIs that usually cause KGDB to > enter. That is, not all NMIs should be enabled/disabled, but only > those that issue kgdb_handle_exception(). > > We must mask it as serial-line interrupt can be used as an NMI, s

Re: [PATCH v7 0/11] KGDB/KDB FIQ (NMI) debugger

2012-09-17 Thread Jason Wessel
On 09/17/2012 06:37 AM, Greg Kroah-Hartman wrote: > On Thu, Sep 13, 2012 at 08:01:33AM -0700, Anton Vorontsov wrote: >> Hi all, >> >> Here comes the lucky v7: >> >> - Per Alan Cox's suggestion added hangup method and removed a small >> leftover; >> - Per Colin Cross' suggestion moved IRQ quiescin

Lines for locations sizing information (from Kernel Summit 2012 discussion)

2012-08-28 Thread Jason Wessel
Because I had not done any size profiling since the original RFC posting, I took 20 min and ported the patch set up to the 3.6-rc3 and booted the kernel in each configuration. There are still probably a few use cases where this patch set might be useful but the general sentiment seemed that this

[PATCH 2/4] pmac_zilog,kdb: Fix console poll hook to return instead of loop

2012-08-12 Thread Jason Wessel
: Greg Kroah-Hartman Signed-off-by: Jason Wessel --- drivers/tty/serial/pmac_zilog.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c index 654755a..333c8d0 100644 --- a/drivers/tty/serial/pmac_z

[PATCH 4/4] kgdboc: Accept either kbd or kdb to activate the vga + keyboard kdb shell

2012-08-12 Thread Jason Wessel
kbd was the original abbreviation for keyboard). With this change kgdboc will now accept either to mean the same thing: kgdboc=kbd kgdboc=kdb Signed-off-by: Jason Wessel --- drivers/tty/serial/kgdboc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/t

[PATCH 1/4] mips,kgdb: fix recursive page fault with CONFIG_KPROBES

2012-08-12 Thread Jason Wessel
igned-off-by: Jason Wessel --- arch/mips/kernel/kgdb.c |9 + 1 file changed, 9 insertions(+) diff --git a/arch/mips/kernel/kgdb.c b/arch/mips/kernel/kgdb.c index f4546e9..23817a6 100644 --- a/arch/mips/kernel/kgdb.c +++ b/arch/mips/kernel/kgdb.c @@ -283,6 +283,15 @@ static int kgdb_mips_n

[PATCH 3/4] kgdb,x86: fix warning about unused variable

2012-08-12 Thread Jason Wessel
the warning go away. Reported-by: Thiago Rafael Becker Signed-off-by: Jason Wessel --- arch/x86/kernel/kgdb.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c index 3f61904..836f832 100644 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/ker

[GIT PULL] KGDB/KDB/dbgp fixes for 3.6-rc1

2012-08-03 Thread Jason Wessel
Anton Vorontsov (1): kernel/debug: Make use of KGDB_REASON_NMI Colin Ian King (1): USB: echi-dbgp: increase the controller wait time to come out of halt. Jason Wessel (2): kdb: Remove unused KDB_FLAG_ONLY_DO_DUMP kdb: Remove cpu from the more prompt

Re: [PATCH] USB: echi-dbgp: increase the controller wait time to come out of halt.

2012-07-31 Thread Jason Wessel
On 07/30/2012 10:06 AM, Colin Ian King wrote: > The default 10 microsecond delay for the controller to come out of > halt in dbgp_ehci_startup is too short, so increase it to 1 millisecond. > > This is based on emperical testing on various USB debug ports on > modern machines such as a Lenovo X220i

Re: [PATCH 01/11] kernel/debug: Make use of KGDB_REASON_NMI

2012-07-30 Thread Jason Wessel
On 07/30/2012 06:58 AM, Anton Vorontsov wrote: > Currently kernel never set KGDB_REASON_NMI. We do now, when we enter > KGDB/KDB from an NMI. > > This is not to be confused with kgdb_nmicallback(), NMI callback is > an entry for the slave CPUs during CPUs roundup, but REASON_NMI is the > entry for

Re: [PATCH 0/3] kgdb: fixes and ARCH=arm support

2008-02-21 Thread Jason Wessel
Ingo Molnar wrote: > > I think we should also try to do some self-tests, so that when one boots > a bzImage with the self-tests activated it can be said that all the > basic functionality works. Simulated via some loopback method, from > within the kernel - not via a real serial line - but it s

[PATCH 3/3] kgdb: support for ARCH=arm

2008-02-20 Thread Jason Wessel
to setup the traps earlier allow for early debugging with a uart based KGDB I/O driver. The do_undefinstr() routine also needed to allow the lookup of kernel address space in order for the debugger to plant undefined instructions in kernel memory space and receive the correct notification. Signed-of

[PATCH 1/3] kgdb: fix optional arch functions and probe_kernel_*

2008-02-20 Thread Jason Wessel
not allow access to the kernel memory space. As an example, it is required to allow the full kernel address space is when you the kernel debugger to inspect a system call. Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- kernel/kgdb.c | 11 +++ mm/maccess.c |6 ++ 2

[PATCH 2/3] kgdb: kgdboc pl011 I/O module

2008-02-20 Thread Jason Wessel
Implement the serial polling hooks for the pl011 uart for use with kgdboc. This patch was specifically tested on the ARM Versatile AB reference platform. Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Thomas Glei

[PATCH 0/3] kgdb: fixes and ARCH=arm support

2008-02-20 Thread Jason Wessel
series. Jason. The following changes since commit 4ce04a959ef2ba9338217966013b832ff0ff9003: Jason Wessel (1): kgdb-light-v10: x86 HW breakpoints are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git for_ingo Jason Wessel (3

[PATCH 7/7] kgdb-light-v10: build core and arch pieces as a kernel module

2008-02-15 Thread Jason Wessel
gpl-exported all of them. The result is a fully modular kgdb that may help to reduce concerns regarding its intrusiveness. Signed-off-by: Jan Kiszka <[EMAIL PROTECTED]> Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- arch/x86/kernel/kgdb-x86.c | 11 ++- arch/x86/kernel/r

[PATCH 2/7] kgdb-light-v10: fix NMI hangs

2008-02-15 Thread Jason Wessel
NMI sync vs the normal NMI apic interrupt so kgdb needs to catch the unknown NMI if it the debugger was previously active on one of the cpus. Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- arch/x86/kernel/kgdb.c | 18 +++--- arch/x86/kernel/traps_32.c |2 ++ ar

[PATCH 5/7] kgdb-light-v10: x86 HW breakpoints

2008-02-15 Thread Jason Wessel
are interested in, in the first place. Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- arch/x86/kernel/kgdb.c| 138 + arch/x86/kernel/setup64.c | 14 + kernel/kgdb.c |4 +- 3 files changed, 154 insertions(+), 2 del

[PATCH 3/7] kgdb-light-v10: clocksource watchdog

2008-02-15 Thread Jason Wessel
In order to not trip the clocksource watchdog, kgdb must touch the clocksource watchdog on the return to normal system run state. Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- include/linux/clocksource.h |1 + kernel/kgdb.c |4 kernel/time/clocksource.c

[PATCH 4/7] kgdb-light-v10: print breakpoint removed on exception

2008-02-15 Thread Jason Wessel
If kgdb does remove a breakpoint that had a problem on the recursion check, it should also print the address of the breakpoint. Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- kernel/kgdb.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/kernel/kgdb.c b/

[PATCH 1/7] kgdb-light-v10: fix kgdboc dynamic module configuration

2008-02-15 Thread Jason Wessel
Fix the run time configuration of kgdboc such that it does not default to 9600 baud if you use the "echo" command to configure the sysfs module paramater. Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- drivers/serial/kgdboc.c |7 ++- 1 files changed, 6 insertions

[PATCH 0/7] kgdb-light-v10: proposed fixes

2008-02-15 Thread Jason Wessel
because the kernel.org community may or may not object to exposing too many low level exports. The following changes since commit 2680c15446821264fa3c2278e584974f2feb97b4: Jason Wessel (1): Merge branch 'master' of git://git.kernel.org/.../mingo/linux-2.6-kgdb are available

Re: [git pull] kgdb-light -v10

2008-02-15 Thread Jason Wessel
Linus Torvalds wrote: > [ The exception being that I think hw breakpoint support should be added > back in - never mind that it won't work if the "native kernel" also uses > them. Tough. > > If the debugger screws up the hw breakpoint state, that's a debugger > error. I'd hope that the remote debug

Re: [RFC][PATCH] modular kgdb-light

2008-02-15 Thread Jason Wessel
Andi Kleen wrote: > On Fri, Feb 15, 2008 at 01:35:36PM +0100, Jan Kiszka wrote: > >> o machine_emergency_restart - for implementing "R0" gdb packet >> > > Hmm, might be a bit dangerous to call this directly -- there are various > quirks with e.g. not rebooting on CPU #0 and not resetting A

Re: [git pull] kgdb-light -v10

2008-02-12 Thread Jason Wessel
Andi Kleen wrote: >> It is more than a simple recursion check (which is already in the code) >> because there are some conditions we can recover from. I'd rather not >> crash the system out if it can be recovered. >> > > Ok I'm trying to understand the code as you describe it. As far > as I

Re: [git pull] kgdb-light -v10

2008-02-12 Thread Jason Wessel
Andi Kleen wrote: >> Basically when you reach this chunk of code it is before the hand off >> to the source debugger. We cannot continue because there was a >> breakpoint in a part of the system kgdb was using while doing its >> normal work. The reality is that KGDB is not self contained. It >>

Re: [git pull] kgdb-light -v10

2008-02-12 Thread Jason Wessel
Andi Kleen wrote: >> We might be best served to add a comment to explain the purpose of >> kgdb_arch_pc() and put it in the optional implementation function >> headers in include/linux/kgdb.h >> >> On some archs certain exceptions do not report the address that the >> exception occurred at when you

Re: [git pull] kgdb-light -v10

2008-02-12 Thread Jason Wessel
Domenico Andreoli wrote: > Hi, > > On Tue, Feb 12, 2008 at 12:27:47PM +0100, Ingo Molnar wrote: > >> this is kgdb-light, version -v10 (against Linus-latest), and can be >> pulled from: >> >>git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-kgdb.git >> >> shortlog, diffstat and f

Re: [git pull] kgdb-light -v10

2008-02-12 Thread Jason Wessel
Ingo Molnar wrote: > * Andi Kleen <[EMAIL PROTECTED]> wrote: > > >>> i went for correctness and simplicity first. If a system is hung, >>> the debugging CPU might hang too at any time. A timeout on the other >>> hand introduces the possibility of a 'dead' CPU just coming back to >>> life afte

Re: [PATCH][7/8] kgdb: exclusive use kgdb8250 uart I/O driver

2008-02-09 Thread Jason Wessel
Jan Kiszka wrote: > There are a few things I missed in my last cleanup round, please fold > them in, they reduce the changes outside kgdb. (I bet that membase > dumping was related to mmio vs. mmap configuration, right?) > > That is correct, the right thing to do is remove the code. I folded y

Re: [PATCH][7/8] kgdb: exclusive use kgdb8250 uart I/O driver

2008-02-09 Thread Jason Wessel
Jan Kiszka wrote: > [EMAIL PROTECTED] wrote: > >> @@ -2175,9 +2187,9 @@ uart_configure_port(struct uart_driver *drv, struct >> uart_state *state, >> >> /* >> * Power down all ports by default, except the >> - * console if we have one. >> + *

[PATCH 8/8] kgdb: kgdboc 8250 I/O module

2008-02-09 Thread jason . wessel
From: Jason Wessel <[EMAIL PROTECTED]> Add a SERIAL_POLL API to the serial core for use with kgdboc (KGDB over the console), the gdb serial adapter which can multiplex with a console port. The kgdboc module can be extended later to support all sorts of different console types provided that

[PATCH][7/8] kgdb: exclusive use kgdb8250 uart I/O driver

2008-02-09 Thread jason . wessel
From: Jason Wessel <[EMAIL PROTECTED]> This patch some small hooks into the normal serial core so that a uart can be unregistered to be exclusively used for KGDB. These changes allow for registering and unregistering a port with a struct uart_port. From that point on KGDB does raw acces

[PATCH 4/8] kgdb: COPTIMIZE flag

2008-02-09 Thread jason . wessel
From: Jason Wessel <[EMAIL PROTECTED]> This patch adds in the ability to unoptimize a single kernel module to make source stepping more linear and not optimize out variables that the developer might like to inspect. It used with adding COPTIMIZE=-O0 to the build line when doing something

[PATCH 2/8] pid, kgdb: add pid_max prototype

2008-02-09 Thread jason . wessel
From: Ingo Molnar <[EMAIL PROTECTED]> add pid_max prototype - now used by sysctl and kgdb as well. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]> Signed-off-by: Jason Wessel <[EMAIL PROTECTED]> --- include/linux/pid.h

[PATCH 6/8] kgdb, sysrq_bugfix

2008-02-09 Thread jason . wessel
From: Jason Wessel <[EMAIL PROTECTED]> It is possible that when SysRq-G is triggered via the keyboard that we will miss the "up" event and once KGDB lets the kernel go another SysRq will be required to clear this, without this change. Signed-off-by: Tom Rini <[EMAIL PROTEC

[PATCH 3/8] kgdb, modules: Always allow module sect info for KGDB

2008-02-09 Thread jason . wessel
From: Jason Wessel <[EMAIL PROTECTED]> With more information in the kernel, gdb can be modified in such a way as to automatically read the kernel module section information and allow for easy kernel module debugging. In gdb the solib-search-path must contain the location of any module

[PATCH 5/8] kgdb, x86: Add arch specfic kgdb support

2008-02-09 Thread jason . wessel
From: Jason Wessel <[EMAIL PROTECTED]> On the i386 arch, in order to support early debugginer with kgdb when used with kgdb via rs232 some traps must be initialized sooner rather than later, but it is safe to always do this. The arch i386 now calls parse_early_param() to explicitly l

[PATCH 0/8] kgdb 2.6.25 version

2008-02-09 Thread jason . wessel
Per reqest on lkml, here are the individual kgdb patches targeted at 2.6.25. The kgdb tree has been collapsed review. It includes the kgdb core, the x86 arch, the kgdb8250 uart driver and the kgdb console sharing driver. Since the last time the kgdb patches were posted to LKML several months ago

[git pull] kgdb core and rs232 I/O drivers

2008-02-08 Thread Jason Wessel
/linux-2.6-kgdb.git for_linus Ingo Molnar (1): pid, kgdb: add pid_max prototype Jason Wessel (7): kgdb: core API and gdb protocol handler kgdb, modules: Always allow module sect info for KGDB kgdb: COPTIMIZE flag kgdb, x86: Add arch specfic kgdb support kgdb

  1   2   >