Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-18 Thread Jarno Rajahalme
cells, i); > > __skb_queue_head_init(&cell->napi_skbs); > + > + set_bit(NAPI_STATE_NO_BUSY_POLL, &cell->napi.state); > + > netif_napi_add(dev, &cell->napi, gro_cell_poll, 64); > napi_enable(&cell->napi); > } > > > > > This fixes the problem for me, so for whatever it’s worth: Tested-by: Jarno Rajahalme

Re: Long delays creating a netns after deleting one (possibly RCU related)

2016-11-17 Thread Jarno Rajahalme
> On Nov 14, 2016, at 3:09 PM, Eric Dumazet wrote: > > On Mon, 2016-11-14 at 14:46 -0800, Eric Dumazet wrote: >> On Mon, 2016-11-14 at 16:12 -0600, Eric W. Biederman wrote: >> >>> synchronize_rcu_expidited is not enough if you have multiple network >>> devices in play. >>> >>> Looking at the c

[PATCH net v3 1/2] udp_tunnel: Remove redundant udp_tunnel_gro_complete().

2016-05-03 Thread Jarno Rajahalme
The setting of the UDP tunnel GSO type is already performed by udp[46]_gro_complete(). Signed-off-by: Jarno Rajahalme --- drivers/net/geneve.c | 2 -- drivers/net/vxlan.c | 2 -- include/net/udp_tunnel.h | 9 - net/ipv4/fou.c | 2 -- 4 files changed, 15 deletions

[PATCH net v3 2/2] udp_offload: Set encapsulation before inner completes.

2016-05-03 Thread Jarno Rajahalme
nt or as packet loss. This patch fixes this by setting skb's 'encapsulation' in udp_gro_complete() before calling into the inner complete functions, and by making each possible UDP tunnel gro_complete() callback set the inner_mac_header to the beginning of the tunnel payload. Sig

[PATCH net v2 2/2] udp_offload: Set encapsulation before inner completes.

2016-05-02 Thread Jarno Rajahalme
e here. Furthermore, it was wrongly set to the beginning of the UDP tunnel header rather than the inner MAC header. Signed-off-by: Jarno Rajahalme --- net/ipv4/udp_offload.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/net/ipv4/udp_offload.c b/net/ipv4/udp_offload.c

[PATCH net v2 1/2] udp_tunnel: Remove redundant udp_tunnel_gro_complete().

2016-05-02 Thread Jarno Rajahalme
The setting of the UDP tunnel GSO type is already performed by udp[46]_gro_complete(). Signed-off-by: Jarno Rajahalme --- drivers/net/geneve.c | 2 -- drivers/net/vxlan.c | 2 -- include/net/udp_tunnel.h | 9 - net/ipv4/fou.c | 2 -- 4 files changed, 15 deletions

Re: [patch] openvswitch: using a bit shift as a mask

2016-03-18 Thread Jarno Rajahalme
> On Mar 17, 2016, at 3:41 AM, Dan Carpenter wrote: > > The original condition is never true. We want to test if BIT(0) is set > but the code is ANDing with zero. > > Fixes: 05752523e565 ('openvswitch: Interface with NAT.') > Signed-off-by: Dan Carpenter > > diff --git a/net/openvswitch/conn

Re: [ovs-dev] [PATCH] ovs: do not allocate memory from offline numa node

2015-10-07 Thread Jarno Rajahalme
> On Oct 6, 2015, at 6:01 PM, Jesse Gross wrote: > > On Mon, Oct 5, 2015 at 1:25 PM, Alexander Duyck > wrote: >> On 10/05/2015 06:59 AM, Vlastimil Babka wrote: >>> >>> On 10/02/2015 12:18 PM, Konstantin Khlebnikov wrote: When openvswitch tries allocate memory from offline numa node

Re: [PATCH net-next] openvswitch: Fix serialization of non-masked set actions.

2015-03-03 Thread Jarno Rajahalme
Thanks for spotting and fixing this, Acked-by: Jarno Rajahalme > On Mar 2, 2015, at 6:49 PM, Joe Stringer wrote: > > Set actions consist of a regular OVS_KEY_ATTR_* attribute nested inside > of a OVS_ACTION_ATTR_SET action attribute. When converting masked actions > back