[PATCH] staging: rtl8712: remove wrapper function thread_enter()

The inline function thread_enter() accepts a single ignored parameter and is just a wrapper for allow_signal(SIGTERM). Removed. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h | 5 - drivers/staging/rtl8712/rtl8712_cmd.c | 2 +- 2 files changed, 1 insertion

[PATCH 2/3] staging: rtl8712: remove wrapper function _set_workitem()

The inline function _set_workitem() simply wraps schedule_work(). Removed. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h | 5 - drivers/staging/rtl8712/rtl8712_led.c | 2 +- drivers/staging/rtl8712/rtl871x_pwrctrl.c | 4 ++-- 3 files changed, 3

[PATCH 3/3] staging: rtl8712: remove #define _workitem struct work_struct

_workitem is just a #define for work_struct. Remove the #define and use struct work_struct directly instead. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/drv_types.h | 2 +- drivers/staging/rtl8712/osdep_service.h | 1 - drivers/staging/rtl8712/rtl871x_led.h | 2

[PATCH 1/3] staging: rtl8712: remove wrapper function _init_workitem()

The inline function _init_workitem() is just a wrapper around INIT_WORK(). Oddly, this wrapper accepts 3 parameters while INIT_WORK() only accepts 2. The third parameter is unused. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h | 5 - drivers/staging

Re: [PATCH 8/8] staging: rtl8712: remove inapplicable comment

On Tue, Jul 08, 2014 at 01:16:53PM +0300, Dan Carpenter wrote: > On Tue, Jun 24, 2014 at 10:52:41PM -0400, James A Shackleford wrote: > > Signed-off-by: James A Shackleford > > --- > > drivers/staging/rtl8712/osdep_service.h |5 - > > 1 file changed, 5 deletio

[PATCH 7/8] staging: rtl8712: remove wrapper function _queue_empty

_queue_empty is an inline wrapper around list_empty. This patch removes this wrapper function and instead calls list_empty directly. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - drivers/staging/rtl8712/rtl8712_cmd.c |2 +- drivers

[PATCH 8/8] staging: rtl8712: remove inapplicable comment

Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index 77b1443..3dfc473 100644 --- a/drivers/staging/rtl8712/osdep_service.h

[PATCH 5/8] staging: rtl8712: remove wrapper function get_next

get_next is just an inline wrapper around return list->next. This patch removes the wrapper and directly uses list->next where applicable. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - drivers/staging/rtl8712/rtl8712_recv.c

[PATCH 6/8] staging: rtl8712: remove function get_list_head

get_list_head is an inline that returns &list->head. This patch removes this inline and directly applies &list->head where applicable. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - drivers/staging/rtl8712/rtl8712_recv.c

[PATCH 3/8] staging: rtl8712: remove wrapper function list_insert_tail

list_insert_tail is just an inline wrapper around list_add_tail. This patch removes the wrapper and directly uses list_add_tail. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |6 -- drivers/staging/rtl8712/rtl8712_recv.c| 10 +- drivers

[PATCH 1/8] staging: rtl8712: remove wrapper function _init_listhead

_init_listhead is just an inline wrapper around INIT_LIST_HEAD. This patch removes the wrapper and directly uses INIT_LIST_HEAD instead. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |7 +-- drivers/staging/rtl8712/rtl8712_recv.c|4

[PATCH 4/8] staging: rtl8712: remove wrapper function list_delete

list_delete is just an inline wrapper around list_del_init. This patch removes the wrapper and directly uses list_del_init. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - drivers/staging/rtl8712/rtl8712_recv.c|8 drivers/staging

[PATCH 2/8] staging: rtl8712: remove wrapper function is_list_empty

is_list_empty is just an inline wrapper around list_empty. This patch removes the wrapper and directly uses list_empty instead. Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h | 10 +- drivers/staging/rtl8712/rtl8712_recv.c |4 ++-- drivers/staging

[PATCH 2/4] staging: rtl8712: remove inline _RND128() and use round_up()

Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - drivers/staging/rtl8712/rtl8712_recv.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index

[PATCH 3/4] staging: rtl8712: remove unused inline _RND256()

Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index 37ec56b..9316eab 100644 --- a/drivers/staging/rtl8712/osdep_service.h

[PATCH 1/4] staging: rtl8712: remove inline _RND8() and use round_up()

Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - drivers/staging/rtl8712/rtl8712_cmd.c |2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index

[PATCH 4/4] staging: rtl8712: remove unused inline _RND512()

Signed-off-by: James A Shackleford --- drivers/staging/rtl8712/osdep_service.h |5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8712/osdep_service.h b/drivers/staging/rtl8712/osdep_service.h index 9316eab..425f0f1 100644 --- a/drivers/staging/rtl8712/osdep_service.h

[PATCH] staging: goldfish: fix direct copy_to_user() from __iomem

: James A Shackleford --- drivers/staging/goldfish/goldfish_audio.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index a166424..535ed20 100644 --- a/drivers/staging

[PATCH] staging: lustre: fix sparse warnings for static symbols

.c:2748:1: warning: symbol 'ksocknal_net_start_threads' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2860:1: warning: symbol 'ksocknal_module_fini' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/socklnd/socklnd.c:2866:

[PATCH] staging: vt6655: remove header declarations for static functions

The functions iwctl_giwscan() and iwctl_siwscan() are only referenced within iwctl.c -- so, remove their function declarations from iwctl.h and mark these functions as static. Signed-off-by: James A Shackleford --- drivers/staging/vt6655/iwctl.c |4 ++-- drivers/staging/vt6655/iwctl.h

Re: [PATCH 1/3] staging: vt6655: update out-of-date function declaration

On Thu, Jun 19, 2014 at 04:35:02PM -0700, Greg KH wrote: > On Sun, Jun 01, 2014 at 10:19:31PM -0400, James A Shackleford wrote: > > The function iwctl_siwscan() is defined in iwctl.c as: > > int iwctl_siwscan(struct net_device *dev, > > struct

[PATCH] staging: vt6655: replace C99 style comments

Signed-off-by: James A Shackleford --- drivers/staging/vt6655/baseband.c | 300 ++--- 1 file changed, 150 insertions(+), 150 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 6f95fb6..490ca96 100644 --- a

[PATCH 3/3] staging: vt6655: fix sparse warning for static declarations

? iwctl.c:1644:5: warning: symbol 'iwctl_giwgenie' was not declared. Should it be static? iwctl.c:1669:5: warning: symbol 'iwctl_siwencodeext' was not declared. Should it be static? iwctl.c:1783:5: warning: symbol 'iwctl_giwencodeext' was not declared. Should it be st

[PATCH 1/3] staging: vt6655: update out-of-date function declaration

) in the function declaration matches the definition. Signed-off-by: James A Shackleford --- drivers/staging/vt6655/iwctl.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h index 871bd7c..4ad5e48 100644 --- a

[PATCH 2/3] staging: vt6655: update iwctl_private_args extern declaration

Update declaration of iwctl_private_args to match definition in iwctl.c Signed-off-by: James A Shackleford --- drivers/staging/vt6655/iwctl.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h index 4ad5e48

[PATCH] staging: vt6655: fix sparse warning for static declarations

as not declared. Should it be static? Signed-off-by: James A Shackleford --- drivers/staging/vt6655/dpc.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/dpc.c b/drivers/staging/vt6655/dpc.c index 7ddaf26..696564b 100644 --- a/drivers/staging/vt66

[PATCH] staging: skein: fix sparse warning for static arrays

147:11: warning: symbol 'SKEIN_1024_IV_512' was not declared. Should it be static? skein_iv.h:167:11: warning: symbol 'SKEIN_1024_IV_1024' was not declared. Should it be static? by declaring the initialization vectors in question as static. The header skein_iv.h is only includ

[PATCH] staging: skein: fix sparse warning for static declarations

3:6: warning: symbol 'skein_1024_process_block' was not declared. Should it be static? by including the header skein_block.h, which contains the declarations in question. Signed-off-by: James A Shackleford --- drivers/staging/skein/skein_block.c |1 + 1 file changed, 1 insertion(+) diff

[PATCH] staging: silicom: fix sparse warning for static variable

This patch fixes the following sparse warning in bpctl_mod.c: warning: symbol 'bpvm_lock' was not declared. Should it be static? Signed-off-by: James A Shackleford --- drivers/staging/silicom/bpctl_mod.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH] staging: vt6655: fix sparse warning "cast removes address space of expression"

Add missing __user macro to second parameter of ethtool_ioctl(). This removes the need for the offending (void *) cast of the user space pointer rq->ifr_data. Signed-off-by: James A Shackleford --- drivers/staging/vt6655/device_main.c |6 +++--- 1 file changed, 3 insertions(+), 3 deleti

[PATCH] staging: ozwpan: Add missing blanklines after declarations

Signed-off-by: James A Shackleford --- (For Eudyptula Challenge) --- drivers/staging/ozwpan/ozhcd.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c index b3d401a..91bb29e 100644 --- a/drivers/staging/ozwpan