Re: Why is the kfree() argument const?

2008-01-18 Thread Jakob Oestergaard
On Fri, Jan 18, 2008 at 02:31:16PM +0100, Björn Steinbrink wrote: ... > > Do you see anything that casts the const away? No? Me neither. Still, > the memory that p points to was changed, because there was another > pointer and that was not const. *another* being key here. > > > *That* is the pu

Re: Why is the kfree() argument const?

2008-01-18 Thread Jakob Oestergaard
On Fri, Jan 18, 2008 at 12:47:01PM +0100, Giacomo A. Catenazzi wrote: ... > "restrict" exists for this reason. const is only about lvalue. You think that I try to put more meaning into const than I do - but I don't. Please read what I wrote, not what you want to think I wrote. I agree that if I

Re: Why is the kfree() argument const?

2008-01-18 Thread Jakob Oestergaard
On Thu, Jan 17, 2008 at 01:25:39PM -0800, Linus Torvalds wrote: ... > Why do you make that mistake, when it is PROVABLY NOT TRUE! > > Try this trivial program: > > int main(int argc, char **argv) > { > int i; > const int *c; > > i = 5;

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-10 Thread Jakob Oestergaard
On Thu, Jan 10, 2008 at 03:03:03AM +0300, Anton Salikhmetov wrote: ... > > I guess a third possible time (if we want to minimize the number of > > updates) would be when natural syncing of the file data to disk, by > > other things in the VM, would be about to clear the I_DIRTY_PAGES > > flag on th

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Jakob Oestergaard
On Wed, Jan 09, 2008 at 05:06:33PM -0500, Rik van Riel wrote: ... > > > > Lather, rinse, repeat Just verified this at one customer site; they had a db that was last backed up in 2003 :/ > > On the other hand, updating the mtime and ctime whenever a page is dirtied > also does not work right

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Jakob Oestergaard
On Wed, Jan 09, 2008 at 02:32:53PM +0300, Anton Salikhmetov wrote: ... > > This bug causes backup systems to *miss* changed files. > This problem is seen with both Amanda and TSM (Tivoli Storage Manager). A site running Amanda with, say, a full backup weekly and incremental backups daily, will

Re: [PATCH][RFC][BUG] updating the ctime and mtime time stamps in msync()

2008-01-09 Thread Jakob Oestergaard
On Wed, Jan 09, 2008 at 02:32:53PM +0300, Anton Salikhmetov wrote: > Since no reaction in LKML was recieved for this message it seemed > logical to suggest closing the bug #2645 as "WONTFIX": > > http://bugzilla.kernel.org/show_bug.cgi?id=2645#c15 Thank you! A quick run-down for those who don't

Re: [PATCH] Smackv10: Smack rules grammar + their stateful parser(2)

2007-11-10 Thread Jakob Oestergaard
... > I've double-checked the code for any possible off-by-one/overflow > errors. ... Two things caught my eye. ... > + case bol: > + case subject: > + if (*label_len >= SMK_MAXLEN) > + goto out; > + subj

Re: recent nfs change causes autofs regression

2007-09-03 Thread Jakob Oestergaard
On Fri, Aug 31, 2007 at 09:43:29AM -0700, Linus Torvalds wrote: ... > This is *not* a security hole. In order to make it a security hole, you > need to be root in the first place. Non-root users can write to places where root might believe they cannot write because he might be under the mistaken

Re: recent nfs change causes autofs regression

2007-08-31 Thread Jakob Oestergaard
On Fri, Aug 31, 2007 at 01:07:56AM -0700, Linus Torvalds wrote: ... > When we add NEW BEHAVIOUR, we don't add it to old interfaces when that > breaks old user mode! We add a new flag saying "I want the new behaviour". > > This is not rocket science, guys. This is very basic kernel behaviour. The

Re: recent nfs change causes autofs regression

2007-08-31 Thread Jakob Oestergaard
On Thu, Aug 30, 2007 at 10:16:37PM -0700, Linus Torvalds wrote: > ... > > Why aren't we doing that for any other filesystem than NFS? > > How hard is it to acknowledge the following little word: > > "regression" > > It's simple. You broke things. You may want to fix them, but you need to

Re: [PATCH 00/23] per device dirty throttling -v8

2007-08-05 Thread Jakob Oestergaard
On Sun, Aug 05, 2007 at 02:46:48PM +0200, Ingo Molnar wrote: > > * Jakob Oestergaard <[EMAIL PROTECTED]> wrote: > > > > If you can show massive amounts of users that will actually be > > > negatively impacted, please present hard evidence. > > > &

Re: [PATCH 00/23] per device dirty throttling -v8

2007-08-05 Thread Jakob Oestergaard
On Sun, Aug 05, 2007 at 06:42:30AM -0400, Jeff Garzik wrote: ... > If you can show massive amounts of users that will actually be > negatively impacted, please present hard evidence. > > Otherwise all this is useless hot air. Peace Jeff :) In another mail, I gave an example with tmpreaper clea

Re: [PATCH 00/23] per device dirty throttling -v8

2007-08-05 Thread Jakob Oestergaard
On Sat, Aug 04, 2007 at 02:08:40PM -0400, Jeff Garzik wrote: > Linus Torvalds wrote: > >The "relatime" thing that David mentioned might well be very useful, but > >it's probably even less used than "noatime" is. And sadly, I don't really > >see that changing (unless we were to actually change the

Re: [PATCH 00/23] per device dirty throttling -v8

2007-08-05 Thread Jakob Oestergaard
On Sun, Aug 05, 2007 at 09:28:05AM +0200, Ingo Molnar wrote: > > * Alan Cox <[EMAIL PROTECTED]> wrote: > > > > Can you give examples of backup solutions that rely on atime being > > > updated? I can understand backup tools using mtime/ctime for > > > incremental backups (like tar + Amanda, etc

Re: Getting rid of SHMMAX/SHMALL ?

2005-08-04 Thread Jakob Oestergaard
On Thu, Aug 04, 2005 at 02:19:21PM +0100, Hugh Dickins wrote: ... > > Even on 32bit architectures it is far too small and doesn't > > make much sense. Does anybody remember why we even have this limit? > > To be like the UNIXes. :) ... > Anton proposed raising the limits last autumn, but I was

Re: 10 GB in Opteron machine

2005-07-22 Thread Jakob Oestergaard
On Fri, Jul 22, 2005 at 01:37:46PM +0200, Christoph Pleger wrote: > Hello, > ... > I am also using Debian sarge. I extracted the tarfile to /usr/local/bin > end executed "kmake menuconfig". Everything seemed fine so far. But a > few seconds after starting the compilation (kmake bzImage) I got this

Re: 10 GB in Opteron machine

2005-07-22 Thread Jakob Oestergaard
On Fri, Jul 22, 2005 at 11:31:38AM +0200, Christoph Pleger wrote: > Hello, ... > > There is no highmem option for the 64-bit kernel, because it doesn't > > need one. > > I have two questions: > > 1. Is it possible to compile a 64-bit kernel on a 32-bit machine (or at > least on a 64-bit machine

Re: PROBLEM: please remove reserved word "new" from kernel headers

2005-07-06 Thread Jakob Oestergaard
On Wed, Jul 06, 2005 at 02:26:57AM -0700, Rob Prowel wrote: > [1.] One line summary of the problem: > > 2.4 and 2.6 kernel headers use c++ reserved word "new" > as identifier in function prototypes. Correction: [1.] One line summary of problem: Userspace application is making use of private

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-20 Thread Jakob Oestergaard
On Tue, Apr 19, 2005 at 06:46:28PM -0400, Trond Myklebust wrote: > ty den 19.04.2005 Klokka 21:45 (+0200) skreiv Jakob Oestergaard: > > > It mounts a home directory from a 2.6.6 NFS server - the client and > > server are on a hub'ed 100Mbit network. > > >

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-19 Thread Jakob Oestergaard
On Tue, Apr 12, 2005 at 11:28:43AM +0200, Jakob Oestergaard wrote: ... > > But still, guys, it is the *same* server with tg3 that runs well with a > 2.4 client but poorly with a 2.6 client. > > Maybe I'm just staring myself blind at this, but I can't see how a > g

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-12 Thread Jakob Oestergaard
On Tue, Apr 12, 2005 at 11:03:29AM +1000, Greg Banks wrote: > On Tue, 2005-04-12 at 01:42, Jakob Oestergaard wrote: > > Yes, as far as I know - the Broadcom Tigeon3 driver does not have the > > option of enabling/disabling RX polling (if we agree that is what we're > > t

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-11 Thread Jakob Oestergaard
On Mon, Apr 11, 2005 at 11:21:45AM -0400, Trond Myklebust wrote: > må den 11.04.2005 Klokka 16:41 (+0200) skreiv Jakob Oestergaard: > > > > That can mean either that the server is dropping fragments, or that the > > > client is dropping the replies. Can you generate a simi

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-11 Thread Jakob Oestergaard
On Mon, Apr 11, 2005 at 10:35:25AM -0400, Trond Myklebust wrote: > må den 11.04.2005 Klokka 15:47 (+0200) skreiv Jakob Oestergaard: > > > Certainly; > > > > http://unthought.net/binary.dmp.bz2 > > > > I got an 'invalid snaplen' with the 9 you s

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-11 Thread Jakob Oestergaard
On Mon, Apr 11, 2005 at 08:35:39AM -0400, Trond Myklebust wrote: ... > That certainly shouldn't be the case (and isn't on any of my setups). Is > the behaviour identical same on both the PIII and the Opteron systems? The dual opteron is the nfs server The dual athlon is the 2.4 nfs client The du

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-11 Thread Jakob Oestergaard
On Sat, Apr 09, 2005 at 05:52:32PM -0400, Trond Myklebust wrote: > lau den 09.04.2005 Klokka 23:35 (+0200) skreiv Jakob Oestergaard: > > > 2.6.11.6: (dual PIII 1GHz, 2G RAM, Intel e1000) > > > > File Block Num Seq ReadRand Read Seq Write Rand Write

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-09 Thread Jakob Oestergaard
On Thu, Apr 07, 2005 at 12:17:51PM -0400, Trond Myklebust wrote: > to den 07.04.2005 Klokka 17:38 (+0200) skreiv Jakob Oestergaard: > > > I tweaked the VM a bit, put the following in /etc/sysctl.conf: > > vm.dirty_writeback_centisecs=100 > > vm.dirty_expire_centisecs=2

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-07 Thread Jakob Oestergaard
On Thu, Apr 07, 2005 at 09:19:06AM +1000, Greg Banks wrote: ... > How large is the client's RAM? 2GB - (32 bit kernel because it's dual PIII, so I use highmem) A few more details: With standard VM settings, the client will be laggy during the copy, but it will also have a load average around 10

Re: bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-07 Thread Jakob Oestergaard
On Wed, Apr 06, 2005 at 05:28:56PM -0400, Trond Myklebust wrote: ... > A look at "nfsstat" might help, as might "netstat -s". > > In particular, I suggest looking at the "retrans" counter in nfsstat. When doing a 'cp largefile1 largefile2' on the client, I see approx. 10 retransmissions per secon

bdflush/rpciod high CPU utilization, profile does not make sense

2005-04-06 Thread Jakob Oestergaard
Hello list, Setup; NFS server (dual opteron, HW RAID, SCA disk enclosure) on 2.6.11.6 NFS client (dual PIII) on 2.6.11.6 Both on switched gigabit ethernet - I use NFSv3 over UDP (tried TCP but this makes no difference). Problem; during simple tests such as a 'cp largefile0 largefile1' on the

Re: the "Turing Attack" (was: Sabotaged PaXtest)

2005-02-10 Thread Jakob Oestergaard
On Thu, Feb 10, 2005 at 02:43:14PM +0100, Ingo Molnar wrote: > > * [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > > the bigger problem is however that you're once again fixing the > > symptoms, instead of the underlying problem - not the correct > > approach/mindset. > > i'll change my approac

Re: raid 1 - automatic 'repair' possible?

2005-01-19 Thread Jakob Oestergaard
On Wed, Jan 19, 2005 at 11:48:52AM +0100, Kiniger wrote: ... > some random thoughts: > > nowadays hardware sector sizes are much bigger than 512 bytes No :) > and > the read error may affect some sectors +- the sector which actually > returned the error. That's right > > to keep the handling

Re: XFS: inode with st_mode == 0

2005-01-17 Thread Jakob Oestergaard
On Sun, Jan 16, 2005 at 01:51:12PM +, Christoph Hellwig wrote: > On Fri, Jan 14, 2005 at 07:23:09PM +0100, Jakob Oestergaard wrote: > > So apart from the general well known instability problems that will > > occur when you actually start *using* the system, there should be no

Re: XFS: inode with st_mode == 0

2005-01-16 Thread Jakob Oestergaard
On Sat, Jan 15, 2005 at 01:09:08PM +1100, Nathan Scott wrote: ... > > AFAIK the best you can do is to get the most recent XFS kernel from > > SGI's CVS (this one is based on 2.6.10). > > The -mm tree also has these fixes; we'll get them merged into > mainline soon. Okeydokey - good > > > If you