Re: [PATCH v2 1/3] sysfs: constify bin_attribute argument of sysfs_bin_attr_simple_read()

2025-01-03 Thread Mahesh J Salgaonkar
@@ -196,7 +196,7 @@ static int add_notes_attrs(struct module *mod, const > struct load_info *info) > nattr->attr.mode = 0444; > nattr->size = info->sechdrs[i].sh_size; > nattr->private = (void *)info->sechdrs[i].sh_addr; > - nattr->read = sysfs_bin_attr_simple_read; > + nattr->read_new = sysfs_bin_attr_simple_read; > ++nattr; > } > ++loaded; > > -- > 2.47.1 > > -- Mahesh J Salgaonkar

[RFC PATCH RESEND v2 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

2025-01-02 Thread Isaac J. Manjarres
] https://cs.android.com/android/kernel/superproject/+/common-android-mainline:common/drivers/staging/android/ashmem.c [2] https://developer.android.com/reference/android/database/CursorWindow Signed-off-by: Isaac J. Manjarres --- include/uapi/linux/fcntl.h | 1 + mm/memfd.c | 39

[RFC PATCH RESEND v2 2/2] selftests/memfd: Add tests for F_SEAL_FUTURE_EXEC

2025-01-02 Thread Isaac J. Manjarres
Add tests to ensure that F_SEAL_FUTURE_EXEC behaves as expected. Signed-off-by: Isaac J. Manjarres --- tools/testing/selftests/memfd/memfd_test.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests

[RFC PATCH RESEND v2 0/2] Add file seal to prevent future exec mappings

2025-01-02 Thread Isaac J. Manjarres
inks to previous versions: v1: https://lore.kernel.org/all/20241206010930.3871336-1-isaacmanjar...@google.com/ Isaac J. Manjarres (2): mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd selftests/memfd: Add tests for F_SEAL_FUTURE_EXEC include/uapi/linux/fcntl.h | 1 + mm/memfd.

[RFC PATCH v2 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

2024-12-26 Thread Isaac J. Manjarres
] https://cs.android.com/android/kernel/superproject/+/common-android-mainline:common/drivers/staging/android/ashmem.c [2] https://developer.android.com/reference/android/database/CursorWindow Signed-off-by: Isaac J. Manjarres --- include/uapi/linux/fcntl.h | 1 + mm/memfd.c | 39

[RFC PATCH v2 2/2] selftests/memfd: Add tests for F_SEAL_FUTURE_EXEC

2024-12-26 Thread Isaac J. Manjarres
Add tests to ensure that F_SEAL_FUTURE_EXEC behaves as expected. Signed-off-by: Isaac J. Manjarres --- tools/testing/selftests/memfd/memfd_test.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests

[RFC PATCH v2 0/2] Add file seal to prevent future exec mappings

2024-12-26 Thread Isaac J. Manjarres
fa47dbd8a23@lucifer.local [6] https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/tree/?h=mm-unstable [7] https://lore.kernel.org/all/3a53b154-1e46-45fb-a559-65afa7a8a788@lucifer.local/ Links to previous versions: v1: https://lore.kernel.org/all/20241206010930.3871336-1-isaacma

Re: [PATCH v2 1/3] drivers: base: Don't match devices with NULL of_node/fwnode/etc

2024-12-13 Thread Rafael J. Wysocki
Augment these to return 0 > (false). > > Signed-off-by: Brian Norris > Reviewed-by: Rob Herring (Arm) For the ACPI part Acked-by: Rafael J. Wysocki > --- > > Changes in v2: > * Add Rob's Reviewed-by > > drivers/base/core.c | 8 > 1 file change

[RFC PATCH v1 2/2] selftests/memfd: Add tests for F_SEAL_FUTURE_EXEC

2024-12-05 Thread Isaac J. Manjarres
Add tests to ensure that F_SEAL_FUTURE_EXEC behaves as expected. Cc: Suren Baghdasaryan Cc: Kalesh Singh Cc: John Stultz Signed-off-by: Isaac J. Manjarres --- tools/testing/selftests/memfd/memfd_test.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/tools/testing

[RFC PATCH v1 1/2] mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd

2024-12-05 Thread Isaac J. Manjarres
/android/kernel/superproject/+/common-android-mainline:common/drivers/staging/android/ashmem.c [2] https://developer.android.com/reference/android/database/CursorWindow Cc: Suren Baghdasaryan Cc: Kalesh Singh Cc: John Stultz Signed-off-by: Isaac J. Manjarres --- include/linux/mm.h | 5

[RFC PATCH v1 0/2] Add file seal to prevent future exec mappings

2024-12-05 Thread Isaac J. Manjarres
rWindow [3] https://lore.kernel.org/all/cover.1732804776.git.lorenzo.stoa...@oracle.com/ Isaac J. Manjarres (2): mm/memfd: Add support for F_SEAL_FUTURE_EXEC to memfd selftests/memfd: Add tests for F_SEAL_FUTURE_EXEC include/linux/mm.h | 5 ++ include/uapi/lin

[PATCH v1] selftests/memfd: Run sysctl tests when PID namespace support is enabled

2024-12-05 Thread Isaac J. Manjarres
informative message to let the user know why the sysctl tests are not being run. Fixes: 11f75a01448f ("selftests/memfd: add tests for MFD_NOEXEC_SEAL MFD_EXEC") Cc: sta...@vger.kernel.org # v6.6+ Cc: Jeff Xu Cc: Suren Baghdasaryan Cc: Kalesh Singh Signed-off-by: Isaac J. Manjarres --- too

Re: [PATCH v5 01/19] scripts: move genksyms crc32 implementation to a common include

2024-11-19 Thread Darrick J. Wong
On Mon, Nov 18, 2024 at 09:58:09PM +, Sami Tolvanen wrote: > Hi, > > On Sat, Nov 16, 2024 at 9:09 AM Masahiro Yamada wrote: > > > > On Thu, Nov 14, 2024 at 2:54 AM Sami Tolvanen > > wrote: > > > > > > Hi, > > > > > > On Mon, Nov 11, 2024 at 8:06 PM Masahiro Yamada > > > wrote: > > > > > >

[PATCH net-next v4 2/3] selftests: nic_link_layer: Add selftest case for speed and duplex states

2024-11-14 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_link_layer.py

[PATCH net-next v4 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

2024-11-14 Thread Mohan Prasad J
Prasad J --- .../testing/selftests/drivers/net/hw/Makefile | 1 + .../drivers/net/hw/nic_performance.py | 137 ++ .../selftests/drivers/net/lib/py/load.py | 20 ++- 3 files changed, 157 insertions(+), 1 deletion(-) create mode 100644 tools/testing/selftests/drivers/net

[PATCH net-next v4 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

2024-11-14 Thread Mohan Prasad J
Add selftest file for the link layer tests of a NIC driver. Test for auto-negotiation is added. Add LinkConfig class for changing link layer configs. Selftest makes use of ksft modules and ethtool. Include selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests

[PATCH net-next v4 0/3] selftests: Add selftest for link layer and performance testing

2024-11-14 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v4: - Type hints are added for

[PATCH net-next v3 3/3] selftests: nic_performance: Add selftest for performance of NIC driver

2024-10-16 Thread Mohan Prasad J
Add selftest case to check the send and receive throughput. Supported link modes between local NIC driver and partner are varied. Then send and receive throughput is captured and verified. Test uses iperf3 tool. Signed-off-by: Mohan Prasad J --- .../testing/selftests/drivers/net/hw/Makefile

[PATCH net-next v3 1/3] selftests: nic_link_layer: Add link layer selftest for NIC driver

2024-10-16 Thread Mohan Prasad J
Add selftest file for the link layer tests of a NIC driver. Test for auto-negotiation is added. Add LinkConfig class for changing link layer configs. Selftest makes use of ksft modules and ethtool. Include selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests

[PATCH net-next v3 2/3] selftests: nic_link_layer: Add selftest case for speed and duplex states

2024-10-16 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_link_layer.py

[PATCH net-next v3 0/3] selftests: Add selftest for link layer and performance testing

2024-10-16 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v3: - LinkConfig class is included in

[PATCH net-next v2 3/3] selftests: nic_basic_tests: Add selftest case for throughput check

2024-09-17 Thread Mohan Prasad J
Add selftest case to check the send and receive throughput. Supported link modes between local NIC driver and partner are varied. Then send and receive throughput is captured and verified. Test uses iperf3 tool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_basic_tests.py

[PATCH net-next v2 2/3] selftests: nic_basic_tests: Add selftest case for speed and duplex state checks

2024-09-17 Thread Mohan Prasad J
Add selftest case for testing the speed and duplex state of local NIC driver and the partner based on the supported link modes obtained from the ethtool. Speed and duplex states are varied and verified using ethtool. Signed-off-by: Mohan Prasad J --- .../drivers/net/hw/nic_basic_tests.py

[PATCH net-next v2 1/3] selftests: nic_basic_tests: Add selftest file for basic tests of NIC

2024-09-17 Thread Mohan Prasad J
Add selftest file to test basic features of a NIC driver. Tests for link modes, auto-negotiation are placed. Selftest makes use of ksft modules and ethtool. Add selftest file in the Makefile. Signed-off-by: Mohan Prasad J --- .../testing/selftests/drivers/net/hw/Makefile | 1 + .../drivers

[PATCH net-next v2 0/3] nic_basic_tests: Add selftest for doing basic tests of NIC driver

2024-09-17 Thread Mohan Prasad J
The series of patches are for doing basic tests of NIC driver. Test comprises checks for auto-negotiation, speed, duplex state and throughput between local NIC and partner. Tools such as ethtool, iperf3 are used. Signed-off-by: Mohan Prasad J --- Changes in v2: - Changed the hardcoded

[PATCH net-next 3/3] selftests: lan743x: Add testcase to check throughput of lan743x

2024-09-03 Thread Mohan Prasad J
Add testcase to check TCP throughput of lan743x network driver. Test uses iperf3 to do performance testing of the driver. TCP data at different speeds is sent, received and verified. Signed-off-by: Mohan Prasad J --- .../net/hw/microchip/lan743x/lan743x.py | 33 +++ 1 file

[PATCH net-next 2/3] selftests: lan743x: Add testcase to check speed and duplex state of lan743x

2024-09-03 Thread Mohan Prasad J
Add testcase for checking speed and duplex states for lan743x network driver. Testcase comprises of varying the network speed and duplex state to 10/100/1000Mbps and half/full via ethtool. Signed-off-by: Mohan Prasad J --- .../net/hw/microchip/lan743x/lan743x.py | 33

[PATCH net-next 1/3] selftests: lan743x: Add testfile for lan743x network driver

2024-09-03 Thread Mohan Prasad J
list. Signed-off-by: Mohan Prasad J --- MAINTAINERS | 2 + tools/testing/selftests/Makefile | 2 +- .../drivers/net/hw/microchip/lan743x/Makefile | 7 +++ .../net/hw/microchip/lan743x/lan743x.py | 51 +++ .../hw/microchip

[PATCH net-next 0/3] lan743x: This series of patches are for lan743x driver testing

2024-09-03 Thread Mohan Prasad J
This series of patches are for testing the lan743x network driver. Testing comprises autonegotiation, speed, duplex and throughput checks. Tools such as ethtool, iperf3 are used in the testing process. Performance test is done for TCP streams at different speeds. Signed-off-by: Mohan Prasad J

Re: [PATCH] ACPI: NFIT: add missing MODULE_DESCRIPTION() macro

2024-06-13 Thread Rafael J. Wysocki
On Thu, Jun 6, 2024 at 6:10 PM Dave Jiang wrote: > > > > On 6/3/24 6:30 AM, Jeff Johnson wrote: > > make allmodconfig && make W=1 C=1 reports: > > WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/acpi/nfit/nfit.o > > > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > >

Re: [PATCH v2] PM: runtime: add tracepoint for runtime_status changes

2024-02-22 Thread Rafael J. Wysocki
On Wed, Feb 21, 2024 at 8:49 PM Vilas Bhat wrote: > > Existing runtime PM ftrace events (`rpm_suspend`, `rpm_resume`, > `rpm_return_int`) offer limited visibility into the exact timing of device > runtime power state transitions, particularly when asynchronous operations > are involved. When the `

Re: [PATCH v1 1/1] ACPI: NFIT: Switch to use acpi_evaluate_dsm_typed()

2024-02-02 Thread Rafael J. Wysocki
On Fri, Feb 2, 2024 at 4:49 PM Andy Shevchenko wrote: > > On Mon, Nov 20, 2023 at 07:19:44PM +0200, Andy Shevchenko wrote: > > On Mon, Nov 20, 2023 at 04:11:54PM +0100, Rafael J. Wysocki wrote: > > > On Mon, Nov 20, 2023 at 4:03 PM Andy Shevchenko > > > wrote: >

Re: [PATCH v3 1/2] eventfs: Have the inodes all for files and directories all be the same

2024-01-22 Thread Darrick J. Wong
On Mon, Jan 22, 2024 at 02:02:28PM -0800, Linus Torvalds wrote: > On Mon, 22 Jan 2024 at 13:59, Darrick J. Wong wrote: > > > > though I don't think > > leaking raw kernel pointers is an awesome idea. > > Yeah, I wasn't all that comfortable even with

Re: [PATCH v3 1/2] eventfs: Have the inodes all for files and directories all be the same

2024-01-22 Thread Darrick J. Wong
On Tue, Jan 16, 2024 at 05:55:32PM -0500, Steven Rostedt wrote: > From: "Steven Rostedt (Google)" > > The dentries and inodes are created in the readdir for the sole purpose of > getting a consistent inode number. Linus stated that is unnecessary, and > that all inodes can have the same inode num

Re: [PATCH v2 1/5] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-21 Thread Rafael J. Wysocki
On Thu, Dec 21, 2023 at 8:57 PM Rafael J. Wysocki wrote: > > On Thu, Dec 21, 2023 at 4:24 PM Vincent Guittot > wrote: > > > > Provide to the scheduler a feedback about the temporary max available > > capacity. Unlike arch_update_thermal_pressure, this doesn'

Re: [PATCH v2 1/5] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-21 Thread Rafael J. Wysocki
icy *policy) > +{ > + unsigned long max_capacity, capped_freq, pressure; > + u32 max_freq; > + int cpu; > + > + cpu = cpumask_first(policy->related_cpus); > + pressure = max_capacity = arch_scale_cpu_capacity(cpu); I would prefer two separate

Re: [PATCH 1/4] cpufreq: Add a cpufreq pressure feedback for the scheduler

2023-12-14 Thread Rafael J. Wysocki
On Thu, Dec 14, 2023 at 10:07 AM Lukasz Luba wrote: > > On 12/14/23 07:57, Vincent Guittot wrote: > > On Thu, 14 Dec 2023 at 06:43, Viresh Kumar wrote: > >> > >> On 12-12-23, 15:27, Vincent Guittot wrote: > >>> @@ -2618,6 +2663,9 @@ static int cpufreq_set_policy(struct cpufreq_policy > >>> *poli

Re: [PATCH v1 1/1] ACPI: NFIT: Switch to use acpi_evaluate_dsm_typed()

2023-11-20 Thread Rafael J. Wysocki
On Mon, Nov 20, 2023 at 4:03 PM Andy Shevchenko wrote: > > On Thu, Oct 19, 2023 at 06:03:28PM -0700, Dan Williams wrote: > > Andy Shevchenko wrote: > > > The acpi_evaluate_dsm_typed() provides a way to check the type of the > > > object evaluated by _DSM call. Use it instead of open coded variant.

[GIT PULL] ACPI fix for v6.6-rc8

2023-10-25 Thread Rafael J. Wysocki
Hi Linus, Please pull from the tag git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git \ acpi-6.6-rc8 with top-most commit 9b311b7313d6c104dd4a2d43ab54536dce07f960 ACPI: NFIT: Install Notify() handler before getting NFIT table on top of commit f20f29cbcb438ca37962d22735f74a143

Re: [PATCH v2] ACPI: NFIT: Optimize nfit_mem_cmp() for efficiency

2023-10-18 Thread Rafael J. Wysocki
On Fri, Oct 13, 2023 at 2:22 PM Kuan-Wei Chiu wrote: > > The original code used conditional branching in the nfit_mem_cmp > function to compare two values and return -1, 1, or 0 based on the > result. However, the list_sort comparison function only needs results > <0, >0, or =0. This patch optimiz

Re: [PATCH v3] ACPI: NFIT: Use cleanup.h helpers instead of devm_*()

2023-10-18 Thread Rafael J. Wysocki
On Wed, Oct 18, 2023 at 6:28 AM Dan Williams wrote: > > Michal Wilczynski wrote: > > The new cleanup.h facilities that arrived in v6.5-rc1 can replace the > > the usage of devm semantics in acpi_nfit_init_interleave_set(). That > > routine appears to only be using devm to avoid goto statements. Th

Re: [PATCH v2 5/6] ACPI: NFIT: Replace acpi_driver with platform_driver

2023-10-17 Thread Rafael J. Wysocki
nctioning of the whole devm_*() family of > functions, since the lifecycle of the device stays the same. It is still > being created during the enumeration, and destroyed on platform device > removal. > > Suggested-by: Rafael J. Wysocki > Signed-off-by

Re: [PATCH v3 4/6] ACPI: AC: Rename ACPI device from device to adev

2023-10-17 Thread Rafael J. Wysocki
On Wed, Oct 11, 2023 at 10:34 AM Michal Wilczynski wrote: > > Since transformation from ACPI driver to platform driver there are two > devices on which the driver operates - ACPI device and platform device. > For the sake of reader this calls for the distinction in their naming, > to avoid confusi

Re: [PATCH v2 5/6] ACPI: NFIT: Replace acpi_driver with platform_driver

2023-10-17 Thread Rafael J. Wysocki
gt; NFIT driver uses devm_*() family of functions extensively. This change > > has no impact on correct functioning of the whole devm_*() family of > > functions, since the lifecycle of the device stays the same. It is still > > being created during the enumeration, and destroye

Re: [PATCH v3 2/6] ACPI: AC: Use string_choices API instead of ternary operator

2023-10-13 Thread Rafael J. Wysocki
On Wed, Oct 11, 2023 at 10:34 AM Michal Wilczynski wrote: > > Use modern string_choices API instead of manually determining the > output using ternary operator. > > Suggested-by: Andy Shevchenko > Reviewed-by: Andy Shevchenko > Signed-off-by: Michal Wilczynski > --- > drivers/acpi/ac.c | 5 +++

Re: [PATCH v3 1/6] ACPI: AC: Remove unnecessary checks

2023-10-13 Thread Rafael J. Wysocki
On Wed, Oct 11, 2023 at 10:34 AM Michal Wilczynski wrote: > > Remove unnecessary checks for NULL for variables that can't be NULL at > the point they're checked for it. Defensive programming is discouraged > in the kernel. > > Signed-off-by: Michal Wilczynski > --- > drivers/acpi/ac.c | 27 -

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-09 Thread Rafael J. Wysocki
On Mon, Oct 9, 2023 at 3:04 PM Wilczynski, Michal wrote: > > > > On 10/9/2023 2:27 PM, Rafael J. Wysocki wrote: > > On Mon, Oct 9, 2023 at 10:40 AM Wilczynski, Michal > > wrote: > >> [cut] > >> Yeah we could add platform device without removing acpi

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-09 Thread Rafael J. Wysocki
On Mon, Oct 9, 2023 at 10:40 AM Wilczynski, Michal wrote: > > > Hi ! > > Thanks a lot for a review, to both of you ! :-) > > On 10/7/2023 12:43 PM, Rafael J. Wysocki wrote: > > On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote: > >> On Sat, Oc

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-07 Thread Rafael J. Wysocki
On Sat, Oct 7, 2023 at 12:41 PM Rafael J. Wysocki wrote: > > On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko > wrote: > > > > On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote: > > > On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski > > >

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-07 Thread Rafael J. Wysocki
On Sat, Oct 7, 2023 at 9:56 AM Andy Shevchenko wrote: > > On Fri, Oct 06, 2023 at 09:47:57PM +0200, Rafael J. Wysocki wrote: > > On Fri, Oct 6, 2023 at 8:33 PM Michal Wilczynski > > wrote: > > ... > > > > struct acpi_ac { > > > struc

Re: [PATCH v2 3/6] ACPI: AC: Replace acpi_driver with platform_driver

2023-10-06 Thread Rafael J. Wysocki
d a blank line to distinguish pdev API vs local ACPI notify function. > > Suggested-by: Rafael J. Wysocki > Signed-off-by: Michal Wilczynski > --- > drivers/acpi/ac.c | 70 +-- > 1 file changed, 37 insertions(+), 33 deletions(

Re: [PATCH v1 2/9] docs: firmware-guide: ACPI: Clarify ACPI bus concepts

2023-10-06 Thread Rafael J. Wysocki
On Thu, Oct 5, 2023 at 10:39 PM Wilczynski, Michal wrote: > > > > On 10/5/2023 8:28 PM, Wilczynski, Michal wrote: > > > > On 10/5/2023 7:57 PM, Rafael J. Wysocki wrote: > >> On Monday, September 25, 2023 4:48:35 PM CEST Michal Wilczynski wrote: > >>> S

Re: [PATCH v1 1/9] ACPI: bus: Make notify wrappers more generic

2023-10-05 Thread Rafael J. Wysocki
On Thu, Oct 5, 2023 at 8:27 PM Wilczynski, Michal wrote: > > > > On 10/5/2023 7:03 PM, Rafael J. Wysocki wrote: > > On Thursday, October 5, 2023 5:30:59 PM CEST Rafael J. Wysocki wrote: > >> On Thu, Oct 5, 2023 at 2:05 PM Wilczynski, Michal > >> wrote: &

Re: [PATCH v1 2/9] docs: firmware-guide: ACPI: Clarify ACPI bus concepts

2023-10-05 Thread Rafael J. Wysocki
device interfaces with the FW, and the platform device with the rest of > +the system. > + > DMA support > === I rewrote the above entirely, so here's a new patch to replace this one: --- From: Rafael J. Wysocki Subject: [PATCH v2 2/9] ACPI: docs: enumeration: Clarify ACPI bus

Re: [PATCH v1 1/9] ACPI: bus: Make notify wrappers more generic

2023-10-05 Thread Rafael J. Wysocki
On Thursday, October 5, 2023 5:30:59 PM CEST Rafael J. Wysocki wrote: > On Thu, Oct 5, 2023 at 2:05 PM Wilczynski, Michal > wrote: > > On 10/5/2023 12:57 PM, Rafael J. Wysocki wrote: > > > On Thu, Oct 5, 2023 at 10:10 AM Wilczynski, Michal > > > wrote: > >

Re: [PATCH v1 1/9] ACPI: bus: Make notify wrappers more generic

2023-10-05 Thread Rafael J. Wysocki
On Thu, Oct 5, 2023 at 2:05 PM Wilczynski, Michal wrote: > On 10/5/2023 12:57 PM, Rafael J. Wysocki wrote: > > On Thu, Oct 5, 2023 at 10:10 AM Wilczynski, Michal > > wrote: [cut] > >>> > >>> That said, why exactly is it better to use acpi_handle instea

Re: [PATCH v1 1/9] ACPI: bus: Make notify wrappers more generic

2023-10-05 Thread Rafael J. Wysocki
On Thu, Oct 5, 2023 at 10:10 AM Wilczynski, Michal wrote: > > Hi, > > Thanks for your review ! > > On 10/4/2023 9:09 PM, Rafael J. Wysocki wrote: > > On Mon, Sep 25, 2023 at 6:31 PM Michal Wilczynski > > wrote: > >> acpi_dev_install_notify_handler() and ac

Re: [PATCH v1 1/9] ACPI: bus: Make notify wrappers more generic

2023-10-04 Thread Rafael J. Wysocki
On Mon, Sep 25, 2023 at 6:31 PM Michal Wilczynski wrote: > > acpi_dev_install_notify_handler() and acpi_dev_remove_notify_handler() > are wrappers around ACPICA installers. They are meant to save some > duplicated code from drivers. However as we're moving towards drivers > operating on platform_d

Re: SPDX: Appletalk FW license in the kernel

2023-09-26 Thread J Lovejoy
On 9/26/23 1:34 AM, Christoph Hellwig wrote: On Fri, Sep 15, 2023 at 09:39:05AM -0400, Prarit Bhargava wrote: Is there anyone you know of that we could approach to determine a proper SPDX License for these files? Answering this question generally, even though it sounds like it wasn't needed

Re: [PATCH v7 0/9] Remove .notify callback in acpi_device_ops

2023-07-14 Thread Rafael J. Wysocki
On Mon, Jul 3, 2023 at 10:03 AM Michal Wilczynski wrote: > > *** IMPORTANT *** > This is part 1 - only drivers in acpi directory to ease up review > process. Rest of the drivers will be handled in separate patchsets. > > Currently drivers support ACPI event handlers by defining .notify > callback

Re: [PATCH v7 8/9] acpi/nfit: Remove unnecessary .remove callback

2023-07-13 Thread Rafael J. Wysocki
On Mon, Jul 3, 2023 at 10:03 AM Michal Wilczynski wrote: > > Nfit driver doesn't use .remove() callback and provide an empty function > as it's .remove() callback. Remove empty acpi_nfit_remove() and > initialization of callback. > > Suggested-by: Dan Williams > Signed-off-by: Michal Wilczynski

Re: [PATCH v7 7/9] acpi/nfit: Move handler installing logic to driver

2023-07-13 Thread Rafael J. Wysocki
> > Move acpi_nfit_notify() upwards in the file, so it can be used inside > acpi_nfit_add() and acpi_nfit_remove_notify_handler(). Dan, any objections? > Suggested-by: Rafael J. Wysocki > Signed-off-by: Michal Wilczynski > --- > drivers/acpi/nfit/core.c | 41 +

Re: [PATCH] ACPICA: actbl2: change to be16/be32 types for big endian data

2023-07-04 Thread Rafael J. Wysocki
On Mon, Jul 3, 2023 at 3:01 PM Ben Dooks wrote: > > Some of the fields in struct acpi_nfit_control_region are used in big > endian format, and thus are generatng warnings from spare where the > member is passed to one of the conversion functions. > > Fix the following sparse warnings by changing t

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

2023-06-30 Thread Rafael J. Wysocki
On Fri, Jun 30, 2023 at 1:04 PM Rafael J. Wysocki wrote: > > On Fri, Jun 30, 2023 at 11:52 AM Wilczynski, Michal > wrote: > > > > > > > > On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote: > > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > >

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

2023-06-30 Thread Rafael J. Wysocki
On Fri, Jun 30, 2023 at 11:52 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 6:14 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> Currently terminator line contains redunant characters. > > Well, they a

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

2023-06-30 Thread Rafael J. Wysocki
On Fri, Jun 30, 2023 at 11:55 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 6:18 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> Currently logic for installing notifications from ACPI devices is > >

Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit_notify() before acpi_nfit_add()

2023-06-30 Thread Rafael J. Wysocki
On Fri, Jun 30, 2023 at 11:48 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 6:06 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> To use new style of installing event handlers acpi_nfit_notify() needs >

Re: [PATCH v5 03/10] acpi/ac: Move handler installing logic to driver

2023-06-30 Thread Rafael J. Wysocki
On Fri, Jun 30, 2023 at 11:41 AM Rafael J. Wysocki wrote: > > On Fri, Jun 30, 2023 at 11:39 AM Wilczynski, Michal > wrote: > > > > > > > > On 6/29/2023 5:55 PM, Rafael J. Wysocki wrote: > > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > >

Re: [PATCH v5 03/10] acpi/ac: Move handler installing logic to driver

2023-06-30 Thread Rafael J. Wysocki
On Fri, Jun 30, 2023 at 11:39 AM Wilczynski, Michal wrote: > > > > On 6/29/2023 5:55 PM, Rafael J. Wysocki wrote: > > On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski > > wrote: > >> Currently logic for installing notifications from ACPI devices is > >

Re: [PATCH v5 09/10] acpi/nfit: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
ndler() at the beginning of .remove() > callback. Change arguments passed to the notify function to match with > what's required by acpi_install_notify_handler(). Remove .notify > callback initialization in acpi_driver. > > Suggested-by: Rafael J. Wysocki > Signed-off-by:

Re: [PATCH v5 08/10] acpi/nfit: Improve terminator line in acpi_nfit_ids

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > Currently terminator line contains redunant characters. Well, they are terminating the list properly AFAICS, so they aren't redundant and the size of it before and after the change is actually the same, isn't it? > Remove them and also

Re: [PATCH v5 07/10] acpi/nfit: Move acpi_nfit_notify() before acpi_nfit_add()

2023-06-29 Thread Rafael J. Wysocki
On Fri, Jun 16, 2023 at 6:51 PM Michal Wilczynski wrote: > > To use new style of installing event handlers acpi_nfit_notify() needs > to be known inside acpi_nfit_add(). Move acpi_nfit_notify() upwards in > the file, so it can be used inside acpi_nfit_add(). > > Signed-off-by: Michal Wilczynski >

Re: [PATCH v5 05/10] acpi/battery: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
ndler() at the beginning of .remove() > callback. Change arguments passed to the notify function to match with > what's required by acpi_install_notify_handler(). Remove .notify > callback initialization in acpi_driver. > > While at it, fix lack of whitespaces in .remove() callback. >

Re: [PATCH v5 04/10] acpi/video: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
ndler() at the beginning of .remove() > callback. Change arguments passed to the notify function to match with > what's required by acpi_install_notify_handler(). Remove .notify > callback initialization in acpi_driver. > > Suggested-by: Rafael J. Wysocki > Signed-off-by:

Re: [PATCH v5 03/10] acpi/ac: Move handler installing logic to driver

2023-06-29 Thread Rafael J. Wysocki
ndler() at the beginning of .remove() > callback. Change arguments passed to the notify function to match with > what's required by acpi_install_notify_handler(). Remove .notify > callback initialization in acpi_driver. > > Suggested-by: Rafael J. Wysocki > Signed-

Re: [PATCH 1/3] acpi: nfit: add declaration in a local header

2023-06-05 Thread Rafael J. Wysocki
On Mon, May 22, 2023 at 5:22 PM Dave Jiang wrote: > > > > On 5/16/23 1:14 PM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > The nfit_intel_shutdown_status() function has a __weak defintion > > in nfit.c and an override in acpi_nfit_test.c for testing > > purposes. This works without an ext

Re: [RFC PATCH] xfs: check shared state of when CoW, update reflink flag when io ends

2023-03-21 Thread Darrick J. Wong
On Mon, Mar 20, 2023 at 06:02:05PM +0800, Shiyang Ruan wrote: > > > 在 2023/3/18 4:35, Darrick J. Wong 写道: > > On Fri, Mar 17, 2023 at 03:59:48AM +, Shiyang Ruan wrote: > > > As is mentioned[1] before, the generic/388 will randomly fail with dmesg > > > warni

Re: [RFC PATCH] xfs: check shared state of when CoW, update reflink flag when io ends

2023-03-17 Thread Darrick J. Wong
On Fri, Mar 17, 2023 at 03:59:48AM +, Shiyang Ruan wrote: > As is mentioned[1] before, the generic/388 will randomly fail with dmesg > warning. This case uses fsstress with a lot of random operations. It is hard > to reproduce. Finally I found a 100% reproduce condition, which is setting >

Re: [PATCH v2.2 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-07 Thread Darrick J. Wong
> Also, the flag needs to be renamed to PAGE_MAPPING_DAX_SHARED. > > Signed-off-by: Shiyang Ruan > Reviewed-by: Allison Henderson Looks fine to me, Reviewed-by: Darrick J. Wong --D > --- > fs/dax.c | 38 ++ > inclu

Re: [PATCH v2.1 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-04 Thread Darrick J. Wong
On Mon, Dec 05, 2022 at 01:56:24PM +0800, Shiyang Ruan wrote: > > > 在 2022/12/3 10:07, Dan Williams 写道: > > Shiyang Ruan wrote: > > > fsdax page is used not only when CoW, but also mapread. To make the it > > > easily understood, use 'share' to indicate that the dax page is shared > > > by more t

Re: [PATCH v2 8/8] xfs: remove restrictions for fsdax and reflink

2022-12-01 Thread Darrick J. Wong
On Thu, Dec 01, 2022 at 03:32:53PM +, Shiyang Ruan wrote: > Since the basic function for fsdax and reflink has been implemented, > remove the restrictions of them for widly test. > > Signed-off-by: Shiyang Ruan Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/x

Re: [PATCH v2 6/8] xfs: use dax ops for zero and truncate in fsdax mode

2022-12-01 Thread Darrick J. Wong
On Thu, Dec 01, 2022 at 03:32:10PM +, Shiyang Ruan wrote: > Zero and truncate on a dax file may execute CoW. So use dax ops which > contains end work for CoW. > > Signed-off-by: Shiyang Ruan LGTM Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/xfs_iomap.c | 4 ++-- &g

Re: [PATCH v2 5/8] fsdax: dedupe: iter two files at the same time

2022-12-01 Thread Darrick J. Wong
hem called at the same time. > > Signed-off-by: Shiyang Ruan Thank you for adding that explanation, it makes the problem much more obvious. :) Reviewed-by: Darrick J. Wong --D > --- > fs/dax.c | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > di

Re: [PATCH v2 4/8] fsdax,xfs: set the shared flag when file extent is shared

2022-12-01 Thread Darrick J. Wong
; > Signed-off-by: Shiyang Ruan Makes sense. Reviewed-by: Darrick J. Wong --D > --- > fs/dax.c | 19 +++ > fs/xfs/xfs_iomap.c | 2 +- > 2 files changed, 8 insertions(+), 13 deletions(-) > > diff --git a/fs/dax.c b/fs/dax.c > index 6b6e07ad8d8

Re: [PATCH v2 3/8] fsdax: zero the edges if source is HOLE or UNWRITTEN

2022-12-01 Thread Darrick J. Wong
t; - * dax_iomap_cow_copy - Copy the data from source to destination before write > + * dax_iomap_copy_around - Copy the data from source to destination before > write * dax_iomap_copy_around - Prepare for an unaligned write to a * shared/cow page by copying the data before and after the range

Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-12-01 Thread Darrick J. Wong
On Thu, Dec 01, 2022 at 11:39:12PM +0800, Shiyang Ruan wrote: > > > 在 2022/12/1 5:08, Darrick J. Wong 写道: > > On Tue, Nov 29, 2022 at 11:05:30PM -0800, Dan Williams wrote: > > > Darrick J. Wong wrote: > > > > On Tue, Nov 29, 2022 at 07:59:14PM -0800, Dan Wi

Re: [PATCH v2 2/8] fsdax: invalidate pages when CoW

2022-12-01 Thread Darrick J. Wong
> share state when CoW happens, in both dax_iomap_rw() and > dax_zero_iter(). > > Signed-off-by: Shiyang Ruan Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/dax.c | 17 + > 1 file changed, 13 insertions(+), 4 deletions(-) > > diff --git a

Re: [PATCH v2 1/8] fsdax: introduce page->share for fsdax in reflink mode

2022-12-01 Thread Darrick J. Wong
On Thu, Dec 01, 2022 at 03:28:51PM +, Shiyang Ruan wrote: > fsdax page is used not only when CoW, but also mapread. To make the it > easily understood, use 'share' to indicate that the dax page is shared > by more than one extent. And add helper functions to use it. > > Also, the flag needs t

Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-30 Thread Darrick J. Wong
On Wed, Nov 30, 2022 at 01:48:59PM -0800, Dan Williams wrote: > Andrew Morton wrote: > > On Tue, 29 Nov 2022 19:59:14 -0800 Dan Williams > > wrote: > > > > > [ add Andrew ] > > > > > > Shiyang Ruan wrote: > > > > Many testcases failed in dax+reflink mode with warning message in dmesg. > > > > T

Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-30 Thread Darrick J. Wong
On Tue, Nov 29, 2022 at 11:05:30PM -0800, Dan Williams wrote: > Darrick J. Wong wrote: > > On Tue, Nov 29, 2022 at 07:59:14PM -0800, Dan Williams wrote: > > > [ add Andrew ] > > > > > > Shiyang Ruan wrote: > > > > Many testcases failed i

Re: [PATCH 1/2] fsdax,xfs: fix warning messages at dax_[dis]associate_entry()

2022-11-30 Thread Darrick J. Wong
On Wed, Nov 30, 2022 at 04:58:32PM +0800, Shiyang Ruan wrote: > > > 在 2022/11/30 12:08, Darrick J. Wong 写道: > > On Thu, Nov 24, 2022 at 02:54:53PM +, Shiyang Ruan wrote: > > > This patch fixes the warning message reported in dax_associate_entry() > >

Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-29 Thread Darrick J. Wong
On Tue, Nov 29, 2022 at 07:59:14PM -0800, Dan Williams wrote: > [ add Andrew ] > > Shiyang Ruan wrote: > > Many testcases failed in dax+reflink mode with warning message in dmesg. > > This also effects dax+noreflink mode if we run the test after a > > dax+reflink test. So, the most urgent thing i

Re: [PATCH 1/2] fsdax,xfs: fix warning messages at dax_[dis]associate_entry()

2022-11-29 Thread Darrick J. Wong
On Thu, Nov 24, 2022 at 02:54:53PM +, Shiyang Ruan wrote: > This patch fixes the warning message reported in dax_associate_entry() > and dax_disassociate_entry(). Hmm, that's quite a bit to put in a single patch, but I'll try to get through this... > 1. reset page->mapping and ->index when re

Re: [PATCH 2/2] fsdax,xfs: port unshare to fsdax

2022-11-29 Thread Darrick J. Wong
On Thu, Nov 24, 2022 at 02:54:54PM +, Shiyang Ruan wrote: > Implement unshare in fsdax mode: copy data from srcmap to iomap. > > Signed-off-by: Shiyang Ruan Heh, I had a version nearly like this in my tree. Makes reviewing easier: Reviewed-by: Darrick J. Wong --D > ---

Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-28 Thread Darrick J. Wong
On Mon, Nov 28, 2022 at 10:16:23AM +0800, Shiyang Ruan wrote: > > > 在 2022/11/28 2:38, Darrick J. Wong 写道: > > On Thu, Nov 24, 2022 at 02:54:52PM +, Shiyang Ruan wrote: > > > Many testcases failed in dax+reflink mode with warning message in dmesg. > > > Thi

Re: [PATCH 0/2] fsdax,xfs: fix warning messages

2022-11-27 Thread Darrick J. Wong
On Thu, Nov 24, 2022 at 02:54:52PM +, Shiyang Ruan wrote: > Many testcases failed in dax+reflink mode with warning message in dmesg. > This also effects dax+noreflink mode if we run the test after a > dax+reflink test. So, the most urgent thing is solving the warning > messages. > > Patch 1 f

Re: [PATCH v2 2/2] ACPI: HMAT: Fix initiator registration for single-initiator systems

2022-11-17 Thread Rafael J. Wysocki
nd generate the nodemask, decoupling it from the overloaded initiator_cmp() comparision callback. This prevents the singular list corner case naturally, and makes the code easier to follow as well. Cc: Cc: Rafael J. Wysocki Cc: Liu Shixin Cc: Dan Williams Cc: Kirill A. Shutemov Reported-by: Chris Pi

Re: [PATCH 0/2] ACPI: HMAT: fix single-initiator target registrations

2022-11-16 Thread Rafael J. Wysocki
: > ACPI: HMAT: remove unnecessary variable initialization > ACPI: HMAT: Fix initiator registration for single-initiator systems Acked-by: Rafael J. Wysocki for both and please feel free to ask Dan to take them. Alternatively, if you want me to apply them, please let me know. &g

Re: [RFC PATCH] xfs: drop experimental warning for fsdax

2022-10-19 Thread Darrick J. Wong
On Sun, Oct 16, 2022 at 10:05:17PM +0800, Shiyang Ruan wrote: > > > 在 2022/10/14 23:50, Darrick J. Wong 写道: > > On Fri, Oct 14, 2022 at 10:24:29AM +0800, Shiyang Ruan wrote: > > > > > > > > > 在 2022/10/14 2:30, Darrick J. Wong 写道: > > > &g

Re: [RFC PATCH] xfs: drop experimental warning for fsdax

2022-10-14 Thread Darrick J. Wong
On Fri, Oct 14, 2022 at 10:24:29AM +0800, Shiyang Ruan wrote: > > > 在 2022/10/14 2:30, Darrick J. Wong 写道: > > On Thu, Sep 29, 2022 at 12:05:14PM -0700, Darrick J. Wong wrote: > > > On Wed, Sep 28, 2022 at 10:46:17PM +0800, Shiyang Ruan wrote: > > > > >

  1   2   3   4   5   6   7   8   9   10   >