Re: [PATCH] HID: sony: Support for DS4 clones that do not implement feature report 0x81

2021-02-12 Thread Ivan Mironov
Ignore this patch, I am working on a better one. On Wed, 2021-01-13 at 22:34 +0500, Ivan Mironov wrote: > There are clones of DualShock 4 that are very similar to the originals, > except of 1) they do not support HID feature report 0x81 and 2) they do > not have any USB Audio interface

[PATCH] HID: sony: Support for DS4 clones that do not implement feature report 0x81

2021-01-13 Thread Ivan Mironov
/1b74a4440089f38a24ee2c2483c1d733a0692b8f/DS4Windows/HidLibrary/HidDevice.cs#L479 Signed-off-by: Ivan Mironov --- drivers/hid/hid-sony.c | 72 ++ 1 file changed, 52 insertions(+), 20 deletions(-) diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c

Re: [PATCH v1] drm/amd/powerplay: Fix NULL dereference in lock_bus() on Vega20 w/o RAS

2020-06-25 Thread Ivan Mironov
Issue still reproduces on latest 5.8.0-rc2+ (8be3a53e18e0e1a98f288f6c7f5e9da3adbe9c49).

[PATCH v1] drm/amd/powerplay: Fix NULL dereference in lock_bus() on Vega20 w/o RAS

2020-06-25 Thread Ivan Mironov
ny sense when there is no HW support. Cc: sta...@vger.kernel.org Fixes: 9015d60c9ee1 ("drm/amdgpu: Move EEPROM I2C adapter to amdgpu_device") Signed-off-by: Ivan Mironov Tested-by: Bjorn Nostvold --- Changelog: v1: - Added "Tested-by" for another user who used this pa

[PATCH] drm/amd/powerplay: Fix NULL dereference in lock_bus() on Vega20 w/o RAS

2020-06-16 Thread Ivan Mironov
ny sense when there is no HW support. Cc: sta...@vger.kernel.org Fixes: 9015d60c9ee1 ("drm/amdgpu: Move EEPROM I2C adapter to amdgpu_device") Signed-off-by: Ivan Mironov --- drivers/gpu/drm/amd/powerplay/smumgr/vega20_smumgr.c | 11 +++ 1 file changed, 7 insertions(+), 4

Re: [RFC PATCH 0/2] Fix for the internal card reader and suspend on MacBooks

2019-02-25 Thread Ivan Mironov
On Thu, 2019-02-14 at 22:32 +0500, Ivan Mironov wrote: > On Thu, 2019-02-14 at 06:40 +0500, Ivan Mironov wrote: > > Unfortunately, everything broke again after yet another suspend/resume. > > Currently I'm suspecting that my patch maybe only helps to survive the > > short

Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-02-14 Thread Ivan Mironov
On Thu, 2019-02-07 at 18:26 -0700, Jerry Hoemann wrote: > The name is not the best given its current use, but I'm not sure a > name change would be allowed. > > However, I will send a patch to update the documentation in Kconfig. > > Thanks!

Re: [RFC PATCH 0/2] Fix for the internal card reader and suspend on MacBooks

2019-02-14 Thread Ivan Mironov
On Thu, 2019-02-14 at 06:40 +0500, Ivan Mironov wrote: > Unfortunately, everything broke again after yet another suspend/resume. > Currently I'm suspecting that my patch maybe only helps to survive the > short suspend, but not the long one. > > After this bad suspend

Re: [RFC PATCH 0/2] Fix for the internal card reader and suspend on MacBooks

2019-02-14 Thread Ivan Mironov
On Thu, 2019-02-14 at 17:03 +0200, Mathias Nyman wrote: > This card reader prevents second system suspend on latest kernels, see thread: > https://marc.info/?l=linux-usb&m=154816680816246&w=2 > > In that case the card reader fails to resume from usb3 U3 suspend state, > and ends up stuck in USB3 p

Re: [RFC PATCH 0/2] Fix for the internal card reader and suspend on MacBooks

2019-02-13 Thread Ivan Mironov
Unfortunately, everything broke again after yet another suspend/resume. Currently I'm suspecting that my patch maybe only helps to survive the short suspend, but not the long one. After this bad suspend/resume, card reader disappeared again. Debug logging was not enabled this time, so not too many

[RFC PATCH 2/2] usb: quirks: Add quirk to fix card reader and suspend on MacBooks

2019-02-13 Thread Ivan Mironov
This enabled USB_QUIRK_DISABLE_LINK_ON_SUSPEND for the embedded SD card reader used in Apple MacBook laptops. Link: https://bugzilla.kernel.org/show_bug.cgi?id=111201 Link: https://bugzilla.kernel.org/show_bug.cgi?id=202509 Signed-off-by: Ivan Mironov --- drivers/usb/core/quirks.c | 4 1

[RFC PATCH 1/2] usb: core: Add support of disabling SS link before system suspend

2019-02-13 Thread Ivan Mironov
ow_bug.cgi?id=111201 Link: https://bugzilla.kernel.org/show_bug.cgi?id=202509 Signed-off-by: Ivan Mironov --- drivers/usb/core/driver.c | 6 +++ drivers/usb/core/hub.c | 84 -- drivers/usb/core/quirks.c | 3 ++ include/linux/usb.h| 3 ++ includ

[RFC PATCH 0/2] Fix for the internal card reader and suspend on MacBooks

2019-02-13 Thread Ivan Mironov
.org/show_bug.cgi?id=111201 [2] https://bugzilla.kernel.org/show_bug.cgi?id=202509 [3] https://www.spinics.net/lists/linux-usb/msg164261.html [4] https://github.com/im-0/investigate-card-reader-suspend-problem-on-mbp11.4 Ivan Mironov (2): usb: core: Add support of disabling SS link before sys

[PATCH] USB: serial: cp210x: Add ID for Ingenico 3070

2019-02-06 Thread Ivan Mironov
usb 3-1: Manufacturer: Silicon Labs usb 3-1: SerialNumber: 0001 Apparently this is a POS terminal with embedded USB-to-Serial converter. Cc: sta...@vger.kernel.org Signed-off-by: Ivan Mironov --- drivers/usb/serial/cp210x.c | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [RFC PATCH 0/4] watchdog: hpwdt: Fix NMI-related behaviour when CONFIG_HPWDT_NMI_DECODING is enabled

2019-02-01 Thread Ivan Mironov
On Tue, 2019-01-15 at 19:22 -0700, Jerry Hoemann wrote: > On Mon, Jan 14, 2019 at 07:36:13AM +0500, Ivan Mironov wrote: > > Hi, > > > > I found out that hpwdt alters NMI behaviour unexpectedly if compiled > > with enabled CONFIG_HPWDT_NMI_DECODING: > > > &g

Re: [RFC PATCH 4/4] watchdog: hpwdt: Make panic behaviour configurable

2019-02-01 Thread Ivan Mironov
On Tue, 2019-01-15 at 19:30 -0700, Jerry Hoemann wrote: > On Mon, Jan 14, 2019 at 07:36:17AM +0500, Ivan Mironov wrote: > > This adds an option to not panic on NMI even if it was caused by iLO. > > > > Signed-off-by: Ivan Mironov > > --- > &g

Re: [RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-02-01 Thread Ivan Mironov
On Tue, 2019-01-15 at 19:27 -0700, Jerry Hoemann wrote: > On Mon, Jan 14, 2019 at 07:36:14AM +0500, Ivan Mironov wrote: > > Existing code disables watchdog on NMI right before completely hanging > > the system. > > > > There are two problems here: > > > >

[RFC PATCH 3/4] watchdog: hpwdt: Add more information into message

2019-01-13 Thread Ivan Mironov
Default NMI handling code prints the same into the kernel log. Signed-off-by: Ivan Mironov --- drivers/watchdog/hpwdt.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index e2958df46c69..95d002b5b120

[RFC PATCH 1/4] watchdog: hpwdt: Don't disable watchdog on NMI

2019-01-13 Thread Ivan Mironov
: Ivan Mironov --- drivers/watchdog/hpwdt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index ef30c7e9728d..2467e6bc25c2 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -170,8 +170,6 @@ static int hpwdt_pretimeout

[RFC PATCH 2/4] watchdog: hpwdt: Don't panic on foreign NMI

2019-01-13 Thread Ivan Mironov
ned-off-by: Ivan Mironov --- drivers/watchdog/hpwdt.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 2467e6bc25c2..e2958df46c69 100644 --- a/drivers/watchdog/hpwdt.c +++ b/drivers/watchdog/hpwdt.c @@ -33,7 +33,6 @

[RFC PATCH 0/4] watchdog: hpwdt: Fix NMI-related behaviour when CONFIG_HPWDT_NMI_DECODING is enabled

2019-01-13 Thread Ivan Mironov
RFC patch series because I am not sure that patches are correct. Questions: * Are "mynmi" flags always set on all supported iLO versions when iLO is the source of NMI? * Is it safe to reset "mynmi" flags to zero if code decides to not panic? Ivan Mironov (4): watchdog:

[RFC PATCH 4/4] watchdog: hpwdt: Make panic behaviour configurable

2019-01-13 Thread Ivan Mironov
This adds an option to not panic on NMI even if it was caused by iLO. Signed-off-by: Ivan Mironov --- drivers/watchdog/hpwdt.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index 95d002b5b120

Re: [PATCH v2 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-10 Thread Ivan Mironov
On Wed, 2019-01-09 at 15:52 +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 79e539453b34 DRM: i915: add mode setting support. > > The bot has tested the following trees: v4.20.0, v4.19.13, v4

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-07 Thread Ivan Mironov
On Mon, 2019-01-07 at 11:08 +0100, Daniel Vetter wrote: > > > > @@ -1654,6 +1712,40 @@ int drm_fb_helper_check_var(struct > > > > fb_var_screeninfo *var, > > > > return -EINVAL; > > > > } > > > > > > > > + /* > > > > +* Workaround for SDL 1.2, which is known

[PATCH v2 1/2] drm/fb-helper: Partially bring back workaround for bugs of SDL 1.2

2019-01-07 Thread Ivan Mironov
src/video/fbcon/SDL_fbvideo.c, FB_SetVideoMode() [2] http://www.fceux.com [3] Example ROM: https://github.com/bokuweb/rustynes/blob/master/roms/color_test.nes Reported-by: saahriktu Suggested-by: saahriktu Cc: sta...@vger.kernel.org Fixes: db05c48197759 ("drm: fb-helper: Reject all pixel format chang

[PATCH v2 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-07 Thread Ivan Mironov
with[2], remove /etc/fb.modes file if it exists, and then try to run sopwith from console without X. At least in Fedora 29, sopwith may be simply installed from standard repositories. [1] SDL 1.2.15 source code, src/video/fbcon/SDL_fbvideo.c, vesa_timings [2] http://sdl-sopwith.sourceforge.net/ Signed-

[PATCH v2 0/2] Fix SDL 1.2 on emulated fbdev devices (broken in kernels >=4.19)

2019-01-07 Thread Ivan Mironov
o not perform any guessing. Changes in v1: - Added "Cc: stable" to the patch which fixes known regression. - Added more information and detailed reproduction steps in commit messages. Changes in v0: - RFC patch series introduced. Ivan Mironov (2): drm/fb-helper: Partially bring back wor

Re: [PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2019-01-05 Thread Ivan Mironov
On Fri, 2018-12-28 at 13:06 +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 04:13:08AM +0500, Ivan Mironov wrote: > > Strict requirement of pixclock to be zero breaks support of SDL 1.2 > > which contains hardcoded table of supported video modes with non-zero > &

Re: [PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2019-01-05 Thread Ivan Mironov
On Fri, 2018-12-28 at 13:15 +0100, Daniel Vetter wrote: > On Fri, Dec 28, 2018 at 04:13:07AM +0500, Ivan Mironov wrote: > > SDL 1.2 sets all fields related to the pixel format to zero in some > > cases[1]. Prior to commit db05c48197759 ("drm: fb-helper: Reject all >

Re: [RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Ivan Mironov
On Thu, 2018-12-27 at 13:00 +0100, Daniel Vetter wrote: > > + /* > > +* Workaround for SDL 1.2, which is known to be setting all pixel format > > +* fields values to zero in some cases. We treat this situation as a > > +* kind of "use some reasonable autodetected values". > > +*/

[PATCH v1 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-27 Thread Ivan Mironov
src/video/fbcon/SDL_fbvideo.c, FB_SetVideoMode() [2] http://www.fceux.com [3] Example ROM: https://github.com/bokuweb/rustynes/blob/master/roms/color_test.nes Reported-by: saahriktu Suggested-by: saahriktu Cc: sta...@vger.kernel.org Fixes: db05c48197759 ("drm: fb-helper: Reject all pixel format chang

[PATCH v1 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2018-12-27 Thread Ivan Mironov
/fbcon/SDL_fbvideo.c, vesa_timings [2] http://sdl-sopwith.sourceforge.net/ Signed-off-by: Ivan Mironov --- drivers/gpu/drm/drm_fb_helper.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index aff576c3c4fb.

[PATCH v1 0/2] Fix SDL 1.2 on emulated fbdev devices (broken in kernels >=4.19)

2018-12-27 Thread Ivan Mironov
ch series introduced. Ivan Mironov (2): drm/fb-helper: Bring back workaround for bugs of SDL 1.2 drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock drivers/gpu/drm/drm_fb_helper.c | 153 +--- 1 file changed, 99 insertions(+), 54 deletions(-) -- 2.20.1

[RFC PATCH 1/2] drm/fb-helper: Bring back workaround for bugs of SDL 1.2

2018-12-26 Thread Ivan Mironov
saahriktu Suggested-by: saahriktu Fixes: db05c48197759 ("drm: fb-helper: Reject all pixel format changing requests") Signed-off-by: Ivan Mironov --- drivers/gpu/drm/drm_fb_helper.c | 146 1 file changed, 93 insertions(+), 53 deletions(-) diff --g

[RFC PATCH 2/2] drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock

2018-12-26 Thread Ivan Mironov
ported. It seems that any portable fbdev application which was not written only for one specific device working under one specific kernel version should not rely on any particular behaviour of pixclock anyway. [1] SDL 1.2.15 source code, src/video/fbcon/SDL_fbvideo.c, vesa_timings Signed-off-by: Iv

[RFC PATCH 0/2] Fix SDL 1.2 on emulated fbdev devices (broken in kernels >=4.19)

2018-12-26 Thread Ivan Mironov
positories. [1] http://sdl-sopwith.sourceforge.net/ Ivan Mironov (2): drm/fb-helper: Bring back workaround for bugs of SDL 1.2 drm/fb-helper: Ignore the value of fb_var_screeninfo.pixclock drivers/gpu/drm/drm_fb_helper.c | 153 +--- 1 file changed, 99 inserti

Re: [EXT] [PATCH v1] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
On Mon, 2018-12-24 at 14:26 +, Sudarsana Reddy Kalluru wrote: > Thanks a lot for root-causing the issue and the patch. > Another (simpler) way to address this would be to invoke > bnx2x_del_all_vlans() only for the newer chips, e.g., > + if (!CHIP_IS_E1(bp)) { > /* Remove all curr

[PATCH v2] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
in bnx2x_sp_objs.vlan_obj or not. This regression was introduced after v4.20-rc7, and still exists in v4.20 release. Fixes: 04f05230c5c13 ("bnx2x: Remove configured vlans as part of unload sequence.") Signed-off-by: Ivan Mironov --- v2: - As suggested by Sudarsana Reddy Kalluru, d

[PATCH v1] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
in bnx2x_sp_objs.vlan_obj or not. This regression was introduced after v4.20-rc7, and still exists in v4.20 release. Fixes: 04f05230c5c13 ("bnx2x: Remove configured vlans as part of unload sequence.") Signed-off-by: Ivan Mironov --- v1: - Check for chip num instead of (vlan_obj->de

Re: [PATCH] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-24 Thread Ivan Mironov
4.20 release is affected too. On Sun, 2018-12-23 at 20:29 +0500, Ivan Mironov wrote: > This happened when I tried to boot normal Fedora 29 system with latest > available kernel (from fedora rawhide, plus some unrelated custom > patches): > > BUG: unable to handle kern

[PATCH] bnx2x: Fix NULL pointer dereference in bnx2x_del_all_vlans() on some hw

2018-12-23 Thread Ivan Mironov
emove configured vlans as part of unload sequence.") Signed-off-by: Ivan Mironov --- .../net/ethernet/broadcom/bnx2x/bnx2x_main.c | 22 +-- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c b/drivers/net/ethernet/broa

[PATCH] scsi: sd: Fix cache_type_store()

2018-12-22 Thread Ivan Mironov
gt;cache_type bash: echo: write error: Invalid argument And following appears in dmesg: [13007.865745] sd 1:0:1:0: [sda] Sense Key : Illegal Request [current] [13007.865753] sd 1:0:1:0: [sda] Add. Sense: Invalid field in parameter list Signed-off-by: Ivan Mironov --- driv

Re: [PATCH 0/6] Add support of the HBA mode on HP Smart Array P410i controllers

2018-12-14 Thread Ivan Mironov
On Fri, 2018-12-14 at 19:38 +, don.br...@microchip.com wrote: > NAKing this series. > - The P410 controllers do not fully support HBA mode and we do not support > adding it to the hpsa driver. > Could you please elaborate on what exactly you mean by "do not fully support HBA mode"? HBA mode

[PATCH 2/6] scsi: hpsa: Support HBA mode on HP Smart Array P410i controllers

2018-12-14 Thread Ivan Mironov
using the new module parameter. [1] https://support.hpe.com/hpsc/swd/public/detail?swItemId=MTX_0b76aec489764aea9802a6d27b [2] https://github.com/im-0/hpsahba [3] https://github.com/osandov/blktests [4] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git Signed-off-by: Ivan Mironov --- drivers

[PATCH 0/6] Add support of the HBA mode on HP Smart Array P410i controllers

2018-12-14 Thread Ivan Mironov
blktests[1] and xfstests[2]. To make sure that this new functionality does not break anything, it is disabled by default and may be enabled only manually using new module parameter. [1] https://github.com/osandov/blktests [2] https://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git Ivan Mironov (6

[PATCH 1/6] scsi: hpsa: Add function to check if device is a disk or a zoned device

2018-12-14 Thread Ivan Mironov
This check is used multiple times within the driver. New function makes conditional statements a bit shorter and more readable. Signed-off-by: Ivan Mironov --- drivers/scsi/hpsa.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/hpsa.c b

[PATCH 6/6] scsi: hpsa: Do not use HBA flag from NVRAM if HBA is not supported

2018-12-14 Thread Ivan Mironov
Check bmic_identify_controller.yet_more_controller_flags for HBA support bit before trying to enable HBA mode. HP's ssacli tool calls this bit "Hba Mode Supported" in full diagnostics report. Signed-off-by: Ivan Mironov --- drivers/scsi/hpsa.c | 16 ++-- drivers/

[PATCH 3/6] scsi: hpsa: Add/mask existing devices on rescan if visibility changes

2018-12-14 Thread Ivan Mironov
physical disks. Signed-off-by: Ivan Mironov --- drivers/scsi/hpsa.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index ee3d7c722a63..60f1f7949d8d 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.c @@ -1541,6 +1541,14 @@ static

[PATCH 4/6] scsi: hpsa: Ignore HBA flag from NVRAM if logical devices exist

2018-12-14 Thread Ivan Mironov
Simultaneous use of physical devices and logical RAID devices may be dangerous. Signed-off-by: Ivan Mironov --- drivers/scsi/hpsa.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 60f1f7949d8d..0b5b3a651b70

[PATCH 5/6] scsi: hpsa: Name more fields in "struct bmic_identify_controller"

2018-12-14 Thread Ivan Mironov
Based on information from "struct identify_controller" from cciss_vol_status.c from the cciss_vol_status tool[1]. [1] https://sourceforge.net/projects/cciss/files/cciss_vol_status/ Signed-off-by: Ivan Mironov --- drivers/scsi/hpsa_cmd.h | 109 ++