Hi,
On Wed, 14 Apr 2021, Salvatore Bonaccorso
wrote:
Hi Ioan-Adrian,
On Wed, Apr 07, 2021 at 02:47:24PM +0200, Alessandro Grassi
wrote:
Source: linux Severity: normal Tags: upstream X-Debbugs-Cc:
alessan...@aggro.it Greetings, I am encountering the issue
described in this thread[1], usi
Hi Stefan and thank you for looking into this,
On Sun, 27 Jan 2019, Stefan Wahren wrote:
Hi Ioan-Adrian,
Ioan-Adrian Ratiu hat am 27. Januar 2019 um
21:28 geschrieben: This reverts commit
bea8a160c621d19f7f78b13e14e03f4b8e44cd4b. Contrary to what
the commit message says, on my rpi 3 b
Link to the full 4.19.18 config I'm using:
https://drive.google.com/open?id=1ZI3MeGB2fkYMsEjzGQYXUk2wqr0h9h7R
On Sun, 27 Jan 2019, Ioan-Adrian Ratiu wrote:
This reverts commit bea8a160c621d19f7f78b13e14e03f4b8e44cd4b.
Contrary to what the commit message says, on my rpi 3 b v1.2 changin
, abort command and
terminate frame
The only solution I currently have is to revert and everything works
as expected and as before changing the polarity.
Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
Signed-off-by: Ioan-Adrian Ratiu
---
arch/arm/boot/dts/bcm2837-rpi-3-b-plus.dts
ed-off-by: Ioan-Adrian Ratiu
---
drivers/usb/dwc2/core.h | 5 +++--
drivers/usb/dwc2/platform.c | 46 +++--
2 files changed, 35 insertions(+), 16 deletions(-)
diff --git a/drivers/usb/dwc2/core.h b/drivers/usb/dwc2/core.h
index cd77af3b1565..c50b9fc4a1
583bb ("Revert "ALSA: usb-audio: Fix race at stopping the
stream"")
Signed-off-by: Ioan-Adrian Ratiu
---
sound/usb/endpoint.c | 17 +++--
sound/usb/endpoint.h | 2 +-
sound/usb/pcm.c | 10 +-
3 files changed, 13 insertions(+), 16 deletions(-)
diff
Testing EP_FLAG_RUNNING in snd_complete_urb() before running the completion
logic allows us to save a few cpu cycles by returning early, skipping the
pending urb in case the stream was stopped; the stop logic handles the urb
and sets the completion callbacks to NULL.
Signed-off-by: Ioan-Adrian
Changes since v2:
* Fixed snd_usb_*lock_shutdown imbalance caused by an early return
in snd_usb_pcm_prepare()
Ioan-Adrian Ratiu (2):
ALSA: usb-audio: Fix irq/process data synchronization
ALSA: usb-audio: test EP_FLAG_RUNNING at urb completion
sound/usb/endpoint.c | 20
On Wed, 04 Jan 2017, Takashi Iwai wrote:
> On Mon, 02 Jan 2017 16:50:30 +0100,
> Ioan-Adrian Ratiu wrote:
>>
>> --- a/sound/usb/pcm.c
>> +++ b/sound/usb/pcm.c
> (snip)
>> @@ -850,7 +850,7 @@ static int snd_usb_pcm_prepare(struct snd_pcm_substream
>> *sub
On Tue, 03 Jan 2017, Ioan-Adrian Ratiu wrote:
> On Mon, 02 Jan 2017, Ioan-Adrian Ratiu wrote:
>> Many thanks to Takashi Iwai & Sakamoto for their awesome feedback.
>>
>> Changes since v1:
>> * Rebased my fix on top of tiwai's revert and integrated the
On Mon, 02 Jan 2017, Ioan-Adrian Ratiu wrote:
> Many thanks to Takashi Iwai & Sakamoto for their awesome feedback.
>
> Changes since v1:
> * Rebased my fix on top of tiwai's revert and integrated the changes
> from the original fix into this.
> * Droppe
reviously existing snd_usb_endpoint_sync_pending_stop() call.
* Retained the deactivate_urbs() call in snd_usb_pcm_prepare(), I only
removed the can_sleep logic.
* Split the EP_FLAG_RUNNING check in a separate commit to keep the log
clean since this is not part of the race fix.
Ioan-Adr
Testing EP_FLAG_RUNNING in snd_complete_urb() before running the completion
logic allows us to save a few cpu cycles by returning early, skipping the
pending urb in case the stream was stopped; the stop logic handles the urb
and sets the completion callbacks to NULL.
Signed-off-by: Ioan-Adrian
583bb ("Revert "ALSA: usb-audio: Fix race at stopping the
stream"")
Signed-off-by: Ioan-Adrian Ratiu
---
sound/usb/endpoint.c | 17 +++--
sound/usb/endpoint.h | 2 +-
sound/usb/pcm.c | 10 +-
3 files changed, 13 insertions(+), 16 deletions(-)
diff
On Fri, 30 Dec 2016, Takashi Iwai wrote:
> On Wed, 21 Dec 2016 11:38:54 +0100,
> Ioan-Adrian Ratiu wrote:
>>
>> >> > Please take the time to fully analyze my patch and let's have a
>> >> > discussion based on it, not reject it outright and repla
Hi
On Wed, 21 Dec 2016, Takashi Iwai wrote:
> On Tue, 20 Dec 2016 14:04:56 +0100,
> Takashi Sakamoto wrote:
>>
>> Hi,
>>
>> On Dec 20 2016 20:47, Ioan-Adrian Ratiu wrote:
>> > On Tue, 20 Dec 2016, Takashi Sakamoto wrote:
>> >> ---
>>
; applied for PCM playback substream.
>
> Below workaround can also suppress this bug.
>
> diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
> index a2cdf33..9b34f76 100644
> --- a/sound/usb/endpoint.c
> +++ b/sound/usb/endpoint.c
> @@ -537,11 +537,14 @@ static int wai
9f4bc10
[ 131.184562] CR2: 0010
[1] 041e:3232 Creative Technology SoundBlaster X-FI HD
[2]
http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/115425.html
Signed-off-by: Ioan-Adrian Ratiu
---
sound/usb/endpoint.c | 11 ++-
sound/usb/endpoint.h | 2 +-
sound
On Tue, 27 Sep 2016, Ioan-Adrian Ratiu wrote:
> This reverts commit 18339f59c3a6 ("HID: dragonrise: fix HID...") because it
> breaks certain dragonrise 0079:0006 gamepads. While it may fix a breakage
> caused by commit 79346d620e9d ("HID: input: force generic axis to b
On Wed, 28 Sep 2016, Vladislav Naumov wrote:
> On Tue, Sep 27, 2016 at 10:44 PM, Ioan-Adrian Ratiu wrote:
>> Can you please wait a little until I post v2 later today and test v2
>> directly? Because the change in it's current form has no effect on
>> 0079:0011 (the cur
, but since
only one hardware vendor seems to be affected negatively we're better off
making and exception and mapping in the driver for now; if more vendors or
drivers turn out to experience the problem we should reconsider the quirk
solution.
Signed-off-by: Ioan-Adrian Ratiu
---
e
need to add an exception for this driver to make it keep the old behaviour
previous to the initial breakage (this is done in patch 2 of this series).
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/hid/hid-dr.c | 58
1 file changed, 58 deletions(-)
still have this particular device?
>>
>>
>> I never had it, but perhaps Vladislav still has some.
>>
>> Vladislav, would you be able to test a change to the kernel module for your
>> Dragonrise gamepads?
>>
>> Please see below for context.
>>
&
spend a weekend night digging through this crap because my fiancee
came crying to me that her gamepad stopped working after a kernel update.
>
> On Sep 26 2016 or thereabouts, Ioan-Adrian Ratiu wrote:
>> This reverts commit 18339f59c3a6 ("HID: dragonrise: fix HID...")
>> b
n_Volatile
Bitfield
Item(Main ): End Collection, data=none
Item(Main ): End Collection, data=none
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/hid/hid-dr.c | 58
1 file changed, 58 deletions(-)
diff --git a/drivers
t
needs to continue to handle this hardware as expected before the forcing
to provide the same interface to userspace.
Since these lower-end gamepads like 0079:0006 are definitely the exception,
create a quirk to fix them.
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/hid/hid-dr.c| 2 ++
drive
ntrib/commit/?h=zedd/kernel&id=87a9f321035428d9f4f8859ff99bb9acb70bd60c
Signed-off-by: Ioan-Adrian Ratiu
---
scripts/kconfig/merge_config.sh | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/scripts/kconfig/merge_config.sh b/scripts/kconfig/merge_config.sh
index 67d1
On Mon, 22 Aug 2016, Kalle Valo wrote:
> Benjamin Berg writes:
>
>> On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote:
>>> Actually, I see two patches which might be related but not identical:
>>>
>>> ath9k: fix client mode beacon configuration
>>> https://patchwork.kernel.org/patch/9247699/
>>
0x960
>>> [ 16.910848] [] ? ieee80211_iface_work+0xd4/0x410
>>> [mac80211]
>>> [ 16.910865] [] ieee80211_iface_work+0x295/0x410
>>> [mac80211]
>>> [ 16.910870] [] ? finish_task_switch+0x77/0x1e0
>>> [ 16.910875] [] process_one_work+
9/0xe0
[ 16.910894] [] ? __switch_to+0x2c3/0x610
[ 16.910899] [] ret_from_fork+0x1f/0x40
[ 16.910902] [] ? kthread_create_on_node+0x40/0x40
[ 16.910904] ---[ end trace aa169ad4461f2f18 ]---
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/net/wireless/ath/ath9k/main.c | 9 +
1 file c
On Fri, 20 Nov 2015 22:19:02 +0200
Ioan-Adrian Ratiu wrote:
> The critical section protected by usbhid->lock in hid_ctrl() is too
> big and because of this it causes a recursive deadlock. "Too big" means
> the case statement and the call to hid_input_report() do not need to
if (!strncmp(drv->name, "serial", 6)) {
tracing_change_tracer("function_graph");
tracing_on();
}
Signed-off-by: Ioan-Adrian Ratiu
---
include/linux/kernel.h | 5 +
kernel/trace/trace.c | 56 +++
n grab the lock afterwards in hid_ctrl().
This patch implements the 2nd solution.
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/hid/usbhid/hid-core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c
index 36712e9.
On Thu, 19 Nov 2015 22:34:18 +0100 (CET)
Jiri Kosina wrote:
> Could you please reformulate the changelog in this respect and resubmit?
Yes, of course, I tried to reformulate the problem and solution as clear and
succint as I could in v2, which I'll send shortly.
Thank you very much for your pati
On Thu, 19 Nov 2015 10:10:19 +0100 (CET)
Jiri Kosina wrote:
> On Thu, 19 Nov 2015, Ioan-Adrian Ratiu wrote:
>
> > First part of lockdep report:
> > http://imgur.com/clLsCWe
> >
> > Second part:
> > http://imgur.com/Wa2PzRl
> >
> > Here are som
On Wed, 18 Nov 2015 17:58:56 -0600
Josh Cartwright wrote:
> On Wed, Nov 18, 2015 at 11:05:44PM +0200, Ioan-Adrian Ratiu wrote:
> > On Wed, 18 Nov 2015 21:37:42 +0100 (CET)
> > Jiri Kosina wrote:
> >
> > > On Wed, 18 Nov 2015, Ioan-Adrian Ratiu wrote:
> &g
On Wed, 18 Nov 2015 21:37:42 +0100 (CET)
Jiri Kosina wrote:
> On Wed, 18 Nov 2015, Ioan-Adrian Ratiu wrote:
>
> > The critical section protected by usbhid->lock in hid_ctrl() is too
> > big and in rare cases causes a recursive deadlock because of its call
&g
Here are some images with more information on this deadlock, might be helpful.
First part of lockdep report:
http://imgur.com/clLsCWe
Second part:
http://imgur.com/Wa2PzRl
Here are some printk's of mine while reproducing + debugging the issue:
http://imgur.com/SETOHT7
--
To unsubscribe from this
to grab the lock resulting in a recursive deadlock.
The proper fix is to shrink the critical section in hid_ctrl() to
protect only the instructions which modify usbhid, thus move the lock
after the hid_input_report() call and the deadlock dissapears.
Signed-off-by: Ioan-Adrian Ratiu
---
driv
One branch of the if clause uses pr_info, the other pr_err; change
the 'false' branch to also use pr_info. This minor oversight has gone
unfixed since the initial vga_switcheroo implementation in 6a9ee8af.
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/gpu/drm/i915/i915_dma.c | 2
On Fri, 14 Aug 2015 18:50:24 -0700
Greg KH wrote:
> On Fri, Aug 14, 2015 at 12:57:06PM +0300, Ioan-Adrian Ratiu wrote:
> > Without including ptlrpc_internal.h, GCC gives prototype warnings
> > "pack_generic.c:642:5: warning: no previous prototype for ..."
>
> It
Without including ptlrpc_internal.h, GCC gives prototype warnings
"pack_generic.c:642:5: warning: no previous prototype for ..."
and sparse also complains "pack_generic.c:642:5: warning: symbol
'lustre_unpack_req_ptlrpc_body' was not declared. ..."
Signed-off-by: I
Remove macro and use explicit case statements. Code is a little
longer but clearer. Checkpatch.pl does not complain anymore.
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/staging/rtl8192e/rtllib_rx.c | 80 +++-
1 file changed, 52 insertions(+), 28 deletions
Enclose defined macro in paranthesis to avoid checkpatch complaint
"ERROR: Macros with complex values should be enclosed in parentheses"
Signed-off-by: Ioan-Adrian Ratiu
---
drivers/staging/rtl8192e/rtllib_rx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drive
44 matches
Mail list logo
