Problematic culture around Signed-off-by

2017-07-21 Thread Ian Molton
Hi folks, I've been away from kernel development for a bit, but I've returned and I'm troubled by what seems to be an entrenched and widespread (IMO) misuse of the "Signed-off-by:" in commits. I've now either been asked to sign off RFC quality patches "because its quicker" on more than one occasi

Re: [PATCH] mmc: tmio: Fix hang during suspend

2014-08-15 Thread Ian Molton
> + unsigned int f; > + pdata->clk_enable(host->pdev, &f); > + } > > tmio_mmc_disable_mmc_irqs(host, TMIO_MASK_ALL); > + > + if (pdata->clk_disable) > + pdata->clk_disable(host->pdev); > + > return 0; > } > EXPORT_SYMBOL(tmio_mmc_h

Re: [PATCH] MAINTAINERS: mmc: Update email for host driver maintainer

2014-05-12 Thread Ian Molton
On Fri, 9 May 2014 15:10:51 +0200 Ulf Hansson wrote: > On 8 May 2014 17:37, Ben Dooks wrote: > > On Thu, May 08, 2014 at 11:24:58AM +0200, Ulf Hansson wrote: > >> Update Ian Molton's email, the maintainer for tmio/sh_mobile_sdhci. > >> > >> Cc: Ia

Re: [PATCH] udivdi3: 64 bit divide

2007-03-01 Thread Ian Molton
Jan Engelhardt wrote: The non-arch specific code does not use 64/64 divides through the "/" operator (otherwise there would already have been udivdi3 linking errors). So what remains to check is arch/arm26. grep -Pr 'int64|\bu64' returns only a few results to check (kernel/ecard.c, nwfpe/), so t

Re: [PATCH] udivdi3: 64 bit divide

2007-02-27 Thread Ian Molton
Russell King wrote: On Tue, Feb 27, 2007 at 01:36:56PM -0800, Andrew Morton wrote: On Tue, 27 Feb 2007 13:18:40 -0800 Stephen Hemminger <[EMAIL PROTECTED]> wrote: Then we should pull the existing udivdi3 implementations? Not much point really. Some architectures have gone and done that, but x

Re: [PATCH 2.6.20] arch ARM: Use ARRAY_SIZE macro when appropriate

2007-02-05 Thread Ian Molton
Ahmed S. Darwish wrote: Hi all, A patch to use ARRAY_SIZE macro already defined in linux/kernel.h Looks good. I can only speak for arm26 though, however trivial this is. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> Acked-by: Ian Molton <[EMAIL PROTECTED] --- Patch isn&

Re: [PATCH 2.6.19] arm26: replace kmalloc+memset with kzalloc

2006-12-02 Thread Ian Molton
Yan Burman wrote: Replace kmalloc+memset with kzalloc > Acked-by: Ian Molton <[EMAIL PROTECTED]> Signed-off-by: Yan Burman <[EMAIL PROTECTED]> diff -rubp linux-2.6.19-rc5_orig/arch/arm26/kernel/ecard.c linux-2.6.19-rc5_kzalloc/arch/arm26/kernel/ecard.c --- linux-2.6.19-rc5_

PATCH add support for system on chip (SoC) devices.

2005-04-08 Thread Ian Molton
#define MEDIAQ_11XX_SPI_DEVICE_ID 0x0305 +#define MEDIAQ_11XX_I2S_DEVICE_ID 0x0306 + +/* ATI W3220 devices */ +#define ATI_W3220_FB_DEVICE_ID 0x0401 +#define ATI_W3220_USB_DEVICE_ID 0x0402 + +/* Toshiba T7L66XB TC6393XB etc. devices (aka, tmio) */ +#define TMIO_NAND_DEVICE_I

Re: [PATCH 4/6] freepgt2: arm26 FIRST_USER_ADDRESS PAGE_SIZE

2005-04-06 Thread Ian Molton
Hugh Dickins wrote: ARM26 define FIRST_USER_ADDRESS as PAGE_SIZE (beyond the machine vectors when they are mapped low), and use that definition in place of locally defined MIN_MAP_ADDR. Previously, ARM26 permitted user mappings at 0 if the machine vectors were mapped high; but that's inconsistent

Re: [PATCH 1/6] freepgt: free_pgtables use vma list

2005-03-30 Thread Ian Molton
David Howells wrote: I suspect Ian can live without his printk! I expect so, since arm26 doesnt boot yet. Hopefully once I get my current load of arm32 stuff done I'll get some time to revisit it. arm26 mm is quite broken right now. - To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH][MMC] Secure Digital (SD) support

2005-03-04 Thread Ian Molton
Pierre Ossman wrote: I would if I had some hardware to play with *hint* *hint* ;) Same here. I have some basic chipset docs. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordo

Initialisation sequencing.

2005-03-02 Thread Ian Molton
Hi. I have a problem. It affects both modular and non modular builds, and I dont see an obviously correct solution. The problem is that I have a video chip which supports some GPIOs and an LCD display. some LCD functions are controlled via the GPIOs, like backlighting. so the driver is split in

Re: [PATCH] Use MM_VM_SIZE in exit_mmap

2005-01-25 Thread Ian Molton
Anton Blanchard wrote: > As an aside, all architectures except one define FIRST_USER_PGD_NR as 0: > > include/asm-arm26/pgtable.h:#define FIRST_USER_PGD_NR 1 All processes on arm26 must map the same page 0 as its where the SWI vector table goes. The vector table is located at address 0, and

Re: MMC Driver RFC

2005-01-16 Thread Ian Molton
Pierre Ossman wrote: Ian Molton wrote: Afraid everything gets routed to the same account in the end anyway. I checked the logs and the problem is that your mail server has a HELO that differs from its IP I've sent mail to my ISP re that. cheers. I've had the same idea. But I think